)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"83950fc7d0314f5d6cc9b4bcadfdeaea016b20e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69d801b8_a2aac30d","updated":"2023-07-04 12:18:16.000000000","message":"Thank you Renan. Besides Luisa comments, the fix LGTM.\n\nEven though Felipe\u0027s comment says the reason to create the temp_share [1], I think is good to mention it in the commit message.\n\n[1] https://bugs.launchpad.net/manila/+bug/1922512","commit_id":"1b580ea2e1955895cc66fb271dd8f5babb849a9e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"65ac60d470d1ad91091f29e4ed97dbf7aa406cae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"405702d3_eb47ae4d","updated":"2023-08-01 22:02:23.000000000","message":"Looking good, thanks for the fix Renan!\nCan we get some NetApp CI test results? :)","commit_id":"69efb9ae5329cf5487273cd4281219880b90070e"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"e1c4eb03899013153f17d049610026cbaba825f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f345409f_2bda85ce","updated":"2023-07-26 13:23:50.000000000","message":"Thanks for the point, fixed","commit_id":"69efb9ae5329cf5487273cd4281219880b90070e"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"c6235e48073afeeaf247024b464abbeb1960d3f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"661cbbea_6b5b1bd3","updated":"2023-07-27 19:53:45.000000000","message":"Thanks, Renan. LGTM","commit_id":"69efb9ae5329cf5487273cd4281219880b90070e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2132875ba137cfd011bdcb15e91c35a821ce0212","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1770d6aa_e2778802","updated":"2023-07-27 05:37:02.000000000","message":"run-NetApp CI","commit_id":"69efb9ae5329cf5487273cd4281219880b90070e"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":33756,"name":"Luisa","email":"luisarfamaral@gmail.com","username":"rfluisa"},"change_message_id":"3255b57e2e199220055c031916c4a1f05471de7d","unresolved":true,"context_lines":[{"line_number":810,"context_line":"            # NOTE(felipe_rodrigues): no support to move volumes that are"},{"line_number":811,"context_line":"            # FlexGroup or without the cluster credential. So, performs the"},{"line_number":812,"context_line":"            # workaround using snapmirror even being in the same cluster."},{"line_number":813,"context_line":"            temp_share \u003d dest_share"},{"line_number":814,"context_line":"            if (src_cluster_name !\u003d dest_cluster_name or dest_is_flexgroup or"},{"line_number":815,"context_line":"                    not self._have_cluster_creds):"},{"line_number":816,"context_line":"                # 1. Create a clone on source (temporary volume). We don\u0027t need"}],"source_content_type":"text/x-python","patch_set":1,"id":"643d4ef6_5384df0a","line":813,"updated":"2023-07-03 20:47:53.000000000","message":"Thanks for the code, Renan! Everything looks good, but I don\u0027t understand the purpose of this line. Looks like temp_share is only used inside the if.","commit_id":"1b580ea2e1955895cc66fb271dd8f5babb849a9e"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"f0e55f8513739ff71aa5035e0925ef902fd6391a","unresolved":true,"context_lines":[{"line_number":810,"context_line":"            # NOTE(felipe_rodrigues): no support to move volumes that are"},{"line_number":811,"context_line":"            # FlexGroup or without the cluster credential. So, performs the"},{"line_number":812,"context_line":"            # workaround using snapmirror even being in the same cluster."},{"line_number":813,"context_line":"            temp_share \u003d dest_share"},{"line_number":814,"context_line":"            if (src_cluster_name !\u003d dest_cluster_name or dest_is_flexgroup or"},{"line_number":815,"context_line":"                    not self._have_cluster_creds):"},{"line_number":816,"context_line":"                # 1. Create a clone on source (temporary volume). We don\u0027t need"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2233eb7_00c0d944","line":813,"in_reply_to":"643d4ef6_5384df0a","updated":"2023-07-25 18:58:47.000000000","message":"+1\n\nIt seems to me that this line could be removed.","commit_id":"1b580ea2e1955895cc66fb271dd8f5babb849a9e"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"e1c4eb03899013153f17d049610026cbaba825f2","unresolved":false,"context_lines":[{"line_number":810,"context_line":"            # NOTE(felipe_rodrigues): no support to move volumes that are"},{"line_number":811,"context_line":"            # FlexGroup or without the cluster credential. So, performs the"},{"line_number":812,"context_line":"            # workaround using snapmirror even being in the same cluster."},{"line_number":813,"context_line":"            temp_share \u003d dest_share"},{"line_number":814,"context_line":"            if (src_cluster_name !\u003d dest_cluster_name or dest_is_flexgroup or"},{"line_number":815,"context_line":"                    not self._have_cluster_creds):"},{"line_number":816,"context_line":"                # 1. Create a clone on source (temporary volume). We don\u0027t need"}],"source_content_type":"text/x-python","patch_set":1,"id":"f71abdee_91722125","line":813,"in_reply_to":"d2233eb7_00c0d944","updated":"2023-07-26 13:23:50.000000000","message":"Done","commit_id":"1b580ea2e1955895cc66fb271dd8f5babb849a9e"}]}