)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"ef7723a1f3f6a77aa8e6f2c3597284571ec6edc5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d13df583_9336a894","updated":"2023-09-20 10:40:54.000000000","message":"There is a typo error on models.Share attribute. Please fix that.","commit_id":"5a6115e166bca1520470da2d78a4775585bd2fae"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"bf017ac0d88283829183a5d97d6b1be536a3d417","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fefa5b2_34395ccd","updated":"2023-09-20 07:00:04.000000000","message":"recheck","commit_id":"5a6115e166bca1520470da2d78a4775585bd2fae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6ad0efc5f84d29624258d8759807a6c5220b7d34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99deee86_1fd20ed9","updated":"2023-09-19 15:05:32.000000000","message":"recheck\nLogs are gone","commit_id":"5a6115e166bca1520470da2d78a4775585bd2fae"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"b1d1e656844f7af046bec6760cf01c9ba539f153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9be728c7_e20c4c9f","in_reply_to":"d13df583_9336a894","updated":"2023-09-20 11:43:34.000000000","message":"Resolved","commit_id":"5a6115e166bca1520470da2d78a4775585bd2fae"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"ed23f1a9f5cf569527befbeba93a48475004e3fa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fefe509_435d1b05","updated":"2023-09-20 14:05:47.000000000","message":"Thanks for the patch, Helena and Saikumar. Need to correct the name of the release note.","commit_id":"2cabd4388be0979481ffa0b02a0e7a4eead21a88"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"a9b373891ee66c6080b911302e5c2dcd1593ee84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf23e52a_54333882","in_reply_to":"3fefe509_435d1b05","updated":"2023-09-20 14:46:20.000000000","message":"Thank you Thiago. Added new release notes. Please do verify.","commit_id":"2cabd4388be0979481ffa0b02a0e7a4eead21a88"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"9ea2eb9d635a0c21ee82dd5ce1faa5448849c538","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d852b9ee_8b98951f","in_reply_to":"bf23e52a_54333882","updated":"2023-09-20 17:28:46.000000000","message":"Thanks Saikumar","commit_id":"2cabd4388be0979481ffa0b02a0e7a4eead21a88"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"9ea2eb9d635a0c21ee82dd5ce1faa5448849c538","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e22719e7_76b473a0","updated":"2023-09-20 17:28:46.000000000","message":"LGTM","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"b31a4ebf2546d33f86138c900569e96136fbae96","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"faed5812_37bf58b1","updated":"2023-09-21 10:46:57.000000000","message":"Looks good. I have only one input on making sure the functionality works post the change. As I see the patch has problem on using one of the attribute, which you fixed, I look forward to see data on how the objects listed before and after the change + new operations like \u0027create DHSS\u003dtrue share\u0027 workflow.","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"f96e70b8e96a0646a712b01a46eae5dd45acd5a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef0caa2a_5b23e102","updated":"2023-09-21 11:56:56.000000000","message":"Overall looks code. Please, fix the release note. Also, NetApp DHSS is not passing, please, try to make it pass.","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"56f42143091fc3f1dd4d0eb1a96c3aed7964cee9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"577d00ab_cb9a9c5b","updated":"2023-09-21 10:56:08.000000000","message":"We need UT for the newly changes. You can plan it as part of this, or plan it via separate patch. Need approvals from core team if UT exception is needed.","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"b6b88518806e23ea8b8b5d2b519bff697b319f2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dbbfb267_0f10359f","updated":"2023-09-21 06:29:26.000000000","message":"run-NetApp CI","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"48402baf5ad2816b06c255839a3811750490556e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6f1ddc1_6fe539bd","in_reply_to":"577d00ab_cb9a9c5b","updated":"2023-09-21 11:20:22.000000000","message":"\u003e We need UT for the newly changes. You can plan it as part of this, or plan it via separate patch. Need approvals from core team if UT exception is needed.","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"ea3d4b9f1e84f916df7f3a63b453eebceefbd66e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"76e8d24e_dfff8da6","in_reply_to":"faed5812_37bf58b1","updated":"2023-09-21 11:18:23.000000000","message":"Thank you Saravanan. I have performed light manual sanity testing, focusing creating/listing of shares (with dhss_true) with and without patch changes. I don\u0027t see any regression in listing shares, share-servers, share-istances, share_networks, share-instance-export-locations with my simple configuration.","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"1aabbbce5241f53cfca641149d95d391da2a7c3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8a32045a_d923bc09","updated":"2023-09-26 05:49:02.000000000","message":"run-NetApp CI","commit_id":"a449aa615eb7b901d60eb1765f610cf58075752c"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"d24f91a7847f5d8e24fa142e4338c608c1fcada8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a7cd2cdd_2e51f3d8","updated":"2023-09-25 06:19:24.000000000","message":"run-NetApp CI","commit_id":"a449aa615eb7b901d60eb1765f610cf58075752c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a843bb92cf6e1382a460fa239ea8cfbd38df567d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ea8516e7_5333e5ad","updated":"2023-09-22 20:41:58.000000000","message":"thanks for proposing this change Helena; and for improving it Saikumar. it\u0027s going to be tricky unit-testing this.. but, we use a different mechanism for this; it\u0027s using openstack/rally... \n\nhere\u0027s the output of the \"list share servers\" test that we have, with this patch: https://947c62482e8e55a27073-47560c94aca274da9e9228ef37db57ef.ssl.cf1.rackcdn.com/884592/6/check/manila-rally-ss/e07c2cb/results/report.html#/ManilaShares.list_share_servers/overview\n\n```\nLoad duration: 1.363 s   Full duration: 7.560 s   Iterations: 10   Failures: 0   Started at: 2023-09-21T17:30:58\n```\n\nFor 10 records; the total duration seems pretty bad to me. \n\nIn stable/xena (the version Maurice\u0027s using), the test loads share servers much faster:\n\nhttps://zuul.opendev.org/t/openstack/build/d0cc2c2349254ae590916b304d951bda/logs\nhttps://aeac574290c9b97c3e81-a7f569a782a7e2ea53192935cb483111.ssl.cf5.rackcdn.com/885213/9/check/manila-rally-ss/d0cc2c2/results/report.html\n\n```\nLoad duration: 0.493 s   Full duration: 2.802 s   Iterations: 10   Failures: 0   Started at: 2023-09-22T16:03:37\n```\n\nIn stable/zed:\n\nhttps://zuul.opendev.org/t/openstack/build/9270aa50c0a241dbaf1a4222dacf003d/logs\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_927/891757/2/check/manila-rally-ss/9270aa5/results/report.html\n\n```\nLoad duration: 0.519 s   Full duration: 2.687 s   Iterations: 10   Failures: 0   Started at: 2023-09-22T05:59:52\n```\n\nIn stable/2023.1, the performance fell; and is close to what we\u0027re seeing now:\n\nhttps://d86090b7d54df0827d49-db3d40af5818e6e3e7d50951d8a4c856.ssl.cf1.rackcdn.com/895029/1/check/manila-rally-ss/a7e052f/results/report.html#/ManilaShares.list_share_servers\n\n```\nLoad duration: 1.221 s   Full duration: 7.391 s   Iterations: 10   Failures: 0   Started at: 2023-09-21T01:50:06\n```\n\n\nIs it possible for you to confirm with this tool/test if you\u0027re seeing similar results locally? \n\nThe query linked in Maurice\u0027s report (https://bugs.launchpad.net/manila/+bug/1964089): https://paste.opendev.org/show/bWQWZKPi5TIezltlKkx2/\nseems very complicated and unoptimized..","commit_id":"a449aa615eb7b901d60eb1765f610cf58075752c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03bf26a08addc11a2102e54583c7ef737cc46b3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"327e0dee_db4fd0f3","in_reply_to":"79d668f0_87ba42d5","updated":"2024-07-11 20:49:59.000000000","message":"Hey, Sai! Have you guys managed to check on the query enhancements?","commit_id":"a449aa615eb7b901d60eb1765f610cf58075752c"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"088d48a542ae7f4c077ccd4ff244b9f95f9cf4f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"79d668f0_87ba42d5","in_reply_to":"ea8516e7_5333e5ad","updated":"2023-10-06 12:20:18.000000000","message":"Hi Goutham,\n\nHave tried below 3 scenarios locally for the same config of 25 share servers on all setups,\n \nScenario-1: Get share-server-list response times on latest devstack\nLoad duration: 7.068743 Full duration: 8.785801 Iterations: 10   Failures: 0   Started at: 2023-10-04T18:33:20\n\nScenario-2: Get share-server-list response times on latest devstack with patch changes\nLoad duration: 8.572911 Full duration: 10.335756 Iterations: 10   Failures: 0   Started at: 2023-10-04T23:10:10\n\nScenario-3: Get share-server-list response times on stable/xena\nLoad duration: 10.974866 Full duration: 13.456959  Iterations: 10   Failures: 0   Started at: 2023-10-05T16:22:15\n\nPlease refer below link for complete results,\nhttps://paste.opendev.org/show/bBJ5R66hC3a4JanqoFGh/\n\nSummary: Based on the manual results, performance was low on xena and it improved on master but degraded on patch. \n         We are looking at modifying queries to improve the performance.","commit_id":"a449aa615eb7b901d60eb1765f610cf58075752c"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"ef7723a1f3f6a77aa8e6f2c3597284571ec6edc5","unresolved":true,"context_lines":[{"line_number":1769,"context_line":"    if is_soft_deleted:"},{"line_number":1770,"context_line":"        query \u003d query.filter(models.Share.is_softdeleted.is_(True))"},{"line_number":1771,"context_line":"    else:"},{"line_number":1772,"context_line":"        query \u003d query.filter(models.Share.is_softdeleted.is_(False))"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":"    instance_ids \u003d filters.get(\u0027instance_ids\u0027)"},{"line_number":1775,"context_line":"    if instance_ids:"}],"source_content_type":"text/x-python","patch_set":2,"id":"11088b97_f92c83dc","line":1772,"range":{"start_line":1772,"start_character":42,"end_line":1772,"end_character":56},"updated":"2023-09-20 10:40:54.000000000","message":"Typo error, and it should be is_soft_deleted. Please change the code, and recheck.","commit_id":"5a6115e166bca1520470da2d78a4775585bd2fae"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"b1d1e656844f7af046bec6760cf01c9ba539f153","unresolved":false,"context_lines":[{"line_number":1769,"context_line":"    if is_soft_deleted:"},{"line_number":1770,"context_line":"        query \u003d query.filter(models.Share.is_softdeleted.is_(True))"},{"line_number":1771,"context_line":"    else:"},{"line_number":1772,"context_line":"        query \u003d query.filter(models.Share.is_softdeleted.is_(False))"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":"    instance_ids \u003d filters.get(\u0027instance_ids\u0027)"},{"line_number":1775,"context_line":"    if instance_ids:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0d8fc028_72e0c452","line":1772,"range":{"start_line":1772,"start_character":42,"end_line":1772,"end_character":56},"in_reply_to":"11088b97_f92c83dc","updated":"2023-09-20 11:43:34.000000000","message":"Resolved","commit_id":"5a6115e166bca1520470da2d78a4775585bd2fae"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a843bb92cf6e1382a460fa239ea8cfbd38df567d","unresolved":true,"context_lines":[{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"@require_admin_context"},{"line_number":1736,"context_line":"def share_instances_get_all(context, filters\u003dNone, session\u003dNone):"},{"line_number":1737,"context_line":"    session \u003d session or get_session()"},{"line_number":1738,"context_line":"    query \u003d model_query("},{"line_number":1739,"context_line":"        context, models.ShareInstance, session\u003dsession, read_deleted\u003d\"no\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5cfa0e7b_8503644e","line":1736,"range":{"start_line":1736,"start_character":4,"end_line":1736,"end_character":27},"updated":"2023-09-22 20:41:58.000000000","message":"any reason why we\u0027re modifying this method when the bug specifies the share servers query?","commit_id":"a449aa615eb7b901d60eb1765f610cf58075752c"}],"releasenotes/notes/bug-1964089-fix-share-server-list-slow-by-modifying-query-5a47af9f2cbb0ce0.yaml":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"f96e70b8e96a0646a712b01a46eae5dd45acd5a6","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bug #1964089 \u003chttps://bugs.launchpad.net/manila/+bug/1964089\u003e`_:"},{"line_number":5,"context_line":"    Changed joinedload to subquery for share_intances and sharenetwork_subnets"},{"line_number":6,"context_line":"    for more efficient query in function."},{"line_number":7,"context_line":"    Optimized a query to decrease joining share instances and share instance"},{"line_number":8,"context_line":"    export locations."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"83b80ef6_9198e21b","line":8,"range":{"start_line":5,"start_character":4,"end_line":8,"end_character":21},"updated":"2023-09-21 11:56:56.000000000","message":"The release notes are for end users, it is not for developers. This release note is explaining the SQL/code parts. It should be focused on the results for the end users.\n\nSomething like this:\n: Fixed the slowness while listing the share servers.","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"64898394566fa5d0ba33fdf6ebbbbd8a7aae8e90","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bug #1964089 \u003chttps://bugs.launchpad.net/manila/+bug/1964089\u003e`_:"},{"line_number":5,"context_line":"    Changed joinedload to subquery for share_intances and sharenetwork_subnets"},{"line_number":6,"context_line":"    for more efficient query in function."},{"line_number":7,"context_line":"    Optimized a query to decrease joining share instances and share instance"},{"line_number":8,"context_line":"    export locations."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"88373206_84c87917","line":8,"range":{"start_line":5,"start_character":4,"end_line":8,"end_character":21},"in_reply_to":"83b80ef6_9198e21b","updated":"2023-09-21 17:03:48.000000000","message":"Thank you Felipe, updated the release notes. Please do verify. I will take a look at NetApp DHSS.","commit_id":"d6680f3adcac32c3d68da954fde2403e5244c2b8"}]}