)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4de63b7bd746c15ca27c737134fb92f22b606009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"025d13a1_beec99b4","updated":"2023-06-05 16:47:07.000000000","message":"Hi Luiz, does this bug not exist on \"master\"?","commit_id":"c5de759e9d49259482a206a1395c7ce27621888c"},{"author":{"_account_id":35002},"change_message_id":"38565e9d5f44f1f8d8714a81e38c3a28e1d313f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50e41bac_f957038b","in_reply_to":"025d13a1_beec99b4","updated":"2023-06-12 18:05:53.000000000","message":"Hi Goutham, this patch is a WIP patch to Maurice test if this solve his problem beucase we couldn\u0027t reproduce the bug","commit_id":"c5de759e9d49259482a206a1395c7ce27621888c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"83f28ac19593fb19c15bc9bd7471533e7e25e84f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"416aeedf_25cffc10","updated":"2023-06-14 08:28:27.000000000","message":"Hi Luiz, thanks for working on this even not having a way to reproduce, yet.","commit_id":"abc074883991933c4ddbd26db9bc5ebd9fb1406f"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"d441d4f787e9ba7b04737c1c8aa940de69c07ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1a65c05c_c40452d9","updated":"2023-09-22 08:28:57.000000000","message":"Incorporated review comment given by \nMaurice","commit_id":"65ddaa1eeaa04a7fdb6b4611332213903047b6c6"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"720c896dda424d1679deedb6653992f387c5db78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5791a1d2_284e6f0c","updated":"2023-09-22 08:38:19.000000000","message":"recheck","commit_id":"65ddaa1eeaa04a7fdb6b4611332213903047b6c6"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"029722c8a1298a6137f5cbb2b63035f2fc0fb1e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d1e42962_d50493f6","updated":"2023-09-25 12:14:34.000000000","message":"lgtm","commit_id":"f5d968e929158d50d641e872ea828c89a729bc2a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"d4d312cb79b47fcfe5e0d4a3ae44f689bc27e9cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6cf66db4_d828bed1","updated":"2023-09-23 11:15:05.000000000","message":"recheck","commit_id":"f5d968e929158d50d641e872ea828c89a729bc2a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1162a61f5fcec55bcc70b4831de6bd15c2bef9ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"923cbe1b_108f1387","updated":"2023-09-22 15:33:44.000000000","message":"recheck","commit_id":"f5d968e929158d50d641e872ea828c89a729bc2a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd1ab3440838955a82f0bb3384b73ca0997564d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d5c1399d_e8638a06","updated":"2024-03-07 22:56:58.000000000","message":"cherry picked to unmaintained/xena as https://review.opendev.org/c/openstack/manila/+/911616","commit_id":"b9d5bd90995f4fa12ee89c5ee4727e4bbac06915"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"83f28ac19593fb19c15bc9bd7471533e7e25e84f","unresolved":true,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        # Check if there are no remaining SnapMirror connections and if a"},{"line_number":623,"context_line":"        # vserver peering exists and delete it."},{"line_number":624,"context_line":"        snapmirrors \u003d self._get_snapmirrors_destinations(vserver, peer_vserver)"},{"line_number":625,"context_line":"        snapmirrors_from_peer \u003d self._get_snapmirrors_destinations("},{"line_number":626,"context_line":"            peer_vserver, vserver)"},{"line_number":627,"context_line":"        peers \u003d self._get_vserver_peers(peer_vserver, vserver)"},{"line_number":628,"context_line":"        if not (snapmirrors or snapmirrors_from_peer) and peers:"},{"line_number":629,"context_line":"            self._delete_vserver_peer(peer_vserver, vserver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"6ba7d043_51a8b75f","line":626,"range":{"start_line":624,"start_character":8,"end_line":626,"end_character":34},"updated":"2023-06-14 08:28:27.000000000","message":"Hi, I\u0027m thinking that those two conditions could be added on top of the two existing ones, not replacing them. That would be the naive \u0027catch all\u0027 approach.\n\nMore detailled approach with more potential for errors and headaches: snapmirrors are always visible at the destination.\n`vserver` is the vserver of the active replica, from the to be deleted replica perspective this is the remote one aka the destination.\n\nSo it should be\n```\nremote_vserver, local_vserver \u003d self._get_vservers_from_replicas(\n            context, replica_list, replica)\nsnapmirrors_local \u003d self._get_snapmirrors(remote_vserver, local_vserver)\nsnapmirrors_remote \u003d self._get_snapmirrors_destinations(local_vserver, remote_vserver)\n```\n\nwhich is the same like only applying `_destinations` to line 625 and keeping line 624 like it was before.","commit_id":"abc074883991933c4ddbd26db9bc5ebd9fb1406f"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"d441d4f787e9ba7b04737c1c8aa940de69c07ff8","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        # Check if there are no remaining SnapMirror connections and if a"},{"line_number":623,"context_line":"        # vserver peering exists and delete it."},{"line_number":624,"context_line":"        snapmirrors \u003d self._get_snapmirrors_destinations(vserver, peer_vserver)"},{"line_number":625,"context_line":"        snapmirrors_from_peer \u003d self._get_snapmirrors_destinations("},{"line_number":626,"context_line":"            peer_vserver, vserver)"},{"line_number":627,"context_line":"        peers \u003d self._get_vserver_peers(peer_vserver, vserver)"},{"line_number":628,"context_line":"        if not (snapmirrors or snapmirrors_from_peer) and peers:"},{"line_number":629,"context_line":"            self._delete_vserver_peer(peer_vserver, vserver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"678bd870_9d3448ee","line":626,"range":{"start_line":624,"start_character":8,"end_line":626,"end_character":34},"in_reply_to":"6ba7d043_51a8b75f","updated":"2023-09-22 08:28:57.000000000","message":"Done","commit_id":"abc074883991933c4ddbd26db9bc5ebd9fb1406f"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"9f69544bc1aba8b4d2b3ef108541fb6f46d8f04d","unresolved":true,"context_lines":[{"line_number":622,"context_line":"        snapmirrors_des_list \u003d self._get_snapmirrors_destinations(vserver, peer_vserver)"},{"line_number":623,"context_line":"        snapmirrors_des_list_from_peer \u003d self._get_snapmirrors_destinations("},{"line_number":624,"context_line":"            peer_vserver, vserver)"},{"line_number":625,"context_line":"        if not (snapmirrors_des_list or snapmirrors_des_list_from_peer):"},{"line_number":626,"context_line":"            super(NetAppCmodeMultiSVMFileStorageLibrary, self).delete_replica("},{"line_number":627,"context_line":"                context, replica_list, replica, share_snapshots)"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"14ac42ac_47c6410e","line":625,"updated":"2023-09-22 07:49:19.000000000","message":"shouldn\u0027t this condition be checking for existing snapmirrors, i.e. without \u0027not\u0027:\n\n`if (snapmirrors_des_list or snapmirrors_des_list_from_peer):`","commit_id":"1491c31efbbe86ac7b3f04952fcb940d485cb033"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"44ae07101f94b6b08054d522769972598a9881ae","unresolved":true,"context_lines":[{"line_number":622,"context_line":"        snapmirrors_des_list \u003d self._get_snapmirrors_destinations(vserver, peer_vserver)"},{"line_number":623,"context_line":"        snapmirrors_des_list_from_peer \u003d self._get_snapmirrors_destinations("},{"line_number":624,"context_line":"            peer_vserver, vserver)"},{"line_number":625,"context_line":"        if not (snapmirrors_des_list or snapmirrors_des_list_from_peer):"},{"line_number":626,"context_line":"            super(NetAppCmodeMultiSVMFileStorageLibrary, self).delete_replica("},{"line_number":627,"context_line":"                context, replica_list, replica, share_snapshots)"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"785f2412_2ae48741","line":625,"in_reply_to":"14ac42ac_47c6410e","updated":"2023-09-22 08:25:25.000000000","message":"my bad, I have corrected that.","commit_id":"1491c31efbbe86ac7b3f04952fcb940d485cb033"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"7cfe53d8315322afdc5db8b12ad289c6e67df23d","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        snapmirrors_des_list \u003d self._get_snapmirrors_destinations(vserver, peer_vserver)"},{"line_number":623,"context_line":"        snapmirrors_des_list_from_peer \u003d self._get_snapmirrors_destinations("},{"line_number":624,"context_line":"            peer_vserver, vserver)"},{"line_number":625,"context_line":"        if not (snapmirrors_des_list or snapmirrors_des_list_from_peer):"},{"line_number":626,"context_line":"            super(NetAppCmodeMultiSVMFileStorageLibrary, self).delete_replica("},{"line_number":627,"context_line":"                context, replica_list, replica, share_snapshots)"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"e0ce5e45_a1cc5c46","line":625,"in_reply_to":"785f2412_2ae48741","updated":"2023-09-22 08:26:42.000000000","message":"Done","commit_id":"1491c31efbbe86ac7b3f04952fcb940d485cb033"}]}