)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8756636ca9cee9b4c5c6932d50256d7f678a1117","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2d7ddaa9_e7209140","updated":"2023-07-24 14:28:00.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"eabf6851d1304bea2eeea8f725950c45cad2dbd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"315861bf_6a5fcede","updated":"2023-07-25 14:46:28.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8a968e1439797bc8bc303bd03198622bc2d34b0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3def1413_b559d122","updated":"2023-07-24 08:35:34.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"00750f3654ed183647717bc98745216810e63154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"41f1bf7b_ac1dd1d3","updated":"2023-07-25 13:54:21.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"f2b3863592d87401beb6e3fd7f2efca3c66eb9a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a80b057_842a193f","updated":"2023-07-25 08:33:51.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"aefcc9c022a844c8c81a3f1576f4dd2ded678ede","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9d728125_94fc5b33","updated":"2023-07-24 08:47:57.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"fb624504abcff3edde89a1278dfd57628a30c526","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b448595c_5f33aa88","updated":"2023-07-24 12:14:47.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"13732f309c0c00d7b428011a06d1280d6f2e547b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bbafcbda_7ac1d284","updated":"2023-07-25 10:58:31.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"d3cc3246ab3cd0d55ebdbfa02e0d516b29e2d5ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ea81fae7_e3fa799c","updated":"2023-07-25 11:53:04.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"842655185af99a463491fc18e708ee5f514fd8cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f7ab789e_19ca959a","updated":"2023-07-24 09:19:01.000000000","message":"run-DellEMC PowerStore CI","commit_id":"71a9416251302537ca693a9140df5166b6849de3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"01bd0327_b4fa2105","updated":"2023-08-09 21:07:04.000000000","message":"Hi, \n\nThank you for submitting this driver; please see some comments inline. \nAlso, could you please remove \"suppress_errors_in_cleanup\u003dTrue\" in your tempest configuration? With it, you might be masking a bug: https://elab-os-logsrv.delllabs.net/74/885974/6/check/DellEMC_PowerStore_Manila_dhss_false/7109aa5/DellEMC_PowerStore_Manila_dhss_false/41/logs/tempest_conf.txt.gz\n\n\nAnother thing to note: As with your PowerFlex driver patch, you\u0027ve added numerous folks here to review... could you please remove them so they don\u0027t get spammed by the changes here.","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"99e1a4774b21a9ba7719df0d0099319d1a78ee33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"21645de1_ab273c5e","updated":"2023-08-02 04:07:15.000000000","message":"run-DellEMC PowerStore CI","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"2e6854381428923d70bfebf1ab256ca6929e1ad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7b618f17_f16726e6","updated":"2023-08-02 03:23:06.000000000","message":"run-DellEMC PowerStore CI","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5ed2969f93c8afc5bcffdb77158bd4567806287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aa0ec0b7_7a085810","updated":"2023-08-22 19:44:23.000000000","message":"It looks like the PowerStore CI system has an issue with devstack (just like the PowerFlex CI system). Recently, devstack started creating a global python virtual environment for all python packages [1] - and this may be the cause of the failure. \n\nYou can set `GLOBAL_VENV\u003dfalse` in devstack `local.conf` file and see if that fixes the CI system. Else, please chat on #openstack-infra or file a bug against devstack: bugs.launchpad.net/devstack\n\n[1] https://review.opendev.org/c/openstack/devstack/+/558930","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82e8291c8ff2ed57a2e8477293f681f37d425e5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fdf5fff1_9d22da61","updated":"2023-08-21 17:46:00.000000000","message":"Thank you for working on this change and sorry for keeping you waiting for reviews. Don\u0027t have anything major to bring up, only some questions that I\u0027d be happy to see in a follow-up change in case other reviewers don\u0027t have bigger concerns.","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"22791a5d56d35b653925841fe4056764aaa7334c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bacdbbeb_896bfae9","updated":"2023-08-23 11:03:48.000000000","message":"Thanks for working on the CI!\nLet\u0027s get this in :)","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"849d48b6_a57252eb","updated":"2023-08-17 15:27:26.000000000","message":"run-DellEMC PowerStore CI","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"30d89bacc241619bcac871879dd530423c3005ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b85fc020_94022bb0","updated":"2023-08-23 10:09:06.000000000","message":"run-DellEMC PowerStore CI","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e1b7273e9c9da533ec953e2750c5e36172186abc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"78925eeb_de70e0bc","in_reply_to":"849d48b6_a57252eb","updated":"2023-08-18 06:51:44.000000000","message":"It seems our CI systems failed to install devstack. Jacob is working on that.","commit_id":"09555c80de212825b483e2c3200e382078332c9a"}],"doc/source/configuration/shared-file-systems/drivers/dell-emc-powerstore-driver.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"07d6a4e1_812cdb19","updated":"2023-08-09 21:07:04.000000000","message":"Could you please link this file under this section:\n\n https://github.com/openstack/manila/blob/master/doc/source/admin/index.rst#supported-share-back-ends \n \n as well?","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"961b7221_7f1d7b6e","in_reply_to":"07d6a4e1_812cdb19","updated":"2023-08-17 15:27:26.000000000","message":"Please \"resolve\" comments when you\u0027re updating a patch; this allows reviewers to re-review the code faster.","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    .. code-block:: console"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        $ manila type-create ${share_type_name} False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"#. Map this share type to the share backend name"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"cc58fa14_539a0930","line":128,"range":{"start_line":128,"start_character":10,"end_line":128,"end_character":53},"updated":"2023-08-09 21:07:04.000000000","message":"Please replace these with \"openstack\" CLI commands; we\u0027re transitioning the documents slowly to use the openstackclient instead:\n\n\n```\nopenstack share type create ${share_type_name} False\n```","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    .. code-block:: console"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        $ manila type-create ${share_type_name} False"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"#. Map this share type to the share backend name"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bcc156da_274d0792","line":128,"range":{"start_line":128,"start_character":10,"end_line":128,"end_character":53},"in_reply_to":"cc58fa14_539a0930","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    .. code-block:: console"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        $ manila type-key ${share_type_name} \\"},{"line_number":135,"context_line":"                        set share_backend_name\u003d${share_backend_name}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"#. Create NFS share."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":6,"id":"47c69b69_76c5804f","line":136,"range":{"start_line":134,"start_character":10,"end_line":136,"end_character":0},"updated":"2023-08-09 21:07:04.000000000","message":"```\nopenstack share type set ${share_type_name} \\\n     --extra-specs share_backend_name\u003d${share_backend_name}\n```","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    .. code-block:: console"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        $ manila type-key ${share_type_name} \\"},{"line_number":135,"context_line":"                        set share_backend_name\u003d${share_backend_name}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"#. Create NFS share."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b95f369d_462b5db5","line":136,"range":{"start_line":134,"start_character":10,"end_line":136,"end_character":0},"in_reply_to":"47c69b69_76c5804f","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    .. code-block:: console"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        $ manila create NFS ${size} --name ${share_name} --share-type ${share_type_name}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Pre-configurations for snapshot support"}],"source_content_type":"text/x-rst","patch_set":6,"id":"30015572_c92cb5e8","line":141,"range":{"start_line":141,"start_character":10,"end_line":141,"end_character":23},"updated":"2023-08-09 21:07:04.000000000","message":"```\nopenstack share create\n```","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    .. code-block:: console"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        $ manila create NFS ${size} --name ${share_name} --share-type ${share_type_name}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Pre-configurations for snapshot support"}],"source_content_type":"text/x-rst","patch_set":6,"id":"00c5806a_39580652","line":141,"range":{"start_line":141,"start_character":10,"end_line":141,"end_character":23},"in_reply_to":"30015572_c92cb5e8","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    .. code-block:: console"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        $ manila type-create --snapshot_support True \\"},{"line_number":164,"context_line":"            --create_share_from_snapshot_support True \\"},{"line_number":165,"context_line":"            --revert_to_snapshot_support True \\"},{"line_number":166,"context_line":"            ${share_type_name} False"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Or you can update already existing share type with command:"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"82cfec46_ca89a247","line":166,"range":{"start_line":163,"start_character":10,"end_line":166,"end_character":36},"updated":"2023-08-09 21:07:04.000000000","message":"```\nopenstack share type create ${share_type_name} False \\\n    --snapshot-support\u003dTrue \\\n    --create-share-from-snapshot-support\u003dTrue \\\n    --revert-to-snapshot-support\u003dTrue\n```","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    .. code-block:: console"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        $ manila type-create --snapshot_support True \\"},{"line_number":164,"context_line":"            --create_share_from_snapshot_support True \\"},{"line_number":165,"context_line":"            --revert_to_snapshot_support True \\"},{"line_number":166,"context_line":"            ${share_type_name} False"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Or you can update already existing share type with command:"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"d4b00b66_44c46e3a","line":166,"range":{"start_line":163,"start_character":10,"end_line":166,"end_character":36},"in_reply_to":"82cfec46_ca89a247","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    .. code-block:: console"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        $ manila type-key ${share_type_name} set snapshot_support\u003dTrue"},{"line_number":173,"context_line":"        $ manila type-key ${share_type_name} set create_share_from_snapshot_support\u003dTrue"},{"line_number":174,"context_line":"        $ manila type-key ${share_type_name} set revert_to_snapshot_support\u003dTrue"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Known restrictions"},{"line_number":177,"context_line":"------------------"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fc2c6a6c_f21d41a2","line":175,"range":{"start_line":172,"start_character":10,"end_line":175,"end_character":0},"updated":"2023-08-09 21:07:04.000000000","message":"```\nopenstack share type set ${share_type_name} \\\n    --extra-specs snapshot_support\u003dTrue \\\n          create_share_from_snapshot_support\u003dTrue \\\n          revert_to_snapshot_support\u003dTrue\n```","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    .. code-block:: console"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        $ manila type-key ${share_type_name} set snapshot_support\u003dTrue"},{"line_number":173,"context_line":"        $ manila type-key ${share_type_name} set create_share_from_snapshot_support\u003dTrue"},{"line_number":174,"context_line":"        $ manila type-key ${share_type_name} set revert_to_snapshot_support\u003dTrue"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Known restrictions"},{"line_number":177,"context_line":"------------------"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"cdd5dc6c_2f900841","line":175,"range":{"start_line":172,"start_character":10,"end_line":175,"end_character":0},"in_reply_to":"fc2c6a6c_f21d41a2","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"}],"manila/share/drivers/dell_emc/plugins/powerstore/client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\r"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations\r"},{"line_number":14,"context_line":"# under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"\"\"\"REST client for Dell EMC PowerStore Manila Driver.\"\"\"\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"import functools\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"3e5ae62b_63a0e8b3","line":15,"updated":"2023-08-09 21:07:04.000000000","message":"i think there are incorrect line endings in this file; see the blank lines? Could you please fix those?","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\r"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations\r"},{"line_number":14,"context_line":"# under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"\"\"\"REST client for Dell EMC PowerStore Manila Driver.\"\"\"\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"import functools\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"f672368c_014c9e61","line":15,"in_reply_to":"3e5ae62b_63a0e8b3","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"\"\"\"REST client for Dell EMC PowerStore Manila Driver.\"\"\"\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"import functools\r"},{"line_number":19,"context_line":"import json\r"},{"line_number":20,"context_line":"from oslo_log import log as logging\r"},{"line_number":21,"context_line":"from oslo_utils import strutils\r"},{"line_number":22,"context_line":"import requests\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":25,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"d3f6aa9e_81dddf5f","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":15},"updated":"2023-08-09 21:07:04.000000000","message":"Take a look at the import order template convention used by this project: https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template\n\nYou must separate stdlib imports from third party libraries and imports of modules within the \"manila\" package","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"\"\"\"REST client for Dell EMC PowerStore Manila Driver.\"\"\"\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"import functools\r"},{"line_number":19,"context_line":"import json\r"},{"line_number":20,"context_line":"from oslo_log import log as logging\r"},{"line_number":21,"context_line":"from oslo_utils import strutils\r"},{"line_number":22,"context_line":"import requests\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":25,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"732afc07_beeb8aa2","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":15},"in_reply_to":"d3f6aa9e_81dddf5f","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        if payload and method !\u003d \"GET\":\r"},{"line_number":69,"context_line":"            request_params[\"data\"] \u003d json.dumps(payload)\r"},{"line_number":70,"context_line":"        request_url \u003d self.base_url + url\r"},{"line_number":71,"context_line":"        # LOG.debug(f\"###request params: {request_params}\")\r"},{"line_number":72,"context_line":"        r \u003d requests.request(method, request_url, **request_params)\r"},{"line_number":73,"context_line":"        # LOG.debug(f\"###request header: {r.request.headers}\")\r"},{"line_number":74,"context_line":"        # LOG.debug(f\"###response header: {r.headers}\")\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"a4d7c022_1f5de4f5","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":60},"updated":"2023-08-09 21:07:04.000000000","message":"please remove these commented log lines..","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if payload and method !\u003d \"GET\":\r"},{"line_number":69,"context_line":"            request_params[\"data\"] \u003d json.dumps(payload)\r"},{"line_number":70,"context_line":"        request_url \u003d self.base_url + url\r"},{"line_number":71,"context_line":"        # LOG.debug(f\"###request params: {request_params}\")\r"},{"line_number":72,"context_line":"        r \u003d requests.request(method, request_url, **request_params)\r"},{"line_number":73,"context_line":"        # LOG.debug(f\"###request header: {r.request.headers}\")\r"},{"line_number":74,"context_line":"        # LOG.debug(f\"###response header: {r.headers}\")\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"3e892958_32fbcce7","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":60},"in_reply_to":"a4d7c022_1f5de4f5","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"}],"manila/share/drivers/dell_emc/plugins/powerstore/connection.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"\"\"\"\r"},{"line_number":17,"context_line":"PowerStore specific NAS backend plugin.\r"},{"line_number":18,"context_line":"\"\"\"\r"},{"line_number":19,"context_line":"from manila.common import constants as const\r"},{"line_number":20,"context_line":"from manila import exception\r"},{"line_number":21,"context_line":"from manila.i18n import _\r"},{"line_number":22,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver\r"},{"line_number":23,"context_line":"from manila.share.drivers.dell_emc.plugins.powerstore import client\r"},{"line_number":24,"context_line":"from oslo_config import cfg\r"},{"line_number":25,"context_line":"from oslo_log import log\r"},{"line_number":26,"context_line":"from oslo_utils import units\r"},{"line_number":27,"context_line":"\r"},{"line_number":28,"context_line":"\"\"\"Version history:\r"},{"line_number":29,"context_line":"    1.0 - Initial version\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"29fcb8c9_f1ded0c9","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":28},"updated":"2023-08-09 21:07:04.000000000","message":"same comment here as in the previous file; follow the import order template guideline: https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"\r"},{"line_number":17,"context_line":"PowerStore specific NAS backend plugin.\r"},{"line_number":18,"context_line":"\"\"\"\r"},{"line_number":19,"context_line":"from manila.common import constants as const\r"},{"line_number":20,"context_line":"from manila import exception\r"},{"line_number":21,"context_line":"from manila.i18n import _\r"},{"line_number":22,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver\r"},{"line_number":23,"context_line":"from manila.share.drivers.dell_emc.plugins.powerstore import client\r"},{"line_number":24,"context_line":"from oslo_config import cfg\r"},{"line_number":25,"context_line":"from oslo_log import log\r"},{"line_number":26,"context_line":"from oslo_utils import units\r"},{"line_number":27,"context_line":"\r"},{"line_number":28,"context_line":"\"\"\"Version history:\r"},{"line_number":29,"context_line":"    1.0 - Initial version\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"5466f4f6_2ae36cba","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":28},"in_reply_to":"29fcb8c9_f1ded0c9","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    1.0 - Initial version\r"},{"line_number":30,"context_line":"\"\"\"\r"},{"line_number":31,"context_line":"VERSION \u003d \"1.0\"\r"},{"line_number":32,"context_line":"\r"},{"line_number":33,"context_line":"CONF \u003d cfg.CONF\r"},{"line_number":34,"context_line":"\r"},{"line_number":35,"context_line":"LOG \u003d log.getLogger(__name__)\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ccee6234_7898f271","line":32,"updated":"2023-08-09 21:07:04.000000000","message":"The whitespace/line endings comment applies to this file as well. Please ensure you\u0027ve set the line ending style on git so that the line endings are consistent with the repository; even if you\u0027re using Windows OS when writing this code","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    1.0 - Initial version\r"},{"line_number":30,"context_line":"\"\"\"\r"},{"line_number":31,"context_line":"VERSION \u003d \"1.0\"\r"},{"line_number":32,"context_line":"\r"},{"line_number":33,"context_line":"CONF \u003d cfg.CONF\r"},{"line_number":34,"context_line":"\r"},{"line_number":35,"context_line":"LOG \u003d log.getLogger(__name__)\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"c4ed401d_cd7ca714","line":32,"in_reply_to":"ccee6234_7898f271","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":219,"context_line":"\r"},{"line_number":220,"context_line":"    def _get_cifs_location(self, file_interfaces, share_name):\r"},{"line_number":221,"context_line":"        export_locations \u003d []\r"},{"line_number":222,"context_line":"        for interface in file_interfaces:\r"},{"line_number":223,"context_line":"            export_locations.append(\r"},{"line_number":224,"context_line":"                {\u0027path\u0027: f\"\\\\\\\\{interface}\\\\{share_name}\"})\r"},{"line_number":225,"context_line":"        return export_locations\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"65e6d631_8e9f910b","line":222,"range":{"start_line":222,"start_character":8,"end_line":222,"end_character":40},"updated":"2023-08-09 21:07:04.000000000","message":"is there any way to identify a \"preferred\" interface? In some storage backend drivers, they seem to identify a particular interface as \"preferred\" because of some configuration, or has a high bandwidth network, or is connected directly to a particular storage node that serves the data (as opposed to indirect/routed connections)... \n\nif there is one, i suggest setting the \"preferred\" key in the export list you\u0027re building..","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":263,"context_line":"        new_size_in_bytes \u003d new_size * units.Gi\r"},{"line_number":264,"context_line":"        filesystem_id \u003d self.client.get_filesystem_id(\r"},{"line_number":265,"context_line":"            name)\r"},{"line_number":266,"context_line":"        self.client.resize_filesystem(filesystem_id,\r"},{"line_number":267,"context_line":"                                      new_size_in_bytes)\r"},{"line_number":268,"context_line":"\r"},{"line_number":269,"context_line":"    def allow_access(self, context, share, access, share_server):\r"},{"line_number":270,"context_line":"        \"\"\"Allow access to the share.\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"2e557f4a_d0b365c0","line":267,"range":{"start_line":266,"start_character":8,"end_line":267,"end_character":56},"updated":"2023-08-09 21:07:04.000000000","message":"Does the backend prevent shrinking a share to below the consumed space? If yes, could you please handle that error and raise a \"ShareShrinkingPossibleDataLoss\" excepton [1]?\n\n[1] https://opendev.org/openstack/manila/src/commit/364000c140d6e12d59a8e04fb0398aef1d6badaf/manila/exception.py#L787","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        new_size_in_bytes \u003d new_size * units.Gi\r"},{"line_number":264,"context_line":"        filesystem_id \u003d self.client.get_filesystem_id(\r"},{"line_number":265,"context_line":"            name)\r"},{"line_number":266,"context_line":"        self.client.resize_filesystem(filesystem_id,\r"},{"line_number":267,"context_line":"                                      new_size_in_bytes)\r"},{"line_number":268,"context_line":"\r"},{"line_number":269,"context_line":"    def allow_access(self, context, share, access, share_server):\r"},{"line_number":270,"context_line":"        \"\"\"Allow access to the share.\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"713a7580_5e300bdf","line":267,"range":{"start_line":266,"start_character":8,"end_line":267,"end_character":56},"in_reply_to":"2e557f4a_d0b365c0","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":460,"context_line":"            )\r"},{"line_number":461,"context_line":"        filesystem_id \u003d self.client.clone_snapshot(snapshot_id,\r"},{"line_number":462,"context_line":"                                                   share_name)\r"},{"line_number":463,"context_line":"        if not filesystem_id:\r"},{"line_number":464,"context_line":"            message \u003d {\r"},{"line_number":465,"context_line":"                _(\u0027The filesystem \"%(export)s\" was not created.\u0027) %\r"},{"line_number":466,"context_line":"                {\u0027export\u0027: share_name}}\r"},{"line_number":467,"context_line":"            LOG.error(message)\r"},{"line_number":468,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)\r"},{"line_number":469,"context_line":"        # create a share\r"},{"line_number":470,"context_line":"        nas_server_id \u003d self.client.get_nas_server_id(self.nas_server)\r"},{"line_number":471,"context_line":"        locations \u003d self._create_share_NFS_CIFS(nas_server_id, filesystem_id,\r"},{"line_number":472,"context_line":"                                                share_name,\r"},{"line_number":473,"context_line":"                                                share[\u0027share_proto\u0027].upper())\r"},{"line_number":474,"context_line":"        return locations\r"},{"line_number":475,"context_line":"\r"},{"line_number":476,"context_line":"    def ensure_share(self, context, share, share_server):\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"b8712407_ddea5d7d","line":473,"range":{"start_line":463,"start_character":8,"end_line":473,"end_character":77},"updated":"2023-08-09 21:07:04.000000000","message":"does this logic handle size changes?\n\ni.e., \n\nshare A is 10GB\nYou create a snapshot of A\nYou clone the snapshot of A into share B, but you request it to be 20GB instead.. \n\nIf your \"clone_snapshot\" doesn\u0027t handle this, this method should call \"resize_filesystem\" after the clone to ensure the user\u0027s requested size is applied","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            )\r"},{"line_number":461,"context_line":"        filesystem_id \u003d self.client.clone_snapshot(snapshot_id,\r"},{"line_number":462,"context_line":"                                                   share_name)\r"},{"line_number":463,"context_line":"        if not filesystem_id:\r"},{"line_number":464,"context_line":"            message \u003d {\r"},{"line_number":465,"context_line":"                _(\u0027The filesystem \"%(export)s\" was not created.\u0027) %\r"},{"line_number":466,"context_line":"                {\u0027export\u0027: share_name}}\r"},{"line_number":467,"context_line":"            LOG.error(message)\r"},{"line_number":468,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)\r"},{"line_number":469,"context_line":"        # create a share\r"},{"line_number":470,"context_line":"        nas_server_id \u003d self.client.get_nas_server_id(self.nas_server)\r"},{"line_number":471,"context_line":"        locations \u003d self._create_share_NFS_CIFS(nas_server_id, filesystem_id,\r"},{"line_number":472,"context_line":"                                                share_name,\r"},{"line_number":473,"context_line":"                                                share[\u0027share_proto\u0027].upper())\r"},{"line_number":474,"context_line":"        return locations\r"},{"line_number":475,"context_line":"\r"},{"line_number":476,"context_line":"    def ensure_share(self, context, share, share_server):\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"d81d6005_7c40874b","line":473,"range":{"start_line":463,"start_character":8,"end_line":473,"end_character":77},"in_reply_to":"b8712407_ddea5d7d","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82e8291c8ff2ed57a2e8477293f681f37d425e5c","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        return locations"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def _create_share_NFS_CIFS(self, nas_server_id, filesystem_id, share_name,"},{"line_number":184,"context_line":"                               protocal):"},{"line_number":185,"context_line":"        LOG.debug(f\"Get file interfaces of {nas_server_id}\")"},{"line_number":186,"context_line":"        file_interfaces \u003d self.client.get_nas_server_interfaces("},{"line_number":187,"context_line":"            nas_server_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3bb07967_9f5df401","line":184,"range":{"start_line":184,"start_character":31,"end_line":184,"end_character":39},"updated":"2023-08-21 17:46:00.000000000","message":"nit: protocol","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82e8291c8ff2ed57a2e8477293f681f37d425e5c","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        file_interfaces \u003d self.client.get_nas_server_interfaces("},{"line_number":187,"context_line":"            nas_server_id)"},{"line_number":188,"context_line":"        LOG.debug(f\"Creating {protocal} export {share_name}\")"},{"line_number":189,"context_line":"        if protocal \u003d\u003d \u0027NFS\u0027:"},{"line_number":190,"context_line":"            export_id \u003d self.client.create_nfs_export(filesystem_id,"},{"line_number":191,"context_line":"                                                      share_name)"},{"line_number":192,"context_line":"            if not export_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"02cb6a5f_809c977e","line":189,"range":{"start_line":189,"start_character":11,"end_line":189,"end_character":19},"updated":"2023-08-21 17:46:00.000000000","message":"nit: protocol","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82e8291c8ff2ed57a2e8477293f681f37d425e5c","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        LOG.debug(f\"Retrieving filesystem ID for filesystem {share[\u0027name\u0027]}\")"},{"line_number":244,"context_line":"        filesystem_id \u003d self.client.get_filesystem_id(share[\u0027name\u0027])"},{"line_number":245,"context_line":"        if not filesystem_id:"},{"line_number":246,"context_line":"            LOG.warning(f\u0027Filesystem with share name {share[\"name\"]} \\"},{"line_number":247,"context_line":"                        is not found.\u0027)"},{"line_number":248,"context_line":"        else:"},{"line_number":249,"context_line":"            LOG.debug(f\"Deleting filesystem ID {filesystem_id}\")"},{"line_number":250,"context_line":"            share_deleted \u003d self.client.delete_filesystem(filesystem_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"26c2e151_077f25cd","line":247,"range":{"start_line":246,"start_character":24,"end_line":247,"end_character":38},"updated":"2023-08-21 17:46:00.000000000","message":"nit:\nthis line could be breaked after the LOG.warning( so we would avoid breaking the line with \\","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82e8291c8ff2ed57a2e8477293f681f37d425e5c","unresolved":true,"context_lines":[{"line_number":350,"context_line":"                access_updates.update({rule[\u0027access_id\u0027]: {\u0027state\u0027: \u0027error\u0027}})"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"            else:"},{"line_number":353,"context_line":"                prefix \u003d self.ad_domain or \\"},{"line_number":354,"context_line":"                    self.client.get_nas_server_smb_netbios(self.nas_server)"},{"line_number":355,"context_line":"                if not prefix:"},{"line_number":356,"context_line":"                    message \u003d ("},{"line_number":357,"context_line":"                        _(\u0027Failed to get daomain/netbios name of \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"ea70bdf7_fe8a24f8","line":354,"range":{"start_line":353,"start_character":25,"end_line":354,"end_character":75},"updated":"2023-08-21 17:46:00.000000000","message":"```prefix \u003d (\n    self.ad_domiain or\n    self.client.get_nas_server_smb_netbios(self.nas_server)\n)```","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82e8291c8ff2ed57a2e8477293f681f37d425e5c","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        stats_dict[\u0027driver_version\u0027] \u003d VERSION"},{"line_number":387,"context_line":"        stats_dict[\u0027storage_protocol\u0027] \u003d \u0027NFS_CIFS\u0027"},{"line_number":388,"context_line":"        stats_dict[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":389,"context_line":"        stats_dict[\u0027reserved_snapshot_percentage\u0027] \u003d \\"},{"line_number":390,"context_line":"            self.reserved_snapshot_percentage"},{"line_number":391,"context_line":"        stats_dict[\u0027reserved_share_extend_percentage\u0027] \u003d \\"},{"line_number":392,"context_line":"            self.reserved_share_extend_percentage"},{"line_number":393,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"87778536_c86906e9","line":390,"range":{"start_line":389,"start_character":53,"end_line":390,"end_character":45},"updated":"2023-08-21 17:46:00.000000000","message":"```\u003d (\n    self.reserved_snapshot_percentage)```","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82e8291c8ff2ed57a2e8477293f681f37d425e5c","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        stats_dict[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":389,"context_line":"        stats_dict[\u0027reserved_snapshot_percentage\u0027] \u003d \\"},{"line_number":390,"context_line":"            self.reserved_snapshot_percentage"},{"line_number":391,"context_line":"        stats_dict[\u0027reserved_share_extend_percentage\u0027] \u003d \\"},{"line_number":392,"context_line":"            self.reserved_share_extend_percentage"},{"line_number":393,"context_line":"        stats_dict[\u0027max_over_subscription_ratio\u0027] \u003d \\"},{"line_number":394,"context_line":"            self.max_over_subscription_ratio"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a7b16dca_ce031599","line":392,"range":{"start_line":391,"start_character":55,"end_line":392,"end_character":49},"updated":"2023-08-21 17:46:00.000000000","message":"same","commit_id":"09555c80de212825b483e2c3200e382078332c9a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82e8291c8ff2ed57a2e8477293f681f37d425e5c","unresolved":true,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        cluster_id \u003d self.client.get_cluster_id()"},{"line_number":397,"context_line":"        total, used \u003d self.client.retreive_cluster_capacity_metrics(cluster_id)"},{"line_number":398,"context_line":"        if(total and used):"},{"line_number":399,"context_line":"            free \u003d total - used"},{"line_number":400,"context_line":"            stats_dict[\u0027total_capacity_gb\u0027] \u003d total // units.Gi"},{"line_number":401,"context_line":"            stats_dict[\u0027free_capacity_gb\u0027] \u003d free // units.Gi"}],"source_content_type":"text/x-python","patch_set":7,"id":"0a99f734_f35acb1e","line":398,"range":{"start_line":398,"start_character":10,"end_line":398,"end_character":26},"updated":"2023-08-21 17:46:00.000000000","message":"no need for the parenthesis","commit_id":"09555c80de212825b483e2c3200e382078332c9a"}],"manila/tests/share/drivers/dell_emc/plugins/powerstore/test_client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import json\r"},{"line_number":17,"context_line":"from pathlib import Path\r"},{"line_number":18,"context_line":"import requests_mock\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"from manila.share.drivers.dell_emc.plugins.powerstore import client\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"d29cf81c_e8950cc1","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":25},"updated":"2023-08-09 21:07:04.000000000","message":"you should import the module not the object.. \n\n```\n import pathlib\n```\n \nand use it like:\n\n``` \n pathlib.Path\n```\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import json\r"},{"line_number":17,"context_line":"from pathlib import Path\r"},{"line_number":18,"context_line":"import requests_mock\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"from manila.share.drivers.dell_emc.plugins.powerstore import client\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ad0a7b4f_c73f0dd4","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":25},"in_reply_to":"d29cf81c_e8950cc1","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import json\r"},{"line_number":17,"context_line":"from pathlib import Path\r"},{"line_number":18,"context_line":"import requests_mock\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"from manila.share.drivers.dell_emc.plugins.powerstore import client\r"},{"line_number":21,"context_line":"from manila import test\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"63263cb9_0b79f5fc","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":21},"updated":"2023-08-09 21:07:04.000000000","message":"this is a third party library, please add a blank line to separate it from the stdlib imports above","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import json\r"},{"line_number":17,"context_line":"from pathlib import Path\r"},{"line_number":18,"context_line":"import requests_mock\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"from manila.share.drivers.dell_emc.plugins.powerstore import client\r"},{"line_number":21,"context_line":"from manila import test\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"e3941379_79e276b1","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":21},"in_reply_to":"63263cb9_0b79f5fc","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"}],"releasenotes/notes/bp-dell-powerstore-manila-driver-263489b0d0b10e2e.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7631dcd5da40fbe1275f6ae9c0080a5c55e6657a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new Manila driver to support Dell PowerStore storage backend."},{"line_number":5,"context_line":"    It supports NFS and CIFS shares operations, and snapshot operations."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cdf2bf8d_c23b4d62","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2023-08-09 21:07:04.000000000","message":"nit: Added","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1bb800c842a3d4cfae1f8520dc591115cea11ccd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new Manila driver to support Dell PowerStore storage backend."},{"line_number":5,"context_line":"    It supports NFS and CIFS shares operations, and snapshot operations."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aaf47b4_330cfaeb","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"in_reply_to":"cdf2bf8d_c23b4d62","updated":"2023-08-17 15:27:26.000000000","message":"Done","commit_id":"ec687d58d46dcfaec2382e9190df8a842cc7b530"}]}