)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fd01cd18ce1440d9dba06042dc5f5924707395a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb6b7416_8f189d2a","updated":"2023-06-15 11:21:42.000000000","message":"Hi Kiran, thanks for fixing and bringing this to the community.\n\nCan you please also address the other part, the wrong db method error, here?","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"f3480d66b6771e3749160c7272b30f262e0d2c00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c718f095_31a92682","in_reply_to":"594563f8_d62e5578","updated":"2023-06-15 11:59:36.000000000","message":"Ah, too bad we did not rebase our xena - thanks","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a5f73e61db80024a552cc952c48af86bbe2a924e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"594563f8_d62e5578","in_reply_to":"cb6b7416_8f189d2a","updated":"2023-06-15 11:37:00.000000000","message":"This seems already fixed, https://github.com/openstack/manila/blob/c976f041ddb936af113d0e36f9b6bf2e0c496246/manila/share/api.py#L1515","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9c7c9230957a99779ce6a2e5bcaf9d3768d40f4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea722aab_ae20934d","updated":"2023-06-20 01:38:15.000000000","message":"Hi Kiran, \n\nIt feel like a similar check can apply to shares too? In that case, perhaps move the validation to api/common and invoke it from the API methods?","commit_id":"34ace4372a8b39fe286f82b4d1bc1c83cac60410"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"f3480d66b6771e3749160c7272b30f262e0d2c00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f468f778_78de37c6","updated":"2023-06-15 11:59:36.000000000","message":"LGTM","commit_id":"34ace4372a8b39fe286f82b4d1bc1c83cac60410"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9bfa9253073c5f8d820a02dd7d2a53a5b4ba59e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18697729_1c92e841","updated":"2023-06-15 15:52:05.000000000","message":"recheck","commit_id":"34ace4372a8b39fe286f82b4d1bc1c83cac60410"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f0f5a21bc393b765a940044fcda510a5c7c11594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2712e790_510b3107","in_reply_to":"ea722aab_ae20934d","updated":"2023-06-20 09:44:34.000000000","message":"Fixed.","commit_id":"34ace4372a8b39fe286f82b4d1bc1c83cac60410"},{"author":{"_account_id":35002},"change_message_id":"00c9b73b8b9b436188f116db22798768741d0633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a3aa0ef_802b5da3","updated":"2023-06-21 13:30:57.000000000","message":"As I can see, this patch looks good to me","commit_id":"8196e70c6d8c5f9379de813b0ee7a7574975db95"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d476918eef77e82404f16e99e6af37dd7f50655d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c6c9aa75_37052d7a","updated":"2023-07-20 14:34:50.000000000","message":"Would be good to have a release note for this. Could you please add one?","commit_id":"8196e70c6d8c5f9379de813b0ee7a7574975db95"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"caf06ea9c82a2ca5785d8f567d3d7d4698bf7d4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"98fae6d3_c39c9bf7","updated":"2023-06-30 13:06:03.000000000","message":"lgtm","commit_id":"8196e70c6d8c5f9379de813b0ee7a7574975db95"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"449daacd509059462d1d790c33fa3c8721412ab9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b07b6f28_19ca235b","in_reply_to":"c6c9aa75_37052d7a","updated":"2023-07-20 14:51:57.000000000","message":"done.","commit_id":"8196e70c6d8c5f9379de813b0ee7a7574975db95"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"45da5a1660f83859b8439df41ad93fa62eabe1cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d44c0a22_ded6ad2b","updated":"2023-07-20 20:43:50.000000000","message":"LGTM, thanks Kiran","commit_id":"52fa619958a02bddf4b8c4fffa8ae73119b4d7ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b38e73b7cb7746dd7b7c195f26df20a440cc3bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e343d659_0762820c","updated":"2023-07-31 23:30:52.000000000","message":"Thanks for the update; a couple of comments inline regarding the error message","commit_id":"52fa619958a02bddf4b8c4fffa8ae73119b4d7ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9955bb5c39b410fd7bf0a8c888f001997e711c9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5d693c89_a25943f9","updated":"2023-08-01 18:50:07.000000000","message":"LGTM, thank you!","commit_id":"c88aac595b5754bc948fd3f618ecfab3d7f0c894"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e7d7c6078f86c5015e08f7613bddcd8eb66fb566","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fc030803_c6c8e153","updated":"2023-08-02 20:20:21.000000000","message":"LGTM, thanks for the updates, Kiran","commit_id":"c88aac595b5754bc948fd3f618ecfab3d7f0c894"}],"manila/api/common.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b38e73b7cb7746dd7b7c195f26df20a440cc3bb","unresolved":true,"context_lines":[{"line_number":272,"context_line":"        length \u003d len(field)"},{"line_number":273,"context_line":"        if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":274,"context_line":"            raise exception.InvalidInput("},{"line_number":275,"context_line":"                reason\u003d(\"Please use %(field_name)s up to %(len)d characters.\""},{"line_number":276,"context_line":"                        % {\u0027field_name\u0027: field_name,"},{"line_number":277,"context_line":"                           \u0027len\u0027: constants.DB_DISPLAY_FIELDS_MAX_LENGTH}))"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c2afcf14_6d85ee5b","line":275,"range":{"start_line":275,"start_character":25,"end_line":275,"end_character":36},"updated":"2023-07-31 23:30:52.000000000","message":"grammatically incorrect; \n\n \"%(field_name)s can only be %(len)d characters long.\"","commit_id":"8196e70c6d8c5f9379de813b0ee7a7574975db95"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"981abaf6db09f56b696500f3237c1bbb5952c08c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        length \u003d len(field)"},{"line_number":273,"context_line":"        if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":274,"context_line":"            raise exception.InvalidInput("},{"line_number":275,"context_line":"                reason\u003d(\"Please use %(field_name)s up to %(len)d characters.\""},{"line_number":276,"context_line":"                        % {\u0027field_name\u0027: field_name,"},{"line_number":277,"context_line":"                           \u0027len\u0027: constants.DB_DISPLAY_FIELDS_MAX_LENGTH}))"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b71a6e00_e4463f2b","line":275,"range":{"start_line":275,"start_character":25,"end_line":275,"end_character":36},"in_reply_to":"c2afcf14_6d85ee5b","updated":"2023-08-01 08:22:46.000000000","message":"Done","commit_id":"8196e70c6d8c5f9379de813b0ee7a7574975db95"}],"manila/api/v1/share_snapshots.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fd01cd18ce1440d9dba06042dc5f5924707395a4","unresolved":true,"context_lines":[{"line_number":179,"context_line":"            length \u003d len(update_dict[\u0027display_name\u0027])"},{"line_number":180,"context_line":"            if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":181,"context_line":"                raise exception.InvalidInput("},{"line_number":182,"context_line":"                    reason\u003d(_(\"Please use display name upto %s characters.\""},{"line_number":183,"context_line":"                              ) % constants.DB_DISPLAY_FIELDS_MAX_LENGTH))"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        if update_dict.get(\u0027display_description\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f909beb_5aed56ef","line":182,"range":{"start_line":182,"start_character":31,"end_line":182,"end_character":74},"updated":"2023-06-15 11:21:42.000000000","message":"`Please use name up to %s characters.`\n\nThe \u0027display\u0027 prefix is not user facing (see the view), \u0027up to\u0027 grammar","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a5f73e61db80024a552cc952c48af86bbe2a924e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            length \u003d len(update_dict[\u0027display_name\u0027])"},{"line_number":180,"context_line":"            if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":181,"context_line":"                raise exception.InvalidInput("},{"line_number":182,"context_line":"                    reason\u003d(_(\"Please use display name upto %s characters.\""},{"line_number":183,"context_line":"                              ) % constants.DB_DISPLAY_FIELDS_MAX_LENGTH))"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        if update_dict.get(\u0027display_description\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f83b660_56400558","line":182,"range":{"start_line":182,"start_character":31,"end_line":182,"end_character":74},"in_reply_to":"4f909beb_5aed56ef","updated":"2023-06-15 11:37:00.000000000","message":"Done","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fd01cd18ce1440d9dba06042dc5f5924707395a4","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            length \u003d len(update_dict[\u0027display_description\u0027])"},{"line_number":187,"context_line":"            if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":188,"context_line":"                raise exception.InvalidInput("},{"line_number":189,"context_line":"                    reason\u003d(_(\"Please use display description upto %s \""},{"line_number":190,"context_line":"                              \"characters.\""},{"line_number":191,"context_line":"                              ) % constants.DB_DISPLAY_FIELDS_MAX_LENGTH))"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e68c486c_32ac487e","line":190,"range":{"start_line":189,"start_character":31,"end_line":190,"end_character":42},"updated":"2023-06-15 11:21:42.000000000","message":"`Please use description up to %s characters.`\n\nThe \u0027display\u0027 prefix is not user facing (see the view), \u0027up to\u0027 grammar","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a5f73e61db80024a552cc952c48af86bbe2a924e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            length \u003d len(update_dict[\u0027display_description\u0027])"},{"line_number":187,"context_line":"            if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":188,"context_line":"                raise exception.InvalidInput("},{"line_number":189,"context_line":"                    reason\u003d(_(\"Please use display description upto %s \""},{"line_number":190,"context_line":"                              \"characters.\""},{"line_number":191,"context_line":"                              ) % constants.DB_DISPLAY_FIELDS_MAX_LENGTH))"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"db80befb_ac58d61e","line":190,"range":{"start_line":189,"start_character":31,"end_line":190,"end_character":42},"in_reply_to":"e68c486c_32ac487e","updated":"2023-06-15 11:37:00.000000000","message":"Done","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fd01cd18ce1440d9dba06042dc5f5924707395a4","unresolved":true,"context_lines":[{"line_number":238,"context_line":"                length \u003d len(snapshot[\u0027display_name\u0027])"},{"line_number":239,"context_line":"                if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":240,"context_line":"                    raise exception.InvalidInput("},{"line_number":241,"context_line":"                        reason\u003d(_(\"Please use display name upto %s characters.\""},{"line_number":242,"context_line":"                                  ) % constants.DB_DISPLAY_FIELDS_MAX_LENGTH))"},{"line_number":243,"context_line":"            del snapshot[\u0027name\u0027]"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"10928afd_7906db9a","line":241,"range":{"start_line":241,"start_character":35,"end_line":241,"end_character":78},"updated":"2023-06-15 11:21:42.000000000","message":"same like above","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a5f73e61db80024a552cc952c48af86bbe2a924e","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                length \u003d len(snapshot[\u0027display_name\u0027])"},{"line_number":239,"context_line":"                if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":240,"context_line":"                    raise exception.InvalidInput("},{"line_number":241,"context_line":"                        reason\u003d(_(\"Please use display name upto %s characters.\""},{"line_number":242,"context_line":"                                  ) % constants.DB_DISPLAY_FIELDS_MAX_LENGTH))"},{"line_number":243,"context_line":"            del snapshot[\u0027name\u0027]"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"642b361b_3823b0fd","line":241,"range":{"start_line":241,"start_character":35,"end_line":241,"end_character":78},"in_reply_to":"10928afd_7906db9a","updated":"2023-06-15 11:37:00.000000000","message":"Done","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fd01cd18ce1440d9dba06042dc5f5924707395a4","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                length \u003d len(snapshot[\u0027display_description\u0027])"},{"line_number":251,"context_line":"                if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":252,"context_line":"                    raise exception.InvalidInput("},{"line_number":253,"context_line":"                        reason\u003d(_(\"Please use display description upto %s \""},{"line_number":254,"context_line":"                                  \"characters.\""},{"line_number":255,"context_line":"                                  ) % constants.DB_DISPLAY_FIELDS_MAX_LENGTH))"},{"line_number":256,"context_line":"            del snapshot[\u0027description\u0027]"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fc81179_896a2ff8","line":254,"range":{"start_line":253,"start_character":36,"end_line":254,"end_character":47},"updated":"2023-06-15 11:21:42.000000000","message":"same like above","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a5f73e61db80024a552cc952c48af86bbe2a924e","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                length \u003d len(snapshot[\u0027display_description\u0027])"},{"line_number":251,"context_line":"                if length \u003e constants.DB_DISPLAY_FIELDS_MAX_LENGTH:"},{"line_number":252,"context_line":"                    raise exception.InvalidInput("},{"line_number":253,"context_line":"                        reason\u003d(_(\"Please use display description upto %s \""},{"line_number":254,"context_line":"                                  \"characters.\""},{"line_number":255,"context_line":"                                  ) % constants.DB_DISPLAY_FIELDS_MAX_LENGTH))"},{"line_number":256,"context_line":"            del snapshot[\u0027description\u0027]"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fcb86c3_dcc66991","line":254,"range":{"start_line":253,"start_character":36,"end_line":254,"end_character":47},"in_reply_to":"1fc81179_896a2ff8","updated":"2023-06-15 11:37:00.000000000","message":"Done","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b38e73b7cb7746dd7b7c195f26df20a440cc3bb","unresolved":true,"context_lines":[{"line_number":175,"context_line":"                       if key in snapshot_data}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        common.check_display_field_length("},{"line_number":178,"context_line":"            update_dict.get(\u0027display_name\u0027), \u0027name\u0027)"},{"line_number":179,"context_line":"        common.check_display_field_length("},{"line_number":180,"context_line":"            update_dict.get(\u0027display_description\u0027), \u0027description\u0027)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"52507da6_a71341e9","line":178,"range":{"start_line":178,"start_character":46,"end_line":178,"end_character":50},"updated":"2023-07-31 23:30:52.000000000","message":"see lines 168-171 and https://docs.openstack.org/api-ref/shared-file-system/?expanded\u003dupdate-share-snapshot-detail,update-share-detail#update-share-snapshot\n\n\nthe API accepts \"display_name\" and not \"name\" in the update; and \"display_description\" and not \"description\" in the update.. so the error message that you\u0027re creating in the \"check_display_field_length\" method should use the same field names..","commit_id":"52fa619958a02bddf4b8c4fffa8ae73119b4d7ad"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"981abaf6db09f56b696500f3237c1bbb5952c08c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                       if key in snapshot_data}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        common.check_display_field_length("},{"line_number":178,"context_line":"            update_dict.get(\u0027display_name\u0027), \u0027name\u0027)"},{"line_number":179,"context_line":"        common.check_display_field_length("},{"line_number":180,"context_line":"            update_dict.get(\u0027display_description\u0027), \u0027description\u0027)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e2d3b55d_18dbe817","line":178,"range":{"start_line":178,"start_character":46,"end_line":178,"end_character":50},"in_reply_to":"52507da6_a71341e9","updated":"2023-08-01 08:22:46.000000000","message":"Done","commit_id":"52fa619958a02bddf4b8c4fffa8ae73119b4d7ad"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b38e73b7cb7746dd7b7c195f26df20a440cc3bb","unresolved":true,"context_lines":[{"line_number":218,"context_line":"                       for key in valid_update_keys"},{"line_number":219,"context_line":"                       if key in share_data}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        common.check_display_field_length("},{"line_number":222,"context_line":"            update_dict.get(\u0027display_name\u0027), \u0027name\u0027)"},{"line_number":223,"context_line":"        common.check_display_field_length("},{"line_number":224,"context_line":"            update_dict.get(\u0027display_description\u0027), \u0027description\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        try:"},{"line_number":227,"context_line":"            share \u003d self.share_api.get(context, id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8ff2765c_74fa9cad","line":224,"range":{"start_line":221,"start_character":0,"end_line":224,"end_character":66},"updated":"2023-07-31 23:30:52.000000000","message":"this API doesn\u0027t allow \"name\" or \"description\" in the updates; only allows \"display_name\" or \"display_description\"; so the error message must use those names..","commit_id":"52fa619958a02bddf4b8c4fffa8ae73119b4d7ad"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"981abaf6db09f56b696500f3237c1bbb5952c08c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                       for key in valid_update_keys"},{"line_number":219,"context_line":"                       if key in share_data}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        common.check_display_field_length("},{"line_number":222,"context_line":"            update_dict.get(\u0027display_name\u0027), \u0027name\u0027)"},{"line_number":223,"context_line":"        common.check_display_field_length("},{"line_number":224,"context_line":"            update_dict.get(\u0027display_description\u0027), \u0027description\u0027)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        try:"},{"line_number":227,"context_line":"            share \u003d self.share_api.get(context, id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"efd593ff_46d40cfe","line":224,"range":{"start_line":221,"start_character":0,"end_line":224,"end_character":66},"in_reply_to":"8ff2765c_74fa9cad","updated":"2023-08-01 08:22:46.000000000","message":"Done","commit_id":"52fa619958a02bddf4b8c4fffa8ae73119b4d7ad"}],"manila/tests/api/v1/test_share_snapshots.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fd01cd18ce1440d9dba06042dc5f5924707395a4","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @ddt.data("},{"line_number":94,"context_line":"        {\u0027name\u0027: \u0027name1\u0027, \u0027description\u0027: \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":95,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":96,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":97,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":98,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027},"},{"line_number":99,"context_line":"        {\u0027name\u0027: \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":100,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":101,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"78977de6_35860afe","line":98,"range":{"start_line":94,"start_character":41,"end_line":98,"end_character":51},"updated":"2023-06-15 11:21:42.000000000","message":"I find it more readable in the format: `\u0027x\u0027 * 256` (or whatever number bigger than 255 you have here ;))","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a5f73e61db80024a552cc952c48af86bbe2a924e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @ddt.data("},{"line_number":94,"context_line":"        {\u0027name\u0027: \u0027name1\u0027, \u0027description\u0027: \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":95,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":96,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":97,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":98,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027},"},{"line_number":99,"context_line":"        {\u0027name\u0027: \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":100,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"},{"line_number":101,"context_line":"            \u0027xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"56a4e895_2c4f3bb6","line":98,"range":{"start_line":94,"start_character":41,"end_line":98,"end_character":51},"in_reply_to":"78977de6_35860afe","updated":"2023-06-15 11:37:00.000000000","message":"Done","commit_id":"31848b332b081811a58449851455d2496aa2b5ef"}]}