)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"da7b51182fb9543b41d7f52e96d12553f47106f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4bb22cbb_ca3e6eab","updated":"2023-07-06 14:18:57.000000000","message":"looks good overall, only one comment wrt to the view.\nThanks for working on this change, Kiran!","commit_id":"be1e5c7149ea9f85cc0997d04820550ff011b847"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5f1b0ce6512661a30a37d2be7acbd107e9f41dad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a5f4864_24f02d06","updated":"2023-07-10 06:27:45.000000000","message":"thanks for your chanage, Kiran Pawar.\n\nonly one nit, we also need to add doc about this.\n\nin manila/api-ref/source/snapshots.inc #line 73\n\nyou need to add  \n   - with_count: with_count_snapshot_query\n   \nin manila/api-ref/source/parameters.yaml #line 661\n\nyou need to add:\n    with_count_snapshot_query:\n      description: |\n        Whether to show ``count`` in API response or not, default is ``False``.\n    in: query\n    required: false\n    type: boolean\n    min_version: 2.79","commit_id":"be1e5c7149ea9f85cc0997d04820550ff011b847"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7232c7e50357d7ddbbc256c82e309180d3b2f2ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96b6047c_f8682a62","in_reply_to":"8a5f4864_24f02d06","updated":"2023-07-10 07:55:35.000000000","message":"done","commit_id":"be1e5c7149ea9f85cc0997d04820550ff011b847"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"dbfe3d3866c77842484c55356392eb6d289cac4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99bfa675_43507aab","updated":"2023-07-11 01:54:16.000000000","message":"LGTM","commit_id":"7aab0b5bbd32b2b8e636c5781d2920d9066a6ba1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"72f10b223d11717c9baf7ca2865430f4d1b5389e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5da1932b_49b5140b","updated":"2023-07-26 20:14:47.000000000","message":"I\u0027ve a comment inline regarding the \"detail\" method not ignoring the \"with_count\" attribute prior to API version 2.79. Since this patch has been on for a while, i\u0027ll go ahead and workflow this.. Kiran, could you please submit a minor bugfix patch to address the comment?","commit_id":"0e7812657b3ca90e618087b9fbb26816e60a90c3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1b0afbd92bf2097a9b6af0d318b28207720d3d68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b9e0635_e61c830a","updated":"2023-07-26 19:09:04.000000000","message":"LGTM, Kiran! Thanks for the doc enhancements!","commit_id":"0e7812657b3ca90e618087b9fbb26816e60a90c3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5956eb151f1a1a70ea3878503060797a5fb254ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2526319a_cdf28e99","updated":"2023-07-25 10:26:01.000000000","message":"recheck","commit_id":"0e7812657b3ca90e618087b9fbb26816e60a90c3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3da190251f18b882e206e34d834b5e309d4dabb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8aeac675_f6b572f5","updated":"2023-07-25 13:25:25.000000000","message":"recheck","commit_id":"0e7812657b3ca90e618087b9fbb26816e60a90c3"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"72f10b223d11717c9baf7ca2865430f4d1b5389e","unresolved":true,"context_lines":[{"line_number":429,"context_line":"  to Share Network Subnets."},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"2.79"},{"line_number":432,"context_line":"------------------------"},{"line_number":433,"context_line":"  Added ``with_count`` in share snapshot list API to get total count info."}],"source_content_type":"text/x-rst","patch_set":4,"id":"083acb53_43d2c684","line":432,"range":{"start_line":432,"start_character":4,"end_line":432,"end_character":24},"updated":"2023-07-26 20:14:47.000000000","message":"nit: underline must be as long as the text it decorates","commit_id":"0e7812657b3ca90e618087b9fbb26816e60a90c3"}],"manila/api/v2/share_snapshots.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"72f10b223d11717c9baf7ca2865430f4d1b5389e","unresolved":true,"context_lines":[{"line_number":348,"context_line":"        if req.api_version_request \u003c api_version.APIVersionRequest(\"2.36\"):"},{"line_number":349,"context_line":"            req.GET.pop(\u0027name~\u0027, None)"},{"line_number":350,"context_line":"            req.GET.pop(\u0027description~\u0027, None)"},{"line_number":351,"context_line":"            req.GET.pop(\u0027description\u0027, None)"},{"line_number":352,"context_line":"        return self._get_snapshots(req, is_detail\u003dTrue)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    @wsgi.Controller.api_version(\"2.73\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"6a015849_ea00c170","line":351,"range":{"start_line":351,"start_character":0,"end_line":351,"end_character":44},"updated":"2023-07-26 20:14:47.000000000","message":"you need to ignore the \"with_count\" search query until API version 2.79 here are well","commit_id":"0e7812657b3ca90e618087b9fbb26816e60a90c3"}],"manila/api/views/share_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"da7b51182fb9543b41d7f52e96d12553f47106f4","unresolved":true,"context_lines":[{"line_number":93,"context_line":"                                                     self._collection_name)"},{"line_number":94,"context_line":"        snapshots_dict \u003d {self._collection_name: snapshots_list}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if count is not None:"},{"line_number":97,"context_line":"            snapshots_dict[\u0027count\u0027] \u003d count"},{"line_number":98,"context_line":"        if snapshots_links:"},{"line_number":99,"context_line":"            snapshots_dict[\u0027share_snapshots_links\u0027] \u003d snapshots_links"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c34cdd91_b495b2fe","line":97,"range":{"start_line":96,"start_character":8,"end_line":97,"end_character":43},"updated":"2023-07-06 14:18:57.000000000","message":"please add this as a versioned method, as done in add_metadata, add_project_and_user_ids","commit_id":"be1e5c7149ea9f85cc0997d04820550ff011b847"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a052267cd1775c31d310922c2f7811075ddb3a5a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                                                     self._collection_name)"},{"line_number":94,"context_line":"        snapshots_dict \u003d {self._collection_name: snapshots_list}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if count is not None:"},{"line_number":97,"context_line":"            snapshots_dict[\u0027count\u0027] \u003d count"},{"line_number":98,"context_line":"        if snapshots_links:"},{"line_number":99,"context_line":"            snapshots_dict[\u0027share_snapshots_links\u0027] \u003d snapshots_links"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fd8f5684_baaeb00f","line":97,"range":{"start_line":96,"start_character":8,"end_line":97,"end_character":43},"in_reply_to":"2afd1421_b6e9aa1f","updated":"2023-07-07 12:19:27.000000000","message":"Ah, you\u0027re right. Thanks Kiran!","commit_id":"be1e5c7149ea9f85cc0997d04820550ff011b847"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f3a2d68f6c49b309a6681c01fda778bc04902586","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                                                     self._collection_name)"},{"line_number":94,"context_line":"        snapshots_dict \u003d {self._collection_name: snapshots_list}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if count is not None:"},{"line_number":97,"context_line":"            snapshots_dict[\u0027count\u0027] \u003d count"},{"line_number":98,"context_line":"        if snapshots_links:"},{"line_number":99,"context_line":"            snapshots_dict[\u0027share_snapshots_links\u0027] \u003d snapshots_links"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2afd1421_b6e9aa1f","line":97,"range":{"start_line":96,"start_character":8,"end_line":97,"end_character":43},"in_reply_to":"c34cdd91_b495b2fe","updated":"2023-07-07 07:14:29.000000000","message":"Versioned method are added to update individual fields within resource. Since count param as input is validated as version check, the view functions are called with non-None count only if version check is passed in input API. \n\u0027count\u0027 is additional field in resources dict and not single field in resource dict. So versioned method is not needed. Check similar implementation in views/shares.py","commit_id":"be1e5c7149ea9f85cc0997d04820550ff011b847"}]}