)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"081645da_67e0b847","updated":"2023-07-27 05:22:48.000000000","message":"Thank you for working on this, some comments inline","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b8982c03_bff0102e","updated":"2023-08-08 19:29:14.000000000","message":"Thanks for the review!","commit_id":"7b0560846670b762a40513d20e13dbfecaa2d01b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"18e30a3810e39cf3d92f4dfef4e35e41ab4e6dbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"541e4790_6eef2c2c","updated":"2023-08-11 19:35:53.000000000","message":"Thanks; LGTM; \n\nthis is a documentation change, so okay with single-core approval atm.. there is a concern about one of the parameters.. i think its an opportunity to fix inconsistencies that currently exist in the api ref. \n\nAshley, could you please push up a different change and address those comments?","commit_id":"3497062d496e63eb26270f21f221b139ff3f5025"}],"api-ref/source/samples/snapshot-set-metadata-request.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e6ec4854_6223c121","updated":"2023-07-27 05:22:48.000000000","message":"Please match the request and response: https://review.opendev.org/c/openstack/manila/+/887228/4/api-ref/source/samples/snapshot-set-metadata-response.json","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a94bdb2_5e86a9bc","in_reply_to":"e6ec4854_6223c121","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"}],"api-ref/source/snapshot-metadata.inc":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Snapshot metadata"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Shows, sets, updates, and unsets snapshot metadata."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"c1b35a3a_4d546499","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":17},"updated":"2023-07-27 05:22:48.000000000","message":"add: \"(Since API v2.73)\", like https://docs.openstack.org/api-ref/shared-file-system/#share-export-locations-since-api-v2-9","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Snapshot metadata"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Shows, sets, updates, and unsets snapshot metadata."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"503d89ea_5757a5d2","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":17},"in_reply_to":"c1b35a3a_4d546499","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":10,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method::  GET /v2/snapshots/{snapshot_id}/metadata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Shows all the metadata for a snapshot, as key and value pairs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Response codes"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"739e4276_f5a4672c","line":13,"updated":"2023-07-27 05:22:48.000000000","message":"after each \".. rest_method\" in this file, please add:\n\n .. versionadded:: 2.73\n \n See examples elsewhere on how this works..","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":10,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method::  GET /v2/snapshots/{snapshot_id}/metadata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Shows all the metadata for a snapshot, as key and value pairs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Response codes"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"392f7796_73841ff6","line":13,"in_reply_to":"739e4276_f5a4672c","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   - project_id: project_id_path"},{"line_number":36,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Response parameters"},{"line_number":39,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ddd7fe4d_9723b256","line":36,"range":{"start_line":36,"start_character":18,"end_line":36,"end_character":29},"updated":"2023-07-27 05:22:48.000000000","message":"this parameter is incorrect; the \"snapshot_id\" here needs to be in the \"path\" and not in the \"body\". Use this one instead: https://opendev.org/openstack/manila/src/commit/0e7812657b3ca90e618087b9fbb26816e60a90c3/api-ref/source/parameters.yaml#L150-L154","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   - project_id: project_id_path"},{"line_number":36,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Response parameters"},{"line_number":39,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9013b278_3856877b","line":36,"range":{"start_line":36,"start_character":18,"end_line":36,"end_character":29},"in_reply_to":"ddd7fe4d_9723b256","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   - project_id: project_id_path"},{"line_number":81,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":82,"context_line":"   - key: metadata_key_request"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Response parameters"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"47067537_6c884163","line":81,"range":{"start_line":81,"start_character":18,"end_line":81,"end_character":29},"updated":"2023-07-27 05:22:48.000000000","message":"same comment as above","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   - project_id: project_id_path"},{"line_number":81,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":82,"context_line":"   - key: metadata_key_request"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Response parameters"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1c41ee26_bf388f56","line":81,"range":{"start_line":81,"start_character":18,"end_line":81,"end_character":29},"in_reply_to":"47067537_6c884163","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   - project_id: project_id_path"},{"line_number":81,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":82,"context_line":"   - key: metadata_key_request"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Response parameters"},{"line_number":85,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"23049cbd_3016bd93","line":82,"range":{"start_line":82,"start_character":10,"end_line":82,"end_character":30},"updated":"2023-07-27 05:22:48.000000000","message":"this one is incorrect - it refers to a body element, use this one instead: https://opendev.org/openstack/manila/src/commit/0e7812657b3ca90e618087b9fbb26816e60a90c3/api-ref/source/parameters.yaml#L41-L48","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   - project_id: project_id_path"},{"line_number":81,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":82,"context_line":"   - key: metadata_key_request"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Response parameters"},{"line_number":85,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"65be29e7_20daec63","line":82,"range":{"start_line":82,"start_character":10,"end_line":82,"end_character":30},"in_reply_to":"23049cbd_3016bd93","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":126,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"   - project_id: project_id_path"},{"line_number":129,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":130,"context_line":"   - metadata: metadata_request"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"f5f467bd_f35bcf8c","line":129,"range":{"start_line":129,"start_character":18,"end_line":129,"end_character":29},"updated":"2023-07-27 05:22:48.000000000","message":"snapshot_id_path","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":126,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"   - project_id: project_id_path"},{"line_number":129,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":130,"context_line":"   - metadata: metadata_request"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"df010c32_d8dddf30","line":129,"range":{"start_line":129,"start_character":18,"end_line":129,"end_character":29},"in_reply_to":"f5f467bd_f35bcf8c","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":179,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"   - project_id: project_id_path"},{"line_number":182,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":183,"context_line":"   - metadata: metadata_request"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1a910e85_4047fdfc","line":182,"range":{"start_line":182,"start_character":18,"end_line":182,"end_character":29},"updated":"2023-07-27 05:22:48.000000000","message":"snapshot_id_path","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":179,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"   - project_id: project_id_path"},{"line_number":182,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":183,"context_line":"   - metadata: metadata_request"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ad8d3a7d_4710afe3","line":182,"range":{"start_line":182,"start_character":18,"end_line":182,"end_character":29},"in_reply_to":"1a910e85_4047fdfc","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":248,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"   - project_id: project_id_path"},{"line_number":251,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":252,"context_line":"   - key: metadata_key_request"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"20051c7d_503311aa","line":251,"range":{"start_line":251,"start_character":18,"end_line":251,"end_character":29},"updated":"2023-07-27 05:22:48.000000000","message":"snapshot_id_path","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":248,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"   - project_id: project_id_path"},{"line_number":251,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":252,"context_line":"   - key: metadata_key_request"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"780807db_3411107a","line":251,"range":{"start_line":251,"start_character":18,"end_line":251,"end_character":29},"in_reply_to":"20051c7d_503311aa","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a2cbfc8dbe76cc45199fed76230fa30434f84be","unresolved":true,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"   - project_id: project_id_path"},{"line_number":251,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":252,"context_line":"   - key: metadata_key_request"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"de78f880_5dc61cc1","line":252,"range":{"start_line":252,"start_character":10,"end_line":252,"end_character":30},"updated":"2023-07-27 05:22:48.000000000","message":"metadata_key_path","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2d5ad76f69c8fd8fbc79a9f23f2c5ffc98736f31","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"   - project_id: project_id_path"},{"line_number":251,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":252,"context_line":"   - key: metadata_key_request"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"29a7ab25_a5c11b00","line":252,"range":{"start_line":252,"start_character":10,"end_line":252,"end_character":30},"in_reply_to":"de78f880_5dc61cc1","updated":"2023-08-08 19:29:14.000000000","message":"Done","commit_id":"8077eaa701d88b75957132e2d8b0102591bb65a9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"18e30a3810e39cf3d92f4dfef4e35e41ab4e6dbb","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"   - project_id: project_id_path"},{"line_number":85,"context_line":"   - snapshot_id: snapshot_id_path"},{"line_number":86,"context_line":"   - key: metadata_key_path"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Response parameters"},{"line_number":89,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"b4018fb0_5a008e18","line":86,"range":{"start_line":86,"start_character":10,"end_line":86,"end_character":27},"updated":"2023-08-11 19:35:53.000000000","message":"unsure why this one is set as \"optional\"; the only other use of this is https://opendev.org/openstack/manila/src/branch/master/api-ref/source/share-access-rule-metadata.inc#L93 \n\nand even there, it shouldn\u0027t be optional; can you please set the \"required\" field to True in the corresponding definition in parameters.yaml?\n\nAlso, https://opendev.org/openstack/manila/src/commit/0b99fdaa9a6ee33244e4560ddf2cc767afb5bf80/api-ref/source/share-metadata.inc#L82 needs to reference this parameter instead of a \"body\" parameter (\"metadata_key_request\") that it currently uses.. \n\nmaybe these modifications can come in a different change","commit_id":"3497062d496e63eb26270f21f221b139ff3f5025"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"18e30a3810e39cf3d92f4dfef4e35e41ab4e6dbb","unresolved":true,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"   - project_id: project_id_path"},{"line_number":261,"context_line":"   - snapshot_id: snapshot_id_path"},{"line_number":262,"context_line":"   - key: metadata_key_path"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"149ac663_56f2b006","line":262,"updated":"2023-08-11 19:35:53.000000000","message":"same comment as above; the problem isn\u0027t here.. its in the definiton of this parameter in parameters.yaml; please set \"required: true\": https://opendev.org/openstack/manila/src/commit/0b99fdaa9a6ee33244e4560ddf2cc767afb5bf80/api-ref/source/parameters.yaml#L41-L48\n\n\nand also please fix up https://opendev.org/openstack/manila/src/commit/0b99fdaa9a6ee33244e4560ddf2cc767afb5bf80/api-ref/source/share-metadata.inc#L252 as well in the same change","commit_id":"3497062d496e63eb26270f21f221b139ff3f5025"}]}