)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"9c3a65d10ca1549e01f3de35bbfd61b38036f6ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ffecb79_16156c77","updated":"2023-07-06 17:10:09.000000000","message":"recheck intermitent failures","commit_id":"fb44b04282f12b5ab643918ddf0087b35a733de6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fcb9480647542eb914ecfcfa833d1935a7076abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a9e8ff02_a8c2f7be","updated":"2023-09-13 17:59:12.000000000","message":"Looking good, thanks for the enhancement","commit_id":"b62d56352a6c77745416d4059fd910a7c76c7274"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"3b2391aa2547ad9092661fdf9d134565c83074ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86801d80_519a23f7","updated":"2023-09-13 12:45:30.000000000","message":"Looks good, thanks for the change. One comment in line.","commit_id":"b62d56352a6c77745416d4059fd910a7c76c7274"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1075a8ba23c595dd4dd320a3ee9ffd2d87d32c58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d547c4ae_988056b5","updated":"2023-09-12 12:30:57.000000000","message":"recheck\nJobs are running now, let\u0027s give it another try","commit_id":"b62d56352a6c77745416d4059fd910a7c76c7274"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"69c7922641d97927481d8248956611bc01ae5b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32f13ae9_b1784631","updated":"2024-01-31 22:48:19.000000000","message":"hi; a comment inline regarding the import order in one of the files; else this LGTM.. thanks Ashley!","commit_id":"cf70e06c1bbbc0801b10cfe4ac94710218a1f29b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5f2787d2b6508e25ffac5f7144c954159244ea69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a4bf3db_0209b1dd","updated":"2023-12-06 18:59:32.000000000","message":"recheck old logs","commit_id":"cf70e06c1bbbc0801b10cfe4ac94710218a1f29b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"92985f95ebc7f34cb6dd08677a31ce6e3d3f479b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fc9e2c3b_cf2e85a1","updated":"2024-01-10 20:26:41.000000000","message":"recheck old logs","commit_id":"cf70e06c1bbbc0801b10cfe4ac94710218a1f29b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"470d577e66169b0bd9af02b95183c914245ef792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"84562639_866400d2","updated":"2024-02-06 18:16:13.000000000","message":"Ashley, one more import fix that\u0027d be good to make before we merge this","commit_id":"17380799c4622824eaa8dccf461a4db2a02f10bc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c84db81dff0466815a35d895947e1c606eb18784","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f85a78e8_34e611e9","updated":"2024-02-07 01:22:03.000000000","message":"LGTM thanks!","commit_id":"47e7c78f3774d12d556e9ab51f3e04eb5432c24b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"718759fd705ba190ffbb3ce90f158eae1fdb6f2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2dc86eaf_834e51b8","updated":"2024-02-20 15:36:57.000000000","message":"LGTM, scenario tests and the jobs for drivers using this are happy, so we can ensure it is properly tested.\nThank you for working on this change :)","commit_id":"47e7c78f3774d12d556e9ab51f3e04eb5432c24b"}],"manila/exception.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"3b2391aa2547ad9092661fdf9d134565c83074ce","unresolved":true,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"class RequirementMissing(ManilaException):"},{"line_number":567,"context_line":"    message \u003d _(\u0027Requirement %(req)s is not installed.\u0027)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"class ExportLocationNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5145b9b6_a41e2cc3","line":567,"updated":"2023-09-13 12:45:30.000000000","message":"May be good to use \"\" quotes for style consistency.","commit_id":"b62d56352a6c77745416d4059fd910a7c76c7274"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5794fd5555a8a5537134c0672436f61dcfbafbb7","unresolved":false,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"class RequirementMissing(ManilaException):"},{"line_number":567,"context_line":"    message \u003d _(\u0027Requirement %(req)s is not installed.\u0027)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"class ExportLocationNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":2,"id":"b041b15d_ba080aff","line":567,"in_reply_to":"5145b9b6_a41e2cc3","updated":"2023-11-03 15:44:04.000000000","message":"Done","commit_id":"b62d56352a6c77745416d4059fd910a7c76c7274"}],"manila/ssh_utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"69c7922641d97927481d8248956611bc01ae5b3a","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from eventlet import pools"},{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila.i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":6,"id":"35e6332f_b9df6db9","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":25},"updated":"2024-01-31 22:48:19.000000000","message":"these packages must be in the third group:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"cf70e06c1bbbc0801b10cfe4ac94710218a1f29b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"b8a578357ac3a01217724b159c28d73c433f5577","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from eventlet import pools"},{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila.i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a5dba42_69305555","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":25},"in_reply_to":"35e6332f_b9df6db9","updated":"2024-02-06 17:49:16.000000000","message":"Done","commit_id":"cf70e06c1bbbc0801b10cfe4ac94710218a1f29b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"69c7922641d97927481d8248956611bc01ae5b3a","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila.i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"from oslo_utils.secretutils import md5"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"e9fa8877_d4670593","line":24,"range":{"start_line":22,"start_character":0,"end_line":24,"end_character":38},"updated":"2024-01-31 22:48:19.000000000","message":"this belongs in the second group","commit_id":"cf70e06c1bbbc0801b10cfe4ac94710218a1f29b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"b8a578357ac3a01217724b159c28d73c433f5577","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from manila import exception"},{"line_number":20,"context_line":"from manila.i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"from oslo_utils.secretutils import md5"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5d48b501_670eed3f","line":24,"range":{"start_line":22,"start_character":0,"end_line":24,"end_character":38},"in_reply_to":"e9fa8877_d4670593","updated":"2024-02-06 17:49:16.000000000","message":"Done","commit_id":"cf70e06c1bbbc0801b10cfe4ac94710218a1f29b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"470d577e66169b0bd9af02b95183c914245ef792","unresolved":true,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from eventlet import pools"},{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":7,"id":"fba32e04_b7791879","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":14},"updated":"2024-02-06 18:16:13.000000000","message":"logging is part of std lib and belongs in the group above; and eventlet is a third party lib that belongs in the group below","commit_id":"17380799c4622824eaa8dccf461a4db2a02f10bc"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"8c4e1b7f5f6e14458e6fed7040c506348102d95c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from eventlet import pools"},{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":7,"id":"80bdf36b_b2214090","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":14},"in_reply_to":"fba32e04_b7791879","updated":"2024-02-06 20:31:46.000000000","message":"Acknowledged","commit_id":"17380799c4622824eaa8dccf461a4db2a02f10bc"}],"manila/utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10f21d588bea9a01cbb46f6c5cf9dda3795fc63a","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    return md5(self.asbytes(), usedforsecurity\u003dFalse).digest()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"if paramiko is None:"},{"line_number":82,"context_line":"    raise exception.RequirementMissing(req\u003d\u0027paramiko\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"paramiko.pkey.PKey.get_fingerprint \u003d get_fingerprint"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a80a5de3_b0ce49f7","line":82,"range":{"start_line":80,"start_character":0,"end_line":82,"end_character":54},"updated":"2023-09-15 00:16:33.000000000","message":"i don\u0027t think this will work unfortunately; if paramiko isn\u0027t installed, importing this utils module will cause an exception to be raised. \n\nA lot of manila code imports this utils module, even if the paramiko related code in \"SSHPool\" isn\u0027t used; so in effect, this conditional import to get FIPS compliance will not work, even when we swear by not invoking paramiko at runtime.\n\n\nWhat could work is this:\n\nrefactor this module and remove \"SSHPool\" and paramiko related code from here -- move it to a different file, perhaps \"ssh_utils.py\"; and make the import conditional there. \n\n\nAnother thing is that we have other imports of paramiko here:\n\nwe aren\u0027t dealing with those?\n\nhttps://codesearch.opendev.org/?q\u003dparamiko\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003dopenstack/manila","commit_id":"b62d56352a6c77745416d4059fd910a7c76c7274"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5794fd5555a8a5537134c0672436f61dcfbafbb7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    return md5(self.asbytes(), usedforsecurity\u003dFalse).digest()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"if paramiko is None:"},{"line_number":82,"context_line":"    raise exception.RequirementMissing(req\u003d\u0027paramiko\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"paramiko.pkey.PKey.get_fingerprint \u003d get_fingerprint"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"35458de8_9a5cacf3","line":82,"range":{"start_line":80,"start_character":0,"end_line":82,"end_character":54},"in_reply_to":"a80a5de3_b0ce49f7","updated":"2023-11-03 15:44:04.000000000","message":"applied changes, and unit tests passed locally. lets see what CI says.","commit_id":"b62d56352a6c77745416d4059fd910a7c76c7274"}]}