)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd3a7f1ece71ecb48b299045f41ef402a45f971f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Improve coverage of REST API feature merged in stable 2023.1."},{"line_number":10,"context_line":"Fix Netapp internals tests DHSS True and DHSS False REST:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Fix test_netapp_nfs_config.NetAppNFSConfigTest"},{"line_number":13,"context_line":"- Fix set_volume_snapdir_access"},{"line_number":14,"context_line":"- test_netapp_nfs_config.NetAppNFSConfigTest"},{"line_number":15,"context_line":"- set_volume_snapdir_access"},{"line_number":16,"context_line":"- promote multiple share replicas"},{"line_number":17,"context_line":"- test_tc413_cifs_access_permissions"},{"line_number":18,"context_line":"- test_tc517_security_style"},{"line_number":19,"context_line":"- test_preferred_address"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"partially-implements: bp netapp-ontap-rest-api-client"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-authored-by: Caique Mello \u003ccaiquemellosbo@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ad706557_77932289","line":20,"range":{"start_line":12,"start_character":0,"end_line":20,"end_character":0},"updated":"2023-07-27 05:33:59.000000000","message":"These aren\u0027t tests we know anything about :) \n\nIs there any user visible change due to the modifications in this patch? If yes, please write a release note calling out the enhancements/fixes. It would definitely be useful when you backport this change to stable/2023.1","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"0ce62bb2aecaab66514cdc842da9adab8b6ed91b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Improve coverage of REST API feature merged in stable 2023.1."},{"line_number":10,"context_line":"Fix Netapp internals tests DHSS True and DHSS False REST:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Fix test_netapp_nfs_config.NetAppNFSConfigTest"},{"line_number":13,"context_line":"- Fix set_volume_snapdir_access"},{"line_number":14,"context_line":"- test_netapp_nfs_config.NetAppNFSConfigTest"},{"line_number":15,"context_line":"- set_volume_snapdir_access"},{"line_number":16,"context_line":"- promote multiple share replicas"},{"line_number":17,"context_line":"- test_tc413_cifs_access_permissions"},{"line_number":18,"context_line":"- test_tc517_security_style"},{"line_number":19,"context_line":"- test_preferred_address"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"partially-implements: bp netapp-ontap-rest-api-client"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-authored-by: Caique Mello \u003ccaiquemellosbo@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"aa7635a4_c5a52a3d","line":20,"range":{"start_line":12,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"ad706557_77932289","updated":"2023-07-27 13:08:28.000000000","message":"There is no visible change for the user, just some modifications to adapt the behavior of rest in the NetApp Internals Test","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"7821d7390674b54e136c8362cf7983a694df6b6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"962d5b58_f56e83f5","updated":"2023-07-13 12:02:54.000000000","message":"Thanks Thiago!, comment solved, please take a look","commit_id":"06885cd5c0dcbfa40ab3431f72426f62785c38ca"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"13b2a65fdea6a939460017e71ccd891964e83539","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f4424bd_7b7d6baa","updated":"2023-07-12 20:12:39.000000000","message":"Thanks for the patch, Renan and other contributors. Just one inline important comment.","commit_id":"06885cd5c0dcbfa40ab3431f72426f62785c38ca"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"31ca8ee3beddb648e16e71c31717d710623cf5a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ca74f4b9_a5268c2a","in_reply_to":"7f4424bd_7b7d6baa","updated":"2023-07-13 14:36:08.000000000","message":"Done","commit_id":"06885cd5c0dcbfa40ab3431f72426f62785c38ca"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"df1025043afb2291a2f81adf44efb32fdad527d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ddb93be_d9370562","updated":"2023-07-13 13:55:01.000000000","message":"run-NetApp CI","commit_id":"4bcd2d8bc195f3f70290083a0bd41d4c888227d9"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e2667c7dc65affd9fdcdcd5fbebb825cd97a50e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e5dcb28_598accd4","updated":"2023-07-13 18:47:20.000000000","message":"Hi Renan, thank you. Internal QA done and all seems to be good. REST internals were success.","commit_id":"b86d4edabcd676724960c47786d4e1d97794e6c1"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"31ca8ee3beddb648e16e71c31717d710623cf5a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2afbcbde_a9b6ee20","updated":"2023-07-13 14:36:08.000000000","message":"Thanks Renan","commit_id":"b86d4edabcd676724960c47786d4e1d97794e6c1"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"382bd6e14df7ec435134878f9696b662d0c779ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f36033c3_79b6305a","updated":"2023-07-26 12:44:13.000000000","message":"LGTM thank you Renan.","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd3a7f1ece71ecb48b299045f41ef402a45f971f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"528b6e19_0ca19796","updated":"2023-07-27 05:33:59.000000000","message":"Thanks for working on this! Please see comments inline","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"bc9dc6a0cf86205f224b087236cacf592ebea42d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9d1b3201_66bd76a9","updated":"2023-07-26 13:15:41.000000000","message":"The NetAppCI got some intermittence, them we need to test some times to pass the jobs, we can see the documentation of these jobs here [1]\n\n[1] https://paste.opendev.org/show/bZ062fTnO585gCoeAjeW/","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"557902e8764769869a9d2357235c2dfd8c736569","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2417d068_b5ae7a6f","updated":"2023-07-20 13:38:01.000000000","message":"recheck - zuul failures not related to the patch","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"0ce62bb2aecaab66514cdc842da9adab8b6ed91b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b95047ae_12dd40d1","updated":"2023-07-27 13:08:28.000000000","message":"Thanks Goutham for the review!. I\u0027ve made some corrections, could you please take a look?","commit_id":"9d7b5543bf5f3f77b885d36c45db808cf20de211"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"289966757c68e9c2e3d82032abfd231b1c6e9a8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a03d8e4_f384f176","updated":"2023-07-28 12:09:58.000000000","message":"LGTM Guys, thanks!","commit_id":"a051187212b09546f8e3aaab70c6f94d5e05ad2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e20b71ba59d7e4e6d800c24f48474d228008fcf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9302165e_162c503a","updated":"2023-07-27 17:27:47.000000000","message":"Thank you for the update, LGTM; okay with the reasoning about the NetApp CI... i hope you\u0027re able to get it up and running properly again","commit_id":"a051187212b09546f8e3aaab70c6f94d5e05ad2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a9b37d6c94c73a5ad6d12ca8512e9e8b27af91b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5dee3a34_70e94731","updated":"2023-08-03 10:21:38.000000000","message":"LGTM, thanks for rebasing the change","commit_id":"b4cc96d5fd6d1bb283300aeaf085deb1858877bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"26fedc922201d5e55425f4b4d583c52d85129e18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"92fb1a3c_9bee8b9c","updated":"2023-08-04 00:53:00.000000000","message":"Renan, can you check if we can backport this to stable/2023.1?","commit_id":"b4cc96d5fd6d1bb283300aeaf085deb1858877bd"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"13b2a65fdea6a939460017e71ccd891964e83539","unresolved":true,"context_lines":[{"line_number":1044,"context_line":"        if adaptive_qos_policy_group is not None:"},{"line_number":1045,"context_line":"            body[\u0027qos.policy.name\u0027] \u003d adaptive_qos_policy_group"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"        if encrypt is True:"},{"line_number":1048,"context_line":"            if not self.features.FLEXVOL_ENCRYPTION:"},{"line_number":1049,"context_line":"                msg \u003d \u0027Flexvol encryption is not supported on this backend.\u0027"},{"line_number":1050,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1051,"context_line":"            else:"},{"line_number":1052,"context_line":"                body[\u0027encryption.enabled\u0027] \u003d \u0027true\u0027"},{"line_number":1053,"context_line":"        else:"},{"line_number":1054,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027false\u0027"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"        return body"},{"line_number":1057,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cc6bcc0c_5ffd1d1b","line":1054,"range":{"start_line":1047,"start_character":8,"end_line":1054,"end_character":48},"updated":"2023-07-12 20:12:39.000000000","message":"nit: I think it would be good place this check/raise a possible exception before these other ifs, since they don\u0027t affect each other, and it prevents running unnecessary code.","commit_id":"06885cd5c0dcbfa40ab3431f72426f62785c38ca"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"31ca8ee3beddb648e16e71c31717d710623cf5a9","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        if adaptive_qos_policy_group is not None:"},{"line_number":1045,"context_line":"            body[\u0027qos.policy.name\u0027] \u003d adaptive_qos_policy_group"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"        if encrypt is True:"},{"line_number":1048,"context_line":"            if not self.features.FLEXVOL_ENCRYPTION:"},{"line_number":1049,"context_line":"                msg \u003d \u0027Flexvol encryption is not supported on this backend.\u0027"},{"line_number":1050,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1051,"context_line":"            else:"},{"line_number":1052,"context_line":"                body[\u0027encryption.enabled\u0027] \u003d \u0027true\u0027"},{"line_number":1053,"context_line":"        else:"},{"line_number":1054,"context_line":"            body[\u0027encryption.enabled\u0027] \u003d \u0027false\u0027"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"        return body"},{"line_number":1057,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fc5c883e_1d763d26","line":1054,"range":{"start_line":1047,"start_character":8,"end_line":1054,"end_character":48},"in_reply_to":"cc6bcc0c_5ffd1d1b","updated":"2023-07-13 14:36:08.000000000","message":"Done","commit_id":"06885cd5c0dcbfa40ab3431f72426f62785c38ca"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"13b2a65fdea6a939460017e71ccd891964e83539","unresolved":true,"context_lines":[{"line_number":4553,"context_line":"    def _configure_nfs(self, nfs_config, svm_id):"},{"line_number":4554,"context_line":"        \"\"\"Sets the nfs configuraton\"\"\""},{"line_number":4555,"context_line":""},{"line_number":4556,"context_line":"        if (nfs_config[\u0027udp-max-xfer-size\u0027] !\u003d str(DEFAULT_UDP_MAX_XFER_SIZE)"},{"line_number":4557,"context_line":"                and \u0027udp-max-xfer-size\u0027 in nfs_config):"},{"line_number":4558,"context_line":""},{"line_number":4559,"context_line":"            msg \u003d _(\u0027Failed to configure NFS. REST API does not support \u0027"},{"line_number":4560,"context_line":"                    \u0027setting udp-max-xfer-size default value %(default)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"8acb8886_11b8625d","line":4557,"range":{"start_line":4556,"start_character":8,"end_line":4557,"end_character":55},"updated":"2023-07-12 20:12:39.000000000","message":"It\u0027s better to change the conditionals position to prevent an access to a nonexistent index bug, like did it happen on test_configure_nfs UT [1] in this CI execution [2].\n\n[1] https://review.opendev.org/c/openstack/manila/+/887562/1/manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode_rest.py#4491\n[2] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f71/887562/1/check/openstack-tox-cover/f718be6/testr_results.html","commit_id":"06885cd5c0dcbfa40ab3431f72426f62785c38ca"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"7821d7390674b54e136c8362cf7983a694df6b6f","unresolved":false,"context_lines":[{"line_number":4553,"context_line":"    def _configure_nfs(self, nfs_config, svm_id):"},{"line_number":4554,"context_line":"        \"\"\"Sets the nfs configuraton\"\"\""},{"line_number":4555,"context_line":""},{"line_number":4556,"context_line":"        if (nfs_config[\u0027udp-max-xfer-size\u0027] !\u003d str(DEFAULT_UDP_MAX_XFER_SIZE)"},{"line_number":4557,"context_line":"                and \u0027udp-max-xfer-size\u0027 in nfs_config):"},{"line_number":4558,"context_line":""},{"line_number":4559,"context_line":"            msg \u003d _(\u0027Failed to configure NFS. REST API does not support \u0027"},{"line_number":4560,"context_line":"                    \u0027setting udp-max-xfer-size default value %(default)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1f041a1_827d2db7","line":4557,"range":{"start_line":4556,"start_character":8,"end_line":4557,"end_character":55},"in_reply_to":"8acb8886_11b8625d","updated":"2023-07-13 12:02:54.000000000","message":"Done!","commit_id":"06885cd5c0dcbfa40ab3431f72426f62785c38ca"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd3a7f1ece71ecb48b299045f41ef402a45f971f","unresolved":true,"context_lines":[{"line_number":1195,"context_line":"        try:"},{"line_number":1196,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1197,"context_line":"        except exception.NetAppException:"},{"line_number":1198,"context_line":"            LOG.debug(\"Could not find volume to set snapdir access.\")"},{"line_number":1199,"context_line":"            raise exception.SnapshotResourceNotFound(name\u003dvolume_name)"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3b4a6e2b_bc183d62","line":1198,"range":{"start_line":1198,"start_character":16,"end_line":1198,"end_character":21},"updated":"2023-07-27 05:33:59.000000000","message":"LOG.error or LOG.exception seem more appropriate","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"0ce62bb2aecaab66514cdc842da9adab8b6ed91b","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"        try:"},{"line_number":1196,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1197,"context_line":"        except exception.NetAppException:"},{"line_number":1198,"context_line":"            LOG.debug(\"Could not find volume to set snapdir access.\")"},{"line_number":1199,"context_line":"            raise exception.SnapshotResourceNotFound(name\u003dvolume_name)"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"c28f7857_77ef65b0","line":1198,"range":{"start_line":1198,"start_character":16,"end_line":1198,"end_character":21},"in_reply_to":"3b4a6e2b_bc183d62","updated":"2023-07-27 13:08:28.000000000","message":"Done","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd3a7f1ece71ecb48b299045f41ef402a45f971f","unresolved":true,"context_lines":[{"line_number":1886,"context_line":"        try:"},{"line_number":1887,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1888,"context_line":"        except exception.NetAppException:"},{"line_number":1889,"context_line":"            LOG.debug(\"Could not find volume to get snapshot.\")"},{"line_number":1890,"context_line":"            raise exception.SnapshotResourceNotFound(name\u003dsnapshot_name)"},{"line_number":1891,"context_line":""},{"line_number":1892,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"94e36952_506ebfff","line":1889,"range":{"start_line":1889,"start_character":16,"end_line":1889,"end_character":21},"updated":"2023-07-27 05:33:59.000000000","message":"same comment as above","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"0ce62bb2aecaab66514cdc842da9adab8b6ed91b","unresolved":false,"context_lines":[{"line_number":1886,"context_line":"        try:"},{"line_number":1887,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1888,"context_line":"        except exception.NetAppException:"},{"line_number":1889,"context_line":"            LOG.debug(\"Could not find volume to get snapshot.\")"},{"line_number":1890,"context_line":"            raise exception.SnapshotResourceNotFound(name\u003dsnapshot_name)"},{"line_number":1891,"context_line":""},{"line_number":1892,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ce0bf8d6_aadaebe1","line":1889,"range":{"start_line":1889,"start_character":16,"end_line":1889,"end_character":21},"in_reply_to":"94e36952_506ebfff","updated":"2023-07-27 13:08:28.000000000","message":"Done","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd3a7f1ece71ecb48b299045f41ef402a45f971f","unresolved":true,"context_lines":[{"line_number":1953,"context_line":"        try:"},{"line_number":1954,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1955,"context_line":"        except exception.NetAppException:"},{"line_number":1956,"context_line":"            LOG.debug(\"Could not find volume to delete snapshot.\")"},{"line_number":1957,"context_line":"            return"},{"line_number":1958,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"},{"line_number":1959,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"82b18c24_4356cc76","line":1956,"range":{"start_line":1956,"start_character":16,"end_line":1956,"end_character":21},"updated":"2023-07-27 05:33:59.000000000","message":"LOG.warning\n\nalso, print the volume name in the log message, perhaps?","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"0ce62bb2aecaab66514cdc842da9adab8b6ed91b","unresolved":false,"context_lines":[{"line_number":1953,"context_line":"        try:"},{"line_number":1954,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1955,"context_line":"        except exception.NetAppException:"},{"line_number":1956,"context_line":"            LOG.debug(\"Could not find volume to delete snapshot.\")"},{"line_number":1957,"context_line":"            return"},{"line_number":1958,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"},{"line_number":1959,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"49d471c8_d8cbac46","line":1956,"range":{"start_line":1956,"start_character":16,"end_line":1956,"end_character":21},"in_reply_to":"82b18c24_4356cc76","updated":"2023-07-27 13:08:28.000000000","message":"Done","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd3a7f1ece71ecb48b299045f41ef402a45f971f","unresolved":true,"context_lines":[{"line_number":3105,"context_line":""},{"line_number":3106,"context_line":"        self.send_request(\u0027/storage/volumes\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3107,"context_line":""},{"line_number":3108,"context_line":"        # NOTE(nahimsouza): QoS policy can not be setted during the cloning"},{"line_number":3109,"context_line":"        # process, so we need to make a separate request."},{"line_number":3110,"context_line":"        if qos_policy_group is not None:"},{"line_number":3111,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c579cd5_3ca9b7dd","line":3108,"range":{"start_line":3108,"start_character":50,"end_line":3108,"end_character":56},"updated":"2023-07-27 05:33:59.000000000","message":"nit: set","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"0ce62bb2aecaab66514cdc842da9adab8b6ed91b","unresolved":false,"context_lines":[{"line_number":3105,"context_line":""},{"line_number":3106,"context_line":"        self.send_request(\u0027/storage/volumes\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3107,"context_line":""},{"line_number":3108,"context_line":"        # NOTE(nahimsouza): QoS policy can not be setted during the cloning"},{"line_number":3109,"context_line":"        # process, so we need to make a separate request."},{"line_number":3110,"context_line":"        if qos_policy_group is not None:"},{"line_number":3111,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"cda7e336_443a97c9","line":3108,"range":{"start_line":3108,"start_character":50,"end_line":3108,"end_character":56},"in_reply_to":"4c579cd5_3ca9b7dd","updated":"2023-07-27 13:08:28.000000000","message":"Done","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd3a7f1ece71ecb48b299045f41ef402a45f971f","unresolved":true,"context_lines":[{"line_number":3304,"context_line":"                           source_vserver\u003dNone, dest_vserver\u003dNone,"},{"line_number":3305,"context_line":"                           source_volume\u003dNone, dest_volume\u003dNone):"},{"line_number":3306,"context_line":"        \"\"\"Update a snapmirror relationship asynchronously.\"\"\""},{"line_number":3307,"context_line":"        snapmirrors \u003d self.get_snapmirrors(source_path, dest_path,"},{"line_number":3308,"context_line":"                                           source_vserver, dest_vserver,"},{"line_number":3309,"context_line":"                                           source_volume, dest_volume)"},{"line_number":3310,"context_line":""},{"line_number":3311,"context_line":"        if not snapmirrors:"},{"line_number":3312,"context_line":"            msg \u003d _(\u0027Failed to get snapmirror relationship information\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"abb51398_afb74995","line":3309,"range":{"start_line":3307,"start_character":43,"end_line":3309,"end_character":70},"updated":"2023-07-27 05:33:59.000000000","message":"always pass kwargs as kwargs - its more readable, and makes it easier to make changes to the order","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"0ce62bb2aecaab66514cdc842da9adab8b6ed91b","unresolved":false,"context_lines":[{"line_number":3304,"context_line":"                           source_vserver\u003dNone, dest_vserver\u003dNone,"},{"line_number":3305,"context_line":"                           source_volume\u003dNone, dest_volume\u003dNone):"},{"line_number":3306,"context_line":"        \"\"\"Update a snapmirror relationship asynchronously.\"\"\""},{"line_number":3307,"context_line":"        snapmirrors \u003d self.get_snapmirrors(source_path, dest_path,"},{"line_number":3308,"context_line":"                                           source_vserver, dest_vserver,"},{"line_number":3309,"context_line":"                                           source_volume, dest_volume)"},{"line_number":3310,"context_line":""},{"line_number":3311,"context_line":"        if not snapmirrors:"},{"line_number":3312,"context_line":"            msg \u003d _(\u0027Failed to get snapmirror relationship information\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a29951ba_25a1bb12","line":3309,"range":{"start_line":3307,"start_character":43,"end_line":3309,"end_character":70},"in_reply_to":"abb51398_afb74995","updated":"2023-07-27 13:08:28.000000000","message":"Done","commit_id":"2b9b08046a7578666b5fe7f7899739dc9ccb196f"}]}