)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"42ed8a42d40b1132e111beabe57a9c8efdffceb4","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[NetApp] SVM migration get progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement method share_server_migration_get_progress to get the"},{"line_number":10,"context_line":"SVM migration percent based in total amount of shares size (GB)"},{"line_number":11,"context_line":"tranfered from source to destination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da1033ec_afd2773f","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":58},"updated":"2023-07-27 19:44:57.000000000","message":"nit: the total size of shares","commit_id":"69102fd8c3b238118d6d9ba3a7cd6b23d2fce440"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"96e4ba4ef83dd22a7c48320db7f5e62147690356","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[NetApp] SVM migration get progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement method share_server_migration_get_progress to get the"},{"line_number":10,"context_line":"SVM migration percent based in total amount of shares size (GB)"},{"line_number":11,"context_line":"tranfered from source to destination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b4e10b40_a0edb00d","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":58},"in_reply_to":"da1033ec_afd2773f","updated":"2023-07-28 12:32:38.000000000","message":"Done","commit_id":"69102fd8c3b238118d6d9ba3a7cd6b23d2fce440"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"42ed8a42d40b1132e111beabe57a9c8efdffceb4","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement method share_server_migration_get_progress to get the"},{"line_number":10,"context_line":"SVM migration percent based in total amount of shares size (GB)"},{"line_number":11,"context_line":"tranfered from source to destination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8b21d196_d6781ef0","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"updated":"2023-07-27 19:44:57.000000000","message":"typo: transferred","commit_id":"69102fd8c3b238118d6d9ba3a7cd6b23d2fce440"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"96e4ba4ef83dd22a7c48320db7f5e62147690356","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement method share_server_migration_get_progress to get the"},{"line_number":10,"context_line":"SVM migration percent based in total amount of shares size (GB)"},{"line_number":11,"context_line":"tranfered from source to destination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"49250aa5_c0777564","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"in_reply_to":"8b21d196_d6781ef0","updated":"2023-07-28 12:32:38.000000000","message":"Done","commit_id":"69102fd8c3b238118d6d9ba3a7cd6b23d2fce440"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":true,"context_lines":[{"line_number":11,"context_line":"tranfered from source to destination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If4bf3378388cc0d9ea03f58b0ab5abd9a268bfdd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"97afe27f_26908f2f","line":14,"updated":"2023-08-09 14:20:29.000000000","message":"Can you create a RFE launchpad for us explaining the issue and add here ?","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[{"line_number":11,"context_line":"tranfered from source to destination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If4bf3378388cc0d9ea03f58b0ab5abd9a268bfdd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f8eff99e_2168efa5","line":14,"in_reply_to":"97afe27f_26908f2f","updated":"2023-08-10 13:36:23.000000000","message":"Done","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"d1e5fdfc6dfb3ffadf3fb80d640c0bcfa01a945c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     MelloCaique \u003ccaique_mellosbo@hotmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-11 14:20:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[RFE] NetApp SVM migration get progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement method share_server_migration_get_progress to get the"},{"line_number":10,"context_line":"SVM migration percent based in the total size of shares (GB)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d6476f5d_3c5d682c","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":17},"updated":"2023-08-14 12:04:19.000000000","message":"ONTAP Name, use manila name: share server","commit_id":"ebfa7dc0c705a93c3726c9dc461c5cc3be7db841"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"796c55946061e59891f7f8f7ed897919cfb02e86","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     MelloCaique \u003ccaique_mellosbo@hotmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-11 14:20:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[RFE] NetApp SVM migration get progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement method share_server_migration_get_progress to get the"},{"line_number":10,"context_line":"SVM migration percent based in the total size of shares (GB)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"380b828c_f6c93c15","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":17},"in_reply_to":"d6476f5d_3c5d682c","updated":"2023-08-14 13:12:17.000000000","message":"Done","commit_id":"ebfa7dc0c705a93c3726c9dc461c5cc3be7db841"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"d1e5fdfc6dfb3ffadf3fb80d640c0bcfa01a945c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[RFE] NetApp SVM migration get progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement method share_server_migration_get_progress to get the"},{"line_number":10,"context_line":"SVM migration percent based in the total size of shares (GB)"},{"line_number":11,"context_line":"tranfered from source to destination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"a6118dbe_757d77ae","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2023-08-14 12:04:19.000000000","message":"ONTAP Name, use manila name: share server","commit_id":"ebfa7dc0c705a93c3726c9dc461c5cc3be7db841"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"796c55946061e59891f7f8f7ed897919cfb02e86","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[RFE] NetApp SVM migration get progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement method share_server_migration_get_progress to get the"},{"line_number":10,"context_line":"SVM migration percent based in the total size of shares (GB)"},{"line_number":11,"context_line":"tranfered from source to destination."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d67d6c96_af360781","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"in_reply_to":"a6118dbe_757d77ae","updated":"2023-08-14 13:12:17.000000000","message":"Done","commit_id":"ebfa7dc0c705a93c3726c9dc461c5cc3be7db841"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6cb45f6f9780c84c3d5f0aab11a851d38b5fa38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af3e41f0_1f4eb554","updated":"2023-07-27 05:43:51.000000000","message":"Thank you for this; could you please add a release note in your next patch, Caique","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"de8ed3ec722e26bfa5378a6e203075fbb7d9e5a5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6e96a9db_7fb91504","updated":"2023-07-26 19:21:04.000000000","message":"Thanks for the patch, Caique. Just a question inline.","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"6aceda119910c69f1215b06eeda98e1ffc204525","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"371c9a5c_4848d6ea","in_reply_to":"6e96a9db_7fb91504","updated":"2023-08-03 12:49:22.000000000","message":"Done","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"01399b2866d6f0f685d7d34bb933e194aff8cdb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9617107_4d073e41","updated":"2023-07-27 17:43:28.000000000","message":"Thank you Goutham and Thiago.","commit_id":"69102fd8c3b238118d6d9ba3a7cd6b23d2fce440"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"42ed8a42d40b1132e111beabe57a9c8efdffceb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2633b9c7_af2f48d1","updated":"2023-07-27 19:44:57.000000000","message":"Thanks for the patch. I only added some small suggestions in commit msg and release notes.","commit_id":"69102fd8c3b238118d6d9ba3a7cd6b23d2fce440"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"96e4ba4ef83dd22a7c48320db7f5e62147690356","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f427624_7ccb9e8d","updated":"2023-07-28 12:32:38.000000000","message":"Thank you Nahim. Comments were addressed.","commit_id":"e612910f90cac871706ca87f558b548514790195"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e287e1a9_2987b412","updated":"2023-08-09 14:20:29.000000000","message":"Thanks Caique for the patch! See my comments","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"6a8184c0a0ef343bb9a40537fa7799dd94f58519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"242855c5_df1b0b99","updated":"2023-08-04 17:16:41.000000000","message":"Thanks for the updates, Caique. LGTM.","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c62b92ebc4540d8fc9c14b9010d88435f20575ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20870ad3_4982983b","updated":"2023-08-10 16:12:28.000000000","message":"Hi, thanks for proposing a fix.\n\nPlease see my inline comments.\nThe 3 comments to client_cmode.py apply to client_cmode_rest.py, too.","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"eda2ecf8a08346b12d1b32a08a733e85a9ed275f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6511d66f_c494b5aa","updated":"2023-08-10 13:56:25.000000000","message":"My comments have been addressed, thanks Caique.","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"91aa74ac_6ebccc8b","updated":"2023-08-10 13:36:23.000000000","message":"Thank you Felipe. All the comments were addressed.","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b29b320801874e14c1c7dda67bca57c40b25c14e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2d9d119a_b401d3ef","updated":"2023-08-11 15:40:53.000000000","message":"Thank you for the review carthaca, I have fixed your points and commented others please check if you agree.","commit_id":"ebfa7dc0c705a93c3726c9dc461c5cc3be7db841"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"7d7ab57ba0e5850fca533c33a7d941d63bfd1324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"059114aa_0e96ee0e","updated":"2023-08-14 12:14:57.000000000","message":"Thanks for addressing my comments. I\u0027m still unhappy with arbitrary limiting the progress at 90% (see an example for illustration inline)","commit_id":"ebfa7dc0c705a93c3726c9dc461c5cc3be7db841"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"de333c37b3fea8ed5c5ee12c97516e2fa02e94fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cf4c4c58_8f8ca33e","updated":"2023-08-11 17:36:55.000000000","message":"recheck fail not related to the change.","commit_id":"ebfa7dc0c705a93c3726c9dc461c5cc3be7db841"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62a56b4da744f853364fef08b4f4ba9454a6eccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5c7d83b5_248b3807","updated":"2023-08-22 16:49:14.000000000","message":"Caique: should we be backporting this change to older stable releases? If yes, could you please propose the backports? Thanks!","commit_id":"bb7a06bf322e89f5b5dbdeb7421bab5f6bd5f833"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"75497c5fc023ce3a846152edd7e19db6734684e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"69a51213_6426e252","updated":"2023-08-22 09:40:55.000000000","message":"LGTM, thanks for working on this enhancement, Caique","commit_id":"bb7a06bf322e89f5b5dbdeb7421bab5f6bd5f833"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"417cdc3afb4e7ca522ab9217f970f541c5e1cb3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"279e6743_f2b22552","updated":"2023-08-16 19:32:17.000000000","message":"NetApp\u0027s share server migration NFS job was executed internally with a success.\n\nLink: https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/58/1758/1/downstream-share-server-migration/manila-tempest-plugin-ontap-dhss-migration/6679a2a/","commit_id":"bb7a06bf322e89f5b5dbdeb7421bab5f6bd5f833"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"73b68660bd5c53a0f749b574560b6d4a5ec0211e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"53292acf_99573403","updated":"2023-08-16 20:47:51.000000000","message":"Thanks Caique, LGTM!","commit_id":"bb7a06bf322e89f5b5dbdeb7421bab5f6bd5f833"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"d2de96c94ae02ab41828290b28a402cb7e51d946","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2bed0fa5_bc7f7363","updated":"2023-08-17 15:24:26.000000000","message":"Thanks, I can live with the 99% 😊","commit_id":"bb7a06bf322e89f5b5dbdeb7421bab5f6bd5f833"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b1339f06818cfa36185be9bd24a77230a7172a74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5a36aacb_623c72af","updated":"2023-08-16 11:59:46.000000000","message":"recheck dummy driver job failed for random reason","commit_id":"bb7a06bf322e89f5b5dbdeb7421bab5f6bd5f833"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"2843b9e5506636769ba3d481664c7711b2eddfb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cd370a6e_72ce0385","updated":"2023-08-14 15:08:04.000000000","message":"recheck dummy driver job failed for random reason","commit_id":"bb7a06bf322e89f5b5dbdeb7421bab5f6bd5f833"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"8aea3aa0c066a1f119eab73c4897ff8a1af34d4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"100d53ae_f0006bda","updated":"2023-08-16 18:40:45.000000000","message":"run-NetApp CI","commit_id":"bb7a06bf322e89f5b5dbdeb7421bab5f6bd5f833"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c62b92ebc4540d8fc9c14b9010d88435f20575ef","unresolved":true,"context_lines":[{"line_number":6044,"context_line":""},{"line_number":6045,"context_line":"    @na_utils.trace"},{"line_number":6046,"context_line":"    def get_svm_volumes_total_size(self, svm_name):"},{"line_number":6047,"context_line":"        \"\"\"Gets volumes sizes sum from all volumes in SVM by svm_name\"\"\""},{"line_number":6048,"context_line":""},{"line_number":6049,"context_line":"        request \u003d {}"},{"line_number":6050,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"69db4bec_0afd9815","line":6047,"updated":"2023-08-10 16:12:28.000000000","message":"Please mention that this return the sum in GB","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b29b320801874e14c1c7dda67bca57c40b25c14e","unresolved":false,"context_lines":[{"line_number":6044,"context_line":""},{"line_number":6045,"context_line":"    @na_utils.trace"},{"line_number":6046,"context_line":"    def get_svm_volumes_total_size(self, svm_name):"},{"line_number":6047,"context_line":"        \"\"\"Gets volumes sizes sum from all volumes in SVM by svm_name\"\"\""},{"line_number":6048,"context_line":""},{"line_number":6049,"context_line":"        request \u003d {}"},{"line_number":6050,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f57c18d_8b5a142b","line":6047,"in_reply_to":"69db4bec_0afd9815","updated":"2023-08-11 15:40:53.000000000","message":"Done","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c62b92ebc4540d8fc9c14b9010d88435f20575ef","unresolved":true,"context_lines":[{"line_number":6063,"context_line":"        if len(svm_volumes) \u003e 0:"},{"line_number":6064,"context_line":"            total_volumes_size \u003d 0"},{"line_number":6065,"context_line":"            for volume in svm_volumes:"},{"line_number":6066,"context_line":"                if volume[\u0027name\u0027] !\u003d \u0027root\u0027:"},{"line_number":6067,"context_line":"                    total_volumes_size \u003d total_volumes_size + volume[\u0027size\u0027]"},{"line_number":6068,"context_line":"        else:"},{"line_number":6069,"context_line":"            return 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"7acba91b_9ab7b69e","line":6066,"updated":"2023-08-10 16:12:28.000000000","message":"Please add a comment why this is excluded (or depending on possible changes in lib_multi_svm remove this arbitrary exclusion)","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b29b320801874e14c1c7dda67bca57c40b25c14e","unresolved":false,"context_lines":[{"line_number":6063,"context_line":"        if len(svm_volumes) \u003e 0:"},{"line_number":6064,"context_line":"            total_volumes_size \u003d 0"},{"line_number":6065,"context_line":"            for volume in svm_volumes:"},{"line_number":6066,"context_line":"                if volume[\u0027name\u0027] !\u003d \u0027root\u0027:"},{"line_number":6067,"context_line":"                    total_volumes_size \u003d total_volumes_size + volume[\u0027size\u0027]"},{"line_number":6068,"context_line":"        else:"},{"line_number":6069,"context_line":"            return 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"58f11354_9219624d","line":6066,"in_reply_to":"7acba91b_9ab7b69e","updated":"2023-08-11 15:40:53.000000000","message":"Done","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c62b92ebc4540d8fc9c14b9010d88435f20575ef","unresolved":true,"context_lines":[{"line_number":6068,"context_line":"        else:"},{"line_number":6069,"context_line":"            return 0"},{"line_number":6070,"context_line":""},{"line_number":6071,"context_line":"        # Convert Kbs to Gbs"},{"line_number":6072,"context_line":"        return (total_volumes_size / 1024**3)"}],"source_content_type":"text/x-python","patch_set":5,"id":"de82f172_9242d231","line":6071,"updated":"2023-08-10 16:12:28.000000000","message":"Isn\u0027t it \"# Convert Bytes to GBs\"?","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b29b320801874e14c1c7dda67bca57c40b25c14e","unresolved":false,"context_lines":[{"line_number":6068,"context_line":"        else:"},{"line_number":6069,"context_line":"            return 0"},{"line_number":6070,"context_line":""},{"line_number":6071,"context_line":"        # Convert Kbs to Gbs"},{"line_number":6072,"context_line":"        return (total_volumes_size / 1024**3)"}],"source_content_type":"text/x-python","patch_set":5,"id":"c7c471e0_c785083e","line":6071,"in_reply_to":"de82f172_9242d231","updated":"2023-08-11 15:40:53.000000000","message":"Done","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6cb45f6f9780c84c3d5f0aab11a851d38b5fa38","unresolved":true,"context_lines":[{"line_number":2034,"context_line":"        src_shares_total_size \u003d 0"},{"line_number":2035,"context_line":"        for instance in shares:"},{"line_number":2036,"context_line":"            src_shares_total_size \u003d ("},{"line_number":2037,"context_line":"                src_shares_total_size + instance.get(\u0027size\u0027))"},{"line_number":2038,"context_line":""},{"line_number":2039,"context_line":"        # Source and destination share server is the same"},{"line_number":2040,"context_line":"        dest_share_server_name \u003d self._get_vserver_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"a210c70c_bd5a1e55","line":2037,"range":{"start_line":2037,"start_character":40,"end_line":2037,"end_character":60},"updated":"2023-07-27 05:43:51.000000000","message":".get() could potentially give you None - defensively, use:\n\n  instance.get(\u0027size\u0027) or 0","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"01399b2866d6f0f685d7d34bb933e194aff8cdb5","unresolved":false,"context_lines":[{"line_number":2034,"context_line":"        src_shares_total_size \u003d 0"},{"line_number":2035,"context_line":"        for instance in shares:"},{"line_number":2036,"context_line":"            src_shares_total_size \u003d ("},{"line_number":2037,"context_line":"                src_shares_total_size + instance.get(\u0027size\u0027))"},{"line_number":2038,"context_line":""},{"line_number":2039,"context_line":"        # Source and destination share server is the same"},{"line_number":2040,"context_line":"        dest_share_server_name \u003d self._get_vserver_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"d2ae5c19_4c69b4ff","line":2037,"range":{"start_line":2037,"start_character":40,"end_line":2037,"end_character":60},"in_reply_to":"a210c70c_bd5a1e55","updated":"2023-07-27 17:43:28.000000000","message":"Done","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"de8ed3ec722e26bfa5378a6e203075fbb7d9e5a5","unresolved":true,"context_lines":[{"line_number":2041,"context_line":"            dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"        # Get currently volume total size in the destination SVM"},{"line_number":2044,"context_line":"        dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"            dest_share_server_name)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":"        if src_shares_total_size \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d2196e0_a35223ee","line":2044,"updated":"2023-07-26 19:21:04.000000000","message":"I don\u0027t know if I look into right place but seems to me there is not a try/except block to treat possible exceptions here, neither in manager [1] nor in client implementations. Looks to me it would be good have it. WDYT?\n\n[1] https://opendev.org/openstack/manila/src/branch/master/manila/share/manager.py#L5910","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"01399b2866d6f0f685d7d34bb933e194aff8cdb5","unresolved":true,"context_lines":[{"line_number":2041,"context_line":"            dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"        # Get currently volume total size in the destination SVM"},{"line_number":2044,"context_line":"        dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"            dest_share_server_name)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":"        if src_shares_total_size \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8535516_c304fbaf","line":2044,"in_reply_to":"1d2196e0_a35223ee","updated":"2023-07-27 17:43:28.000000000","message":"If I\u0027m not wrong the workflow until this point would not break when trying to call the dest_share_server due to svm migration checks so far.","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"6aceda119910c69f1215b06eeda98e1ffc204525","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"            dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"        # Get currently volume total size in the destination SVM"},{"line_number":2044,"context_line":"        dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"            dest_share_server_name)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":"        if src_shares_total_size \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d3b2f5d4_36a1b58a","line":2044,"in_reply_to":"c8535516_c304fbaf","updated":"2023-08-03 12:49:22.000000000","message":"Done","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"de8ed3ec722e26bfa5378a6e203075fbb7d9e5a5","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"        dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"            dest_share_server_name)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":"        if src_shares_total_size \u003e 0:"},{"line_number":2048,"context_line":"            total_progress \u003d ("},{"line_number":2049,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2050,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"278b5ec2_c6e77c0d","line":2047,"updated":"2023-07-26 19:21:04.000000000","message":"nit: Just small suggestion to avoid unnecessary calls: You can put this IF after the for loop using the ELSE conditional. This way, you can discard ELSE and return the total_progress \u003d 0 without make ONTAP call.","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"01399b2866d6f0f685d7d34bb933e194aff8cdb5","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"        dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"            dest_share_server_name)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":"        if src_shares_total_size \u003e 0:"},{"line_number":2048,"context_line":"            total_progress \u003d ("},{"line_number":2049,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2050,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c525470_81270354","line":2047,"in_reply_to":"278b5ec2_c6e77c0d","updated":"2023-07-27 17:43:28.000000000","message":"Yes you are right Thiago, thank you. DONE.","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6cb45f6f9780c84c3d5f0aab11a851d38b5fa38","unresolved":true,"context_lines":[{"line_number":2048,"context_line":"            total_progress \u003d ("},{"line_number":2049,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2050,"context_line":"        else:"},{"line_number":2051,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        return {\u0027total_progress\u0027: total_progress}"},{"line_number":2054,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"edc00f0e_66cf20d0","line":2051,"range":{"start_line":2051,"start_character":19,"end_line":2051,"end_character":40},"updated":"2023-07-27 05:43:51.000000000","message":"if the source shares have no size, shouldn\u0027t this be 100? i.e., data copy is done?","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"6aceda119910c69f1215b06eeda98e1ffc204525","unresolved":false,"context_lines":[{"line_number":2048,"context_line":"            total_progress \u003d ("},{"line_number":2049,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2050,"context_line":"        else:"},{"line_number":2051,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        return {\u0027total_progress\u0027: total_progress}"},{"line_number":2054,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2c445c28_e7d65737","line":2051,"range":{"start_line":2051,"start_character":19,"end_line":2051,"end_character":40},"in_reply_to":"050664ae_8fcccca2","updated":"2023-08-03 12:49:22.000000000","message":"Done","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"01399b2866d6f0f685d7d34bb933e194aff8cdb5","unresolved":true,"context_lines":[{"line_number":2048,"context_line":"            total_progress \u003d ("},{"line_number":2049,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2050,"context_line":"        else:"},{"line_number":2051,"context_line":"            return {\u0027total_progress\u0027: 0}"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        return {\u0027total_progress\u0027: total_progress}"},{"line_number":2054,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"050664ae_8fcccca2","line":2051,"range":{"start_line":2051,"start_character":19,"end_line":2051,"end_character":40},"in_reply_to":"edc00f0e_66cf20d0","updated":"2023-07-27 17:43:28.000000000","message":"The progress will be updated to 100 when migration phase 1 is completed.","commit_id":"3b645334d946830adf12ec434fd55e69c06ee5b2"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":true,"context_lines":[{"line_number":2026,"context_line":"        LOG.info(\u0027Share server migration was cancelled.\u0027)"},{"line_number":2027,"context_line":""},{"line_number":2028,"context_line":"    @na_utils.trace"},{"line_number":2029,"context_line":"    def share_server_migration_get_progress(self, context, src_share_server,"},{"line_number":2030,"context_line":"                                            dest_share_server, shares,"},{"line_number":2031,"context_line":"                                            snapshots):"},{"line_number":2032,"context_line":"        # Get the source svm shares sum"}],"source_content_type":"text/x-python","patch_set":4,"id":"54da0d50_520e7e62","line":2029,"range":{"start_line":2029,"start_character":8,"end_line":2029,"end_character":43},"updated":"2023-08-09 14:20:29.000000000","message":"add doc of the function","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[{"line_number":2026,"context_line":"        LOG.info(\u0027Share server migration was cancelled.\u0027)"},{"line_number":2027,"context_line":""},{"line_number":2028,"context_line":"    @na_utils.trace"},{"line_number":2029,"context_line":"    def share_server_migration_get_progress(self, context, src_share_server,"},{"line_number":2030,"context_line":"                                            dest_share_server, shares,"},{"line_number":2031,"context_line":"                                            snapshots):"},{"line_number":2032,"context_line":"        # Get the source svm shares sum"}],"source_content_type":"text/x-python","patch_set":4,"id":"b4181891_b8ea1375","line":2029,"range":{"start_line":2029,"start_character":8,"end_line":2029,"end_character":43},"in_reply_to":"54da0d50_520e7e62","updated":"2023-08-10 13:36:23.000000000","message":"Done","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":true,"context_lines":[{"line_number":2029,"context_line":"    def share_server_migration_get_progress(self, context, src_share_server,"},{"line_number":2030,"context_line":"                                            dest_share_server, shares,"},{"line_number":2031,"context_line":"                                            snapshots):"},{"line_number":2032,"context_line":"        # Get the source svm shares sum"},{"line_number":2033,"context_line":"        src_shares_total_size \u003d 0"},{"line_number":2034,"context_line":"        for instance in shares:"},{"line_number":2035,"context_line":"            src_shares_total_size \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"df1ac2c4_dfd5b9ac","line":2032,"range":{"start_line":2032,"start_character":25,"end_line":2032,"end_character":39},"updated":"2023-08-09 14:20:29.000000000","message":"\"svm share sum\", of what ? Maybe:\n\n\"Get the source svm shares size sum.\"\nor\n\"Get the total size of the source svm shares.\"","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[{"line_number":2029,"context_line":"    def share_server_migration_get_progress(self, context, src_share_server,"},{"line_number":2030,"context_line":"                                            dest_share_server, shares,"},{"line_number":2031,"context_line":"                                            snapshots):"},{"line_number":2032,"context_line":"        # Get the source svm shares sum"},{"line_number":2033,"context_line":"        src_shares_total_size \u003d 0"},{"line_number":2034,"context_line":"        for instance in shares:"},{"line_number":2035,"context_line":"            src_shares_total_size \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"53693a06_6c96b6b2","line":2032,"range":{"start_line":2032,"start_character":25,"end_line":2032,"end_character":39},"in_reply_to":"df1ac2c4_dfd5b9ac","updated":"2023-08-10 13:36:23.000000000","message":"Done","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":true,"context_lines":[{"line_number":2036,"context_line":"                src_shares_total_size + instance.get(\u0027size\u0027, 0))"},{"line_number":2037,"context_line":""},{"line_number":2038,"context_line":"        if src_shares_total_size \u003e 0:"},{"line_number":2039,"context_line":"            # Source and destination share server is the same"},{"line_number":2040,"context_line":"            dest_share_server_name \u003d self._get_vserver_name("},{"line_number":2041,"context_line":"                dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"499d5265_2b891dcb","line":2039,"range":{"start_line":2039,"start_character":12,"end_line":2039,"end_character":61},"updated":"2023-08-09 14:20:29.000000000","message":"they are not the same, I think you meant that they have the same name. Maybe:\n\nDestination share server has the same name as the source share server.\n\nAm I right ?","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[{"line_number":2036,"context_line":"                src_shares_total_size + instance.get(\u0027size\u0027, 0))"},{"line_number":2037,"context_line":""},{"line_number":2038,"context_line":"        if src_shares_total_size \u003e 0:"},{"line_number":2039,"context_line":"            # Source and destination share server is the same"},{"line_number":2040,"context_line":"            dest_share_server_name \u003d self._get_vserver_name("},{"line_number":2041,"context_line":"                dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"79854c70_c31766eb","line":2039,"range":{"start_line":2039,"start_character":12,"end_line":2039,"end_character":61},"in_reply_to":"499d5265_2b891dcb","updated":"2023-08-10 13:36:23.000000000","message":"Yes, you are right. The migration keep the name from source to destination.","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":true,"context_lines":[{"line_number":2040,"context_line":"            dest_share_server_name \u003d self._get_vserver_name("},{"line_number":2041,"context_line":"                dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"            # Get currently volume total size in the destination SVM"},{"line_number":2044,"context_line":"            dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"                dest_share_server_name)"},{"line_number":2046,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"354a0241_a156fb74","line":2043,"range":{"start_line":2043,"start_character":65,"end_line":2043,"end_character":68},"updated":"2023-08-09 14:20:29.000000000","message":"SVM.","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":true,"context_lines":[{"line_number":2040,"context_line":"            dest_share_server_name \u003d self._get_vserver_name("},{"line_number":2041,"context_line":"                dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"            # Get currently volume total size in the destination SVM"},{"line_number":2044,"context_line":"            dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"                dest_share_server_name)"},{"line_number":2046,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2d772921_e19c2d31","line":2043,"range":{"start_line":2043,"start_character":18,"end_line":2043,"end_character":28},"updated":"2023-08-09 14:20:29.000000000","message":"current","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[{"line_number":2040,"context_line":"            dest_share_server_name \u003d self._get_vserver_name("},{"line_number":2041,"context_line":"                dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"            # Get currently volume total size in the destination SVM"},{"line_number":2044,"context_line":"            dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"                dest_share_server_name)"},{"line_number":2046,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"69b2d390_457a2ee6","line":2043,"range":{"start_line":2043,"start_character":18,"end_line":2043,"end_character":28},"in_reply_to":"2d772921_e19c2d31","updated":"2023-08-10 13:36:23.000000000","message":"Done","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[{"line_number":2040,"context_line":"            dest_share_server_name \u003d self._get_vserver_name("},{"line_number":2041,"context_line":"                dest_share_server[\u0027source_share_server_id\u0027])"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"            # Get currently volume total size in the destination SVM"},{"line_number":2044,"context_line":"            dest_shares_total_size \u003d self._client.get_svm_volumes_total_size("},{"line_number":2045,"context_line":"                dest_share_server_name)"},{"line_number":2046,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"152092e2_026ed102","line":2043,"range":{"start_line":2043,"start_character":65,"end_line":2043,"end_character":68},"in_reply_to":"354a0241_a156fb74","updated":"2023-08-10 13:36:23.000000000","message":"Done","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":true,"context_lines":[{"line_number":2045,"context_line":"                dest_share_server_name)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":"            total_progress \u003d ("},{"line_number":2048,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"            return {\u0027total_progress\u0027: total_progress}"},{"line_number":2051,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4e8be71c_97e8a80a","line":2048,"range":{"start_line":2048,"start_character":17,"end_line":2048,"end_character":20},"updated":"2023-08-09 14:20:29.000000000","message":"why 90 ? should it be 100 ?","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"                dest_share_server_name)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":"            total_progress \u003d ("},{"line_number":2048,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"            return {\u0027total_progress\u0027: total_progress}"},{"line_number":2051,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b0363456_667fd292","line":2048,"range":{"start_line":2048,"start_character":17,"end_line":2048,"end_character":20},"in_reply_to":"4e8be71c_97e8a80a","updated":"2023-08-10 13:36:23.000000000","message":"90% is an arbitrary number. 100% progress will be set when the migration phase 1 is completed.","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c62b92ebc4540d8fc9c14b9010d88435f20575ef","unresolved":true,"context_lines":[{"line_number":2041,"context_line":"        src_shares_total_size \u003d 0"},{"line_number":2042,"context_line":"        for instance in shares:"},{"line_number":2043,"context_line":"            src_shares_total_size \u003d ("},{"line_number":2044,"context_line":"                src_shares_total_size + instance.get(\u0027size\u0027, 0))"},{"line_number":2045,"context_line":""},{"line_number":2046,"context_line":"        if src_shares_total_size \u003e 0:"},{"line_number":2047,"context_line":"            # Destination share server has the same name as the source share"}],"source_content_type":"text/x-python","patch_set":5,"id":"1906f01d_b0126f19","line":2044,"updated":"2023-08-10 16:12:28.000000000","message":"Can we use the same method like below `.get_svm_volumes_total_size()` to make sure we are not comparing apples and oranges? There may be other non-manila volumes in the SVM apart from the root volume.","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b29b320801874e14c1c7dda67bca57c40b25c14e","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"        src_shares_total_size \u003d 0"},{"line_number":2042,"context_line":"        for instance in shares:"},{"line_number":2043,"context_line":"            src_shares_total_size \u003d ("},{"line_number":2044,"context_line":"                src_shares_total_size + instance.get(\u0027size\u0027, 0))"},{"line_number":2045,"context_line":""},{"line_number":2046,"context_line":"        if src_shares_total_size \u003e 0:"},{"line_number":2047,"context_line":"            # Destination share server has the same name as the source share"}],"source_content_type":"text/x-python","patch_set":5,"id":"0e81ed6c_59c97326","line":2044,"in_reply_to":"1906f01d_b0126f19","updated":"2023-08-11 15:40:53.000000000","message":"We already have the information of the shares from the source SVM, maybe call the method \u0027.get_svm_volumes_total_size()\u0027 would be an unnecessary call. Once we are migrating the SVM all the shares will be migrated.","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c62b92ebc4540d8fc9c14b9010d88435f20575ef","unresolved":true,"context_lines":[{"line_number":2056,"context_line":"            # The 100% progress will be return only when the SVM migration"},{"line_number":2057,"context_line":"            # phase 1 is completed. 90% is an arbitrary number."},{"line_number":2058,"context_line":"            total_progress \u003d ("},{"line_number":2059,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"            return {\u0027total_progress\u0027: total_progress}"},{"line_number":2062,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1305c714_83efb36b","line":2059,"updated":"2023-08-10 16:12:28.000000000","message":"A.) That means if half of the volumes are transferred, we report 45% progress? Seems strange to me - what is the motivation to not report up to 100%? We \nhave the task_state to differentiate the phases and don\u0027t need to do this by the progress percentage.\n\nB.) If we really have to do this: I would like to use 99% instead of 90% to indicate that we are near to the end (that would also improve my first example, half of 99% would be reported as 49% or 50% depending on the rounding)\n\nC.) This needs some rounding added on top, we are only interested in the first 1-2 digits. (e.g. 6%, not 5.823529411764706%)","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b29b320801874e14c1c7dda67bca57c40b25c14e","unresolved":false,"context_lines":[{"line_number":2056,"context_line":"            # The 100% progress will be return only when the SVM migration"},{"line_number":2057,"context_line":"            # phase 1 is completed. 90% is an arbitrary number."},{"line_number":2058,"context_line":"            total_progress \u003d ("},{"line_number":2059,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"            return {\u0027total_progress\u0027: total_progress}"},{"line_number":2062,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b1a48a44_8341e3c5","line":2059,"in_reply_to":"1305c714_83efb36b","updated":"2023-08-11 15:40:53.000000000","message":"A,B) I believe It is just a matter of alignment. 90% was set due to the tests I have done in my dev env, after the shares migration (20-40 shares with 5GB) the operation took 1-2 minutes to complete phase_1. I don\u0027t have information regarding the time to complete phase_1 after the migration of shares in a production env, so maybe I was a little conservative.\n\nC) Fixed.","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"796c55946061e59891f7f8f7ed897919cfb02e86","unresolved":true,"context_lines":[{"line_number":2056,"context_line":"            # The 100% progress will be return only when the SVM migration"},{"line_number":2057,"context_line":"            # phase 1 is completed. 90% is an arbitrary number."},{"line_number":2058,"context_line":"            total_progress \u003d ("},{"line_number":2059,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"            return {\u0027total_progress\u0027: total_progress}"},{"line_number":2062,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"0943c816_42db4bde","line":2059,"in_reply_to":"4fdf1182_b2fe8a6d","updated":"2023-08-14 13:12:17.000000000","message":"Thank you Felipe and carthaca for the reviews. Yes, your point makes total sense. I missed the view from the final user. Thank you bringing this up. I modified to 99%.","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"d1e5fdfc6dfb3ffadf3fb80d640c0bcfa01a945c","unresolved":true,"context_lines":[{"line_number":2056,"context_line":"            # The 100% progress will be return only when the SVM migration"},{"line_number":2057,"context_line":"            # phase 1 is completed. 90% is an arbitrary number."},{"line_number":2058,"context_line":"            total_progress \u003d ("},{"line_number":2059,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"            return {\u0027total_progress\u0027: total_progress}"},{"line_number":2062,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"02d53d7e_f89b294a","line":2059,"in_reply_to":"b1a48a44_8341e3c5","updated":"2023-08-14 12:04:19.000000000","message":"A,B) Agree with carthaca. We should use \"99\".","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"7d7ab57ba0e5850fca533c33a7d941d63bfd1324","unresolved":false,"context_lines":[{"line_number":2056,"context_line":"            # The 100% progress will be return only when the SVM migration"},{"line_number":2057,"context_line":"            # phase 1 is completed. 90% is an arbitrary number."},{"line_number":2058,"context_line":"            total_progress \u003d ("},{"line_number":2059,"context_line":"                (90 * dest_shares_total_size) / src_shares_total_size)"},{"line_number":2060,"context_line":""},{"line_number":2061,"context_line":"            return {\u0027total_progress\u0027: total_progress}"},{"line_number":2062,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4fdf1182_b2fe8a6d","line":2059,"in_reply_to":"b1a48a44_8341e3c5","updated":"2023-08-14 12:14:57.000000000","message":"Let\u0027s give an example what I will do with the values:\nMy client will check the progress regularly and extrapolate (assuming stable transfer speed) the time until this finishes.\nE.g. progress increases by 1% every minute, my client will predict the migration is done after 100 minutes. But actually it will only take 90 minutes, which hurts the accuracy of this prediction.\n\nThe progress bar will slowly go from 0% to 90% and then jump to 100% at once - seems weird to me. We have big SVMs with up to 10TiB, it will make a difference ;)","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"}],"manila/tests/share/drivers/netapp/dataontap/client/fakes.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"c62b92ebc4540d8fc9c14b9010d88435f20575ef","unresolved":true,"context_lines":[{"line_number":4770,"context_line":"        {"},{"line_number":4771,"context_line":"            \"uuid\": FAKE_UUID,"},{"line_number":4772,"context_line":"            \"name\": \"share_6cb5b3f4_35d0_40b8_a106_d35262ac17c7\","},{"line_number":4773,"context_line":"            \"size\": 1073741824,"},{"line_number":4774,"context_line":"        }"},{"line_number":4775,"context_line":"    ],"},{"line_number":4776,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ec22e1d6_f00aad8f","line":4773,"updated":"2023-08-10 16:12:28.000000000","message":"would be better readable when written as `1024**3`","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b29b320801874e14c1c7dda67bca57c40b25c14e","unresolved":false,"context_lines":[{"line_number":4770,"context_line":"        {"},{"line_number":4771,"context_line":"            \"uuid\": FAKE_UUID,"},{"line_number":4772,"context_line":"            \"name\": \"share_6cb5b3f4_35d0_40b8_a106_d35262ac17c7\","},{"line_number":4773,"context_line":"            \"size\": 1073741824,"},{"line_number":4774,"context_line":"        }"},{"line_number":4775,"context_line":"    ],"},{"line_number":4776,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"65a3b256_6bcae591","line":4773,"in_reply_to":"ec22e1d6_f00aad8f","updated":"2023-08-11 15:40:53.000000000","message":"Done","commit_id":"14d0304cce3919abb2de0aa8db82500811d6f07c"}],"releasenotes/notes/netapp-svm-get-progress-596cd387c66dea1b.yaml":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"42ed8a42d40b1132e111beabe57a9c8efdffceb4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement method share_server_migration_get_progress to get the"},{"line_number":5,"context_line":"    SVM migration percent based in total amount of shares size"},{"line_number":6,"context_line":"    tranfered from source to destination."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"315cc091_f3c8c892","line":6,"range":{"start_line":5,"start_character":26,"end_line":6,"end_character":13},"updated":"2023-07-27 19:44:57.000000000","message":"nit: same suggestion as in the commit message :)","commit_id":"69102fd8c3b238118d6d9ba3a7cd6b23d2fce440"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"96e4ba4ef83dd22a7c48320db7f5e62147690356","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement method share_server_migration_get_progress to get the"},{"line_number":5,"context_line":"    SVM migration percent based in total amount of shares size"},{"line_number":6,"context_line":"    tranfered from source to destination."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"33716173_7302bb3e","line":6,"range":{"start_line":5,"start_character":26,"end_line":6,"end_character":13},"in_reply_to":"315cc091_f3c8c892","updated":"2023-07-28 12:32:38.000000000","message":"Done","commit_id":"69102fd8c3b238118d6d9ba3a7cd6b23d2fce440"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c281f87e1f9477234940e29ee54191bf4e81332","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement method share_server_migration_get_progress to get the"},{"line_number":5,"context_line":"    SVM migration percent based in the total size of shares"},{"line_number":6,"context_line":"    tranfered from source to destination."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0c4dd117_10c5ef72","line":6,"range":{"start_line":4,"start_character":3,"end_line":6,"end_character":41},"updated":"2023-08-09 14:20:29.000000000","message":"1.It is for end users, so you should use more operational/genric explanations. Instead of mentioning `Implement method share_server_migration_get_progress` (developer view).\n2. You should mention that it is a NetApp feature\n3. Avoid NetApp term (SVM), use Manila term: share server \n\n`NetApp driver is now able to inform the completed percentage of a share server migration.`","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e83e507e086024d516f1c2ad7444b4b18313fc22","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement method share_server_migration_get_progress to get the"},{"line_number":5,"context_line":"    SVM migration percent based in the total size of shares"},{"line_number":6,"context_line":"    tranfered from source to destination."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"970fcf09_a341c9eb","line":6,"range":{"start_line":4,"start_character":3,"end_line":6,"end_character":41},"in_reply_to":"0c4dd117_10c5ef72","updated":"2023-08-10 13:36:23.000000000","message":"Done","commit_id":"74584444830c997063fb89554c5bfd8726ff2a41"}]}