)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ec97a4f60c6729fc6c92fe89df49c9869b78cf4c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"This patch fix all the errors related to this change."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #2025075"},{"line_number":15,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"},{"line_number":16,"context_line":"Change-Id: Iaaf15906aa3a29543860d878cde305cfddc7f70e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0bc8587d_bc3ac814","line":15,"updated":"2023-08-16 19:44:30.000000000","message":"This fix should not depend on a driver fix. Please, remove it.","commit_id":"cc58a0e283578b36f7c013ff2d09ed027efbccb3"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"779567de05461e1d23e2c7fc348f6237ff6bf393","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch fix all the errors related to this change."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #2025075"},{"line_number":15,"context_line":"Depends-On: I9eae95ff3f66a3497b00ca582491afec58ae6dc3"},{"line_number":16,"context_line":"Change-Id: Iaaf15906aa3a29543860d878cde305cfddc7f70e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f1eb2d91_83d07995","line":15,"in_reply_to":"0bc8587d_bc3ac814","updated":"2023-08-16 19:57:41.000000000","message":"Done","commit_id":"cc58a0e283578b36f7c013ff2d09ed027efbccb3"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c3be8df9396a04ab12e3101ddffea71f5092d01d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Caique Mello \u003ccaiquemellosbo@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-16 19:53:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] Fix BadRequest from share-server-migration-get-progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The share-server-migration-get-progress command was returning error"},{"line_number":10,"context_line":"when executed immediataly after starting migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b28cd3d1_9767db3e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":10},"updated":"2023-09-20 14:59:26.000000000","message":"Not a NetApp bug. Only found with NetApp driver.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Caique Mello \u003ccaiquemellosbo@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-16 19:53:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp] Fix BadRequest from share-server-migration-get-progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The share-server-migration-get-progress command was returning error"},{"line_number":10,"context_line":"when executed immediataly after starting migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"49011484_9e1ac24c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":10},"in_reply_to":"b28cd3d1_9767db3e","updated":"2023-09-20 19:21:09.000000000","message":"Done","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b6442fe3e283677b9df159199ff719460322c404","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"424fc8aa_ce6172ab","updated":"2023-07-27 12:17:53.000000000","message":"Thank you Helena, I have a suggestion.","commit_id":"b77e4f80d9399d5dd409fe31cf791cf23b7904f8"},{"author":{"_account_id":35049,"name":"Helena","email":"helenamylena@gmail.com","username":"helenadantas"},"change_message_id":"4c49faf61b2585e0dbcc49077acb7b4a2f8d02e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ea834a0c_b8a31386","updated":"2023-07-26 19:45:16.000000000","message":"run-NetApp CI","commit_id":"b77e4f80d9399d5dd409fe31cf791cf23b7904f8"},{"author":{"_account_id":35049,"name":"Helena","email":"helenamylena@gmail.com","username":"helenadantas"},"change_message_id":"90fbb6362cf8538199ee3dcef04e495b0b6bfe4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa3fc6b8_bb31efca","updated":"2023-07-27 12:10:12.000000000","message":"run-NetApp CI","commit_id":"b77e4f80d9399d5dd409fe31cf791cf23b7904f8"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ec97a4f60c6729fc6c92fe89df49c9869b78cf4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"466ebd7b_bbf7d857","updated":"2023-08-16 19:44:30.000000000","message":"Thanks Caique, please, see my comments.","commit_id":"cc58a0e283578b36f7c013ff2d09ed027efbccb3"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"779567de05461e1d23e2c7fc348f6237ff6bf393","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6a986c54_ac823fac","updated":"2023-08-16 19:57:41.000000000","message":"Thank you Felipe for the review. Comments were addressed.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c3be8df9396a04ab12e3101ddffea71f5092d01d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5354dade_39c56abe","updated":"2023-09-20 14:59:26.000000000","message":"Thanks for the code, please, see my comments.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0effd508164e4c7255640f648e166aeb5bd8a741","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"761a57bf_abbe8f0e","updated":"2023-09-19 14:18:50.000000000","message":"recheck\nNo zuul votes","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a0605397_57af1b63","updated":"2023-09-20 19:21:09.000000000","message":"Thank you Felipe and Gireesh for the reviews. Some comments were addressed and others replied.","commit_id":"948ff639abbe534a314478273d5999c89d7b15c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"8ddd138445050508a305b4bc2448a69a261de59c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d57a2ebb_8897dea1","updated":"2023-09-21 14:49:44.000000000","message":"Thank you! Caique. your changes LGTM.Just NIT comment.","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e599c5cbcc0b711645b962402a6f5505a92916e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4637671e_222ac66d","updated":"2023-09-21 10:31:35.000000000","message":"Thanks caique for fixing the commnets. See more points that I found.","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bb962637fc2e3025da91e527fe91a83aa6cc753c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0dacbccb_84b745a1","updated":"2023-09-22 18:10:40.000000000","message":"Thanks for the fix, Caique. I like the approach, have one suggestion for you on the LOG info message. Please take a look","commit_id":"ca861f1452d32e6dd7110d3fe1f01f095331ba23"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"f384a07a767cd870346670253db7791b9b0786bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aafee41c_8026a431","updated":"2023-09-21 18:55:00.000000000","message":"Thanks for the patch, Caique. LGTM","commit_id":"ca861f1452d32e6dd7110d3fe1f01f095331ba23"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"49c33c858ba51cec6fa598e5d4a3c44f631cd407","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6c42f331_0b9c2e6a","updated":"2023-09-25 12:44:04.000000000","message":"Keeping my previous vote.","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6f682c4335eee0435f5fc126668a5946b5e45ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"725760ea_a6ab35ec","updated":"2023-09-28 00:02:13.000000000","message":"Thanks for the fix Caique; could you please see my comments inline","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"398d9987d46790c93f972874ece179ee8abe5cf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"944b2570_034a9409","in_reply_to":"725760ea_a6ab35ec","updated":"2023-09-29 19:29:10.000000000","message":"Thank you for the comments Goutham.","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"398d9987d46790c93f972874ece179ee8abe5cf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"57434009_5804ac09","updated":"2023-09-29 19:29:10.000000000","message":"Comments addressed.","commit_id":"736deefd37884f437f9290151c9baa43145a96e9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"e4fb35b3a5551702145605d454937c4935e31a66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9acfb5a6_3851af5f","updated":"2023-10-03 20:32:06.000000000","message":"LGTM!","commit_id":"736deefd37884f437f9290151c9baa43145a96e9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53542bbed27f72126adf11cdc3c84739869e122b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e901c44c_6269e43a","updated":"2023-10-17 13:49:47.000000000","message":"LGTM, thanks Caique! Please address Gouthamr\u0027s comments in a follow-up change","commit_id":"736deefd37884f437f9290151c9baa43145a96e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c33cd2cbda2b1c3d3c24828291562a3fb25aab2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"58ae7848_91bd6bb6","updated":"2023-10-02 17:38:39.000000000","message":"Thanks for the changes Caique; further comments inline if you\u0027d like to change things up","commit_id":"736deefd37884f437f9290151c9baa43145a96e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e91ce23b3f61ee2f36c683dcca53da1a508711d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"04e0b6b6_5733aab0","updated":"2023-10-20 17:48:52.000000000","message":"Caique: should we get this backported? if yes, could you please propose backports in order, to the older branches? Thanks!","commit_id":"8229f3e5c19b079edc3a7a23185e4bd8ce52d1ec"}],"manila/share/api.py":[{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b6442fe3e283677b9df159199ff719460322c404","unresolved":true,"context_lines":[{"line_number":3064,"context_line":"        )"},{"line_number":3065,"context_line":""},{"line_number":3066,"context_line":"        if isinstance(dest_share_server, list):"},{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":""},{"line_number":3073,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"},{"line_number":3074,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1372fb41_02b67952","line":3071,"range":{"start_line":3067,"start_character":0,"end_line":3071,"end_character":13},"updated":"2023-07-27 12:17:53.000000000","message":"Maybe adding a log.info here showing why the migration was not found at this time and asking for retry the get_progress?\n\nE.g.: (line 3095) \"Migration progress of share server %s cannot be obtained at this moment.\"","commit_id":"b77e4f80d9399d5dd409fe31cf791cf23b7904f8"},{"author":{"_account_id":35049,"name":"Helena","email":"helenamylena@gmail.com","username":"helenadantas"},"change_message_id":"075818fb9fa09f0fb971c4a9cf31d0af6565670c","unresolved":false,"context_lines":[{"line_number":3064,"context_line":"        )"},{"line_number":3065,"context_line":""},{"line_number":3066,"context_line":"        if isinstance(dest_share_server, list):"},{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":""},{"line_number":3073,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"},{"line_number":3074,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9c2321dd_8d3e7d72","line":3071,"range":{"start_line":3067,"start_character":0,"end_line":3071,"end_character":13},"in_reply_to":"1372fb41_02b67952","updated":"2023-07-28 13:05:00.000000000","message":"Done","commit_id":"b77e4f80d9399d5dd409fe31cf791cf23b7904f8"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ec97a4f60c6729fc6c92fe89df49c9869b78cf4c","unresolved":true,"context_lines":[{"line_number":3061,"context_line":""},{"line_number":3062,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"},{"line_number":3063,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"},{"line_number":3064,"context_line":""},{"line_number":3065,"context_line":"            dest_host \u003d share_utils.extract_host(dest_share_server[\u0027host\u0027])"},{"line_number":3066,"context_line":"            utils.validate_service_host(context, dest_host)"},{"line_number":3067,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"04af409e_c1932c12","side":"PARENT","line":3064,"updated":"2023-08-16 19:44:30.000000000","message":"please, dont remove lines that are not related with the fix (may cause problems with the git blame later).","commit_id":"4e62085cdbf0623962e40ce3762803e3697d75ee"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"779567de05461e1d23e2c7fc348f6237ff6bf393","unresolved":false,"context_lines":[{"line_number":3061,"context_line":""},{"line_number":3062,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"},{"line_number":3063,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"},{"line_number":3064,"context_line":""},{"line_number":3065,"context_line":"            dest_host \u003d share_utils.extract_host(dest_share_server[\u0027host\u0027])"},{"line_number":3066,"context_line":"            utils.validate_service_host(context, dest_host)"},{"line_number":3067,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ce829ca2_af9eefd9","side":"PARENT","line":3064,"in_reply_to":"04af409e_c1932c12","updated":"2023-08-16 19:57:41.000000000","message":"Done","commit_id":"4e62085cdbf0623962e40ce3762803e3697d75ee"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c3be8df9396a04ab12e3101ddffea71f5092d01d","unresolved":true,"context_lines":[{"line_number":2648,"context_line":"        return self.db.share_snapshot_instance_export_location_get(context,"},{"line_number":2649,"context_line":"                                                                   el_id)"},{"line_number":2650,"context_line":""},{"line_number":2651,"context_line":"    def share_server_migration_get_destination(self, context, source_server_id,"},{"line_number":2652,"context_line":"                                               status\u003dNone,"},{"line_number":2653,"context_line":"                                               is_get_progress\u003dFalse):"},{"line_number":2654,"context_line":"        filters \u003d {\u0027source_share_server_id\u0027: source_server_id}"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e796cc6_303931e5","line":2651,"range":{"start_line":2651,"start_character":8,"end_line":2651,"end_character":46},"updated":"2023-09-20 14:59:26.000000000","message":"Please, add a documentation of this function. I think it will be nice for future developers, since it has a specific behavior for get progress.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":false,"context_lines":[{"line_number":2648,"context_line":"        return self.db.share_snapshot_instance_export_location_get(context,"},{"line_number":2649,"context_line":"                                                                   el_id)"},{"line_number":2650,"context_line":""},{"line_number":2651,"context_line":"    def share_server_migration_get_destination(self, context, source_server_id,"},{"line_number":2652,"context_line":"                                               status\u003dNone,"},{"line_number":2653,"context_line":"                                               is_get_progress\u003dFalse):"},{"line_number":2654,"context_line":"        filters \u003d {\u0027source_share_server_id\u0027: source_server_id}"}],"source_content_type":"text/x-python","patch_set":6,"id":"8a430614_ce88a5a8","line":2651,"range":{"start_line":2651,"start_character":8,"end_line":2651,"end_character":46},"in_reply_to":"6e796cc6_303931e5","updated":"2023-09-20 19:21:09.000000000","message":"Done","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c3be8df9396a04ab12e3101ddffea71f5092d01d","unresolved":true,"context_lines":[{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"        dest_share_servers \u003d self.db.share_server_get_all_with_filters("},{"line_number":2659,"context_line":"            context, filters\u003dfilters)"},{"line_number":2660,"context_line":"        if not dest_share_servers:"},{"line_number":2661,"context_line":"            if (is_get_progress):"},{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"1d5cf3f7_e6772173","line":2661,"range":{"start_line":2660,"start_character":8,"end_line":2661,"end_character":32},"updated":"2023-09-20 14:59:26.000000000","message":"Avoid chain of \"if\"s:\n\nif not dest_share_servers and is_get_progress:","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":true,"context_lines":[{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"        dest_share_servers \u003d self.db.share_server_get_all_with_filters("},{"line_number":2659,"context_line":"            context, filters\u003dfilters)"},{"line_number":2660,"context_line":"        if not dest_share_servers:"},{"line_number":2661,"context_line":"            if (is_get_progress):"},{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"d14d5ca6_d039fd5b","line":2661,"range":{"start_line":2660,"start_character":8,"end_line":2661,"end_character":32},"in_reply_to":"1d5cf3f7_e6772173","updated":"2023-09-20 19:21:09.000000000","message":"But I want to keep the behavior as before, raising the execption in case of dest_share_servers \u003d False. If a move the is_get_progress as suggested I would need to create other condition for dest\u003dfalse and get_prog\u003dFalse.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e599c5cbcc0b711645b962402a6f5505a92916e9","unresolved":false,"context_lines":[{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"        dest_share_servers \u003d self.db.share_server_get_all_with_filters("},{"line_number":2659,"context_line":"            context, filters\u003dfilters)"},{"line_number":2660,"context_line":"        if not dest_share_servers:"},{"line_number":2661,"context_line":"            if (is_get_progress):"},{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"d6a663c6_c1dffe48","line":2661,"range":{"start_line":2660,"start_character":8,"end_line":2661,"end_character":32},"in_reply_to":"d14d5ca6_d039fd5b","updated":"2023-09-21 10:31:35.000000000","message":"I see. keep as it is.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c3be8df9396a04ab12e3101ddffea71f5092d01d","unresolved":true,"context_lines":[{"line_number":2659,"context_line":"            context, filters\u003dfilters)"},{"line_number":2660,"context_line":"        if not dest_share_servers:"},{"line_number":2661,"context_line":"            if (is_get_progress):"},{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2665,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7cdd43ba_118b4e90","line":2662,"range":{"start_line":2662,"start_character":16,"end_line":2662,"end_character":25},"updated":"2023-09-20 14:59:26.000000000","message":"why return an empty list ? The idea of this function is returning a single \"destination share server\", if there isn\u0027t any, it should return \"None\". Makes more sense from my view for this functon than an empty list.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":false,"context_lines":[{"line_number":2659,"context_line":"            context, filters\u003dfilters)"},{"line_number":2660,"context_line":"        if not dest_share_servers:"},{"line_number":2661,"context_line":"            if (is_get_progress):"},{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2665,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3e90970a_2c657e35","line":2662,"range":{"start_line":2662,"start_character":16,"end_line":2662,"end_character":25},"in_reply_to":"7cdd43ba_118b4e90","updated":"2023-09-20 19:21:09.000000000","message":"Done","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"6ce5e0b267de5f1cb6e3bdac1a0b8d32db4325dc","unresolved":true,"context_lines":[{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2665,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2666,"context_line":"        if len(dest_share_servers) \u003e 1:"},{"line_number":2667,"context_line":"            msg \u003d _(\"More than one destination share server was found for \""},{"line_number":2668,"context_line":"                    \"source share server %s. Aborting...\") % source_server_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"201b403e_5028f5c8","line":2665,"updated":"2023-09-20 16:52:35.000000000","message":"Need to remove below lines of codes as we are returning the empty list or None. In this case below line of code will never executed.\nmsg \u003d _(\"A destination share server wasn\u0027t found for source \"\n                    \"share server %s.\") % source_server_id\n            raise exception.InvalidShareServer(reason\u003dmsg)","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":true,"context_lines":[{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2665,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2666,"context_line":"        if len(dest_share_servers) \u003e 1:"},{"line_number":2667,"context_line":"            msg \u003d _(\"More than one destination share server was found for \""},{"line_number":2668,"context_line":"                    \"source share server %s. Aborting...\") % source_server_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"cc1d57db_52e0ea6c","line":2665,"in_reply_to":"201b403e_5028f5c8","updated":"2023-09-20 19:21:09.000000000","message":"I think we can keep the exception because we are handling 2 scenarios (when the call comes from share_server_migration_get_progress or not).\nSo, we keep the behavior raising an exception for calls not related with the get_progress operation.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"1ada1b4ca4c93bfe4d4cbbc0322457babaf00f00","unresolved":false,"context_lines":[{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2665,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2666,"context_line":"        if len(dest_share_servers) \u003e 1:"},{"line_number":2667,"context_line":"            msg \u003d _(\"More than one destination share server was found for \""},{"line_number":2668,"context_line":"                    \"source share server %s. Aborting...\") % source_server_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"30fd8b8f_7834621f","line":2665,"in_reply_to":"28c433fe_10fbfd94","updated":"2023-09-21 14:22:02.000000000","message":"Done","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e599c5cbcc0b711645b962402a6f5505a92916e9","unresolved":true,"context_lines":[{"line_number":2662,"context_line":"                return []"},{"line_number":2663,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2664,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2665,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":2666,"context_line":"        if len(dest_share_servers) \u003e 1:"},{"line_number":2667,"context_line":"            msg \u003d _(\"More than one destination share server was found for \""},{"line_number":2668,"context_line":"                    \"source share server %s. Aborting...\") % source_server_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"28c433fe_10fbfd94","line":2665,"in_reply_to":"cc1d57db_52e0ea6c","updated":"2023-09-21 10:31:35.000000000","message":"Caique+1","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"79078a3ade3fd979dbd4a7f14ef0a98ab97c7a00","unresolved":true,"context_lines":[{"line_number":3063,"context_line":"            is_get_progress\u003dTrue"},{"line_number":3064,"context_line":"        )"},{"line_number":3065,"context_line":""},{"line_number":3066,"context_line":"        if isinstance(dest_share_server, list):"},{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"cb565c80_15f89dbf","line":3066,"updated":"2023-09-20 17:36:01.000000000","message":"Change this condition, if you are returning the empty list then it should \nif len(dest_share_server) \u003d\u003d 0:\n\nor if you are returning the None then it should be \nif dest_share_server is None\n\nit is recommended to return the None instead of empty list for share_server_migration_get_destination method, even Felipe suggested the same.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":false,"context_lines":[{"line_number":3063,"context_line":"            is_get_progress\u003dTrue"},{"line_number":3064,"context_line":"        )"},{"line_number":3065,"context_line":""},{"line_number":3066,"context_line":"        if isinstance(dest_share_server, list):"},{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b3e3298f_42a970dd","line":3066,"in_reply_to":"cb565c80_15f89dbf","updated":"2023-09-20 19:21:09.000000000","message":"Done","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"79078a3ade3fd979dbd4a7f14ef0a98ab97c7a00","unresolved":true,"context_lines":[{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3073,"context_line":"                    \"obtained. The provided share server is not being \""}],"source_content_type":"text/x-python","patch_set":6,"id":"120ff3e6_bc2e7b63","line":3070,"updated":"2023-09-20 17:36:01.000000000","message":"task_state\u0027: \u0027migration_not_found\u0027,\nis this right task_state for migration. will this can be mislead to customer. I don\u0027t this we have any migration task_state as migration_not_found. I think better to keep task_state: \u0027\u0027. This is just suggestion but better to discuss this with felippe and carloss.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":true,"context_lines":[{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3073,"context_line":"                    \"obtained. The provided share server is not being \""}],"source_content_type":"text/x-python","patch_set":6,"id":"ae06793c_be7d8e3a","line":3070,"in_reply_to":"120ff3e6_bc2e7b63","updated":"2023-09-20 19:21:09.000000000","message":"Yes, I agree. We can see Carloss and Felipe opinions about that.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4d137487523df0dc207e4b4fd754eeb97019926","unresolved":true,"context_lines":[{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3073,"context_line":"                    \"obtained. The provided share server is not being \""}],"source_content_type":"text/x-python","patch_set":6,"id":"a718c6e8_538334b2","line":3070,"in_reply_to":"91a87d6c_b30a207d","updated":"2023-09-21 14:01:16.000000000","message":"I agree too","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"1ada1b4ca4c93bfe4d4cbbc0322457babaf00f00","unresolved":false,"context_lines":[{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3073,"context_line":"                    \"obtained. The provided share server is not being \""}],"source_content_type":"text/x-python","patch_set":6,"id":"b800e825_257b0335","line":3070,"in_reply_to":"a718c6e8_538334b2","updated":"2023-09-21 14:22:02.000000000","message":"Done","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e599c5cbcc0b711645b962402a6f5505a92916e9","unresolved":true,"context_lines":[{"line_number":3067,"context_line":"            return {"},{"line_number":3068,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3073,"context_line":"                    \"obtained. The provided share server is not being \""}],"source_content_type":"text/x-python","patch_set":6,"id":"91a87d6c_b30a207d","line":3070,"in_reply_to":"ae06793c_be7d8e3a","updated":"2023-09-21 10:31:35.000000000","message":"agree.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c3be8df9396a04ab12e3101ddffea71f5092d01d","unresolved":true,"context_lines":[{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3073,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":3074,"context_line":"                    \"migrated. This operation \""},{"line_number":3075,"context_line":"                    \"can be retried.\") % share_server[\u0027id\u0027]"},{"line_number":3076,"context_line":"            LOG.info(msg)"},{"line_number":3077,"context_line":""},{"line_number":3078,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"},{"line_number":3079,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e91776c9_ce18d075","line":3076,"range":{"start_line":3072,"start_character":12,"end_line":3076,"end_character":25},"updated":"2023-09-20 14:59:26.000000000","message":"should it be before the \"return\" ? Otherwise it will never be called. Am I wrong ?","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ee635f99b9fc437f5a1b3e78b786732234d11a95","unresolved":false,"context_lines":[{"line_number":3069,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3070,"context_line":"                \u0027task_state\u0027: \u0027migration_not_found\u0027,"},{"line_number":3071,"context_line":"            }"},{"line_number":3072,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3073,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":3074,"context_line":"                    \"migrated. This operation \""},{"line_number":3075,"context_line":"                    \"can be retried.\") % share_server[\u0027id\u0027]"},{"line_number":3076,"context_line":"            LOG.info(msg)"},{"line_number":3077,"context_line":""},{"line_number":3078,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"},{"line_number":3079,"context_line":"                constants.TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS):"}],"source_content_type":"text/x-python","patch_set":6,"id":"623139fc_70f9fd51","line":3076,"range":{"start_line":3072,"start_character":12,"end_line":3076,"end_character":25},"in_reply_to":"e91776c9_ce18d075","updated":"2023-09-20 19:21:09.000000000","message":"Done","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"8ddd138445050508a305b4bc2448a69a261de59c","unresolved":true,"context_lines":[{"line_number":2650,"context_line":""},{"line_number":2651,"context_line":"    def share_server_migration_get_destination(self, context, source_server_id,"},{"line_number":2652,"context_line":"                                               status\u003dNone,"},{"line_number":2653,"context_line":"                                               is_get_progress\u003dFalse):"},{"line_number":2654,"context_line":"        \"\"\"Returns destination share server for a share server migration."},{"line_number":2655,"context_line":""},{"line_number":2656,"context_line":"        If a share server migration get progress is called immediately after a"}],"source_content_type":"text/x-python","patch_set":9,"id":"ef2bf03e_c97d32af","line":2653,"updated":"2023-09-21 14:49:44.000000000","message":"nit:All invocations are passing True. Can make default to True and ignore passing this attribute while invoking.","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e8bef1e0f32019de6c7e0bd0107feed3118d1507","unresolved":false,"context_lines":[{"line_number":2650,"context_line":""},{"line_number":2651,"context_line":"    def share_server_migration_get_destination(self, context, source_server_id,"},{"line_number":2652,"context_line":"                                               status\u003dNone,"},{"line_number":2653,"context_line":"                                               is_get_progress\u003dFalse):"},{"line_number":2654,"context_line":"        \"\"\"Returns destination share server for a share server migration."},{"line_number":2655,"context_line":""},{"line_number":2656,"context_line":"        If a share server migration get progress is called immediately after a"}],"source_content_type":"text/x-python","patch_set":9,"id":"019a5d94_fd397bd6","line":2653,"in_reply_to":"1abfc0c9_d40ca257","updated":"2023-09-21 15:33:04.000000000","message":"+1 Thank you!","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"cdf7324c64d1ca9d1e17d3280a12746e6c9f7768","unresolved":true,"context_lines":[{"line_number":2650,"context_line":""},{"line_number":2651,"context_line":"    def share_server_migration_get_destination(self, context, source_server_id,"},{"line_number":2652,"context_line":"                                               status\u003dNone,"},{"line_number":2653,"context_line":"                                               is_get_progress\u003dFalse):"},{"line_number":2654,"context_line":"        \"\"\"Returns destination share server for a share server migration."},{"line_number":2655,"context_line":""},{"line_number":2656,"context_line":"        If a share server migration get progress is called immediately after a"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abfc0c9_d40ca257","line":2653,"in_reply_to":"ef2bf03e_c97d32af","updated":"2023-09-21 15:16:27.000000000","message":"Hi Jay, thanks for the review. Actually not all the invocations are passing True. This method is also used in others share_server_migration operations, such as \"share_server_migration_complete\".","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e599c5cbcc0b711645b962402a6f5505a92916e9","unresolved":true,"context_lines":[{"line_number":2667,"context_line":"            context, filters\u003dfilters)"},{"line_number":2668,"context_line":"        if not dest_share_servers:"},{"line_number":2669,"context_line":"            if is_get_progress:"},{"line_number":2670,"context_line":"                return None"},{"line_number":2671,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2672,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2673,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3e1e7647_fea717b3","line":2670,"updated":"2023-09-21 10:31:35.000000000","message":"This new scenario is not being tested by any unit tests. You should cover it. Can you add UT for it ?","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4d137487523df0dc207e4b4fd754eeb97019926","unresolved":true,"context_lines":[{"line_number":2667,"context_line":"            context, filters\u003dfilters)"},{"line_number":2668,"context_line":"        if not dest_share_servers:"},{"line_number":2669,"context_line":"            if is_get_progress:"},{"line_number":2670,"context_line":"                return None"},{"line_number":2671,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2672,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2673,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"e3540ef0_450bc164","line":2670,"in_reply_to":"3e1e7647_fea717b3","updated":"2023-09-21 14:01:16.000000000","message":"++","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"1ada1b4ca4c93bfe4d4cbbc0322457babaf00f00","unresolved":false,"context_lines":[{"line_number":2667,"context_line":"            context, filters\u003dfilters)"},{"line_number":2668,"context_line":"        if not dest_share_servers:"},{"line_number":2669,"context_line":"            if is_get_progress:"},{"line_number":2670,"context_line":"                return None"},{"line_number":2671,"context_line":"            msg \u003d _(\"A destination share server wasn\u0027t found for source \""},{"line_number":2672,"context_line":"                    \"share server %s.\") % source_server_id"},{"line_number":2673,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"a71a0aec_0b18a342","line":2670,"in_reply_to":"e3540ef0_450bc164","updated":"2023-09-21 14:22:02.000000000","message":"Done","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e599c5cbcc0b711645b962402a6f5505a92916e9","unresolved":true,"context_lines":[{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3076,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":3077,"context_line":"                    \"migrated. This operation \""},{"line_number":3078,"context_line":"                    \"can be retried.\") % share_server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"ebfd0643_0b0ae743","line":3075,"updated":"2023-09-21 10:31:35.000000000","message":"This new scenario is not being tested by any unit tests. You should cover it. Can you add UT for it ?","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"1ada1b4ca4c93bfe4d4cbbc0322457babaf00f00","unresolved":false,"context_lines":[{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3076,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":3077,"context_line":"                    \"migrated. This operation \""},{"line_number":3078,"context_line":"                    \"can be retried.\") % share_server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"0b2bf0b1_30115370","line":3075,"in_reply_to":"ebfd0643_0b0ae743","updated":"2023-09-21 14:22:02.000000000","message":"Done","commit_id":"45eea2b15ba6d90602af93c3d59e7d17ecf79771"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bb962637fc2e3025da91e527fe91a83aa6cc753c","unresolved":true,"context_lines":[{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3076,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":3077,"context_line":"                    \"migrated. This operation \""},{"line_number":3078,"context_line":"                    \"can be retried.\") % share_server[\u0027id\u0027]"},{"line_number":3079,"context_line":"            LOG.info(msg)"},{"line_number":3080,"context_line":"            return {"},{"line_number":3081,"context_line":"                \u0027total_progress\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":10,"id":"591f02ca_d8ebd75d","line":3078,"range":{"start_line":3075,"start_character":20,"end_line":3078,"end_character":37},"updated":"2023-09-22 18:10:40.000000000","message":"I believe this message can be misleading, specially considering this part:\n\"The provided share server is not being migrated\" - If they got to this point, it means that the source share server is being migrated, as it is being validated in line 3061. If we leave it as is, the administrators might want to trigger the migration again, but it has already been started.\nSo I would suggest something on the lines of:\nMigration progress of share server %s cannot be determined yet. Please retry.","commit_id":"ca861f1452d32e6dd7110d3fe1f01f095331ba23"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"32fa7777f99e948ed71c3a02f7233891ff31adaa","unresolved":false,"context_lines":[{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3076,"context_line":"                    \"obtained. The provided share server is not being \""},{"line_number":3077,"context_line":"                    \"migrated. This operation \""},{"line_number":3078,"context_line":"                    \"can be retried.\") % share_server[\u0027id\u0027]"},{"line_number":3079,"context_line":"            LOG.info(msg)"},{"line_number":3080,"context_line":"            return {"},{"line_number":3081,"context_line":"                \u0027total_progress\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":10,"id":"afcd93fb_c4f73950","line":3078,"range":{"start_line":3075,"start_character":20,"end_line":3078,"end_character":37},"in_reply_to":"591f02ca_d8ebd75d","updated":"2023-09-25 11:40:48.000000000","message":"Thank you for the review carloss. The new message is better.","commit_id":"ca861f1452d32e6dd7110d3fe1f01f095331ba23"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6f682c4335eee0435f5fc126668a5946b5e45ca","unresolved":true,"context_lines":[{"line_number":3065,"context_line":"            LOG.error(msg)"},{"line_number":3066,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":3067,"context_line":""},{"line_number":3068,"context_line":"        dest_share_server \u003d self.share_server_migration_get_destination("},{"line_number":3069,"context_line":"            context, share_server[\u0027id\u0027],"},{"line_number":3070,"context_line":"            status\u003dconstants.STATUS_SERVER_MIGRATING_TO,"},{"line_number":3071,"context_line":"            is_get_progress\u003dTrue"},{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""}],"source_content_type":"text/x-python","patch_set":12,"id":"b959b5b9_d241a8a1","line":3072,"range":{"start_line":3068,"start_character":0,"end_line":3072,"end_character":9},"updated":"2023-09-28 00:02:13.000000000","message":"instead of handling this error by setting the \"is_get_progress\" context, could you try...except on `exception.InvalidShareServer`?\n\nIt\u0027s more readable - and you\u0027ll not need to modify the shared `share_server_migration_get_destination` method","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"d540eba6e0e9e80e5a0753bc099063b0c3e6195f","unresolved":false,"context_lines":[{"line_number":3065,"context_line":"            LOG.error(msg)"},{"line_number":3066,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":3067,"context_line":""},{"line_number":3068,"context_line":"        dest_share_server \u003d self.share_server_migration_get_destination("},{"line_number":3069,"context_line":"            context, share_server[\u0027id\u0027],"},{"line_number":3070,"context_line":"            status\u003dconstants.STATUS_SERVER_MIGRATING_TO,"},{"line_number":3071,"context_line":"            is_get_progress\u003dTrue"},{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""}],"source_content_type":"text/x-python","patch_set":12,"id":"8e9f8bdf_c572f13c","line":3072,"range":{"start_line":3068,"start_character":0,"end_line":3072,"end_character":9},"in_reply_to":"609faa6a_c1d85a1e","updated":"2023-09-29 19:29:29.000000000","message":"Done","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"398d9987d46790c93f972874ece179ee8abe5cf3","unresolved":true,"context_lines":[{"line_number":3065,"context_line":"            LOG.error(msg)"},{"line_number":3066,"context_line":"            raise exception.InvalidShareServer(reason\u003dmsg)"},{"line_number":3067,"context_line":""},{"line_number":3068,"context_line":"        dest_share_server \u003d self.share_server_migration_get_destination("},{"line_number":3069,"context_line":"            context, share_server[\u0027id\u0027],"},{"line_number":3070,"context_line":"            status\u003dconstants.STATUS_SERVER_MIGRATING_TO,"},{"line_number":3071,"context_line":"            is_get_progress\u003dTrue"},{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""}],"source_content_type":"text/x-python","patch_set":12,"id":"609faa6a_c1d85a1e","line":3072,"range":{"start_line":3068,"start_character":0,"end_line":3072,"end_character":9},"in_reply_to":"b959b5b9_d241a8a1","updated":"2023-09-29 19:29:10.000000000","message":"yes, nice touch. I added the try...except instead of the changes in the method.","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6f682c4335eee0435f5fc126668a5946b5e45ca","unresolved":true,"context_lines":[{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3076,"context_line":"                    \"determined yet. Please retry the migration get \""},{"line_number":3077,"context_line":"                    \"progress operation.\") % share_server[\u0027id\u0027]"},{"line_number":3078,"context_line":"            LOG.info(msg)"},{"line_number":3079,"context_line":"            return {"},{"line_number":3080,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3081,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"f680e070_ba2e929f","line":3078,"range":{"start_line":3075,"start_character":0,"end_line":3078,"end_character":25},"updated":"2023-09-28 00:02:13.000000000","message":"this isn\u0027t useful to log at the Info level.. the caller would need to understand that \"destination_share_server_id\" set to None is a normal situation;","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"81a739d1d1a1f6e4331f438348f782aff5e7615d","unresolved":false,"context_lines":[{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3076,"context_line":"                    \"determined yet. Please retry the migration get \""},{"line_number":3077,"context_line":"                    \"progress operation.\") % share_server[\u0027id\u0027]"},{"line_number":3078,"context_line":"            LOG.info(msg)"},{"line_number":3079,"context_line":"            return {"},{"line_number":3080,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3081,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa60afc4_1fd3ab59","line":3078,"range":{"start_line":3075,"start_character":0,"end_line":3078,"end_character":25},"in_reply_to":"d7f6e6ee_bde9bcd1","updated":"2023-10-19 21:18:23.000000000","message":"yes; not a big deal though..","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"398d9987d46790c93f972874ece179ee8abe5cf3","unresolved":true,"context_lines":[{"line_number":3072,"context_line":"        )"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"        if dest_share_server is None:"},{"line_number":3075,"context_line":"            msg \u003d _(\"Migration progress of share server %s cannot be \""},{"line_number":3076,"context_line":"                    \"determined yet. Please retry the migration get \""},{"line_number":3077,"context_line":"                    \"progress operation.\") % share_server[\u0027id\u0027]"},{"line_number":3078,"context_line":"            LOG.info(msg)"},{"line_number":3079,"context_line":"            return {"},{"line_number":3080,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3081,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"d7f6e6ee_bde9bcd1","line":3078,"range":{"start_line":3075,"start_character":0,"end_line":3078,"end_character":25},"in_reply_to":"f680e070_ba2e929f","updated":"2023-09-29 19:29:10.000000000","message":"I didn\u0027t understand the point to not have the log. Should we remove the log info instead?","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6f682c4335eee0435f5fc126668a5946b5e45ca","unresolved":true,"context_lines":[{"line_number":3077,"context_line":"                    \"progress operation.\") % share_server[\u0027id\u0027]"},{"line_number":3078,"context_line":"            LOG.info(msg)"},{"line_number":3079,"context_line":"            return {"},{"line_number":3080,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3081,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3082,"context_line":"                \u0027task_state\u0027: \u0027\u0027,"},{"line_number":3083,"context_line":"            }"},{"line_number":3084,"context_line":""},{"line_number":3085,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":12,"id":"b6ae1e39_176a0479","line":3082,"range":{"start_line":3080,"start_character":17,"end_line":3082,"end_character":33},"updated":"2023-09-28 00:02:13.000000000","message":"initialize this in a structure:\n```\nresult \u003d {\n    \u0027destination_share_server_id\u0027: \u0027\u0027,\n}\n```\n\nand call `_migration_get_progress_state(share_server)` to update the result","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"398d9987d46790c93f972874ece179ee8abe5cf3","unresolved":false,"context_lines":[{"line_number":3077,"context_line":"                    \"progress operation.\") % share_server[\u0027id\u0027]"},{"line_number":3078,"context_line":"            LOG.info(msg)"},{"line_number":3079,"context_line":"            return {"},{"line_number":3080,"context_line":"                \u0027total_progress\u0027: 0,"},{"line_number":3081,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3082,"context_line":"                \u0027task_state\u0027: \u0027\u0027,"},{"line_number":3083,"context_line":"            }"},{"line_number":3084,"context_line":""},{"line_number":3085,"context_line":"        if (share_server[\u0027task_state\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":12,"id":"f3565c3c_beb7dc2e","line":3082,"range":{"start_line":3080,"start_character":17,"end_line":3082,"end_character":33},"in_reply_to":"b6ae1e39_176a0479","updated":"2023-09-29 19:29:10.000000000","message":"Done","commit_id":"4a569246ef9f483ce3d2449650e316ba10c4f62e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c33cd2cbda2b1c3d3c24828291562a3fb25aab2","unresolved":true,"context_lines":[{"line_number":3062,"context_line":"                status\u003dconstants.STATUS_SERVER_MIGRATING_TO"},{"line_number":3063,"context_line":"            )"},{"line_number":3064,"context_line":"        except Exception:"},{"line_number":3065,"context_line":"            msg \u003d (\"Migration progress of share server %s cannot be \""},{"line_number":3066,"context_line":"                   \"determined yet. Please retry the migration get \""},{"line_number":3067,"context_line":"                   \"progress operation.\") % share_server[\u0027id\u0027]"},{"line_number":3068,"context_line":"            LOG.info(msg)"},{"line_number":3069,"context_line":""},{"line_number":3070,"context_line":"            result \u003d {"},{"line_number":3071,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3dcee0e4_b0216d47","line":3068,"range":{"start_line":3065,"start_character":12,"end_line":3068,"end_character":25},"updated":"2023-10-02 17:38:39.000000000","message":"responding to a comment on the previous patchset.. i think this log is not useful at the \"Info\" level; would we be able to switch to \"debug\".. \n\nthe reason i say that is that you\u0027re really providing the information we have at hand with the API through this change... no further action (i.e., logging) is really necessary..","commit_id":"736deefd37884f437f9290151c9baa43145a96e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c33cd2cbda2b1c3d3c24828291562a3fb25aab2","unresolved":true,"context_lines":[{"line_number":3069,"context_line":""},{"line_number":3070,"context_line":"            result \u003d {"},{"line_number":3071,"context_line":"                \u0027destination_share_server_id\u0027: \u0027\u0027,"},{"line_number":3072,"context_line":"                \u0027task_state\u0027: \u0027\u0027"},{"line_number":3073,"context_line":"                }"},{"line_number":3074,"context_line":""},{"line_number":3075,"context_line":"            result.update(self._migration_get_progress_state(share_server))"}],"source_content_type":"text/x-python","patch_set":13,"id":"fb35ec25_9a1e34d3","line":3072,"range":{"start_line":3072,"start_character":16,"end_line":3072,"end_character":32},"updated":"2023-10-02 17:38:39.000000000","message":"nit: remove; we set the share server\u0027s task_state to \"TASK_STATE_MIGRATION_STARTING\" on line 2940.. and the update on line 3075 will replace this anyway.","commit_id":"736deefd37884f437f9290151c9baa43145a96e9"}],"releasenotes/notes/bug-2025075-BadRequest-share-server-migration-get-progress-bf6fe476f7ab3111.yaml":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c3be8df9396a04ab12e3101ddffea71f5092d01d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Netapp driver: Fix Netapp BadRequest error from"},{"line_number":5,"context_line":"    share-server-migration-get-progress. For more details please refer to"},{"line_number":6,"context_line":"    `launchpad bug #2025075 \u003chttps://bugs.launchpad.net/manila/+bug/2025075\u003e`"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f194dc69_a5dbddb6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":29},"updated":"2023-09-20 14:59:26.000000000","message":"It is not a NetApp bug. It is a Manila share server migration bug that was found when the NetApp driver was in use.","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"312b6977bb2dbb747b4e652013ae277edc679bda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Netapp driver: Fix Netapp BadRequest error from"},{"line_number":5,"context_line":"    share-server-migration-get-progress. For more details please refer to"},{"line_number":6,"context_line":"    `launchpad bug #2025075 \u003chttps://bugs.launchpad.net/manila/+bug/2025075\u003e`"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a275ce3d_243bb3eb","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":29},"in_reply_to":"f194dc69_a5dbddb6","updated":"2023-09-20 19:22:28.000000000","message":"Done","commit_id":"e436cd49bf110541f751f8f65ba6b7b2218bd490"}]}