)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7778c1d55febd5479ce05f4f4bcbbbe6e36ffd9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5fe3496_7ba3bd70","updated":"2023-08-15 23:04:15.000000000","message":"thanks for submitting this code change; the functionality itself looks good, we\u0027ve a failing unit test:\n\n```\nmanila.tests.share.test_manager.ShareManagerTestCase.test_create_share_instance_with_share_network_server_fail\n```\n\nNeed to add a share type to the share obj being created here: https://opendev.org/openstack/manila/src/commit/824fdb3270e64782cfdeb6bf27ea107ef7c1e58f/manila/tests/share/test_manager.py#L2253-L2254\n\n\nAlso, with your next patch, could you please add a release note?\n\nhttps://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#how-do-i-add-a-release-note","commit_id":"ea6bf3fcc719521d093c6b28527d6acbad55d4e0"},{"author":{"_account_id":36240,"name":"Mariusz Adamski","display_name":"Mariusz Adamski","email":"mariusz.adamski@ovhcloud.com","username":"mariuszadamski-ovh","status":"OVH Group"},"change_message_id":"da999ee74e56a9a4dbfe33797f966d3a1bd03244","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3dcebac_6df865b4","in_reply_to":"4b7b963b_32e4f74f","updated":"2023-08-18 08:49:32.000000000","message":"Test fixed. I added the release note as well.","commit_id":"ea6bf3fcc719521d093c6b28527d6acbad55d4e0"},{"author":{"_account_id":36240,"name":"Mariusz Adamski","display_name":"Mariusz Adamski","email":"mariusz.adamski@ovhcloud.com","username":"mariuszadamski-ovh","status":"OVH Group"},"change_message_id":"71ce9c6a0d4a11753b7c3d7d9193140c7f6cde83","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b7b963b_32e4f74f","in_reply_to":"f5fe3496_7ba3bd70","updated":"2023-08-16 06:45:42.000000000","message":"Thank you Goutham, I\u0027ll get back to it as soon as I can.","commit_id":"ea6bf3fcc719521d093c6b28527d6acbad55d4e0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"64033a723e71f74ec9176cf3c65e108d96f145b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5527ba47_ae2688f9","updated":"2023-08-29 18:36:43.000000000","message":"LGTM, thanks for the enhancement, Mariusz","commit_id":"94b71a5faf5fe161e2a74b36f99d6a0bd17b32a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38a0f0a586558a1f851297d28f7b631c7b50ad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2305bc3f_0df8c0dd","updated":"2023-08-18 17:07:41.000000000","message":"Thanks Mariusz; this LGTM... we don\u0027t enable oslo_messaging_notifications in any of our CI jobs; but the code fix looks good. Have you tested this in your environment with notifications enabled?","commit_id":"94b71a5faf5fe161e2a74b36f99d6a0bd17b32a5"},{"author":{"_account_id":36240,"name":"Mariusz Adamski","display_name":"Mariusz Adamski","email":"mariusz.adamski@ovhcloud.com","username":"mariuszadamski-ovh","status":"OVH Group"},"change_message_id":"8b2c0c26a48f02c715191db6aace621bf23bfbf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1dfc7121_42c92b25","in_reply_to":"1b73fc37_67ccc830","updated":"2023-08-30 12:37:53.000000000","message":"Thanks, I\u0027ve found this in the #openstack-qa logs from yesterday: https://github.com/tox-dev/pyproject-api/issues/101\nIt should be fixed with the newer tox release, so I think this is a case for a recheck.","commit_id":"94b71a5faf5fe161e2a74b36f99d6a0bd17b32a5"},{"author":{"_account_id":36240,"name":"Mariusz Adamski","display_name":"Mariusz Adamski","email":"mariusz.adamski@ovhcloud.com","username":"mariuszadamski-ovh","status":"OVH Group"},"change_message_id":"4d2cc874ce347de62bf0a67f2a0da48ad74d998b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9c6166e_ae4f353d","in_reply_to":"2305bc3f_0df8c0dd","updated":"2023-08-23 15:40:44.000000000","message":"Thanks Goutham, yes I did test it in my environment, with both RabbitMQ an Kafka. Everything was working as expected.","commit_id":"94b71a5faf5fe161e2a74b36f99d6a0bd17b32a5"},{"author":{"_account_id":36240,"name":"Mariusz Adamski","display_name":"Mariusz Adamski","email":"mariusz.adamski@ovhcloud.com","username":"mariuszadamski-ovh","status":"OVH Group"},"change_message_id":"8f8a29aba99119b8ccf66d45a87b8e6aeaedb26a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"920e62c0_678d46e1","in_reply_to":"5527ba47_ae2688f9","updated":"2023-08-30 08:53:54.000000000","message":"Thanks Carlos! I\u0027ll look into these failed gate jobs.","commit_id":"94b71a5faf5fe161e2a74b36f99d6a0bd17b32a5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bf9882583f82e862a2a70db6f24332789e01a1c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b73fc37_67ccc830","in_reply_to":"920e62c0_678d46e1","updated":"2023-08-30 11:10:29.000000000","message":"Hi, Mariusz! I believe this is an issue with the CI itself. I\u0027m seeing jobs failing in other projects as well. I\u0027ll take a look around to see if there\u0027s a fix that people are working on.","commit_id":"94b71a5faf5fe161e2a74b36f99d6a0bd17b32a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8a5aee43d11b6162674619dfcb5d893a67a442a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f4a482b_2a49cda0","in_reply_to":"e9c6166e_ae4f353d","updated":"2023-08-23 18:54:26.000000000","message":"Thank you!","commit_id":"94b71a5faf5fe161e2a74b36f99d6a0bd17b32a5"}]}