)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0a235ed5c4139dc5bcdd104870ad73b14e33b929","unresolved":true,"context_lines":[{"line_number":9,"context_line":"- Follow up change to fix suggestions from earlier pull request i.e."},{"line_number":10,"context_line":"  https://review.opendev.org/c/openstack/manila/+/343980 ."},{"line_number":11,"context_line":"- Add API-ref docs"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement: blueprint share-backup"},{"line_number":14,"context_line":"Change-Id: Ice01ab7892b1eb52b3202f2c79957977f73f3aca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"216554fc_b6b55019","line":12,"updated":"2023-08-17 15:37:10.000000000","message":"please add closes-bug tag for https://bugs.launchpad.net/manila/+bug/2031311","commit_id":"cf36feb605ef336b698f05a1bf2ba0ccaefeaf6c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d3c6a7ac82d3f6ac6844f1e29c2e019853f3373a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- Follow up change to fix suggestions from earlier pull request i.e."},{"line_number":10,"context_line":"  https://review.opendev.org/c/openstack/manila/+/343980 ."},{"line_number":11,"context_line":"- Add API-ref docs"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement: blueprint share-backup"},{"line_number":14,"context_line":"Change-Id: Ice01ab7892b1eb52b3202f2c79957977f73f3aca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"274c517d_f2996346","line":12,"in_reply_to":"216554fc_b6b55019","updated":"2023-08-18 10:58:18.000000000","message":"Done","commit_id":"cf36feb605ef336b698f05a1bf2ba0ccaefeaf6c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1f2059da8d0a991eeab00343d31e5207f456f700","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran Pawar \u003ckinpaa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-22 13:34:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[API docs] Share backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Follow up change to fix suggestions from earlier pull request i.e."},{"line_number":10,"context_line":"  https://review.opendev.org/c/openstack/manila/+/343980 ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"496d2e54_9a41dd51","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"updated":"2023-08-23 20:04:19.000000000","message":"it feels like this is all docs - it isn\u0027t.. so I\u0027d remove this and use a different commit message header; perhaps:\n\n\"Change Share backup API and add api ref\"","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran Pawar \u003ckinpaa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-22 13:34:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[API docs] Share backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Follow up change to fix suggestions from earlier pull request i.e."},{"line_number":10,"context_line":"  https://review.opendev.org/c/openstack/manila/+/343980 ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"51f59d7e_21f509bc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"496d2e54_9a41dd51","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"400ce58086fce8e967d854b51b1b214f58d002c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"609a4c8c_3fecd60c","updated":"2023-08-21 13:24:24.000000000","message":"Changed update API response from 202 to 200.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"88461473_4470f984","updated":"2023-08-22 01:18:02.000000000","message":"Some more comments","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1d0bffb2_4b03c633","updated":"2023-08-22 13:34:51.000000000","message":"Thanks for detailed review. Fixed suggestions.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a8f95af8cd813f9a9e22ba7d994cb07c566b9152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cd36606b_bd3302cc","updated":"2023-08-22 01:23:25.000000000","message":"just some comments. thanks for your docs.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e5363d0b_72126b15","updated":"2023-08-22 22:55:44.000000000","message":"Thanks for the changes; some more comments about the API Ref..","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6e3846ca92ebbf58cf25b8f100b065d5b12953be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c1cb9f71_f86d7ead","updated":"2023-08-23 14:47:13.000000000","message":"Haixin, i missed your latest comment. Fixed it the way snapshots support \u0027all_tenants\u0027 option. WDYT ?","commit_id":"dff7addd0d425c979e476eec58acd637dbe9ddf7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"824b7e4dd85db155efde19f5de7ff53ca7124d9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b5a69bb3_f72e5133","updated":"2023-08-23 21:55:11.000000000","message":"Hi, Kiran! While testing with the CLI I realized the dummy driver is not working fine. When I attempted to create a backup, it was stuck in creating, when I attempted to restore it was also stuc... The dummy driver is very important for CI testing (and you\u0027ll also need it in your tempest change). Please take a look and fix the issues with it.","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"df3da78c_7c020012","updated":"2023-08-24 08:26:07.000000000","message":"fixed suggestions from haixin and goutham. Please review.","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6490a904_d771aff9","updated":"2023-08-23 19:59:56.000000000","message":"looking good, thanks; some more comments as the review on the tests continues","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e30a4b1c5b3c068d4477635a68642950be349734","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bd9a3c28_e412a7ab","updated":"2023-08-24 12:04:34.000000000","message":"As per suggestion on manilaclient PR, `name` is added in summary list. \nAlso, fixed db to change az to az_id as az column was old way when backup PR was initially created.","commit_id":"486455e14e583b44dc35d973c509270f95b3c352"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0e35681247d3ac600c3243ef8c277f1c4d6adf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a8ab5ce1_6bea1ecf","updated":"2023-08-24 09:07:25.000000000","message":"two comments. Kiran Pawar.","commit_id":"486455e14e583b44dc35d973c509270f95b3c352"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4fa37d752ab4d9bbfc5f0cb55b2df95d6ca459ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8d5a478d_8406b1b3","updated":"2023-08-24 15:17:24.000000000","message":"now, LGTM. thanks.","commit_id":"713f2d22cb3a3596632d1ca5de46af3690aa91ad"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a6bff35035d70600dfbaa1e59239cce6f686aeab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d220c732_80491ce5","updated":"2023-08-28 01:28:28.000000000","message":"LGTM.","commit_id":"3a2d220f8a11570a90fc2cfcdb111fe577e4b800"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"52191808d9c3058f39c407e43b5df88015cc187c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"521b4a26_74a1de79","updated":"2023-08-28 19:53:29.000000000","message":"LGTM. Apparently, Goutham\u0027s comments have been addressed as well, so let\u0027s get this change merged.","commit_id":"3a2d220f8a11570a90fc2cfcdb111fe577e4b800"}],"api-ref/source/index.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":55,"context_line":".. include:: share-group-types.inc"},{"line_number":56,"context_line":".. include:: share-group-snapshots.inc"},{"line_number":57,"context_line":".. include:: share-transfers.inc"},{"line_number":58,"context_line":".. include:: share-backups.inc"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":61,"context_line":"Shared File Systems API (EXPERIMENTAL)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c0bc84cf_06cafac2","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":30},"updated":"2023-08-22 22:55:44.000000000","message":"this needs to be moved to the section below since it is an experimental API","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":55,"context_line":".. include:: share-group-types.inc"},{"line_number":56,"context_line":".. include:: share-group-snapshots.inc"},{"line_number":57,"context_line":".. include:: share-transfers.inc"},{"line_number":58,"context_line":".. include:: share-backups.inc"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":61,"context_line":"Shared File Systems API (EXPERIMENTAL)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d3c5c10b_a18e4f29","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":30},"in_reply_to":"c0bc84cf_06cafac2","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  description: |"},{"line_number":19,"context_line":"    The UUID of the share backup."},{"line_number":20,"context_line":"  in: path"},{"line_number":21,"context_line":"  required: false"},{"line_number":22,"context_line":"  type: string"},{"line_number":23,"context_line":"export_location_id_path:"},{"line_number":24,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a104be0d_571dde66","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":17},"updated":"2023-08-22 01:18:02.000000000","message":"true\n\npath parameters are seldom optional","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  description: |"},{"line_number":19,"context_line":"    The UUID of the share backup."},{"line_number":20,"context_line":"  in: path"},{"line_number":21,"context_line":"  required: false"},{"line_number":22,"context_line":"  type: string"},{"line_number":23,"context_line":"export_location_id_path:"},{"line_number":24,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"308880ec_018ae7ee","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":17},"in_reply_to":"a104be0d_571dde66","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":911,"context_line":"  type: object"},{"line_number":912,"context_line":"backup_progress:"},{"line_number":913,"context_line":"  description: |"},{"line_number":914,"context_line":"    The progress of the backup creation."},{"line_number":915,"context_line":"  in: body"},{"line_number":916,"context_line":"  required: true"},{"line_number":917,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"391e10b6_7c934b92","line":914,"range":{"start_line":914,"start_character":39,"end_line":914,"end_character":40},"updated":"2023-08-22 01:18:02.000000000","message":"in percentage.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":911,"context_line":"  type: object"},{"line_number":912,"context_line":"backup_progress:"},{"line_number":913,"context_line":"  description: |"},{"line_number":914,"context_line":"    The progress of the backup creation."},{"line_number":915,"context_line":"  in: body"},{"line_number":916,"context_line":"  required: true"},{"line_number":917,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1ff230cf_0aab1ca5","line":914,"range":{"start_line":914,"start_character":39,"end_line":914,"end_character":40},"in_reply_to":"391e10b6_7c934b92","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":917,"context_line":"  type: string"},{"line_number":918,"context_line":"backup_restore_progress:"},{"line_number":919,"context_line":"  description: |"},{"line_number":920,"context_line":"    The progress of the backup restoration."},{"line_number":921,"context_line":"  in: body"},{"line_number":922,"context_line":"  required: true"},{"line_number":923,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"81159c59_fa6e004d","line":920,"range":{"start_line":920,"start_character":42,"end_line":920,"end_character":43},"updated":"2023-08-22 01:18:02.000000000","message":"in percentage.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":917,"context_line":"  type: string"},{"line_number":918,"context_line":"backup_restore_progress:"},{"line_number":919,"context_line":"  description: |"},{"line_number":920,"context_line":"    The progress of the backup restoration."},{"line_number":921,"context_line":"  in: body"},{"line_number":922,"context_line":"  required: true"},{"line_number":923,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a330e8bd_13805b4c","line":920,"range":{"start_line":920,"start_character":42,"end_line":920,"end_character":43},"in_reply_to":"81159c59_fa6e004d","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":921,"context_line":"  in: body"},{"line_number":922,"context_line":"  required: true"},{"line_number":923,"context_line":"  type: string"},{"line_number":924,"context_line":"backup_share_id_request:"},{"line_number":925,"context_line":"  description: |"},{"line_number":926,"context_line":"    The UUID of the share from which to create a backup."},{"line_number":927,"context_line":"  in: body"},{"line_number":928,"context_line":"  required: true"},{"line_number":929,"context_line":"  type: string"},{"line_number":930,"context_line":"backup_share_id_response:"},{"line_number":931,"context_line":"  description: |"},{"line_number":932,"context_line":"    The UUID of the share backup during response of backup create."},{"line_number":933,"context_line":"  in: body"},{"line_number":934,"context_line":"  required: true"},{"line_number":935,"context_line":"  type: string"},{"line_number":936,"context_line":"backup_size:"},{"line_number":937,"context_line":"  description: |"},{"line_number":938,"context_line":"    The share backup size, in GiBs."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"26778f0a_b38b9a60","line":935,"range":{"start_line":924,"start_character":0,"end_line":935,"end_character":14},"updated":"2023-08-22 01:18:02.000000000","message":"you can combine these (and call it \"backup_share_id\" as referenced in the share_backups.inc file) by using this as the description:\n\n\"The UUID of the share that the backup pertains to.\"","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":921,"context_line":"  in: body"},{"line_number":922,"context_line":"  required: true"},{"line_number":923,"context_line":"  type: string"},{"line_number":924,"context_line":"backup_share_id_request:"},{"line_number":925,"context_line":"  description: |"},{"line_number":926,"context_line":"    The UUID of the share from which to create a backup."},{"line_number":927,"context_line":"  in: body"},{"line_number":928,"context_line":"  required: true"},{"line_number":929,"context_line":"  type: string"},{"line_number":930,"context_line":"backup_share_id_response:"},{"line_number":931,"context_line":"  description: |"},{"line_number":932,"context_line":"    The UUID of the share backup during response of backup create."},{"line_number":933,"context_line":"  in: body"},{"line_number":934,"context_line":"  required: true"},{"line_number":935,"context_line":"  type: string"},{"line_number":936,"context_line":"backup_size:"},{"line_number":937,"context_line":"  description: |"},{"line_number":938,"context_line":"    The share backup size, in GiBs."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c0cee404_59942967","line":935,"range":{"start_line":924,"start_character":0,"end_line":935,"end_character":14},"in_reply_to":"26778f0a_b38b9a60","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":941,"context_line":"  type: integer"},{"line_number":942,"context_line":"backup_state:"},{"line_number":943,"context_line":"  description: |"},{"line_number":944,"context_line":"    The state of backup which can be either of \u0027creating\u0027, \u0027error\u0027,"},{"line_number":945,"context_line":"    \u0027available\u0027, \u0027restoring\u0027."},{"line_number":946,"context_line":"  in: body"},{"line_number":947,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8b237db0_d513d78a","line":944,"range":{"start_line":944,"start_character":37,"end_line":944,"end_character":43},"updated":"2023-08-22 01:18:02.000000000","message":"one","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":941,"context_line":"  type: integer"},{"line_number":942,"context_line":"backup_state:"},{"line_number":943,"context_line":"  description: |"},{"line_number":944,"context_line":"    The state of backup which can be either of \u0027creating\u0027, \u0027error\u0027,"},{"line_number":945,"context_line":"    \u0027available\u0027, \u0027restoring\u0027."},{"line_number":946,"context_line":"  in: body"},{"line_number":947,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9d133789_64486813","line":944,"range":{"start_line":944,"start_character":37,"end_line":944,"end_character":43},"in_reply_to":"8b237db0_d513d78a","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":223,"context_line":"  type: string"},{"line_number":224,"context_line":"backup_share_id_query:"},{"line_number":225,"context_line":"  description: |"},{"line_number":226,"context_line":"    The UUID of the share backup."},{"line_number":227,"context_line":"  in: query"},{"line_number":228,"context_line":"  required: false"},{"line_number":229,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6ccfde21_e804e2d9","line":226,"range":{"start_line":226,"start_character":26,"end_line":226,"end_character":33},"updated":"2023-08-22 22:55:44.000000000","message":"that the backup pertains to","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":223,"context_line":"  type: string"},{"line_number":224,"context_line":"backup_share_id_query:"},{"line_number":225,"context_line":"  description: |"},{"line_number":226,"context_line":"    The UUID of the share backup."},{"line_number":227,"context_line":"  in: query"},{"line_number":228,"context_line":"  required: false"},{"line_number":229,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d82b3795_f9036b47","line":226,"range":{"start_line":226,"start_character":26,"end_line":226,"end_character":33},"in_reply_to":"6ccfde21_e804e2d9","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":229,"context_line":"  type: string"},{"line_number":230,"context_line":"backup_status_query:"},{"line_number":231,"context_line":"  description: |"},{"line_number":232,"context_line":"    Filters by a backup status. Valid status are one of \u0027creating\u0027, \u0027error\u0027,"},{"line_number":233,"context_line":"    \u0027available\u0027, \u0027restoring\u0027."},{"line_number":234,"context_line":"  in: query"},{"line_number":235,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa81d95_2a67e2ff","line":232,"range":{"start_line":232,"start_character":32,"end_line":232,"end_character":56},"updated":"2023-08-22 22:55:44.000000000","message":"A valid filter value can be one of","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":229,"context_line":"  type: string"},{"line_number":230,"context_line":"backup_status_query:"},{"line_number":231,"context_line":"  description: |"},{"line_number":232,"context_line":"    Filters by a backup status. Valid status are one of \u0027creating\u0027, \u0027error\u0027,"},{"line_number":233,"context_line":"    \u0027available\u0027, \u0027restoring\u0027."},{"line_number":234,"context_line":"  in: query"},{"line_number":235,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5dd4da5f_8467189b","line":232,"range":{"start_line":232,"start_character":32,"end_line":232,"end_character":56},"in_reply_to":"3fa81d95_2a67e2ff","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":236,"context_line":"  type: string"},{"line_number":237,"context_line":"backup_topic_query:"},{"line_number":238,"context_line":"  description: |"},{"line_number":239,"context_line":"    Filters by a backup topic. Valid status are one of \u0027manila-data\u0027,"},{"line_number":240,"context_line":"    \u0027manila-share\u0027."},{"line_number":241,"context_line":"  in: query"},{"line_number":242,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"75183c41_be20dea4","line":239,"range":{"start_line":239,"start_character":31,"end_line":239,"end_character":55},"updated":"2023-08-22 22:55:44.000000000","message":"A valid filter value can be one of","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":236,"context_line":"  type: string"},{"line_number":237,"context_line":"backup_topic_query:"},{"line_number":238,"context_line":"  description: |"},{"line_number":239,"context_line":"    Filters by a backup topic. Valid status are one of \u0027manila-data\u0027,"},{"line_number":240,"context_line":"    \u0027manila-share\u0027."},{"line_number":241,"context_line":"  in: query"},{"line_number":242,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"502b2ef1_1cb0ac64","line":239,"range":{"start_line":239,"start_character":31,"end_line":239,"end_character":55},"in_reply_to":"75183c41_be20dea4","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":935,"context_line":"    One or more backup options key and value pairs as a"},{"line_number":936,"context_line":"    url encoded dictionary of strings."},{"line_number":937,"context_line":"  in: body"},{"line_number":938,"context_line":"  required: true"},{"line_number":939,"context_line":"  type: object"},{"line_number":940,"context_line":"backup_progress:"},{"line_number":941,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7e34d6f4_909c441c","line":938,"range":{"start_line":938,"start_character":12,"end_line":938,"end_character":16},"updated":"2023-08-22 22:55:44.000000000","message":"false\n\n\n\"backup_options\" is optional in the create API","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":935,"context_line":"    One or more backup options key and value pairs as a"},{"line_number":936,"context_line":"    url encoded dictionary of strings."},{"line_number":937,"context_line":"  in: body"},{"line_number":938,"context_line":"  required: true"},{"line_number":939,"context_line":"  type: object"},{"line_number":940,"context_line":"backup_progress:"},{"line_number":941,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2ed886a7_aae1271f","line":938,"range":{"start_line":938,"start_character":12,"end_line":938,"end_character":16},"in_reply_to":"7e34d6f4_909c441c","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":2138,"context_line":"  description: |"},{"line_number":2139,"context_line":"    The number of gigabytes for the backups allowed for each project."},{"line_number":2140,"context_line":"  in: body"},{"line_number":2141,"context_line":"  required: true"},{"line_number":2142,"context_line":"  type: integer"},{"line_number":2143,"context_line":"quota_backup_gigabytes_detail:"},{"line_number":2144,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"66b3237c_5e7cc861","line":2141,"updated":"2023-08-22 22:55:44.000000000","message":"please add:\n\n`min_version: 2.80`","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":2138,"context_line":"  description: |"},{"line_number":2139,"context_line":"    The number of gigabytes for the backups allowed for each project."},{"line_number":2140,"context_line":"  in: body"},{"line_number":2141,"context_line":"  required: true"},{"line_number":2142,"context_line":"  type: integer"},{"line_number":2143,"context_line":"quota_backup_gigabytes_detail:"},{"line_number":2144,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b525986d_906fd0fe","line":2141,"in_reply_to":"66b3237c_5e7cc861","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":2153,"context_line":"    The number of gigabytes for the backups for the"},{"line_number":2154,"context_line":"    project."},{"line_number":2155,"context_line":"  in: body"},{"line_number":2156,"context_line":"  required: false"},{"line_number":2157,"context_line":"  type: integer"},{"line_number":2158,"context_line":"quota_backups:"},{"line_number":2159,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1c6e6064_70b1c2d3","line":2156,"updated":"2023-08-22 22:55:44.000000000","message":"please add:\n\n`min_version: 2.80`","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":2153,"context_line":"    The number of gigabytes for the backups for the"},{"line_number":2154,"context_line":"    project."},{"line_number":2155,"context_line":"  in: body"},{"line_number":2156,"context_line":"  required: false"},{"line_number":2157,"context_line":"  type: integer"},{"line_number":2158,"context_line":"quota_backups:"},{"line_number":2159,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"85a09e05_ca5a4062","line":2156,"in_reply_to":"1c6e6064_70b1c2d3","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":2159,"context_line":"  description: |"},{"line_number":2160,"context_line":"    The number of backups allowed for each project."},{"line_number":2161,"context_line":"  in: body"},{"line_number":2162,"context_line":"  required: true"},{"line_number":2163,"context_line":"  type: integer"},{"line_number":2164,"context_line":"quota_backups_detail:"},{"line_number":2165,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"83ce482c_76dc7c20","line":2162,"updated":"2023-08-22 22:55:44.000000000","message":"please add:\n\n`min_version: 2.80`","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":2159,"context_line":"  description: |"},{"line_number":2160,"context_line":"    The number of backups allowed for each project."},{"line_number":2161,"context_line":"  in: body"},{"line_number":2162,"context_line":"  required: true"},{"line_number":2163,"context_line":"  type: integer"},{"line_number":2164,"context_line":"quota_backups_detail:"},{"line_number":2165,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"99bbc425_add7872c","line":2162,"in_reply_to":"83ce482c_76dc7c20","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":2173,"context_line":"  description: |"},{"line_number":2174,"context_line":"    The number of backups for the project."},{"line_number":2175,"context_line":"  in: body"},{"line_number":2176,"context_line":"  required: false"},{"line_number":2177,"context_line":"  type: integer"},{"line_number":2178,"context_line":"quota_class_id:"},{"line_number":2179,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"254b3956_17860112","line":2176,"updated":"2023-08-22 22:55:44.000000000","message":"please add:\n\n`min_version: 2.80`","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"  description: |"},{"line_number":2174,"context_line":"    The number of backups for the project."},{"line_number":2175,"context_line":"  in: body"},{"line_number":2176,"context_line":"  required: false"},{"line_number":2177,"context_line":"  type: integer"},{"line_number":2178,"context_line":"quota_class_id:"},{"line_number":2179,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8574e154_c851c1c3","line":2176,"in_reply_to":"254b3956_17860112","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":301,"context_line":"  in: query"},{"line_number":302,"context_line":"  required: false"},{"line_number":303,"context_line":"  type: string"},{"line_number":304,"context_line":"description_inexact_query:"},{"line_number":305,"context_line":"  description: |"},{"line_number":306,"context_line":"    The description pattern that can be used to filter shares,"},{"line_number":307,"context_line":"    share snapshots, share networks or share groups."},{"line_number":308,"context_line":"  in: query"},{"line_number":309,"context_line":"  required: false"},{"line_number":310,"context_line":"  type: string"},{"line_number":311,"context_line":"  min_version: 2.36"},{"line_number":312,"context_line":"description_query:"},{"line_number":313,"context_line":"  description: |"},{"line_number":314,"context_line":"    The user defined description text that can be used to filter resources."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"483bba5f_d7198a61","line":311,"range":{"start_line":304,"start_character":0,"end_line":311,"end_character":19},"updated":"2023-08-23 19:59:56.000000000","message":"similar comment as with `name_inexact_query`","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":301,"context_line":"  in: query"},{"line_number":302,"context_line":"  required: false"},{"line_number":303,"context_line":"  type: string"},{"line_number":304,"context_line":"description_inexact_query:"},{"line_number":305,"context_line":"  description: |"},{"line_number":306,"context_line":"    The description pattern that can be used to filter shares,"},{"line_number":307,"context_line":"    share snapshots, share networks or share groups."},{"line_number":308,"context_line":"  in: query"},{"line_number":309,"context_line":"  required: false"},{"line_number":310,"context_line":"  type: string"},{"line_number":311,"context_line":"  min_version: 2.36"},{"line_number":312,"context_line":"description_query:"},{"line_number":313,"context_line":"  description: |"},{"line_number":314,"context_line":"    The user defined description text that can be used to filter resources."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4843fbda_d2fae646","line":311,"range":{"start_line":304,"start_character":0,"end_line":311,"end_character":19},"in_reply_to":"483bba5f_d7198a61","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":428,"context_line":"    url encoded dictionary of strings."},{"line_number":429,"context_line":"name_inexact_query:"},{"line_number":430,"context_line":"  description: |"},{"line_number":431,"context_line":"    The name pattern that can be used to filter shares,"},{"line_number":432,"context_line":"    share snapshots, share networks, transfers or share groups."},{"line_number":433,"context_line":"  in: query"},{"line_number":434,"context_line":"  required: false"},{"line_number":435,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"489be28b_df4a345e","line":432,"range":{"start_line":431,"start_character":48,"end_line":432,"end_character":63},"updated":"2023-08-23 19:59:56.000000000","message":"could you please duplicate this option (because it is versioned) and make it generic? You can then use this new option in your api ref for correctness.. \n\n```\nname_inexact_query_versionless:\n  description: |\n    The name pattern that can be used to filter resource records with.\n  in: query\n  required: false\n  type: string\n```","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    url encoded dictionary of strings."},{"line_number":429,"context_line":"name_inexact_query:"},{"line_number":430,"context_line":"  description: |"},{"line_number":431,"context_line":"    The name pattern that can be used to filter shares,"},{"line_number":432,"context_line":"    share snapshots, share networks, transfers or share groups."},{"line_number":433,"context_line":"  in: query"},{"line_number":434,"context_line":"  required: false"},{"line_number":435,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cb713b76_9d6ad8cc","line":432,"range":{"start_line":431,"start_character":48,"end_line":432,"end_character":63},"in_reply_to":"489be28b_df4a345e","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":936,"context_line":"  description: |"},{"line_number":937,"context_line":"    The availability zone."},{"line_number":938,"context_line":"  in: body"},{"line_number":939,"context_line":"  required: false"},{"line_number":940,"context_line":"  type: string"},{"line_number":941,"context_line":"backup_id_response:"},{"line_number":942,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"929724f8_b0387c62","line":939,"range":{"start_line":939,"start_character":12,"end_line":939,"end_character":17},"updated":"2023-08-23 19:59:56.000000000","message":"true\n\nthis is in the response.. it\u0027s always present","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":936,"context_line":"  description: |"},{"line_number":937,"context_line":"    The availability zone."},{"line_number":938,"context_line":"  in: body"},{"line_number":939,"context_line":"  required: false"},{"line_number":940,"context_line":"  type: string"},{"line_number":941,"context_line":"backup_id_response:"},{"line_number":942,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4ff1eba6_3dd7910a","line":939,"range":{"start_line":939,"start_character":12,"end_line":939,"end_character":17},"in_reply_to":"929724f8_b0387c62","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"}],"api-ref/source/quota-sets.inc":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f6896e63_034ec3d7","updated":"2023-08-22 22:55:44.000000000","message":"Similar changes must also be made to \n\napi-ref/source/quota-class-sets.inc","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8aed26fe_86aa6f21","in_reply_to":"f6896e63_034ec3d7","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":94,"context_line":"Response example"},{"line_number":95,"context_line":"----------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. literalinclude:: samples/quota-show-response.json"},{"line_number":98,"context_line":"   :language: javascript"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"a386dce6_e685d754","line":97,"range":{"start_line":97,"start_character":3,"end_line":97,"end_character":52},"updated":"2023-08-22 22:55:44.000000000","message":"please modify this file and include new fields with their default values","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Response example"},{"line_number":95,"context_line":"----------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. literalinclude:: samples/quota-show-response.json"},{"line_number":98,"context_line":"   :language: javascript"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"7e7c1f8d_dff7021f","line":97,"range":{"start_line":97,"start_character":3,"end_line":97,"end_character":52},"in_reply_to":"a386dce6_e685d754","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":155,"context_line":"Response example"},{"line_number":156,"context_line":"----------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. literalinclude:: samples/quota-show-response.json"},{"line_number":159,"context_line":"   :language: javascript"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"ab45a762_43822b29","line":158,"range":{"start_line":158,"start_character":21,"end_line":158,"end_character":52},"updated":"2023-08-22 22:55:44.000000000","message":"please modify this file and include new fields with their default values","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Response example"},{"line_number":156,"context_line":"----------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. literalinclude:: samples/quota-show-response.json"},{"line_number":159,"context_line":"   :language: javascript"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"95377de9_605439d8","line":158,"range":{"start_line":158,"start_character":21,"end_line":158,"end_character":52},"in_reply_to":"ab45a762_43822b29","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":218,"context_line":"Response example"},{"line_number":219,"context_line":"----------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":".. literalinclude:: samples/quota-show-detail-response.json"},{"line_number":222,"context_line":"   :language: javascript"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Update quota set"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"7fcc56da_b827a9e0","line":222,"range":{"start_line":221,"start_character":3,"end_line":222,"end_character":24},"updated":"2023-08-22 22:55:44.000000000","message":"please modify this file and include new fields with their default values","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Response example"},{"line_number":219,"context_line":"----------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":".. literalinclude:: samples/quota-show-detail-response.json"},{"line_number":222,"context_line":"   :language: javascript"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Update quota set"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"deddddaa_e96d96e1","line":222,"range":{"start_line":221,"start_character":3,"end_line":222,"end_character":24},"in_reply_to":"7fcc56da_b827a9e0","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":299,"context_line":"Response example"},{"line_number":300,"context_line":"----------------"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":".. literalinclude:: samples/quota-update-response.json"},{"line_number":303,"context_line":"   :language: javascript"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"d14f72b2_7aca1c9d","line":302,"range":{"start_line":302,"start_character":0,"end_line":302,"end_character":54},"updated":"2023-08-22 22:55:44.000000000","message":"please modify this file and include new fields with their default values","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":299,"context_line":"Response example"},{"line_number":300,"context_line":"----------------"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":".. literalinclude:: samples/quota-update-response.json"},{"line_number":303,"context_line":"   :language: javascript"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"0a3b5298_5849bafc","line":302,"range":{"start_line":302,"start_character":0,"end_line":302,"end_character":54},"in_reply_to":"d14f72b2_7aca1c9d","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"}],"api-ref/source/share-backups.inc":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4ab2f7b8_c36045e3","updated":"2023-08-22 01:18:02.000000000","message":"you\u0027ve to add this file to the \"index.rst\" in the folder..","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1c53de8c_66388dd6","in_reply_to":"4ab2f7b8_c36045e3","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share backups (since API v2.80)"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"f09c67e1_b2a0eb62","line":1,"updated":"2023-08-22 01:18:02.000000000","message":"also, please include the new API parameters added to the \"quotas\" APIs:\n\nhttps://review.opendev.org/c/openstack/manila/+/343980/60/manila/api/views/quota_class_sets.py\nhttps://review.opendev.org/c/openstack/manila/+/343980/60/manila/api/views/quota_sets.py\n\n\nA further question: \n\nyou introduced \"source_backup_id\" as an attribute on the share object. But this isn\u0027t shown via the API... was this intentional?","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share backups (since API v2.80)"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"8c1f352b_150dc3b4","line":1,"in_reply_to":"3d8d8cd3_34a24bbe","updated":"2023-08-23 19:59:56.000000000","message":"i think so; its minor i think, but after a restore is complete, there\u0027s no other way to know what the last restore was without this information","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share backups (since API v2.80)"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"58205322_b72cdad0","line":1,"in_reply_to":"8c1f352b_150dc3b4","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share backups (since API v2.80)"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"3d8d8cd3_34a24bbe","line":1,"in_reply_to":"f09c67e1_b2a0eb62","updated":"2023-08-22 13:34:51.000000000","message":"the source_backup_id is applicable when share is created from backup. Do you want to show it similar to \"snapshot_id\" in share show command ?","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Use the Shared File Systems service to make backups of shares. A share"},{"line_number":7,"context_line":"backup is a point-in-time, read-write copy of the data that is"},{"line_number":8,"context_line":"contained in a share. The APIs below allow controlling share backups. They"},{"line_number":9,"context_line":"are represented by a \"backup\" resource in the Shared File Systems service,"},{"line_number":10,"context_line":"and they can have user-defined metadata such as a name and description."}],"source_content_type":"text/x-c++src","patch_set":5,"id":"96c6bf03_856c4eff","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":42},"updated":"2023-08-22 01:18:02.000000000","message":"read-only?","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Use the Shared File Systems service to make backups of shares. A share"},{"line_number":7,"context_line":"backup is a point-in-time, read-write copy of the data that is"},{"line_number":8,"context_line":"contained in a share. The APIs below allow controlling share backups. They"},{"line_number":9,"context_line":"are represented by a \"backup\" resource in the Shared File Systems service,"},{"line_number":10,"context_line":"and they can have user-defined metadata such as a name and description."}],"source_content_type":"text/x-c++src","patch_set":5,"id":"27fae77a_96cc7452","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":42},"in_reply_to":"96c6bf03_856c4eff","updated":"2023-08-22 13:34:51.000000000","message":"Ok changed. I was under impression that user can update backup and then restore in share. But if its invalid(not-expected) operation, I am fine with \"read-only\"","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a8f95af8cd813f9a9e22ba7d994cb07c566b9152","unresolved":true,"context_lines":[{"line_number":9,"context_line":"are represented by a \"backup\" resource in the Shared File Systems service,"},{"line_number":10,"context_line":"and they can have user-defined metadata such as a name and description."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"You can create, restore, update, and delete share backups. After you create"},{"line_number":13,"context_line":"a share backup, you can access backup and use it. You can also restore a"},{"line_number":14,"context_line":"backup into a share as long as certain criteria are met e.g. size."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"0d531293_171cca62","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"updated":"2023-08-22 01:23:25.000000000","message":"also can list backups.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":9,"context_line":"are represented by a \"backup\" resource in the Shared File Systems service,"},{"line_number":10,"context_line":"and they can have user-defined metadata such as a name and description."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"You can create, restore, update, and delete share backups. After you create"},{"line_number":13,"context_line":"a share backup, you can access backup and use it. You can also restore a"},{"line_number":14,"context_line":"backup into a share as long as certain criteria are met e.g. size."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"4df1739a_a9593e33","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"in_reply_to":"0d531293_171cca62","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":14,"context_line":"backup into a share as long as certain criteria are met e.g. size."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"You can update a share backup to change its name or description. Backup can"},{"line_number":17,"context_line":"be in either of below states:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- ``available``"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"1c527e66_2c97860d","line":17,"range":{"start_line":17,"start_character":16,"end_line":17,"end_character":21},"updated":"2023-08-22 01:18:02.000000000","message":"following","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":14,"context_line":"backup into a share as long as certain criteria are met e.g. size."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"You can update a share backup to change its name or description. Backup can"},{"line_number":17,"context_line":"be in either of below states:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- ``available``"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"871bb63c_9ecee132","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":12},"updated":"2023-08-22 01:18:02.000000000","message":"one","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":14,"context_line":"backup into a share as long as certain criteria are met e.g. size."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"You can update a share backup to change its name or description. Backup can"},{"line_number":17,"context_line":"be in either of below states:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- ``available``"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"c445dd0a_b1e8a5ce","line":17,"range":{"start_line":17,"start_character":16,"end_line":17,"end_character":21},"in_reply_to":"1c527e66_2c97860d","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":14,"context_line":"backup into a share as long as certain criteria are met e.g. size."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"You can update a share backup to change its name or description. Backup can"},{"line_number":17,"context_line":"be in either of below states:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- ``available``"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"551548bb_41e2a8fc","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":12},"in_reply_to":"871bb63c_9ecee132","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a8f95af8cd813f9a9e22ba7d994cb07c566b9152","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- ``deleting``"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- ``restoring``"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"List share backups"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"893d044d_05e0a05a","line":27,"updated":"2023-08-22 01:23:25.000000000","message":"and error_deleting\n\nwe better add share also add more status, such as\nbackup_creating, backup_restoring, backup_restoring_error","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- ``deleting``"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- ``restoring``"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"List share backups"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"190169d7_c5081a42","line":27,"in_reply_to":"893d044d_05e0a05a","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"   - share_id: backup_share_id_request"},{"line_number":55,"context_line":"   - name~: name_inexact_query"},{"line_number":56,"context_line":"   - description~: description_inexact_query"},{"line_number":57,"context_line":"   - limit: limit"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"58b9bd75_e269ec72","line":54,"range":{"start_line":54,"start_character":15,"end_line":54,"end_character":38},"updated":"2023-08-22 01:18:02.000000000","message":"this is a required `body` parameter; you\u0027ll need to create a new parameter for this attribute since it is an optional `query` paramater.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"   - share_id: backup_share_id_request"},{"line_number":55,"context_line":"   - name~: name_inexact_query"},{"line_number":56,"context_line":"   - description~: description_inexact_query"},{"line_number":57,"context_line":"   - limit: limit"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"863bb421_e0d92d50","line":54,"range":{"start_line":54,"start_character":15,"end_line":54,"end_character":38},"in_reply_to":"58b9bd75_e269ec72","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a8f95af8cd813f9a9e22ba7d994cb07c566b9152","unresolved":true,"context_lines":[{"line_number":57,"context_line":"   - limit: limit"},{"line_number":58,"context_line":"   - offset: offset"},{"line_number":59,"context_line":"   - sort_key: sort_key"},{"line_number":60,"context_line":"   - sort_dir: sort_dir"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Response parameters"},{"line_number":63,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"00509c65_c8ef8df0","line":60,"updated":"2023-08-22 01:23:25.000000000","message":"we also can filter by\n\n-status:\n-topic:\n-host:","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   - limit: limit"},{"line_number":58,"context_line":"   - offset: offset"},{"line_number":59,"context_line":"   - sort_key: sort_key"},{"line_number":60,"context_line":"   - sort_dir: sort_dir"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Response parameters"},{"line_number":63,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"031f1eab_986779b3","line":60,"in_reply_to":"00509c65_c8ef8df0","updated":"2023-08-22 13:34:51.000000000","message":"ok, added","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   - share_id: backup_share_id_request"},{"line_number":103,"context_line":"   - name~: name_inexact_query"},{"line_number":104,"context_line":"   - description~: description_inexact_query"},{"line_number":105,"context_line":"   - limit: limit"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"f917c773_049323b7","line":102,"range":{"start_line":102,"start_character":15,"end_line":102,"end_character":38},"updated":"2023-08-22 01:18:02.000000000","message":"same comment as above","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   - share_id: backup_share_id_request"},{"line_number":103,"context_line":"   - name~: name_inexact_query"},{"line_number":104,"context_line":"   - description~: description_inexact_query"},{"line_number":105,"context_line":"   - limit: limit"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"994e9b56_818ceabe","line":102,"range":{"start_line":102,"start_character":15,"end_line":102,"end_character":38},"in_reply_to":"f917c773_049323b7","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a8f95af8cd813f9a9e22ba7d994cb07c566b9152","unresolved":true,"context_lines":[{"line_number":105,"context_line":"   - limit: limit"},{"line_number":106,"context_line":"   - offset: offset"},{"line_number":107,"context_line":"   - sort_key: sort_key"},{"line_number":108,"context_line":"   - sort_dir: sort_dir"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Response parameters"},{"line_number":111,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"afda1fcc_b85a232b","line":108,"updated":"2023-08-22 01:23:25.000000000","message":"same above.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":105,"context_line":"   - limit: limit"},{"line_number":106,"context_line":"   - offset: offset"},{"line_number":107,"context_line":"   - sort_key: sort_key"},{"line_number":108,"context_line":"   - sort_dir: sort_dir"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Response parameters"},{"line_number":111,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"90af02f8_d0c0674b","line":108,"in_reply_to":"afda1fcc_b85a232b","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"You can update these attributes:"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"- ``display_name``, which also changes the ``name`` of the share"},{"line_number":255,"context_line":"  backup."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"- ``display_description``, which also changes the ``description`` of"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"8fbd3e1a_016ce530","line":254,"range":{"start_line":254,"start_character":26,"end_line":254,"end_character":31},"updated":"2023-08-22 01:18:02.000000000","message":"remove \"also\"","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"You can update these attributes:"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"- ``display_name``, which also changes the ``name`` of the share"},{"line_number":255,"context_line":"  backup."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"- ``display_description``, which also changes the ``description`` of"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"f7ce9388_84820594","line":254,"range":{"start_line":254,"start_character":26,"end_line":254,"end_character":31},"in_reply_to":"8fbd3e1a_016ce530","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":254,"context_line":"- ``display_name``, which also changes the ``name`` of the share"},{"line_number":255,"context_line":"  backup."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"- ``display_description``, which also changes the ``description`` of"},{"line_number":258,"context_line":"  the share backup."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"If you try to update other attributes, they retain their previous"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"db4a68a5_cd3944ea","line":257,"range":{"start_line":257,"start_character":33,"end_line":257,"end_character":37},"updated":"2023-08-22 01:18:02.000000000","message":"remove \"also\"","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":254,"context_line":"- ``display_name``, which also changes the ``name`` of the share"},{"line_number":255,"context_line":"  backup."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"- ``display_description``, which also changes the ``description`` of"},{"line_number":258,"context_line":"  the share backup."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"If you try to update other attributes, they retain their previous"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"3be6c61d_d3709b4f","line":257,"range":{"start_line":257,"start_character":33,"end_line":257,"end_character":37},"in_reply_to":"db4a68a5_cd3944ea","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":258,"context_line":"  the share backup."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"If you try to update other attributes, they retain their previous"},{"line_number":261,"context_line":"values."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Response codes"},{"line_number":264,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"fa310148_38727905","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":7},"updated":"2023-08-22 01:18:02.000000000","message":"Is there no error presented?","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":258,"context_line":"  the share backup."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"If you try to update other attributes, they retain their previous"},{"line_number":261,"context_line":"values."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Response codes"},{"line_number":264,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"e90df7ad_bb34a3fb","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":7},"in_reply_to":"cc7a4690_20e875ca","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":true,"context_lines":[{"line_number":258,"context_line":"  the share backup."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"If you try to update other attributes, they retain their previous"},{"line_number":261,"context_line":"values."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Response codes"},{"line_number":264,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"cc7a4690_20e875ca","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":7},"in_reply_to":"fa310148_38727905","updated":"2023-08-22 13:34:51.000000000","message":"No, update dict will contain either name/description. Rest are ignored. Snapshots has similar implementation.","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":27,"context_line":"- ``restoring``"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"While during backup create and restore operations, share can be in one of the"},{"line_number":31,"context_line":"following states:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- ``available``"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"0bbd4332_049a6e1e","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":49},"updated":"2023-08-22 22:55:44.000000000","message":"during a backup or restore operation","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- ``restoring``"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"While during backup create and restore operations, share can be in one of the"},{"line_number":31,"context_line":"following states:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- ``available``"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"d5049bad_b260bce8","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":49},"in_reply_to":"0bbd4332_049a6e1e","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":43,"context_line":"~~~~~~~~~~~~~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":".. rest_method::  GET /v2/share-backups"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Lists all share backups."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Response codes"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"b3b5e406_eacaaf90","line":46,"updated":"2023-08-22 22:55:44.000000000","message":"after each of these \".. rest_method\" annotations, please add:\n\n```\n.. versionadded:: 2.80\n```","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":43,"context_line":"~~~~~~~~~~~~~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":".. rest_method::  GET /v2/share-backups"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Lists all share backups."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Response codes"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"fe0e023d_01272edd","line":46,"in_reply_to":"b3b5e406_eacaaf90","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   - share_id: backup_share_id_query"},{"line_number":67,"context_line":"   - name~: name_inexact_query"},{"line_number":68,"context_line":"   - description~: description_inexact_query"},{"line_number":69,"context_line":"   - limit: limit"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"cfe6bdec_4e3df428","line":66,"updated":"2023-08-22 22:55:44.000000000","message":"Please verify the o/p:\n\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b62/891613/6/check/build-openstack-api-ref/b62aee4/docs/?expanded\u003dlist-share-backups-detail#id803\n\nSome things look off. \n\nthe \"name~\" and \"description~\" parameter descriptions don\u0027t mention share backups. \nthe \"limit\" parameter description says \"number of shares to return\" --- maybe just fix the description to say: \"number of resource records to return\"\nthe \"offset\" parameter description says \"The offset to define start point of share or share group listing\" - maybe fix the description to say: \"The offset to define start point of resource record listing\".\nThe \"sort_key\" pertains to shares --- maybe this can\u0027t be shared, create a new parameter with valid backup specific sort_key values called out.","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   - share_id: backup_share_id_query"},{"line_number":67,"context_line":"   - name~: name_inexact_query"},{"line_number":68,"context_line":"   - description~: description_inexact_query"},{"line_number":69,"context_line":"   - limit: limit"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"d016002a_ef29a63f","line":66,"in_reply_to":"cfe6bdec_4e3df428","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   - share_id: backup_share_id_query"},{"line_number":118,"context_line":"   - name~: name_inexact_query"},{"line_number":119,"context_line":"   - description~: description_inexact_query"},{"line_number":120,"context_line":"   - limit: limit"},{"line_number":121,"context_line":"   - offset: offset"},{"line_number":122,"context_line":"   - sort_key: sort_key"},{"line_number":123,"context_line":"   - sort_dir: sort_dir"},{"line_number":124,"context_line":"   - status: backup_status_query"},{"line_number":125,"context_line":"   - host: backup_host_query"},{"line_number":126,"context_line":"   - topic: backup_topic_query"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Response parameters"},{"line_number":129,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"0ea20348_9b9139e7","line":126,"range":{"start_line":117,"start_character":0,"end_line":126,"end_character":30},"updated":"2023-08-22 22:55:44.000000000","message":"same comment as above wrt parameter descriptions","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   - share_id: backup_share_id_query"},{"line_number":118,"context_line":"   - name~: name_inexact_query"},{"line_number":119,"context_line":"   - description~: description_inexact_query"},{"line_number":120,"context_line":"   - limit: limit"},{"line_number":121,"context_line":"   - offset: offset"},{"line_number":122,"context_line":"   - sort_key: sort_key"},{"line_number":123,"context_line":"   - sort_dir: sort_dir"},{"line_number":124,"context_line":"   - status: backup_status_query"},{"line_number":125,"context_line":"   - host: backup_host_query"},{"line_number":126,"context_line":"   - topic: backup_topic_query"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Response parameters"},{"line_number":129,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"5ccc3312_86b31b20","line":126,"range":{"start_line":117,"start_character":0,"end_line":126,"end_character":30},"in_reply_to":"0ea20348_9b9139e7","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":140,"context_line":"   - updated_at: updated_at"},{"line_number":141,"context_line":"   - progress: backup_progress"},{"line_number":142,"context_line":"   - restore_progress: backup_restore_progress"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Response example"},{"line_number":145,"context_line":"----------------"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"eab80b29_6a6e5909","line":143,"updated":"2023-08-22 22:55:44.000000000","message":"this is missing \"availability_zone\"","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":140,"context_line":"   - updated_at: updated_at"},{"line_number":141,"context_line":"   - progress: backup_progress"},{"line_number":142,"context_line":"   - restore_progress: backup_restore_progress"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Response example"},{"line_number":145,"context_line":"----------------"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"ec6afca9_fcbaa145","line":143,"in_reply_to":"eab80b29_6a6e5909","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":219,"context_line":"   - 401"},{"line_number":220,"context_line":"   - 403"},{"line_number":221,"context_line":"   - 404"},{"line_number":222,"context_line":"   - 422"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Request"},{"line_number":225,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"7a9720a5_2bae5b0e","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":8},"updated":"2023-08-22 22:55:44.000000000","message":"it\u0027s also possible to receive 409","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":219,"context_line":"   - 401"},{"line_number":220,"context_line":"   - 403"},{"line_number":221,"context_line":"   - 404"},{"line_number":222,"context_line":"   - 422"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Request"},{"line_number":225,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3fdfb8fd_460a4245","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":8},"in_reply_to":"7a9720a5_2bae5b0e","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":289,"context_line":"   - 400"},{"line_number":290,"context_line":"   - 401"},{"line_number":291,"context_line":"   - 403"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Request"},{"line_number":294,"context_line":"-------"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"b5e0843d_99fffb66","line":292,"updated":"2023-08-22 22:55:44.000000000","message":"404 is also possible","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":289,"context_line":"   - 400"},{"line_number":290,"context_line":"   - 401"},{"line_number":291,"context_line":"   - 403"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Request"},{"line_number":294,"context_line":"-------"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"be7ed7d0_d70027ea","line":292,"in_reply_to":"b5e0843d_99fffb66","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":392,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"   - backup_id: backup_id_request_path"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Response parameters"},{"line_number":397,"context_line":"-------------------"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"9c2edccc_a1e46084","line":395,"updated":"2023-08-22 22:55:44.000000000","message":"please provide a request example..","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":false,"context_lines":[{"line_number":392,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"   - backup_id: backup_id_request_path"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Response parameters"},{"line_number":397,"context_line":"-------------------"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"ad242fc8_4fdadc51","line":395,"in_reply_to":"08201407_c17cdcfd","updated":"2023-08-23 19:59:56.000000000","message":"that\u0027s not true, it _does_ have a parameter.. since the API parameter necessary is just a \"key\", maybe it doesn\u0027t need an elaborate parameter documentation.. there\u0027s however value in showing it in the required request format:\n\n```\n{\n    restore: null\n}\n\n```\n\nJust like: \nhttps://github.com/openstack/manila/blob/master/api-ref/source/samples/share-actions-restore-request.json\nhttps://github.com/openstack/manila/blob/master/api-ref/source/samples/share-replica-resync-request.json\n\nand many others..","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":392,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"   - backup_id: backup_id_request_path"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Response parameters"},{"line_number":397,"context_line":"-------------------"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"08201407_c17cdcfd","line":395,"in_reply_to":"9c2edccc_a1e46084","updated":"2023-08-23 10:53:12.000000000","message":"restore function does not have any parameter apart from backup_id itself. This is similar as that of show functions where I did not find any request example for other resource objects. So skipped it.","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":27,"context_line":"- ``restoring``"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"While during a backup or restore operation, share can be in one of the"},{"line_number":31,"context_line":"following states:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- ``available``"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"e3a45192_be6ed2e1","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":12},"updated":"2023-08-23 19:59:56.000000000","message":"During\n\n\nremove \"While\"","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- ``restoring``"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"While during a backup or restore operation, share can be in one of the"},{"line_number":31,"context_line":"following states:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- ``available``"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"ecae1a00_532418a8","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":12},"in_reply_to":"e3a45192_be6ed2e1","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":66,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   - share_id: backup_share_id_query"},{"line_number":69,"context_line":"   - name~: name_inexact_query"},{"line_number":70,"context_line":"   - description~: description_inexact_query"},{"line_number":71,"context_line":"   - limit: limit"},{"line_number":72,"context_line":"   - offset: offset"},{"line_number":73,"context_line":"   - sort_key: sort_key_backup"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"20e9a101_18531bb7","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":44},"updated":"2023-08-23 19:59:56.000000000","message":"these parameters arent fixed yet; i made a suggestion in parameters.yaml","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":66,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   - share_id: backup_share_id_query"},{"line_number":69,"context_line":"   - name~: name_inexact_query"},{"line_number":70,"context_line":"   - description~: description_inexact_query"},{"line_number":71,"context_line":"   - limit: limit"},{"line_number":72,"context_line":"   - offset: offset"},{"line_number":73,"context_line":"   - sort_key: sort_key_backup"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"e906b2ae_789b35bd","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":44},"in_reply_to":"20e9a101_18531bb7","updated":"2023-08-24 08:26:07.000000000","message":"fixed via versionless parameter.","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":119,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"   - share_id: backup_share_id_query"},{"line_number":122,"context_line":"   - name~: name_inexact_query"},{"line_number":123,"context_line":"   - description~: description_inexact_query"},{"line_number":124,"context_line":"   - limit: limit"},{"line_number":125,"context_line":"   - offset: offset"},{"line_number":126,"context_line":"   - sort_key: sort_key_backup"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"4c865a08_146ec6c7","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":44},"updated":"2023-08-23 19:59:56.000000000","message":"these parameters arent fixed yet; i made a suggestion in parameters.yaml","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":119,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"   - share_id: backup_share_id_query"},{"line_number":122,"context_line":"   - name~: name_inexact_query"},{"line_number":123,"context_line":"   - description~: description_inexact_query"},{"line_number":124,"context_line":"   - limit: limit"},{"line_number":125,"context_line":"   - offset: offset"},{"line_number":126,"context_line":"   - sort_key: sort_key_backup"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"73d3c8ea_68594a98","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":44},"in_reply_to":"4c865a08_146ec6c7","updated":"2023-08-24 08:26:07.000000000","message":"fixed via versionless parameter.","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"824b7e4dd85db155efde19f5de7ff53ca7124d9f","unresolved":true,"context_lines":[{"line_number":379,"context_line":"   - backup_id: backup_id_request_path"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"Restore of the share backup"},{"line_number":383,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":".. rest_method::  POST /v2/share-backups/{backup_id}/action"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"fe113fa5_2ee03bc7","line":382,"range":{"start_line":382,"start_character":8,"end_line":382,"end_character":27},"updated":"2023-08-23 21:55:11.000000000","message":"a share backup","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":379,"context_line":"   - backup_id: backup_id_request_path"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"Restore of the share backup"},{"line_number":383,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":".. rest_method::  POST /v2/share-backups/{backup_id}/action"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"d646963f_49bfc498","line":382,"range":{"start_line":382,"start_character":8,"end_line":382,"end_character":27},"in_reply_to":"fe113fa5_2ee03bc7","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":432,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":".. rest_method::  POST /v2/share-backups/{backup_id}/action"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"Administrator only. Explicitly updates the state of a share snapshot."},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"Use the ``policy.yaml`` file to grant permissions for this action"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"164adf45_e06e556c","line":435,"updated":"2023-08-23 19:59:56.000000000","message":"`.. version_added: 2.80`","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":432,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":".. rest_method::  POST /v2/share-backups/{backup_id}/action"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"Administrator only. Explicitly updates the state of a share snapshot."},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"Use the ``policy.yaml`` file to grant permissions for this action"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"925f5f66_bad8d3c4","line":435,"in_reply_to":"164adf45_e06e556c","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":".. rest_method::  POST /v2/share-backups/{backup_id}/action"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"Administrator only. Explicitly updates the state of a share snapshot."},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"Use the ``policy.yaml`` file to grant permissions for this action"},{"line_number":439,"context_line":"to other roles."}],"source_content_type":"text/x-c++src","patch_set":8,"id":"64a0e3d5_587c5ccf","line":436,"range":{"start_line":436,"start_character":60,"end_line":436,"end_character":68},"updated":"2023-08-23 19:59:56.000000000","message":"backup","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":".. rest_method::  POST /v2/share-backups/{backup_id}/action"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"Administrator only. Explicitly updates the state of a share snapshot."},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"Use the ``policy.yaml`` file to grant permissions for this action"},{"line_number":439,"context_line":"to other roles."}],"source_content_type":"text/x-c++src","patch_set":8,"id":"260adf35_8fe266c6","line":436,"range":{"start_line":436,"start_character":60,"end_line":436,"end_character":68},"in_reply_to":"64a0e3d5_587c5ccf","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"bacbef0941005eb884cfddb2197b2e53717dcb2b"}],"manila/api/v2/share_backups.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"73234413fa9d567a9956f2d905852a048a1b9a0c","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        for key in key_dict:"},{"line_number":72,"context_line":"            if sort_key \u003d\u003d key:"},{"line_number":73,"context_line":"                sort_key \u003d key_dict[key]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        share_id \u003d req.params.get(\u0027share_id\u0027)"},{"line_number":76,"context_line":"        if share_id:"},{"line_number":77,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"c335f38a_5b27d319","line":74,"updated":"2023-08-23 07:44:46.000000000","message":"1: we also need change search key word\n2: we also support like filter:\n\n        if \u0027name\u0027 in search_opts:\n            search_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027)\n        if \u0027description\u0027 in search_opts:\n            search_opts[\u0027display_description\u0027] \u003d search_opts.pop(\n                \u0027description\u0027)\n            \n        for key, db_key in ((\u0027name~\u0027, \u0027display_name~\u0027),\n                        (\u0027description~\u0027, \u0027display_description~\u0027)):\n        if key in search_opts:\n            search_opts[db_key] \u003d search_opts.pop(key)","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6e3846ca92ebbf58cf25b8f100b065d5b12953be","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        for key in key_dict:"},{"line_number":72,"context_line":"            if sort_key \u003d\u003d key:"},{"line_number":73,"context_line":"                sort_key \u003d key_dict[key]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        share_id \u003d req.params.get(\u0027share_id\u0027)"},{"line_number":76,"context_line":"        if share_id:"},{"line_number":77,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"066553e8_9445cf68","line":74,"in_reply_to":"c335f38a_5b27d319","updated":"2023-08-23 14:47:13.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"73234413fa9d567a9956f2d905852a048a1b9a0c","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            except exception.NotFound:"},{"line_number":81,"context_line":"                msg \u003d _(\"No share exists with ID %s.\")"},{"line_number":82,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % share_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        backups \u003d db.share_backups_get_all(context,"},{"line_number":85,"context_line":"                                           filters\u003dsearch_opts,"},{"line_number":86,"context_line":"                                           limit\u003dlimit,"}],"source_content_type":"text/x-python","patch_set":6,"id":"6a78e51a_04116b53","line":83,"updated":"2023-08-23 07:44:46.000000000","message":"only admin user can get all projects backups. Not admin can only get it\u0027s project backups.\n\n        from manila import utils   # move to top import\n        if utils.is_all_tenants(search_opts):\n            from manila import policy   # move to top import\n            allowed_to_list_all_tenants \u003d policy.check_policy(\n                context, \u0027share_backup\u0027, \u0027get_all_project\u0027,\n                do_raise\u003dFalse)\n            if not allowed_to_list_all_tenants:\n                search_opts[\u0027project_id\u0027] \u003d context.project_id\n                \nin manila/policies/share_backups.py\nwe should add:\n\n    policy.DocumentedRuleDefault(\n        name\u003dBASE_POLICY_NAME % \u0027get_all_project\u0027,\n        check_str\u003dbase.ADMIN,\n        scope_types\u003d[\u0027project\u0027],\n        description\u003d\"Get share backups of all projects.\",\n        operations\u003d[\n            {\n                \u0027method\u0027: \u0027GET\u0027,\n                \u0027path\u0027: \u0027/share-backups?all_tenants\u003d1\u0027\n            },\n            {\n                \u0027method\u0027: \u0027GET\u0027,\n                \u0027path\u0027: \u0027/share-backups/detail?all_tenants\u003d1\u0027\n            }\n        ],\n        deprecated_rule\u003ddeprecated_backup_get_all_project\n    ),","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            except exception.NotFound:"},{"line_number":81,"context_line":"                msg \u003d _(\"No share exists with ID %s.\")"},{"line_number":82,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % share_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        backups \u003d db.share_backups_get_all(context,"},{"line_number":85,"context_line":"                                           filters\u003dsearch_opts,"},{"line_number":86,"context_line":"                                           limit\u003dlimit,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d22ee72_9689a159","line":83,"in_reply_to":"11873cb9_1d67cc71","updated":"2023-08-23 19:59:56.000000000","message":"please implement a new policy as Haixin suggestion... \"context.is_admin\" is a bad anti-pattern for granular RBAC.. using it will disallow custom roles being defined in a deployment\n\n\nalso, while you\u0027re supporting \"all_tenants\", also add support for \"all_projects\":\n\n\n```\nall_tenants \u003d search_opts.pop(\u0027all_tenants\u0027, search_opts.pop(\u0027all_projects\u0027, None))\n```","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ced746900dc511c591e191f9289e33dc78125dea","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            except exception.NotFound:"},{"line_number":81,"context_line":"                msg \u003d _(\"No share exists with ID %s.\")"},{"line_number":82,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % share_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        backups \u003d db.share_backups_get_all(context,"},{"line_number":85,"context_line":"                                           filters\u003dsearch_opts,"},{"line_number":86,"context_line":"                                           limit\u003dlimit,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4af2867d_c797f869","line":83,"in_reply_to":"2d22ee72_9689a159","updated":"2023-08-24 08:26:07.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"356ab6725d71156f10336b6e141ea3fe136800e2","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            except exception.NotFound:"},{"line_number":81,"context_line":"                msg \u003d _(\"No share exists with ID %s.\")"},{"line_number":82,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % share_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        backups \u003d db.share_backups_get_all(context,"},{"line_number":85,"context_line":"                                           filters\u003dsearch_opts,"},{"line_number":86,"context_line":"                                           limit\u003dlimit,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d00c63a9_b9fe5289","line":83,"in_reply_to":"6a78e51a_04116b53","updated":"2023-08-23 08:02:52.000000000","message":"fix above code, default we only get backups by project.\nonly admin and specified all_project means get all project backups.\n\n        search_opts[\u0027project_id\u0027] \u003d context.project_id\n        from manila import utils   # move to top import\n        if utils.is_all_tenants(search_opts):\n            from manila import policy   # move to top import\n            allowed_to_list_all_tenants \u003d policy.check_policy(\n                context, \u0027share_backup\u0027, \u0027get_all_project\u0027,\n                do_raise\u003dFalse)\n            if allowed_to_list_all_tenants:\n                search_opts.pop(\u0027project_id\u0027)","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6e3846ca92ebbf58cf25b8f100b065d5b12953be","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            except exception.NotFound:"},{"line_number":81,"context_line":"                msg \u003d _(\"No share exists with ID %s.\")"},{"line_number":82,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg % share_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        backups \u003d db.share_backups_get_all(context,"},{"line_number":85,"context_line":"                                           filters\u003dsearch_opts,"},{"line_number":86,"context_line":"                                           limit\u003dlimit,"}],"source_content_type":"text/x-python","patch_set":6,"id":"11873cb9_1d67cc71","line":83,"in_reply_to":"d00c63a9_b9fe5289","updated":"2023-08-23 14:47:13.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d6eed6e65970d125884f6351dfb3a340e8411d34","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        backup \u003d self.share_api.update_share_backup(context, backup,"},{"line_number":217,"context_line":"                                                    update_dict)"},{"line_number":218,"context_line":"        return self._view_builder.detail(req, backup)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"def create_resource():"},{"line_number":222,"context_line":"    return wsgi.Resource(ShareBackupController())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f976439_748889eb","line":219,"updated":"2023-08-23 06:34:32.000000000","message":"just like snapshot_reset_status.here we can add new function:\n\n    @wsgi.Controller.api_version(MIN_SUPPORTED_API_VERSION, experimental\u003dTrue)\n    @wsgi.action(\u0027reset_status\u0027)\n    def backup_reset_status(self, req, id, body):\n        return self._reset_status(req, id, body)\n        \nand manila client also need add reset status command line.","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        backup \u003d self.share_api.update_share_backup(context, backup,"},{"line_number":217,"context_line":"                                                    update_dict)"},{"line_number":218,"context_line":"        return self._view_builder.detail(req, backup)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"def create_resource():"},{"line_number":222,"context_line":"    return wsgi.Resource(ShareBackupController())"}],"source_content_type":"text/x-python","patch_set":6,"id":"f3255c4d_11637e76","line":219,"in_reply_to":"9f976439_748889eb","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0e35681247d3ac600c3243ef8c277f1c4d6adf7","unresolved":true,"context_lines":[{"line_number":249,"context_line":"        return self._view_builder.detail(req, backup)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @wsgi.Controller.api_version(MIN_SUPPORTED_API_VERSION, experimental\u003dTrue)"},{"line_number":252,"context_line":"    @wsgi.Controller.authorize"},{"line_number":253,"context_line":"    @wsgi.action(\u0027reset_status\u0027)"},{"line_number":254,"context_line":"    def backup_reset_status(self, req, id, body):"},{"line_number":255,"context_line":"        return self._reset_status(req, id, body)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bd92de6f_c79f798f","line":252,"range":{"start_line":252,"start_character":4,"end_line":252,"end_character":30},"updated":"2023-08-24 09:07:25.000000000","message":"we don\u0027t need check policy here,\nin manila/api/openstack/wsgi.py line1239 will check admin policyl.","commit_id":"486455e14e583b44dc35d973c509270f95b3c352"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e30a4b1c5b3c068d4477635a68642950be349734","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        return self._view_builder.detail(req, backup)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @wsgi.Controller.api_version(MIN_SUPPORTED_API_VERSION, experimental\u003dTrue)"},{"line_number":252,"context_line":"    @wsgi.Controller.authorize"},{"line_number":253,"context_line":"    @wsgi.action(\u0027reset_status\u0027)"},{"line_number":254,"context_line":"    def backup_reset_status(self, req, id, body):"},{"line_number":255,"context_line":"        return self._reset_status(req, id, body)"}],"source_content_type":"text/x-python","patch_set":9,"id":"09628d1f_75157aec","line":252,"range":{"start_line":252,"start_character":4,"end_line":252,"end_character":30},"in_reply_to":"bd92de6f_c79f798f","updated":"2023-08-24 12:04:34.000000000","message":"Done","commit_id":"486455e14e583b44dc35d973c509270f95b3c352"}],"manila/api/views/share_backups.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa253fb6e48d691387ebe2e41fd03ceae9b3f438","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \u0027created_at\u0027: backup.get(\u0027created_at\u0027),"},{"line_number":64,"context_line":"            \u0027availability_zone\u0027: backup.get(\u0027availability_zone\u0027),"},{"line_number":65,"context_line":"            \u0027progress\u0027: backup.get(\u0027progress\u0027),"},{"line_number":66,"context_line":"            \u0027restore_progress\u0027: backup.get(\u0027restore_progress\u0027),"},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if policy.check_is_host_admin(context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"2afdd76e_7a061195","line":66,"range":{"start_line":66,"start_character":62,"end_line":66,"end_character":63},"updated":"2023-08-16 17:15:15.000000000","message":"why are we dropping \"updated_at\"?","commit_id":"55f571bcf23023d6e073fe2c767a6a32e9445e36"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"755751edc95a8af4f183c09e945ea4d19b1fa6f7","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \u0027created_at\u0027: backup.get(\u0027created_at\u0027),"},{"line_number":64,"context_line":"            \u0027availability_zone\u0027: backup.get(\u0027availability_zone\u0027),"},{"line_number":65,"context_line":"            \u0027progress\u0027: backup.get(\u0027progress\u0027),"},{"line_number":66,"context_line":"            \u0027restore_progress\u0027: backup.get(\u0027restore_progress\u0027),"},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if policy.check_is_host_admin(context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5911671_afdee971","line":66,"range":{"start_line":66,"start_character":62,"end_line":66,"end_character":63},"in_reply_to":"2afdd76e_7a061195","updated":"2023-08-17 15:01:27.000000000","message":"Once backup is created, updated_at will mostly be useful if backup name/description updated or it will be restored in share. So I thought updated_at is not much meaningful. If you think otherwise, let me know. I will add it back.","commit_id":"55f571bcf23023d6e073fe2c767a6a32e9445e36"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d3c6a7ac82d3f6ac6844f1e29c2e019853f3373a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027created_at\u0027: backup.get(\u0027created_at\u0027),"},{"line_number":64,"context_line":"            \u0027availability_zone\u0027: backup.get(\u0027availability_zone\u0027),"},{"line_number":65,"context_line":"            \u0027progress\u0027: backup.get(\u0027progress\u0027),"},{"line_number":66,"context_line":"            \u0027restore_progress\u0027: backup.get(\u0027restore_progress\u0027),"},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if policy.check_is_host_admin(context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"42723f2b_6e89e091","line":66,"range":{"start_line":66,"start_character":62,"end_line":66,"end_character":63},"in_reply_to":"54daeddf_85f2ab51","updated":"2023-08-18 10:58:18.000000000","message":"Done","commit_id":"55f571bcf23023d6e073fe2c767a6a32e9445e36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f15188502c2a448e2de3e74af07291ee083c3c9","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            \u0027created_at\u0027: backup.get(\u0027created_at\u0027),"},{"line_number":64,"context_line":"            \u0027availability_zone\u0027: backup.get(\u0027availability_zone\u0027),"},{"line_number":65,"context_line":"            \u0027progress\u0027: backup.get(\u0027progress\u0027),"},{"line_number":66,"context_line":"            \u0027restore_progress\u0027: backup.get(\u0027restore_progress\u0027),"},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if policy.check_is_host_admin(context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"54daeddf_85f2ab51","line":66,"range":{"start_line":66,"start_character":62,"end_line":66,"end_character":63},"in_reply_to":"d5911671_afdee971","updated":"2023-08-17 17:02:14.000000000","message":"besides the name/description; this signifies other significant updates: \n\nyou\u0027ll know:\n\n- when the backup transitioned to a particular status \n- when the \"progress\"/\"restore_progress\" fields were last updated\n\ni think its pretty important information","commit_id":"55f571bcf23023d6e073fe2c767a6a32e9445e36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02403ab805acefc29ed1bda655820717350ae7c9","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        backup_dict \u003d {"},{"line_number":57,"context_line":"            \u0027id\u0027: backup.get(\u0027id\u0027),"},{"line_number":58,"context_line":"            \u0027share_id\u0027: backup.get(\u0027share_id\u0027),"},{"line_number":59,"context_line":"            \u0027backup_state\u0027: backup.get(\u0027status\u0027),"},{"line_number":60,"context_line":"            \u0027name\u0027: backup.get(\u0027display_name\u0027),"},{"line_number":61,"context_line":"            \u0027description\u0027: backup.get(\u0027display_description\u0027),"},{"line_number":62,"context_line":"            \u0027size\u0027: backup.get(\u0027size\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"8b5b472d_d3792899","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":25},"updated":"2023-08-22 01:18:02.000000000","message":"please call this field \"status\" -- since it is a common attribute to backup and restore operations..","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        backup_dict \u003d {"},{"line_number":57,"context_line":"            \u0027id\u0027: backup.get(\u0027id\u0027),"},{"line_number":58,"context_line":"            \u0027share_id\u0027: backup.get(\u0027share_id\u0027),"},{"line_number":59,"context_line":"            \u0027backup_state\u0027: backup.get(\u0027status\u0027),"},{"line_number":60,"context_line":"            \u0027name\u0027: backup.get(\u0027display_name\u0027),"},{"line_number":61,"context_line":"            \u0027description\u0027: backup.get(\u0027display_description\u0027),"},{"line_number":62,"context_line":"            \u0027size\u0027: backup.get(\u0027size\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"f6e8e505_1823e308","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":25},"in_reply_to":"8b5b472d_d3792899","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"}],"manila/api/views/shares.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0e35681247d3ac600c3243ef8c277f1c4d6adf7","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        share_dict[\u0027scheduled_to_be_deleted_at\u0027] \u003d share.get("},{"line_number":208,"context_line":"            \u0027scheduled_to_be_deleted_at\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @common.ViewBuilder.versioned_method(\"2.69\")"},{"line_number":211,"context_line":"    def add_source_backup_id_field(self, context, share_dict, share):"},{"line_number":212,"context_line":"        share_dict[\u0027source_backup_id\u0027] \u003d share.get(\u0027source_backup_id\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4949e854_3d98cab3","line":210,"range":{"start_line":210,"start_character":42,"end_line":210,"end_character":46},"updated":"2023-08-24 09:07:25.000000000","message":"maybe 2.80","commit_id":"486455e14e583b44dc35d973c509270f95b3c352"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e30a4b1c5b3c068d4477635a68642950be349734","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        share_dict[\u0027scheduled_to_be_deleted_at\u0027] \u003d share.get("},{"line_number":208,"context_line":"            \u0027scheduled_to_be_deleted_at\u0027)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @common.ViewBuilder.versioned_method(\"2.69\")"},{"line_number":211,"context_line":"    def add_source_backup_id_field(self, context, share_dict, share):"},{"line_number":212,"context_line":"        share_dict[\u0027source_backup_id\u0027] \u003d share.get(\u0027source_backup_id\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"e7bfcfbf_720cf30e","line":210,"range":{"start_line":210,"start_character":42,"end_line":210,"end_character":46},"in_reply_to":"4949e854_3d98cab3","updated":"2023-08-24 12:04:34.000000000","message":"Done","commit_id":"486455e14e583b44dc35d973c509270f95b3c352"}],"manila/data/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04b1fbf583e780ebbcbdd81fb7833f9d4a39a569","unresolved":true,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        try:"},{"line_number":404,"context_line":"            self._run_backup(context, backup, share)"},{"line_number":405,"context_line":"            self.db.share_update("},{"line_number":406,"context_line":"                context, share_id,"},{"line_number":407,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":408,"context_line":"            self.db.share_backup_update("},{"line_number":409,"context_line":"                context, backup_id,"},{"line_number":410,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE, \u0027progress\u0027: \u0027100\u0027})"},{"line_number":411,"context_line":"            LOG.info(\"Created share backup %s successfully.\", backup_id)"},{"line_number":412,"context_line":"        except Exception as err:"},{"line_number":413,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":414,"context_line":"                LOG.error(\"Failed to create share backup %s by data driver.\","}],"source_content_type":"text/x-python","patch_set":5,"id":"a7ae8983_5500b1b3","line":411,"range":{"start_line":405,"start_character":12,"end_line":411,"end_character":72},"updated":"2023-08-22 03:22:57.000000000","message":"i see why you\u0027re doing this; could you please move this outside of the try..except?","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        try:"},{"line_number":404,"context_line":"            self._run_backup(context, backup, share)"},{"line_number":405,"context_line":"            self.db.share_update("},{"line_number":406,"context_line":"                context, share_id,"},{"line_number":407,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":408,"context_line":"            self.db.share_backup_update("},{"line_number":409,"context_line":"                context, backup_id,"},{"line_number":410,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE, \u0027progress\u0027: \u0027100\u0027})"},{"line_number":411,"context_line":"            LOG.info(\"Created share backup %s successfully.\", backup_id)"},{"line_number":412,"context_line":"        except Exception as err:"},{"line_number":413,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":414,"context_line":"                LOG.error(\"Failed to create share backup %s by data driver.\","}],"source_content_type":"text/x-python","patch_set":5,"id":"4a9e0650_8c0e4475","line":411,"range":{"start_line":405,"start_character":12,"end_line":411,"end_character":72},"in_reply_to":"a7ae8983_5500b1b3","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04b1fbf583e780ebbcbdd81fb7833f9d4a39a569","unresolved":true,"context_lines":[{"line_number":437,"context_line":"            try:"},{"line_number":438,"context_line":"                result \u003d self.data_copy_get_progress(context, share_id)"},{"line_number":439,"context_line":"                progress \u003d result.get(\u0027total_progress\u0027, \u00270\u0027)"},{"line_number":440,"context_line":"                self.db.share_backup_update(context, backup_id,"},{"line_number":441,"context_line":"                                            {\u0027progress\u0027: progress})"},{"line_number":442,"context_line":"                if progress \u003d\u003d \u0027100\u0027:"},{"line_number":443,"context_line":"                    self.db.share_update("},{"line_number":444,"context_line":"                        context, share_id,"},{"line_number":445,"context_line":"                        {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":446,"context_line":"                    self.db.share_backup_update("},{"line_number":447,"context_line":"                        context, backup_id,"},{"line_number":448,"context_line":"                        {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":449,"context_line":"                    LOG.info(\"Created share backup %s successfully.\","},{"line_number":450,"context_line":"                             backup_id)"},{"line_number":451,"context_line":"            except Exception:"},{"line_number":452,"context_line":"                LOG.warning(\"Failed to get progress of share %(share)s \""},{"line_number":453,"context_line":"                            \"backing up in share_backup %(backup).\","}],"source_content_type":"text/x-python","patch_set":5,"id":"ab74fd6b_24bfd441","line":450,"range":{"start_line":440,"start_character":16,"end_line":450,"end_character":39},"updated":"2023-08-22 03:22:57.000000000","message":"you can make the self.db.share_backup_update call just once if you reworked this code","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            try:"},{"line_number":438,"context_line":"                result \u003d self.data_copy_get_progress(context, share_id)"},{"line_number":439,"context_line":"                progress \u003d result.get(\u0027total_progress\u0027, \u00270\u0027)"},{"line_number":440,"context_line":"                self.db.share_backup_update(context, backup_id,"},{"line_number":441,"context_line":"                                            {\u0027progress\u0027: progress})"},{"line_number":442,"context_line":"                if progress \u003d\u003d \u0027100\u0027:"},{"line_number":443,"context_line":"                    self.db.share_update("},{"line_number":444,"context_line":"                        context, share_id,"},{"line_number":445,"context_line":"                        {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":446,"context_line":"                    self.db.share_backup_update("},{"line_number":447,"context_line":"                        context, backup_id,"},{"line_number":448,"context_line":"                        {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":449,"context_line":"                    LOG.info(\"Created share backup %s successfully.\","},{"line_number":450,"context_line":"                             backup_id)"},{"line_number":451,"context_line":"            except Exception:"},{"line_number":452,"context_line":"                LOG.warning(\"Failed to get progress of share %(share)s \""},{"line_number":453,"context_line":"                            \"backing up in share_backup %(backup).\","}],"source_content_type":"text/x-python","patch_set":5,"id":"87fa09a0_fb7b1319","line":450,"range":{"start_line":440,"start_character":16,"end_line":450,"end_character":39},"in_reply_to":"ab74fd6b_24bfd441","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04b1fbf583e780ebbcbdd81fb7833f9d4a39a569","unresolved":true,"context_lines":[{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        try:"},{"line_number":627,"context_line":"            self._run_restore(context, backup, share)"},{"line_number":628,"context_line":"            self.db.share_update("},{"line_number":629,"context_line":"                context, share_id,"},{"line_number":630,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":631,"context_line":"            self.db.share_backup_update("},{"line_number":632,"context_line":"                context, backup_id,"},{"line_number":633,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":634,"context_line":"                 \u0027restore_progress\u0027: \u0027100\u0027})"},{"line_number":635,"context_line":"            LOG.info(\"Share backup %s restored successfully.\", backup_id)"},{"line_number":636,"context_line":"        except Exception:"},{"line_number":637,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":638,"context_line":"                LOG.error(\"Failed to restore backup %(backup)s to share \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dff3401e_756ef7d2","line":635,"range":{"start_line":628,"start_character":0,"end_line":635,"end_character":73},"updated":"2023-08-22 03:22:57.000000000","message":"same comment as above","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        try:"},{"line_number":627,"context_line":"            self._run_restore(context, backup, share)"},{"line_number":628,"context_line":"            self.db.share_update("},{"line_number":629,"context_line":"                context, share_id,"},{"line_number":630,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":631,"context_line":"            self.db.share_backup_update("},{"line_number":632,"context_line":"                context, backup_id,"},{"line_number":633,"context_line":"                {\u0027status\u0027: constants.STATUS_AVAILABLE,"},{"line_number":634,"context_line":"                 \u0027restore_progress\u0027: \u0027100\u0027})"},{"line_number":635,"context_line":"            LOG.info(\"Share backup %s restored successfully.\", backup_id)"},{"line_number":636,"context_line":"        except Exception:"},{"line_number":637,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":638,"context_line":"                LOG.error(\"Failed to restore backup %(backup)s to share \""}],"source_content_type":"text/x-python","patch_set":5,"id":"aef7e9a6_5a16c487","line":635,"range":{"start_line":628,"start_character":0,"end_line":635,"end_character":73},"in_reply_to":"dff3401e_756ef7d2","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04b1fbf583e780ebbcbdd81fb7833f9d4a39a569","unresolved":true,"context_lines":[{"line_number":674,"context_line":"                try:"},{"line_number":675,"context_line":"                    result \u003d self.data_copy_get_progress(context, share_id)"},{"line_number":676,"context_line":"                    progress \u003d result.get(\u0027total_progress\u0027, \u00270\u0027)"},{"line_number":677,"context_line":"                    self.db.share_backup_update(context, backup_id,"},{"line_number":678,"context_line":"                                                {\u0027restore_progress\u0027: progress})"},{"line_number":679,"context_line":"                    if progress \u003d\u003d \u0027100\u0027:"},{"line_number":680,"context_line":"                        self.db.share_update("},{"line_number":681,"context_line":"                            context, share_id,"},{"line_number":682,"context_line":"                            {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":683,"context_line":"                        self.db.share_backup_update("},{"line_number":684,"context_line":"                            context, backup_id,"},{"line_number":685,"context_line":"                            {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":686,"context_line":"                        LOG.info(\"Share backup %s restored successfully.\","},{"line_number":687,"context_line":"                                 backup_id)"},{"line_number":688,"context_line":"                except Exception:"},{"line_number":689,"context_line":"                    LOG.exception(\"Failed to get progress of share_backup \""},{"line_number":690,"context_line":"                                  \"%(backup)s restoring in share %(share).\","}],"source_content_type":"text/x-python","patch_set":5,"id":"228186e8_f438271f","line":687,"range":{"start_line":677,"start_character":19,"end_line":687,"end_character":43},"updated":"2023-08-22 03:22:57.000000000","message":"you can make the self.db.share_backup_update call just once if you reworked this code","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                try:"},{"line_number":675,"context_line":"                    result \u003d self.data_copy_get_progress(context, share_id)"},{"line_number":676,"context_line":"                    progress \u003d result.get(\u0027total_progress\u0027, \u00270\u0027)"},{"line_number":677,"context_line":"                    self.db.share_backup_update(context, backup_id,"},{"line_number":678,"context_line":"                                                {\u0027restore_progress\u0027: progress})"},{"line_number":679,"context_line":"                    if progress \u003d\u003d \u0027100\u0027:"},{"line_number":680,"context_line":"                        self.db.share_update("},{"line_number":681,"context_line":"                            context, share_id,"},{"line_number":682,"context_line":"                            {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":683,"context_line":"                        self.db.share_backup_update("},{"line_number":684,"context_line":"                            context, backup_id,"},{"line_number":685,"context_line":"                            {\u0027status\u0027: constants.STATUS_AVAILABLE})"},{"line_number":686,"context_line":"                        LOG.info(\"Share backup %s restored successfully.\","},{"line_number":687,"context_line":"                                 backup_id)"},{"line_number":688,"context_line":"                except Exception:"},{"line_number":689,"context_line":"                    LOG.exception(\"Failed to get progress of share_backup \""},{"line_number":690,"context_line":"                                  \"%(backup)s restoring in share %(share).\","}],"source_content_type":"text/x-python","patch_set":5,"id":"41dac0fe_6de1d1c3","line":687,"range":{"start_line":677,"start_character":19,"end_line":687,"end_character":43},"in_reply_to":"228186e8_f438271f","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04b1fbf583e780ebbcbdd81fb7833f9d4a39a569","unresolved":true,"context_lines":[{"line_number":3843,"context_line":"        else:"},{"line_number":3844,"context_line":"            topic \u003d CONF.data_topic"},{"line_number":3845,"context_line":""},{"line_number":3846,"context_line":"        self.db.share_backup_update("},{"line_number":3847,"context_line":"            context, backup_ref[\u0027id\u0027], {\u0027topic\u0027: topic})"},{"line_number":3848,"context_line":""},{"line_number":3849,"context_line":"        if topic \u003d\u003d CONF.share_topic:"},{"line_number":3850,"context_line":"            backup_ref[\u0027host\u0027] \u003d share[\u0027host\u0027]"},{"line_number":3851,"context_line":"            self.db.share_backup_update("},{"line_number":3852,"context_line":"                context, backup_ref[\u0027id\u0027], {\u0027host\u0027: backup_ref[\u0027host\u0027]})"},{"line_number":3853,"context_line":"            self.share_rpcapi.create_backup(context, backup_ref)"},{"line_number":3854,"context_line":"        elif topic \u003d\u003d CONF.data_topic:"},{"line_number":3855,"context_line":"            data_rpc \u003d data_rpcapi.DataAPI()"},{"line_number":3856,"context_line":"            data_rpc.create_backup(context, backup_ref)"}],"source_content_type":"text/x-python","patch_set":5,"id":"372140e5_446345b6","line":3853,"range":{"start_line":3846,"start_character":8,"end_line":3853,"end_character":64},"updated":"2023-08-22 03:22:57.000000000","message":"please rework this code so that you call self.db.share_backup_update just once","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":3843,"context_line":"        else:"},{"line_number":3844,"context_line":"            topic \u003d CONF.data_topic"},{"line_number":3845,"context_line":""},{"line_number":3846,"context_line":"        self.db.share_backup_update("},{"line_number":3847,"context_line":"            context, backup_ref[\u0027id\u0027], {\u0027topic\u0027: topic})"},{"line_number":3848,"context_line":""},{"line_number":3849,"context_line":"        if topic \u003d\u003d CONF.share_topic:"},{"line_number":3850,"context_line":"            backup_ref[\u0027host\u0027] \u003d share[\u0027host\u0027]"},{"line_number":3851,"context_line":"            self.db.share_backup_update("},{"line_number":3852,"context_line":"                context, backup_ref[\u0027id\u0027], {\u0027host\u0027: backup_ref[\u0027host\u0027]})"},{"line_number":3853,"context_line":"            self.share_rpcapi.create_backup(context, backup_ref)"},{"line_number":3854,"context_line":"        elif topic \u003d\u003d CONF.data_topic:"},{"line_number":3855,"context_line":"            data_rpc \u003d data_rpcapi.DataAPI()"},{"line_number":3856,"context_line":"            data_rpc.create_backup(context, backup_ref)"}],"source_content_type":"text/x-python","patch_set":5,"id":"4a31d5ec_e831e1fe","line":3853,"range":{"start_line":3846,"start_character":8,"end_line":3853,"end_character":64},"in_reply_to":"372140e5_446345b6","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f6f1aa40dc1f5e009cd47ab240f617fd9893f79","unresolved":true,"context_lines":[{"line_number":3815,"context_line":"                        allowed\u003dquotas[over])"},{"line_number":3816,"context_line":""},{"line_number":3817,"context_line":"        try:"},{"line_number":3818,"context_line":"            backup_ref \u003d self.db.share_backup_create("},{"line_number":3819,"context_line":"                context, share[\u0027id\u0027],"},{"line_number":3820,"context_line":"                {"},{"line_number":3821,"context_line":"                    \u0027user_id\u0027: context.user_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"49b1736c_d59e217d","line":3818,"range":{"start_line":3818,"start_character":0,"end_line":3818,"end_character":53},"updated":"2023-08-22 22:55:44.000000000","message":"please define backup_ref \u003d {} outside this try block","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":3815,"context_line":"                        allowed\u003dquotas[over])"},{"line_number":3816,"context_line":""},{"line_number":3817,"context_line":"        try:"},{"line_number":3818,"context_line":"            backup_ref \u003d self.db.share_backup_create("},{"line_number":3819,"context_line":"                context, share[\u0027id\u0027],"},{"line_number":3820,"context_line":"                {"},{"line_number":3821,"context_line":"                    \u0027user_id\u0027: context.user_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d647d34f_0ba9731a","line":3818,"range":{"start_line":3818,"start_character":0,"end_line":3818,"end_character":53},"in_reply_to":"49b1736c_d59e217d","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0aa88d1f3f2b72b313c176da034310f4f943f052","unresolved":true,"context_lines":[{"line_number":3865,"context_line":"        :raises: BackupDriverException"},{"line_number":3866,"context_line":"        :raises: ServiceNotFound"},{"line_number":3867,"context_line":"        \"\"\""},{"line_number":3868,"context_line":"        if backup.status not in [constants.STATUS_AVAILABLE,"},{"line_number":3869,"context_line":"                                 constants.STATUS_ERROR]:"},{"line_number":3870,"context_line":"            msg \u003d (_(\u0027Backup %s status must be available or error.\u0027)"},{"line_number":3871,"context_line":"                   % backup[\u0027id\u0027])"},{"line_number":3872,"context_line":"            raise exception.InvalidBackup(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1425f3c3_00205971","line":3869,"range":{"start_line":3868,"start_character":8,"end_line":3869,"end_character":57},"updated":"2023-08-23 03:30:48.000000000","message":"I find that if the state of backup changes to error_deleting after the first deletion failure, the user cannot reset the state of backup through backup set or delete the backup again.\n\n\n\nPossible solutions:\n\n1: openstack share backup set supports resetting the backup status (only administrators can do this).\n\n2: Alternatively, backup deletion supports the error_deleting state","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"cb7e18d62b3e629fe2efc320ecb0856f370b9e35","unresolved":true,"context_lines":[{"line_number":3865,"context_line":"        :raises: BackupDriverException"},{"line_number":3866,"context_line":"        :raises: ServiceNotFound"},{"line_number":3867,"context_line":"        \"\"\""},{"line_number":3868,"context_line":"        if backup.status not in [constants.STATUS_AVAILABLE,"},{"line_number":3869,"context_line":"                                 constants.STATUS_ERROR]:"},{"line_number":3870,"context_line":"            msg \u003d (_(\u0027Backup %s status must be available or error.\u0027)"},{"line_number":3871,"context_line":"                   % backup[\u0027id\u0027])"},{"line_number":3872,"context_line":"            raise exception.InvalidBackup(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bb17b1bf_2a687f32","line":3869,"range":{"start_line":3868,"start_character":8,"end_line":3869,"end_character":57},"in_reply_to":"1425f3c3_00205971","updated":"2023-08-23 03:40:56.000000000","message":"Also, if the state of backup is stuck in creating, how do we delete it? It seems necessary to reset the status.","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05ec29b0449614c4d4850b6ac6467b25fa8e954","unresolved":false,"context_lines":[{"line_number":3865,"context_line":"        :raises: BackupDriverException"},{"line_number":3866,"context_line":"        :raises: ServiceNotFound"},{"line_number":3867,"context_line":"        \"\"\""},{"line_number":3868,"context_line":"        if backup.status not in [constants.STATUS_AVAILABLE,"},{"line_number":3869,"context_line":"                                 constants.STATUS_ERROR]:"},{"line_number":3870,"context_line":"            msg \u003d (_(\u0027Backup %s status must be available or error.\u0027)"},{"line_number":3871,"context_line":"                   % backup[\u0027id\u0027])"},{"line_number":3872,"context_line":"            raise exception.InvalidBackup(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"cb698738_0eb1995e","line":3869,"range":{"start_line":3868,"start_character":8,"end_line":3869,"end_character":57},"in_reply_to":"78f6fae2_4837a4a5","updated":"2023-08-23 19:59:56.000000000","message":"great catch haixin, and thanks for addressing this Kiran!","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9ffdb66b0b9413f30a593912248d02a7dd782214","unresolved":false,"context_lines":[{"line_number":3865,"context_line":"        :raises: BackupDriverException"},{"line_number":3866,"context_line":"        :raises: ServiceNotFound"},{"line_number":3867,"context_line":"        \"\"\""},{"line_number":3868,"context_line":"        if backup.status not in [constants.STATUS_AVAILABLE,"},{"line_number":3869,"context_line":"                                 constants.STATUS_ERROR]:"},{"line_number":3870,"context_line":"            msg \u003d (_(\u0027Backup %s status must be available or error.\u0027)"},{"line_number":3871,"context_line":"                   % backup[\u0027id\u0027])"},{"line_number":3872,"context_line":"            raise exception.InvalidBackup(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"78f6fae2_4837a4a5","line":3869,"range":{"start_line":3868,"start_character":8,"end_line":3869,"end_character":57},"in_reply_to":"bb17b1bf_2a687f32","updated":"2023-08-23 10:53:12.000000000","message":"Done","commit_id":"75492c86c46882ae7a80521ec43dfcb9df0f082c"}],"manila/tests/share/test_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04b1fbf583e780ebbcbdd81fb7833f9d4a39a569","unresolved":true,"context_lines":[{"line_number":7077,"context_line":"        quota.QUOTAS.reserve.assert_called_once()"},{"line_number":7078,"context_line":"        db_api.share_backup_create.assert_called_once()"},{"line_number":7079,"context_line":"        quota.QUOTAS.commit.assert_called_once()"},{"line_number":7080,"context_line":"        db_api.share_backup_update.assert_called()"},{"line_number":7081,"context_line":"        if backup_opts:"},{"line_number":7082,"context_line":"            self.share_rpcapi.create_backup.assert_called_once_with("},{"line_number":7083,"context_line":"                self.context, backup_ref)"}],"source_content_type":"text/x-python","patch_set":5,"id":"37f02226_f0a34636","line":7080,"range":{"start_line":7080,"start_character":35,"end_line":7080,"end_character":50},"updated":"2023-08-22 03:22:57.000000000","message":"please revert once you rework the code in share/api.py","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35b62216f8f4da0a5658f782736344c729fc4998","unresolved":false,"context_lines":[{"line_number":7077,"context_line":"        quota.QUOTAS.reserve.assert_called_once()"},{"line_number":7078,"context_line":"        db_api.share_backup_create.assert_called_once()"},{"line_number":7079,"context_line":"        quota.QUOTAS.commit.assert_called_once()"},{"line_number":7080,"context_line":"        db_api.share_backup_update.assert_called()"},{"line_number":7081,"context_line":"        if backup_opts:"},{"line_number":7082,"context_line":"            self.share_rpcapi.create_backup.assert_called_once_with("},{"line_number":7083,"context_line":"                self.context, backup_ref)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ad286166_e08bc2cf","line":7080,"range":{"start_line":7080,"start_character":35,"end_line":7080,"end_character":50},"in_reply_to":"37f02226_f0a34636","updated":"2023-08-22 13:34:51.000000000","message":"Done","commit_id":"a44c31ae54180601c585a4ab323483fa2e4b1226"}]}