)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f787b04332f9e97d59e0d678232b64449e42c9bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32a9e26e_af835c51","updated":"2023-09-22 19:55:29.000000000","message":"LGTM; thanks Carlos. I think not throwing utf-8 in the tables where we don\u0027t need it is a good decision; although we\u0027d ensure via oslo.db that we\u0027d use \u0027utf-8\u0027 (3-byte) connections from the service... not specifying one during creation time leaves this at the mercy of the default configuration... we should me mindful about this in the future.","commit_id":"b44c36e5ba43aa8c07d0aa68b90a2cf9e130ecc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d3cf0ee071ed56382521d22ba28cebf9470b675b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7d573de1_7d03a50f","updated":"2023-09-21 19:32:57.000000000","message":"Thanks for the review, Saravanan! Attempted applying the utf8mb4 thing - our CI jobs didn\u0027t quite like that. Goutham found a nice explanation [1]\n\n[1] https://opendev.org/openstack/ironic/commit/1435a15ce3013da0a3138e1c5ab6ac523c382bb8","commit_id":"b44c36e5ba43aa8c07d0aa68b90a2cf9e130ecc7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"34d28e2e7df7c5914ecac59aa69f80d5617f42af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6d341a21_04381e08","updated":"2023-09-22 15:41:57.000000000","message":"This should fix up the CI issues I\u0027ve seen on some patches nicely. Thanks Carlos","commit_id":"b44c36e5ba43aa8c07d0aa68b90a2cf9e130ecc7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f7e650aca44d8dc03ee1422d2c8047de1399a9bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8a463329_29a010be","updated":"2023-09-27 03:55:10.000000000","message":"thanks, lgtm","commit_id":"b44c36e5ba43aa8c07d0aa68b90a2cf9e130ecc7"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"288446ef49393e7b4d6f3202d71db62595917511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97e0042f_230b0b30","in_reply_to":"7d573de1_7d03a50f","updated":"2023-09-22 05:18:43.000000000","message":"That\u0027s fine Carlos. Thank you for the links.","commit_id":"b44c36e5ba43aa8c07d0aa68b90a2cf9e130ecc7"}],"manila/db/migrations/alembic/versions/38e632621e5a_change_volume_type_to_share_type.py":[{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"5c02a02ed419e1b94c96a813a21279579f433075","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                  nullable\u003dFalse),"},{"line_number":61,"context_line":"        sa.Column(\u0027spec_key\u0027, sa.String(length\u003d255)),"},{"line_number":62,"context_line":"        sa.Column(\u0027spec_value\u0027, sa.String(length\u003d255)),"},{"line_number":63,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027, mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    LOG.info(\"Migrating volume_type_extra_specs to \""},{"line_number":66,"context_line":"             \"share_type_extra_specs\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"8a2baf6a_47918a0f","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":20},"updated":"2023-09-21 11:38:18.000000000","message":"NIT: utf8 is aliased to utf8mb3 in older releases of mysql (8.0 and below) and it is aliased to utf8mb4 in the latest releases. \n\nTo avoid ambiguity, can we use  utf8mb4 charset explicitly ?","commit_id":"0bae78dbfe2fc99ce5d28ac0913a78055fee54a7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d3cf0ee071ed56382521d22ba28cebf9470b675b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                  nullable\u003dFalse),"},{"line_number":61,"context_line":"        sa.Column(\u0027spec_key\u0027, sa.String(length\u003d255)),"},{"line_number":62,"context_line":"        sa.Column(\u0027spec_value\u0027, sa.String(length\u003d255)),"},{"line_number":63,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027, mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    LOG.info(\"Migrating volume_type_extra_specs to \""},{"line_number":66,"context_line":"             \"share_type_extra_specs\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7be6d124_60c6ee48","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":20},"in_reply_to":"0eef1364_d09e9db5","updated":"2023-09-21 19:32:57.000000000","message":"Done","commit_id":"0bae78dbfe2fc99ce5d28ac0913a78055fee54a7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9c4f41255b3ed203d2671d21142610c8572060a6","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                  nullable\u003dFalse),"},{"line_number":61,"context_line":"        sa.Column(\u0027spec_key\u0027, sa.String(length\u003d255)),"},{"line_number":62,"context_line":"        sa.Column(\u0027spec_value\u0027, sa.String(length\u003d255)),"},{"line_number":63,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027, mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    LOG.info(\"Migrating volume_type_extra_specs to \""},{"line_number":66,"context_line":"             \"share_type_extra_specs\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"0eef1364_d09e9db5","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":20},"in_reply_to":"8a2baf6a_47918a0f","updated":"2023-09-21 14:45:22.000000000","message":"Yeah, that sounds fair - thanks for the suggestion. Will submit another PS","commit_id":"0bae78dbfe2fc99ce5d28ac0913a78055fee54a7"}],"manila/db/migrations/alembic/versions/3a482171410f_add_drivers_private_data_table.py":[{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"5c02a02ed419e1b94c96a813a21279579f433075","unresolved":true,"context_lines":[{"line_number":50,"context_line":"                       nullable\u003dFalse, primary_key\u003dTrue),"},{"line_number":51,"context_line":"            sql.Column(\u0027value\u0027, sql.String(1023), nullable\u003dFalse),"},{"line_number":52,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":53,"context_line":"            mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":54,"context_line":"        )"},{"line_number":55,"context_line":"    except Exception:"},{"line_number":56,"context_line":"        LOG.error(\"Table |%s| not created!\","}],"source_content_type":"text/x-python","patch_set":4,"id":"e068e92e_255578d7","line":53,"updated":"2023-09-21 11:38:18.000000000","message":"NIT: Same as above","commit_id":"0bae78dbfe2fc99ce5d28ac0913a78055fee54a7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d3cf0ee071ed56382521d22ba28cebf9470b675b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                       nullable\u003dFalse, primary_key\u003dTrue),"},{"line_number":51,"context_line":"            sql.Column(\u0027value\u0027, sql.String(1023), nullable\u003dFalse),"},{"line_number":52,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":53,"context_line":"            mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":54,"context_line":"        )"},{"line_number":55,"context_line":"    except Exception:"},{"line_number":56,"context_line":"        LOG.error(\"Table |%s| not created!\","}],"source_content_type":"text/x-python","patch_set":4,"id":"1b983c01_78b84e49","line":53,"in_reply_to":"e068e92e_255578d7","updated":"2023-09-21 19:32:57.000000000","message":"Done","commit_id":"0bae78dbfe2fc99ce5d28ac0913a78055fee54a7"}],"manila/tests/share/drivers/dell_emc/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"024f107f6be2027eae2979da487694d3349b98cf","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                          None, snapshot, share_access_rules,"},{"line_number":278,"context_line":"                          snapshot_access_rules, share_server)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def test_unmanage_manage(self):"},{"line_number":281,"context_line":"        share \u003d {}"},{"line_number":282,"context_line":"        server_details \u003d {}"},{"line_number":283,"context_line":"        share_server \u003d mock.Mock()"},{"line_number":284,"context_line":"        snapshot \u003d mock.Mock()"},{"line_number":285,"context_line":"        self.driver.plugin \u003d mock.Mock(share)"},{"line_number":286,"context_line":"        self.driver.unmanage(share)"},{"line_number":287,"context_line":"        self.driver.unmanage_with_server(share, share_server)"},{"line_number":288,"context_line":"        self.driver.unmanage_snapshot(snapshot)"},{"line_number":289,"context_line":"        self.driver.unmanage_snapshot_with_server(snapshot, share_server)"},{"line_number":290,"context_line":"        self.driver.unmanage_server(server_details)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def test_get_default_filter_function(self):"},{"line_number":293,"context_line":"        expected \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"27235d94_3400dfe1","line":290,"range":{"start_line":280,"start_character":0,"end_line":290,"end_character":51},"updated":"2023-09-21 19:12:43.000000000","message":"strange looking test. it does nothing really... with the plugin mocked out, there\u0027s no code invocation..","commit_id":"0bae78dbfe2fc99ce5d28ac0913a78055fee54a7"}]}