)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"8670dfed709f07b54aa19b9a56a004641e89d347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"537be582_357c9e4b","updated":"2023-09-28 13:02:44.000000000","message":"recheck","commit_id":"2efdfe054c156374e6ef51327ba20b7ef574d52a"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"496d6b0c1efe7d836e7641f13e9c2e827b01c9d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27f06d5f_8970a177","updated":"2023-09-28 15:52:43.000000000","message":"LGTM","commit_id":"41201991daab74e370fdca67354218530a460b00"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fe1a83f5ffcb6e2dad313fa6050d6f621542eff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09b26504_2636fe7f","updated":"2023-09-28 21:10:51.000000000","message":"Thanks for working on the fix, Gireesh! Could you please add a release note to this change?\n\n[1] https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"41201991daab74e370fdca67354218530a460b00"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"a727b7b5210336c0f351a421f31ad912365b5c5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ebfd7c6_428896e3","updated":"2023-09-28 15:54:23.000000000","message":"run-NetApp CI","commit_id":"41201991daab74e370fdca67354218530a460b00"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55220b684d76a68fba3dd7e5980d84abadb43bcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b2de943_8619f5bd","updated":"2023-09-29 20:08:28.000000000","message":"I believe black is pointing out an issue in the pep8 job, so I\u0027d recommend ensuring that you have the change that made black a thing in your env and running pep8 locally, and black will take care of fixing what\u0027s the issue. Then, you can add the changes and amend the commit, and when if you submit this again, it should be fine.","commit_id":"210c1c0fda5f081aeddeafacd80b3c1385b2f965"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"d3eb957d74ad2201c406eea0c958a98ef84a0ff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ebd672c_fa7af684","updated":"2023-09-29 13:07:41.000000000","message":"recheck","commit_id":"210c1c0fda5f081aeddeafacd80b3c1385b2f965"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"49a4f754c95bec987a8e33f25a38e0c2f95197da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bef21a45_2082d4b4","updated":"2023-09-30 06:59:33.000000000","message":"recheck","commit_id":"210c1c0fda5f081aeddeafacd80b3c1385b2f965"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"594cee421a71751c077d1cbd995bb80def2dbffb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9373a112_44e7105c","updated":"2023-10-03 09:13:49.000000000","message":"I trigger NetApp CI 3-4 times, It seems due to hardware issue test are failing intermediary. the test failed in https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/59/896759/5/upstream-check/manila-tempest-plugin-ontap-dhss/b0d70a5/testr_results.html run are passing in next run https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/59/896759/5/upstream-check/manila-tempest-plugin-ontap-dhss/8ed4e42/testr_results.html. so based on this I would say there will be no regression due to my fix.","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bb651c922e4dad9ffe83f9e17b675eef3acd9593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa936a2f_67d23478","updated":"2023-10-04 12:44:51.000000000","message":"LGTM, thanks for the fix.\nOn the backports: as 2023.2 is already branched, that should be the first branch to receive the change after it merges on Master. Could you please to the backport there too?","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"15b2660c4e97e594439bd902975983483bdbd2f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4aea5d7b_450aa916","updated":"2023-10-03 16:31:14.000000000","message":"LGTM.","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe1c7d3fbdeb15bd4ae6080c53140318d5ccc642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a27a8080_94346c66","updated":"2023-10-13 19:55:39.000000000","message":"Thanks Gireesh","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"637306677166bb33d90918210fa5037bc6c0de81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"323b0ff0_28cc7618","updated":"2023-10-02 12:01:54.000000000","message":"run-NetApp CI","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"b9b7f87a834336b8972f2d515634b1573a7ca420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"36b33d17_5c4b486a","updated":"2023-10-03 03:20:11.000000000","message":"run-NetApp CI","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"0cc6e41cabeb1384904045e0af13ed45f20bdc63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6b7afd7e_cd44052c","updated":"2023-10-02 07:12:08.000000000","message":"run-NetApp CI","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"e1e9bfc2636fec10f917cb54faad7241385443e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a6cd3da2_e7b132d4","updated":"2023-10-02 07:45:50.000000000","message":"run-NetApp CI","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"e649d678615f5840cfb4044ded8f09d58c9867ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cbb1059c_9e57d249","updated":"2023-10-01 11:08:08.000000000","message":"run-NetApp CI","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"8e218c9df3f87b496e4891f10c0fc47e9ecdb87f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cbfd1f9a_1c814131","updated":"2023-10-01 12:49:10.000000000","message":"run-NetApp CI","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe1c7d3fbdeb15bd4ae6080c53140318d5ccc642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7c301f13_2866fdac","in_reply_to":"9373a112_44e7105c","updated":"2023-10-13 19:55:39.000000000","message":"ack","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"64d24b1143957cf2c6959605ae5afb367365dfa0","unresolved":true,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        # Fix for bug 1996907- If snapmirror relationship still exist,"},{"line_number":744,"context_line":"        # deletes those again."},{"line_number":745,"context_line":"        snapmirrors_des_list \u003d self._get_snapmirrors_destinations("},{"line_number":746,"context_line":"            vserver, peer_vserver)"},{"line_number":747,"context_line":"        snapmirrors_des_list_from_peer \u003d self._get_snapmirrors_destinations("},{"line_number":748,"context_line":"            peer_vserver, vserver)"},{"line_number":749,"context_line":"        if snapmirrors_des_list or snapmirrors_des_list_from_peer:"},{"line_number":750,"context_line":"            super(NetAppCmodeMultiSVMFileStorageLibrary, self).delete_replica("},{"line_number":751,"context_line":"                context, replica_list, replica, share_snapshots)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # Check if there are no remaining SnapMirror connections and if a"},{"line_number":754,"context_line":"        # vserver peering exists and delete it."}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d99b_a39286f4","line":751,"range":{"start_line":745,"start_character":0,"end_line":751,"end_character":64},"updated":"2023-10-11 00:02:11.000000000","message":"this could potentially loop forever; have you considered coding with a particular number of retries instead?","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe1c7d3fbdeb15bd4ae6080c53140318d5ccc642","unresolved":false,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        # Fix for bug 1996907- If snapmirror relationship still exist,"},{"line_number":744,"context_line":"        # deletes those again."},{"line_number":745,"context_line":"        snapmirrors_des_list \u003d self._get_snapmirrors_destinations("},{"line_number":746,"context_line":"            vserver, peer_vserver)"},{"line_number":747,"context_line":"        snapmirrors_des_list_from_peer \u003d self._get_snapmirrors_destinations("},{"line_number":748,"context_line":"            peer_vserver, vserver)"},{"line_number":749,"context_line":"        if snapmirrors_des_list or snapmirrors_des_list_from_peer:"},{"line_number":750,"context_line":"            super(NetAppCmodeMultiSVMFileStorageLibrary, self).delete_replica("},{"line_number":751,"context_line":"                context, replica_list, replica, share_snapshots)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # Check if there are no remaining SnapMirror connections and if a"},{"line_number":754,"context_line":"        # vserver peering exists and delete it."}],"source_content_type":"text/x-python","patch_set":5,"id":"50c688c4_271d9aae","line":751,"range":{"start_line":745,"start_character":0,"end_line":751,"end_character":64},"in_reply_to":"652b17b5_5d6886c2","updated":"2023-10-13 19:55:39.000000000","message":"I understand why this is being done; my concern is how this coded as a never ending recursion... \n\nhowever, iiuc, you\u0027re saying that ONTAP does clean up the destinations at some point, and we should repeat ourselves once (or a few times) at most. I\u0027ll defer to your wisdom as the driver\u0027s maintainer.","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"2204dd32dfaa95e66fe9c865ea0eb1f50d02f7a2","unresolved":true,"context_lines":[{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        # Fix for bug 1996907- If snapmirror relationship still exist,"},{"line_number":744,"context_line":"        # deletes those again."},{"line_number":745,"context_line":"        snapmirrors_des_list \u003d self._get_snapmirrors_destinations("},{"line_number":746,"context_line":"            vserver, peer_vserver)"},{"line_number":747,"context_line":"        snapmirrors_des_list_from_peer \u003d self._get_snapmirrors_destinations("},{"line_number":748,"context_line":"            peer_vserver, vserver)"},{"line_number":749,"context_line":"        if snapmirrors_des_list or snapmirrors_des_list_from_peer:"},{"line_number":750,"context_line":"            super(NetAppCmodeMultiSVMFileStorageLibrary, self).delete_replica("},{"line_number":751,"context_line":"                context, replica_list, replica, share_snapshots)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # Check if there are no remaining SnapMirror connections and if a"},{"line_number":754,"context_line":"        # vserver peering exists and delete it."}],"source_content_type":"text/x-python","patch_set":5,"id":"652b17b5_5d6886c2","line":751,"range":{"start_line":745,"start_character":0,"end_line":751,"end_character":64},"in_reply_to":"bfb3d99b_a39286f4","updated":"2023-10-12 11:01:35.000000000","message":"This will be executed only once when we delete the replica.I have tested this by changing the code on my local setup as below and then delete the replica. below code is executed only once.\nif True:\n   super(NetAppCmodeMultiSVMFileStorageLibrary, self).delete_replica(\n                context, replica_list, replica, share_snapshots)\n                \nAs we are not able to reproduce this issue so we added the code to delete the replica again if list-destination still showing the snapmirror relationship.","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"}],"releasenotes/notes/bug-1982808-fix-netapp-api-failed-relationship-is-in-use-ecc9ede4d7f0f5b9.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe1c7d3fbdeb15bd4ae6080c53140318d5ccc642","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NetApp driver `bug #1982808"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/1982808\u003e`_: Fixed issue"},{"line_number":6,"context_line":"    to add the retry logic to delete and release the snapmirror relationship."},{"line_number":7,"context_line":"    Delete the vserver pairing when there is no snapmirror relationship exist"},{"line_number":8,"context_line":"    on source and destination cluster."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8840a4c9_066b9286","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":77},"updated":"2023-10-13 19:55:39.000000000","message":"nit: there are no snapmirror relationships that exist","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe1c7d3fbdeb15bd4ae6080c53140318d5ccc642","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/1982808\u003e`_: Fixed issue"},{"line_number":6,"context_line":"    to add the retry logic to delete and release the snapmirror relationship."},{"line_number":7,"context_line":"    Delete the vserver pairing when there is no snapmirror relationship exist"},{"line_number":8,"context_line":"    on source and destination cluster."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1acbd296_39cbac33","line":8,"range":{"start_line":8,"start_character":30,"end_line":8,"end_character":37},"updated":"2023-10-13 19:55:39.000000000","message":"nit: clusters","commit_id":"1f9d51fdba24c218940b5eeacd3175b6b0767635"}]}