)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1665d70971e491c3263849f800b0dd34eb05e9bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"028e48dc_6b690178","updated":"2023-10-03 23:47:08.000000000","message":"Thanks I prefer this fix; is there any intention of backporting this to older stable releases; perhaps as an enhancement for the fix to https://bugs.launchpad.net/manila/+bug/2037580 ?","commit_id":"e3c73432599287d0b3fd2d6f6019ade2499cbbe1"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"59387be1c53a312f92a34320cce8aafe61f3ac4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1356fa47_eecb36e9","in_reply_to":"028e48dc_6b690178","updated":"2023-10-04 14:34:13.000000000","message":"this indeed fix the host setting issue in https://bugs.launchpad.net/manila/+bug/2037580 \nIf it\u0027s acceptable to you, I think backport this will really help to correct host config around","commit_id":"e3c73432599287d0b3fd2d6f6019ade2499cbbe1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16975bee2f7225ef4dd806d2f8052252e2c634a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a021e47c_1ec87428","in_reply_to":"1356fa47_eecb36e9","updated":"2023-10-04 18:14:32.000000000","message":"I agree; since it preserves the prior behavior, it\u0027s as good a thing to backport as this series: https://review.opendev.org/q/topic:bug%252F2037580 \n\ni\u0027ll set the topic and comment on the bug so we can be aware its the same issue we\u0027re addressing","commit_id":"e3c73432599287d0b3fd2d6f6019ade2499cbbe1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b43075c98fb90f640610a2d265146dfbb454b62b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"12f8b5c4_309b98cf","updated":"2023-10-24 17:38:31.000000000","message":"LGTM, thanks Rico","commit_id":"129dc9b28ba776e47b552d7bddb0a63a38745082"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16975bee2f7225ef4dd806d2f8052252e2c634a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1549a060_5a2f1c40","updated":"2023-10-04 18:14:32.000000000","message":"Thanks Rico!","commit_id":"129dc9b28ba776e47b552d7bddb0a63a38745082"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"aa51d861d3d1203f3908a78c70edaf4764036b14","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        \"service_network_host\","},{"line_number":83,"context_line":"        sample_default\u003d\"\u003cyour_network_hostname\u003e\","},{"line_number":84,"context_line":"        help\u003d\"Name of share network host that network ports runs on. \""},{"line_number":85,"context_line":"             \"This can be an opaque identifier. It is not necessarily a \""},{"line_number":86,"context_line":"             \"hostname, FQDN, or IP address. Used only with Neutron \""},{"line_number":87,"context_line":"             \"and if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":88,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"a6c85ad4_40fb1783","line":85,"updated":"2023-10-02 19:17:14.000000000","message":"I would change it to be something like\n\n\"Hostname to be used for service network binding.  Used only with Neutron and if driver_handles_share_servers\u003dTrue.\"","commit_id":"fe43c2d54118ea40d2f8cf684e4a265a0fd96b1d"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"28dcfd5447adaae7c788d76ce61733b6562353fa","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \"service_network_host\","},{"line_number":83,"context_line":"        sample_default\u003d\"\u003cyour_network_hostname\u003e\","},{"line_number":84,"context_line":"        help\u003d\"Name of share network host that network ports runs on. \""},{"line_number":85,"context_line":"             \"This can be an opaque identifier. It is not necessarily a \""},{"line_number":86,"context_line":"             \"hostname, FQDN, or IP address. Used only with Neutron \""},{"line_number":87,"context_line":"             \"and if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":88,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"11716d8c_3ad229ea","line":85,"in_reply_to":"a6c85ad4_40fb1783","updated":"2023-10-02 19:19:47.000000000","message":"Done","commit_id":"fe43c2d54118ea40d2f8cf684e4a265a0fd96b1d"}],"releasenotes/notes/new-config-option-dhss-4931db193fd76656.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1665d70971e491c3263849f800b0dd34eb05e9bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new config option \u0027service_network_host\u0027 for service instance that with"},{"line_number":5,"context_line":"    \u0027dhss\u0027\u003dTrue. This helps us to define network host for ports and able to"},{"line_number":6,"context_line":"    seperate from manila host."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f316ef39_ad5f0103","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":74},"updated":"2023-10-03 23:47:08.000000000","message":"nit: unnecessary word","commit_id":"e3c73432599287d0b3fd2d6f6019ade2499cbbe1"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"966a4af8af6afb6a4f99742c0f0867a72d2bf979","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new config option \u0027service_network_host\u0027 for service instance that with"},{"line_number":5,"context_line":"    \u0027dhss\u0027\u003dTrue. This helps us to define network host for ports and able to"},{"line_number":6,"context_line":"    seperate from manila host."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b4ac1bb3_1c43754f","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":74},"in_reply_to":"f316ef39_ad5f0103","updated":"2023-10-24 06:53:45.000000000","message":"Done","commit_id":"e3c73432599287d0b3fd2d6f6019ade2499cbbe1"}]}
