)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"2fdb5068bccc17d752ca819976d0ff65d5cf7355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e33bfa7_27ef1f51","updated":"2023-10-27 14:48:09.000000000","message":"Looks good, thanks Carlos. It would help to provide acceptance criteria guidelines.","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"19093114bb49c4f0b1932d04ea482437eb8eb975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90534fba_eeccee6e","updated":"2023-10-19 19:42:16.000000000","message":"looks good, added some comments regarding grammatical changes. \nShould we include a call out for microversions as well?","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"7f70e4e6c4907544c1921a727008af4f489a8d3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ede1ca6d_986874ca","updated":"2023-12-05 18:47:02.000000000","message":"LGTM, thanks carloss","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"a7ab19cc9f0cfd203616206916bedf7725f9f319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"540f676f_98afb696","updated":"2023-11-28 11:19:12.000000000","message":"Looks good, thanks.","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ddbc57cf163c327fdcd4c3ad4a136e58a8d2d5df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"968a64d9_feea601d","updated":"2024-01-15 19:09:03.000000000","message":"Thank you for the review. PTAL :)","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c1f0ff3ca16220452166bca1ba664f0d5abf7d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53a0298d_1e0d77b6","updated":"2023-12-05 19:10:05.000000000","message":"Thanks for the changes; some minor comments inline, Carlos.","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"196983e8_c9b56228","updated":"2023-11-27 13:04:25.000000000","message":"Thanks for the reviews! Please take a look at the changes inline","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f58d3a570d2ad402d535d0a410e4bedf417c90f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40c24a80_98706fc8","updated":"2024-01-15 19:09:51.000000000","message":"Apologies, accidentally +2\u0027d the previous patch while submitting the replies.","commit_id":"d1edbdbaec0d85b761ef5e7fb88851a9acec850b"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ffebf3a46ce86b0455df127b6e73ea686cb4d873","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b2a45e02_42e2121d","updated":"2024-01-17 17:11:57.000000000","message":"Looks good, Thanks.","commit_id":"d1edbdbaec0d85b761ef5e7fb88851a9acec850b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"439e68519f1eb758f2df506fc51eddfb3d2fc132","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"afe140d3_b661d938","updated":"2024-01-15 23:04:05.000000000","message":"Thanks Carlos; This is a good compilation of conventions that will now become official.","commit_id":"d1edbdbaec0d85b761ef5e7fb88851a9acec850b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"640d90676f24a6b812aae2f93b58ba9262431a15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba634f67_3a9b1060","updated":"2024-01-26 04:48:00.000000000","message":"lets get this in","commit_id":"d1edbdbaec0d85b761ef5e7fb88851a9acec850b"}],"doc/source/contributor/new_feature_workflow.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ee9d8a8010d70ae084f0eb13e661b412cec3cbd","unresolved":true,"context_lines":[{"line_number":49,"context_line":"design of the feature and have the community helping you shape it."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"In case you missed the PTG deadline to bring up such features, you can also"},{"line_number":52,"context_line":"add a topic to the Manila upstream weekly meeting"},{"line_number":53,"context_line":"`agenda \u003chttps://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting\u003e`_ and"},{"line_number":54,"context_line":"request feedback from the community."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6b5a3504_edf84a97","line":52,"range":{"start_line":52,"start_character":19,"end_line":52,"end_character":49},"updated":"2023-10-31 22:26:28.000000000","message":"Manila community weekly IRC meeting","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"design of the feature and have the community helping you shape it."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"In case you missed the PTG deadline to bring up such features, you can also"},{"line_number":52,"context_line":"add a topic to the Manila upstream weekly meeting"},{"line_number":53,"context_line":"`agenda \u003chttps://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting\u003e`_ and"},{"line_number":54,"context_line":"request feedback from the community."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6b0b1569_7656df87","line":52,"range":{"start_line":52,"start_character":19,"end_line":52,"end_character":49},"in_reply_to":"6b5a3504_edf84a97","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"19093114bb49c4f0b1932d04ea482437eb8eb975","unresolved":true,"context_lines":[{"line_number":57,"context_line":"and raise awareness, so there are no surprises when the feature is being"},{"line_number":58,"context_line":"proposed."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"One other outcome of this discussion is if you will need to write a"},{"line_number":61,"context_line":"specification or not. The community will use"},{"line_number":62,"context_line":":ref:`pre-defined \u003cfeatures-that-require-spefication\u003e` factors to decide if you"},{"line_number":63,"context_line":"need a specification or not."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9d08543a_51afa2b6","line":61,"range":{"start_line":60,"start_character":40,"end_line":61,"end_character":20},"updated":"2023-10-19 19:42:16.000000000","message":"nit: \"determining the necesity of a specification.\"","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"and raise awareness, so there are no surprises when the feature is being"},{"line_number":58,"context_line":"proposed."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"One other outcome of this discussion is if you will need to write a"},{"line_number":61,"context_line":"specification or not. The community will use"},{"line_number":62,"context_line":":ref:`pre-defined \u003cfeatures-that-require-spefication\u003e` factors to decide if you"},{"line_number":63,"context_line":"need a specification or not."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a510f96_d31ae203","line":61,"range":{"start_line":60,"start_character":40,"end_line":61,"end_character":20},"in_reply_to":"9d08543a_51afa2b6","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"19093114bb49c4f0b1932d04ea482437eb8eb975","unresolved":true,"context_lines":[{"line_number":65,"context_line":"Writing a specification"},{"line_number":66,"context_line":"-----------------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Writing a specification is a required step to document a feature behavior."},{"line_number":69,"context_line":"You will need to write in more details about the problem you are trying to"},{"line_number":70,"context_line":"solve, the use cases and all the impact this change will have in terms of API"},{"line_number":71,"context_line":"changes, database, security and other aspects. The specification will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8d907a7a_36fe0e5a","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":74},"updated":"2023-10-19 19:42:16.000000000","message":"You mentioned above \"if\" a spec is necessary, but here it is required. Maybe: \n\n\"After determining if a specification is necesary for your proposed feature, you will need to write...\"","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Writing a specification"},{"line_number":66,"context_line":"-----------------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Writing a specification is a required step to document a feature behavior."},{"line_number":69,"context_line":"You will need to write in more details about the problem you are trying to"},{"line_number":70,"context_line":"solve, the use cases and all the impact this change will have in terms of API"},{"line_number":71,"context_line":"changes, database, security and other aspects. The specification will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2ff25643_033903a6","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":74},"in_reply_to":"8d907a7a_36fe0e5a","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ee9d8a8010d70ae084f0eb13e661b412cec3cbd","unresolved":true,"context_lines":[{"line_number":72,"context_line":"reviewed by different people, and this process is crucial for hashing out"},{"line_number":73,"context_line":"details. Please check the OpenStack Manila"},{"line_number":74,"context_line":"`example specification \u003chttps://specs.openstack.org/openstack/manila-specs/specs/template.html\u003e`_"},{"line_number":75,"context_line":"and follow its guidelines. A more brief specification might be asked"},{"line_number":76,"context_line":"(lite spec) and here is"},{"line_number":77,"context_line":"`an example \u003chttps://github.com/openstack/manila-specs/blob/master/specs/wallaby/spec-lite-add-max-shares-on-share-server-limit.rst\u003e`_."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"94668e89_d857980b","line":75,"range":{"start_line":75,"start_character":27,"end_line":75,"end_character":68},"updated":"2023-10-31 22:26:28.000000000","message":"If you are working on a smaller feature, you may submit a \"lite spec\". Please follow this `example \u003c\u003e_`.","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"reviewed by different people, and this process is crucial for hashing out"},{"line_number":73,"context_line":"details. Please check the OpenStack Manila"},{"line_number":74,"context_line":"`example specification \u003chttps://specs.openstack.org/openstack/manila-specs/specs/template.html\u003e`_"},{"line_number":75,"context_line":"and follow its guidelines. A more brief specification might be asked"},{"line_number":76,"context_line":"(lite spec) and here is"},{"line_number":77,"context_line":"`an example \u003chttps://github.com/openstack/manila-specs/blob/master/specs/wallaby/spec-lite-add-max-shares-on-share-server-limit.rst\u003e`_."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"db0ec70f_775a9592","line":75,"range":{"start_line":75,"start_character":27,"end_line":75,"end_character":68},"in_reply_to":"94668e89_d857980b","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"19093114bb49c4f0b1932d04ea482437eb8eb975","unresolved":true,"context_lines":[{"line_number":83,"context_line":"you write must follow the OpenStack coding"},{"line_number":84,"context_line":"`guidelines \u003chttps://docs.openstack.org/hacking/latest/user/hacking.html\u003e`_."},{"line_number":85,"context_line":"You can find examples of database migrations, driver implementations,"},{"line_number":86,"context_line":"RPC APIs and many other changes in the Manila code base. As the code is"},{"line_number":87,"context_line":"being worked for a while, there is a high chance that someone else implemented"},{"line_number":88,"context_line":"something similar to what you are doing now, so keeping the consistency with"},{"line_number":89,"context_line":"feature implementation is very important."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ce1ca4a1_d7706800","line":87,"range":{"start_line":86,"start_character":57,"end_line":87,"end_character":24},"updated":"2023-10-19 19:42:16.000000000","message":"\"As our code has been worked on and imporved over the years, ...\"","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"you write must follow the OpenStack coding"},{"line_number":84,"context_line":"`guidelines \u003chttps://docs.openstack.org/hacking/latest/user/hacking.html\u003e`_."},{"line_number":85,"context_line":"You can find examples of database migrations, driver implementations,"},{"line_number":86,"context_line":"RPC APIs and many other changes in the Manila code base. As the code is"},{"line_number":87,"context_line":"being worked for a while, there is a high chance that someone else implemented"},{"line_number":88,"context_line":"something similar to what you are doing now, so keeping the consistency with"},{"line_number":89,"context_line":"feature implementation is very important."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f613eb1f_a04762ae","line":87,"range":{"start_line":86,"start_character":57,"end_line":87,"end_character":24},"in_reply_to":"ce1ca4a1_d7706800","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ee9d8a8010d70ae084f0eb13e661b412cec3cbd","unresolved":true,"context_lines":[{"line_number":100,"context_line":"install it using the Manila Dummy Driver or another backend driver of your"},{"line_number":101,"context_line":"choice."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"OpenStack client"},{"line_number":104,"context_line":"----------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"It is important to have the OpenStack client changes in place so users and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"08ded3e8_2ae9f363","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":16},"updated":"2023-10-31 22:26:28.000000000","message":"SDK and OpenStack Client","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"install it using the Manila Dummy Driver or another backend driver of your"},{"line_number":101,"context_line":"choice."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"OpenStack client"},{"line_number":104,"context_line":"----------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"It is important to have the OpenStack client changes in place so users and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"19de8f2f_3f93385f","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":16},"in_reply_to":"08ded3e8_2ae9f363","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ee9d8a8010d70ae084f0eb13e661b412cec3cbd","unresolved":true,"context_lines":[{"line_number":103,"context_line":"OpenStack client"},{"line_number":104,"context_line":"----------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"It is important to have the OpenStack client changes in place so users and"},{"line_number":107,"context_line":"administrators can make use of your feature."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Unit tests"}],"source_content_type":"text/x-rst","patch_set":1,"id":"15ef66bf_0316678b","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":23},"updated":"2023-10-31 22:26:28.000000000","message":"If the feature changes the Manila API, please ensure that support these changes through the SDK bindings and OpenStack client in the `python-manilaclient \u003c\u003e`_ repository.","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"OpenStack client"},{"line_number":104,"context_line":"----------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"It is important to have the OpenStack client changes in place so users and"},{"line_number":107,"context_line":"administrators can make use of your feature."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Unit tests"}],"source_content_type":"text/x-rst","patch_set":1,"id":"011551c6_183f0c93","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":23},"in_reply_to":"15ef66bf_0316678b","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ee9d8a8010d70ae084f0eb13e661b412cec3cbd","unresolved":true,"context_lines":[{"line_number":118,"context_line":"    Please :ref:`run the unit tests locally \u003crunning-unit-tests\u003e` to ensure"},{"line_number":119,"context_line":"    that your tests are passing before submitting them to the upstream gerrit."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Functional tests"},{"line_number":122,"context_line":"----------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"New negative and positive functional tests must be written for new APIs. You"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8c8bd48c_7c3fed0e","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":16},"updated":"2023-10-31 22:26:28.000000000","message":"Should we just call these \"Tempest tests\"","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    Please :ref:`run the unit tests locally \u003crunning-unit-tests\u003e` to ensure"},{"line_number":119,"context_line":"    that your tests are passing before submitting them to the upstream gerrit."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Functional tests"},{"line_number":122,"context_line":"----------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"New negative and positive functional tests must be written for new APIs. You"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d64c160a_33945b09","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":16},"in_reply_to":"8c8bd48c_7c3fed0e","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ee9d8a8010d70ae084f0eb13e661b412cec3cbd","unresolved":true,"context_lines":[{"line_number":121,"context_line":"Functional tests"},{"line_number":122,"context_line":"----------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"New negative and positive functional tests must be written for new APIs. You"},{"line_number":125,"context_line":"can use your development environment to"},{"line_number":126,"context_line":":ref:`run such tests \u003cinstalling-tempest-tests\u003e`, and ensure your changes"},{"line_number":127,"context_line":"didn\u0027t break existing functional tests."}],"source_content_type":"text/x-rst","patch_set":1,"id":"46fc6453_96065eb0","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":71},"updated":"2023-10-31 22:26:28.000000000","message":"All API changes must be tested with negative and positive tests within the `manila-tempest-plugin repository \u003c\u003e`_","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Functional tests"},{"line_number":122,"context_line":"----------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"New negative and positive functional tests must be written for new APIs. You"},{"line_number":125,"context_line":"can use your development environment to"},{"line_number":126,"context_line":":ref:`run such tests \u003cinstalling-tempest-tests\u003e`, and ensure your changes"},{"line_number":127,"context_line":"didn\u0027t break existing functional tests."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f049e190_8b98b7ca","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":71},"in_reply_to":"46fc6453_96065eb0","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"19093114bb49c4f0b1932d04ea482437eb8eb975","unresolved":true,"context_lines":[{"line_number":124,"context_line":"New negative and positive functional tests must be written for new APIs. You"},{"line_number":125,"context_line":"can use your development environment to"},{"line_number":126,"context_line":":ref:`run such tests \u003cinstalling-tempest-tests\u003e`, and ensure your changes"},{"line_number":127,"context_line":"didn\u0027t break existing functional tests."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Documenting your work"},{"line_number":130,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ddbc769a_b220c54a","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":6},"updated":"2023-10-19 19:42:16.000000000","message":"\"don\u0027t\"","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"New negative and positive functional tests must be written for new APIs. You"},{"line_number":125,"context_line":"can use your development environment to"},{"line_number":126,"context_line":":ref:`run such tests \u003cinstalling-tempest-tests\u003e`, and ensure your changes"},{"line_number":127,"context_line":"didn\u0027t break existing functional tests."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Documenting your work"},{"line_number":130,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0b552c82_29bdbd0c","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":6},"in_reply_to":"ddbc769a_b220c54a","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"2fdb5068bccc17d752ca819976d0ff65d5cf7355","unresolved":true,"context_lines":[{"line_number":125,"context_line":"can use your development environment to"},{"line_number":126,"context_line":":ref:`run such tests \u003cinstalling-tempest-tests\u003e`, and ensure your changes"},{"line_number":127,"context_line":"didn\u0027t break existing functional tests."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Documenting your work"},{"line_number":130,"context_line":"---------------------"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fbaef9fc_bc61a6d9","line":128,"updated":"2023-10-27 14:48:09.000000000","message":"Suggest to add a section to define acceptance criteria for the feature proposed","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"can use your development environment to"},{"line_number":126,"context_line":":ref:`run such tests \u003cinstalling-tempest-tests\u003e`, and ensure your changes"},{"line_number":127,"context_line":"didn\u0027t break existing functional tests."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Documenting your work"},{"line_number":130,"context_line":"---------------------"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3e6a104b_f117f6a1","line":128,"in_reply_to":"fbaef9fc_bc61a6d9","updated":"2023-11-27 13:04:25.000000000","message":"Done... Added a couple of things, but don\u0027t think it should be a final list. Please let me know your thoughts on it :)","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"19093114bb49c4f0b1932d04ea482437eb8eb975","unresolved":true,"context_lines":[{"line_number":130,"context_line":"---------------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":":ref:`Documenting your work \u003cdocumenting_your_work\u003e` is very important. Please"},{"line_number":133,"context_line":"read the documentation and make changes where necessary."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Collaborative review sessions"},{"line_number":136,"context_line":"-----------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8864d413_eb7194aa","line":133,"range":{"start_line":133,"start_character":9,"end_line":133,"end_character":56},"updated":"2023-10-19 19:42:16.000000000","message":"\"API documentation \u003cinsert link here\u003e and make changes where neceasry. Also, you must include a release notes with your change. On devstack you may use \n\u0027\u0027\u0027tox -e reno new insert-title-here\u0027\u0027\u0027 to generate a release note.\"","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"---------------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":":ref:`Documenting your work \u003cdocumenting_your_work\u003e` is very important. Please"},{"line_number":133,"context_line":"read the documentation and make changes where necessary."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Collaborative review sessions"},{"line_number":136,"context_line":"-----------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"50b72242_3b9fffff","line":133,"range":{"start_line":133,"start_character":9,"end_line":133,"end_character":56},"in_reply_to":"8864d413_eb7194aa","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ee9d8a8010d70ae084f0eb13e661b412cec3cbd","unresolved":true,"context_lines":[{"line_number":136,"context_line":"-----------------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"`Collaborative review sessions \u003chttps://www.youtube.com/playlist?list\u003dPLnpzT0InFrqCZB_t2B3IHEYH3_gPFEhck\u003e`_"},{"line_number":139,"context_line":"are a good way to speed up the review process. It is encouraged that you"},{"line_number":140,"context_line":"propose one right after the Manila feature proposal freeze date. In the"},{"line_number":141,"context_line":"session, you can walk through the key aspects of the changes you are working on"},{"line_number":142,"context_line":"and explain some decisions you took during the implementation. It has proven"},{"line_number":143,"context_line":"to be very valuable to both change owners and reviewers."}],"source_content_type":"text/x-rst","patch_set":1,"id":"87bcfe66_55c58fb8","line":140,"range":{"start_line":139,"start_character":47,"end_line":140,"end_character":64},"updated":"2023-10-31 22:26:28.000000000","message":"lets recommend that we do this as early as possible. Do we want to mention that this can be proposed either via the ML or via the weekly IRC meeting so we can plan a date for this review meeting together.","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d01c2f9f6009773c70f62b60851b9457b24d745e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"-----------------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"`Collaborative review sessions \u003chttps://www.youtube.com/playlist?list\u003dPLnpzT0InFrqCZB_t2B3IHEYH3_gPFEhck\u003e`_"},{"line_number":139,"context_line":"are a good way to speed up the review process. It is encouraged that you"},{"line_number":140,"context_line":"propose one right after the Manila feature proposal freeze date. In the"},{"line_number":141,"context_line":"session, you can walk through the key aspects of the changes you are working on"},{"line_number":142,"context_line":"and explain some decisions you took during the implementation. It has proven"},{"line_number":143,"context_line":"to be very valuable to both change owners and reviewers."}],"source_content_type":"text/x-rst","patch_set":1,"id":"d7542507_fe8f5b04","line":140,"range":{"start_line":139,"start_character":47,"end_line":140,"end_character":64},"in_reply_to":"87bcfe66_55c58fb8","updated":"2023-11-27 13:04:25.000000000","message":"Done","commit_id":"a11c41f2273e4d33fd65d24ef7775fec0a29ebc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c1f0ff3ca16220452166bca1ba664f0d5abf7d2","unresolved":true,"context_lines":[{"line_number":76,"context_line":"submit a \"lite spec\". Please follow"},{"line_number":77,"context_line":"`this example \u003chttps://github.com/openstack/manila-specs/blob/master/specs/wallaby/spec-lite-add-max-shares-on-share-server-limit.rst\u003e`_."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"A more brief specification might be asked"},{"line_number":80,"context_line":"(lite spec) and here is"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Working on the implementation"},{"line_number":83,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3ddc57e4_b743df3d","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":23},"updated":"2023-12-05 19:10:05.000000000","message":"out of place? or incomplete?","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ddbc57cf163c327fdcd4c3ad4a136e58a8d2d5df","unresolved":false,"context_lines":[{"line_number":76,"context_line":"submit a \"lite spec\". Please follow"},{"line_number":77,"context_line":"`this example \u003chttps://github.com/openstack/manila-specs/blob/master/specs/wallaby/spec-lite-add-max-shares-on-share-server-limit.rst\u003e`_."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"A more brief specification might be asked"},{"line_number":80,"context_line":"(lite spec) and here is"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Working on the implementation"},{"line_number":83,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ef19a022_97b99868","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":23},"in_reply_to":"3ddc57e4_b743df3d","updated":"2024-01-15 19:09:03.000000000","message":"out of place :) thanks","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c1f0ff3ca16220452166bca1ba664f0d5abf7d2","unresolved":true,"context_lines":[{"line_number":91,"context_line":"implemented something similar to what you are doing now, so keeping the"},{"line_number":92,"context_line":"consistency with feature implementation is very important."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"In case you are doing changes to the API or adding new APIs, please"},{"line_number":95,"context_line":"read the :ref:`Manila API contributor docs \u003cadding-a-new-api\u003e`."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Development environment"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fc1edfc6_fe101959","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":21},"updated":"2023-12-05 19:10:05.000000000","message":"nit: making","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ddbc57cf163c327fdcd4c3ad4a136e58a8d2d5df","unresolved":false,"context_lines":[{"line_number":91,"context_line":"implemented something similar to what you are doing now, so keeping the"},{"line_number":92,"context_line":"consistency with feature implementation is very important."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"In case you are doing changes to the API or adding new APIs, please"},{"line_number":95,"context_line":"read the :ref:`Manila API contributor docs \u003cadding-a-new-api\u003e`."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Development environment"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4a79bf77_06969277","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":21},"in_reply_to":"fc1edfc6_fe101959","updated":"2024-01-15 19:09:03.000000000","message":"Done","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c1f0ff3ca16220452166bca1ba664f0d5abf7d2","unresolved":true,"context_lines":[{"line_number":97,"context_line":"Development environment"},{"line_number":98,"context_line":"-----------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"So you have worked on you changes and would like to test them?"},{"line_number":101,"context_line":":ref:`Devstack \u003csetting-up-manila-devstack\u003e` is likely the easiest way to go."},{"line_number":102,"context_line":"With devstack, you can have OpenStack installed quickly. You can chose to"},{"line_number":103,"context_line":"install it using the Manila Dummy Driver or another backend driver of your"}],"source_content_type":"text/x-rst","patch_set":2,"id":"38c3a853_c6beef91","line":100,"range":{"start_line":100,"start_character":22,"end_line":100,"end_character":25},"updated":"2023-12-05 19:10:05.000000000","message":"your","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ddbc57cf163c327fdcd4c3ad4a136e58a8d2d5df","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Development environment"},{"line_number":98,"context_line":"-----------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"So you have worked on you changes and would like to test them?"},{"line_number":101,"context_line":":ref:`Devstack \u003csetting-up-manila-devstack\u003e` is likely the easiest way to go."},{"line_number":102,"context_line":"With devstack, you can have OpenStack installed quickly. You can chose to"},{"line_number":103,"context_line":"install it using the Manila Dummy Driver or another backend driver of your"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3cb3e8fe_dd8ff134","line":100,"range":{"start_line":100,"start_character":22,"end_line":100,"end_character":25},"in_reply_to":"38c3a853_c6beef91","updated":"2024-01-15 19:09:03.000000000","message":"Done","commit_id":"df19d893cc2f8783338e373fd50b441a0cab48ac"}]}