)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5fd99c10e3cb4b8e10c8dfa163ea1b12191c446","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gray Lutalo \u003cjogareko@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-25 23:06:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"reset replica state not forbidden for active replica"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In a replication setup, users encountered a critical issue where they unintentionally reset the replica_state of an active replica while attempting to resolve errors on a non-active replica. This led to a situation with no active replica, causing data loss. Users expected server-side valdation to prevent such actions."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ed4fa54a_7c44aafb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2023-10-25 23:56:10.000000000","message":"this should convey what your commit does, and not what the problem is; for example:\n\n\"Forbid resetting state of active replicas\"\n\nis a fine heading.","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"},{"author":{"_account_id":36480,"name":"Gray Lutalo","display_name":"gray","email":"jogareko@gmail.com","username":"gray"},"change_message_id":"49f50aa17b7538a3ae2b255c39b1ae5951571a90","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gray Lutalo \u003cjogareko@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-25 23:06:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"reset replica state not forbidden for active replica"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In a replication setup, users encountered a critical issue where they unintentionally reset the replica_state of an active replica while attempting to resolve errors on a non-active replica. This led to a situation with no active replica, causing data loss. Users expected server-side valdation to prevent such actions."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"75022a2a_512ea805","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"in_reply_to":"ed4fa54a_7c44aafb","updated":"2023-10-29 08:20:03.000000000","message":"Done","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5fd99c10e3cb4b8e10c8dfa163ea1b12191c446","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"reset replica state not forbidden for active replica"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In a replication setup, users encountered a critical issue where they unintentionally reset the replica_state of an active replica while attempting to resolve errors on a non-active replica. This led to a situation with no active replica, causing data loss. Users expected server-side valdation to prevent such actions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #2015328"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff86ef48_ef13a368","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":319},"updated":"2023-10-25 23:56:10.000000000","message":"this explanation is good; thanks; I\u0027d like you to however wrap the text at ~79 characters... it allows the commit message to be clearly read by folks using narrow monitors or fine tuned code diff settings.\n\nFor example:\n\n```\nIn a replication setup, users encountered a \ncritical issue where they unintentionally reset\n....\n```","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"},{"author":{"_account_id":36480,"name":"Gray Lutalo","display_name":"gray","email":"jogareko@gmail.com","username":"gray"},"change_message_id":"49f50aa17b7538a3ae2b255c39b1ae5951571a90","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"reset replica state not forbidden for active replica"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In a replication setup, users encountered a critical issue where they unintentionally reset the replica_state of an active replica while attempting to resolve errors on a non-active replica. This led to a situation with no active replica, causing data loss. Users expected server-side valdation to prevent such actions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #2015328"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f3421558_48e62c76","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":319},"in_reply_to":"ff86ef48_ef13a368","updated":"2023-10-29 08:20:03.000000000","message":"Done","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c33621b8bd3cd5c1b5b61f97ee59ba4effcc59b3","unresolved":true,"context_lines":[{"line_number":18,"context_line":"cannot be applied to active replicas, addressing the"},{"line_number":19,"context_line":"reported issue and improving data integrity in"},{"line_number":20,"context_line":"replication setups."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #2015328"},{"line_number":23,"context_line":"Change-Id: I629669476e585a834673b8c8b49ad4b0270b877f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1fb0666c_511cb437","line":21,"updated":"2024-03-08 19:27:06.000000000","message":"I suggest adding a line above \"Closes-Bug\" to indicate that you\u0027re now the Co-Author; make sure that its in a line of its own, and there\u0027s a blank line between this line and the paragraph above\n\n```\nCo-Authored-By: Solly \u003csolobarine@gmail.com\u003e\n```","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5e0298eb87452230771acbdaca16a850b0011fe2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"cannot be applied to active replicas, addressing the"},{"line_number":19,"context_line":"reported issue and improving data integrity in"},{"line_number":20,"context_line":"replication setups."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #2015328"},{"line_number":23,"context_line":"Change-Id: I629669476e585a834673b8c8b49ad4b0270b877f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"2323db77_d8c348a5","line":21,"in_reply_to":"1fb0666c_511cb437","updated":"2024-03-08 20:18:58.000000000","message":"Done","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36480,"name":"Gray Lutalo","display_name":"gray","email":"jogareko@gmail.com","username":"gray"},"change_message_id":"6165e8c0276bab12089e804072010ce5010d75b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4b19ce9d_fde45232","updated":"2023-10-25 23:18:03.000000000","message":"Kindly help me review this.  Since i am still new here (outreachy Applicant) am not so sure whether am on the right truck","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5fd99c10e3cb4b8e10c8dfa163ea1b12191c446","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b5694a2f_41582bb9","updated":"2023-10-25 23:56:10.000000000","message":"Thank you for your submission; and welcome to OpenStack! \n\nI\u0027ve left some review comments inline, with suggestions for improving this. \n\nAlso, can you please add a release note? The instructions to do that are here:\n\nhttps://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"712d60730f37c9a9e2233dbb092853db303a626c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"50ba0eb3_01b2a252","in_reply_to":"b5694a2f_41582bb9","updated":"2023-10-31 18:21:04.000000000","message":"Can you please address this too?","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1296e3c0438f206d4b8e441df1b7c7e162fa1358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5725faec_2c6c26af","updated":"2023-10-27 19:43:42.000000000","message":"patch was rebased but prior review comments still apply","commit_id":"206d5a09e4b230b6e837763b4212fed3523e66bc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"712d60730f37c9a9e2233dbb092853db303a626c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4af50646_67a98bc2","updated":"2023-10-31 18:21:04.000000000","message":"Thanks for the update on this bugfix... i\u0027ve some more comments inline; and could you please add a release note as well?","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":36480,"name":"Gray Lutalo","display_name":"gray","email":"jogareko@gmail.com","username":"gray"},"change_message_id":"49f50aa17b7538a3ae2b255c39b1ae5951571a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"98f88b2f_9a47b668","updated":"2023-10-29 08:20:03.000000000","message":"done some changes, kindly check them out","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a29701fcd6925a9da43cc3a1fedb9b9365f2f3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"aca323c0_39985de2","updated":"2024-03-07 19:05:23.000000000","message":"Hi Solly, thank you for reviving this change and addressing review comments; i\u0027ve some more comments for you inline. \n\nDid you understand the fix? if yes, could you please write up a release note as well? https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"944e8b45e0671c3287933311de6d2e59bfcff0c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a02b1e0a_69210c1e","in_reply_to":"aca323c0_39985de2","updated":"2024-03-08 13:21:33.000000000","message":"\u003e Hi Solly, thank you for reviving this change and addressing review comments; i\u0027ve some more comments for you inline. \n\u003e \n\u003e Did you understand the fix? if yes, could you please write up a release note as well? https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html\n\nHey Solly, in case you might be wondering how to add a release  note, you can run this command on your terminal ` tox -e newnote -- bug-\u003claunchpad-bug-id\u003e\u003cslug-name\u003e`\nThis would generate a new release note for you. Find your specific release note and add the file accordingly. Since you are working on a bug, you might have to edit the `fixes` section of the file and probably remove rest contents.","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c33621b8bd3cd5c1b5b61f97ee59ba4effcc59b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d410f335_371e262a","updated":"2024-03-08 19:27:06.000000000","message":"Thanks for the update, Solly.. I presume you\u0027re learning how gerrit works. Please take a look at the latest comments and address them. \n\nAlso remember, you can \"comment\" on this patch yourself. For each comment that you are addressing, make sure to respond when you submit your patch. \n\nIf you addressed a comment, say something like \"Done\" and ensure that you\u0027re ticked off \"Resolved\" in the gerrit review. This helps reviewers. Remember you would have to click on the \"Reply\" button in your change and post your comments once you\u0027re done addressing all of them","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5e0298eb87452230771acbdaca16a850b0011fe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e338c296_c9911df8","in_reply_to":"d410f335_371e262a","updated":"2024-03-08 20:18:58.000000000","message":"Thanks for the review. The next patch fixes all the issues you outlined.","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dd1d69ff_e1eca5ed","updated":"2024-03-08 20:30:31.000000000","message":"Thanks; there\u0027s a comment on the release note. please address it if you\u0027re pushing up another patch","commit_id":"b7ad6c3e90a13b8e1c9641c15b82c02bb9d009a5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7eb39f5e7e97eff6f15945f2841ee5565e0d0a57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"acf559ca_01c44b69","updated":"2024-03-13 12:59:18.000000000","message":"LGTM, thank you for working on this change!","commit_id":"b7a1b5b2cf765b1570432b67363905251893ce42"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2025c73afa0fec8f836ee079c1745bd3bf0f7f15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"bca26825_66db9e70","updated":"2024-03-09 08:53:30.000000000","message":"good stuff; thank you","commit_id":"b7a1b5b2cf765b1570432b67363905251893ce42"}],"manila/api/openstack/wsgi.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"712d60730f37c9a9e2233dbb092853db303a626c","unresolved":true,"context_lines":[{"line_number":1262,"context_line":"            raise webob.exc.HTTPNotFound(e.message)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if (status_attr \u003d\u003d \u0027replica_state\u0027 and"},{"line_number":1265,"context_line":"                resource[\u0027replica_state\u0027] \u003d\u003d constants.REPLICA_STATE_ACTIVE):"},{"line_number":1266,"context_line":"            msg \u003d _(\"Cannot reset replica_state of active replica\")"},{"line_number":1267,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1268,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"49ee2893_30981d5d","line":1265,"range":{"start_line":1265,"start_character":16,"end_line":1265,"end_character":41},"updated":"2023-10-31 18:21:04.000000000","message":"please use \n\n```\n  resource.get(\u0027replica_state\u0027)\n  \n```\ninstead","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"            raise webob.exc.HTTPNotFound(e.message)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if (status_attr \u003d\u003d \u0027replica_state\u0027 and"},{"line_number":1265,"context_line":"                resource[\u0027replica_state\u0027] \u003d\u003d constants.REPLICA_STATE_ACTIVE):"},{"line_number":1266,"context_line":"            msg \u003d _(\"Cannot reset replica_state of active replica\")"},{"line_number":1267,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1268,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"820eb12a_d9706216","line":1265,"range":{"start_line":1265,"start_character":16,"end_line":1265,"end_character":41},"in_reply_to":"1471e62c_55b3d3f7","updated":"2024-03-08 20:30:31.000000000","message":"this is now resolved","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a29701fcd6925a9da43cc3a1fedb9b9365f2f3a","unresolved":true,"context_lines":[{"line_number":1262,"context_line":"            raise webob.exc.HTTPNotFound(e.message)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if (status_attr \u003d\u003d \u0027replica_state\u0027 and"},{"line_number":1265,"context_line":"                resource[\u0027replica_state\u0027] \u003d\u003d constants.REPLICA_STATE_ACTIVE):"},{"line_number":1266,"context_line":"            msg \u003d _(\"Cannot reset replica_state of active replica\")"},{"line_number":1267,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1268,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1471e62c_55b3d3f7","line":1265,"range":{"start_line":1265,"start_character":16,"end_line":1265,"end_character":41},"in_reply_to":"49ee2893_30981d5d","updated":"2024-03-07 19:05:23.000000000","message":"please address this comment","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a29701fcd6925a9da43cc3a1fedb9b9365f2f3a","unresolved":true,"context_lines":[{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if (status_attr \u003d\u003d \u0027replica_state\u0027 and"},{"line_number":1265,"context_line":"                resource[\u0027replica_state\u0027] \u003d\u003d constants.REPLICA_STATE_ACTIVE):"},{"line_number":1266,"context_line":"            msg \u003d _(\"Cannot reset replica_state of active replica\")"},{"line_number":1267,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1268,"context_line":"        try:"},{"line_number":1269,"context_line":"            policy.check_policy(context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7cdb8c9b_76815c6f","line":1266,"range":{"start_line":1266,"start_character":51,"end_line":1266,"end_character":57},"updated":"2024-03-07 19:05:23.000000000","message":"nit: an active","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if (status_attr \u003d\u003d \u0027replica_state\u0027 and"},{"line_number":1265,"context_line":"                resource[\u0027replica_state\u0027] \u003d\u003d constants.REPLICA_STATE_ACTIVE):"},{"line_number":1266,"context_line":"            msg \u003d _(\"Cannot reset replica_state of active replica\")"},{"line_number":1267,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1268,"context_line":"        try:"},{"line_number":1269,"context_line":"            policy.check_policy(context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"db10a8b0_90fb7e4c","line":1266,"range":{"start_line":1266,"start_character":51,"end_line":1266,"end_character":57},"in_reply_to":"7cdb8c9b_76815c6f","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"b4f51589e1581014c7b0f4193827c2e29fe814cf","unresolved":true,"context_lines":[{"line_number":1262,"context_line":"            raise webob.exc.HTTPNotFound(e.message)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if (status_attr \u003d\u003d \u0027replica_state\u0027 and"},{"line_number":1265,"context_line":"                resource.get(\u0027replica_state\u0027) \u003d\u003d constants.REPLICA_STATE_ACTIVE):"},{"line_number":1266,"context_line":"            msg \u003d _(\"Cannot reset replica_state of an active replica\")"},{"line_number":1267,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1268,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"72ca219a_8291efc5","line":1265,"in_reply_to":"494a88ea_891f6fa8","updated":"2024-03-08 12:11:27.000000000","message":"\u003e pep8: E501 line too long (81 \u003e 79 characters)\n\nTo help you in fixing this type of error, you can run `tox -e pep8`.\nThen look at your terminal, the tox command would output the line too long error with the file name and the line where it occurs. You can fix it before committing the changes","commit_id":"d19b3da3e75f0624447d3c120fc6cf0d359459cc"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5e0298eb87452230771acbdaca16a850b0011fe2","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"            raise webob.exc.HTTPNotFound(e.message)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if (status_attr \u003d\u003d \u0027replica_state\u0027 and"},{"line_number":1265,"context_line":"                resource.get(\u0027replica_state\u0027) \u003d\u003d constants.REPLICA_STATE_ACTIVE):"},{"line_number":1266,"context_line":"            msg \u003d _(\"Cannot reset replica_state of an active replica\")"},{"line_number":1267,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":1268,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c10f359b_89688104","line":1265,"in_reply_to":"72ca219a_8291efc5","updated":"2024-03-08 20:18:58.000000000","message":"Got it. Thanks for the tip.","commit_id":"d19b3da3e75f0624447d3c120fc6cf0d359459cc"}],"manila/tests/api/openstack/test_wsgi.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5fd99c10e3cb4b8e10c8dfa163ea1b12191c446","unresolved":true,"context_lines":[{"line_number":1023,"context_line":"            self.assertRaises(webob.exc.HTTPForbidden,"},{"line_number":1024,"context_line":"                              self.controller.fake_action_2, req)"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"class TestResetStatusMethod(unittest.TestCase):"},{"line_number":1027,"context_line":"    def test_reset_status_allowed(self):"},{"line_number":1028,"context_line":"        class Controller(object):"},{"line_number":1029,"context_line":"            def index(self, req, pants\u003dNone):"},{"line_number":1030,"context_line":"                return pants"},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"        controller \u003d Controller()"},{"line_number":1033,"context_line":"        resource \u003d wsgi.Resource(controller)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        body \u003d {\u0027status_attr\u0027: \u0027replica_state\u0027}"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"        try:"},{"line_number":1038,"context_line":"            response \u003d resource._reset_status(req\u003dNone, id\u003d1, body\u003dbody, status_attr\u003d\u0027replica_state\u0027)"},{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"            self.assertEqual(response.status_int, exc.HTTP_ACCEPTED.code)"},{"line_number":1041,"context_line":"        except exc.HTTPException as e:"},{"line_number":1042,"context_line":"            self.fail(f\"Unexpected exception: {e}\")"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    def test_reset_status_disallowed(self):"},{"line_number":1045,"context_line":"        class Controller(object):"},{"line_number":1046,"context_line":"            def index(self, req, pants\u003dNone):"},{"line_number":1047,"context_line":"                return pants"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        controller \u003d Controller()"},{"line_number":1050,"context_line":"        resource \u003d wsgi.Resource(controller)"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        body \u003d {\u0027status_attr\u0027: \u0027replica_state\u0027}"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        with self.assertRaises(exc.HTTPBadRequest) as cm:"},{"line_number":1055,"context_line":"            resource._reset_status(req\u003dNone, id\u003d1, body\u003dbody, status_attr\u003d\u0027replica_state\u0027)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"        self.assertIn(\"Cannot reset replica_state of active replica\", str(cm.exception))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ab5e8153_06c399b4","line":1057,"range":{"start_line":1026,"start_character":0,"end_line":1057,"end_character":88},"updated":"2023-10-25 23:56:10.000000000","message":"this is a good attempt; but the code won\u0027t work.. i can see your thought process though.. \n\nThere are some existing unit test cases for resetting the replica state:\n\nhttps://github.com/openstack/manila/blob/5d5ece51eac9fed78373d1a43f24a6112765df93/manila/tests/api/v2/test_share_replicas.py#L812-L823\n\nI\u0027d suggest reading through that test case, understanding it and basing your test on that..","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"},{"author":{"_account_id":36480,"name":"Gray Lutalo","display_name":"gray","email":"jogareko@gmail.com","username":"gray"},"change_message_id":"49f50aa17b7538a3ae2b255c39b1ae5951571a90","unresolved":false,"context_lines":[{"line_number":1023,"context_line":"            self.assertRaises(webob.exc.HTTPForbidden,"},{"line_number":1024,"context_line":"                              self.controller.fake_action_2, req)"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"class TestResetStatusMethod(unittest.TestCase):"},{"line_number":1027,"context_line":"    def test_reset_status_allowed(self):"},{"line_number":1028,"context_line":"        class Controller(object):"},{"line_number":1029,"context_line":"            def index(self, req, pants\u003dNone):"},{"line_number":1030,"context_line":"                return pants"},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"        controller \u003d Controller()"},{"line_number":1033,"context_line":"        resource \u003d wsgi.Resource(controller)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        body \u003d {\u0027status_attr\u0027: \u0027replica_state\u0027}"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"        try:"},{"line_number":1038,"context_line":"            response \u003d resource._reset_status(req\u003dNone, id\u003d1, body\u003dbody, status_attr\u003d\u0027replica_state\u0027)"},{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"            self.assertEqual(response.status_int, exc.HTTP_ACCEPTED.code)"},{"line_number":1041,"context_line":"        except exc.HTTPException as e:"},{"line_number":1042,"context_line":"            self.fail(f\"Unexpected exception: {e}\")"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    def test_reset_status_disallowed(self):"},{"line_number":1045,"context_line":"        class Controller(object):"},{"line_number":1046,"context_line":"            def index(self, req, pants\u003dNone):"},{"line_number":1047,"context_line":"                return pants"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        controller \u003d Controller()"},{"line_number":1050,"context_line":"        resource \u003d wsgi.Resource(controller)"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        body \u003d {\u0027status_attr\u0027: \u0027replica_state\u0027}"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        with self.assertRaises(exc.HTTPBadRequest) as cm:"},{"line_number":1055,"context_line":"            resource._reset_status(req\u003dNone, id\u003d1, body\u003dbody, status_attr\u003d\u0027replica_state\u0027)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"        self.assertIn(\"Cannot reset replica_state of active replica\", str(cm.exception))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3dfba572_f35f0424","line":1057,"range":{"start_line":1026,"start_character":0,"end_line":1057,"end_character":88},"in_reply_to":"ab5e8153_06c399b4","updated":"2023-10-29 08:20:03.000000000","message":"I have changed the testing logic.  Kindly check it out to see if it makes more sense now","commit_id":"26a60021565b74bdbc560b64a48acde6ae98a2d5"}],"manila/tests/api/v2/test_share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"712d60730f37c9a9e2233dbb092853db303a626c","unresolved":true,"context_lines":[{"line_number":823,"context_line":"                           valid_status\u003dvalid_status, body\u003dbody)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":826,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":827,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_ACTIVE}}"},{"line_number":828,"context_line":"        replica, action_req \u003d self._create_replica_get_req()"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6ae03b2b_8bf198b3","line":827,"range":{"start_line":826,"start_character":0,"end_line":827,"end_character":61},"updated":"2023-10-31 18:21:04.000000000","message":"a good test \"negative\" test case would be to attempt to do the destructive operation, and see your code fix in action.. so i suggest setting the \"replica_state\" you intend to set to what\u0027s described in the bug: constants.REPLICA_STATE_OUT_OF_SYNC. \n\n\nAlso, please use proper formatting for the dict: https://docs.openstack.org/hacking/latest/user/hacking.html#dictionaries-lists\n\n```\n body \u003d {\n     \u0027reset_replica_state\u0027: {\n            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC,\n     }\n }\n```","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":823,"context_line":"                           valid_status\u003dvalid_status, body\u003dbody)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":826,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":827,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_ACTIVE}}"},{"line_number":828,"context_line":"        replica, action_req \u003d self._create_replica_get_req()"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"8b437a53_84e75c6f","line":827,"range":{"start_line":826,"start_character":0,"end_line":827,"end_character":61},"in_reply_to":"6ae03b2b_8bf198b3","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"712d60730f37c9a9e2233dbb092853db303a626c","unresolved":true,"context_lines":[{"line_number":825,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":826,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":827,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_ACTIVE}}"},{"line_number":828,"context_line":"        replica, action_req \u003d self._create_replica_get_req()"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        try:"},{"line_number":831,"context_line":"            self._reset_status(self.admin_context, replica, action_req,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a6845efe_a37ad196","line":828,"range":{"start_line":828,"start_character":59,"end_line":828,"end_character":60},"updated":"2023-10-31 18:21:04.000000000","message":"You\u0027ll need the replica to initially have an \"active\" state:\n\n```\nself._create_replica_get_req(replica_state\u003dconstants.REPLICA_STATE_ACTIVE)\n```","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":825,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":826,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":827,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_ACTIVE}}"},{"line_number":828,"context_line":"        replica, action_req \u003d self._create_replica_get_req()"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        try:"},{"line_number":831,"context_line":"            self._reset_status(self.admin_context, replica, action_req,"}],"source_content_type":"text/x-python","patch_set":6,"id":"25611a84_454eaa3a","line":828,"range":{"start_line":828,"start_character":59,"end_line":828,"end_character":60},"in_reply_to":"a6845efe_a37ad196","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"712d60730f37c9a9e2233dbb092853db303a626c","unresolved":true,"context_lines":[{"line_number":827,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_ACTIVE}}"},{"line_number":828,"context_line":"        replica, action_req \u003d self._create_replica_get_req()"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        try:"},{"line_number":831,"context_line":"            self._reset_status(self.admin_context, replica, action_req,"},{"line_number":832,"context_line":"                               status_attr\u003d\u0027replica_state\u0027, valid_status\u003dconstants.REPLICA_STATE_ACTIVE, body\u003dbody)"},{"line_number":833,"context_line":"        except exc.HTTPBadRequest as e:"},{"line_number":834,"context_line":"            self.assertIn("},{"line_number":835,"context_line":"                \"Cannot reset replica_state of active replica\", str(e))"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    @ddt.data("},{"line_number":838,"context_line":"        {\u0027os-reset_replica_state\u0027: {\u0027x-replica_state\u0027: \u0027bad\u0027}},"}],"source_content_type":"text/x-python","patch_set":6,"id":"ef8d3f4e_2e6bf1b8","line":835,"range":{"start_line":830,"start_character":8,"end_line":835,"end_character":71},"updated":"2023-10-31 18:21:04.000000000","message":"please see _reset_status, there\u0027s a way to handle exceptions and assert a proper error code.. so no need to try..except here.. \n\n\n```\n  self._reset_status(self.admin_context, replica, action_req,\n                     valid_code\u003d400, status_attr\u003d\u0027replica_state\u0027,\n                     valid_status\u003dconstants.REPLICA_STATE_ACTIVE,\n                     body\u003dbody)\n```","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":827,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_ACTIVE}}"},{"line_number":828,"context_line":"        replica, action_req \u003d self._create_replica_get_req()"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        try:"},{"line_number":831,"context_line":"            self._reset_status(self.admin_context, replica, action_req,"},{"line_number":832,"context_line":"                               status_attr\u003d\u0027replica_state\u0027, valid_status\u003dconstants.REPLICA_STATE_ACTIVE, body\u003dbody)"},{"line_number":833,"context_line":"        except exc.HTTPBadRequest as e:"},{"line_number":834,"context_line":"            self.assertIn("},{"line_number":835,"context_line":"                \"Cannot reset replica_state of active replica\", str(e))"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    @ddt.data("},{"line_number":838,"context_line":"        {\u0027os-reset_replica_state\u0027: {\u0027x-replica_state\u0027: \u0027bad\u0027}},"}],"source_content_type":"text/x-python","patch_set":6,"id":"d937dbac_955749af","line":835,"range":{"start_line":830,"start_character":8,"end_line":835,"end_character":71},"in_reply_to":"ef8d3f4e_2e6bf1b8","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"41395c3aea1191db43f7847f74953e6f265fea84"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"6c00355d0e5b942d09f2bff6185ac0f90105bf34","unresolved":true,"context_lines":[{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        try:"},{"line_number":831,"context_line":"            self._reset_status(self.admin_context, replica, action_req,"},{"line_number":832,"context_line":"                               status_attr\u003d\u0027replica_state\u0027, valid_status\u003dconstants.REPLICA_STATE_ACTIVE, body\u003dbody)"},{"line_number":833,"context_line":"        except exc.HTTPBadRequest as e:"},{"line_number":834,"context_line":"            self.assertIn("},{"line_number":835,"context_line":"                \"Cannot reset replica_state of active replica\", str(e))"}],"source_content_type":"text/x-python","patch_set":7,"id":"8244e13c_78c17a1d","line":832,"updated":"2024-03-07 11:59:29.000000000","message":"Break up lines to be less than 80 characters","commit_id":"587e2c4ab9dd41e3e760b820a37567fdc06e71e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        try:"},{"line_number":831,"context_line":"            self._reset_status(self.admin_context, replica, action_req,"},{"line_number":832,"context_line":"                               status_attr\u003d\u0027replica_state\u0027, valid_status\u003dconstants.REPLICA_STATE_ACTIVE, body\u003dbody)"},{"line_number":833,"context_line":"        except exc.HTTPBadRequest as e:"},{"line_number":834,"context_line":"            self.assertIn("},{"line_number":835,"context_line":"                \"Cannot reset replica_state of active replica\", str(e))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9036c73f_464aca79","line":832,"in_reply_to":"8244e13c_78c17a1d","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"587e2c4ab9dd41e3e760b820a37567fdc06e71e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a29701fcd6925a9da43cc3a1fedb9b9365f2f3a","unresolved":true,"context_lines":[{"line_number":824,"context_line":"                           valid_status\u003dvalid_status, body\u003dbody)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC}}"},{"line_number":829,"context_line":"        replica, action_req \u003d self._create_replica_get_req("},{"line_number":830,"context_line":"                valid_status\u003dconstants.REPLICA_STATE_ACTIVE"},{"line_number":831,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":8,"id":"47e1edb3_432c7615","line":828,"range":{"start_line":827,"start_character":8,"end_line":828,"end_character":66},"updated":"2024-03-07 19:05:23.000000000","message":"please fix the formatting here:\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#dictionaries-lists\n\n```\n body \u003d {\n     \u0027reset_replica_state\u0027: {\n            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC,\n     }\n }\n ```","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                           valid_status\u003dvalid_status, body\u003dbody)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC}}"},{"line_number":829,"context_line":"        replica, action_req \u003d self._create_replica_get_req("},{"line_number":830,"context_line":"                valid_status\u003dconstants.REPLICA_STATE_ACTIVE"},{"line_number":831,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":8,"id":"962e9d0d_18a50fdf","line":828,"range":{"start_line":827,"start_character":8,"end_line":828,"end_character":66},"in_reply_to":"47e1edb3_432c7615","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a29701fcd6925a9da43cc3a1fedb9b9365f2f3a","unresolved":true,"context_lines":[{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC}}"},{"line_number":829,"context_line":"        replica, action_req \u003d self._create_replica_get_req("},{"line_number":830,"context_line":"                valid_status\u003dconstants.REPLICA_STATE_ACTIVE"},{"line_number":831,"context_line":"                )"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        self._reset_status(self.admin_context, replica, action_req,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9bd75d77_05488bbf","line":830,"range":{"start_line":830,"start_character":16,"end_line":830,"end_character":28},"updated":"2024-03-07 19:05:23.000000000","message":"also there\u0027s no \"valid_status\" attribute.. you mean to set \"replica_state\"","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC}}"},{"line_number":829,"context_line":"        replica, action_req \u003d self._create_replica_get_req("},{"line_number":830,"context_line":"                valid_status\u003dconstants.REPLICA_STATE_ACTIVE"},{"line_number":831,"context_line":"                )"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        self._reset_status(self.admin_context, replica, action_req,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a14c8d16_31f405d6","line":830,"in_reply_to":"00a46d89_c291404e","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a29701fcd6925a9da43cc3a1fedb9b9365f2f3a","unresolved":true,"context_lines":[{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC}}"},{"line_number":829,"context_line":"        replica, action_req \u003d self._create_replica_get_req("},{"line_number":830,"context_line":"                valid_status\u003dconstants.REPLICA_STATE_ACTIVE"},{"line_number":831,"context_line":"                )"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        self._reset_status(self.admin_context, replica, action_req,"}],"source_content_type":"text/x-python","patch_set":8,"id":"00a46d89_c291404e","line":830,"in_reply_to":"63882462_3d6f68e0","updated":"2024-03-07 19:05:23.000000000","message":"\u003e pep8: E126 continuation line over-indented for hanging indent\n\nPlease fix.","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC}}"},{"line_number":829,"context_line":"        replica, action_req \u003d self._create_replica_get_req("},{"line_number":830,"context_line":"                valid_status\u003dconstants.REPLICA_STATE_ACTIVE"},{"line_number":831,"context_line":"                )"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        self._reset_status(self.admin_context, replica, action_req,"}],"source_content_type":"text/x-python","patch_set":8,"id":"cac6e0de_3eba9365","line":830,"range":{"start_line":830,"start_character":16,"end_line":830,"end_character":28},"in_reply_to":"9bd75d77_05488bbf","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a29701fcd6925a9da43cc3a1fedb9b9365f2f3a","unresolved":true,"context_lines":[{"line_number":834,"context_line":"                           status_attr\u003d\u0027replica_state\u0027,"},{"line_number":835,"context_line":"                           valid_status\u003dconstants.REPLICA_STATE_OUT_OF_SYNC,"},{"line_number":836,"context_line":"                           body\u003dbody"},{"line_number":837,"context_line":"                           )"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    @ddt.data("},{"line_number":840,"context_line":"        {\u0027os-reset_replica_state\u0027: {\u0027x-replica_state\u0027: \u0027bad\u0027}},"}],"source_content_type":"text/x-python","patch_set":8,"id":"442904c5_d055a83e","line":837,"range":{"start_line":837,"start_character":27,"end_line":837,"end_character":28},"updated":"2024-03-07 19:05:23.000000000","message":"nit: move closing paranthesis to previous line","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":false,"context_lines":[{"line_number":834,"context_line":"                           status_attr\u003d\u0027replica_state\u0027,"},{"line_number":835,"context_line":"                           valid_status\u003dconstants.REPLICA_STATE_OUT_OF_SYNC,"},{"line_number":836,"context_line":"                           body\u003dbody"},{"line_number":837,"context_line":"                           )"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    @ddt.data("},{"line_number":840,"context_line":"        {\u0027os-reset_replica_state\u0027: {\u0027x-replica_state\u0027: \u0027bad\u0027}},"}],"source_content_type":"text/x-python","patch_set":8,"id":"18835953_114b901d","line":837,"range":{"start_line":837,"start_character":27,"end_line":837,"end_character":28},"in_reply_to":"442904c5_d055a83e","updated":"2024-03-08 20:30:31.000000000","message":"resolved","commit_id":"6533938906c9a62f9f6a7dccb74a1e7c82c0ed75"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c33621b8bd3cd5c1b5b61f97ee59ba4effcc59b3","unresolved":true,"context_lines":[{"line_number":824,"context_line":"                           valid_status\u003dvalid_status, body\u003dbody)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC"},{"line_number":829,"context_line":"            }"},{"line_number":830,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":12,"id":"c1df3391_1ceac830","line":827,"range":{"start_line":827,"start_character":15,"end_line":827,"end_character":40},"updated":"2024-03-08 19:27:06.000000000","message":"this needs to go into the next line:\n\nexactly like this:\n\n```\nbody \u003d {\n     \u0027reset_replica_state\u0027: {\n            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC,\n     }\n}\n```\nPlease see https://docs.openstack.org/hacking/latest/user/hacking.html#dictionaries-lists\n\nfor formatting guidelines","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5e0298eb87452230771acbdaca16a850b0011fe2","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                           valid_status\u003dvalid_status, body\u003dbody)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC"},{"line_number":829,"context_line":"            }"},{"line_number":830,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":12,"id":"34346688_9efa7007","line":827,"range":{"start_line":827,"start_character":15,"end_line":827,"end_character":40},"in_reply_to":"c1df3391_1ceac830","updated":"2024-03-08 20:18:58.000000000","message":"Done","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c33621b8bd3cd5c1b5b61f97ee59ba4effcc59b3","unresolved":true,"context_lines":[{"line_number":825,"context_line":""},{"line_number":826,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC"},{"line_number":829,"context_line":"            }"},{"line_number":830,"context_line":"        }"},{"line_number":831,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"35178f1d_2e382a4b","line":828,"updated":"2024-03-08 19:27:06.000000000","message":"missing a trailing comma","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5e0298eb87452230771acbdaca16a850b0011fe2","unresolved":false,"context_lines":[{"line_number":825,"context_line":""},{"line_number":826,"context_line":"    def test_reset_replica_with_active_state(self):"},{"line_number":827,"context_line":"        body \u003d {\u0027reset_replica_state\u0027: {"},{"line_number":828,"context_line":"            \u0027replica_state\u0027: constants.REPLICA_STATE_OUT_OF_SYNC"},{"line_number":829,"context_line":"            }"},{"line_number":830,"context_line":"        }"},{"line_number":831,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"00bbc70e_ee2127c6","line":828,"in_reply_to":"35178f1d_2e382a4b","updated":"2024-03-08 20:18:58.000000000","message":"Done","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"}],"releasenotes/notes/bug-2015328-add_negative_test_for_reset_replica_state-a3d4511ff1352d68.yaml":[{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"77fbd3f0ce2704736bc2fa5b24e35fe0feb9fc4d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add Negative test checking if \"reset_state\" function resets a replica with an active state."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7eabcbd8_d0753c49","line":4,"updated":"2024-03-08 16:33:17.000000000","message":"Hey Solly, nice effort. I think it is more appropriate to write the release note in this format Launchpad bug \u003claunchpad_bug_id\u003e \u003chttps://bugs.launchpad.net/manila/+bug/899320\u003e has been fixed for Add Negative test checking if \"reset_state\" function resets a replica with an active state.","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5e0298eb87452230771acbdaca16a850b0011fe2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add Negative test checking if \"reset_state\" function resets a replica with an active state."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"adfd6925_0552261c","line":4,"in_reply_to":"09a016d6_8d2be7dd","updated":"2024-03-08 20:18:58.000000000","message":"Done","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c33621b8bd3cd5c1b5b61f97ee59ba4effcc59b3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add Negative test checking if \"reset_state\" function resets a replica with an active state."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"09a016d6_8d2be7dd","line":4,"in_reply_to":"7eabcbd8_d0753c49","updated":"2024-03-08 19:27:06.000000000","message":"Thanks Christian; \n\na couple of things:\n\n\n1) The file name - could you please rename this file to only use hyphens?\n2) The release note must be written for what the effect is on users/deployers.. not for the unit test that you added. Unit tests are for developers like you and me, they are typically not included in packaged versions of this software when it is used in production environments\n\nSo, please fix the note, and the file name to something more appropriate\n\n  \"bug-2015328-disallow-reset-replica-state-on-active-replicas-a3d4511ff1352d68.yaml\"\n  \n```  \n---\nfixes:\n  - |\n    The \"replica_state\" attribute of \"active\" replicas cannot be modified. \n    Please see `Launchpad bug 2015328 \u003chttps://launchpad.net/bugs/2015328\u003e`_\n    for more details.\n```","commit_id":"222adc48f083cc590a6e7e6183344568348248ed"}],"releasenotes/notes/bug-2015328-disallow-reset-replica-state-on-active-replicas-a3d4511ff1352d68.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7f1ea4e318daf0b2c2a2df482d5d9786e8a90d1d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The \"replica_state\" attribute of \"active\" replicas cannot be modified."},{"line_number":5,"context_line":"    Please see `Launchpad bug 2015328 \u003chttps://launchpad.net/bugs/2015328\u003e`"},{"line_number":6,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3a5ecf14_bd4120a5","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":75},"updated":"2024-03-08 20:30:31.000000000","message":"the syntax here has to be:\n\n```\n `Launchpad bug 2015328 \u003chttps://launchpad.net/bugs/2015328\u003e`_\n\n```\n\nThat\u0027s how this becomes a link. Please see the o/p here: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_14c/899320/13/check/build-openstack-releasenotes/14cb29f/docs/unreleased.html\n\nPlease fix it if you push up another patch","commit_id":"b7ad6c3e90a13b8e1c9641c15b82c02bb9d009a5"}]}