)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d9308e2e8be6ea8cfffb7da1d479e5e9df5e9b3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     melakualehegn \u003cmelakualehegn34@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 03:11:03 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"change status and error when /shares api fails to handle share_type in request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8d4b30daae2fe8c88c30d93d402bf2e5a558f804"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1492a595_e866443f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":78},"updated":"2023-10-26 02:19:48.000000000","message":"this is a good/complete commit message; but we\u0027ve some conventions.. \n\nsome things to remember:\n\n- keep the first line of the commit message under 50 characters \n- you can add anymore detail into a second paragraph after a blank line\n- you must use a commit message tag that states that you\u0027re closing a bug... we have automation here that updates bug states and such, that relies on that tag.. so:\n\n  \"Closes-Bug: #\u003cBUG NUMBER\u003e\"\n  \nshould appear in its own line in the commit message\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"aaf315bae8e80092c896fb69dd909e589893ade6"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"b05ff0b6735041876a0f7990e73281aa06f70899","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     melakualehegn \u003cmelakualehegn34@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 03:11:03 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"change status and error when /shares api fails to handle share_type in request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8d4b30daae2fe8c88c30d93d402bf2e5a558f804"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a929bc38_ebf6894d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":78},"in_reply_to":"1492a595_e866443f","updated":"2023-10-27 18:53:26.000000000","message":"Thanks Goutham, Will update the commit message as requested","commit_id":"aaf315bae8e80092c896fb69dd909e589893ade6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c69fcbb4b3198519333b70817e38d11836e3e055","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     melakualehegn \u003cmelakualehegn34@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-10-26 03:11:03 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"change status and error when /shares api fails to handle share_type in request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8d4b30daae2fe8c88c30d93d402bf2e5a558f804"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"85cb669a_15583b06","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":78},"in_reply_to":"a929bc38_ebf6894d","updated":"2023-10-27 22:13:35.000000000","message":"this was resolved.","commit_id":"aaf315bae8e80092c896fb69dd909e589893ade6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5403945237c357654af55baeb17012122070bea","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-10-27 03:59:10 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change status and error handling for /shares API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change modifies the status and error handling logic of the /shares API when it fails to handle the specified share_type in the request. The updated logic ensures that appropriate responses are generated to handle this scenario effectively."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The modifications include updating the error messages and status codes returned by the API to provide clearer information to the users. Additionally, the internal error handling mechanisms have been enhanced to improve error reporting and troubleshooting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1944478"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ad51ac4_b08bd142","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":255},"updated":"2023-10-27 06:01:55.000000000","message":"please wrap these at 72 characters; \n\ndo read https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"908c8758139fd282cc5a1320b6d1b1a29b957c12"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"b05ff0b6735041876a0f7990e73281aa06f70899","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-10-27 03:59:10 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change status and error handling for /shares API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change modifies the status and error handling logic of the /shares API when it fails to handle the specified share_type in the request. The updated logic ensures that appropriate responses are generated to handle this scenario effectively."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The modifications include updating the error messages and status codes returned by the API to provide clearer information to the users. Additionally, the internal error handling mechanisms have been enhanced to improve error reporting and troubleshooting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1944478"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"85176529_6934075a","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":255},"in_reply_to":"1ad51ac4_b08bd142","updated":"2023-10-27 18:53:26.000000000","message":"I have wrapped the commit messages","commit_id":"908c8758139fd282cc5a1320b6d1b1a29b957c12"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c69fcbb4b3198519333b70817e38d11836e3e055","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-10-27 03:59:10 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change status and error handling for /shares API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change modifies the status and error handling logic of the /shares API when it fails to handle the specified share_type in the request. The updated logic ensures that appropriate responses are generated to handle this scenario effectively."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The modifications include updating the error messages and status codes returned by the API to provide clearer information to the users. Additionally, the internal error handling mechanisms have been enhanced to improve error reporting and troubleshooting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1944478"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fbaf861d_c210e142","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":255},"in_reply_to":"85176529_6934075a","updated":"2023-10-27 22:13:35.000000000","message":"This was resolved.","commit_id":"908c8758139fd282cc5a1320b6d1b1a29b957c12"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d9308e2e8be6ea8cfffb7da1d479e5e9df5e9b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"400070b9_35e39dcf","updated":"2023-10-26 02:19:48.000000000","message":"Thank you for your code submission Melaku.. \n\ni\u0027ve some comments inline for you to improve this.. \nI also recommend adding a unit test to cover the code that you\u0027re changing. \nAlso, please add a release note for this bugfix.. the procedure to include a release note is documented here: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"aaf315bae8e80092c896fb69dd909e589893ade6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5403945237c357654af55baeb17012122070bea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f1202ddd_af7ca309","updated":"2023-10-27 06:01:55.000000000","message":"Thanks; please \"resolve\" the comments you\u0027ve addressed; or respond to them.. \ni\u0027ve added a further comment about the commit message. Please fix it should you make another patch.","commit_id":"908c8758139fd282cc5a1320b6d1b1a29b957c12"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"90be8b4f1634b9ab7d37ee950fdbf3b27f09dfb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7cbf8a7c_d3aa2b90","updated":"2023-10-27 20:11:30.000000000","message":"LGTM, thanks Melaku!","commit_id":"b24ef91f2c6e1e63c6bae8e52b778bba22ff15ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c69fcbb4b3198519333b70817e38d11836e3e055","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9737ddac_176d849a","updated":"2023-10-27 22:13:35.000000000","message":"Since this bug is present in stable releases of OpenStack Manila, we\u0027ll be backporting the bug fix to released branches: https://docs.openstack.org/project-team-guide/stable-branches.html\n\n\nMelaku: you\u0027ll notice the \"cherry-pick\" messages here.. please feel free to review the code submission to the older branches as they are made.","commit_id":"b24ef91f2c6e1e63c6bae8e52b778bba22ff15ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b00fb5cdc309caceeccc5af8ef0a5b92498edb88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"80c388ae_3ecae600","updated":"2023-10-27 18:11:22.000000000","message":"Thanks, LGTM\n\nPlease \"resolve\" the comments added that you have addressed with your changes.","commit_id":"b24ef91f2c6e1e63c6bae8e52b778bba22ff15ff"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d9308e2e8be6ea8cfffb7da1d479e5e9df5e9b3","unresolved":true,"context_lines":[{"line_number":397,"context_line":"                else:"},{"line_number":398,"context_line":"                    share_type \u003d share_types.get_share_type("},{"line_number":399,"context_line":"                        context, req_share_type)"},{"line_number":400,"context_line":"            except (exception.ShareTypeNotFound,"},{"line_number":401,"context_line":"                    exception.ShareTypeNotFoundByName)as e:"},{"line_number":402,"context_line":"                        if isinstance(e, exception.InvalidShareType):"},{"line_number":403,"context_line":"                            msg \u003d _(\"Invalid share type.\")"},{"line_number":404,"context_line":"                            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":405,"context_line":"                        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b64f5ad4_2e3b17a8","line":402,"range":{"start_line":400,"start_character":12,"end_line":402,"end_character":69},"updated":"2023-10-26 02:19:48.000000000","message":"this isn\u0027t going to be true; \n\n \"InvalidShareType\" isn\u0027t a subclass of either \"ShareTypeNotFound\" or \"ShareTypeNotFoundByName\"\n \n\nHere\u0027s an example of how multiple exceptions are handled: https://docs.python.org/3/tutorial/errors.html#handling-exceptions\nhttps://github.com/openstack/manila/blob/43de2e8fb5871f2ae73ba458f61e293ec093d7ef/manila/api/v1/share_metadata.py#L146-L154","commit_id":"aaf315bae8e80092c896fb69dd909e589893ade6"}],"manila/share/share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d9308e2e8be6ea8cfffb7da1d479e5e9df5e9b3","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        msg \u003d _(\"name cannot be None\")"},{"line_number":203,"context_line":"        raise exception.InvalidShareType(reason\u003dmsg)"},{"line_number":204,"context_line":"    if not isinstance(name, str):"},{"line_number":205,"context_line":"        msg \u003d _(\"the share_type parameter was badly formatted\")"},{"line_number":206,"context_line":"        raise exc.InvalidShareType(reason\u003dmsg)"},{"line_number":207,"context_line":"    return db.share_type_get_by_name(context, name)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0cecd792_0451815a","line":205,"range":{"start_line":205,"start_character":21,"end_line":205,"end_character":41},"updated":"2023-10-26 02:19:48.000000000","message":"`share type\u0027s name parameter`","commit_id":"aaf315bae8e80092c896fb69dd909e589893ade6"}]}