)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d41801183080c542309c965cc9335b714da725dc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b84d66d8_3b69ae88","updated":"2023-10-28 14:27:35.000000000","message":"This should be squashed into the parent change.","commit_id":"b0e9172a9fc3ba88b8ead32b03e3f932175e9a36"}],"manila/api/v2/shares.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d41801183080c542309c965cc9335b714da725dc","unresolved":true,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        return data"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    # HTTP 500 raised by POST /shares API when failing to handle \"share_type\" in request  ##"},{"line_number":193,"context_line":"    @wsgi.Controller.api_version(\"2.65\")"},{"line_number":194,"context_line":"    def create(self, req, body):"},{"line_number":195,"context_line":"        if not self.is_valid_body(body, \u0027share\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"94af2353_e0a85e23","line":192,"in_reply_to":"4d7892ca_e925af1b","updated":"2023-10-28 14:27:35.000000000","message":"\u003e pep8: E501 line too long (92 \u003e 79 characters)\n\nPlease fix. Also the I\u0027m not too sure describing the specific handling is a good idea.","commit_id":"b0e9172a9fc3ba88b8ead32b03e3f932175e9a36"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d41801183080c542309c965cc9335b714da725dc","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        share_type \u003d share.get(\u0027share_type\u0027)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if not isinstance(share_type, str):"},{"line_number":202,"context_line":"            raise exc.HTTPBadRequest(explanation\u003d_(\"Invalid format for \u0027share_type\u0027 parameter. Expected a string.\"))"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        scheduler_hints \u003d share.pop(\u0027scheduler_hints\u0027, None)"},{"line_number":205,"context_line":"        if req.api_version_request \u003c api_version.APIVersionRequest(\"2.67\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c98f64a0_c1d6acc2","line":202,"in_reply_to":"3f37d74b_448b8b60","updated":"2023-10-28 14:27:35.000000000","message":"\u003e pep8: E501 line too long (116 \u003e 79 characters)\n\nPlease fix.","commit_id":"b0e9172a9fc3ba88b8ead32b03e3f932175e9a36"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d41801183080c542309c965cc9335b714da725dc","unresolved":true,"context_lines":[{"line_number":211,"context_line":"                            check_availability_zones_extra_spec\u003dTrue,"},{"line_number":212,"context_line":"                            scheduler_hints\u003dscheduler_hints)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def is_valid_body(self, body, entity_name):"},{"line_number":215,"context_line":"        if body is None or entity_name not in body:"},{"line_number":216,"context_line":"            return False"},{"line_number":217,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"424a063d_9ebf9a51","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":21},"updated":"2023-10-28 14:27:35.000000000","message":"this is not used.","commit_id":"b0e9172a9fc3ba88b8ead32b03e3f932175e9a36"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"32296eb580c751df7e6fd4ebfbbeaca5ab9e6b98","unresolved":true,"context_lines":[{"line_number":211,"context_line":"                            check_availability_zones_extra_spec\u003dTrue,"},{"line_number":212,"context_line":"                            scheduler_hints\u003dscheduler_hints)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def is_valid_body(self, body, entity_name):"},{"line_number":215,"context_line":"        if body is None or entity_name not in body:"},{"line_number":216,"context_line":"            return False"},{"line_number":217,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"e94dee34_5b0bfcca","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":21},"in_reply_to":"424a063d_9ebf9a51","updated":"2023-10-28 14:30:51.000000000","message":"Ignore my previous comment, but I didn\u0027t get what is the specific reason to override this.","commit_id":"b0e9172a9fc3ba88b8ead32b03e3f932175e9a36"}]}