)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ea2c37bb6d297e79a9d98fd94f9726bcd57795b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"manager services are down or are still"},{"line_number":12,"context_line":"initializing"},{"line_number":13,"context_line":"removed a duplicate test: test_create_share_non_admin"},{"line_number":14,"context_line":"Closes-Bug: #1886690"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I168564a5b054d17762ad668ebbe4f5e7b562197b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"adb05b8d_88e2c4d1","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"updated":"2024-01-12 19:35:44.000000000","message":"nit: this is typically added in the same paragraph as the \"Change-Id\"... i.e., a blank line needs to be added above","commit_id":"545cca221367fe703b2602302752344ec83da8e8"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"d5c7c7d7da709f8f36b89308e5e554e919e094d9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"manager services are down or are still"},{"line_number":12,"context_line":"initializing"},{"line_number":13,"context_line":"removed a duplicate test: test_create_share_non_admin"},{"line_number":14,"context_line":"Closes-Bug: #1886690"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I168564a5b054d17762ad668ebbe4f5e7b562197b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"64e8f643_a55da4c7","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"in_reply_to":"adb05b8d_88e2c4d1","updated":"2024-01-12 23:55:04.000000000","message":"Thanks, I will update as requested","commit_id":"545cca221367fe703b2602302752344ec83da8e8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0d86a4532dcfb4a3d011144e7d5ea57045472ad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c8791dd_6bab3b85","updated":"2023-10-27 23:29:45.000000000","message":"Hey Melaku, \n\nThanks for attempting this fix; the problem with this bug isn\u0027t that the message was incorrect... it is that there is no error handling around share backend services not being ready.. \n\nTake a look at this block of code: \n\nhttps://github.com/openstack/manila/blob/281788715b618384168e69b1c1e5b17b10e37bb3/manila/scheduler/drivers/filter.py#L241-L254\n\n\nWe begin by making a dict \"hosts\" from all the known backend hosts on line 243 in the link above. The code should immediately be checking if that dict has any elements before proceeding to filter the hosts on lines 246-247. \n\nIf the \"hosts\" dict is empty prior to filtering, the code should bail out by raising a different exception that you can handle, and raise an appropriate user message..","commit_id":"03809eef39927380909a2c84914049b32018466a"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"044e24e1b931b0445fd809b3afc3a4960182272f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de300aa9_8d3b5db3","in_reply_to":"1c8791dd_6bab3b85","updated":"2023-10-29 20:14:25.000000000","message":"Hi Goutham,\n\nPlease Take a look at the changes I made. I\u0027ve added the check in the \"hosts\" dict and raised the necessary errors.","commit_id":"03809eef39927380909a2c84914049b32018466a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5bc1d9c64dd673d43f79188b0fdd1fabff901420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7182ca84_a42714f7","updated":"2023-10-31 18:33:46.000000000","message":"Thanks for updating this; and adding a release note.. i\u0027ve some more comments inline, please take a look","commit_id":"39722ffe73e107b220b7c8728b9f67ed5c4e3ec1"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"81ecef64eee185be9c9895577b11c63ac7ccad94","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b9ea68d9_0d479b7c","in_reply_to":"7182ca84_a42714f7","updated":"2023-11-07 22:52:03.000000000","message":"Hi Goutham, Thanks for the feedback. Working on the suggestions you mentioned.","commit_id":"39722ffe73e107b220b7c8728b9f67ed5c4e3ec1"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"d5c7c7d7da709f8f36b89308e5e554e919e094d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"127a3058_d7eb7c8d","in_reply_to":"b9ea68d9_0d479b7c","updated":"2024-01-12 23:55:04.000000000","message":"Thanks, added the suggestions in my latest patch","commit_id":"39722ffe73e107b220b7c8728b9f67ed5c4e3ec1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915a2b6cd7b4726b6b8c9b2d27d0c7740291cacb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"15230a25_8d8cac22","updated":"2023-11-08 22:44:57.000000000","message":"Thanks for the update, Melaku; please see comments for improvement inline","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"bb8c482f361ed7e37c9e242eef5ee0f8045313e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"04c17953_c3a9b989","in_reply_to":"15230a25_8d8cac22","updated":"2023-11-09 02:58:11.000000000","message":"Updated as requested, Please review Goutham. Thanks","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"38c917dfab8cff8ef79e268a822c37ba0bf93f95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c787f279_14c898c4","updated":"2023-11-09 05:50:54.000000000","message":"Hey Melaku; you\u0027ve not addressed all the comments; please resolve the comments individually (or did you forget to hit \"Reply\" and \"Submit\" after responding?)\n\nAlso, a bunch of tests are failing.. are you able to figure out what\u0027s going on?","commit_id":"7ebe8a789239c53540e8cc6d271c7fd699339d52"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"beb5180c45886b26b785e804825a766cf73fa6dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b8ed09f8_a22d04fe","in_reply_to":"c787f279_14c898c4","updated":"2023-11-10 22:46:28.000000000","message":"I haven\u0027t noticed the last two comment on my last check. I will work on them. As far as the unit tests, they were failing that I had to pass a parameter host for WillNotSchedule in raise exception.WillNotSchedule(msg), I resolved them by passing empty string for host.","commit_id":"7ebe8a789239c53540e8cc6d271c7fd699339d52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ea2c37bb6d297e79a9d98fd94f9726bcd57795b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff18daf2_700c480d","updated":"2024-01-12 19:35:44.000000000","message":"Thanks melaku... i have a couple more suggestions inline, could you please take a look? Also, as we discussed, please resolve all older comments...","commit_id":"545cca221367fe703b2602302752344ec83da8e8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"033973bf1166b3b5331a101708217d75b41673ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a6710591_f14879fc","updated":"2024-01-15 20:06:27.000000000","message":"Thanks Melaku; LGTM.. i\u0027ve a couple of minor comments inline that you can address if you make another patch.","commit_id":"2a35c65d1d613c1458a95b4c2e751340a785abf7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"79b37fbb762cc9f2f0d59e623f4d768c9d071a6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7318142c_1bdcf37c","updated":"2024-01-26 11:24:08.000000000","message":"Hi, Melaku! Thank you for working on the change. I believe we could use an enhancement to the message raised in the schedule. Please take a look at the suggestion inline :)","commit_id":"de6743f39695d623c29674529d54403fd3bdbfc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c82107f820026e7b40f5794ea2ecced912a504b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1dbd2aa4_1885a31d","updated":"2024-01-17 00:39:58.000000000","message":"Thanks Melaku! LGTM","commit_id":"de6743f39695d623c29674529d54403fd3bdbfc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6028a98e9cc90f7012eb0c3bbdb6fe2b49602804","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"32f34251_7455b043","updated":"2024-01-21 20:40:00.000000000","message":"recheck\n\ndocs job should pass now","commit_id":"de6743f39695d623c29674529d54403fd3bdbfc7"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"cc3dcbe2e0f5a5d0f1f203cdd0385cd9f3b50885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"96f008a7_c41ebb25","in_reply_to":"7318142c_1bdcf37c","updated":"2024-01-29 10:08:17.000000000","message":"Thanks for the review Carlos, I have added a follow up question","commit_id":"de6743f39695d623c29674529d54403fd3bdbfc7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b4d74d30e8e99a0c83f02981c9e6dcb1a7935cb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4b540cd8_53c24ff9","updated":"2024-01-30 08:56:32.000000000","message":"thanks for your change.","commit_id":"0f150cc3fc38a90a2591ae1044b781e24663404f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"afaa9fcc8f4bdbcb75a1dbd4f9418d92a1b601cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ef0f6576_4b09e8e1","updated":"2024-01-31 11:44:47.000000000","message":"LGTM, thank you Melaku! I\u0027m merging this, but please follow up with Goutham wrt his comment :)","commit_id":"ecda09a14d0b31169b275ed67a9088a131fbef12"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6fce09f4c259bb502dc0e0b0c69c74b6c7c0f65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"272adc23_36c22941","updated":"2024-01-30 23:43:43.000000000","message":"Thanks for the changes Melaku. I\u0027ve added a comment inline; please take a look if you make another patch","commit_id":"ecda09a14d0b31169b275ed67a9088a131fbef12"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"cf5cda30b29e6b9724508dbb7c514811c705d7c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"de9d09f0_ae3e64a9","updated":"2024-01-31 08:26:40.000000000","message":"recheck","commit_id":"ecda09a14d0b31169b275ed67a9088a131fbef12"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"832512268a5eacc6c231d51e99653f2352bcf325","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cfdb3be3_2dd3128a","in_reply_to":"ef0f6576_4b09e8e1","updated":"2024-02-01 21:43:59.000000000","message":"Thanks Carlos. I\u0027ll update with Goutham\u0027s comment.","commit_id":"ecda09a14d0b31169b275ed67a9088a131fbef12"}],"manila/message/message_field.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"033973bf1166b3b5331a101708217d75b41673ce","unresolved":true,"context_lines":[{"line_number":152,"context_line":"        \u0027028\u0027,"},{"line_number":153,"context_line":"        _(\"No storage could be allocated for this share \""},{"line_number":154,"context_line":"          \"request. Share back end services are not \""},{"line_number":155,"context_line":"          \"ready yet, trying again after a while may \""},{"line_number":156,"context_line":"          \"succeed. Contact your administrator in case \""},{"line_number":157,"context_line":"          \"retrying does not help.\"))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    ALL \u003d ("}],"source_content_type":"text/x-python","patch_set":9,"id":"562db3ba_8ac81b70","line":156,"range":{"start_line":155,"start_character":22,"end_line":156,"end_character":18},"updated":"2024-01-15 20:06:27.000000000","message":"this part of the message is grammatically incorrect and isn\u0027t necessary either. You can drop this since we\u0027re suggesting that the user retries through the next sentence.","commit_id":"2a35c65d1d613c1458a95b4c2e751340a785abf7"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"182df24f7182c0d52d309e40f7946c093ff8be7c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \u0027028\u0027,"},{"line_number":153,"context_line":"        _(\"No storage could be allocated for this share \""},{"line_number":154,"context_line":"          \"request. Share back end services are not \""},{"line_number":155,"context_line":"          \"ready yet, trying again after a while may \""},{"line_number":156,"context_line":"          \"succeed. Contact your administrator in case \""},{"line_number":157,"context_line":"          \"retrying does not help.\"))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    ALL \u003d ("}],"source_content_type":"text/x-python","patch_set":9,"id":"a0f84e4e_1f20f359","line":156,"range":{"start_line":155,"start_character":22,"end_line":156,"end_character":18},"in_reply_to":"562db3ba_8ac81b70","updated":"2024-01-17 00:21:17.000000000","message":"Thanks for pointing this out. I have sent another patch with the suggested updates.","commit_id":"2a35c65d1d613c1458a95b4c2e751340a785abf7"}],"manila/scheduler/drivers/filter.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5bc1d9c64dd673d43f79188b0fdd1fabff901420","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":257,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":258,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":259,"context_line":"            raise exception.NoValidHost(err\u003dmsg)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":262,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":3,"id":"fca1f168_a2039ca0","line":259,"range":{"start_line":259,"start_character":12,"end_line":259,"end_character":48},"updated":"2023-10-31 18:33:46.000000000","message":"the message handler interprets \"NoValidHost\" as a special exception...https://github.com/openstack/manila/blob/1c44d9946012e78be451e317a021085bea7a1c98/manila/message/message_field.py#L223-L229\n\nSince no \"filters\" have executed yet, perhaps raise this exception instead? https://github.com/openstack/manila/blob/1c44d9946012e78be451e317a021085bea7a1c98/manila/exception.py#L432","commit_id":"39722ffe73e107b220b7c8728b9f67ed5c4e3ec1"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"d5c7c7d7da709f8f36b89308e5e554e919e094d9","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":257,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":258,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":259,"context_line":"            raise exception.NoValidHost(err\u003dmsg)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":262,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":3,"id":"6b0be7de_0301bf65","line":259,"range":{"start_line":259,"start_character":12,"end_line":259,"end_character":48},"in_reply_to":"fca1f168_a2039ca0","updated":"2024-01-12 23:55:04.000000000","message":"Suggestion added","commit_id":"39722ffe73e107b220b7c8728b9f67ed5c4e3ec1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5bc1d9c64dd673d43f79188b0fdd1fabff901420","unresolved":true,"context_lines":[{"line_number":257,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":258,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":259,"context_line":"            raise exception.NoValidHost(err\u003dmsg)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":262,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("},{"line_number":263,"context_line":"            hosts, filter_properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"16f00f6e_fd195220","line":260,"updated":"2023-10-31 18:33:46.000000000","message":"Also, this code change can be unit tested.. there are a bunch of unit tests in https://github.com/openstack/manila/blob/1c44d9946012e78be451e317a021085bea7a1c98/manila/tests/scheduler/drivers/test_filter.py#L193-L411\n\nCould you think of a good test case?","commit_id":"39722ffe73e107b220b7c8728b9f67ed5c4e3ec1"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"d5c7c7d7da709f8f36b89308e5e554e919e094d9","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":258,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":259,"context_line":"            raise exception.NoValidHost(err\u003dmsg)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":262,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("},{"line_number":263,"context_line":"            hosts, filter_properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0268d209_d8b8d434","line":260,"in_reply_to":"16f00f6e_fd195220","updated":"2024-01-12 23:55:04.000000000","message":"I have updated the unit test, and removed a test test_create_share_non_admin since it was duplicate.","commit_id":"39722ffe73e107b220b7c8728b9f67ed5c4e3ec1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915a2b6cd7b4726b6b8c9b2d27d0c7740291cacb","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":257,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":258,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":259,"context_line":"            raise exception.WillNotSchedule(err\u003dmsg, host\u003d\u0027\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":262,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":4,"id":"3ddde797_a885f7d8","line":259,"range":{"start_line":259,"start_character":44,"end_line":259,"end_character":51},"updated":"2023-11-08 22:44:57.000000000","message":"Since you\u0027re already logging this on line 251; probably just set host\u003d\u0027\u0027 here;","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c444a5873031da115ae8dc669c964d915e1dd2ec","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":257,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":258,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":259,"context_line":"            raise exception.WillNotSchedule(err\u003dmsg, host\u003d\u0027\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":262,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":4,"id":"76dcadf8_c103e4f9","line":259,"range":{"start_line":259,"start_character":44,"end_line":259,"end_character":51},"in_reply_to":"3ddde797_a885f7d8","updated":"2023-11-08 22:49:35.000000000","message":"or; even better.. just raise the exception with the message, no need to set any kwargs:\n`\n raise exception.WillNotSchedule(msg)`","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"80ef2bdc82ecb5f01d4f5c1ed9d0fff44f6010a7","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":257,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":258,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":259,"context_line":"            raise exception.WillNotSchedule(err\u003dmsg, host\u003d\u0027\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":262,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f0d2fe9_9d3d5f87","line":259,"range":{"start_line":259,"start_character":44,"end_line":259,"end_character":51},"in_reply_to":"76dcadf8_c103e4f9","updated":"2024-01-12 01:08:46.000000000","message":"Thanks, will update as suggested","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"033973bf1166b3b5331a101708217d75b41673ce","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        if not hosts:"},{"line_number":245,"context_line":"            msg \u003d _(\"No storage could be allocated for this share \""},{"line_number":246,"context_line":"                    \"request. Share back end services are not \""},{"line_number":247,"context_line":"                    \"ready yet, trying again after a while may \""},{"line_number":248,"context_line":"                    \"succeed. Contact your administrator in case \""},{"line_number":249,"context_line":"                    \"retrying does not help. \""},{"line_number":250,"context_line":"                    \"filter didn\u0027t succeed.\")"},{"line_number":251,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"b71befc8_881bfc83","line":248,"range":{"start_line":247,"start_character":32,"end_line":248,"end_character":28},"updated":"2024-01-15 20:06:27.000000000","message":"same comment as the prior patch","commit_id":"2a35c65d1d613c1458a95b4c2e751340a785abf7"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"182df24f7182c0d52d309e40f7946c093ff8be7c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        if not hosts:"},{"line_number":245,"context_line":"            msg \u003d _(\"No storage could be allocated for this share \""},{"line_number":246,"context_line":"                    \"request. Share back end services are not \""},{"line_number":247,"context_line":"                    \"ready yet, trying again after a while may \""},{"line_number":248,"context_line":"                    \"succeed. Contact your administrator in case \""},{"line_number":249,"context_line":"                    \"retrying does not help. \""},{"line_number":250,"context_line":"                    \"filter didn\u0027t succeed.\")"},{"line_number":251,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"050ee600_2f2e826b","line":248,"range":{"start_line":247,"start_character":32,"end_line":248,"end_character":28},"in_reply_to":"b71befc8_881bfc83","updated":"2024-01-17 00:21:17.000000000","message":"Updated it here too.","commit_id":"2a35c65d1d613c1458a95b4c2e751340a785abf7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"79b37fbb762cc9f2f0d59e623f4d768c9d071a6b","unresolved":true,"context_lines":[{"line_number":246,"context_line":"                    \"request. Share back end services are not \""},{"line_number":247,"context_line":"                    \"ready yet. Contact your administrator in case \""},{"line_number":248,"context_line":"                    \"retrying does not help. \""},{"line_number":249,"context_line":"                    \"filter didn\u0027t succeed.\")"},{"line_number":250,"context_line":"            LOG.error(msg)"},{"line_number":251,"context_line":"            self.message_api.create("},{"line_number":252,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f4768d9_ab96a668","line":249,"range":{"start_line":249,"start_character":20,"end_line":249,"end_character":44},"updated":"2024-01-26 11:24:08.000000000","message":"I think this could be dropped and you could reuse message_field.Detail.SHARE_BACKEND_NOT_READY_YET... If we don\u0027t have backends, we won\u0027t get to filter them.","commit_id":"de6743f39695d623c29674529d54403fd3bdbfc7"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"b750a4d3da99bee3091db356d7c28f21616de370","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                    \"request. Share back end services are not \""},{"line_number":247,"context_line":"                    \"ready yet. Contact your administrator in case \""},{"line_number":248,"context_line":"                    \"retrying does not help. \""},{"line_number":249,"context_line":"                    \"filter didn\u0027t succeed.\")"},{"line_number":250,"context_line":"            LOG.error(msg)"},{"line_number":251,"context_line":"            self.message_api.create("},{"line_number":252,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"f31153d3_c3dbd404","line":249,"range":{"start_line":249,"start_character":20,"end_line":249,"end_character":44},"in_reply_to":"38d3fa70_a9234d64","updated":"2024-01-29 20:25:15.000000000","message":"I updated with the fix you mentioned. Please take a look.","commit_id":"de6743f39695d623c29674529d54403fd3bdbfc7"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"99a0b4cb4705f123f386b43014ebd637807e9b86","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                    \"request. Share back end services are not \""},{"line_number":247,"context_line":"                    \"ready yet. Contact your administrator in case \""},{"line_number":248,"context_line":"                    \"retrying does not help. \""},{"line_number":249,"context_line":"                    \"filter didn\u0027t succeed.\")"},{"line_number":250,"context_line":"            LOG.error(msg)"},{"line_number":251,"context_line":"            self.message_api.create("},{"line_number":252,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ea3a5112_8f5a5eae","line":249,"range":{"start_line":249,"start_character":20,"end_line":249,"end_character":44},"in_reply_to":"9f4768d9_ab96a668","updated":"2024-01-27 03:00:20.000000000","message":"Hi Carlos,Thanks for the review.\nDo I have to remove the \"filter didn\u0027t succeed.\" part from msg? or replace it with message_field.Detail.SHARE_BACKEND_NOT_READY_YET ?","commit_id":"de6743f39695d623c29674529d54403fd3bdbfc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a783fe9825b8ca557775a4905d1d4b5f4cf28d7","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                    \"request. Share back end services are not \""},{"line_number":247,"context_line":"                    \"ready yet. Contact your administrator in case \""},{"line_number":248,"context_line":"                    \"retrying does not help. \""},{"line_number":249,"context_line":"                    \"filter didn\u0027t succeed.\")"},{"line_number":250,"context_line":"            LOG.error(msg)"},{"line_number":251,"context_line":"            self.message_api.create("},{"line_number":252,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"38d3fa70_a9234d64","line":249,"range":{"start_line":249,"start_character":20,"end_line":249,"end_character":44},"in_reply_to":"ea3a5112_8f5a5eae","updated":"2024-01-29 15:42:47.000000000","message":"Hi, Melaku! If you remove the filter didn\u0027t succeed part, the message will be 100% equal to what you declared in the message_field.....\n\nSo replacing it is just fine","commit_id":"de6743f39695d623c29674529d54403fd3bdbfc7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b4d74d30e8e99a0c83f02981c9e6dcb1a7935cb0","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":251,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":252,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":253,"context_line":"            raise exception.WillNotSchedule("},{"line_number":254,"context_line":"                message_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":257,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":11,"id":"17e4b813_8e06dd90","line":254,"range":{"start_line":253,"start_character":12,"end_line":254,"end_character":65},"updated":"2024-01-30 08:56:32.000000000","message":"unit test failed, reason is we can not use message_field.Detail.SHARE_BACKEND_NOT_READY_YET as parameter.\n\njust as Goutham Pacha Ravi suggested. we can write like:\n\n    raise exception.WillNotSchedule(host\u003d\u0027here\u0027)","commit_id":"0f150cc3fc38a90a2591ae1044b781e24663404f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0951d7d96744aca85b7d6cb534741b2cad7f089e","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":251,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":252,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":253,"context_line":"            raise exception.WillNotSchedule("},{"line_number":254,"context_line":"                message_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":257,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":11,"id":"83455d22_a28593be","line":254,"range":{"start_line":253,"start_character":12,"end_line":254,"end_character":65},"in_reply_to":"17e4b813_8e06dd90","updated":"2024-01-30 13:16:37.000000000","message":"\u003e unit test failed, reason is we can not use message_field.Detail.SHARE_BACKEND_NOT_READY_YET as parameter.\n\nYes... I think it should be okay trying to extract the message out of it though :)","commit_id":"0f150cc3fc38a90a2591ae1044b781e24663404f"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"7d858cd0b9975bb04bfa29b7a58135d994c8c0f8","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":251,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":252,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":253,"context_line":"            raise exception.WillNotSchedule("},{"line_number":254,"context_line":"                message_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":257,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":11,"id":"399394c7_74df88e9","line":254,"range":{"start_line":253,"start_character":12,"end_line":254,"end_character":65},"in_reply_to":"5665e072_773f0918","updated":"2024-01-30 20:38:42.000000000","message":"I have updated my code and the tests passed locally.","commit_id":"0f150cc3fc38a90a2591ae1044b781e24663404f"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"fa361d3663a86c778debde825d769ff20e98d5c1","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                resource_type\u003dmessage_field.Resource.SHARE,"},{"line_number":251,"context_line":"                resource_id\u003drequest_spec.get(\u0027share_id\u0027, None),"},{"line_number":252,"context_line":"                detail\u003dmessage_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":253,"context_line":"            raise exception.WillNotSchedule("},{"line_number":254,"context_line":"                message_field.Detail.SHARE_BACKEND_NOT_READY_YET)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # Filter local hosts based on requirements ..."},{"line_number":257,"context_line":"        hosts, last_filter \u003d self.host_manager.get_filtered_hosts("}],"source_content_type":"text/x-python","patch_set":11,"id":"5665e072_773f0918","line":254,"range":{"start_line":253,"start_character":12,"end_line":254,"end_character":65},"in_reply_to":"83455d22_a28593be","updated":"2024-01-30 20:26:27.000000000","message":"Like it was before?. but with the msg updated?","commit_id":"0f150cc3fc38a90a2591ae1044b781e24663404f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6fce09f4c259bb502dc0e0b0c69c74b6c7c0f65","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        # traverse this list once."},{"line_number":243,"context_line":"        hosts \u003d self.host_manager.get_all_host_states_share(elevated)"},{"line_number":244,"context_line":"        if not hosts:"},{"line_number":245,"context_line":"            msg \u003d _(\"No storage could be allocated for this share \""},{"line_number":246,"context_line":"                    \"request. Share back end services are not \""},{"line_number":247,"context_line":"                    \"ready yet. Contact your administrator in case \""},{"line_number":248,"context_line":"                    \"retrying does not help.\")"},{"line_number":249,"context_line":"            LOG.error(msg)"},{"line_number":250,"context_line":"            self.message_api.create("},{"line_number":251,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":13,"id":"2de065b8_fc1a9697","line":248,"range":{"start_line":245,"start_character":21,"end_line":248,"end_character":44},"updated":"2024-01-30 23:43:43.000000000","message":"This is a log message; saying this has little meaning to someone reading the logs.. \n\ntypically administrators read logs. \n\nSo, a much more helpful message:\n\n\"There are no hosts to fulfill this provisioning request. Are share backend services down?\"","commit_id":"ecda09a14d0b31169b275ed67a9088a131fbef12"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"832512268a5eacc6c231d51e99653f2352bcf325","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # traverse this list once."},{"line_number":243,"context_line":"        hosts \u003d self.host_manager.get_all_host_states_share(elevated)"},{"line_number":244,"context_line":"        if not hosts:"},{"line_number":245,"context_line":"            msg \u003d _(\"No storage could be allocated for this share \""},{"line_number":246,"context_line":"                    \"request. Share back end services are not \""},{"line_number":247,"context_line":"                    \"ready yet. Contact your administrator in case \""},{"line_number":248,"context_line":"                    \"retrying does not help.\")"},{"line_number":249,"context_line":"            LOG.error(msg)"},{"line_number":250,"context_line":"            self.message_api.create("},{"line_number":251,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":13,"id":"faba97e4_b5fd3e94","line":248,"range":{"start_line":245,"start_character":21,"end_line":248,"end_character":44},"in_reply_to":"2de065b8_fc1a9697","updated":"2024-02-01 21:43:59.000000000","message":"Thanks! I Will update it with this.","commit_id":"ecda09a14d0b31169b275ed67a9088a131fbef12"}],"manila/tests/scheduler/drivers/test_filter.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915a2b6cd7b4726b6b8c9b2d27d0c7740291cacb","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        self.assertRaises(exception.NoValidHost, sched._schedule_share,"},{"line_number":238,"context_line":"                          fake_context, request_spec, {})"},{"line_number":239,"context_line":"        self.assertTrue(_mock_service_get_all_by_topic.called)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @ddt.data("},{"line_number":242,"context_line":"        *[{\u0027name\u0027: \u0027foo\u0027, \u0027extra_specs\u0027: {"},{"line_number":243,"context_line":"            SNAPSHOT_SUPPORT: \u0027True\u0027, REPLICATION_TYPE_SPEC: v"},{"line_number":244,"context_line":"        }} for v in (\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027)]"},{"line_number":245,"context_line":"    )"},{"line_number":246,"context_line":"    @mock.patch(\u0027manila.scheduler.host_manager.HostManager.\u0027"},{"line_number":247,"context_line":"                \u0027get_all_host_states_share\u0027)"},{"line_number":248,"context_line":"    def test_schedule_share_no_hosts("}],"source_content_type":"text/x-python","patch_set":4,"id":"98f1c064_a1513c94","line":245,"range":{"start_line":240,"start_character":0,"end_line":245,"end_character":5},"updated":"2023-11-08 22:44:57.000000000","message":"this ddt annotation belongs above the test case below.. i.e., above line 263.","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"9f557a3bfaac30f5fb97a3dd86378cdc991c02ce","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.assertRaises(exception.NoValidHost, sched._schedule_share,"},{"line_number":238,"context_line":"                          fake_context, request_spec, {})"},{"line_number":239,"context_line":"        self.assertTrue(_mock_service_get_all_by_topic.called)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @ddt.data("},{"line_number":242,"context_line":"        *[{\u0027name\u0027: \u0027foo\u0027, \u0027extra_specs\u0027: {"},{"line_number":243,"context_line":"            SNAPSHOT_SUPPORT: \u0027True\u0027, REPLICATION_TYPE_SPEC: v"},{"line_number":244,"context_line":"        }} for v in (\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027)]"},{"line_number":245,"context_line":"    )"},{"line_number":246,"context_line":"    @mock.patch(\u0027manila.scheduler.host_manager.HostManager.\u0027"},{"line_number":247,"context_line":"                \u0027get_all_host_states_share\u0027)"},{"line_number":248,"context_line":"    def test_schedule_share_no_hosts("}],"source_content_type":"text/x-python","patch_set":4,"id":"5806e36d_13576e84","line":245,"range":{"start_line":240,"start_character":0,"end_line":245,"end_character":5},"in_reply_to":"98f1c064_a1513c94","updated":"2024-01-11 21:55:51.000000000","message":"I have addressed this","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915a2b6cd7b4726b6b8c9b2d27d0c7740291cacb","unresolved":true,"context_lines":[{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        self.assertRaises(exception.WillNotSchedule, sched._schedule_share,"},{"line_number":260,"context_line":"                          fake_context, request_spec, {})"},{"line_number":261,"context_line":"        self.assertTrue(mock_get_all_host_states_share.called)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @mock.patch(\u0027manila.db.service_get_all_by_topic\u0027)"},{"line_number":264,"context_line":"    def test__schedule_share_with_valid_replication_spec("}],"source_content_type":"text/x-python","patch_set":4,"id":"8c96754c_fea00143","line":261,"updated":"2023-11-08 22:44:57.000000000","message":"can you also mock message_api\u0027s \u0027create\u0027 and assert that it was called with the expected parameters? see lines 72-90 in this file for an example..","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fec774d627da84637a2e0d9ef389a9c7995ff651","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        self.assertRaises(exception.WillNotSchedule, sched._schedule_share,"},{"line_number":260,"context_line":"                          fake_context, request_spec, {})"},{"line_number":261,"context_line":"        self.assertTrue(mock_get_all_host_states_share.called)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @mock.patch(\u0027manila.db.service_get_all_by_topic\u0027)"},{"line_number":264,"context_line":"    def test__schedule_share_with_valid_replication_spec("}],"source_content_type":"text/x-python","patch_set":4,"id":"f7315a8c_536e54e5","line":261,"in_reply_to":"4c502f31_78b451d3","updated":"2023-11-12 01:56:53.000000000","message":"in addition; this line is fine.","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"beb5180c45886b26b785e804825a766cf73fa6dc","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        self.assertRaises(exception.WillNotSchedule, sched._schedule_share,"},{"line_number":260,"context_line":"                          fake_context, request_spec, {})"},{"line_number":261,"context_line":"        self.assertTrue(mock_get_all_host_states_share.called)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @mock.patch(\u0027manila.db.service_get_all_by_topic\u0027)"},{"line_number":264,"context_line":"    def test__schedule_share_with_valid_replication_spec("}],"source_content_type":"text/x-python","patch_set":4,"id":"4c502f31_78b451d3","line":261,"in_reply_to":"8c96754c_fea00143","updated":"2023-11-10 22:46:28.000000000","message":"Should I mock the message_api\u0027s \u0027create\u0027 instead of this? or should this line still exist?","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"340335aca23d5d75f6d58cbeeca0acfc4d6fad6b","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        self.assertRaises(exception.WillNotSchedule, sched._schedule_share,"},{"line_number":260,"context_line":"                          fake_context, request_spec, {})"},{"line_number":261,"context_line":"        self.assertTrue(mock_get_all_host_states_share.called)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @mock.patch(\u0027manila.db.service_get_all_by_topic\u0027)"},{"line_number":264,"context_line":"    def test__schedule_share_with_valid_replication_spec("}],"source_content_type":"text/x-python","patch_set":4,"id":"472617f7_d76e0017","line":261,"in_reply_to":"f7315a8c_536e54e5","updated":"2024-01-05 21:15:00.000000000","message":"I have added the changes requested, please review.","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ea2c37bb6d297e79a9d98fd94f9726bcd57795b","unresolved":true,"context_lines":[{"line_number":158,"context_line":"                          sched.schedule_create_share,"},{"line_number":159,"context_line":"                          fake_context,"},{"line_number":160,"context_line":"                          request_spec,"},{"line_number":161,"context_line":"                          {})"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @ddt.data("},{"line_number":164,"context_line":"        {\u0027name\u0027: \u0027foo\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"b602dbc7_1fd4ce92","line":161,"range":{"start_line":161,"start_character":28,"end_line":161,"end_character":29},"updated":"2024-01-12 19:35:44.000000000","message":"can you also add an assert here that the user message was created?\n\nSee an example of how to mock the \"create_message\" call on line 72 of this file; and there\u0027s an example of how the mock can be asserted on lines 84-90..","commit_id":"545cca221367fe703b2602302752344ec83da8e8"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"d5c7c7d7da709f8f36b89308e5e554e919e094d9","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                          sched.schedule_create_share,"},{"line_number":159,"context_line":"                          fake_context,"},{"line_number":160,"context_line":"                          request_spec,"},{"line_number":161,"context_line":"                          {})"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @ddt.data("},{"line_number":164,"context_line":"        {\u0027name\u0027: \u0027foo\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"7b7a425b_93195842","line":161,"range":{"start_line":161,"start_character":28,"end_line":161,"end_character":29},"in_reply_to":"b602dbc7_1fd4ce92","updated":"2024-01-12 23:55:04.000000000","message":"Added this too","commit_id":"545cca221367fe703b2602302752344ec83da8e8"}],"releasenotes/notes/bug-1886690-edit-services-down-message-c857de1a678b6781.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915a2b6cd7b4726b6b8c9b2d27d0c7740291cacb","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `bug #1886690 \u003chttps://bugs.launchpad.net/manila/+bug/1886690\u003e`_"},{"line_number":5,"context_line":"    that was a misleading user message when share services are down. The"},{"line_number":6,"context_line":"    message is now clear and descriptive."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"97c18294_e9e1cdc4","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":41},"updated":"2023-11-08 22:44:57.000000000","message":"nit; instead, you could say this:\n \n with a clear and descriptive user message when share services are down.","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"beb5180c45886b26b785e804825a766cf73fa6dc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `bug #1886690 \u003chttps://bugs.launchpad.net/manila/+bug/1886690\u003e`_"},{"line_number":5,"context_line":"    that was a misleading user message when share services are down. The"},{"line_number":6,"context_line":"    message is now clear and descriptive."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0fb36cfd_907ed44a","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":41},"in_reply_to":"97c18294_e9e1cdc4","updated":"2023-11-10 22:46:28.000000000","message":"Noted. I will update","commit_id":"ff6242e9064763ec639a5ca61bf44a78c87b18e2"}]}