)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5040e0dcddef3fa6405b7e20bfbfd838a4e8b271","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing skipped default override for CORS options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the cores middleware options should have overridden default"},{"line_number":10,"context_line":"values but the override method was not actually called so the library"},{"line_number":11,"context_line":"defaults are still used."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c8d150e7_3c51a0b0","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":17},"updated":"2024-01-31 01:48:56.000000000","message":"(nit) cors. would be trivial because of the correct name in the title.","commit_id":"5d48410d0ab72c5eba80c4034f19f3ae20a76de3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1a1149b9c2c04fbeec233a6dcf1a3f3baee97013","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec91743b_4ea0b7d5","updated":"2024-01-28 16:48:32.000000000","message":"This looks like a fix for a legit bug and we may want to backport this to stable branches.\n\nwondering if you mind creating a bug here https://bugs.launchpad.net/manila and add `Closes-Bug: #\u003cnumber\u003e` as a reference to the bug (and some more explanation about the problem being fixed).","commit_id":"2a84871d08b0761bc0a73fcc49c1b3c09b4d3e1f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b9b7de9378f0e59e832241f2492ba7630e66afbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"422233cf_8ed0556c","in_reply_to":"48c35ecc_9b25b79a","updated":"2024-01-30 22:25:46.000000000","message":"Thanks Joshua for discovering this bug, and for fixing it up.\n\nThank you very much for seeking a bug report; and for adding a release note, Takashi... this paperwork is important to communicate with deployers when we publish these fixes to older stable branches.","commit_id":"2a84871d08b0761bc0a73fcc49c1b3c09b4d3e1f"},{"author":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"change_message_id":"8994f84241b73a01bd7a3db3283c8db6173777b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48c35ecc_9b25b79a","in_reply_to":"ec91743b_4ea0b7d5","updated":"2024-01-30 10:50:30.000000000","message":"https://bugs.launchpad.net/manila/+bug/2051691","commit_id":"2a84871d08b0761bc0a73fcc49c1b3c09b4d3e1f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ce47c0d311d97a130cf27ce4b10f3cc257ce4f98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d08d0a4_ec16cd7c","updated":"2024-02-01 15:47:46.000000000","message":"LGTM, thank you for the fix! :)","commit_id":"5d48410d0ab72c5eba80c4034f19f3ae20a76de3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"349226e36dbf0d59057a92d2c18178690fd3c06b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eec8fe7a_d55f115c","updated":"2024-01-30 13:30:24.000000000","message":"So... the problem is that the set_lib_defaults method is used to define an entry point in the oslo.config.opts.defaults namespace but this is only used for generating config files. We have to actuall call the method within the code to change the default value picked up by the services.\n\nWe can probably refactor the method and split out the cors options part and call only that part from api/wsgi, because policy.yaml is overriden in manila.policies.base, but duplicate override may not cause problems so for a sort term the current fix would be fine.","commit_id":"5d48410d0ab72c5eba80c4034f19f3ae20a76de3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b9b7de9378f0e59e832241f2492ba7630e66afbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b08a0556_b6f655c4","updated":"2024-01-30 22:25:46.000000000","message":"recheck\n\n\nthe docs job must pass now","commit_id":"5d48410d0ab72c5eba80c4034f19f3ae20a76de3"}],"manila/cmd/api.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dd6ccb741aba01407e902e7d3b139085b7a2f6d2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":4,"context_line":"# Administrator of the National Aeronautics and Space Administration."}],"source_content_type":"text/x-python","patch_set":1,"id":"b4987fe6_1ef5dbd3","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":21},"updated":"2024-01-28 16:49:09.000000000","message":"do we need this revert actually ?","commit_id":"2a84871d08b0761bc0a73fcc49c1b3c09b4d3e1f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"abbfee8ed778de4b53207ca76959329d9d81513c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":4,"context_line":"# Administrator of the National Aeronautics and Space Administration."}],"source_content_type":"text/x-python","patch_set":1,"id":"284b9b2a_3a270afc","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":21},"in_reply_to":"170c97d8_b4ef038d","updated":"2024-01-30 13:21:06.000000000","message":"Done","commit_id":"2a84871d08b0761bc0a73fcc49c1b3c09b4d3e1f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d4c33fe84f98c100e816c14eaa75eb4928099515","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":4,"context_line":"# Administrator of the National Aeronautics and Space Administration."}],"source_content_type":"text/x-python","patch_set":1,"id":"170c97d8_b4ef038d","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":21},"in_reply_to":"b2f65e1b_1899516a","updated":"2024-01-30 13:13:36.000000000","message":"OK then let\u0027s revert this.","commit_id":"2a84871d08b0761bc0a73fcc49c1b3c09b4d3e1f"},{"author":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"change_message_id":"fabfef1adde36d5bd400e0466591754a97f937f9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":4,"context_line":"# Administrator of the National Aeronautics and Space Administration."}],"source_content_type":"text/x-python","patch_set":1,"id":"b2f65e1b_1899516a","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":21},"in_reply_to":"b4987fe6_1ef5dbd3","updated":"2024-01-30 09:50:29.000000000","message":"Nope, not at all.","commit_id":"2a84871d08b0761bc0a73fcc49c1b3c09b4d3e1f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d4c33fe84f98c100e816c14eaa75eb4928099515","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027manila\u0027,"},{"line_number":49,"context_line":"         version\u003dversion.version_string())"},{"line_number":50,"context_line":"    config.verify_share_protocols()"},{"line_number":51,"context_line":"    config.set_lib_defaults()"},{"line_number":52,"context_line":"    log.setup(CONF, \"manila\")"},{"line_number":53,"context_line":"    utils.monkey_patch()"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"44758d15_e02a73ec","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":29},"updated":"2024-01-30 13:13:36.000000000","message":"seems this also affects wsgi application... I\u0027ll update this change to fix it as well.","commit_id":"5881931194707628e4483254befe0ea8f7046c77"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"abbfee8ed778de4b53207ca76959329d9d81513c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027manila\u0027,"},{"line_number":49,"context_line":"         version\u003dversion.version_string())"},{"line_number":50,"context_line":"    config.verify_share_protocols()"},{"line_number":51,"context_line":"    config.set_lib_defaults()"},{"line_number":52,"context_line":"    log.setup(CONF, \"manila\")"},{"line_number":53,"context_line":"    utils.monkey_patch()"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"467f7645_a14215f0","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":29},"in_reply_to":"44758d15_e02a73ec","updated":"2024-01-30 13:21:06.000000000","message":"Done","commit_id":"5881931194707628e4483254befe0ea8f7046c77"}]}