)]}'
{"id":"openstack%2Fmanila~907945","triplet_id":"openstack%2Fmanila~stable%2Fxena~I5b1f1ce517efed000f17b1e0901e183a1913ba9f","project":"openstack/manila","branch":"stable/xena","topic":"bug/2004230","attention_set":{},"removed_from_attention_set":{"29632":{"account":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"last_update":"2024-02-08 19:52:13.000000000","reason":"\u003cGERRIT_ACCOUNT_29632\u003e replied on the change","reason_account":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}},"16643":{"account":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"last_update":"2024-02-08 20:45:55.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5b1f1ce517efed000f17b1e0901e183a1913ba9f","subject":"[rbac] Pull up policy checks on share/snapshot APIs","status":"MERGED","created":"2024-02-06 06:07:45.000000000","updated":"2024-02-08 20:47:03.000000000","submitted":"2024-02-08 20:45:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"907945-bug/2004230","meta_rev_id":"8ed8e8fe3000c7dc77efc16489c2276aeb84d007","_number":907945,"virtual_id_number":907945,"owner":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-02-08 20:45:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"all":[{"value":2,"date":"2024-02-08 19:52:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"all":[{"value":1,"date":"2024-02-08 19:52:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-06 07:54:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-06 19:48:50.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"state":"REVIEWER"}],"messages":[{"id":"bfa81e239f659d547b2a8b3180f407bd939966a4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2024-02-06 06:07:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5c82791d8388293cb05fe1758ed00af54b44d6aa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-06 07:54:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/098504ace283415c8ef75bd08a020c4b\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81789d71a62a4bbfa50c506a57694432 : SUCCESS in 9m 17s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c1fa1a3b37b845319bdcbcdcb6ebc8d3 : SUCCESS in 17m 14s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3edd86095a4242cd9dfa25e36b74e8fb : SUCCESS in 4m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/aa3719dfd0864632ae0f2f262dec1b4c : SUCCESS in 9m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b1520833d8dd4d97b823b9810de94e23 : SUCCESS in 7m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/38315ea3a41141fd8d24e0b85bb0f72f : SUCCESS in 9m 06s (non-voting)\n- manila-tempest-plugin-lvm-stable https://zuul.opendev.org/t/openstack/build/e5bdde859327402cbd6f8b4e85801e9d : SUCCESS in 54m 18s\n- manila-tempest-plugin-generic-scenario-stable https://zuul.opendev.org/t/openstack/build/f0140ab86b8e444b87705dfb2de27e92 : SUCCESS in 1h 45m 26s (non-voting)\n- manila-tempest-plugin-generic-stable https://zuul.opendev.org/t/openstack/build/97e7ed74a1de4b40afa7caf2e06c93db : SUCCESS in 1h 19m 52s (non-voting)\n- manila-tempest-plugin-cephfs-native-stable https://zuul.opendev.org/t/openstack/build/3716210c0be248139cdfe9e78529b2ce : SUCCESS in 1h 21m 58s (non-voting)\n- manila-tempest-plugin-cephfs-nfs-stable https://zuul.opendev.org/t/openstack/build/f5eead1652264810954e3e80bb47bc2c : SUCCESS in 1h 07m 55s (non-voting)\n- manila-tempest-plugin-zfsonlinux-stable https://zuul.opendev.org/t/openstack/build/d067e78144b547c982b31aa5f33adff0 : SUCCESS in 50m 48s (non-voting)\n- manila-tox-genconfig https://zuul.opendev.org/t/openstack/build/6a2ebfeec712453a9726ec2e0d83e461 : SUCCESS in 4m 47s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/91726644a5984437ade511fc8cab9d2b : SUCCESS in 5m 50s (non-voting)\n- manila-tempest-plugin-dummy-no-dhss https://zuul.opendev.org/t/openstack/build/0218ea511cca406eb8c3b50f04fec9c5 : SUCCESS in 26m 21s\n- manila-tempest-plugin-dummy-dhss https://zuul.opendev.org/t/openstack/build/93d0877217a246a4a0e1c39072ce30f9 : SUCCESS in 33m 05s\n- manila-tempest-plugin-container https://zuul.opendev.org/t/openstack/build/34d3f8f8b3c64eb1a75bca34ca9cda3a : SUCCESS in 42m 08s (non-voting)\n- manila-tempest-plugin-glusterfs-native https://zuul.opendev.org/t/openstack/build/eea428ef468e45e2ad427ba3789aa064 : SUCCESS in 21m 31s (non-voting)\n- manila-tempest-plugin-glusterfs-nfs https://zuul.opendev.org/t/openstack/build/ee7e1838fc8e4f1c99ace3d4aafcb503 : SUCCESS in 28m 28s (non-voting)\n- manila-tempest-plugin-lvm-fips-stable https://zuul.opendev.org/t/openstack/build/68f1c51d1c03497d89048b32a8c6fe35 : SUCCESS in 57m 45s (non-voting)\n- manila-grenade https://zuul.opendev.org/t/openstack/build/b5b8c2971d294d80b648652c531229b6 : FAILURE in 36m 56s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/88fb68bdf9c843f08f62dae58cb3653e : SUCCESS in 22m 37s (non-voting)\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/a06fb06f1f714ea888aeec5aeb4f502a : SUCCESS in 31m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b2d62a81ab48711b23e7d90ebfa80d54a17a5ce0","author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"date":"2024-02-08 19:52:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e0b5088316cf061af4aacf9d3e863e51b14e3a41","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-08 19:52:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9307e9f5e73ebc449066d7f026f55a088f1cd745","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-08 20:45:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8396bbd12e6c44ab92456560aecd74a5\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/728adcdbe1284172b7d82a7a6a39948e : SUCCESS in 10m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/431c5fd6e6ba4fb68edd33b1c03a5368 : SUCCESS in 5m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ccb400098d9d48d686e9e9cb8d42a98a : SUCCESS in 8m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/817b8d70c17540b88e6453a58d5bc5c6 : SUCCESS in 8m 06s\n- manila-tempest-plugin-lvm-stable https://zuul.opendev.org/t/openstack/build/a2911984d9d344beb3612ec572e33d22 : SUCCESS in 51m 52s\n- manila-tempest-plugin-dummy-no-dhss https://zuul.opendev.org/t/openstack/build/3f5e2fa5bb97419bbc620e017639c5bb : SUCCESS in 26m 25s\n- manila-tempest-plugin-dummy-dhss https://zuul.opendev.org/t/openstack/build/85ff58da5e504406b9bdb9552c4102bc : SUCCESS in 39m 25s","accounts_in_message":[],"_revision_number":1},{"id":"fa16da4b466e5310dad1a8fbd0a9dcb97b498504","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-08 20:45:55.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"8ed8e8fe3000c7dc77efc16489c2276aeb84d007","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-08 20:47:03.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/df788fe6edea414cb0cb63fc24667047\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c54c5862d9e84c79a86eefe7d0be871a : SUCCESS in 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8ab5ec6b4f9393d940da6222188be2341816aace","revisions":{"8ab5ec6b4f9393d940da6222188be2341816aace":{"kind":"REWORK","_number":1,"created":"2024-02-06 06:07:45.000000000","uploader":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"ref":"refs/changes/45/907945/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila","ref":"refs/changes/45/907945/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila refs/changes/45/907945/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila refs/changes/45/907945/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila refs/changes/45/907945/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila refs/changes/45/907945/1"}}},"commit":{"parents":[{"commit":"ede80c4f365072d53a82ef3f4840cc57a663732d","subject":"Change status and error handling for /shares API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/ede80c4f365072d53a82ef3f4840cc57a663732d"}]}],"author":{"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","date":"2023-05-25 22:20:31.000000000","tz":-420},"committer":{"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","date":"2024-02-06 06:05:41.000000000","tz":-480},"subject":"[rbac] Pull up policy checks on share/snapshot APIs","message":"[rbac] Pull up policy checks on share/snapshot APIs\n\nRBAC enforcement in manila happens in stages:\n1) Does user have access to the API\n2) Does user have access to the resource\n3) Is user permitted to perform the API action on the resource\n\nIf (1) fails, user gets a HTTP 403, if (2) fails,\nthey get a HTTP 404; if (3) fails, they get a HTTP 403.\n\nMore often than not, (2) prevents \"existence\" detection\nof resources that don\u0027t belong to the user; except in\ncase of \"public\" resources (e.g.: shares can be \"public\").\n\nIn some share API methods, policy checks for (1) are\nhappening after a bunch of processing. This leads to\nsome inconsistency.\n\nFix these occurrences to ensure a consistent user\nexperience.\n\nChange-Id: I5b1f1ce517efed000f17b1e0901e183a1913ba9f\nRelated-Bug: #2004230\nSigned-off-by: Goutham Pacha Ravi \u003cgouthampravi@gmail.com\u003e\n(cherry picked from commit 190876809f2bda4153166e055c9de9bd1786f2a8)\n(cherry picked from commit 318140e2505a946f7523e47dc6cf5b4ac34a7813)\n(cherry picked from commit 8edaa3254c589c20443accc21eb732038158c59f)\n(cherry picked from commit f878e15bcaa129356207117a8e0b9282a22b42cb)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/8ab5ec6b4f9393d940da6222188be2341816aace"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/8ab5ec6b4f9393d940da6222188be2341816aace"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}