)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-02-21 10:29:23 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Human readable export location core implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Export locations are usually too difficult to memo"},{"line_number":10,"context_line":"rize.Currently, there is no way to determine the"},{"line_number":11,"context_line":"export location before the share is created, so"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e3c8a27e_7c31fb46","line":8,"updated":"2024-02-23 10:10:27.000000000","message":"Jayaanand - this change is missing documentation. Some documentation that\u0027s necessary:\n\n* API reference - you\u0027re introducing a new parameter \"mount_point_name\" to shares APIs,\nthe POST /shares API, GET /shares, GET /shares/\u003cshare-id\u003e, GET /shares/detail at a minimum are changing.\nCan you please add the docs for this, I don\u0027t mind this coming in a follow up patch.\n\n* You are introducing a new \"common\" capability: \"human_readable_export_location_support\". We need to add a reference in\nthe share_back_ends_feature_support_mapping.rst file.\n* We could also use an update to `doc/source/admin/capabilities_and_extra_specs.rst` - this file contains descriptions of all the common capabilities. Please add a reference here to both \"human_readable_export_location_support\" and \"provisioning:mount_point_prefix\" (which is used to setup a prefix)\n* We could also update `doc/user/create-and-manage-shares.rst`. There\u0027s a table with share type capabilities where you can address both \"human_readable_export_location_support\" and \"provisioning:mount_point_prefix\". In the same file, you can also show how to customize a mount point, and what the user can expect when that\u0027s done.\n\n\nYou can report a doc bug on https://bugs.launchpad.net/manila, assign it to yourself and add these doc changes in a follow up patch","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-02-21 10:29:23 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Human readable export location core implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Export locations are usually too difficult to memo"},{"line_number":10,"context_line":"rize.Currently, there is no way to determine the"},{"line_number":11,"context_line":"export location before the share is created, so"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"eb789581_9ad62a1a","line":8,"in_reply_to":"e3c8a27e_7c31fb46","updated":"2024-03-04 16:03:44.000000000","message":"Thank you! Goutham for detailed review. Update all document section. Regarding create-and-manage-shares.rst, i didn\u0027t find any capabilities table. let me know if i misunderstand something. I will correct it.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":14,"context_line":"locations to mount the share. The generated"},{"line_number":15,"context_line":"export locations are often not human readable"},{"line_number":16,"context_line":" and it is hard to memorize and control them."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"69a4f9c1_a16def6d","line":17,"updated":"2024-02-23 10:10:27.000000000","message":"Please add:\n\nImplements bp: human-readable-export-locations","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"locations to mount the share. The generated"},{"line_number":15,"context_line":"export locations are often not human readable"},{"line_number":16,"context_line":" and it is hard to memorize and control them."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"701fecd4_b391ab22","line":17,"in_reply_to":"69a4f9c1_a16def6d","updated":"2024-03-04 16:03:44.000000000","message":"update blue print details.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"export locations are often not human readable"},{"line_number":16,"context_line":" and it is hard to memorize and control them."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"bp: human-readable-export-locations"},{"line_number":19,"context_line":"Change-Id: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"14b9dad3_c74e079c","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":2},"updated":"2024-03-05 23:58:57.000000000","message":"\"Implements: bp/human-readable-export-locations\"\n\n\nThis is an automation hint, so formatting it correctly is necessary. Please see https://docs.openstack.org/manila/latest/contributor/commit_message_tags.html","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"export locations are often not human readable"},{"line_number":16,"context_line":" and it is hard to memorize and control them."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"bp: human-readable-export-locations"},{"line_number":19,"context_line":"Change-Id: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"552854b2_1be932ff","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":2},"in_reply_to":"14b9dad3_c74e079c","updated":"2024-03-06 20:53:12.000000000","message":"ok, update commit message","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dca438c2270a2f833bdaef3a95f990fd7243532","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a8ec80ab_bee48a90","updated":"2024-02-15 12:42:00.000000000","message":"Thank you for working on this change, Jayaanand! Have some suggestions inline. Please take a look at them.\n\nAlso, could you please add a release note to this change?\n\nhttps://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#how-do-i-add-a-release-note","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"085c7b0f_d17ee0f0","updated":"2024-02-16 02:07:01.000000000","message":"Thanks for submitting this, Jayaanand. \n\nI\u0027ve some comments inline; ptal.. \n\nIt seems like we can implement \"human_readable_export_locations_support\" in one of the free and open source drivers: generic, lvm, zfsonlinux, container (and definitely in the dummy driver) for testing purposes.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe08a4f_137baf7d","in_reply_to":"085c7b0f_d17ee0f0","updated":"2024-02-21 17:03:21.000000000","message":"Added code for LVM and Dummy driver","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ab512e8d_18270404","in_reply_to":"a8ec80ab_bee48a90","updated":"2024-02-21 17:03:21.000000000","message":"Added release notes.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"f219b517986bf1252c9c40c740b1ed19c28b3a41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"28e95ca3_17f28bce","updated":"2024-02-27 14:26:19.000000000","message":"For reducing complexity I would like to have only one name for this feature. What do you think?","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"63c2e85d816f923437556a8c5f9336c84076a940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c659ede_b64edff1","updated":"2024-02-27 22:29:56.000000000","message":"Jayaanand, \n\nWe\u0027re running quite close to the feature freeze deadline. If this patch cannot merge by the feature freeze deadline, it will need to be provided a Feature Freeze Exception; however, please note that the python-manilaclient patch that depends on this change will not merge in the Caracal release - i.e., we\u0027ll have to merge the change when the Dalmation release opens up for python-manilaclient (this happens after the feature freeze date - Feb 29th 2024) \n\n\nI\u0027ll hopefully be able to do a re-review; however, my availability this week is patchy.. Please feel free to ask follow up questions if you have regarding the pending review comments. Thanks!","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"10a11fd3_96ba435f","updated":"2024-02-21 17:03:21.000000000","message":"Thank you! Goutham/Carlos for the detailed review. Addressed review comments. Can you please review again.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ce65f81d_f6706477","updated":"2024-02-23 10:10:27.000000000","message":"Thanks for walking us through this change at the collab review, Jayaanand. I\u0027ve added comments inline","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b74f8227bc4b08f834b8e7bb30606ac70fcf466e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8105b197_31230173","updated":"2024-03-04 15:54:43.000000000","message":"Check commit message, its about service.","commit_id":"9568e9abed80d4d65993618b80188b58890d7ea3"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d7b99a6e_b4a06fc3","updated":"2024-03-04 16:03:44.000000000","message":"Hi Goutham, thank you! for the detailed and precise review comments. Addressed all review comments. Please review again.","commit_id":"9568e9abed80d4d65993618b80188b58890d7ea3"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7451fce84270ee7c030a4f760cc051e89a4595ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0ad7a73e_ec168d0f","in_reply_to":"8105b197_31230173","updated":"2024-03-04 16:06:48.000000000","message":"Thank you! Kiran, The message got messed up after the rebase. Corrected now.","commit_id":"9568e9abed80d4d65993618b80188b58890d7ea3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"12d35014_33ad1dd1","updated":"2024-03-05 17:52:25.000000000","message":"Hey, Jayaanand. Thank you for working on the comments, please take a look at some extra suggestions inline.\nAlso, I realized something: no changes to the share/manager were required? :)","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7451fce84270ee7c030a4f760cc051e89a4595ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5d0fbb91_46101995","updated":"2024-03-04 16:06:48.000000000","message":"Thank you! Kiran, The message got messed up after the rebase. Corrected now.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4669d86fdcb77bcba1378a95300fe0d8b47b16c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"14eb078f_685b5e73","updated":"2024-03-06 23:06:54.000000000","message":"I\u0027ve some further comments about missing unit test coverage, ptal","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0d36b526_0995c320","updated":"2024-03-06 20:53:12.000000000","message":"Thank you!Goutham/Carlos for detailed review. Resolved suggested review comments. Please review again. I really appreciate your time.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"929bd65ec75ac171241f9a563342b28ab0fe160f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b3c80b17_f35b79d6","updated":"2024-03-06 22:59:08.000000000","message":"this broke some tests; please see comments inline","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6099518dae02edc4bd6e65c62e963c1ed6bdd8cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7975d352_3bcff07e","updated":"2024-03-12 20:43:06.000000000","message":"And a test bug: https://bugs.launchpad.net/manila/+bug/2057703","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"75b11317e05522497e117123a553b90b2f1122ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3e7d6c48_ced24832","updated":"2024-03-08 11:02:58.000000000","message":"Goutham: \n\nOn the CI,\n\n    manila-tempest-plugin-ontap-dhss: 3 failures, and they are the same we discussed in the channel last wednsday -  FAILURE in 1h 23m 42s\ntest_restore_share_with_wrong_id[api,id-87345725-f187-4d7d-86b1-62284e8c75ae,negative]\ntest_soft_delete_share_has_been_soft_deleted[api_with_backend,id-36cbe23b-08d2-49d9-bb42-f9eb2a804cb1,negative]\ntest_soft_delete_share_with_wrong_id[api,id-0ccd44dd-2fda-403e-bc23-7ce428550f36,negative]\n\n    manila-tempest-plugin-ontap-no-dhss https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/97/908897/9/upstream-check/manila-tempest-plugin-ontap-no-dhss/8c33b5f/ : SUCCESS in 2h 46m 59s\n\n\nWe\u0027ll fix the failures as part of https://bugs.launchpad.net/manila/+bug/2035562","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ef00f400fb19d7a341223727c3edebf0935cda3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f7e71902_515d807d","updated":"2024-03-12 20:40:46.000000000","message":"Jayaanand: I\u0027ve added a new doc bug requesting some docs regarding this feature: https://bugs.launchpad.net/manila/+bug/2057702","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"faa3e07aa92bd09eaf60357eac3bb3a02025ce14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"95f47cf8_8ce27869","updated":"2024-03-08 13:22:55.000000000","message":"LGTM, thank you for the hard work on this change, Jayaanand!","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"38e5976efebd7b36e94abcf04fa8111b423eda90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f3376f81_db775220","updated":"2024-03-08 14:10:29.000000000","message":"Thank you Jayanand for taking care of all the changes requested.","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d243c06f_b1506228","updated":"2024-03-07 22:25:10.000000000","message":"Thank you! Goutham, I am able to make code changes based on your suggestion and added additional UTs. Can you please review again.","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c49a1431c934a66a207e7de98c52458612b1aea6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2d9889b7_8ba47129","updated":"2024-03-07 22:48:38.000000000","message":"Thanks for the changes; LGTM.. waiting on CI to +2; please see comments inline that you can address in a follow up patch","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31fb2fe49708442e8b3de3df12b18e9a8039e29e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e9d3c4f4_69234afd","updated":"2024-03-08 16:54:43.000000000","message":"let’s ship it","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"fbb7a2edf82067b39b85b5a2a502c2b126964750","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b1f94d70_3df99dbc","updated":"2024-03-08 07:25:49.000000000","message":"run-NetApp CI","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"}],"doc/source/admin/capabilities_and_extra_specs.rst":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":196,"context_line":"  this extra-spec, the share type is assumed to be serviceable in all"},{"line_number":197,"context_line":"  availability zones known to the Shared File Systems service."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* **mount_point_name_support** indicates the use of a custom export"},{"line_number":200,"context_line":"  location during share creation. To enable this, the admin user must"},{"line_number":201,"context_line":"  create a share type named provisioning:mount_point_prefix. The user"},{"line_number":202,"context_line":"  will then use this prefix in conjunction with the mount_point_name"},{"line_number":203,"context_line":"  when creating a share. The share\u0027s export location will be created"}],"source_content_type":"text/x-rst","patch_set":7,"id":"cdf6ebf4_d42b731d","line":200,"range":{"start_line":199,"start_character":41,"end_line":200,"end_character":32},"updated":"2024-03-05 17:52:25.000000000","message":"whether a custom export location could be specified during shares creation or not.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"  this extra-spec, the share type is assumed to be serviceable in all"},{"line_number":197,"context_line":"  availability zones known to the Shared File Systems service."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* **mount_point_name_support** indicates the use of a custom export"},{"line_number":200,"context_line":"  location during share creation. To enable this, the admin user must"},{"line_number":201,"context_line":"  create a share type named provisioning:mount_point_prefix. The user"},{"line_number":202,"context_line":"  will then use this prefix in conjunction with the mount_point_name"},{"line_number":203,"context_line":"  when creating a share. The share\u0027s export location will be created"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f17c9bfe_a8f7eb2a","line":200,"range":{"start_line":199,"start_character":41,"end_line":200,"end_character":32},"in_reply_to":"5682787e_5a19d0b9","updated":"2024-03-06 20:53:12.000000000","message":"sure, updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":196,"context_line":"  this extra-spec, the share type is assumed to be serviceable in all"},{"line_number":197,"context_line":"  availability zones known to the Shared File Systems service."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* **mount_point_name_support** indicates the use of a custom export"},{"line_number":200,"context_line":"  location during share creation. To enable this, the admin user must"},{"line_number":201,"context_line":"  create a share type named provisioning:mount_point_prefix. The user"},{"line_number":202,"context_line":"  will then use this prefix in conjunction with the mount_point_name"},{"line_number":203,"context_line":"  when creating a share. The share\u0027s export location will be created"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5682787e_5a19d0b9","line":200,"range":{"start_line":199,"start_character":41,"end_line":200,"end_character":32},"in_reply_to":"cdf6ebf4_d42b731d","updated":"2024-03-05 23:58:57.000000000","message":"+1; slight modification:\n\n\"whether a custom export location could be specified during share creation.\"","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* **mount_point_name_support** indicates the use of a custom export"},{"line_number":200,"context_line":"  location during share creation. To enable this, the admin user must"},{"line_number":201,"context_line":"  create a share type named provisioning:mount_point_prefix. The user"},{"line_number":202,"context_line":"  will then use this prefix in conjunction with the mount_point_name"},{"line_number":203,"context_line":"  when creating a share. The share\u0027s export location will be created"},{"line_number":204,"context_line":"  using the provided mount_point_name, prefixed with mount_point_prefix."}],"source_content_type":"text/x-rst","patch_set":7,"id":"92455fd1_e3759465","line":201,"range":{"start_line":201,"start_character":22,"end_line":201,"end_character":27},"updated":"2024-03-05 23:58:57.000000000","message":"This is incomplete;\n\n\n\"To enable users to specify a custom mount point for their shares, administrators must set this extra-specification in the share type to True. They must also provide an extra-spec named ``provisioning:mount_point_prefix``. The service will use this prefix in conjunction with the mount point name provided by end users during share creation.\"","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* **mount_point_name_support** indicates the use of a custom export"},{"line_number":200,"context_line":"  location during share creation. To enable this, the admin user must"},{"line_number":201,"context_line":"  create a share type named provisioning:mount_point_prefix. The user"},{"line_number":202,"context_line":"  will then use this prefix in conjunction with the mount_point_name"},{"line_number":203,"context_line":"  when creating a share. The share\u0027s export location will be created"},{"line_number":204,"context_line":"  using the provided mount_point_name, prefixed with mount_point_prefix."}],"source_content_type":"text/x-rst","patch_set":7,"id":"e887761c_982bf9db","line":201,"range":{"start_line":201,"start_character":22,"end_line":201,"end_character":27},"in_reply_to":"92455fd1_e3759465","updated":"2024-03-06 20:53:12.000000000","message":"sure, updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":202,"context_line":"  will then use this prefix in conjunction with the mount_point_name"},{"line_number":203,"context_line":"  when creating a share. The share\u0027s export location will be created"},{"line_number":204,"context_line":"  using the provided mount_point_name, prefixed with mount_point_prefix."},{"line_number":205,"context_line":"  In cases where mount_point_prefix is missing from the share type,"},{"line_number":206,"context_line":"  the share\u0027s export location will be prefixed with the project_id."},{"line_number":207,"context_line":"  However, shares created with a project_id prefix are not eligible for"},{"line_number":208,"context_line":"  transfer.For these shares to be transferred to a different project,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1b5b7d55_3cd5b742","line":205,"range":{"start_line":205,"start_character":2,"end_line":205,"end_character":35},"updated":"2024-03-05 23:58:57.000000000","message":"When ``provisioning:mount_point_prefix`` is not set on a share type, but ``mount_point_name_support`` is enabled,...\n\n\n(Within this paragraph, use back ticks (`) when you\u0027re trying to highlight a constant/string that can be copied by the reader for example:\n\n\n```\n``mount_point_name_support``\n```\n)","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"  will then use this prefix in conjunction with the mount_point_name"},{"line_number":203,"context_line":"  when creating a share. The share\u0027s export location will be created"},{"line_number":204,"context_line":"  using the provided mount_point_name, prefixed with mount_point_prefix."},{"line_number":205,"context_line":"  In cases where mount_point_prefix is missing from the share type,"},{"line_number":206,"context_line":"  the share\u0027s export location will be prefixed with the project_id."},{"line_number":207,"context_line":"  However, shares created with a project_id prefix are not eligible for"},{"line_number":208,"context_line":"  transfer.For these shares to be transferred to a different project,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"2199c7ac_39731c95","line":205,"range":{"start_line":205,"start_character":2,"end_line":205,"end_character":35},"in_reply_to":"1b5b7d55_3cd5b742","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":205,"context_line":"  In cases where mount_point_prefix is missing from the share type,"},{"line_number":206,"context_line":"  the share\u0027s export location will be prefixed with the project_id."},{"line_number":207,"context_line":"  However, shares created with a project_id prefix are not eligible for"},{"line_number":208,"context_line":"  transfer.For these shares to be transferred to a different project,"},{"line_number":209,"context_line":"  the admin will need to manually unmount them from the current project"},{"line_number":210,"context_line":"  and mount them to the target project."},{"line_number":211,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f6f2376_bc185011","line":208,"range":{"start_line":208,"start_character":10,"end_line":208,"end_character":12},"updated":"2024-03-05 17:52:25.000000000","message":"nit: please add a blank space after the period","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  In cases where mount_point_prefix is missing from the share type,"},{"line_number":206,"context_line":"  the share\u0027s export location will be prefixed with the project_id."},{"line_number":207,"context_line":"  However, shares created with a project_id prefix are not eligible for"},{"line_number":208,"context_line":"  transfer.For these shares to be transferred to a different project,"},{"line_number":209,"context_line":"  the admin will need to manually unmount them from the current project"},{"line_number":210,"context_line":"  and mount them to the target project."},{"line_number":211,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1639a0ef_3763c0d7","line":208,"range":{"start_line":208,"start_character":10,"end_line":208,"end_character":12},"in_reply_to":"1f6f2376_bc185011","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! added space now..","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":289,"context_line":"  only effective limit."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"* **provisioning:mount_point_prefix** can set prefix for human readable"},{"line_number":292,"context_line":"  mount_point_name, the value must be an string containing ASCII alphabets"},{"line_number":293,"context_line":"  and underscore are allowed."}],"source_content_type":"text/x-rst","patch_set":7,"id":"0e28fad3_e139807f","line":292,"range":{"start_line":292,"start_character":38,"end_line":292,"end_character":40},"updated":"2024-03-05 23:58:57.000000000","message":"a","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":289,"context_line":"  only effective limit."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"* **provisioning:mount_point_prefix** can set prefix for human readable"},{"line_number":292,"context_line":"  mount_point_name, the value must be an string containing ASCII alphabets"},{"line_number":293,"context_line":"  and underscore are allowed."}],"source_content_type":"text/x-rst","patch_set":7,"id":"20b310d5_05e5201c","line":292,"range":{"start_line":292,"start_character":38,"end_line":292,"end_character":40},"in_reply_to":"0e28fad3_e139807f","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated typo","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"* **provisioning:mount_point_prefix** can set prefix for human readable"},{"line_number":292,"context_line":"  mount_point_name, the value must be an string containing ASCII alphabets"},{"line_number":293,"context_line":"  and underscore are allowed."}],"source_content_type":"text/x-rst","patch_set":7,"id":"c628c5f9_19df6393","line":293,"range":{"start_line":293,"start_character":6,"end_line":293,"end_character":28},"updated":"2024-03-05 23:58:57.000000000","message":"\"optionally, the underscore character.\"","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"* **provisioning:mount_point_prefix** can set prefix for human readable"},{"line_number":292,"context_line":"  mount_point_name, the value must be an string containing ASCII alphabets"},{"line_number":293,"context_line":"  and underscore are allowed."}],"source_content_type":"text/x-rst","patch_set":7,"id":"4604ad7f_180e29a5","line":293,"range":{"start_line":293,"start_character":6,"end_line":293,"end_character":28},"in_reply_to":"c628c5f9_19df6393","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"}],"doc/source/admin/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"More information: :ref:`capabilities_and_extra_specs`"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+--------------+--------------+-------------------------+----------------------+"},{"line_number":265,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | dedupe | compression | thin_provisioning | thick_provisioning | qos | create share from snapshot | revert to snapshot | mountable snapshot | ipv4_support | ipv6_support | multiple subnets per AZ | human readable share |"},{"line_number":266,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":267,"context_line":"|               ZFSonLinux               |     \\-    |      M     |   M    |      M      |         M         |          \\-        | \\-  |              M             |          \\-        |          \\-        |       P      |      \\-      |           \\-            |           \\-         |"},{"line_number":268,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+--------------+--------------+-------------------------+----------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"824b079a_abe093f4","line":265,"range":{"start_line":265,"start_character":265,"end_line":265,"end_character":285},"updated":"2024-03-05 23:58:57.000000000","message":"call this \"mount point name support\" instead","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":262,"context_line":"More information: :ref:`capabilities_and_extra_specs`"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+--------------+--------------+-------------------------+----------------------+"},{"line_number":265,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | dedupe | compression | thin_provisioning | thick_provisioning | qos | create share from snapshot | revert to snapshot | mountable snapshot | ipv4_support | ipv6_support | multiple subnets per AZ | human readable share |"},{"line_number":266,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":267,"context_line":"|               ZFSonLinux               |     \\-    |      M     |   M    |      M      |         M         |          \\-        | \\-  |              M             |          \\-        |          \\-        |       P      |      \\-      |           \\-            |           \\-         |"},{"line_number":268,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+--------------+--------------+-------------------------+----------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"223a14db_25235539","line":265,"range":{"start_line":265,"start_character":280,"end_line":265,"end_character":285},"updated":"2024-03-05 17:52:25.000000000","message":"export location","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":262,"context_line":"More information: :ref:`capabilities_and_extra_specs`"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+--------------+--------------+-------------------------+----------------------+"},{"line_number":265,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | dedupe | compression | thin_provisioning | thick_provisioning | qos | create share from snapshot | revert to snapshot | mountable snapshot | ipv4_support | ipv6_support | multiple subnets per AZ | human readable share |"},{"line_number":266,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":267,"context_line":"|               ZFSonLinux               |     \\-    |      M     |   M    |      M      |         M         |          \\-        | \\-  |              M             |          \\-        |          \\-        |       P      |      \\-      |           \\-            |           \\-         |"},{"line_number":268,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+--------------+--------------+-------------------------+----------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"2794da0b_a06eb1fc","line":265,"range":{"start_line":265,"start_character":280,"end_line":265,"end_character":285},"in_reply_to":"223a14db_25235539","updated":"2024-03-06 20:53:12.000000000","message":"yes, update mount point name support as suggested by Goutham","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":262,"context_line":"More information: :ref:`capabilities_and_extra_specs`"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+--------------+--------------+-------------------------+----------------------+"},{"line_number":265,"context_line":"|              Driver name               | DHSS\u003dTrue | DHSS\u003dFalse | dedupe | compression | thin_provisioning | thick_provisioning | qos | create share from snapshot | revert to snapshot | mountable snapshot | ipv4_support | ipv6_support | multiple subnets per AZ | human readable share |"},{"line_number":266,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":267,"context_line":"|               ZFSonLinux               |     \\-    |      M     |   M    |      M      |         M         |          \\-        | \\-  |              M             |          \\-        |          \\-        |       P      |      \\-      |           \\-            |           \\-         |"},{"line_number":268,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+--------------+--------------+-------------------------+----------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"d3df3586_0f95a407","line":265,"range":{"start_line":265,"start_character":265,"end_line":265,"end_character":285},"in_reply_to":"824b079a_abe093f4","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fbc06b8d_49d7a142","updated":"2024-02-16 02:07:01.000000000","message":"There\u0027s another file you need to modify: \n\nhttps://opendev.org/openstack/manila/src/branch/master/manila/api/openstack/rest_api_version_history.rst","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b8529b3_ed697a17","in_reply_to":"fbc06b8d_49d7a142","updated":"2024-02-21 17:03:21.000000000","message":"Added current version details","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":200,"context_line":"    * 2.80 - Added share backup APIs."},{"line_number":201,"context_line":"    * 2.81 - Added API methods, endpoint /resource-locks."},{"line_number":202,"context_line":"    * 2.82 - Added lock and restriction to share access rules."},{"line_number":203,"context_line":"    * 2.83 - Added mount_point_name to shares."},{"line_number":204,"context_line":"\"\"\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":5,"id":"25b11be0_800b6287","line":203,"range":{"start_line":203,"start_character":0,"end_line":203,"end_character":46},"updated":"2024-02-23 10:10:27.000000000","message":"please be aware that microversion conflicts may arise when if we merge other patches before yours. Please be prepared to change to an appropriate microversion","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    * 2.80 - Added share backup APIs."},{"line_number":201,"context_line":"    * 2.81 - Added API methods, endpoint /resource-locks."},{"line_number":202,"context_line":"    * 2.82 - Added lock and restriction to share access rules."},{"line_number":203,"context_line":"    * 2.83 - Added mount_point_name to shares."},{"line_number":204,"context_line":"\"\"\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":5,"id":"064e0623_c0134948","line":203,"range":{"start_line":203,"start_character":0,"end_line":203,"end_character":46},"in_reply_to":"25b11be0_800b6287","updated":"2024-03-04 16:03:44.000000000","message":"rebased and updated version details every ware.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"}],"manila/api/v1/shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dca438c2270a2f833bdaef3a95f990fd7243532","unresolved":true,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        mount_point_name \u003d body.get(\u0027share\u0027).get(\u0027mount_point_name\u0027)"},{"line_number":449,"context_line":"        # appended with project_name to make mount_point_name unique."},{"line_number":450,"context_line":"        if mount_point_name is not None:"},{"line_number":451,"context_line":"            mount_point_name \u003d f\"{context.project_name}_{mount_point_name}\""}],"source_content_type":"text/x-python","patch_set":4,"id":"488c882c_d34ca47f","line":448,"range":{"start_line":448,"start_character":7,"end_line":448,"end_character":68},"updated":"2024-02-15 12:42:00.000000000","message":"this could be simplified to mount_point_name \u003d share.get(\u0027mount_point_name\u0027), as the share variable already holds the value for body.get(\u0027share\u0027)","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        mount_point_name \u003d body.get(\u0027share\u0027).get(\u0027mount_point_name\u0027)"},{"line_number":449,"context_line":"        # appended with project_name to make mount_point_name unique."},{"line_number":450,"context_line":"        if mount_point_name is not None:"},{"line_number":451,"context_line":"            mount_point_name \u003d f\"{context.project_name}_{mount_point_name}\""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf932e1e_bc3d72d0","line":448,"range":{"start_line":448,"start_character":8,"end_line":448,"end_character":24},"updated":"2024-02-16 02:07:01.000000000","message":"where are the micro-version checks for this parameter? \nYou must prevent the usage of this parameter with older API microversions. E.g.: \n\nhttps://opendev.org/openstack/manila/src/branch/master/manila/api/v2/shares.py#L192-L227","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        mount_point_name \u003d body.get(\u0027share\u0027).get(\u0027mount_point_name\u0027)"},{"line_number":449,"context_line":"        # appended with project_name to make mount_point_name unique."},{"line_number":450,"context_line":"        if mount_point_name is not None:"},{"line_number":451,"context_line":"            mount_point_name \u003d f\"{context.project_name}_{mount_point_name}\""}],"source_content_type":"text/x-python","patch_set":4,"id":"0f41e925_a6e26f5e","line":448,"range":{"start_line":448,"start_character":7,"end_line":448,"end_character":68},"in_reply_to":"488c882c_d34ca47f","updated":"2024-02-21 17:03:21.000000000","message":"Replaced with share","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        mount_point_name \u003d body.get(\u0027share\u0027).get(\u0027mount_point_name\u0027)"},{"line_number":449,"context_line":"        # appended with project_name to make mount_point_name unique."},{"line_number":450,"context_line":"        if mount_point_name is not None:"},{"line_number":451,"context_line":"            mount_point_name \u003d f\"{context.project_name}_{mount_point_name}\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9375fa6a_7b2f0ee0","line":448,"range":{"start_line":448,"start_character":8,"end_line":448,"end_character":24},"in_reply_to":"bf932e1e_bc3d72d0","updated":"2024-02-21 17:03:21.000000000","message":"Added version check for mount_point_name","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[{"line_number":448,"context_line":"        mount_point_name \u003d body.get(\u0027share\u0027).get(\u0027mount_point_name\u0027)"},{"line_number":449,"context_line":"        # appended with project_name to make mount_point_name unique."},{"line_number":450,"context_line":"        if mount_point_name is not None:"},{"line_number":451,"context_line":"            mount_point_name \u003d f\"{context.project_name}_{mount_point_name}\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        kwargs[\u0027mount_point_name\u0027] \u003d mount_point_name"},{"line_number":454,"context_line":"        new_share \u003d self.share_api.create(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e3eb6b1c_49d448d1","line":451,"range":{"start_line":451,"start_character":33,"end_line":451,"end_character":55},"updated":"2024-02-16 02:07:01.000000000","message":"I remember the original spec  [1] calling out the \"project_name\"; but, keystone project names can be changed: https://docs.openstack.org/keystone/latest/admin/cli-manage-projects-users-and-roles.html#update-a-project and sometimes are just too long (255 characters). \n\nCan we allow the share type to contain an override to this prefix?\n\nPerhaps through an extra-spec:\n\n```\n  RESKEY:mount_point_name_prefix\n```\n\n[1] https://specs.openstack.org/openstack/manila-specs/specs/xena/spec-lite-add-human-readable-export-locations.html","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        mount_point_name \u003d body.get(\u0027share\u0027).get(\u0027mount_point_name\u0027)"},{"line_number":449,"context_line":"        # appended with project_name to make mount_point_name unique."},{"line_number":450,"context_line":"        if mount_point_name is not None:"},{"line_number":451,"context_line":"            mount_point_name \u003d f\"{context.project_name}_{mount_point_name}\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        kwargs[\u0027mount_point_name\u0027] \u003d mount_point_name"},{"line_number":454,"context_line":"        new_share \u003d self.share_api.create(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7bf721d7_5c67f9b8","line":451,"range":{"start_line":451,"start_character":33,"end_line":451,"end_character":55},"in_reply_to":"e3eb6b1c_49d448d1","updated":"2024-02-21 17:03:21.000000000","message":"reformatted error message to show project_name + mount_point_name is exceeding 255 characters. Regarding \"mount_point_name_prefix\", this is not part of spec https://review.opendev.org/c/openstack/manila-specs/+/797776. This is my first Manila PR and taking time to implement. Can i take new PR for this change.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        mount_point_name \u003d share.get(\u0027mount_point_name\u0027)"},{"line_number":449,"context_line":"        # appended with project_name to make mount_point_name unique."},{"line_number":450,"context_line":"        if mount_point_name is not None:"},{"line_number":451,"context_line":"            mount_point_name \u003d f\"{context.project_name}_{mount_point_name}\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        kwargs[\u0027mount_point_name\u0027] \u003d mount_point_name"},{"line_number":454,"context_line":"        new_share \u003d self.share_api.create(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"4c78bad4_a0beb322","line":451,"range":{"start_line":448,"start_character":0,"end_line":451,"end_character":75},"updated":"2024-02-23 10:10:27.000000000","message":"Lets move the construction of the mount_point_name to share/api.py... The reason being,\n1) we\u0027ll have to add the logic to figure out the mount point name post our discussion in the collab review.\n2) you\u0027re validating the mount_point_name already in share/api.py (LINK) ... so we can construct the mount_point_name just before that validation\n3) You need to implement \"mount_point_name\" even for the manage share workflow... not just create. Create and Manage are very similar; the difference is that in \"manage\", we expect a share to exist outside of manila... and if you do the construction and validation in share/api.py, you can share a common method with the \"manage\" API:\n\nRepeating our discussion at the collab review,\nusing \"context.project_name\" as a prefix may not be always appropriate, because:\n1) Project names are not expected to be URL safe always; for example \"this is my project name\" is an appropriate project name\n2) Project names can be 64 characters long.. while they\u0027re available to end users, and hence \"deterministic\", they do end up eating a chunk of the 256 characters available for the mount point name\n3) Project names can be modified at any time directly on keystone. Doing this will leave manila share mount point names out of sync\n4) Project names are inappropriate during share transfer - i.e., when a share moves between projects, we\u0027d be leaking the original project\u0027s name to the new project\u0027s users through the mount point name.\n\nSo my suggestion was to allow the configuration of a prefix via share type extra-specs; this can be:\n\n\"provisioning:mount_point_prefix\"\n\nThis key can be made tenant-visible, so, users will always know what the prefix is by examining the share type\n\nHowever, this also suffers some downsides (credits to Maurice):\n\n1) What if an admin \"forgets\" to configure a \"provisioning:mount_point_prefix\"?\n\n   a) should we refuse to create any shares with \"mount_point_name\"?\n   b) should we use the share type\u0027s name as a prefix?\n   c) should we use the project_name or project_id as the default prefix?\n\n2) If a share type is shared among multiple projects, you can\u0027t have a common static prefix... Lets say this prefix is set to \"share_\".. a user from project XYZZY creates a share with mount_point_name \"testshare\". We\u0027ll set the mount_point_name to be \"share_testshare\". A user from project ACME can try to create a share with the same mount_point_name and the same share type, if the shares end up on the same storage pool, you\u0027ll have an export path collision; and the user has unexpectedly learned that there is a share whose export path has \"share_testshare\". If they are malicious, they can attempt to guess the rest of the export path and attempt to mount the share. If project XYZZY has set their share access rules wide open, this is a sure shot way of leaking share data.\n\nI think the solution here can be a combination; some ideas:\n\na) We could allow \"provisioning:mount_point_prefix\" to be a templatable string:\n\n   for example: \"{context.project_id}\" or \"{context.project_name}\"\n   (ofcourse they can use a regular string too, if they don\u0027t want to template it)\n\n   Doing this will give us the best of both worlds, and we can try to address some of the concerns with project identity like this:\n\n- \"{context.project_id}\" can be the default if the administrator doesn\u0027t configure \"provisioning:mount_point_prefix\"\n- This _might_ avoid leaking information regarding the existence of other shares; with a caveat - if an admin sets the \"provisioning:mount_point_prefix\" to a constant string, e.g.: \"gold\", and then shares the share type with multiple projects, they have intentionally opened a security hole. We can mention this in the docs.\n- During share transfer, we can look at \"provisioning:mount_point_prefix\", and if there\u0027s a project_id or project_name there, we can refuse to transfer with HTTP 400, indicating that the share has some project identity that needs administrator intervention to perform the transfer. Administrators will need to unmanage and manage the share into the appropriate project. This behavior must also be documented.\n- We can construct the mount_point_name by using the prefix from the share type and the suffix from the user and then validate this to be ASCII alphanumeric (allowing only underscores in addition)... if this validation fails, we can log and return an error that the mount_point_name isn\u0027t appropriate. This behavior must also be documented.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        mount_point_name \u003d share.get(\u0027mount_point_name\u0027)"},{"line_number":449,"context_line":"        # appended with project_name to make mount_point_name unique."},{"line_number":450,"context_line":"        if mount_point_name is not None:"},{"line_number":451,"context_line":"            mount_point_name \u003d f\"{context.project_name}_{mount_point_name}\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        kwargs[\u0027mount_point_name\u0027] \u003d mount_point_name"},{"line_number":454,"context_line":"        new_share \u003d self.share_api.create(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"53000f2f_4b936e93","line":451,"range":{"start_line":448,"start_character":0,"end_line":451,"end_character":75},"in_reply_to":"4c78bad4_a0beb322","updated":"2024-03-04 16:03:44.000000000","message":"Thank you! addressed all scenarios.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4669d86fdcb77bcba1378a95300fe0d8b47b16c","unresolved":true,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        if req.api_version_request \u003e\u003d api_version.APIVersionRequest(\"2.84\"):"},{"line_number":450,"context_line":"            kwargs[\u0027mount_point_name\u0027] \u003d share.pop(\u0027mount_point_name\u0027, None)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        new_share \u003d self.share_api.create(context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"72789591_2e936566","line":449,"updated":"2024-03-06 23:06:54.000000000","message":"you could add a unit test for this..","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        if req.api_version_request \u003e\u003d api_version.APIVersionRequest(\"2.84\"):"},{"line_number":450,"context_line":"            kwargs[\u0027mount_point_name\u0027] \u003d share.pop(\u0027mount_point_name\u0027, None)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        new_share \u003d self.share_api.create(context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"0499e49e_0ee0b1cc","line":449,"in_reply_to":"72789591_2e936566","updated":"2024-03-07 22:25:10.000000000","message":"Added UTs to cover this scenario.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"}],"manila/api/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        return data"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    @wsgi.Controller.api_version(\"2.83\")"},{"line_number":193,"context_line":"    def create(self, req, body):"},{"line_number":194,"context_line":"        if not self.is_valid_body(body, \u0027share\u0027):"},{"line_number":195,"context_line":"            raise exc.HTTPUnprocessableEntity()"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        scheduler_hints \u003d body.get(\u0027share\u0027, {}).pop(\u0027scheduler_hints\u0027, None)"},{"line_number":198,"context_line":"        return self._create(req, body,"},{"line_number":199,"context_line":"                            check_create_share_from_snapshot_support\u003dTrue,"},{"line_number":200,"context_line":"                            check_availability_zones_extra_spec\u003dTrue,"},{"line_number":201,"context_line":"                            scheduler_hints\u003dscheduler_hints)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @wsgi.Controller.api_version(\"2.65\", \"2.82\") # noqa"},{"line_number":204,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ddda22d_5acb869b","line":201,"range":{"start_line":192,"start_character":3,"end_line":201,"end_character":60},"updated":"2024-02-23 10:10:27.000000000","message":"I think we\u0027re propagating a painful pattern here....\nWe\u0027re validating the body here L194-195 and L205-206.. and this validation is also happening in the _create() method...\nInstead of double validating, we ought to move the validation to each of the create methods..\n\nOR\n\njust make a simple microversion check in _create instead!\n\n```\nshare \u003d body[\u0027share\u0027]\n...\n\nif req.api_version_request \u003e\u003d api_version.APIVersionRequest(\"2.83\"):\n    kwargs[\u0027mount_point_name\u0027] \u003d share.pop(\u0027mount_point_name\u0027, None)\n```\n\n(there\u0027s no \"else\"; i.e., mount_point_name is ignored for all lower microversions)\n\nDoing this is simpler and more readable, and you don\u0027t need to make any changes to this file","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        return data"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    @wsgi.Controller.api_version(\"2.83\")"},{"line_number":193,"context_line":"    def create(self, req, body):"},{"line_number":194,"context_line":"        if not self.is_valid_body(body, \u0027share\u0027):"},{"line_number":195,"context_line":"            raise exc.HTTPUnprocessableEntity()"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        scheduler_hints \u003d body.get(\u0027share\u0027, {}).pop(\u0027scheduler_hints\u0027, None)"},{"line_number":198,"context_line":"        return self._create(req, body,"},{"line_number":199,"context_line":"                            check_create_share_from_snapshot_support\u003dTrue,"},{"line_number":200,"context_line":"                            check_availability_zones_extra_spec\u003dTrue,"},{"line_number":201,"context_line":"                            scheduler_hints\u003dscheduler_hints)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @wsgi.Controller.api_version(\"2.65\", \"2.82\") # noqa"},{"line_number":204,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b94d099_1215fec0","line":201,"range":{"start_line":192,"start_character":3,"end_line":201,"end_character":60},"in_reply_to":"9ddda22d_5acb869b","updated":"2024-03-04 16:03:44.000000000","message":"updated to do version check in _create.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"}],"manila/common/constants.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":304,"context_line":"    PROVISIONING_MAX_SHARE_SIZE \u003d \"provisioning:max_share_size\""},{"line_number":305,"context_line":"    PROVISIONING_MIN_SHARE_SIZE \u003d \"provisioning:min_share_size\""},{"line_number":306,"context_line":"    PROVISIONING_MAX_SHARE_EXTEND_SIZE \u003d \"provisioning:max_share_extend_size\""},{"line_number":307,"context_line":"    MOUNT_POINT_NAME \u003d \"mount_point_name\""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    # Extra specs containers"},{"line_number":310,"context_line":"    REQUIRED \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"ca7ec7ef_54ac43a9","line":307,"updated":"2024-02-23 10:10:27.000000000","message":"you need two constants:\n\n   HUMAN_READABLE_EXPORT_LOCATION_SUPPORT \u003d \u0027human_readable_export_location_support\u0027\n   HUMAN_READABLE_EXPORT_LOCATION_SUPPORT \u003d \"provisioning:mount_point_prefix\"","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    PROVISIONING_MAX_SHARE_SIZE \u003d \"provisioning:max_share_size\""},{"line_number":305,"context_line":"    PROVISIONING_MIN_SHARE_SIZE \u003d \"provisioning:min_share_size\""},{"line_number":306,"context_line":"    PROVISIONING_MAX_SHARE_EXTEND_SIZE \u003d \"provisioning:max_share_extend_size\""},{"line_number":307,"context_line":"    MOUNT_POINT_NAME \u003d \"mount_point_name\""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    # Extra specs containers"},{"line_number":310,"context_line":"    REQUIRED \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"1b6fb354_c94f07d3","line":307,"in_reply_to":"ca7ec7ef_54ac43a9","updated":"2024-03-04 16:03:44.000000000","message":"yes, added to support share type \"provisioning:mount_point_prefix\" and verified all scenarios.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":321,"context_line":"        PROVISIONING_MAX_SHARE_SIZE,"},{"line_number":322,"context_line":"        PROVISIONING_MIN_SHARE_SIZE,"},{"line_number":323,"context_line":"        PROVISIONING_MAX_SHARE_EXTEND_SIZE,"},{"line_number":324,"context_line":"        MOUNT_POINT_NAME"},{"line_number":325,"context_line":"    )"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    # NOTE(cknight): Some extra specs are necessary parts of the Manila API and"}],"source_content_type":"text/x-python","patch_set":5,"id":"325dab15_ad0d681d","line":324,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma, and you need both new constants here: HUMAN_READABLE_EXPORT_LOCATION_SUPPORT, HUMAN_READABLE_EXPORT_LOCATION_SUPPORT","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        PROVISIONING_MAX_SHARE_SIZE,"},{"line_number":322,"context_line":"        PROVISIONING_MIN_SHARE_SIZE,"},{"line_number":323,"context_line":"        PROVISIONING_MAX_SHARE_EXTEND_SIZE,"},{"line_number":324,"context_line":"        MOUNT_POINT_NAME"},{"line_number":325,"context_line":"    )"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    # NOTE(cknight): Some extra specs are necessary parts of the Manila API and"}],"source_content_type":"text/x-python","patch_set":5,"id":"4a83d6d5_58300c79","line":324,"in_reply_to":"325dab15_ad0d681d","updated":"2024-03-04 16:03:44.000000000","message":"trailing commas are added.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":299,"context_line":"    REPLICATION_TYPE_SPEC \u003d \"replication_type\""},{"line_number":300,"context_line":"    CREATE_SHARE_FROM_SNAPSHOT_SUPPORT \u003d \"create_share_from_snapshot_support\""},{"line_number":301,"context_line":"    REVERT_TO_SNAPSHOT_SUPPORT \u003d \"revert_to_snapshot_support\""},{"line_number":302,"context_line":"    MOUNT_SNAPSHOT_SUPPORT \u003d \"mount_snapshot_support\""},{"line_number":303,"context_line":"    AVAILABILITY_ZONES \u003d \"availability_zones\""},{"line_number":304,"context_line":"    PROVISIONING_MAX_SHARE_SIZE \u003d \"provisioning:max_share_size\""},{"line_number":305,"context_line":"    PROVISIONING_MIN_SHARE_SIZE \u003d \"provisioning:min_share_size\""}],"source_content_type":"text/x-python","patch_set":7,"id":"6712b8b9_de636c78","line":302,"updated":"2024-03-05 23:58:57.000000000","message":"don\u0027t you need:\n\nMOUNT_POINT_NAME_SUPPORT as well?","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    REPLICATION_TYPE_SPEC \u003d \"replication_type\""},{"line_number":300,"context_line":"    CREATE_SHARE_FROM_SNAPSHOT_SUPPORT \u003d \"create_share_from_snapshot_support\""},{"line_number":301,"context_line":"    REVERT_TO_SNAPSHOT_SUPPORT \u003d \"revert_to_snapshot_support\""},{"line_number":302,"context_line":"    MOUNT_SNAPSHOT_SUPPORT \u003d \"mount_snapshot_support\""},{"line_number":303,"context_line":"    AVAILABILITY_ZONES \u003d \"availability_zones\""},{"line_number":304,"context_line":"    PROVISIONING_MAX_SHARE_SIZE \u003d \"provisioning:max_share_size\""},{"line_number":305,"context_line":"    PROVISIONING_MIN_SHARE_SIZE \u003d \"provisioning:min_share_size\""}],"source_content_type":"text/x-python","patch_set":7,"id":"d1a73597_39402e1b","line":302,"in_reply_to":"6712b8b9_de636c78","updated":"2024-03-06 20:53:12.000000000","message":"yes added MOUNT_POINT_NAME_SUPPORT","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":321,"context_line":"        PROVISIONING_MAX_SHARE_SIZE,"},{"line_number":322,"context_line":"        PROVISIONING_MIN_SHARE_SIZE,"},{"line_number":323,"context_line":"        PROVISIONING_MAX_SHARE_EXTEND_SIZE,"},{"line_number":324,"context_line":"        PROVISIONING_MOUNT_POINT_PREFIX,"},{"line_number":325,"context_line":"    )"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    # NOTE(cknight): Some extra specs are necessary parts of the Manila API and"}],"source_content_type":"text/x-python","patch_set":7,"id":"455a1675_9736eac2","line":324,"updated":"2024-03-05 23:58:57.000000000","message":"this should also include:\n\n\n\"MOUNT_POINT_NAME_SUPPORT\"","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        PROVISIONING_MAX_SHARE_SIZE,"},{"line_number":322,"context_line":"        PROVISIONING_MIN_SHARE_SIZE,"},{"line_number":323,"context_line":"        PROVISIONING_MAX_SHARE_EXTEND_SIZE,"},{"line_number":324,"context_line":"        PROVISIONING_MOUNT_POINT_PREFIX,"},{"line_number":325,"context_line":"    )"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    # NOTE(cknight): Some extra specs are necessary parts of the Manila API and"}],"source_content_type":"text/x-python","patch_set":7,"id":"89cf473c_8cfc7c81","line":324,"in_reply_to":"455a1675_9736eac2","updated":"2024-03-06 20:53:12.000000000","message":"yes added MOUNT_POINT_NAME_SUPPORT","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"929bd65ec75ac171241f9a563342b28ab0fe160f","unresolved":true,"context_lines":[{"line_number":347,"context_line":"        CREATE_SHARE_FROM_SNAPSHOT_SUPPORT: False,"},{"line_number":348,"context_line":"        REVERT_TO_SNAPSHOT_SUPPORT: False,"},{"line_number":349,"context_line":"        MOUNT_SNAPSHOT_SUPPORT: False,"},{"line_number":350,"context_line":"        MOUNT_POINT_NAME_SUPPORT: False,"},{"line_number":351,"context_line":"    }"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    REPLICATION_TYPES \u003d (\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"cb1f96fa_d1635b21","line":350,"range":{"start_line":350,"start_character":0,"end_line":350,"end_character":40},"updated":"2024-03-06 22:59:08.000000000","message":"unfortunately, adding this here is breaking existing tempest tests:\n\n manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsNFS. test_migration_files\n \n and \n \n manila_tempest_tests.tests.api.admin.test_share_types_extra_specs_negative.ExtraSpecsAdminNegativeTest.test_try_read_extra_specs_on_share_type_with_user\n \n \nThe first test expects to see extra-specs of the \"default\" share type match exactly with what the backend is reporting - this is how it finds a good second backend to migrate a share to; however, after this change, the default share type has \"mount_point_name_support\u003dFalse\" (an inferred default value); but, the driver itself could be reporting \"True\" (LVM driver is supporting this feature within this patch)... One way to fix this is by amending the default share type extra specs provided to the job [1] but that\u0027ll break all sorts of things because it\u0027ll introduce a chicken and egg problem... \n\n\nThe second test case [2] creates a new share type, and verifies the response to match exactly what\u0027s created; and it doesn\u0027t know about mount_point_name_support yet.\n\n\n[1] https://opendev.org/openstack/manila-tempest-plugin/src/commit/bdc5ad5961ce18aa72719e2a5aaf0d32f806e8f3/zuul.d/manila-tempest-jobs.yaml#L212\n[2] https://opendev.org/openstack/manila-tempest-plugin/src/commit/bdc5ad5961ce18aa72719e2a5aaf0d32f806e8f3/manila_tempest_tests/tests/api/admin/test_share_types_extra_specs_negative.py#L75-L92\n\n\nSo, lets take it out of this map.. the impact of doing that:\n\nWhen \"mount_point_name_support\" isn\u0027t provided in a share type, it \nis assumed to be False, and, end users won\u0027t see it when they use \"openstack share type list\"... \n\nthis is different from \"snapshot_support\" or \"mount_snapshot_support\" or \"revert_to_snapshot_support\"; but i guess we\u0027ll live with that.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        CREATE_SHARE_FROM_SNAPSHOT_SUPPORT: False,"},{"line_number":348,"context_line":"        REVERT_TO_SNAPSHOT_SUPPORT: False,"},{"line_number":349,"context_line":"        MOUNT_SNAPSHOT_SUPPORT: False,"},{"line_number":350,"context_line":"        MOUNT_POINT_NAME_SUPPORT: False,"},{"line_number":351,"context_line":"    }"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    REPLICATION_TYPES \u003d (\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"07730791_21ba2025","line":350,"range":{"start_line":350,"start_character":0,"end_line":350,"end_character":40},"in_reply_to":"cb1f96fa_d1635b21","updated":"2024-03-07 22:25:10.000000000","message":"Thank you! Moved out of inferred optional map based on your suggestion.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"}],"manila/db/migrations/alembic/versions/40d1f2374e89_add_mount_point_name_to_share_instances.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    try:"},{"line_number":36,"context_line":"        op.add_column(share_table_name, sa.Column(column_name,"},{"line_number":37,"context_line":"                                                  sa.String(255), default\u003d0))"},{"line_number":38,"context_line":"    except Exception:"},{"line_number":39,"context_line":"        LOG.error(\"Column mount_point_name not created!\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"bbc41c15_bd1d6879","line":36,"updated":"2024-02-16 02:07:01.000000000","message":"please call this \"share_instances_table_name\" or just \"table_name\"","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    try:"},{"line_number":36,"context_line":"        op.add_column(share_table_name, sa.Column(column_name,"},{"line_number":37,"context_line":"                                                  sa.String(255), default\u003d0))"},{"line_number":38,"context_line":"    except Exception:"},{"line_number":39,"context_line":"        LOG.error(\"Column mount_point_name not created!\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"8aef48db_04fafc9e","line":36,"in_reply_to":"bbc41c15_bd1d6879","updated":"2024-02-21 17:03:21.000000000","message":"yes, updated name to \"share_instances_table_name\". sorry, copy past error.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    try:"},{"line_number":36,"context_line":"        op.add_column(share_table_name, sa.Column(column_name,"},{"line_number":37,"context_line":"                                                  sa.String(255), default\u003d0))"},{"line_number":38,"context_line":"    except Exception:"},{"line_number":39,"context_line":"        LOG.error(\"Column mount_point_name not created!\")"},{"line_number":40,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"39228cc6_8de196e5","line":37,"range":{"start_line":37,"start_character":65,"end_line":37,"end_character":76},"updated":"2024-02-16 02:07:01.000000000","message":"set `nullable\u003dTrue` instead","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    try:"},{"line_number":36,"context_line":"        op.add_column(share_table_name, sa.Column(column_name,"},{"line_number":37,"context_line":"                                                  sa.String(255), default\u003d0))"},{"line_number":38,"context_line":"    except Exception:"},{"line_number":39,"context_line":"        LOG.error(\"Column mount_point_name not created!\")"},{"line_number":40,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"95a9af1b_2382a9cc","line":37,"range":{"start_line":37,"start_character":65,"end_line":37,"end_character":76},"in_reply_to":"39228cc6_8de196e5","updated":"2024-02-21 17:03:21.000000000","message":"updated to nullable\u003dTrue","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\"\"\"add mount_point_name to share_instances"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 6e32091979e0"},{"line_number":16,"context_line":"Revises: 2d708a9a3ba9"},{"line_number":17,"context_line":"Create Date: 2024-01-26 22:08:22.412974"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"# revision identifiers, used by Alembic."}],"source_content_type":"text/x-python","patch_set":7,"id":"5efdf3ba_3bdb3fb3","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"updated":"2024-03-05 23:58:57.000000000","message":"please update this as well","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"add mount_point_name to share_instances"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 6e32091979e0"},{"line_number":16,"context_line":"Revises: 2d708a9a3ba9"},{"line_number":17,"context_line":"Create Date: 2024-01-26 22:08:22.412974"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"# revision identifiers, used by Alembic."}],"source_content_type":"text/x-python","patch_set":7,"id":"f7cd6090_2057d73d","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"in_reply_to":"5efdf3ba_3bdb3fb3","updated":"2024-03-06 20:53:12.000000000","message":"missed, updated comment.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"}],"manila/db/migrations/alembic/versions/6e32091979e0_add_mount_point_name_to_shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dca438c2270a2f833bdaef3a95f990fd7243532","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"24e55cb9_ed3993ef","line":1,"updated":"2024-02-15 12:42:00.000000000","message":"I believe both columns could be added in the same migration change","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"7c271322_56b0e586","line":1,"in_reply_to":"24e55cb9_ed3993ef","updated":"2024-02-16 02:07:01.000000000","message":"True, but also, Why are two columns necessary for \"mount_point_name\"?\n\nIs this field more appropriate on share instances or shares?\n\nCan multiple share instances of the same share have different mount point names? if yes, how can one provide that information? The only way a user can create a share instance today is when they create a share replica...","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"97fda24d_ffcfe3d8","line":1,"in_reply_to":"7c271322_56b0e586","updated":"2024-02-21 17:03:21.000000000","message":"True, I don\u0027t need shares table change...removed.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[{"line_number":321,"context_line":"    task_state \u003d Column(String(255))"},{"line_number":322,"context_line":"    is_soft_deleted \u003d Column(Boolean, default\u003dFalse)"},{"line_number":323,"context_line":"    scheduled_to_be_deleted_at \u003d Column(DateTime)"},{"line_number":324,"context_line":"    mount_point_name \u003d Column(String(255))"},{"line_number":325,"context_line":"    instances \u003d orm.relationship("},{"line_number":326,"context_line":"        \"ShareInstance\","},{"line_number":327,"context_line":"        lazy\u003d\u0027subquery\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"b39ec23b_37ce14e1","line":324,"updated":"2024-02-16 02:07:01.000000000","message":"same comment as in the migration. This column either belongs in the Shares table or ShareInstances table; not both","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    task_state \u003d Column(String(255))"},{"line_number":322,"context_line":"    is_soft_deleted \u003d Column(Boolean, default\u003dFalse)"},{"line_number":323,"context_line":"    scheduled_to_be_deleted_at \u003d Column(DateTime)"},{"line_number":324,"context_line":"    mount_point_name \u003d Column(String(255))"},{"line_number":325,"context_line":"    instances \u003d orm.relationship("},{"line_number":326,"context_line":"        \"ShareInstance\","},{"line_number":327,"context_line":"        lazy\u003d\u0027subquery\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ce5a3014_c5e6cf50","line":324,"in_reply_to":"b39ec23b_37ce14e1","updated":"2024-02-21 17:03:21.000000000","message":"True, I don\u0027t need shares table change...removed.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    @property"},{"line_number":355,"context_line":"    def name(self):"},{"line_number":356,"context_line":"        if self.mount_point_name is not None:"},{"line_number":357,"context_line":"            return self.mount_point_name"},{"line_number":358,"context_line":"        return CONF.share_name_template % self.id"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"6d5e92ce_b8b6e681","line":357,"range":{"start_line":356,"start_character":8,"end_line":357,"end_character":40},"updated":"2024-03-05 17:52:25.000000000","message":"I think this could break some workflows. Name \u003d share name, specified during the creation. If we return mount point name instead, we\u0027d be showing the mount point name instead of the name, and that doesn\u0027t allow users to properly filter shares, and could result in not found, when the share actually exists... I might be missing something, so what would be the use here?","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    @property"},{"line_number":355,"context_line":"    def name(self):"},{"line_number":356,"context_line":"        if self.mount_point_name is not None:"},{"line_number":357,"context_line":"            return self.mount_point_name"},{"line_number":358,"context_line":"        return CONF.share_name_template % self.id"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"1b43050e_267ad1e8","line":357,"range":{"start_line":356,"start_character":8,"end_line":357,"end_character":40},"in_reply_to":"0a186e64_7436fbce","updated":"2024-03-06 20:53:12.000000000","message":"thank you! moved logic to diriver","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9836a98fa6f48658f1b885d0ea871716a938eb86","unresolved":true,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    @property"},{"line_number":355,"context_line":"    def name(self):"},{"line_number":356,"context_line":"        if self.mount_point_name is not None:"},{"line_number":357,"context_line":"            return self.mount_point_name"},{"line_number":358,"context_line":"        return CONF.share_name_template % self.id"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"0a186e64_7436fbce","line":357,"range":{"start_line":356,"start_character":8,"end_line":357,"end_character":40},"in_reply_to":"6d5e92ce_b8b6e681","updated":"2024-03-06 00:04:46.000000000","message":"Hmmm, I think this change should be left to the driver instead of here. I.e., when exporting, the LVM driver seems to be looking at share[\"name\"] to construct export locations.. so this logic should be modified instead:\n\nhttps://github.com/openstack/manila/blob/f4c77bfe7111bc000ba3f663ce5820f06a7df17b/manila/share/drivers/lvm.py#L276-L277","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"}],"manila/scheduler/filters/capabilities.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dca438c2270a2f833bdaef3a95f990fd7243532","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":40,"context_line":"        \"\"\"Return a list of hosts that can create resource_type.\"\"\""},{"line_number":41,"context_line":"        resource_type \u003d filter_properties.get(\u0027resource_type\u0027)"},{"line_number":42,"context_line":"        mount_point_name \u003d ("},{"line_number":43,"context_line":"            filter_properties.get(\u0027request_spec\u0027, {})"},{"line_number":44,"context_line":"            .get(\u0027share_properties\u0027, {}).get(\u0027mount_point_name\u0027))"},{"line_number":45,"context_line":"        human_readable_export_location_support \u003d ("},{"line_number":46,"context_line":"            host_state.capabilities.get"},{"line_number":47,"context_line":"            (\u0027human_readable_export_location_support\u0027, False))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if (mount_point_name is not None and"},{"line_number":50,"context_line":"                not human_readable_export_location_support):"},{"line_number":51,"context_line":"            return False"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if not self._satisfies_extra_specs(host_state.capabilities,"},{"line_number":54,"context_line":"                                           resource_type):"}],"source_content_type":"text/x-python","patch_set":4,"id":"989d5af3_c696e1f8","line":51,"range":{"start_line":42,"start_character":8,"end_line":51,"end_character":24},"updated":"2024-02-15 12:42:00.000000000","message":"have you tried the code without this fragment? I have a feeling that it would work, as the share type would have the extra specs set, and the scheduler would already make the call... Am I missing something?","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":40,"context_line":"        \"\"\"Return a list of hosts that can create resource_type.\"\"\""},{"line_number":41,"context_line":"        resource_type \u003d filter_properties.get(\u0027resource_type\u0027)"},{"line_number":42,"context_line":"        mount_point_name \u003d ("},{"line_number":43,"context_line":"            filter_properties.get(\u0027request_spec\u0027, {})"},{"line_number":44,"context_line":"            .get(\u0027share_properties\u0027, {}).get(\u0027mount_point_name\u0027))"},{"line_number":45,"context_line":"        human_readable_export_location_support \u003d ("},{"line_number":46,"context_line":"            host_state.capabilities.get"},{"line_number":47,"context_line":"            (\u0027human_readable_export_location_support\u0027, False))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if (mount_point_name is not None and"},{"line_number":50,"context_line":"                not human_readable_export_location_support):"},{"line_number":51,"context_line":"            return False"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if not self._satisfies_extra_specs(host_state.capabilities,"},{"line_number":54,"context_line":"                                           resource_type):"}],"source_content_type":"text/x-python","patch_set":4,"id":"800e2229_4371a248","line":51,"range":{"start_line":42,"start_character":8,"end_line":51,"end_character":24},"in_reply_to":"94521699_127a79d3","updated":"2024-02-21 17:03:21.000000000","message":"True, removed this part of code.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    def host_passes(self, host_state, filter_properties):"},{"line_number":40,"context_line":"        \"\"\"Return a list of hosts that can create resource_type.\"\"\""},{"line_number":41,"context_line":"        resource_type \u003d filter_properties.get(\u0027resource_type\u0027)"},{"line_number":42,"context_line":"        mount_point_name \u003d ("},{"line_number":43,"context_line":"            filter_properties.get(\u0027request_spec\u0027, {})"},{"line_number":44,"context_line":"            .get(\u0027share_properties\u0027, {}).get(\u0027mount_point_name\u0027))"},{"line_number":45,"context_line":"        human_readable_export_location_support \u003d ("},{"line_number":46,"context_line":"            host_state.capabilities.get"},{"line_number":47,"context_line":"            (\u0027human_readable_export_location_support\u0027, False))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if (mount_point_name is not None and"},{"line_number":50,"context_line":"                not human_readable_export_location_support):"},{"line_number":51,"context_line":"            return False"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if not self._satisfies_extra_specs(host_state.capabilities,"},{"line_number":54,"context_line":"                                           resource_type):"}],"source_content_type":"text/x-python","patch_set":4,"id":"94521699_127a79d3","line":51,"range":{"start_line":42,"start_character":8,"end_line":51,"end_character":24},"in_reply_to":"989d5af3_c696e1f8","updated":"2024-02-16 02:07:01.000000000","message":"Agree; \n\nDon\u0027t need this code; the share type needs to have \"human_readable_export_location_support\" set to true. \n\nI think:\n\n\"human_readable_export_location_support\" can be a user visible extra-spec: https://docs.openstack.org/manila/latest/admin/capabilities_and_extra_specs.html#common-capabilities\n\nSo make sure to introduce it in: https://opendev.org/openstack/manila/src/commit/a7ffbf7bd0b62fea1c94eaaa6cc518298704ad85/manila/common/constants.py#L313-L322","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"}],"manila/scheduler/host_manager.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"f219b517986bf1252c9c40c740b1ed19c28b3a41","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        self.security_service_update_support \u003d False"},{"line_number":163,"context_line":"        self.network_allocation_update_support \u003d False"},{"line_number":164,"context_line":"        self.share_server_multiple_subnet_support \u003d False"},{"line_number":165,"context_line":"        self.human_readable_export_location_support \u003d False"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # PoolState for all pools"},{"line_number":168,"context_line":"        self.pools \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"0dc870cc_90d79ef1","line":165,"range":{"start_line":165,"start_character":13,"end_line":165,"end_character":51},"updated":"2024-02-27 14:26:19.000000000","message":"We would end up with two different key words for the same feature.\n\nI would prefer to name this something like `mount_point_name_support` instead of human_readable_export_location_support.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"63c2e85d816f923437556a8c5f9336c84076a940","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        self.security_service_update_support \u003d False"},{"line_number":163,"context_line":"        self.network_allocation_update_support \u003d False"},{"line_number":164,"context_line":"        self.share_server_multiple_subnet_support \u003d False"},{"line_number":165,"context_line":"        self.human_readable_export_location_support \u003d False"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # PoolState for all pools"},{"line_number":168,"context_line":"        self.pools \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"1838b386_370fe006","line":165,"range":{"start_line":165,"start_character":13,"end_line":165,"end_character":51},"in_reply_to":"0dc870cc_90d79ef1","updated":"2024-02-27 22:29:56.000000000","message":"+1\n\nI like this better too - thanks for suggesting it, Maurice; Jayaanand?","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.security_service_update_support \u003d False"},{"line_number":163,"context_line":"        self.network_allocation_update_support \u003d False"},{"line_number":164,"context_line":"        self.share_server_multiple_subnet_support \u003d False"},{"line_number":165,"context_line":"        self.human_readable_export_location_support \u003d False"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # PoolState for all pools"},{"line_number":168,"context_line":"        self.pools \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"f51a5d39_514700fc","line":165,"range":{"start_line":165,"start_character":13,"end_line":165,"end_character":51},"in_reply_to":"1838b386_370fe006","updated":"2024-03-04 16:03:44.000000000","message":"update human_readable_export_location_support to mount_point_name_support and verified all scenarios.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"}],"manila/share/api.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dca438c2270a2f833bdaef3a95f990fd7243532","unresolved":true,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if mount_point_name is not None and len(mount_point_name) \u003e 255:"},{"line_number":290,"context_line":"            msg \u003d _(\"Length of \u0027mount_point_name\u0027 \""},{"line_number":291,"context_line":"                    \"should not exceed 255 characters.\")"},{"line_number":292,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7b212e47_74cb17ea","line":291,"updated":"2024-02-15 12:42:00.000000000","message":"... exceed 255 characters including the project name.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a5bce5ad58013536e2adba35e0ec92cb774efc69","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            snapshot \u003d None"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if mount_point_name is not None and len(mount_point_name) \u003e 255:"},{"line_number":290,"context_line":"            msg \u003d _(\"Length of \u0027mount_point_name\u0027 \""},{"line_number":291,"context_line":"                    \"should not exceed 255 characters.\")"},{"line_number":292,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"aa8ee076_6d5371fc","line":291,"range":{"start_line":290,"start_character":12,"end_line":291,"end_character":56},"updated":"2024-02-16 02:09:08.000000000","message":"the spec proposes that we\u0027ll check for mount_point_name collisions:\n\nhttps://specs.openstack.org/openstack/manila-specs/specs/xena/spec-lite-add-human-readable-export-locations.html\n\nthis isn\u0027t an easy thing to do here in the API layer (because we don\u0027t know where the share will get scheduled to).. \n\nbut it seems like something that can be added in the share manager (where we know the host to filter existing shares). If there\u0027s a conflicting mount point, we can raise an appropriate asynchronous user message.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3dcbd8814b7caf61405dfd304c1f8f21b15dca8c","unresolved":true,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if mount_point_name is not None and len(mount_point_name) \u003e 255:"},{"line_number":290,"context_line":"            msg \u003d _(\"Length of \u0027mount_point_name\u0027 \""},{"line_number":291,"context_line":"                    \"should not exceed 255 characters.\")"},{"line_number":292,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"e9b03620_29c61222","line":291,"in_reply_to":"7b212e47_74cb17ea","updated":"2024-02-16 02:07:01.000000000","message":"(and the \"project_name\" can potentially take up 64 characters [1])\n\ns/should not/cannot\n\n\n\n\n\nhttps://github.com/openstack/keystone/blob/7dc175a41f92e3f01cf26912431d0f2c98a03b32/keystone/common/sql/migrations/versions/27e647c0fad4_initial_version.py#L257","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            snapshot \u003d None"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if mount_point_name is not None and len(mount_point_name) \u003e 255:"},{"line_number":290,"context_line":"            msg \u003d _(\"Length of \u0027mount_point_name\u0027 \""},{"line_number":291,"context_line":"                    \"should not exceed 255 characters.\")"},{"line_number":292,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"e7f1f586_21bdd45d","line":291,"range":{"start_line":290,"start_character":12,"end_line":291,"end_character":56},"in_reply_to":"aa8ee076_6d5371fc","updated":"2024-02-21 17:03:21.000000000","message":"Driver is throwing error when duplicate value is present. Following spec https://review.opendev.org/c/openstack/manila-specs/+/797776 \"As an alternative, drivers could reuse the name and the description of shares and generate human readable export locations, but names can be duplicated and backends may fail due to that.\". Please share example filtering logic in share manager i can refer if you think this change needed as part of current PR.","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if mount_point_name is not None and len(mount_point_name) \u003e 255:"},{"line_number":290,"context_line":"            msg \u003d _(\"Length of \u0027mount_point_name\u0027 \""},{"line_number":291,"context_line":"                    \"should not exceed 255 characters.\")"},{"line_number":292,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9b5b5d99_5727ab29","line":291,"in_reply_to":"e9b03620_29c61222","updated":"2024-02-21 17:03:21.000000000","message":"reformatted error message to show project_name + mount_point_name is exceeding 255 characters","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        else:"},{"line_number":287,"context_line":"            snapshot \u003d None"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if mount_point_name is not None and len(mount_point_name) \u003e 255:"},{"line_number":290,"context_line":"            msg \u003d (_(\"Length of \u0027%s\u0027 should not exceed 255 characters.\")"},{"line_number":291,"context_line":"                   % mount_point_name)"},{"line_number":292,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"},{"line_number":295,"context_line":"            msg \u003d (_(\"Share size \u0027%s\u0027 must be an integer and greater than 0\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"8feb9e26_3ce6f015","line":292,"range":{"start_line":289,"start_character":7,"end_line":292,"end_character":52},"updated":"2024-02-23 10:10:27.000000000","message":"Please extract this into a method:\n\n    if mount_point_name is not None:\n        mount_point_name \u003d self._get_formatted_valid_mount_point_name(context, share_type, mount_point_name)\n\n\n\n    def _get_formatted_valid_mount_point_name(self, context, share_type, mount_point_name):\n        prefix \u003d share_type.get(\"provisioning:mount_point_prefix\")\n        prefix \u003d prefix or context.project_name\n        prefix \u003d prefix.format(context.to_dict())\n        mount_point_name \u003d f\"{prefix}_{mount_point_name}\"","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        else:"},{"line_number":287,"context_line":"            snapshot \u003d None"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if mount_point_name is not None and len(mount_point_name) \u003e 255:"},{"line_number":290,"context_line":"            msg \u003d (_(\"Length of \u0027%s\u0027 should not exceed 255 characters.\")"},{"line_number":291,"context_line":"                   % mount_point_name)"},{"line_number":292,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if not strutils.is_int_like(size) or int(size) \u003c\u003d 0:"},{"line_number":295,"context_line":"            msg \u003d (_(\"Share size \u0027%s\u0027 must be an integer and greater than 0\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fa62aa0_65d8646b","line":292,"range":{"start_line":289,"start_character":7,"end_line":292,"end_character":52},"in_reply_to":"8feb9e26_3ce6f015","updated":"2024-03-04 16:03:44.000000000","message":"refactored into different method.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":666,"context_line":"            \u0027source_share_group_snapshot_member_id\u0027: share["},{"line_number":667,"context_line":"                \u0027source_share_group_snapshot_member_id\u0027],"},{"line_number":668,"context_line":"            \u0027snapshot_id\u0027: share[\u0027snapshot_id\u0027],"},{"line_number":669,"context_line":"            \u0027replication_type\u0027: share[\u0027replication_type\u0027]"},{"line_number":670,"context_line":"        }"},{"line_number":671,"context_line":"        share_instance_properties \u003d {"},{"line_number":672,"context_line":"            \u0027id\u0027: share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1b9b320d_01df6d23","line":669,"updated":"2024-02-23 10:10:27.000000000","message":"please don\u0027t remove the trailing comma at the end of this line/item","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            \u0027source_share_group_snapshot_member_id\u0027: share["},{"line_number":667,"context_line":"                \u0027source_share_group_snapshot_member_id\u0027],"},{"line_number":668,"context_line":"            \u0027snapshot_id\u0027: share[\u0027snapshot_id\u0027],"},{"line_number":669,"context_line":"            \u0027replication_type\u0027: share[\u0027replication_type\u0027]"},{"line_number":670,"context_line":"        }"},{"line_number":671,"context_line":"        share_instance_properties \u003d {"},{"line_number":672,"context_line":"            \u0027id\u0027: share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1cfde277_88ad65fa","line":669,"in_reply_to":"1b9b320d_01df6d23","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":678,"context_line":"            \u0027status\u0027: share_instance[\u0027status\u0027],"},{"line_number":679,"context_line":"            \u0027replica_state\u0027: share_instance[\u0027replica_state\u0027],"},{"line_number":680,"context_line":"            \u0027share_type_id\u0027: share_instance[\u0027share_type_id\u0027],"},{"line_number":681,"context_line":"            \u0027mount_point_name\u0027: share_instance[\u0027mount_point_name\u0027]"},{"line_number":682,"context_line":"        }"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        share_type \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"5d6acde4_0ce43531","line":681,"updated":"2024-02-23 10:10:27.000000000","message":"is this even required?","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            \u0027status\u0027: share_instance[\u0027status\u0027],"},{"line_number":679,"context_line":"            \u0027replica_state\u0027: share_instance[\u0027replica_state\u0027],"},{"line_number":680,"context_line":"            \u0027share_type_id\u0027: share_instance[\u0027share_type_id\u0027],"},{"line_number":681,"context_line":"            \u0027mount_point_name\u0027: share_instance[\u0027mount_point_name\u0027]"},{"line_number":682,"context_line":"        }"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        share_type \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"d5b9fd47_08bf58fd","line":681,"in_reply_to":"5d6acde4_0ce43531","updated":"2024-03-04 16:03:44.000000000","message":"mount_point_name is added to share_instance.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":699,"context_line":"            \u0027availability_zones\u0027: availability_zones,"},{"line_number":700,"context_line":"            \u0027az_request_multiple_subnet_support_map\u0027: ("},{"line_number":701,"context_line":"                az_request_multiple_subnet_support_map),"},{"line_number":702,"context_line":"            \u0027mount_point_name\u0027: mount_point_name"},{"line_number":703,"context_line":"        }"},{"line_number":704,"context_line":"        return request_spec, share_instance"},{"line_number":705,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"72ea34fc_a264f661","line":702,"updated":"2024-02-23 10:10:27.000000000","message":"is this even required?","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":699,"context_line":"            \u0027availability_zones\u0027: availability_zones,"},{"line_number":700,"context_line":"            \u0027az_request_multiple_subnet_support_map\u0027: ("},{"line_number":701,"context_line":"                az_request_multiple_subnet_support_map),"},{"line_number":702,"context_line":"            \u0027mount_point_name\u0027: mount_point_name"},{"line_number":703,"context_line":"        }"},{"line_number":704,"context_line":"        return request_spec, share_instance"},{"line_number":705,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7cbae2ec_c80689cb","line":702,"in_reply_to":"72ea34fc_a264f661","updated":"2024-03-04 16:03:44.000000000","message":"yes, mount_point_name details are added to share_instance table.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":699,"context_line":"            \u0027availability_zones\u0027: availability_zones,"},{"line_number":700,"context_line":"            \u0027az_request_multiple_subnet_support_map\u0027: ("},{"line_number":701,"context_line":"                az_request_multiple_subnet_support_map),"},{"line_number":702,"context_line":"            \u0027mount_point_name\u0027: mount_point_name"},{"line_number":703,"context_line":"        }"},{"line_number":704,"context_line":"        return request_spec, share_instance"},{"line_number":705,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"95376ca8_2953ae3b","line":702,"in_reply_to":"7cbae2ec_c80689cb","updated":"2024-03-05 23:58:57.000000000","message":"Sure; but the creation has already happened above.. you don\u0027t need this in the request spec.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":699,"context_line":"            \u0027availability_zones\u0027: availability_zones,"},{"line_number":700,"context_line":"            \u0027az_request_multiple_subnet_support_map\u0027: ("},{"line_number":701,"context_line":"                az_request_multiple_subnet_support_map),"},{"line_number":702,"context_line":"            \u0027mount_point_name\u0027: mount_point_name"},{"line_number":703,"context_line":"        }"},{"line_number":704,"context_line":"        return request_spec, share_instance"},{"line_number":705,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e7ef7d8d_f7ce7f00","line":702,"in_reply_to":"95376ca8_2953ae3b","updated":"2024-03-06 20:53:12.000000000","message":"ok removed now.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":353,"context_line":"        self.check_is_share_size_within_per_share_quota_limit(context, size)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        deltas \u003d {\u0027shares\u0027: 1, \u0027gigabytes\u0027: size}"},{"line_number":356,"context_line":"        share_type_attributes \u003d self.get_share_attributes_from_share_type("},{"line_number":357,"context_line":"            share_type)"},{"line_number":358,"context_line":"        share_type_supports_replication \u003d share_type_attributes.get("},{"line_number":359,"context_line":"            \u0027replication_type\u0027, None)"},{"line_number":360,"context_line":"        if share_type_supports_replication:"},{"line_number":361,"context_line":"            deltas.update("},{"line_number":362,"context_line":"                {\u0027share_replicas\u0027: 1, \u0027replica_gigabytes\u0027: size})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        try:"},{"line_number":365,"context_line":"            reservations \u003d QUOTAS.reserve("}],"source_content_type":"text/x-python","patch_set":7,"id":"fe12829b_aacaceb4","line":362,"range":{"start_line":356,"start_character":0,"end_line":362,"end_character":65},"updated":"2024-03-05 23:58:57.000000000","message":"move the mount point name logic from 290-293 after these lines; please see related comment within the `get_share_attributes_from_share_type` method.\n\n\n```\nshare_type_supports_mount_point_name \u003d share_type_attributes.get(\n      \u0027mount_point_name_support\u0027)\nif mount_point_name is not None:\n    if not mount_point_name_support:\n        msg \u003d _(\"Mount point name is not supported by the share type used.\")\n        raise exception.InvalidInput(reason\u003dmsg)\n    mount_point_name \u003d self._prefix_mount_point_name(\n        share_type, context, mount_point_name\n    )\n```","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        self.check_is_share_size_within_per_share_quota_limit(context, size)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        deltas \u003d {\u0027shares\u0027: 1, \u0027gigabytes\u0027: size}"},{"line_number":356,"context_line":"        share_type_attributes \u003d self.get_share_attributes_from_share_type("},{"line_number":357,"context_line":"            share_type)"},{"line_number":358,"context_line":"        share_type_supports_replication \u003d share_type_attributes.get("},{"line_number":359,"context_line":"            \u0027replication_type\u0027, None)"},{"line_number":360,"context_line":"        if share_type_supports_replication:"},{"line_number":361,"context_line":"            deltas.update("},{"line_number":362,"context_line":"                {\u0027share_replicas\u0027: 1, \u0027replica_gigabytes\u0027: size})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        try:"},{"line_number":365,"context_line":"            reservations \u003d QUOTAS.reserve("}],"source_content_type":"text/x-python","patch_set":7,"id":"a6dd04ff_ab8e0b71","line":362,"range":{"start_line":356,"start_character":0,"end_line":362,"end_character":65},"in_reply_to":"fe12829b_aacaceb4","updated":"2024-03-06 20:53:12.000000000","message":"updated logic to add mount_point_name_support extra spec.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":505,"context_line":"        consistently govern the behavior of that share over its lifespan."},{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        inferred_map \u003d constants.ExtraSpecs.INFERRED_OPTIONAL_MAP"},{"line_number":509,"context_line":"        snapshot_support_key \u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT"},{"line_number":510,"context_line":"        create_share_from_snapshot_key \u003d ("},{"line_number":511,"context_line":"            constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c1596d2b_70665bb1","line":508,"range":{"start_line":508,"start_character":44,"end_line":508,"end_character":65},"updated":"2024-03-05 23:58:57.000000000","message":"add mount_point_name_support to this object, defaulting to False","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        consistently govern the behavior of that share over its lifespan."},{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        inferred_map \u003d constants.ExtraSpecs.INFERRED_OPTIONAL_MAP"},{"line_number":509,"context_line":"        snapshot_support_key \u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT"},{"line_number":510,"context_line":"        create_share_from_snapshot_key \u003d ("},{"line_number":511,"context_line":"            constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3822e921_9285ec7b","line":508,"range":{"start_line":508,"start_character":44,"end_line":508,"end_character":65},"in_reply_to":"c1596d2b_70665bb1","updated":"2024-03-06 20:53:12.000000000","message":"updated logic to add mount_point_name_support extra spec.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        inferred_map \u003d constants.ExtraSpecs.INFERRED_OPTIONAL_MAP"},{"line_number":509,"context_line":"        snapshot_support_key \u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT"},{"line_number":510,"context_line":"        create_share_from_snapshot_key \u003d ("},{"line_number":511,"context_line":"            constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT)"},{"line_number":512,"context_line":"        revert_to_snapshot_key \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"a5d56811_c13ef226","line":509,"range":{"start_line":509,"start_character":31,"end_line":509,"end_character":51},"updated":"2024-03-05 23:58:57.000000000","message":"add \"mount_point_name_support\" as a constant to this class","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        inferred_map \u003d constants.ExtraSpecs.INFERRED_OPTIONAL_MAP"},{"line_number":509,"context_line":"        snapshot_support_key \u003d constants.ExtraSpecs.SNAPSHOT_SUPPORT"},{"line_number":510,"context_line":"        create_share_from_snapshot_key \u003d ("},{"line_number":511,"context_line":"            constants.ExtraSpecs.CREATE_SHARE_FROM_SNAPSHOT_SUPPORT)"},{"line_number":512,"context_line":"        revert_to_snapshot_key \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"617cf790_298c3dff","line":509,"range":{"start_line":509,"start_character":31,"end_line":509,"end_character":51},"in_reply_to":"a5d56811_c13ef226","updated":"2024-03-06 20:53:12.000000000","message":"updated logic to add mount_point_name_support extra spec.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":539,"context_line":"                    share_type.get(\u0027extra_specs\u0027, {}).get("},{"line_number":540,"context_line":"                        revert_to_snapshot_key,"},{"line_number":541,"context_line":"                        revert_to_snapshot_support_default)))"},{"line_number":542,"context_line":"            mount_snapshot_support \u003d share_types.parse_boolean_extra_spec("},{"line_number":543,"context_line":"                mount_snapshot_support_key, share_type.get("},{"line_number":544,"context_line":"                    \u0027extra_specs\u0027, {}).get("},{"line_number":545,"context_line":"                    mount_snapshot_support_key,"},{"line_number":546,"context_line":"                    mount_snapshot_support_default))"},{"line_number":547,"context_line":"            replication_type \u003d share_type.get(\u0027extra_specs\u0027, {}).get("},{"line_number":548,"context_line":"                \u0027replication_type\u0027)"},{"line_number":549,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"b76a5d8f_b4c06aa7","line":546,"range":{"start_line":542,"start_character":12,"end_line":546,"end_character":52},"updated":"2024-03-05 23:58:57.000000000","message":"parse \"mount_point_name_support\" just like this..","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":539,"context_line":"                    share_type.get(\u0027extra_specs\u0027, {}).get("},{"line_number":540,"context_line":"                        revert_to_snapshot_key,"},{"line_number":541,"context_line":"                        revert_to_snapshot_support_default)))"},{"line_number":542,"context_line":"            mount_snapshot_support \u003d share_types.parse_boolean_extra_spec("},{"line_number":543,"context_line":"                mount_snapshot_support_key, share_type.get("},{"line_number":544,"context_line":"                    \u0027extra_specs\u0027, {}).get("},{"line_number":545,"context_line":"                    mount_snapshot_support_key,"},{"line_number":546,"context_line":"                    mount_snapshot_support_default))"},{"line_number":547,"context_line":"            replication_type \u003d share_type.get(\u0027extra_specs\u0027, {}).get("},{"line_number":548,"context_line":"                \u0027replication_type\u0027)"},{"line_number":549,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"efb5a101_17677050","line":546,"range":{"start_line":542,"start_character":12,"end_line":546,"end_character":52},"in_reply_to":"b76a5d8f_b4c06aa7","updated":"2024-03-06 20:53:12.000000000","message":"updated logic to add mount_point_name_support extra spec.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":679,"context_line":"            \u0027status\u0027: share_instance[\u0027status\u0027],"},{"line_number":680,"context_line":"            \u0027replica_state\u0027: share_instance[\u0027replica_state\u0027],"},{"line_number":681,"context_line":"            \u0027share_type_id\u0027: share_instance[\u0027share_type_id\u0027],"},{"line_number":682,"context_line":"            \u0027mount_point_name\u0027: share_instance[\u0027mount_point_name\u0027]"},{"line_number":683,"context_line":"        }"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        share_type \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"3874e769_3d3eabee","line":682,"range":{"start_line":682,"start_character":0,"end_line":682,"end_character":66},"updated":"2024-03-05 23:58:57.000000000","message":"I still don\u0027t think this is required here.. you\u0027re not using this anywhere","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":679,"context_line":"            \u0027status\u0027: share_instance[\u0027status\u0027],"},{"line_number":680,"context_line":"            \u0027replica_state\u0027: share_instance[\u0027replica_state\u0027],"},{"line_number":681,"context_line":"            \u0027share_type_id\u0027: share_instance[\u0027share_type_id\u0027],"},{"line_number":682,"context_line":"            \u0027mount_point_name\u0027: share_instance[\u0027mount_point_name\u0027]"},{"line_number":683,"context_line":"        }"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        share_type \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"e7e6e085_9a62c8ed","line":682,"range":{"start_line":682,"start_character":0,"end_line":682,"end_character":66},"in_reply_to":"3874e769_3d3eabee","updated":"2024-03-06 20:53:12.000000000","message":"ok, removed","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":700,"context_line":"            \u0027availability_zones\u0027: availability_zones,"},{"line_number":701,"context_line":"            \u0027az_request_multiple_subnet_support_map\u0027: ("},{"line_number":702,"context_line":"                az_request_multiple_subnet_support_map),"},{"line_number":703,"context_line":"            \u0027mount_point_name\u0027: mount_point_name"},{"line_number":704,"context_line":"        }"},{"line_number":705,"context_line":"        return request_spec, share_instance"},{"line_number":706,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ad78acc6_28a8c4a6","line":703,"range":{"start_line":703,"start_character":0,"end_line":703,"end_character":48},"updated":"2024-03-05 23:58:57.000000000","message":"this isnt being used from this request_spec; please remove","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":700,"context_line":"            \u0027availability_zones\u0027: availability_zones,"},{"line_number":701,"context_line":"            \u0027az_request_multiple_subnet_support_map\u0027: ("},{"line_number":702,"context_line":"                az_request_multiple_subnet_support_map),"},{"line_number":703,"context_line":"            \u0027mount_point_name\u0027: mount_point_name"},{"line_number":704,"context_line":"        }"},{"line_number":705,"context_line":"        return request_spec, share_instance"},{"line_number":706,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"65077de9_ee81abd8","line":703,"range":{"start_line":703,"start_character":0,"end_line":703,"end_character":48},"in_reply_to":"ad78acc6_28a8c4a6","updated":"2024-03-06 20:53:12.000000000","message":"ok, removed now.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def _prefix_mount_point_name(self, share_type, context,"},{"line_number":1112,"context_line":"                                 mount_point_name\u003dNone):"},{"line_number":1113,"context_line":"        if mount_point_name is not None:"},{"line_number":1114,"context_line":"            mount_point_prefix \u003d (share_type.get(\u0027extra_specs\u0027).get("},{"line_number":1115,"context_line":"                constants.ExtraSpecs.PROVISIONING_MOUNT_POINT_PREFIX"},{"line_number":1116,"context_line":"            ) or context.project_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"d9fb3b0a_83793ea5","line":1113,"range":{"start_line":1113,"start_character":0,"end_line":1113,"end_character":40},"updated":"2024-03-05 23:58:57.000000000","message":"isn\u0027t this condition evaluated already before this method is invoked; i.e., currently line 290.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def _prefix_mount_point_name(self, share_type, context,"},{"line_number":1112,"context_line":"                                 mount_point_name\u003dNone):"},{"line_number":1113,"context_line":"        if mount_point_name is not None:"},{"line_number":1114,"context_line":"            mount_point_prefix \u003d (share_type.get(\u0027extra_specs\u0027).get("},{"line_number":1115,"context_line":"                constants.ExtraSpecs.PROVISIONING_MOUNT_POINT_PREFIX"},{"line_number":1116,"context_line":"            ) or context.project_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"30289e3c_205db687","line":1113,"range":{"start_line":1113,"start_character":0,"end_line":1113,"end_character":40},"in_reply_to":"d9fb3b0a_83793ea5","updated":"2024-03-06 20:53:12.000000000","message":"yea, i want it to be independent function. remove and also related test","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":1111,"context_line":"    def _prefix_mount_point_name(self, share_type, context,"},{"line_number":1112,"context_line":"                                 mount_point_name\u003dNone):"},{"line_number":1113,"context_line":"        if mount_point_name is not None:"},{"line_number":1114,"context_line":"            mount_point_prefix \u003d (share_type.get(\u0027extra_specs\u0027).get("},{"line_number":1115,"context_line":"                constants.ExtraSpecs.PROVISIONING_MOUNT_POINT_PREFIX"},{"line_number":1116,"context_line":"            ) or context.project_id)"},{"line_number":1117,"context_line":"            mount_point_name \u003d f\"{mount_point_prefix}_{mount_point_name}\" \\"},{"line_number":1118,"context_line":"                if mount_point_name else None"},{"line_number":1119,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"c3fb6646_517cb336","line":1116,"range":{"start_line":1114,"start_character":12,"end_line":1116,"end_character":13},"updated":"2024-03-05 23:58:57.000000000","message":"what happened to treating this as a template?\n\n```\n    prefix \u003d share_type.get(\"provisioning:mount_point_prefix\")\n    prefix \u003d prefix or context.project_name\n    prefix \u003d prefix.format(context.to_dict())\n    mount_point_name \u003d f\"{prefix}_{mount_point_name}\"\n```","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"    def _prefix_mount_point_name(self, share_type, context,"},{"line_number":1112,"context_line":"                                 mount_point_name\u003dNone):"},{"line_number":1113,"context_line":"        if mount_point_name is not None:"},{"line_number":1114,"context_line":"            mount_point_prefix \u003d (share_type.get(\u0027extra_specs\u0027).get("},{"line_number":1115,"context_line":"                constants.ExtraSpecs.PROVISIONING_MOUNT_POINT_PREFIX"},{"line_number":1116,"context_line":"            ) or context.project_id)"},{"line_number":1117,"context_line":"            mount_point_name \u003d f\"{mount_point_prefix}_{mount_point_name}\" \\"},{"line_number":1118,"context_line":"                if mount_point_name else None"},{"line_number":1119,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"c3a12917_663b0788","line":1116,"range":{"start_line":1114,"start_character":12,"end_line":1116,"end_character":13},"in_reply_to":"c3fb6646_517cb336","updated":"2024-03-06 20:53:12.000000000","message":"yes, updated to suggested logic","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":1114,"context_line":"            mount_point_prefix \u003d (share_type.get(\u0027extra_specs\u0027).get("},{"line_number":1115,"context_line":"                constants.ExtraSpecs.PROVISIONING_MOUNT_POINT_PREFIX"},{"line_number":1116,"context_line":"            ) or context.project_id)"},{"line_number":1117,"context_line":"            mount_point_name \u003d f\"{mount_point_prefix}_{mount_point_name}\" \\"},{"line_number":1118,"context_line":"                if mount_point_name else None"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"            if mount_point_name and ("},{"line_number":1121,"context_line":"                    not re.match("}],"source_content_type":"text/x-python","patch_set":7,"id":"ff847a75_f1d6c0c5","line":1118,"range":{"start_line":1117,"start_character":12,"end_line":1118,"end_character":45},"updated":"2024-03-05 17:52:25.000000000","message":"A suggestion of formatting:\n```\nmount_point_name \u003d (\n    f\"{mount_point_prefix}_{mount_point_name}\"\n    if mount_point_name else None)\n```","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"            mount_point_prefix \u003d (share_type.get(\u0027extra_specs\u0027).get("},{"line_number":1115,"context_line":"                constants.ExtraSpecs.PROVISIONING_MOUNT_POINT_PREFIX"},{"line_number":1116,"context_line":"            ) or context.project_id)"},{"line_number":1117,"context_line":"            mount_point_name \u003d f\"{mount_point_prefix}_{mount_point_name}\" \\"},{"line_number":1118,"context_line":"                if mount_point_name else None"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"            if mount_point_name and ("},{"line_number":1121,"context_line":"                    not re.match("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4407ac_72fb0a4b","line":1118,"range":{"start_line":1117,"start_character":12,"end_line":1118,"end_character":45},"in_reply_to":"ff847a75_f1d6c0c5","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated to suggested logic","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":1122,"context_line":"                        r\u0027^[a-zA-Z0-9_]*$\u0027, mount_point_name)"},{"line_number":1123,"context_line":"                    or len(mount_point_name) \u003e 255"},{"line_number":1124,"context_line":"            ):"},{"line_number":1125,"context_line":"                LOG.error(\"Invalid mount_point_name: %s\", mount_point_name)"},{"line_number":1126,"context_line":"                raise exception.InvalidInput("},{"line_number":1127,"context_line":"                    reason\u003d\"Invalid mount_point_names\""},{"line_number":1128,"context_line":"                )"},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"        return mount_point_name"}],"source_content_type":"text/x-python","patch_set":7,"id":"e53c79ae_f03a9ace","line":1127,"range":{"start_line":1125,"start_character":16,"end_line":1127,"end_character":54},"updated":"2024-03-05 23:58:57.000000000","message":"```\n   msg \u003d _(\"Invalid mount_point_name: %s\")\n   LOG.error(msg, mount_point_name)\n   raise exception.InvalidInput(msg % mount_point_name)\n```","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                        r\u0027^[a-zA-Z0-9_]*$\u0027, mount_point_name)"},{"line_number":1123,"context_line":"                    or len(mount_point_name) \u003e 255"},{"line_number":1124,"context_line":"            ):"},{"line_number":1125,"context_line":"                LOG.error(\"Invalid mount_point_name: %s\", mount_point_name)"},{"line_number":1126,"context_line":"                raise exception.InvalidInput("},{"line_number":1127,"context_line":"                    reason\u003d\"Invalid mount_point_names\""},{"line_number":1128,"context_line":"                )"},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"        return mount_point_name"}],"source_content_type":"text/x-python","patch_set":7,"id":"7c62d24e_e9822061","line":1127,"range":{"start_line":1125,"start_character":16,"end_line":1127,"end_character":54},"in_reply_to":"e53c79ae_f03a9ace","updated":"2024-03-06 20:53:12.000000000","message":"yes, updated to suggested logic","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4669d86fdcb77bcba1378a95300fe0d8b47b16c","unresolved":true,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        mount_point_name_support \u003d share_type_attributes.get("},{"line_number":355,"context_line":"            constants.ExtraSpecs.MOUNT_POINT_NAME_SUPPORT, None)"},{"line_number":356,"context_line":"        if mount_point_name is not None:"},{"line_number":357,"context_line":"            if not mount_point_name_support:"},{"line_number":358,"context_line":"                msg \u003d _(\"Setting a mount point name is not supported by the\""},{"line_number":359,"context_line":"                        \" share type used %s.\" % share_type[\u0027name\u0027])"},{"line_number":360,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1068fdaf_80e2c2c0","line":357,"range":{"start_line":356,"start_character":7,"end_line":357,"end_character":44},"updated":"2024-03-06 23:06:54.000000000","message":"missing a unit test for this: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0b2/908897/8/check/openstack-tox-cover/0b27a89/cover/d_030f674440dfdd1c_api_py.html#t359","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        mount_point_name_support \u003d share_type_attributes.get("},{"line_number":355,"context_line":"            constants.ExtraSpecs.MOUNT_POINT_NAME_SUPPORT, None)"},{"line_number":356,"context_line":"        if mount_point_name is not None:"},{"line_number":357,"context_line":"            if not mount_point_name_support:"},{"line_number":358,"context_line":"                msg \u003d _(\"Setting a mount point name is not supported by the\""},{"line_number":359,"context_line":"                        \" share type used %s.\" % share_type[\u0027name\u0027])"},{"line_number":360,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"469df40d_f7e25b7b","line":357,"range":{"start_line":356,"start_character":7,"end_line":357,"end_character":44},"in_reply_to":"1068fdaf_80e2c2c0","updated":"2024-03-07 22:25:10.000000000","message":"Added UTs to cover this scenario.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00b67bf31bd375097971ab219e139dff1f633a1a","unresolved":true,"context_lines":[{"line_number":356,"context_line":"        if mount_point_name is not None:"},{"line_number":357,"context_line":"            if not mount_point_name_support:"},{"line_number":358,"context_line":"                msg \u003d _(\"Setting a mount point name is not supported by the\""},{"line_number":359,"context_line":"                        \" share type used %s.\" % share_type[\u0027name\u0027])"},{"line_number":360,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":361,"context_line":"            mount_point_name \u003d self._prefix_mount_point_name("},{"line_number":362,"context_line":"                share_type, context, mount_point_name"}],"source_content_type":"text/x-python","patch_set":8,"id":"fd0f8123_d2ee5671","line":359,"range":{"start_line":359,"start_character":49,"end_line":359,"end_character":68},"updated":"2024-03-06 22:44:39.000000000","message":"is there a share_type may be None here?\n\nAll other statements above handle a situation where share_type is None..","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        if mount_point_name is not None:"},{"line_number":357,"context_line":"            if not mount_point_name_support:"},{"line_number":358,"context_line":"                msg \u003d _(\"Setting a mount point name is not supported by the\""},{"line_number":359,"context_line":"                        \" share type used %s.\" % share_type[\u0027name\u0027])"},{"line_number":360,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":361,"context_line":"            mount_point_name \u003d self._prefix_mount_point_name("},{"line_number":362,"context_line":"                share_type, context, mount_point_name"}],"source_content_type":"text/x-python","patch_set":8,"id":"4d24c48f_7cde333c","line":359,"range":{"start_line":359,"start_character":49,"end_line":359,"end_character":68},"in_reply_to":"fd0f8123_d2ee5671","updated":"2024-03-07 22:25:10.000000000","message":"updated based on your suggestion. Thank you!","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4669d86fdcb77bcba1378a95300fe0d8b47b16c","unresolved":true,"context_lines":[{"line_number":531,"context_line":"            revert_to_snapshot_key)"},{"line_number":532,"context_line":"        mount_snapshot_support_default \u003d inferred_map.get("},{"line_number":533,"context_line":"            constants.ExtraSpecs.MOUNT_SNAPSHOT_SUPPORT)"},{"line_number":534,"context_line":"        mount_point_name_support_default \u003d inferred_map.get("},{"line_number":535,"context_line":"            constants.ExtraSpecs.MOUNT_POINT_NAME_SUPPORT)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if share_type:"},{"line_number":538,"context_line":"            snapshot_support \u003d share_types.parse_boolean_extra_spec("}],"source_content_type":"text/x-python","patch_set":8,"id":"3c4a925d_95f5b28d","line":535,"range":{"start_line":534,"start_character":8,"end_line":535,"end_character":58},"updated":"2024-03-06 23:06:54.000000000","message":"assume that the default is False; no need to define it as a variable; see how \"replication_type\" is handled (the default value for that extra-spec is None, i.e., no replication)","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":531,"context_line":"            revert_to_snapshot_key)"},{"line_number":532,"context_line":"        mount_snapshot_support_default \u003d inferred_map.get("},{"line_number":533,"context_line":"            constants.ExtraSpecs.MOUNT_SNAPSHOT_SUPPORT)"},{"line_number":534,"context_line":"        mount_point_name_support_default \u003d inferred_map.get("},{"line_number":535,"context_line":"            constants.ExtraSpecs.MOUNT_POINT_NAME_SUPPORT)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if share_type:"},{"line_number":538,"context_line":"            snapshot_support \u003d share_types.parse_boolean_extra_spec("}],"source_content_type":"text/x-python","patch_set":8,"id":"8474a90c_91815f2f","line":535,"range":{"start_line":534,"start_character":8,"end_line":535,"end_character":58},"in_reply_to":"3c4a925d_95f5b28d","updated":"2024-03-07 22:25:10.000000000","message":"Thank you!Assigned default value False after your suggestion.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"}],"manila/share/share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4669d86fdcb77bcba1378a95300fe0d8b47b16c","unresolved":true,"context_lines":[{"line_number":329,"context_line":"    values \u003d extra_spec_value.split(\u0027,\u0027)"},{"line_number":330,"context_line":"    return all([v.strip() for v in values])"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"def is_valid_string(v):"},{"line_number":334,"context_line":"    return isinstance(v, str) and len(v) in range(1, 256)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"def sanitize_csv(csv_string):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7cc03af4_180ebf70","line":334,"range":{"start_line":332,"start_character":0,"end_line":334,"end_character":57},"updated":"2024-03-06 23:06:54.000000000","message":"needs a unit test please","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    values \u003d extra_spec_value.split(\u0027,\u0027)"},{"line_number":330,"context_line":"    return all([v.strip() for v in values])"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"def is_valid_string(v):"},{"line_number":334,"context_line":"    return isinstance(v, str) and len(v) in range(1, 256)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"def sanitize_csv(csv_string):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1efbd71e_79342c18","line":334,"range":{"start_line":332,"start_character":0,"end_line":334,"end_character":57},"in_reply_to":"7cc03af4_180ebf70","updated":"2024-03-07 22:25:10.000000000","message":"Added UTs to cover this scenario.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4669d86fdcb77bcba1378a95300fe0d8b47b16c","unresolved":true,"context_lines":[{"line_number":360,"context_line":"        return value in constants.ExtraSpecs.REPLICATION_TYPES"},{"line_number":361,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.MOUNT_SNAPSHOT_SUPPORT:"},{"line_number":362,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":363,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.MOUNT_POINT_NAME_SUPPORT:"},{"line_number":364,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":365,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.AVAILABILITY_ZONES:"},{"line_number":366,"context_line":"        return is_valid_csv(value)"},{"line_number":367,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.PROVISIONING_MOUNT_POINT_PREFIX:"},{"line_number":368,"context_line":"        return is_valid_string(value)"},{"line_number":369,"context_line":"    elif key in [constants.ExtraSpecs.PROVISIONING_MAX_SHARE_SIZE,"},{"line_number":370,"context_line":"                 constants.ExtraSpecs.PROVISIONING_MIN_SHARE_SIZE,"},{"line_number":371,"context_line":"                 constants.ExtraSpecs.PROVISIONING_MAX_SHARE_EXTEND_SIZE]:"}],"source_content_type":"text/x-python","patch_set":8,"id":"698f8fad_de4ca1a7","line":368,"range":{"start_line":363,"start_character":0,"end_line":368,"end_character":37},"updated":"2024-03-06 23:06:54.000000000","message":"could benefit from unit tests","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        return value in constants.ExtraSpecs.REPLICATION_TYPES"},{"line_number":361,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.MOUNT_SNAPSHOT_SUPPORT:"},{"line_number":362,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":363,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.MOUNT_POINT_NAME_SUPPORT:"},{"line_number":364,"context_line":"        return parse_boolean_extra_spec(key, value) is not None"},{"line_number":365,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.AVAILABILITY_ZONES:"},{"line_number":366,"context_line":"        return is_valid_csv(value)"},{"line_number":367,"context_line":"    elif key \u003d\u003d constants.ExtraSpecs.PROVISIONING_MOUNT_POINT_PREFIX:"},{"line_number":368,"context_line":"        return is_valid_string(value)"},{"line_number":369,"context_line":"    elif key in [constants.ExtraSpecs.PROVISIONING_MAX_SHARE_SIZE,"},{"line_number":370,"context_line":"                 constants.ExtraSpecs.PROVISIONING_MIN_SHARE_SIZE,"},{"line_number":371,"context_line":"                 constants.ExtraSpecs.PROVISIONING_MAX_SHARE_EXTEND_SIZE]:"}],"source_content_type":"text/x-python","patch_set":8,"id":"678a7f10_697ff1a8","line":368,"range":{"start_line":363,"start_character":0,"end_line":368,"end_character":37},"in_reply_to":"698f8fad_de4ca1a7","updated":"2024-03-07 22:25:10.000000000","message":"Added UTs to cover this scenario.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"}],"manila/tests/api/v2/test_share_transfer.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c49a1431c934a66a207e7de98c52458612b1aea6","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                      mount_point_name\u003dNone):"},{"line_number":66,"context_line":"        \"\"\"Create a share object.\"\"\""},{"line_number":67,"context_line":"        share_type \u003d db_utils.create_share_type()"},{"line_number":68,"context_line":"        if mount_point_name:"},{"line_number":69,"context_line":"            instance_list \u003d ["},{"line_number":70,"context_line":"                db_utils.create_share_instance("},{"line_number":71,"context_line":"                    status\u003dstatus,"},{"line_number":72,"context_line":"                    share_id\u003d\u0027fake_id\u0027,"},{"line_number":73,"context_line":"                    mount_point_name\u003dmount_point_name"},{"line_number":74,"context_line":"                )"},{"line_number":75,"context_line":"            ]"},{"line_number":76,"context_line":"            share \u003d db_utils.create_share("},{"line_number":77,"context_line":"                display_name\u003ddisplay_name,"},{"line_number":78,"context_line":"                display_description\u003ddisplay_description,"},{"line_number":79,"context_line":"                status\u003dstatus, size\u003dsize,"},{"line_number":80,"context_line":"                project_id\u003dproject_id,"},{"line_number":81,"context_line":"                user_id\u003duser_id,"},{"line_number":82,"context_line":"                share_type_id\u003dshare_type[\u0027id\u0027],"},{"line_number":83,"context_line":"                share_network_id\u003dshare_network_id,"},{"line_number":84,"context_line":"                instances\u003dinstance_list"},{"line_number":85,"context_line":"            )"},{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            share \u003d db_utils.create_share("},{"line_number":88,"context_line":"                display_name\u003ddisplay_name,"},{"line_number":89,"context_line":"                display_description\u003ddisplay_description,"},{"line_number":90,"context_line":"                status\u003dstatus,"},{"line_number":91,"context_line":"                size\u003dsize,"},{"line_number":92,"context_line":"                project_id\u003dproject_id,"},{"line_number":93,"context_line":"                user_id\u003duser_id,"},{"line_number":94,"context_line":"                share_type_id\u003dshare_type[\u0027id\u0027],"},{"line_number":95,"context_line":"                share_network_id\u003dshare_network_id,"},{"line_number":96,"context_line":"                mount_point_name\u003dmount_point_name"},{"line_number":97,"context_line":"            )"},{"line_number":98,"context_line":"        share_id \u003d share[\u0027id\u0027]"},{"line_number":99,"context_line":"        return share_id"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ff77c6e_ae77c2a4","line":97,"range":{"start_line":68,"start_character":8,"end_line":97,"end_character":13},"updated":"2024-03-07 22:48:38.000000000","message":"reduce duplication:\n\n\n```\n\n    kwargs \u003d {\n       \u0027display_name\u0027: display_name,\n       \u0027display_description\u0027: display_description,\n       \u0027status\u0027: status,\n       \u0027size\u0027: size,\n       \u0027project_id\u0027: project_id,\n       \u0027user_id\u0027: user_id,\n       \u0027share_type_id\u0027: share_type[\u0027id\u0027],\n       \u0027share_network_id\u0027: share_network_id,\n    }\n    if mount_point_name:\n         # mount_point_name is set on the instance\n         instance_list \u003d [\n              db_utils.create_share_instance(\n                  status\u003dstatus,\n                  share_id\u003d\u0027fake_id\u0027,\n                  mount_point_name\u003dmount_point_name\n              )\n          ]\n          kwargs[\u0027instances\u0027] \u003d instance_list,\n\n           \n            \n    share \u003d db_utils.create_share(**kwargs)\n```","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c49a1431c934a66a207e7de98c52458612b1aea6","unresolved":true,"context_lines":[{"line_number":276,"context_line":"    def test_create_transfer_with_project_id_prefix_mount_point_name(self):"},{"line_number":277,"context_line":"        share_id \u003d self._create_share(project_id\u003d\u0027fake\u0027,"},{"line_number":278,"context_line":"                                      mount_point_name\u003d\u0027fake_mp\u0027)"},{"line_number":279,"context_line":"        \u0027\u0027\u0027self.share_transfer_api.create(context.get_admin_context(),"},{"line_number":280,"context_line":"                                       share_id,"},{"line_number":281,"context_line":"                                       \u0027test_missing_share_type\u0027)\u0027\u0027\u0027"},{"line_number":282,"context_line":"        self.assertRaises(exception.Invalid,"},{"line_number":283,"context_line":"                          self.share_transfer_api.create,"},{"line_number":284,"context_line":"                          context.get_admin_context(), share_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"25ff1388_7c30ac35","line":281,"range":{"start_line":279,"start_character":0,"end_line":281,"end_character":68},"updated":"2024-03-07 22:48:38.000000000","message":"please remove...","commit_id":"ea1ac5f4482121712c7a481e6d5ddb98b181b66e"}],"manila/tests/db_utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        \u0027host\u0027: \u0027fake_host\u0027,"},{"line_number":97,"context_line":"        \u0027is_soft_deleted\u0027: False,"},{"line_number":98,"context_line":"        \u0027mount_point_name\u0027: \u0027fake_mp\u0027"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":"    return _create_db_row(db.share_create, share, kwargs)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"2ddd3296_98df0aff","line":99,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \u0027host\u0027: \u0027fake_host\u0027,"},{"line_number":97,"context_line":"        \u0027is_soft_deleted\u0027: False,"},{"line_number":98,"context_line":"        \u0027mount_point_name\u0027: \u0027fake_mp\u0027"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":"    return _create_db_row(db.share_create, share, kwargs)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"41387a4d_9f94f87f","line":99,"in_reply_to":"2ddd3296_98df0aff","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        \u0027status\u0027: constants.STATUS_CREATING,"},{"line_number":115,"context_line":"        \u0027host\u0027: \u0027fake_host\u0027,"},{"line_number":116,"context_line":"        \u0027is_soft_deleted\u0027: False,"},{"line_number":117,"context_line":"        \u0027mount_point_name\u0027: None"},{"line_number":118,"context_line":"    }"},{"line_number":119,"context_line":"    share.update(copy.deepcopy(kwargs))"},{"line_number":120,"context_line":"    return db.share_create(context.get_admin_context(), share, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7b6b2b86_b06f0352","line":117,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        \u0027status\u0027: constants.STATUS_CREATING,"},{"line_number":115,"context_line":"        \u0027host\u0027: \u0027fake_host\u0027,"},{"line_number":116,"context_line":"        \u0027is_soft_deleted\u0027: False,"},{"line_number":117,"context_line":"        \u0027mount_point_name\u0027: None"},{"line_number":118,"context_line":"    }"},{"line_number":119,"context_line":"    share.update(copy.deepcopy(kwargs))"},{"line_number":120,"context_line":"    return db.share_create(context.get_admin_context(), share, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ddfd8f34_0fe93963","line":117,"in_reply_to":"7b6b2b86_b06f0352","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"}],"manila/tests/scheduler/fakes.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dca438c2270a2f833bdaef3a95f990fd7243532","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from manila.scheduler import host_manager"},{"line_number":23,"context_line":"from manila.scheduler.weighers import base_host as base_host_weigher"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"FAKE_AZ_1 \u003d {\u0027name\u0027: \u0027zone1\u0027, \u0027id\u0027: \u002724433438-c9b5-4cb5-a472-f78462aa5f31\u0027}"},{"line_number":27,"context_line":"FAKE_AZ_2 \u003d {\u0027name\u0027: \u0027zone2\u0027, \u0027id\u0027: \u0027ebef050c-d20d-4c44-b272-1a0adce11cb5\u0027}"},{"line_number":28,"context_line":"FAKE_AZ_3 \u003d {\u0027name\u0027: \u0027zone3\u0027, \u0027id\u0027: \u002718e7e6e2-39d6-466b-a706-2717bd1086e1\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"bba3e216_00784808","side":"PARENT","line":25,"updated":"2024-02-15 12:42:00.000000000","message":"I\u0027d recommend not removing blank lines like this, so we don\u0027t get confused in the future when checking the history of commits","commit_id":"a7ffbf7bd0b62fea1c94eaaa6cc518298704ad85"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from manila.scheduler import host_manager"},{"line_number":23,"context_line":"from manila.scheduler.weighers import base_host as base_host_weigher"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"FAKE_AZ_1 \u003d {\u0027name\u0027: \u0027zone1\u0027, \u0027id\u0027: \u002724433438-c9b5-4cb5-a472-f78462aa5f31\u0027}"},{"line_number":27,"context_line":"FAKE_AZ_2 \u003d {\u0027name\u0027: \u0027zone2\u0027, \u0027id\u0027: \u0027ebef050c-d20d-4c44-b272-1a0adce11cb5\u0027}"},{"line_number":28,"context_line":"FAKE_AZ_3 \u003d {\u0027name\u0027: \u0027zone3\u0027, \u0027id\u0027: \u002718e7e6e2-39d6-466b-a706-2717bd1086e1\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"e5d43488_de740dfe","side":"PARENT","line":25,"in_reply_to":"bba3e216_00784808","updated":"2024-02-21 17:03:21.000000000","message":"removed","commit_id":"a7ffbf7bd0b62fea1c94eaaa6cc518298704ad85"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dca438c2270a2f833bdaef3a95f990fd7243532","unresolved":true,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"def get_fake_host(host_name\u003dNone):"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    class FakeHost(object):"},{"line_number":602,"context_line":"        def __init__(self, host_name\u003dNone):"},{"line_number":603,"context_line":"            self.host \u003d host_name or \u0027openstack@BackendZ#PoolA\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"2653e31a_28adb2a9","side":"PARENT","line":600,"updated":"2024-02-15 12:42:00.000000000","message":"same as above","commit_id":"a7ffbf7bd0b62fea1c94eaaa6cc518298704ad85"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"def get_fake_host(host_name\u003dNone):"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    class FakeHost(object):"},{"line_number":602,"context_line":"        def __init__(self, host_name\u003dNone):"},{"line_number":603,"context_line":"            self.host \u003d host_name or \u0027openstack@BackendZ#PoolA\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"a6d85881_1b5f3919","side":"PARENT","line":600,"in_reply_to":"2653e31a_28adb2a9","updated":"2024-02-21 17:03:21.000000000","message":"removed","commit_id":"a7ffbf7bd0b62fea1c94eaaa6cc518298704ad85"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":128,"context_line":"                                  provisioned_capacity_gb\u003d10,"},{"line_number":129,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":130,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":131,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":132,"context_line":"                                  )]),"},{"line_number":133,"context_line":"    \u0027host2@BBB\u0027: dict(share_backend_name\u003d\u0027BBB\u0027,"},{"line_number":134,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"6d51bd0a_b2b67c70","line":131,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                  provisioned_capacity_gb\u003d10,"},{"line_number":129,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":130,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":131,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":132,"context_line":"                                  )]),"},{"line_number":133,"context_line":"    \u0027host2@BBB\u0027: dict(share_backend_name\u003d\u0027BBB\u0027,"},{"line_number":134,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"0bd74dc7_2d8307d9","line":131,"in_reply_to":"6d51bd0a_b2b67c70","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                                  provisioned_capacity_gb\u003d60,"},{"line_number":149,"context_line":"                                  max_over_subscription_ratio\u003d2.0,"},{"line_number":150,"context_line":"                                  thin_provisioning\u003dTrue,"},{"line_number":151,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":152,"context_line":"                                  )]),"},{"line_number":153,"context_line":"    \u0027host3@CCC\u0027: dict(share_backend_name\u003d\u0027CCC\u0027,"},{"line_number":154,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"0d7b9dd6_cf4322c5","line":151,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                  provisioned_capacity_gb\u003d60,"},{"line_number":149,"context_line":"                                  max_over_subscription_ratio\u003d2.0,"},{"line_number":150,"context_line":"                                  thin_provisioning\u003dTrue,"},{"line_number":151,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":152,"context_line":"                                  )]),"},{"line_number":153,"context_line":"    \u0027host3@CCC\u0027: dict(share_backend_name\u003d\u0027CCC\u0027,"},{"line_number":154,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"6693c2cb_e1d69f5b","line":151,"in_reply_to":"0d7b9dd6_cf4322c5","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":168,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":169,"context_line":"                                  max_over_subscription_ratio\u003d20.0,"},{"line_number":170,"context_line":"                                  thin_provisioning\u003dTrue,"},{"line_number":171,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":172,"context_line":"                                  )]),"},{"line_number":173,"context_line":"    \u0027host4@DDD\u0027: dict(share_backend_name\u003d\u0027DDD\u0027,"},{"line_number":174,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"050d703d_809748f8","line":171,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":169,"context_line":"                                  max_over_subscription_ratio\u003d20.0,"},{"line_number":170,"context_line":"                                  thin_provisioning\u003dTrue,"},{"line_number":171,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":172,"context_line":"                                  )]),"},{"line_number":173,"context_line":"    \u0027host4@DDD\u0027: dict(share_backend_name\u003d\u0027DDD\u0027,"},{"line_number":174,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"97a61fa8_bed4d04a","line":171,"in_reply_to":"050d703d_809748f8","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":188,"context_line":"                                  provisioned_capacity_gb\u003d800,"},{"line_number":189,"context_line":"                                  max_over_subscription_ratio\u003d2.0,"},{"line_number":190,"context_line":"                                  thin_provisioning\u003dTrue,"},{"line_number":191,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":192,"context_line":"                                  ),"},{"line_number":193,"context_line":"                             dict(pool_name\u003d\u0027pool4b\u0027,"},{"line_number":194,"context_line":"                                  total_capacity_gb\u003d542,"}],"source_content_type":"text/x-python","patch_set":5,"id":"60d2f542_6c45c5d6","line":191,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                  provisioned_capacity_gb\u003d800,"},{"line_number":189,"context_line":"                                  max_over_subscription_ratio\u003d2.0,"},{"line_number":190,"context_line":"                                  thin_provisioning\u003dTrue,"},{"line_number":191,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":192,"context_line":"                                  ),"},{"line_number":193,"context_line":"                             dict(pool_name\u003d\u0027pool4b\u0027,"},{"line_number":194,"context_line":"                                  total_capacity_gb\u003d542,"}],"source_content_type":"text/x-python","patch_set":5,"id":"88048ece_27fa3a99","line":191,"in_reply_to":"60d2f542_6c45c5d6","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":199,"context_line":"                                  provisioned_capacity_gb\u003d2000,"},{"line_number":200,"context_line":"                                  max_over_subscription_ratio\u003d10.0,"},{"line_number":201,"context_line":"                                  thin_provisioning\u003dTrue,"},{"line_number":202,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":203,"context_line":"                                  )]),"},{"line_number":204,"context_line":"    \u0027host5@EEE\u0027: dict(share_backend_name\u003d\u0027EEE\u0027,"},{"line_number":205,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"f5ae5914_d8be45f0","line":202,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                  provisioned_capacity_gb\u003d2000,"},{"line_number":200,"context_line":"                                  max_over_subscription_ratio\u003d10.0,"},{"line_number":201,"context_line":"                                  thin_provisioning\u003dTrue,"},{"line_number":202,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":203,"context_line":"                                  )]),"},{"line_number":204,"context_line":"    \u0027host5@EEE\u0027: dict(share_backend_name\u003d\u0027EEE\u0027,"},{"line_number":205,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"4c7cf720_df22e433","line":202,"in_reply_to":"f5ae5914_d8be45f0","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":219,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":220,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":221,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":222,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":223,"context_line":"                                  ),"},{"line_number":224,"context_line":"                             dict(pool_name\u003d\u0027pool5b\u0027,"},{"line_number":225,"context_line":"                                  total_capacity_gb\u003d552,"}],"source_content_type":"text/x-python","patch_set":5,"id":"afad84b5_a7581b6a","line":222,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":220,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":221,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":222,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":223,"context_line":"                                  ),"},{"line_number":224,"context_line":"                             dict(pool_name\u003d\u0027pool5b\u0027,"},{"line_number":225,"context_line":"                                  total_capacity_gb\u003d552,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a0abd483_f8511e7b","line":222,"in_reply_to":"afad84b5_a7581b6a","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":230,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":231,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":232,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":233,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":234,"context_line":"                                  )]),"},{"line_number":235,"context_line":"    \u0027host6@FFF\u0027: dict(share_backend_name\u003d\u0027FFF\u0027,"},{"line_number":236,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"6c38f531_fde30d12","line":233,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":231,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":232,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":233,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":234,"context_line":"                                  )]),"},{"line_number":235,"context_line":"    \u0027host6@FFF\u0027: dict(share_backend_name\u003d\u0027FFF\u0027,"},{"line_number":236,"context_line":"                      timestamp\u003dNone, reserved_percentage\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"0dd63639_36929d4d","line":233,"in_reply_to":"6c38f531_fde30d12","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":251,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":252,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":253,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":254,"context_line":"                                  ),"},{"line_number":255,"context_line":"                             dict(pool_name\u003d\u0027pool6b\u0027,"},{"line_number":256,"context_line":"                                  total_capacity_gb\u003d\u0027unknown\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"58f0d74e_e28a5d31","line":253,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":251,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":252,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":253,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":254,"context_line":"                                  ),"},{"line_number":255,"context_line":"                             dict(pool_name\u003d\u0027pool6b\u0027,"},{"line_number":256,"context_line":"                                  total_capacity_gb\u003d\u0027unknown\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a236155_e0e2fe11","line":253,"in_reply_to":"58f0d74e_e28a5d31","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":261,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":262,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":263,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":264,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":265,"context_line":"                                  )]),"},{"line_number":266,"context_line":"}"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fe81170e_c7eddcb9","line":264,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                                  provisioned_capacity_gb\u003d100,"},{"line_number":262,"context_line":"                                  max_over_subscription_ratio\u003d1.0,"},{"line_number":263,"context_line":"                                  thin_provisioning\u003dFalse,"},{"line_number":264,"context_line":"                                  human_readable_export_location_support\u003dFalse"},{"line_number":265,"context_line":"                                  )]),"},{"line_number":266,"context_line":"}"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"8eeeef22_6345dc02","line":264,"in_reply_to":"fe81170e_c7eddcb9","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"}],"manila/tests/scheduler/filters/test_capabilities.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dca438c2270a2f833bdaef3a95f990fd7243532","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    def test_human_readable_export_location_support_pass(self):"},{"line_number":49,"context_line":"        capabilities \u003d {\u0027human_readable_export_location_support\u0027: True}"},{"line_number":50,"context_line":"        service \u003d {\u0027disabled\u0027: False}"},{"line_number":51,"context_line":"        filter_properties \u003d \\"},{"line_number":52,"context_line":"            dict("},{"line_number":53,"context_line":"                resource_type\u003d{\u0027request_spec\u0027: {\u0027share_properties\u0027: dict("},{"line_number":54,"context_line":"                    mount_point_name\u003d\u0027fake_mp\u0027)}})"},{"line_number":55,"context_line":"        host \u003d fakes.FakeHostState(\u0027host1\u0027,"},{"line_number":56,"context_line":"                                   {\u0027free_capacity_gb\u0027: 1024,"},{"line_number":57,"context_line":"                                    \u0027capabilities\u0027: capabilities,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0d2fa9d8_c32c6326","line":54,"range":{"start_line":51,"start_character":28,"end_line":54,"end_character":50},"updated":"2024-02-15 12:42:00.000000000","message":"you could also wrap the statement with ( instead of adding the \\\nor declare a dictionary without calling the function:\n\n```\n        filter_properties \u003d {\n            \u0027resource_type\u0027: {\n                \u0027request_spec\u0027: {\n                    \u0027share_properties\u0027: {\n                        \u0027mount_point_name\u0027: \u0027fake_mp\u0027\n                    }\n                }\n            }\n        }\n```\nI believe it would look more readable if written like this","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"01c07fad7a06839f2b64ea83a61463cb5f28c66a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_human_readable_export_location_support_pass(self):"},{"line_number":49,"context_line":"        capabilities \u003d {\u0027human_readable_export_location_support\u0027: True}"},{"line_number":50,"context_line":"        service \u003d {\u0027disabled\u0027: False}"},{"line_number":51,"context_line":"        filter_properties \u003d \\"},{"line_number":52,"context_line":"            dict("},{"line_number":53,"context_line":"                resource_type\u003d{\u0027request_spec\u0027: {\u0027share_properties\u0027: dict("},{"line_number":54,"context_line":"                    mount_point_name\u003d\u0027fake_mp\u0027)}})"},{"line_number":55,"context_line":"        host \u003d fakes.FakeHostState(\u0027host1\u0027,"},{"line_number":56,"context_line":"                                   {\u0027free_capacity_gb\u0027: 1024,"},{"line_number":57,"context_line":"                                    \u0027capabilities\u0027: capabilities,"}],"source_content_type":"text/x-python","patch_set":4,"id":"874089cd_c58d55ba","line":54,"range":{"start_line":51,"start_character":28,"end_line":54,"end_character":50},"in_reply_to":"0d2fa9d8_c32c6326","updated":"2024-02-21 17:03:21.000000000","message":"updated to new format","commit_id":"26b5378dd1e80bd12b4ec605ac2131d96276ec7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            \u0027resource_type\u0027: {"},{"line_number":53,"context_line":"                \u0027request_spec\u0027: {"},{"line_number":54,"context_line":"                    \u0027share_properties\u0027: {"},{"line_number":55,"context_line":"                        \u0027mount_point_name\u0027: \u0027fake_mp\u0027"},{"line_number":56,"context_line":"                    }"},{"line_number":57,"context_line":"                }"},{"line_number":58,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":5,"id":"4009fd96_6872b8c1","line":55,"updated":"2024-02-23 10:10:27.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            \u0027resource_type\u0027: {"},{"line_number":53,"context_line":"                \u0027request_spec\u0027: {"},{"line_number":54,"context_line":"                    \u0027share_properties\u0027: {"},{"line_number":55,"context_line":"                        \u0027mount_point_name\u0027: \u0027fake_mp\u0027"},{"line_number":56,"context_line":"                    }"},{"line_number":57,"context_line":"                }"},{"line_number":58,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":5,"id":"f8e077f0_71d6c64b","line":55,"updated":"2024-02-23 10:10:27.000000000","message":"shouldn\u0027t the request spec contain a share type that has the extra-spec: human_readable_export_location_support\u003dTrue for this test to make sense? You can also include \"provisioning:mount_point_prefix\" as an extra-spec so you can test that the filter scheduler ignores that key altogether","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027resource_type\u0027: {"},{"line_number":53,"context_line":"                \u0027request_spec\u0027: {"},{"line_number":54,"context_line":"                    \u0027share_properties\u0027: {"},{"line_number":55,"context_line":"                        \u0027mount_point_name\u0027: \u0027fake_mp\u0027"},{"line_number":56,"context_line":"                    }"},{"line_number":57,"context_line":"                }"},{"line_number":58,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae41763_64486d1f","line":55,"in_reply_to":"4009fd96_6872b8c1","updated":"2024-03-04 16:03:44.000000000","message":"added trailing comma","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027resource_type\u0027: {"},{"line_number":53,"context_line":"                \u0027request_spec\u0027: {"},{"line_number":54,"context_line":"                    \u0027share_properties\u0027: {"},{"line_number":55,"context_line":"                        \u0027mount_point_name\u0027: \u0027fake_mp\u0027"},{"line_number":56,"context_line":"                    }"},{"line_number":57,"context_line":"                }"},{"line_number":58,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":5,"id":"af8a1e01_44cb9925","line":55,"in_reply_to":"f8e077f0_71d6c64b","updated":"2024-03-04 16:03:44.000000000","message":"Not sure how provisioning:mount_point_prefix is used in scheduler filtering. Can you point at example UTs, I will try to understand inner workings and add new UTs.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"}],"manila/transfer/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":169,"context_line":"                            target_obj\u003dshare_ref)"},{"line_number":170,"context_line":"        share_instance \u003d share_ref[\u0027instance\u0027]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        mount_point_name \u003d share_instance[\u0027mount_point_name\u0027]"},{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(context.project_id)):"},{"line_number":175,"context_line":"            raise exception.Invalid(reason\u003d_(\"Share\u0027s transfer not supported \""},{"line_number":176,"context_line":"                                             \"for share without share type\"))"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"c0d6d781_9f5828b7","line":174,"range":{"start_line":172,"start_character":8,"end_line":174,"end_character":65},"updated":"2024-03-05 23:58:57.000000000","message":"you\u0027re checking the wrong project_id; context.project_id refers to the project of the person initiating the transfer... it\u0027s possible that an administrator initiates the share transfer, while the share belongs to a different tenant/project.. \n\nWe store the \"project_id\" in the share object; you should check against this.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                            target_obj\u003dshare_ref)"},{"line_number":170,"context_line":"        share_instance \u003d share_ref[\u0027instance\u0027]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        mount_point_name \u003d share_instance[\u0027mount_point_name\u0027]"},{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(context.project_id)):"},{"line_number":175,"context_line":"            raise exception.Invalid(reason\u003d_(\"Share\u0027s transfer not supported \""},{"line_number":176,"context_line":"                                             \"for share without share type\"))"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a7bee99_4ebf22c4","line":174,"range":{"start_line":172,"start_character":8,"end_line":174,"end_character":65},"in_reply_to":"c0d6d781_9f5828b7","updated":"2024-03-06 20:53:12.000000000","message":"yes using stare project_id","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":172,"context_line":"        mount_point_name \u003d share_instance[\u0027mount_point_name\u0027]"},{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(context.project_id)):"},{"line_number":175,"context_line":"            raise exception.Invalid(reason\u003d_(\"Share\u0027s transfer not supported \""},{"line_number":176,"context_line":"                                             \"for share without share type\"))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        if share_ref[\u0027status\u0027] !\u003d \"available\":"},{"line_number":179,"context_line":"            raise exception.InvalidShare(reason\u003d_(\"Share\u0027s status must be \""}],"source_content_type":"text/x-python","patch_set":7,"id":"a1636dd2_a07bd5cc","line":176,"range":{"start_line":175,"start_character":46,"end_line":176,"end_character":74},"updated":"2024-03-05 17:52:25.000000000","message":"shares will always be tied to a share type... we could change this to something like:\nTransferring shares that have mount point name without a predefined prefix is not supported.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        mount_point_name \u003d share_instance[\u0027mount_point_name\u0027]"},{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(context.project_id)):"},{"line_number":175,"context_line":"            raise exception.Invalid(reason\u003d_(\"Share\u0027s transfer not supported \""},{"line_number":176,"context_line":"                                             \"for share without share type\"))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        if share_ref[\u0027status\u0027] !\u003d \"available\":"},{"line_number":179,"context_line":"            raise exception.InvalidShare(reason\u003d_(\"Share\u0027s status must be \""}],"source_content_type":"text/x-python","patch_set":7,"id":"ffd53e32_49ffbd73","line":176,"range":{"start_line":175,"start_character":46,"end_line":176,"end_character":74},"in_reply_to":"9b0df914_88c0425c","updated":"2024-03-06 20:53:12.000000000","message":"yes, updated to suggested text.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e77605ee969f9b5c0da24f90ba6056690db442b","unresolved":true,"context_lines":[{"line_number":172,"context_line":"        mount_point_name \u003d share_instance[\u0027mount_point_name\u0027]"},{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(context.project_id)):"},{"line_number":175,"context_line":"            raise exception.Invalid(reason\u003d_(\"Share\u0027s transfer not supported \""},{"line_number":176,"context_line":"                                             \"for share without share type\"))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        if share_ref[\u0027status\u0027] !\u003d \"available\":"},{"line_number":179,"context_line":"            raise exception.InvalidShare(reason\u003d_(\"Share\u0027s status must be \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9b0df914_88c0425c","line":176,"range":{"start_line":175,"start_character":46,"end_line":176,"end_character":74},"in_reply_to":"a1636dd2_a07bd5cc","updated":"2024-03-05 23:58:57.000000000","message":"missing a prefix is no longer fixable. \n\nWe should be more explicit about why this transfer is denied; perhaps:\n\n\"Share %s has a custom mount_point_name %s. This has the project_id or project_name encoded in it. Transferring such a share isn\u0027t supported\".","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4669d86fdcb77bcba1378a95300fe0d8b47b16c","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        share_instance \u003d share_ref[\u0027instance\u0027]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        mount_point_name \u003d share_instance[\u0027mount_point_name\u0027]"},{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(share_ref[\u0027project_id\u0027])):"},{"line_number":175,"context_line":"            msg \u003d _(\u0027Share %s has a custom mount_point_name %s.\u0027"},{"line_number":176,"context_line":"                    \u0027 This has the project_id or project_name encoded in it.\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"401b3403_8f710a3a","line":173,"updated":"2024-03-06 23:06:54.000000000","message":"need a unit test for this too.. \n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0b2/908897/8/check/openstack-tox-cover/0b27a89/cover/d_b3807b99d6fcfed9_api_py.html#t176","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        share_instance \u003d share_ref[\u0027instance\u0027]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        mount_point_name \u003d share_instance[\u0027mount_point_name\u0027]"},{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(share_ref[\u0027project_id\u0027])):"},{"line_number":175,"context_line":"            msg \u003d _(\u0027Share %s has a custom mount_point_name %s.\u0027"},{"line_number":176,"context_line":"                    \u0027 This has the project_id or project_name encoded in it.\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"345409b5_eba79f72","line":173,"in_reply_to":"401b3403_8f710a3a","updated":"2024-03-07 22:25:10.000000000","message":"Added UTs to cover this scenario.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00b67bf31bd375097971ab219e139dff1f633a1a","unresolved":true,"context_lines":[{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(share_ref[\u0027project_id\u0027])):"},{"line_number":175,"context_line":"            msg \u003d _(\u0027Share %s has a custom mount_point_name %s.\u0027"},{"line_number":176,"context_line":"                    \u0027 This has the project_id or project_name encoded in it.\u0027"},{"line_number":177,"context_line":"                    \u0027 Transferring such\u0027"},{"line_number":178,"context_line":"                    \u0027 a share isn\\\u0027t supported\u0027) % (share_ref[\u0027name\u0027],"},{"line_number":179,"context_line":"                                                    mount_point_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfb3ac08_b1d145d5","line":176,"range":{"start_line":176,"start_character":46,"end_line":176,"end_character":61},"updated":"2024-03-06 22:44:39.000000000","message":"my bad, we\u0027re not checking for project_name; you can remove this from the message.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6672adcd36a96a89e36120b5e7b92ff0b2411427","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if (mount_point_name and"},{"line_number":174,"context_line":"                mount_point_name.startswith(share_ref[\u0027project_id\u0027])):"},{"line_number":175,"context_line":"            msg \u003d _(\u0027Share %s has a custom mount_point_name %s.\u0027"},{"line_number":176,"context_line":"                    \u0027 This has the project_id or project_name encoded in it.\u0027"},{"line_number":177,"context_line":"                    \u0027 Transferring such\u0027"},{"line_number":178,"context_line":"                    \u0027 a share isn\\\u0027t supported\u0027) % (share_ref[\u0027name\u0027],"},{"line_number":179,"context_line":"                                                    mount_point_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"cdbf82e2_cbb44025","line":176,"range":{"start_line":176,"start_character":46,"end_line":176,"end_character":61},"in_reply_to":"dfb3ac08_b1d145d5","updated":"2024-03-07 22:25:10.000000000","message":"Updated text based on your suggestion.","commit_id":"34417a7788850b774e2301a49df804ee23e63d4c"}],"releasenotes/notes/human-readable-export-location-share-support-a72cd2f0e92c41c7.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added option \"mount_point_name\" to Share create API. Project name"},{"line_number":4,"context_line":"    will be added to this friendly name to have unique name across"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9344ee93_01918ca6","line":1,"updated":"2024-02-23 10:10:27.000000000","message":"Can you please add that support for this was added in the LVM driver?","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added option \"mount_point_name\" to Share create API. Project name"},{"line_number":4,"context_line":"    will be added to this friendly name to have unique name across"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ef997f04_8cc3f6f4","line":1,"in_reply_to":"9344ee93_01918ca6","updated":"2024-03-04 16:03:44.000000000","message":"yes, update LVM driver details.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"982583541bab61c22e5dbe263615efe25898e902","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - Added option \"mount_point_name\" to Share create API. Project name"},{"line_number":4,"context_line":"    will be added to this friendly name to have unique name across"},{"line_number":5,"context_line":"    application. Export location will reflect this location name once"},{"line_number":6,"context_line":"    Share creation is successful. "},{"line_number":7,"context_line":"    Scheduler expect \"human_readable_export_location_support\" from "},{"line_number":8,"context_line":"    driver to provision Share with given \"mount_point_name\"."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bc3d9db5_ef71b773","line":6,"range":{"start_line":6,"start_character":29,"end_line":6,"end_character":31},"updated":"2024-02-23 10:10:27.000000000","message":"remove trailing whitespace at the end of this line\n\nand add a blank/new line at the end of this file.","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bc44d2e297a7b1fc75c89ebd3305a8bf397031e8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added option \"mount_point_name\" to Share create API. Project name"},{"line_number":4,"context_line":"    will be added to this friendly name to have unique name across"},{"line_number":5,"context_line":"    application. Export location will reflect this location name once"},{"line_number":6,"context_line":"    Share creation is successful. "},{"line_number":7,"context_line":"    Scheduler expect \"human_readable_export_location_support\" from "},{"line_number":8,"context_line":"    driver to provision Share with given \"mount_point_name\"."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"04dc61b1_713eaeef","line":6,"range":{"start_line":6,"start_character":29,"end_line":6,"end_character":31},"in_reply_to":"bc3d9db5_ef71b773","updated":"2024-03-04 16:03:44.000000000","message":"removed extra trailing whitespaces","commit_id":"bd6a994e4ef97757729eb0d55a459bdc8f5148ed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added option \"mount_point_name\" to Share create API."},{"line_number":4,"context_line":"    \"provisioning:mount_point_prefix\" share type will be"},{"line_number":5,"context_line":"    prefixed with friendly name when share is created."},{"line_number":6,"context_line":"    Project id will be added to this friendly name"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a8ab40b4_85928bd9","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":55},"updated":"2024-03-05 17:52:25.000000000","message":"A human readable mount point name can now be specified while creating shares through the `mount_point_name` parameter.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added option \"mount_point_name\" to Share create API."},{"line_number":4,"context_line":"    \"provisioning:mount_point_prefix\" share type will be"},{"line_number":5,"context_line":"    prefixed with friendly name when share is created."},{"line_number":6,"context_line":"    Project id will be added to this friendly name"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2dcb6da9_c903f774","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":55},"in_reply_to":"a8ab40b4_85928bd9","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added option \"mount_point_name\" to Share create API."},{"line_number":4,"context_line":"    \"provisioning:mount_point_prefix\" share type will be"},{"line_number":5,"context_line":"    prefixed with friendly name when share is created."},{"line_number":6,"context_line":"    Project id will be added to this friendly name"},{"line_number":7,"context_line":"    \"provisioning:mount_point_prefix\" share type is not"},{"line_number":8,"context_line":"    provided during provisioning."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"faf115cb_08ff6c8d","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":53},"updated":"2024-03-05 17:52:25.000000000","message":"Manila will prepend a prefix to the mount point name which can be configured through the `provisioning:mount_point_prefix` share type extra spec.\nIn case this extra spec is not available in the share type, Manila will prepend a project identification to the mount point name.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added option \"mount_point_name\" to Share create API."},{"line_number":4,"context_line":"    \"provisioning:mount_point_prefix\" share type will be"},{"line_number":5,"context_line":"    prefixed with friendly name when share is created."},{"line_number":6,"context_line":"    Project id will be added to this friendly name"},{"line_number":7,"context_line":"    \"provisioning:mount_point_prefix\" share type is not"},{"line_number":8,"context_line":"    provided during provisioning."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"60c5f4d7_3a8c764f","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":53},"in_reply_to":"faf115cb_08ff6c8d","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    Project id will be added to this friendly name"},{"line_number":7,"context_line":"    \"provisioning:mount_point_prefix\" share type is not"},{"line_number":8,"context_line":"    provided during provisioning."},{"line_number":9,"context_line":"    Scheduler expect \"mount_point_name_support\" from"},{"line_number":10,"context_line":"    driver to provision Share with given \"mount_point_name\"."},{"line_number":11,"context_line":"    Now, LVM driver has support for \"mount_point_name\"."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"83bbf55b_8cfbc49a","line":10,"range":{"start_line":9,"start_character":4,"end_line":10,"end_character":60},"updated":"2024-03-05 17:52:25.000000000","message":"I\u0027d drop this phrase, as it\u0027s giving some drivers\u0027 technical details.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    Project id will be added to this friendly name"},{"line_number":7,"context_line":"    \"provisioning:mount_point_prefix\" share type is not"},{"line_number":8,"context_line":"    provided during provisioning."},{"line_number":9,"context_line":"    Scheduler expect \"mount_point_name_support\" from"},{"line_number":10,"context_line":"    driver to provision Share with given \"mount_point_name\"."},{"line_number":11,"context_line":"    Now, LVM driver has support for \"mount_point_name\"."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"53eacdc4_ac783c8d","line":10,"range":{"start_line":9,"start_character":4,"end_line":10,"end_character":60},"in_reply_to":"83bbf55b_8cfbc49a","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a027155c126dab873bd4bcb3da77326783c4fe8","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    provided during provisioning."},{"line_number":9,"context_line":"    Scheduler expect \"mount_point_name_support\" from"},{"line_number":10,"context_line":"    driver to provision Share with given \"mount_point_name\"."},{"line_number":11,"context_line":"    Now, LVM driver has support for \"mount_point_name\"."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fbf4c66_85fc25c6","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":55},"updated":"2024-03-05 17:52:25.000000000","message":"I\u0027d make this a new bullet:\nThe LVM driver now supports human readable export locations.","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41499ec67380f54ac92d60d4acf94602de3561d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    provided during provisioning."},{"line_number":9,"context_line":"    Scheduler expect \"mount_point_name_support\" from"},{"line_number":10,"context_line":"    driver to provision Share with given \"mount_point_name\"."},{"line_number":11,"context_line":"    Now, LVM driver has support for \"mount_point_name\"."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"658b097b_a7875982","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":55},"in_reply_to":"9fbf4c66_85fc25c6","updated":"2024-03-06 20:53:12.000000000","message":"Thank you! updated text","commit_id":"a0619a38ade6aff734f4b435ec5a9b88a0ac13ea"}]}