)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bee3336ba18f20658304ab8f49fc16c99fcfa5e2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix unit test compabitility with netaddr \u003e\u003d 1.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"netaddr.valid_ipv4 throws an exception in case a non string value is"},{"line_number":10,"context_line":"given, since 1.0.0[1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/netaddr/netaddr/issues/368"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"86a7e9f9_b7c74721","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":22},"updated":"2024-02-19 23:52:53.000000000","message":"ty; very fruitful discussion in the issue as well; \n\nmy suggestion here however is to fix the is_valid_ip method (instead of the tests) and return False if the caller sends a None (or a non-string really)..","commit_id":"f4767f89eed45831be759150b07d28c8d91b9c67"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ff4f8d518b61c2962ac4b7e757b1f43188e2f880","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix unit test compabitility with netaddr \u003e\u003d 1.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"netaddr.valid_ipv4 throws an exception in case a non string value is"},{"line_number":10,"context_line":"given, since 1.0.0[1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/netaddr/netaddr/issues/368"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"317ecaa3_90ea0ff8","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":22},"in_reply_to":"27cd8bff_16b20226","updated":"2024-02-20 00:59:03.000000000","message":"you mean in netaddr? I was referring to manila\u0027s own utils method that is being tested in the tests you\u0027re fixing.. \n\nhttps://opendev.org/openstack/manila/src/commit/9c62dbdf26ecb82b684a33a98c9b30dbb40dc5a2/manila/utils.py#L385-L400","commit_id":"f4767f89eed45831be759150b07d28c8d91b9c67"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"75077102435644e494f97468cafc7fd84f5e7db7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix unit test compabitility with netaddr \u003e\u003d 1.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"netaddr.valid_ipv4 throws an exception in case a non string value is"},{"line_number":10,"context_line":"given, since 1.0.0[1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/netaddr/netaddr/issues/368"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b9df15d7_ec7442f1","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":22},"in_reply_to":"317ecaa3_90ea0ff8","updated":"2024-02-20 05:19:22.000000000","message":"I meant the methods (actually these are netutils.is_valid_ipv4 and netutils.is_valid_ipv6) in oslo.utils, but as you said we can add a logic to manila probably. Let me submit a different proposal.","commit_id":"f4767f89eed45831be759150b07d28c8d91b9c67"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2f139381f0393dba8f073a87f8bfc976c929d339","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix unit test compabitility with netaddr \u003e\u003d 1.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"netaddr.valid_ipv4 throws an exception in case a non string value is"},{"line_number":10,"context_line":"given, since 1.0.0[1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/netaddr/netaddr/issues/368"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"27cd8bff_16b20226","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":22},"in_reply_to":"86a7e9f9_b7c74721","updated":"2024-02-20 00:56:22.000000000","message":"We can still fix it, but even is_valid_ip in oslo.util says it expects a string value, according to param doc. Also, I\u0027m unsure it\u0027s a good idea to test detailed behavior of it in manila unit tests.","commit_id":"f4767f89eed45831be759150b07d28c8d91b9c67"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6ec601e6f577f086e985e0e236b06615e00c2d1e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"981fd7d9_5f5d7f8c","updated":"2024-02-20 05:21:53.000000000","message":"See https://review.opendev.org/c/openstack/manila/+/909497","commit_id":"f4767f89eed45831be759150b07d28c8d91b9c67"}]}