)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9076,"name":"Kris Lindgren","email":"klindgren@godaddy.com","username":"klindgren"},"change_message_id":"d85b5e78716d0ebf4667260bab04f344b25954ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d2298df_7e8e4070","updated":"2024-02-22 19:16:43.000000000","message":"Confirmed that from a function perspective this code will update existing shares on hash update.  In addition to new shares being created also having the share metadata.","commit_id":"7bb6f2aa73725566aa35851f39ca6d488d1a1dcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"168a8cb5834974f618119a902116671b69d8b264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9df3487_ff222bdc","updated":"2024-02-24 00:26:52.000000000","message":"LGTM thank you Carlos. I have some comments for improvement; you can follow up and i\u0027ll +2 again","commit_id":"7bb6f2aa73725566aa35851f39ca6d488d1a1dcc"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f9d920f6c902bf58c55aa125e2f3aad23a8ca771","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7cd015ca_10ceed97","updated":"2024-03-01 06:40:32.000000000","message":"LGTM,thanks for your change, let\u0027s merge it.","commit_id":"7e585a3bb56bf22fedd6cae1cf942d42d35c9b89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cc8c5cccd9996f4b3d5b1bbc6a792e109cb755a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc20a294_1e96fcd6","updated":"2024-02-28 22:26:45.000000000","message":"LGTM; the name of the config opt in the release note of this patch is “admin_only_metadata_keys” while the parent patch still introduces it as “admin_metadata_keys”; but that’s a change that needs to be made in the parent patch","commit_id":"7e585a3bb56bf22fedd6cae1cf942d42d35c9b89"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1389e945a770de31d33e7a06f3449ea036ccc96c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"181a03e1_b6935732","updated":"2024-02-28 12:36:48.000000000","message":"TY for the review, Goutham! PTAL :)","commit_id":"7e585a3bb56bf22fedd6cae1cf942d42d35c9b89"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"168a8cb5834974f618119a902116671b69d8b264","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        return self.protocol_helper.get_export_locations(share, subvolume_path)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def get_optional_share_creation_data(self, share, share_server\u003dNone):"},{"line_number":357,"context_line":"        \"\"\"Get the to be set in a share."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        :return: the metadata to be set in share."},{"line_number":360,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"e0d73fd5_923e2c36","line":357,"range":{"start_line":357,"start_character":15,"end_line":357,"end_character":18},"updated":"2024-02-24 00:26:52.000000000","message":"additional properties?","commit_id":"7bb6f2aa73725566aa35851f39ca6d488d1a1dcc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1389e945a770de31d33e7a06f3449ea036ccc96c","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        return self.protocol_helper.get_export_locations(share, subvolume_path)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def get_optional_share_creation_data(self, share, share_server\u003dNone):"},{"line_number":357,"context_line":"        \"\"\"Get the to be set in a share."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        :return: the metadata to be set in share."},{"line_number":360,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ac13b6c9_555091e7","line":357,"range":{"start_line":357,"start_character":15,"end_line":357,"end_character":18},"in_reply_to":"e0d73fd5_923e2c36","updated":"2024-02-28 12:36:48.000000000","message":"Done","commit_id":"7bb6f2aa73725566aa35851f39ca6d488d1a1dcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"168a8cb5834974f618119a902116671b69d8b264","unresolved":true,"context_lines":[{"line_number":855,"context_line":"        return {"},{"line_number":856,"context_line":"            \"cephfs_ensure_all_shares_salt\":"},{"line_number":857,"context_line":"                self.configuration.cephfs_ensure_all_shares_salt,"},{"line_number":858,"context_line":"            \"cephfs_filesystem_name\": self.volname"},{"line_number":859,"context_line":"        }"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def get_export_locations(self, share, subvolume_path):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fed6bde2_349d98b6","line":858,"updated":"2024-02-24 00:26:52.000000000","message":"nit: trailing comma","commit_id":"7bb6f2aa73725566aa35851f39ca6d488d1a1dcc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1389e945a770de31d33e7a06f3449ea036ccc96c","unresolved":false,"context_lines":[{"line_number":855,"context_line":"        return {"},{"line_number":856,"context_line":"            \"cephfs_ensure_all_shares_salt\":"},{"line_number":857,"context_line":"                self.configuration.cephfs_ensure_all_shares_salt,"},{"line_number":858,"context_line":"            \"cephfs_filesystem_name\": self.volname"},{"line_number":859,"context_line":"        }"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def get_export_locations(self, share, subvolume_path):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5231c178_3d23cc40","line":858,"in_reply_to":"fed6bde2_349d98b6","updated":"2024-02-28 12:36:48.000000000","message":"Done","commit_id":"7bb6f2aa73725566aa35851f39ca6d488d1a1dcc"}],"releasenotes/notes/bug-2050010-add-filesystem-name-metadata-to-cephfs-shares-5725d751980360ec.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"168a8cb5834974f618119a902116671b69d8b264","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Shares created using the CEPHFS Native protocol will now have a new"},{"line_number":5,"context_line":"    `__mount_options` metadata containing the `cephfs_filesystem_name` to"},{"line_number":6,"context_line":"    enhance usability while mounting shares. Existing shares will be updated"},{"line_number":7,"context_line":"    thorugh the ensure shares workflow."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"333281a5_0ab75f89","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":39},"updated":"2024-02-24 00:26:52.000000000","message":"Do mention:\n\n\"\"\"\n\nTo preserve backwards compatibility, this metadata is mutable by end users. It is strongly recommended that administrators include \"__mount_options\" in the `[DEFAULT]/admin_only_metadata_keys` configuration option.\n\n\n\"\"\"\n\n\nIn another patch; i do hope we can include \"__mount_options\" to the default list of admin_only_metadata for Caracal and beyond.","commit_id":"7bb6f2aa73725566aa35851f39ca6d488d1a1dcc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1389e945a770de31d33e7a06f3449ea036ccc96c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Shares created using the CEPHFS Native protocol will now have a new"},{"line_number":5,"context_line":"    `__mount_options` metadata containing the `cephfs_filesystem_name` to"},{"line_number":6,"context_line":"    enhance usability while mounting shares. Existing shares will be updated"},{"line_number":7,"context_line":"    thorugh the ensure shares workflow."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6bf4a60d_5b9fe9bc","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":39},"in_reply_to":"333281a5_0ab75f89","updated":"2024-02-28 12:36:48.000000000","message":"Done","commit_id":"7bb6f2aa73725566aa35851f39ca6d488d1a1dcc"}]}