)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4da36aaed9294771501a128fdff7f974cead8499","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4c98ae0_5e8ddd62","updated":"2024-06-11 19:25:06.000000000","message":"Thanks for fixing this up Carlos! please see comments inline","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"72b87f23a6f078fa9725175c22172fdb96745e6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0fe52e93_dfa8ec2a","updated":"2024-06-14 02:00:09.000000000","message":"almost looks good to me, thanks Carlos, just one comment.","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8acf8898a56f0961632d07c662e74323fbd1b9f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4bbc4d55_274ea924","updated":"2024-06-14 18:02:33.000000000","message":"Great; thanks Carlos; we should backport this to stable/2024.1 when it merges","commit_id":"12aa2913baa4e004d2198f0a5fd3ad9ccfeb302d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6e715263ccdc91749be3ec9405121a3d231631ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"77244944_b811d1fe","updated":"2024-06-14 15:44:55.000000000","message":"Thanks for the reviews. PTAL","commit_id":"12aa2913baa4e004d2198f0a5fd3ad9ccfeb302d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5032c449304c87248467081b4d1dae571435dfaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff943842_8e841097","updated":"2024-06-18 08:47:49.000000000","message":"let\u0027s merge this change, thanks.","commit_id":"12aa2913baa4e004d2198f0a5fd3ad9ccfeb302d"}],"manila/scheduler/evaluator/evaluator.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4da36aaed9294771501a128fdff7f974cead8499","unresolved":true,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def _def_parser():"},{"line_number":229,"context_line":"    # Enabling packrat parsing greatly speeds up the parsing."},{"line_number":230,"context_line":"    # pylint: disable \u003d no-value-for-parameter"},{"line_number":231,"context_line":"    pyparsing.ParserElement.enablePackrat()"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    alphas \u003d pyparsing.alphas"}],"source_content_type":"text/x-python","patch_set":3,"id":"d321e9da_c3917378","line":230,"range":{"start_line":230,"start_character":4,"end_line":230,"end_character":46},"updated":"2024-06-11 19:25:06.000000000","message":"what all get flagged here? can we add this to the individual lines?","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6e715263ccdc91749be3ec9405121a3d231631ac","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def _def_parser():"},{"line_number":229,"context_line":"    # Enabling packrat parsing greatly speeds up the parsing."},{"line_number":230,"context_line":"    # pylint: disable \u003d no-value-for-parameter"},{"line_number":231,"context_line":"    pyparsing.ParserElement.enablePackrat()"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    alphas \u003d pyparsing.alphas"}],"source_content_type":"text/x-python","patch_set":3,"id":"c5d568bf_cc211e23","line":230,"range":{"start_line":230,"start_character":4,"end_line":230,"end_character":46},"in_reply_to":"d321e9da_c3917378","updated":"2024-06-14 15:44:55.000000000","message":"Done","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"}],"manila/share/api.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dbf7fc33ab6172101419f96bcc48bcdd6bf9d754","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        except Exception:"},{"line_number":480,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":481,"context_line":"                try:"},{"line_number":482,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":483,"context_line":"                    self.db.share_delete(context, share[\u0027id\u0027])"},{"line_number":484,"context_line":"                finally:"},{"line_number":485,"context_line":"                    QUOTAS.rollback("}],"source_content_type":"text/x-python","patch_set":3,"id":"ddc92baf_4f0b077d","line":482,"range":{"start_line":482,"start_character":20,"end_line":482,"end_character":62},"updated":"2024-06-07 21:11:23.000000000","message":"share is being defined within the try/catch block, so we always assume this exception would be related to the quotas.commit thing. Otherwise, we will fail here as well, because share won\u0027t have an ID. It is a DB record creation, so I see the logic on trusting that the DB will be able to handle this call and create the record easily. Otherwise, we must move the declaration outside and before trying to access the value for share[\u0027id\u0027] check if it actually exists.","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"72b87f23a6f078fa9725175c22172fdb96745e6f","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        except Exception:"},{"line_number":480,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":481,"context_line":"                try:"},{"line_number":482,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":483,"context_line":"                    self.db.share_delete(context, share[\u0027id\u0027])"},{"line_number":484,"context_line":"                finally:"},{"line_number":485,"context_line":"                    QUOTAS.rollback("}],"source_content_type":"text/x-python","patch_set":3,"id":"57818cda_c9321401","line":482,"range":{"start_line":482,"start_character":20,"end_line":482,"end_character":62},"in_reply_to":"573a1ce9_5df399f7","updated":"2024-06-14 02:00:09.000000000","message":"i also agree with setting share\u003dNone above. if DB error, share[\u0027id\u0027] will raise KeyError.","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6e715263ccdc91749be3ec9405121a3d231631ac","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        except Exception:"},{"line_number":480,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":481,"context_line":"                try:"},{"line_number":482,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":483,"context_line":"                    self.db.share_delete(context, share[\u0027id\u0027])"},{"line_number":484,"context_line":"                finally:"},{"line_number":485,"context_line":"                    QUOTAS.rollback("}],"source_content_type":"text/x-python","patch_set":3,"id":"963e70ad_7d0546eb","line":482,"range":{"start_line":482,"start_character":20,"end_line":482,"end_character":62},"in_reply_to":"57818cda_c9321401","updated":"2024-06-14 15:44:55.000000000","message":"Done","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4da36aaed9294771501a128fdff7f974cead8499","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        except Exception:"},{"line_number":480,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":481,"context_line":"                try:"},{"line_number":482,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":483,"context_line":"                    self.db.share_delete(context, share[\u0027id\u0027])"},{"line_number":484,"context_line":"                finally:"},{"line_number":485,"context_line":"                    QUOTAS.rollback("}],"source_content_type":"text/x-python","patch_set":3,"id":"573a1ce9_5df399f7","line":482,"range":{"start_line":482,"start_character":20,"end_line":482,"end_character":62},"in_reply_to":"ddc92baf_4f0b077d","updated":"2024-06-11 19:25:06.000000000","message":"I agree with setting `share \u003d None` above and removing this","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dbf7fc33ab6172101419f96bcc48bcdd6bf9d754","unresolved":true,"context_lines":[{"line_number":864,"context_line":"        except Exception:"},{"line_number":865,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":866,"context_line":"                try:"},{"line_number":867,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":868,"context_line":"                    self.db.share_replica_delete("},{"line_number":869,"context_line":"                        context, share_replica[\u0027id\u0027],"},{"line_number":870,"context_line":"                        need_to_update_usages\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5d2b5e27_b61003a6","line":867,"range":{"start_line":867,"start_character":20,"end_line":867,"end_character":62},"updated":"2024-06-07 21:11:23.000000000","message":"same as above, now for share_replica","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4da36aaed9294771501a128fdff7f974cead8499","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        except Exception:"},{"line_number":865,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":866,"context_line":"                try:"},{"line_number":867,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":868,"context_line":"                    self.db.share_replica_delete("},{"line_number":869,"context_line":"                        context, share_replica[\u0027id\u0027],"},{"line_number":870,"context_line":"                        need_to_update_usages\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c6de29f4_3c250475","line":867,"range":{"start_line":867,"start_character":20,"end_line":867,"end_character":62},"in_reply_to":"5d2b5e27_b61003a6","updated":"2024-06-11 19:25:06.000000000","message":"+1","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dbf7fc33ab6172101419f96bcc48bcdd6bf9d754","unresolved":true,"context_lines":[{"line_number":1651,"context_line":"        except Exception:"},{"line_number":1652,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1653,"context_line":"                try:"},{"line_number":1654,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":1655,"context_line":"                    if snapshot and snapshot[\u0027instance\u0027]:"},{"line_number":1656,"context_line":"                        self.db.share_snapshot_instance_delete("},{"line_number":1657,"context_line":"                            context, snapshot[\u0027instance\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"f37282f4_11dec482","line":1654,"range":{"start_line":1654,"start_character":20,"end_line":1654,"end_character":62},"updated":"2024-06-07 21:11:23.000000000","message":"same, now for snapshot","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4da36aaed9294771501a128fdff7f974cead8499","unresolved":true,"context_lines":[{"line_number":1651,"context_line":"        except Exception:"},{"line_number":1652,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1653,"context_line":"                try:"},{"line_number":1654,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":1655,"context_line":"                    if snapshot and snapshot[\u0027instance\u0027]:"},{"line_number":1656,"context_line":"                        self.db.share_snapshot_instance_delete("},{"line_number":1657,"context_line":"                            context, snapshot[\u0027instance\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa2214e3_8028f3c1","line":1654,"range":{"start_line":1654,"start_character":20,"end_line":1654,"end_character":62},"in_reply_to":"f37282f4_11dec482","updated":"2024-06-11 19:25:06.000000000","message":"+1","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5f05d5781abb410c2e52d4b554b3171c96eb0f98","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"        except Exception:"},{"line_number":1652,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1653,"context_line":"                try:"},{"line_number":1654,"context_line":"                    # pylint: disable \u003d used-before-assignment"},{"line_number":1655,"context_line":"                    if snapshot and snapshot[\u0027instance\u0027]:"},{"line_number":1656,"context_line":"                        self.db.share_snapshot_instance_delete("},{"line_number":1657,"context_line":"                            context, snapshot[\u0027instance\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"2c85ea51_24c888be","line":1654,"range":{"start_line":1654,"start_character":20,"end_line":1654,"end_character":62},"in_reply_to":"fa2214e3_8028f3c1","updated":"2024-06-14 15:45:03.000000000","message":"Done","commit_id":"d4dea736b9f554793d953f83ab0ffb505f86d2b1"}]}