)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9e421c8eda674b4c2fc1a7b4cbeecfd50fe0ec34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b45141d_a2f0ef04","updated":"2024-03-26 12:00:22.000000000","message":"Thank you for the review... PTAL :)","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"da98e623747896515f0ba38b37ac13b10ecdcf9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f12d1e37_06faee7a","updated":"2024-03-20 21:32:24.000000000","message":"Thanks Carlos; please see some comments inline","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"44904fa0c6731d6a211701b7065a5ced89581db9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"686bc490_996c7b75","updated":"2024-03-28 16:32:29.000000000","message":"+1 on gouthamr\u0027s comment, but otherwise LGTM thanks carloss","commit_id":"a4010b9b400bb481c0147371253733b55795f1f1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d9d5d09acd65481deac9cfe74f85f1d5d5e51d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a4d1bf0_46726510","updated":"2024-03-26 20:06:18.000000000","message":"Thanks Carlos","commit_id":"a4010b9b400bb481c0147371253733b55795f1f1"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"02b1eeb31cfe44c106438fc184328bde9af7d30e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c1a2185a_933b689c","updated":"2024-03-28 18:34:02.000000000","message":"Looks great","commit_id":"dd615466ef4fd723feb19f414d96d8032c7ebe8e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9502b56ecd31c75b673089934f3d810b8e0352bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8eaecb80_e56dae9d","updated":"2024-03-29 18:38:30.000000000","message":"Thank you; LGTM","commit_id":"dd615466ef4fd723feb19f414d96d8032c7ebe8e"}],"doc/source/configuration/shared-file-systems/drivers/cephfs_driver.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"da98e623747896515f0ba38b37ac13b10ecdcf9c","unresolved":true,"context_lines":[{"line_number":315,"context_line":"option."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":".. important::"},{"line_number":318,"context_line":"  The CephFS native driver will make the share\u0027s ``cephfs_filesystem_name``"},{"line_number":319,"context_line":"  visible to users through the ``__mount_opts`` metadata. Make sure to add"},{"line_number":320,"context_line":"  the ``__mount_opts`` metadata key to the list of admin only modifiable"},{"line_number":321,"context_line":"  metadata items (``admin_only_metadata``), as documented in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e7e5dbf0_23849431","line":318,"range":{"start_line":318,"start_character":2,"end_line":318,"end_character":48},"updated":"2024-03-20 21:32:24.000000000","message":"There\u0027s really only one driver, two protocols.. \n\n\"For Native CephFS shares, the backing ``cephfs_filesystem_name`` is visible to\nend users...\" perhaps","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9e421c8eda674b4c2fc1a7b4cbeecfd50fe0ec34","unresolved":false,"context_lines":[{"line_number":315,"context_line":"option."},{"line_number":316,"context_line":""},{"line_number":317,"context_line":".. important::"},{"line_number":318,"context_line":"  The CephFS native driver will make the share\u0027s ``cephfs_filesystem_name``"},{"line_number":319,"context_line":"  visible to users through the ``__mount_opts`` metadata. Make sure to add"},{"line_number":320,"context_line":"  the ``__mount_opts`` metadata key to the list of admin only modifiable"},{"line_number":321,"context_line":"  metadata items (``admin_only_metadata``), as documented in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"205f3f22_3ea5484f","line":318,"range":{"start_line":318,"start_character":2,"end_line":318,"end_character":48},"in_reply_to":"e7e5dbf0_23849431","updated":"2024-03-26 12:00:22.000000000","message":"Done","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"da98e623747896515f0ba38b37ac13b10ecdcf9c","unresolved":true,"context_lines":[{"line_number":317,"context_line":".. important::"},{"line_number":318,"context_line":"  The CephFS native driver will make the share\u0027s ``cephfs_filesystem_name``"},{"line_number":319,"context_line":"  visible to users through the ``__mount_opts`` metadata. Make sure to add"},{"line_number":320,"context_line":"  the ``__mount_opts`` metadata key to the list of admin only modifiable"},{"line_number":321,"context_line":"  metadata items (``admin_only_metadata``), as documented in the"},{"line_number":322,"context_line":"  :ref:`additional configuration options page \u003cmanila-common\u003e`."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f6b3721e_8aa72e1e","line":320,"range":{"start_line":320,"start_character":8,"end_line":320,"end_character":20},"updated":"2024-03-20 21:32:24.000000000","message":"__mount_options","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9e421c8eda674b4c2fc1a7b4cbeecfd50fe0ec34","unresolved":false,"context_lines":[{"line_number":317,"context_line":".. important::"},{"line_number":318,"context_line":"  The CephFS native driver will make the share\u0027s ``cephfs_filesystem_name``"},{"line_number":319,"context_line":"  visible to users through the ``__mount_opts`` metadata. Make sure to add"},{"line_number":320,"context_line":"  the ``__mount_opts`` metadata key to the list of admin only modifiable"},{"line_number":321,"context_line":"  metadata items (``admin_only_metadata``), as documented in the"},{"line_number":322,"context_line":"  :ref:`additional configuration options page \u003cmanila-common\u003e`."},{"line_number":323,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"aa26cd33_f01a8382","line":320,"range":{"start_line":320,"start_character":8,"end_line":320,"end_character":20},"in_reply_to":"f6b3721e_8aa72e1e","updated":"2024-03-26 12:00:22.000000000","message":"Done","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"da98e623747896515f0ba38b37ac13b10ecdcf9c","unresolved":true,"context_lines":[{"line_number":317,"context_line":".. important::"},{"line_number":318,"context_line":"  The CephFS native driver will make the share\u0027s ``cephfs_filesystem_name``"},{"line_number":319,"context_line":"  visible to users through the ``__mount_opts`` metadata. Make sure to add"},{"line_number":320,"context_line":"  the ``__mount_opts`` metadata key to the list of admin only modifiable"},{"line_number":321,"context_line":"  metadata items (``admin_only_metadata``), as documented in the"},{"line_number":322,"context_line":"  :ref:`additional configuration options page \u003cmanila-common\u003e`."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ef57de7f_e3e88e5b","line":321,"range":{"start_line":320,"start_character":51,"end_line":321,"end_character":16},"updated":"2024-03-20 21:32:24.000000000","message":"metadata keys modifiable only by administrators","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9e421c8eda674b4c2fc1a7b4cbeecfd50fe0ec34","unresolved":false,"context_lines":[{"line_number":317,"context_line":".. important::"},{"line_number":318,"context_line":"  The CephFS native driver will make the share\u0027s ``cephfs_filesystem_name``"},{"line_number":319,"context_line":"  visible to users through the ``__mount_opts`` metadata. Make sure to add"},{"line_number":320,"context_line":"  the ``__mount_opts`` metadata key to the list of admin only modifiable"},{"line_number":321,"context_line":"  metadata items (``admin_only_metadata``), as documented in the"},{"line_number":322,"context_line":"  :ref:`additional configuration options page \u003cmanila-common\u003e`."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"061a7d10_05e5c6d6","line":321,"range":{"start_line":320,"start_character":51,"end_line":321,"end_character":16},"in_reply_to":"ef57de7f_e3e88e5b","updated":"2024-03-26 12:00:22.000000000","message":"Done","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"da98e623747896515f0ba38b37ac13b10ecdcf9c","unresolved":true,"context_lines":[{"line_number":606,"context_line":"        -o name\u003dalice,secret\u003d\u0027AQA8+ANW/4ZWNRAAOtWJMFPEihBA1unFImJczA\u003d\u003d\u0027"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":".. note::"},{"line_number":609,"context_line":"  The cephfs filesystem name will be available in the ``__mount_options``"},{"line_number":610,"context_line":"  share\u0027s metadata."},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"Mount CephFS NFS share using NFS client"}],"source_content_type":"text/x-rst","patch_set":1,"id":"db339409_a2de57a2","line":610,"range":{"start_line":609,"start_character":0,"end_line":610,"end_character":19},"updated":"2024-03-20 21:32:24.000000000","message":"This note is relevant in both sections (ceph-fuse and kernel client)..\n\nceph-fuse uses: \"--client_fs\"\nhttps://docs.ceph.com/en/quincy/man/8/ceph-fuse/#cmdoption-ceph-fuse-client_fs\n\nkernel client has a couple of ways:\nhttps://docs.ceph.com/en/latest/cephfs/mount-using-kernel-driver/#mounting-cephfs","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9e421c8eda674b4c2fc1a7b4cbeecfd50fe0ec34","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        -o name\u003dalice,secret\u003d\u0027AQA8+ANW/4ZWNRAAOtWJMFPEihBA1unFImJczA\u003d\u003d\u0027"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":".. note::"},{"line_number":609,"context_line":"  The cephfs filesystem name will be available in the ``__mount_options``"},{"line_number":610,"context_line":"  share\u0027s metadata."},{"line_number":611,"context_line":""},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"Mount CephFS NFS share using NFS client"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6968b769_89b54be6","line":610,"range":{"start_line":609,"start_character":0,"end_line":610,"end_character":19},"in_reply_to":"db339409_a2de57a2","updated":"2024-03-26 12:00:22.000000000","message":"yep, I think I just misplaced it... I tried to put it after the instructions to the kernel client so it would fit both, but it can be misleading. I\u0027ll add it before.","commit_id":"96da9397c8e7092295a30df7903d50e9aec2d0c3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d9d5d09acd65481deac9cfe74f85f1d5d5e51d08","unresolved":true,"context_lines":[{"line_number":318,"context_line":"  For Native CephFS shares, the backing ``cephfs_filesystem_name`` is visible"},{"line_number":319,"context_line":"  to end users through the ``__mount_options`` metadata. Make sure to add"},{"line_number":320,"context_line":"  the ``__mount_options`` metadata key to the list of admin only modifiable"},{"line_number":321,"context_line":"  metadata keys modifiable only by administrators (``admin_only_metadata``),"},{"line_number":322,"context_line":"  :ref:`additional configuration options page \u003cmanila-common\u003e`."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"67356c21_f8b8a970","line":321,"range":{"start_line":321,"start_character":15,"end_line":321,"end_character":50},"updated":"2024-03-26 20:06:18.000000000","message":"not required, if you drop it, it fixes the grammar","commit_id":"a4010b9b400bb481c0147371253733b55795f1f1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5defb4ddaf4290fd675e4f0cdeeff094aad25c8f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"  For Native CephFS shares, the backing ``cephfs_filesystem_name`` is visible"},{"line_number":319,"context_line":"  to end users through the ``__mount_options`` metadata. Make sure to add"},{"line_number":320,"context_line":"  the ``__mount_options`` metadata key to the list of admin only modifiable"},{"line_number":321,"context_line":"  metadata keys modifiable only by administrators (``admin_only_metadata``),"},{"line_number":322,"context_line":"  :ref:`additional configuration options page \u003cmanila-common\u003e`."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"09b04e0d_18dfb030","line":321,"range":{"start_line":321,"start_character":15,"end_line":321,"end_character":50},"in_reply_to":"67356c21_f8b8a970","updated":"2024-03-28 17:57:31.000000000","message":"Done","commit_id":"a4010b9b400bb481c0147371253733b55795f1f1"}]}