)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2264aed6feaa6f2c4f5633a6d617fff64a722e0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"efe19609_f023f536","updated":"2024-04-02 23:10:18.000000000","message":"Thank you for working on this Skylar.. a couple of comments inline","commit_id":"8538fc68ec8a61a6af80bee8d6951152b0a089da"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e02101845d300104a437dd63a92f443591692004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0cea6b43_2858ade5","updated":"2024-04-04 18:59:43.000000000","message":"Good job; and thanks Skylar!","commit_id":"cb31307adf268059b3868f375b9aecadb8b643c5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ab84df6ab10df507554a7f2f6724b147e548fc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c7214d6c_375c8203","updated":"2024-04-29 18:59:14.000000000","message":"LGTM. defusedxml should be the default. Thank you for working on this change!","commit_id":"cb31307adf268059b3868f375b9aecadb8b643c5"}],"manila/share/drivers/huawei/huawei_nas.py":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"6a02b6fb205309e72571ce327c0a32c4af2a23ad","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Huawei Nas Driver for Huawei storage arrays.\"\"\""},{"line_number":17,"context_line":"from defusedxml import ElementTree as ET"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":5,"id":"7405fb7d_5804e130","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":15},"updated":"2024-04-02 17:22:04.000000000","message":"add to requirements.txt version 0.7.1 #PSF","commit_id":"f928571a5799174b0d95acc5fc34ada4d6b15460"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2264aed6feaa6f2c4f5633a6d617fff64a722e0b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Huawei Nas Driver for Huawei storage arrays.\"\"\""},{"line_number":17,"context_line":"from defusedxml import ElementTree as ET"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":5,"id":"2f780ecc_beeb355a","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":15},"in_reply_to":"7405fb7d_5804e130","updated":"2024-04-02 23:10:18.000000000","message":"Skylar:\n\na reminder for next time: please respond to code review comments such as this with an \"ack\", or \"done\", and when you do..  click on the \"Resolved\" check box. You\u0027ll have to then hit \"Reply\" and post your responses. Doing this allows reviewers to know that their comments were addressed.","commit_id":"f928571a5799174b0d95acc5fc34ada4d6b15460"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2264aed6feaa6f2c4f5633a6d617fff64a722e0b","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Huawei Nas Driver for Huawei storage arrays.\"\"\""},{"line_number":17,"context_line":"from defusedxml import ElementTree as ET"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from oslo_utils import importutils"}],"source_content_type":"text/x-python","patch_set":6,"id":"f703c78f_56f2e4cc","line":18,"updated":"2024-04-02 23:10:18.000000000","message":"please remove blank line.. we break up imports into three groups: https://docs.openstack.org/hacking/latest/user/hacking.html#imports\n\ndefusedxml isn\u0027t part of stdlib; so needs to go with the group below","commit_id":"8538fc68ec8a61a6af80bee8d6951152b0a089da"},{"author":{"_account_id":36757,"name":"Skylar Markegard","display_name":"skylarmarkegard","email":"skylar.markegard@ndsu.edu","username":"skylarmarkegard"},"change_message_id":"23dba87964aea64f725e60423091815494b2ab57","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Huawei Nas Driver for Huawei storage arrays.\"\"\""},{"line_number":17,"context_line":"from defusedxml import ElementTree as ET"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from oslo_utils import importutils"}],"source_content_type":"text/x-python","patch_set":6,"id":"9b00af2e_ac403b46","line":18,"in_reply_to":"f703c78f_56f2e4cc","updated":"2024-04-04 03:08:14.000000000","message":"Acknowledged","commit_id":"8538fc68ec8a61a6af80bee8d6951152b0a089da"}],"manila/share/drivers/huawei/v3/helper.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2264aed6feaa6f2c4f5633a6d617fff64a722e0b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from defusedxml import ElementTree as ET"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1732e3b0_9662ff37","line":22,"updated":"2024-04-02 23:10:18.000000000","message":"remove blank line here.. defusedxml and oslo* imports are all third party library imports","commit_id":"8538fc68ec8a61a6af80bee8d6951152b0a089da"},{"author":{"_account_id":36757,"name":"Skylar Markegard","display_name":"skylarmarkegard","email":"skylar.markegard@ndsu.edu","username":"skylarmarkegard"},"change_message_id":"23dba87964aea64f725e60423091815494b2ab57","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from defusedxml import ElementTree as ET"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fb455a47_9f492020","line":22,"in_reply_to":"1732e3b0_9662ff37","updated":"2024-04-04 03:08:14.000000000","message":"Acknowledged","commit_id":"8538fc68ec8a61a6af80bee8d6951152b0a089da"}]}
