)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"857580e0494e32946897926e47ddf7496eb7d030","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"251c93ac_8fc0656f","updated":"2024-06-04 04:53:46.000000000","message":"Looks good to me.","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"df0885f29d1283ca1bb008c6f7398abb2f696ad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb89e66c_9ba4cc66","updated":"2024-05-31 17:36:35.000000000","message":"Looks good, thank you Gireesh\nWaiting on NetApp CI output or another netapper\u0027s eye on this change :)","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0524ceec7daa70c3d423727ca7f2afa6587fee7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"023b9534_915fe130","updated":"2024-04-29 17:52:19.000000000","message":"Thanks Gireesh; I am curious if any manila tempest test needs to change to accommodate this bugfix. Is the NetApp CI still broken?","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ac72e7432623e6d7eef6deba65848a3adc7ef721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca6dd98f_b7422f9b","updated":"2024-06-04 15:31:38.000000000","message":"The NetApp CI is still failing; and its hard to know if the issues are introduced with these patches. I\u0027m hoping with Saravanan\u0027s +1, we\u0027re signalling that the issues aren\u0027t related this change. Is that the case?","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"0c4b9c592aededb96f1af754575c4c122e51476d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86206fef_2ec846c5","updated":"2024-04-05 08:45:51.000000000","message":"recheck","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"d276bd2cf8e6b160445a1ba0c42e629136a60a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cde826fc_514853f6","updated":"2024-06-05 06:38:26.000000000","message":"recheck","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"008155245ae9c5ed91b09dcfb31b2064e5433780","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"127c3ca8_9240de77","updated":"2024-06-02 18:02:32.000000000","message":"run-NetApp CI","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"f2dbb668fbe648a6ce30647ee598edf2cb187086","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb86f3bb_8d029089","updated":"2024-05-28 11:23:47.000000000","message":"run-NetApp CI","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40260d29303c34bfacd4725a7445837c7de75164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cabe7782_77510a6a","in_reply_to":"66aebe42_700e8953","updated":"2024-06-04 15:46:51.000000000","message":"Thanks Gireesh; as long as you\u0027re convinced; lets get this in.. and hopefully you\u0027re able to revive your CI soon","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"53acc8fba887e0312c04183f7933ab38cb2e3a4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66aebe42_700e8953","in_reply_to":"ca6dd98f_b7422f9b","updated":"2024-06-04 15:44:04.000000000","message":"I don\u0027t think it is due to my changes. We triggered couple of runs from master branch, our downstream repo and same tests are failing. If require, will run the tests with master branch and if same test are failing that mean it is not due to my changes","commit_id":"aa8695716afd281af32d365787b48069edb7a633"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0524ceec7daa70c3d423727ca7f2afa6587fee7a","unresolved":true,"context_lines":[{"line_number":4950,"context_line":"            pass"},{"line_number":4951,"context_line":""},{"line_number":4952,"context_line":"        # Delete the vserver peering"},{"line_number":4953,"context_line":"        try:"},{"line_number":4954,"context_line":"            if src_vserver !\u003d des_vserver:"},{"line_number":4955,"context_line":"                src_vserver_client.delete_vserver_peer(src_vserver,"},{"line_number":4956,"context_line":"                                                       des_vserver)"},{"line_number":4957,"context_line":"        except netapp_api.NaApiError:"},{"line_number":4958,"context_line":"            pass"},{"line_number":4959,"context_line":""},{"line_number":4960,"context_line":"        # Delete volume"},{"line_number":4961,"context_line":"        if not backup_type_config.safe_get(Backup.DES_VOLUME.value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1b479ee_3ddcb27c","line":4958,"range":{"start_line":4953,"start_character":8,"end_line":4958,"end_character":16},"updated":"2024-04-29 17:52:19.000000000","message":"seems like a unit test can be enhanced to test this part..","commit_id":"aa8695716afd281af32d365787b48069edb7a633"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"df0885f29d1283ca1bb008c6f7398abb2f696ad3","unresolved":true,"context_lines":[{"line_number":4950,"context_line":"            pass"},{"line_number":4951,"context_line":""},{"line_number":4952,"context_line":"        # Delete the vserver peering"},{"line_number":4953,"context_line":"        try:"},{"line_number":4954,"context_line":"            if src_vserver !\u003d des_vserver:"},{"line_number":4955,"context_line":"                src_vserver_client.delete_vserver_peer(src_vserver,"},{"line_number":4956,"context_line":"                                                       des_vserver)"},{"line_number":4957,"context_line":"        except netapp_api.NaApiError:"},{"line_number":4958,"context_line":"            pass"},{"line_number":4959,"context_line":""},{"line_number":4960,"context_line":"        # Delete volume"},{"line_number":4961,"context_line":"        if not backup_type_config.safe_get(Backup.DES_VOLUME.value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c63aff47_c1ee096b","line":4958,"range":{"start_line":4953,"start_character":8,"end_line":4958,"end_character":16},"in_reply_to":"e1b479ee_3ddcb27c","updated":"2024-05-31 17:36:35.000000000","message":"++","commit_id":"aa8695716afd281af32d365787b48069edb7a633"}]}
