)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"42136564a21a57fe98bba87abd8de803bfde03c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"46afe968_9c4983a7","updated":"2024-04-22 18:50:06.000000000","message":"I agree with Goutham let bump the time out to 30, otherwise, fix looks good.","commit_id":"46d7978443415a84243afde528167018cbbeed79"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"e7665904ed4e99d496f86f48042f13a71f0dfa23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e217c28_85b9ebf3","updated":"2024-04-22 18:57:33.000000000","message":"I agree with Goutham that this should be a configurable parameter in options.py with a default value of either 30 or 60.","commit_id":"46d7978443415a84243afde528167018cbbeed79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0939ebe1d9b6ec528d25e0208cbd8d689919cea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c6223f6_c541141f","updated":"2024-04-24 18:32:21.000000000","message":"Skylar: do you need help addressing this comment; we can work on this 1x1 and get this complete, wdyt?","commit_id":"46d7978443415a84243afde528167018cbbeed79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3f50abeebfabeae40fac3d263b802ef4e985714","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93a6fe7c_ec088b83","updated":"2024-04-24 18:50:41.000000000","message":"another option is to set it to 60 like you\u0027re doing here: https://review.opendev.org/c/openstack/manila/+/915304","commit_id":"46d7978443415a84243afde528167018cbbeed79"},{"author":{"_account_id":36757,"name":"Skylar Markegard","display_name":"skylarmarkegard","email":"skylar.markegard@ndsu.edu","username":"skylarmarkegard"},"change_message_id":"07655c998c57bab409e51f8c72f0bb2ad9bb7257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b16f4ef1_7a57fe5a","in_reply_to":"6e217c28_85b9ebf3","updated":"2024-04-30 18:11:55.000000000","message":"Acknowledged","commit_id":"46d7978443415a84243afde528167018cbbeed79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d9411255c77aa4e7949f181a42162772ac369d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b255b23d_0978777e","updated":"2024-04-30 20:59:58.000000000","message":"Skylar: there\u0027s a unit test that needs a fix","commit_id":"fd4776a80f0e1c23d9d62e65c3ae5ff66f4981f6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ff8bb69e1a16848c7b25fabb05e37ad255235ac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"103d916d_40d92909","updated":"2024-05-23 20:15:55.000000000","message":"LGTM, thank you!","commit_id":"67f95a49e1d65683b9ce5d26a86fab47c3815d50"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad5e1607e4d0a65c8e2575eafaa37d48e255f576","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5b62deb_b2c8c167","updated":"2024-05-13 16:25:16.000000000","message":"Thanks for the fix Ashley!","commit_id":"67f95a49e1d65683b9ce5d26a86fab47c3815d50"}],"manila/share/drivers/nexenta/ns4/jsonrpc.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a01c654deb2db4b6620889b40aa3c932bd33c4b4","unresolved":true,"context_lines":[{"line_number":83,"context_line":"            \u0027Authorization\u0027: \u0027Basic %s\u0027 % auth,"},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"        LOG.debug(\u0027Sending JSON data: %s\u0027, data)"},{"line_number":86,"context_line":"        r \u003d requests.post(self.url, data\u003ddata, headers\u003dheaders, timeout\u003d10)"},{"line_number":87,"context_line":"        response \u003d json.loads(r.content) if r.content else None"},{"line_number":88,"context_line":"        LOG.debug(\u0027Got response: %s\u0027, response)"},{"line_number":89,"context_line":"        if response.get(\u0027error\u0027) is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a581bf8d_a7bb9dcb","line":86,"range":{"start_line":86,"start_character":72,"end_line":86,"end_character":74},"updated":"2024-04-11 22:46:11.000000000","message":"why 10? \n\nOne thing to note is that any value we choose here may cause a failure in some circumstances. I would really leave this up to configuration that administrators can tune.. but, if you want to be conservative, 30 or 60 is a more appropriate timeout","commit_id":"46d7978443415a84243afde528167018cbbeed79"},{"author":{"_account_id":36757,"name":"Skylar Markegard","display_name":"skylarmarkegard","email":"skylar.markegard@ndsu.edu","username":"skylarmarkegard"},"change_message_id":"07655c998c57bab409e51f8c72f0bb2ad9bb7257","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027Authorization\u0027: \u0027Basic %s\u0027 % auth,"},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"        LOG.debug(\u0027Sending JSON data: %s\u0027, data)"},{"line_number":86,"context_line":"        r \u003d requests.post(self.url, data\u003ddata, headers\u003dheaders, timeout\u003d10)"},{"line_number":87,"context_line":"        response \u003d json.loads(r.content) if r.content else None"},{"line_number":88,"context_line":"        LOG.debug(\u0027Got response: %s\u0027, response)"},{"line_number":89,"context_line":"        if response.get(\u0027error\u0027) is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"e4ff97e9_ad66afde","line":86,"range":{"start_line":86,"start_character":72,"end_line":86,"end_character":74},"in_reply_to":"a581bf8d_a7bb9dcb","updated":"2024-04-30 18:11:55.000000000","message":"Acknowledged","commit_id":"46d7978443415a84243afde528167018cbbeed79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d9411255c77aa4e7949f181a42162772ac369d0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027Authorization\u0027: \u0027Basic %s\u0027 % auth,"},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"        LOG.debug(\u0027Sending JSON data: %s\u0027, data)"},{"line_number":86,"context_line":"        r \u003d requests.post(self.url, data\u003ddata, headers\u003dheaders, timeout\u003d10)"},{"line_number":87,"context_line":"        response \u003d json.loads(r.content) if r.content else None"},{"line_number":88,"context_line":"        LOG.debug(\u0027Got response: %s\u0027, response)"},{"line_number":89,"context_line":"        if response.get(\u0027error\u0027) is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"29fc1d11_4c88d1aa","line":86,"range":{"start_line":86,"start_character":72,"end_line":86,"end_character":74},"in_reply_to":"e4ff97e9_ad66afde","updated":"2024-04-30 20:59:58.000000000","message":"Skylar pointed out to me that there\u0027s a retry added to this method for durability.. so the timeout here can be hard coded at 60 since \n\n\nthere\u0027s nothing configurable in this module as yet; it\u0027s probably not worth introducing a new configuration option when no one might really need it.","commit_id":"46d7978443415a84243afde528167018cbbeed79"}],"manila/tests/share/drivers/nexenta/ns4/test_nexenta_nas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d9411255c77aa4e7949f181a42162772ac369d0","unresolved":true,"context_lines":[{"line_number":389,"context_line":"        post.assert_called_with("},{"line_number":390,"context_line":"            self.request_params.url, data\u003dself.request_params.build_post_args("},{"line_number":391,"context_line":"                \u0027folder\u0027, \u0027create_snapshot\u0027, folder, snapshot[\u0027name\u0027], \u0027-r\u0027),"},{"line_number":392,"context_line":"            headers\u003dself.request_params.headers, timeout\u003d10)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    @mock.patch(PATH_TO_RPC)"},{"line_number":395,"context_line":"    def test_delete_snapshot(self, post):"}],"source_content_type":"text/x-python","patch_set":4,"id":"92b64774_4d2dc200","line":392,"range":{"start_line":392,"start_character":57,"end_line":392,"end_character":59},"updated":"2024-04-30 20:59:58.000000000","message":"60","commit_id":"fd4776a80f0e1c23d9d62e65c3ae5ff66f4981f6"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"8f161971af43bf372d564e5ada957c3e18b0f3cc","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        post.assert_called_with("},{"line_number":390,"context_line":"            self.request_params.url, data\u003dself.request_params.build_post_args("},{"line_number":391,"context_line":"                \u0027folder\u0027, \u0027create_snapshot\u0027, folder, snapshot[\u0027name\u0027], \u0027-r\u0027),"},{"line_number":392,"context_line":"            headers\u003dself.request_params.headers, timeout\u003d10)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    @mock.patch(PATH_TO_RPC)"},{"line_number":395,"context_line":"    def test_delete_snapshot(self, post):"}],"source_content_type":"text/x-python","patch_set":4,"id":"396df9c8_32d762e9","line":392,"range":{"start_line":392,"start_character":57,"end_line":392,"end_character":59},"in_reply_to":"92b64774_4d2dc200","updated":"2024-05-13 15:45:40.000000000","message":"Done","commit_id":"fd4776a80f0e1c23d9d62e65c3ae5ff66f4981f6"}]}