)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5261c36325b92ea52d2bc76606a751cad06e7e76","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ashley Rodriguez \u003cashrod98@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-14 19:57:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces eval with getattr in Dell EMC eNAS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bandit yells at evals, Bandit suggests using"},{"line_number":10,"context_line":"literal_eval which does not work here."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"11167d80_173cada2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"updated":"2024-05-14 20:31:31.000000000","message":"This and the second paragraph below need to be updated","commit_id":"28ccf336661753cf6e3c09c070d8df00d8d3dc80"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"68c9e9170883e77837c78e60e5153107eaa0c5c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ashley Rodriguez \u003cashrod98@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-14 19:57:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces eval with getattr in Dell EMC eNAS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bandit yells at evals, Bandit suggests using"},{"line_number":10,"context_line":"literal_eval which does not work here."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"cb12e0d6_360165cd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"in_reply_to":"11167d80_173cada2","updated":"2024-05-15 19:10:26.000000000","message":"Done","commit_id":"28ccf336661753cf6e3c09c070d8df00d8d3dc80"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5261c36325b92ea52d2bc76606a751cad06e7e76","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Instead of using eval to parse the attributes,"},{"line_number":13,"context_line":"uses getattr method instead, but tests fail."},{"line_number":14,"context_line":"Applying nosec and reported bug 2065727"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib5404d9e165be5879f5351c3f0952648ae702b2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"27c4481f_823937c4","line":15,"updated":"2024-05-14 20:31:31.000000000","message":"Do we have a related-bug?","commit_id":"28ccf336661753cf6e3c09c070d8df00d8d3dc80"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"68c9e9170883e77837c78e60e5153107eaa0c5c7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Instead of using eval to parse the attributes,"},{"line_number":13,"context_line":"uses getattr method instead, but tests fail."},{"line_number":14,"context_line":"Applying nosec and reported bug 2065727"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib5404d9e165be5879f5351c3f0952648ae702b2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"f2ee35a5_40982f87","line":15,"in_reply_to":"27c4481f_823937c4","updated":"2024-05-15 19:10:26.000000000","message":"Done","commit_id":"28ccf336661753cf6e3c09c070d8df00d8d3dc80"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46a0867200154a3707508fa9e96d078132f62544","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5965dd14_ca08789e","updated":"2024-04-09 20:20:23.000000000","message":"Thanks Skylar, ptal at the comment inline","commit_id":"2958da531a1ee3c79722f468950947b2bb09c226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"183ebfb2f9c6dac2661651c3d01e018fcc1c3620","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c6ab746d_6c377fe9","updated":"2024-04-11 22:38:53.000000000","message":"Skyler, you can run \"tox -epy3\" locally/on your devstack machine and work through these test failures that you\u0027re seeing on the CI","commit_id":"40efba25652ae49e27bab9e448b93c9ff720bd38"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5261c36325b92ea52d2bc76606a751cad06e7e76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"46159769_c5dcc195","updated":"2024-05-14 20:31:31.000000000","message":"Thanks Ashley; having gone down the rabbit hole here with you and Skylar.. we should probably leave it up to the Dell EMC engineers to fix this issue since it affects multiple drivers they maintain. Do you have a bug reference?","commit_id":"28ccf336661753cf6e3c09c070d8df00d8d3dc80"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bc3496fae478d62e57c30ec988226ac421d95ca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"17c0f4cc_4b1f13ff","updated":"2024-05-23 20:16:12.000000000","message":"LGTM, thank you!","commit_id":"d9dd70c4f41101f5b1228ca7d9c3750ab5e2bb8a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4c4e0871d0cb7f978526768434d29428c35db20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"13cdde4b_c63a5bf6","updated":"2024-05-22 18:50:01.000000000","message":"Thanks Ashley and Skylar!","commit_id":"d9dd70c4f41101f5b1228ca7d9c3750ab5e2bb8a"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0c9bcf14ec2c6c9bf0a8b6e87998ab89c2ae8040","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a7443410_1ef886e8","updated":"2024-05-15 21:08:06.000000000","message":"recheck","commit_id":"d9dd70c4f41101f5b1228ca7d9c3750ab5e2bb8a"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"7c9e1ec8a5b7d6737ccda6e34b0e38c8b6d08449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7cafa543_74ed747d","updated":"2024-05-22 18:18:43.000000000","message":"recheck grenade job fix merged","commit_id":"d9dd70c4f41101f5b1228ca7d9c3750ab5e2bb8a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c6c1488f76a5053220cf973f8086b2c3f261c7df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6793eeb0_676a2c42","in_reply_to":"a7443410_1ef886e8","updated":"2024-05-15 21:49:46.000000000","message":"We need https://review.opendev.org/c/openstack/manila/+/919769 - gate\u0027s currently hosed","commit_id":"d9dd70c4f41101f5b1228ca7d9c3750ab5e2bb8a"}],"manila/share/drivers/dell_emc/common/enas/xml_api_parser.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46a0867200154a3707508fa9e96d078132f62544","unresolved":true,"context_lines":[{"line_number":64,"context_line":"            func \u003d self._get_func(action, self.tag)"},{"line_number":65,"context_line":"            if func in vars(XMLAPIParser):"},{"line_number":66,"context_line":"                if action \u003d\u003d \u0027start\u0027:"},{"line_number":67,"context_line":"                    eval(\u0027self.\u0027 + func)(elem, result)  # nosec"},{"line_number":68,"context_line":"                elif action \u003d\u003d \u0027end\u0027:"},{"line_number":69,"context_line":"                    eval(\u0027self.\u0027 + func)()  # nosec"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3e049a23_1f784df5","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":54},"updated":"2024-04-09 20:20:23.000000000","message":"I think this can be replaced with attr lookup instead\n\n```\nfunc \u003d getattr(self, self._get_func(action, self.tag))\nif func in vars(XMLAPIParser):\n    if action \u003d\u003d \u0027start\u0027:\n        func(elem, result)\n    else:\n        func()\n```","commit_id":"2958da531a1ee3c79722f468950947b2bb09c226"},{"author":{"_account_id":36757,"name":"Skylar Markegard","display_name":"skylarmarkegard","email":"skylar.markegard@ndsu.edu","username":"skylarmarkegard"},"change_message_id":"ddb76b3e1c6cc552c49d5965b15803c8e5387a29","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            func \u003d self._get_func(action, self.tag)"},{"line_number":65,"context_line":"            if func in vars(XMLAPIParser):"},{"line_number":66,"context_line":"                if action \u003d\u003d \u0027start\u0027:"},{"line_number":67,"context_line":"                    eval(\u0027self.\u0027 + func)(elem, result)  # nosec"},{"line_number":68,"context_line":"                elif action \u003d\u003d \u0027end\u0027:"},{"line_number":69,"context_line":"                    eval(\u0027self.\u0027 + func)()  # nosec"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8473efcd_d506f97e","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":54},"in_reply_to":"3e049a23_1f784df5","updated":"2024-04-11 20:02:41.000000000","message":"Acknowledged, thank you for the suggestion","commit_id":"2958da531a1ee3c79722f468950947b2bb09c226"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"183ebfb2f9c6dac2661651c3d01e018fcc1c3620","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        for action, elem in context:"},{"line_number":62,"context_line":"            self.tag \u003d self._remove_ns(elem.tag)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"            func \u003d getattr(self._get_func(action, self.tag))"},{"line_number":65,"context_line":"            if func in vars(XMLAPIParser):"},{"line_number":66,"context_line":"                if action \u003d\u003d \u0027start\u0027:"},{"line_number":67,"context_line":"                    func(elem, result)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9b7c2db8_f4733918","line":64,"range":{"start_line":64,"start_character":27,"end_line":64,"end_character":59},"updated":"2024-04-11 22:38:53.000000000","message":"`getattr(self, self._get_func(action, self.tag))`","commit_id":"40efba25652ae49e27bab9e448b93c9ff720bd38"},{"author":{"_account_id":36757,"name":"Skylar Markegard","display_name":"skylarmarkegard","email":"skylar.markegard@ndsu.edu","username":"skylarmarkegard"},"change_message_id":"044580208229d152de176bf927adad86c8c1f655","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        for action, elem in context:"},{"line_number":62,"context_line":"            self.tag \u003d self._remove_ns(elem.tag)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"            func \u003d getattr(self._get_func(action, self.tag))"},{"line_number":65,"context_line":"            if func in vars(XMLAPIParser):"},{"line_number":66,"context_line":"                if action \u003d\u003d \u0027start\u0027:"},{"line_number":67,"context_line":"                    func(elem, result)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ae28863_83098e6a","line":64,"range":{"start_line":64,"start_character":27,"end_line":64,"end_character":59},"in_reply_to":"9b7c2db8_f4733918","updated":"2024-04-15 22:18:11.000000000","message":"Acknowledged","commit_id":"40efba25652ae49e27bab9e448b93c9ff720bd38"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5261c36325b92ea52d2bc76606a751cad06e7e76","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                if action \u003d\u003d \u0027start\u0027:"},{"line_number":67,"context_line":"                    eval(\u0027self.\u0027 + func)(elem, result) # nosec B307"},{"line_number":68,"context_line":"                elif action \u003d\u003d \u0027end\u0027:"},{"line_number":69,"context_line":"                    eval(\u0027self.\u0027 + func)() #B307"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        return result"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"08ec01c8_017a5d19","line":69,"range":{"start_line":69,"start_character":43,"end_line":69,"end_character":48},"updated":"2024-05-14 20:31:31.000000000","message":"```\n # nosec B307\n```","commit_id":"28ccf336661753cf6e3c09c070d8df00d8d3dc80"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"68c9e9170883e77837c78e60e5153107eaa0c5c7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                if action \u003d\u003d \u0027start\u0027:"},{"line_number":67,"context_line":"                    eval(\u0027self.\u0027 + func)(elem, result) # nosec B307"},{"line_number":68,"context_line":"                elif action \u003d\u003d \u0027end\u0027:"},{"line_number":69,"context_line":"                    eval(\u0027self.\u0027 + func)() #B307"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        return result"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"a03e0941_aaf2748c","line":69,"range":{"start_line":69,"start_character":43,"end_line":69,"end_character":48},"in_reply_to":"08ec01c8_017a5d19","updated":"2024-05-15 19:10:26.000000000","message":"Done","commit_id":"28ccf336661753cf6e3c09c070d8df00d8d3dc80"}]}