)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8d6bebf7be20d55306df886308e7c69b5adcd08","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Adds nosec comment to HPE 3PAR driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To appease Bandit since SHA1 angers"},{"line_number":10,"context_line":"the beast and usedforsecurity\u003dFalse"},{"line_number":11,"context_line":"makes tests yell and makes me think"},{"line_number":12,"context_line":"it breaks something, we\u0027ll add a nosec"},{"line_number":13,"context_line":"comment. Why not make it more secure?"},{"line_number":14,"context_line":"Well it\u0027s part of a function to find"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d65dd28f_842b8a1a","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":17},"updated":"2024-04-09 20:37:31.000000000","message":"What tests failed when you tried \"usedforsecurity\u003dFalse\"?\n\nI ask because the sha1 lib usage here is to log something at a debug level.. sounds like a perfect case where we aren\u0027t using sha1 for any security purposes","commit_id":"91427c9b0f1ffbc659e874d2b1b248af92ac4cdd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6274d6676a3284078a051655bf3914187c65a29","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adds nosec comment to HPE 3PAR driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To appease Bandit since SHA1 angers"},{"line_number":10,"context_line":"the beast and usedforsecurity\u003dFalse"},{"line_number":11,"context_line":"makes tests yell and makes me think"},{"line_number":12,"context_line":"it breaks something, we\u0027ll add a nosec"},{"line_number":13,"context_line":"comment. Why not make it more secure?"},{"line_number":14,"context_line":"Well it\u0027s part of a function to find"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf88caf7_caea1bfa","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":17},"in_reply_to":"584a9277_43713304","updated":"2024-04-11 22:42:25.000000000","message":"Perfect; thanks.. \n\nyeah; these CI jobs sometimes can fail due to unrelated reasons... HPE3par being a third party driver, the only thing we test on the gate is the unit tests associated with this driver; and it looks like there were no tests going through that code path. I\u0027m okay with +2ing this","commit_id":"91427c9b0f1ffbc659e874d2b1b248af92ac4cdd"},{"author":{"_account_id":36757,"name":"Skylar Markegard","display_name":"skylarmarkegard","email":"skylar.markegard@ndsu.edu","username":"skylarmarkegard"},"change_message_id":"29e991bd21ac688d2d0862abba62b9c99f269d95","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Adds nosec comment to HPE 3PAR driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To appease Bandit since SHA1 angers"},{"line_number":10,"context_line":"the beast and usedforsecurity\u003dFalse"},{"line_number":11,"context_line":"makes tests yell and makes me think"},{"line_number":12,"context_line":"it breaks something, we\u0027ll add a nosec"},{"line_number":13,"context_line":"comment. Why not make it more secure?"},{"line_number":14,"context_line":"Well it\u0027s part of a function to find"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"584a9277_43713304","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":17},"in_reply_to":"d65dd28f_842b8a1a","updated":"2024-04-11 20:40:53.000000000","message":"It was the manila-tempest-plugin-lvm tests, I went through the log of it and saw a failure to establish a connection and I thought it might have been connected to the modified method, but I saw for the ZFSSA drivers rechecking solved its LVM errors, so I\u0027ll try reverting back to the last patch and seeing if the error goes away with a new test.","commit_id":"91427c9b0f1ffbc659e874d2b1b248af92ac4cdd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"fb2cb31d7c83243a76ff77fe8f4324430ff4808c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f1e9ea7_cc95c758","updated":"2024-04-22 18:48:08.000000000","message":"LGTM","commit_id":"e47c6c26112324cbac2dec052122870095c993c9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"61e4e277112e3088931b5b160eb60c7b096dbce6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"75ce842c_7ede675c","updated":"2024-04-29 19:17:03.000000000","message":"LGTM, thank you!","commit_id":"e47c6c26112324cbac2dec052122870095c993c9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6274d6676a3284078a051655bf3914187c65a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"459287c8_6fe9daa2","updated":"2024-04-11 22:42:25.000000000","message":"Thanks Skylar","commit_id":"e47c6c26112324cbac2dec052122870095c993c9"}]}