)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"247ccadfe6c2d67a4cecb2e407b1a6d2b124c032","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The patchset adds unit test and documentation for fixing"},{"line_number":10,"context_line":"broken pagination links with incorrect endpoint names."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #2058427"},{"line_number":13,"context_line":"Change-Id: I4e7fdba2ae661b9251771ff0daf7842d2e86eac9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"67cd3fe3_d19d5f38","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":6},"updated":"2024-04-12 18:55:19.000000000","message":"\"Partial-Bug\" not \"Closes-Bug\" because the bugfix is in a different patch..","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"f9f13ea4f604fc51b581d4bfc4b03bf5ff280394","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The patchset adds unit test and documentation for fixing"},{"line_number":10,"context_line":"broken pagination links with incorrect endpoint names."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #2058427"},{"line_number":13,"context_line":"Change-Id: I4e7fdba2ae661b9251771ff0daf7842d2e86eac9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f928d868_87341a45","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":6},"in_reply_to":"67cd3fe3_d19d5f38","updated":"2024-04-14 13:00:29.000000000","message":"REsolved","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"247ccadfe6c2d67a4cecb2e407b1a6d2b124c032","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bd8e047c_cb288f97","updated":"2024-04-12 18:55:19.000000000","message":"Thank you for working on this Christian! Please see the comments inline","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"f9f13ea4f604fc51b581d4bfc4b03bf5ff280394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"abc311e3_3761bc30","updated":"2024-04-14 13:00:29.000000000","message":"Resolved","commit_id":"6f1da387b86f6d54464956eefd4b75a36c79999c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"551146b7e12ae6cfa83b8916f7e2804d3fa46bb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"84923f79_6fa86fb5","updated":"2024-04-15 21:44:41.000000000","message":"Christian, thanks - see comment inline","commit_id":"82be430a7aa94641a8ce6ca4ed6b000133f4dcf3"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"a5b5dd37b2014047b4f5a2839579d5cfc6a78adb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b1a29501_2e02d734","updated":"2024-04-23 10:21:02.000000000","message":"Resolved","commit_id":"12e60ab6504d8077d5ee0d13ca3ef3ec72f98c03"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"7f8dae411df34eba7b76eeea1fdca5651b359d06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bfbbffd1_ce357ff5","updated":"2024-04-23 10:22:05.000000000","message":"Resolved","commit_id":"12e60ab6504d8077d5ee0d13ca3ef3ec72f98c03"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"cda545ddbd6d82c5e3cb468dcd28dffeb9d6a295","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e2bce1d7_4fa566ea","updated":"2024-12-17 17:09:29.000000000","message":"recheck old logs","commit_id":"5e14becb13a198de675286d29dfb060f74342752"}],"manila/tests/api/fakes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"247ccadfe6c2d67a4cecb2e407b1a6d2b124c032","unresolved":true,"context_lines":[{"line_number":299,"context_line":"class FakeResourceViewBuilder(api_common.ViewBuilder):"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    _collection_name \u003d \u0027fake_resource\u0027"},{"line_number":302,"context_line":"    _collection_route_name \u003d \u0027fake-route-name\u0027"},{"line_number":303,"context_line":"    _detail_version_modifiers \u003d ["},{"line_number":304,"context_line":"        \"add_field_xyzzy\","},{"line_number":305,"context_line":"        \"add_field_spoon_for_admins\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9b68142f_767fae19","line":302,"range":{"start_line":302,"start_character":4,"end_line":302,"end_character":26},"updated":"2024-04-12 18:55:19.000000000","message":"you\u0027d have to add a test or two to ensure this is having some effect..\ncan you add a test in the test class you are proposing in https://review.opendev.org/c/openstack/manila/+/915340/3/manila/tests/api/views/test_share_replicas.py that invokes the `_get_links()` method of the view builder class and checks the o/p?","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"f9f13ea4f604fc51b581d4bfc4b03bf5ff280394","unresolved":false,"context_lines":[{"line_number":299,"context_line":"class FakeResourceViewBuilder(api_common.ViewBuilder):"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    _collection_name \u003d \u0027fake_resource\u0027"},{"line_number":302,"context_line":"    _collection_route_name \u003d \u0027fake-route-name\u0027"},{"line_number":303,"context_line":"    _detail_version_modifiers \u003d ["},{"line_number":304,"context_line":"        \"add_field_xyzzy\","},{"line_number":305,"context_line":"        \"add_field_spoon_for_admins\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5f405b1d_d8ed2fdb","line":302,"range":{"start_line":302,"start_character":4,"end_line":302,"end_character":26},"in_reply_to":"9b68142f_767fae19","updated":"2024-04-14 13:00:29.000000000","message":"Resolved","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"}],"manila/tests/api/views/test_share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"247ccadfe6c2d67a4cecb2e407b1a6d2b124c032","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0635ec1_e9ba9bdb","updated":"2024-04-12 18:55:19.000000000","message":"This content probably belongs in this existing test module: \n\nmanila/tests/api/test_common.py\n\ni\u0027d just copy-paste this test class there","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"fdefce4fba0dc180e04ff411934d4966b208e130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"098df7a8_19bf8020","in_reply_to":"e0635ec1_e9ba9bdb","updated":"2024-04-14 13:01:10.000000000","message":"Resolved","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"247ccadfe6c2d67a4cecb2e407b1a6d2b124c032","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Mirantis, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3b17fb5_4f841510","line":1,"updated":"2024-04-12 18:55:19.000000000","message":"You can drop this copyright line; Mirantis didn\u0027t add this code file","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"fdefce4fba0dc180e04ff411934d4966b208e130","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Mirantis, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"e16d9d5c_1c720270","line":1,"in_reply_to":"f3b17fb5_4f841510","updated":"2024-04-14 13:01:10.000000000","message":"Resolved","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"247ccadfe6c2d67a4cecb2e407b1a6d2b124c032","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(ViewBuilderTestCase, self).setUp()"},{"line_number":26,"context_line":"        self.builder \u003d share_replicas.ReplicationViewBuilder()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test__collection_name(self):"},{"line_number":29,"context_line":"        self.assertEqual(\u0027share_replicas\u0027, self.builder._collection_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c769a507_92532950","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":62},"updated":"2024-04-12 18:55:19.000000000","message":"you\u0027re adding the new property (\"_collection_route_name\") to the FakeViewBuilder class, why not use that?","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"f9f13ea4f604fc51b581d4bfc4b03bf5ff280394","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(ViewBuilderTestCase, self).setUp()"},{"line_number":26,"context_line":"        self.builder \u003d share_replicas.ReplicationViewBuilder()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test__collection_name(self):"},{"line_number":29,"context_line":"        self.assertEqual(\u0027share_replicas\u0027, self.builder._collection_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f082f3e5_d4fb408e","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":62},"in_reply_to":"c769a507_92532950","updated":"2024-04-14 13:00:29.000000000","message":"Resolved","commit_id":"e154f9735fe8242faf7871bf5fa3d47fd1d01bf1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"551146b7e12ae6cfa83b8916f7e2804d3fa46bb9","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    def test__collection_route_name(self):"},{"line_number":33,"context_line":"        self.assertEqual(\u0027share-replicas\u0027, self.builder._collection_route_name)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch(\u0027manila.api.views.share_replicas\u0027"},{"line_number":36,"context_line":"                \u0027.ReplicationViewBuilder._get_href_link\u0027)"},{"line_number":37,"context_line":"    @mock.patch(\u0027manila.api.views.share_replicas\u0027"},{"line_number":38,"context_line":"                \u0027.ReplicationViewBuilder._get_bookmark_link\u0027)"},{"line_number":39,"context_line":"    def test__get_links(self, mock_get_href_link, mock_get_bookmark_link):"},{"line_number":40,"context_line":"        mock_get_href_link.return_value \u003d \u0027fake_href\u0027"},{"line_number":41,"context_line":"        mock_get_bookmark_link.return_value \u003d \u0027fake_bookmark\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"01c9ec0b_ad557241","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":61},"updated":"2024-04-15 21:44:41.000000000","message":"don\u0027t mock these; these are the methods you should be testing.\n\nIn this code path, it\u0027s okay to mock:\n\n- _update_link_prefix\n- _get_project_id\n- remove_version_from_href\n\nhttps://github.com/openstack/manila/blob/4dc5f6b73015f0540a470a11c321f7ef05ec11c4/manila/api/common.py#L319-L367\n\nThe goal of the test should be to ensure that, when you have a -\n\"_collection_route_name\" set, the link generated should have that instead of \"_collection_name\"","commit_id":"82be430a7aa94641a8ce6ca4ed6b000133f4dcf3"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"7f8dae411df34eba7b76eeea1fdca5651b359d06","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test__collection_route_name(self):"},{"line_number":33,"context_line":"        self.assertEqual(\u0027share-replicas\u0027, self.builder._collection_route_name)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch(\u0027manila.api.views.share_replicas\u0027"},{"line_number":36,"context_line":"                \u0027.ReplicationViewBuilder._get_href_link\u0027)"},{"line_number":37,"context_line":"    @mock.patch(\u0027manila.api.views.share_replicas\u0027"},{"line_number":38,"context_line":"                \u0027.ReplicationViewBuilder._get_bookmark_link\u0027)"},{"line_number":39,"context_line":"    def test__get_links(self, mock_get_href_link, mock_get_bookmark_link):"},{"line_number":40,"context_line":"        mock_get_href_link.return_value \u003d \u0027fake_href\u0027"},{"line_number":41,"context_line":"        mock_get_bookmark_link.return_value \u003d \u0027fake_bookmark\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"10f822f4_d681380a","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":61},"in_reply_to":"01c9ec0b_ad557241","updated":"2024-04-23 10:22:05.000000000","message":"Resolved","commit_id":"82be430a7aa94641a8ce6ca4ed6b000133f4dcf3"}]}