)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"7854f192bdd714ace70c0a8ded656ed1d3fa78ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a69d8bfc_04004874","updated":"2024-05-02 16:03:19.000000000","message":"Is there no changes need to make for REST (client_cmode_rest) client for this...?\nPlease test the change for rest client also to make sure it work for rest also.","commit_id":"3a958c78c05fbe900cfdaf98ef71e3be8a208350"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7de44e3637c34e081ee3faa44bab758aa93b7a76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e8e2112_67a2bd17","updated":"2024-04-29 19:03:56.000000000","message":"LGTM, thank you for working on this change.\nSaravanan, Jayaanand, Sai or Gireesh: can we have your approval here as well?","commit_id":"3a958c78c05fbe900cfdaf98ef71e3be8a208350"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb1767ac7892d0f6b5624ccf7dd282c7db8f1e08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"364bd53f_893cdb18","updated":"2024-04-23 20:13:33.000000000","message":"NetApp\u0027s CI is broken atm; but, the change looks good to me.. I\u0027ve copied a bunch of NetApp maintainers to take a look","commit_id":"3a958c78c05fbe900cfdaf98ef71e3be8a208350"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a1124bed81e9928a894eba76ade67568c183919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d3b91f4c_020d47b6","in_reply_to":"0a0fedc8_faf3af2a","updated":"2024-05-06 23:38:45.000000000","message":"Perfect; thanks for that","commit_id":"3a958c78c05fbe900cfdaf98ef71e3be8a208350"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1fff23669e0191a2dadbfe843e51de5d3ad3577c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a0fedc8_faf3af2a","in_reply_to":"1e771968_ded88f10","updated":"2024-05-03 09:11:31.000000000","message":"hi Goutham,\nI think you are right here, \"ldap-client-config\" is not available for REST.\n\nI usually refer below docs for ZAPI to REST mapping\nhttps://docs.netapp.com/p/ontap/api/9.11.1/Ontapi-To-Rest-Api-Mapping-Information.pdf \n\nand docs say \nldap-client-config and ldap-config are merged into a single endpoint in the\nREST API. Each SVM can have only one LDAP client config. This field is not\nrequired in the REST API.","commit_id":"3a958c78c05fbe900cfdaf98ef71e3be8a208350"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"186f34da93a83fbad120ea656cfdfc3d7a443cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e771968_ded88f10","in_reply_to":"a69d8bfc_04004874","updated":"2024-05-02 20:44:09.000000000","message":"Hey Gireesh, \n\nThe rest client doesn\u0027t seem to use hashlib.md5: \n\nhttps://codesearch.opendev.org/?q\u003dhashlib.md5\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003dnetapp\u0026excludeFiles\u003d\u0026repos\u003dopenstack/manila\n\nThe reasoning for this change is that md5 isn\u0027t a FIPS compliant hashing algorithm, and its use must be limited to non-security use cases.. i.e., if you\u0027re trying to hide/obscure something for security reasons, or use the hash as a way to check the integrity of something for security purposes, you must choose a hashing algorithm that\u0027s stronger than md5, perhaps sha256. \n\nI might be wrong here, but it looks like, with ONTAPI, when referring to an LDAP client\u0027s name, there\u0027s a field called \"ldap-client-config\".. this is missing in REST: https://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py#L3952-L4001\n\nI don\u0027t know why, or if that\u0027s relevant. There\u0027s an ansible-galaxy issue that wonders about this disparity too: https://github.com/ansible-collections/netapp.ontap/issues/172","commit_id":"3a958c78c05fbe900cfdaf98ef71e3be8a208350"}]}