)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cd5c36aae79e55d8df2d51911a88cd05e2bfc6e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This is a mostly complete example showing request body, request query"},{"line_number":10,"context_line":"string and response body schemas in action. The only thing not included"},{"line_number":11,"context_line":"yet is descriptions for fields, which is still being worked on."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I14db582eec6db25ea5437675f8207dcf94228b25"},{"line_number":14,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a384f9d4_d6a62ec1","line":12,"updated":"2024-05-10 19:57:22.000000000","message":"Partially-implements: bp json-schema-validation","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40a95daf28d82b43527709779ed880b29ff033c0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is a mostly complete example showing request body, request query"},{"line_number":10,"context_line":"string and response body schemas in action. The only thing not included"},{"line_number":11,"context_line":"yet is descriptions for fields, which is still being worked on."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I14db582eec6db25ea5437675f8207dcf94228b25"},{"line_number":14,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"12341332_e4423141","line":12,"in_reply_to":"a384f9d4_d6a62ec1","updated":"2024-05-13 15:23:37.000000000","message":"Done","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6657c629edccc7f83dd3fde197841773ab6e5412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10479c98_c6fed2cf","updated":"2024-05-01 12:55:27.000000000","message":"Another failure. Well at least we know that our test strategy works 😂","commit_id":"fe533670132ca9c9ce882a5fbac7517784eb4a33"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ad6587ebd4374d9615fc7ec16206e5592905232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74517bef_02377284","in_reply_to":"10479c98_c6fed2cf","updated":"2024-05-01 13:17:02.000000000","message":"Actually, turned out to be a bug in the format validator for `date-time`-formatted strings included in the previous patch. This is resolved now.","commit_id":"fe533670132ca9c9ce882a5fbac7517784eb4a33"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cd5c36aae79e55d8df2d51911a88cd05e2bfc6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b44f60e6_303af138","updated":"2024-05-10 19:57:22.000000000","message":"Thanks Stephen; \n\na few comments inline","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"df19129fcddd74bbef6a5fa76218e5602be0541d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bc590fe8_877879d4","updated":"2024-05-14 20:35:07.000000000","message":"LGTM; some comments inline","commit_id":"3423cd03a9fcd68e475209ad857aac40955baa30"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3074e58f34693f40654a796953d1765514f86823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"37afbeb4_618a4a1f","updated":"2024-05-14 04:54:17.000000000","message":"recheck\n\ngate racy bug has been addressed: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/918702","commit_id":"3423cd03a9fcd68e475209ad857aac40955baa30"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1805674b5d6352df69889dec105b4bc1d772ae23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34d3cffd_37fbc64a","updated":"2024-05-16 08:50:44.000000000","message":"LGTM; thanks Stephen!","commit_id":"cf65885d44834dbec7cba31e913c1b07a1908ffa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a634f80c419907eeaf37c0b07e9ea3e96b6c8696","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"594eaf89_916f7f53","updated":"2024-05-15 15:49:17.000000000","message":"LGTM; thanks Stephen!","commit_id":"cf65885d44834dbec7cba31e913c1b07a1908ffa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cb0e89cb5056e84c89beee3dfc3ca6e484ed42b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ddd938c1_2ce0a5f4","updated":"2024-05-17 21:16:14.000000000","message":"gate bugfix merged now; this is good to go","commit_id":"cf65885d44834dbec7cba31e913c1b07a1908ffa"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"629a8db2f10c53daa64b05abd654533285bc30be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c3bea463_9b446ac4","updated":"2024-05-16 08:50:56.000000000","message":"recheck","commit_id":"cf65885d44834dbec7cba31e913c1b07a1908ffa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e49d9fa35f7efaddd5e861a4be52413af4a0ab2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1d8d0596_4ad2119b","in_reply_to":"ddd938c1_2ce0a5f4","updated":"2024-05-17 21:18:03.000000000","message":"\u003e gate bugfix merged now; this is good to go\n\nspoke too soon; it\u0027s _nearly_ there.. so to avoid wasting CI cycles, i rebased this patch on top of that change\n\nhttps://review.opendev.org/c/openstack/manila/+/919769/2?usp\u003drelated-change","commit_id":"cf65885d44834dbec7cba31e913c1b07a1908ffa"}],"manila/api/schemas/resource_locks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cd5c36aae79e55d8df2d51911a88cd05e2bfc6e","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            \u0027properties\u0027: {"},{"line_number":61,"context_line":"                \u0027resource_action\u0027: {"},{"line_number":62,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":63,"context_line":"                    \u0027const\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":64,"context_line":"                },"},{"line_number":65,"context_line":"                \u0027lock_reason\u0027: {"},{"line_number":66,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"55109fa3_b08516c2","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":62},"updated":"2024-05-10 19:57:22.000000000","message":"I realize we need to update the api-ref [1]; we have a couple of actions that can be locked.. so this can be validated like the \"resource_action\" property above:\n\n```\n\u0027enum\u0027: constants.RESOURCE_LOCK_RESOURCE_ACTIONS + (None,),\n```\n\n[1] https://review.opendev.org/c/openstack/manila/+/919213","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40a95daf28d82b43527709779ed880b29ff033c0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u0027properties\u0027: {"},{"line_number":61,"context_line":"                \u0027resource_action\u0027: {"},{"line_number":62,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":63,"context_line":"                    \u0027const\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":64,"context_line":"                },"},{"line_number":65,"context_line":"                \u0027lock_reason\u0027: {"},{"line_number":66,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"709bed0b_d4e52186","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":62},"in_reply_to":"55109fa3_b08516c2","updated":"2024-05-13 15:23:37.000000000","message":"Done","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"02aaffa23f5b008a55545feb363242e4b9c7a0b2","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            \u0027properties\u0027: {"},{"line_number":61,"context_line":"                \u0027resource_action\u0027: {"},{"line_number":62,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":63,"context_line":"                    \u0027const\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":64,"context_line":"                },"},{"line_number":65,"context_line":"                \u0027lock_reason\u0027: {"},{"line_number":66,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"6cd26163_b0850332","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":62},"in_reply_to":"5f04f631_44feda30","updated":"2024-05-15 15:14:57.000000000","message":"Nope. Nope, I messed up a rebase. Will respin.","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"819eb5deabbf2763fb029a8341897bed0e1f58f5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u0027properties\u0027: {"},{"line_number":61,"context_line":"                \u0027resource_action\u0027: {"},{"line_number":62,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":63,"context_line":"                    \u0027const\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":64,"context_line":"                },"},{"line_number":65,"context_line":"                \u0027lock_reason\u0027: {"},{"line_number":66,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"11e18542_a0c45f91","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":62},"in_reply_to":"6cd26163_b0850332","updated":"2024-05-15 15:28:40.000000000","message":"Done (for real this time)","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"df19129fcddd74bbef6a5fa76218e5602be0541d","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            \u0027properties\u0027: {"},{"line_number":61,"context_line":"                \u0027resource_action\u0027: {"},{"line_number":62,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":63,"context_line":"                    \u0027const\u0027: constants.RESOURCE_ACTION_DELETE,"},{"line_number":64,"context_line":"                },"},{"line_number":65,"context_line":"                \u0027lock_reason\u0027: {"},{"line_number":66,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f04f631_44feda30","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":62},"in_reply_to":"709bed0b_d4e52186","updated":"2024-05-14 20:35:07.000000000","message":"This isn\u0027t done.. do you want this done in a follow-up patch? :)","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cd5c36aae79e55d8df2d51911a88cd05e2bfc6e","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        \u0027created_before\u0027: parameter_types.multi_params({"},{"line_number":104,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":105,"context_line":"            \u0027format\u0027: \u0027date-time\u0027,"},{"line_number":106,"context_line":"        }),"},{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"    # TODO(stephenfin): Exclude additional query string parameters in a future"},{"line_number":109,"context_line":"    # microversion"}],"source_content_type":"text/x-python","patch_set":5,"id":"64866fe7_b1982a09","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":11},"updated":"2024-05-10 19:57:22.000000000","message":"this list should also include:\n\n\n```\n     \"project_id\": {\n            \"type\": [\"string\", \"null\"],\n            \"format\": \"uuid\",\n      },\n     \"user_id\": {\n            \"type\": [\"string\", \"null\"],\n            \"format\": \"uuid\",\n      }\n      \"resource_id\": {\n            \"type\": [\"string\", \"null\"],\n            \"format\": \"uuid\",\n      }.\n      \u0027resource_action\u0027: {\n             \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],\n             \u0027enum\u0027: constants.RESOURCE_LOCK_RESOURCE_ACTIONS + (None,),\n      },\n      resource_type\u0027: {\n              \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],\n              \u0027enum\u0027: constants.RESOURCE_LOCK_RESOURCE_TYPES + (None,),\n      },\n      \"all_projects\": parameter_types.multi_params(parameter_types.boolean),\n      \"lock_context\": {\n              \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],\n              \u0027maxLength\u0027: 10,\n       },\n      \u0027lock_reason\u0027: {\n              \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],\n               \u0027maxLength\u0027: 1023,\n       },\n      \"lock_reason~\": {\n               \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],\n               \u0027maxLength\u0027: 1023,\n      },\n      \n\n```","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40a95daf28d82b43527709779ed880b29ff033c0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \u0027created_before\u0027: parameter_types.multi_params({"},{"line_number":104,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":105,"context_line":"            \u0027format\u0027: \u0027date-time\u0027,"},{"line_number":106,"context_line":"        }),"},{"line_number":107,"context_line":"    },"},{"line_number":108,"context_line":"    # TODO(stephenfin): Exclude additional query string parameters in a future"},{"line_number":109,"context_line":"    # microversion"}],"source_content_type":"text/x-python","patch_set":5,"id":"6a71a998_1e2ce734","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":11},"in_reply_to":"64866fe7_b1982a09","updated":"2024-05-13 15:23:37.000000000","message":"Oh, not sure how I missed these. Thanks 🙏","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cd5c36aae79e55d8df2d51911a88cd05e2bfc6e","unresolved":true,"context_lines":[{"line_number":180,"context_line":"            \u0027items\u0027: _resource_lock_response,"},{"line_number":181,"context_line":"        },"},{"line_number":182,"context_line":"        \u0027count\u0027: {"},{"line_number":183,"context_line":"            \u0027type\u0027: \u0027integer\u0027,"},{"line_number":184,"context_line":"        },"},{"line_number":185,"context_line":"        \u0027resource_locks_links\u0027: response_types.collection_links,"},{"line_number":186,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":5,"id":"40d15456_66ea9ac0","line":183,"range":{"start_line":183,"start_character":20,"end_line":183,"end_character":29},"updated":"2024-05-10 19:57:22.000000000","message":"probably \"non_negative_integer\" that\u0027s being added to the parameter_types?","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"df19129fcddd74bbef6a5fa76218e5602be0541d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            \u0027items\u0027: _resource_lock_response,"},{"line_number":181,"context_line":"        },"},{"line_number":182,"context_line":"        \u0027count\u0027: {"},{"line_number":183,"context_line":"            \u0027type\u0027: \u0027integer\u0027,"},{"line_number":184,"context_line":"        },"},{"line_number":185,"context_line":"        \u0027resource_locks_links\u0027: response_types.collection_links,"},{"line_number":186,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":5,"id":"c7802f3d_c3261098","line":183,"range":{"start_line":183,"start_character":20,"end_line":183,"end_character":29},"in_reply_to":"3d15bee3_416d6d2d","updated":"2024-05-14 20:35:07.000000000","message":"Ah i missed it; I will leave that up to you; I think request schema validation is more useful!","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40a95daf28d82b43527709779ed880b29ff033c0","unresolved":true,"context_lines":[{"line_number":180,"context_line":"            \u0027items\u0027: _resource_lock_response,"},{"line_number":181,"context_line":"        },"},{"line_number":182,"context_line":"        \u0027count\u0027: {"},{"line_number":183,"context_line":"            \u0027type\u0027: \u0027integer\u0027,"},{"line_number":184,"context_line":"        },"},{"line_number":185,"context_line":"        \u0027resource_locks_links\u0027: response_types.collection_links,"},{"line_number":186,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":5,"id":"3d15bee3_416d6d2d","line":183,"range":{"start_line":183,"start_character":20,"end_line":183,"end_character":29},"in_reply_to":"40d15456_66ea9ac0","updated":"2024-05-13 15:23:37.000000000","message":"Hmm, I hadn\u0027t focused on making these too strict since they\u0027re response body stuff but I can do that when I respin. We should redefine it in response_types though since this is a response field, not a request parameter/field.","commit_id":"8625721e71dfdfc46b9d4b3130a20762718a7285"}]}