)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b47c7d1abfbe567f80a3d3a3253655cdea446a4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6632e8a_ee3aa649","updated":"2024-05-06 05:05:57.000000000","message":"Thanks; its definitely a good catch; since we\u0027d be backporting this fix, could you please include a release note?","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bcad0f91465830b8b74231b87b7b2831685c2d47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"126fee71_745b2353","updated":"2024-05-06 02:08:24.000000000","message":"good catch, share manager can only delete share instances on it\u0027s own backend.","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"9b5e4555726fc612dd481c5bd40f660b2d510207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95de894c_47207247","updated":"2024-05-06 02:08:34.000000000","message":"recheck","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19af4a1672738540cb2014113150c5841e50c408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3ebe06f_2e20cd00","in_reply_to":"e6632e8a_ee3aa649","updated":"2024-05-06 10:16:09.000000000","message":"added release notes.","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ea188b8dbc38a88b01fc9de489a882215ba681b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68d07376_15416106","updated":"2024-05-06 23:38:16.000000000","message":"Thanks; please see comment on the release note if you make another patch","commit_id":"258933eca8e5c3ee1123800e44ac7951c3500849"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10f46b0a18c63f7f0d24f63dc3b46341c3f855a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f9068bcd_1bd3d32b","updated":"2024-05-07 16:26:05.000000000","message":"Thanks Kiran!","commit_id":"fab04b5751527c6a6e3bf3848c2af698088fb249"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"cf63aca58b4182be3204e03786fdcc1c628dd331","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45f2bccc_304703e6","updated":"2024-05-08 01:22:01.000000000","message":"let\u0027s merge this.","commit_id":"fab04b5751527c6a6e3bf3848c2af698088fb249"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"409d5c024eb0e8dfd9ac23c4fa33dce8c78b45bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"af7a9adb_ac76eb45","updated":"2024-05-07 11:38:44.000000000","message":"recheck","commit_id":"fab04b5751527c6a6e3bf3848c2af698088fb249"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b47c7d1abfbe567f80a3d3a3253655cdea446a4e","unresolved":true,"context_lines":[{"line_number":3647,"context_line":"            ctxt,"},{"line_number":3648,"context_line":"            filters\u003d{"},{"line_number":3649,"context_line":"                \u0027status\u0027: constants.STATUS_DEFERRED_DELETING,"},{"line_number":3650,"context_line":"                \u0027host\u0027: self.host"},{"line_number":3651,"context_line":"            })"},{"line_number":3652,"context_line":""},{"line_number":3653,"context_line":"        share_instances_error_deferred_deleting \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1af8a500_9f5ef3b2","line":3650,"range":{"start_line":3650,"start_character":32,"end_line":3650,"end_character":33},"updated":"2024-05-06 05:05:57.000000000","message":"nit: trailing comma","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19af4a1672738540cb2014113150c5841e50c408","unresolved":false,"context_lines":[{"line_number":3647,"context_line":"            ctxt,"},{"line_number":3648,"context_line":"            filters\u003d{"},{"line_number":3649,"context_line":"                \u0027status\u0027: constants.STATUS_DEFERRED_DELETING,"},{"line_number":3650,"context_line":"                \u0027host\u0027: self.host"},{"line_number":3651,"context_line":"            })"},{"line_number":3652,"context_line":""},{"line_number":3653,"context_line":"        share_instances_error_deferred_deleting \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"623a507a_59b32608","line":3650,"range":{"start_line":3650,"start_character":32,"end_line":3650,"end_character":33},"in_reply_to":"1af8a500_9f5ef3b2","updated":"2024-05-06 10:16:09.000000000","message":"Done","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b47c7d1abfbe567f80a3d3a3253655cdea446a4e","unresolved":true,"context_lines":[{"line_number":3655,"context_line":"                ctxt,"},{"line_number":3656,"context_line":"                filters\u003d{"},{"line_number":3657,"context_line":"                    \u0027status\u0027: constants.STATUS_ERROR_DEFERRED_DELETING,"},{"line_number":3658,"context_line":"                    \u0027host\u0027: self.host"},{"line_number":3659,"context_line":"                }))"},{"line_number":3660,"context_line":"        updated_del \u003d timeutils.utcnow() - datetime.timedelta(minutes\u003d30)"},{"line_number":3661,"context_line":"        for share_instance in share_instances_error_deferred_deleting:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e05d0bf_be5c2945","line":3658,"range":{"start_line":3658,"start_character":36,"end_line":3658,"end_character":37},"updated":"2024-05-06 05:05:57.000000000","message":"nit: trailing comma","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19af4a1672738540cb2014113150c5841e50c408","unresolved":false,"context_lines":[{"line_number":3655,"context_line":"                ctxt,"},{"line_number":3656,"context_line":"                filters\u003d{"},{"line_number":3657,"context_line":"                    \u0027status\u0027: constants.STATUS_ERROR_DEFERRED_DELETING,"},{"line_number":3658,"context_line":"                    \u0027host\u0027: self.host"},{"line_number":3659,"context_line":"                }))"},{"line_number":3660,"context_line":"        updated_del \u003d timeutils.utcnow() - datetime.timedelta(minutes\u003d30)"},{"line_number":3661,"context_line":"        for share_instance in share_instances_error_deferred_deleting:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b205384_e2c2fae7","line":3658,"range":{"start_line":3658,"start_character":36,"end_line":3658,"end_character":37},"in_reply_to":"7e05d0bf_be5c2945","updated":"2024-05-06 10:16:09.000000000","message":"Done","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b47c7d1abfbe567f80a3d3a3253655cdea446a4e","unresolved":true,"context_lines":[{"line_number":4067,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":4068,"context_line":"            \u0027status\u0027: \u0027deferred_deleting\u0027,"},{"line_number":4069,"context_line":"            \u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":4070,"context_line":"            \u0027host\u0027: self.host"},{"line_number":4071,"context_line":"        }"},{"line_number":4072,"context_line":"        si_1 \u003d db_utils.create_share_instance(**kwargs)"},{"line_number":4073,"context_line":"        kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f20a0ff_e32d1f3b","line":4070,"range":{"start_line":4070,"start_character":28,"end_line":4070,"end_character":29},"updated":"2024-05-06 05:05:57.000000000","message":"nit: trailing comma","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19af4a1672738540cb2014113150c5841e50c408","unresolved":false,"context_lines":[{"line_number":4067,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":4068,"context_line":"            \u0027status\u0027: \u0027deferred_deleting\u0027,"},{"line_number":4069,"context_line":"            \u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":4070,"context_line":"            \u0027host\u0027: self.host"},{"line_number":4071,"context_line":"        }"},{"line_number":4072,"context_line":"        si_1 \u003d db_utils.create_share_instance(**kwargs)"},{"line_number":4073,"context_line":"        kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"95ee30bb_056e1221","line":4070,"range":{"start_line":4070,"start_character":28,"end_line":4070,"end_character":29},"in_reply_to":"2f20a0ff_e32d1f3b","updated":"2024-05-06 10:16:09.000000000","message":"Done","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b47c7d1abfbe567f80a3d3a3253655cdea446a4e","unresolved":true,"context_lines":[{"line_number":4076,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":4077,"context_line":"            \u0027status\u0027: \u0027deferred_deleting\u0027,"},{"line_number":4078,"context_line":"            \u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":4079,"context_line":"            \u0027host\u0027: self.host"},{"line_number":4080,"context_line":"        }"},{"line_number":4081,"context_line":"        si_2 \u003d db_utils.create_share_instance(**kwargs)"},{"line_number":4082,"context_line":"        mins \u003d 20"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb204d0c_09fe5332","line":4079,"range":{"start_line":4079,"start_character":28,"end_line":4079,"end_character":29},"updated":"2024-05-06 05:05:57.000000000","message":"nit: trailing comma","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19af4a1672738540cb2014113150c5841e50c408","unresolved":false,"context_lines":[{"line_number":4076,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":4077,"context_line":"            \u0027status\u0027: \u0027deferred_deleting\u0027,"},{"line_number":4078,"context_line":"            \u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":4079,"context_line":"            \u0027host\u0027: self.host"},{"line_number":4080,"context_line":"        }"},{"line_number":4081,"context_line":"        si_2 \u003d db_utils.create_share_instance(**kwargs)"},{"line_number":4082,"context_line":"        mins \u003d 20"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce06f186_0d04e0a0","line":4079,"range":{"start_line":4079,"start_character":28,"end_line":4079,"end_character":29},"in_reply_to":"fb204d0c_09fe5332","updated":"2024-05-06 10:16:09.000000000","message":"Done","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b47c7d1abfbe567f80a3d3a3253655cdea446a4e","unresolved":true,"context_lines":[{"line_number":4089,"context_line":"            \u0027status\u0027: \u0027error_deferred_deleting\u0027,"},{"line_number":4090,"context_line":"            \u0027updated_at\u0027: ("},{"line_number":4091,"context_line":"                timeutils.utcnow() - datetime.timedelta(minutes\u003dmins)),"},{"line_number":4092,"context_line":"            \u0027host\u0027: self.host"},{"line_number":4093,"context_line":"        }"},{"line_number":4094,"context_line":"        si_3 \u003d db_utils.create_share_instance(**kwargs)"},{"line_number":4095,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3abb6662_6100c107","line":4092,"range":{"start_line":4092,"start_character":28,"end_line":4092,"end_character":29},"updated":"2024-05-06 05:05:57.000000000","message":"nit: trailing comma","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19af4a1672738540cb2014113150c5841e50c408","unresolved":false,"context_lines":[{"line_number":4089,"context_line":"            \u0027status\u0027: \u0027error_deferred_deleting\u0027,"},{"line_number":4090,"context_line":"            \u0027updated_at\u0027: ("},{"line_number":4091,"context_line":"                timeutils.utcnow() - datetime.timedelta(minutes\u003dmins)),"},{"line_number":4092,"context_line":"            \u0027host\u0027: self.host"},{"line_number":4093,"context_line":"        }"},{"line_number":4094,"context_line":"        si_3 \u003d db_utils.create_share_instance(**kwargs)"},{"line_number":4095,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2277fb40_5ba8d656","line":4092,"range":{"start_line":4092,"start_character":28,"end_line":4092,"end_character":29},"in_reply_to":"3abb6662_6100c107","updated":"2024-05-06 10:16:09.000000000","message":"Done","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b47c7d1abfbe567f80a3d3a3253655cdea446a4e","unresolved":true,"context_lines":[{"line_number":4125,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":4126,"context_line":"            \u0027status\u0027: \u0027deferred_deleting\u0027,"},{"line_number":4127,"context_line":"            \u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":4128,"context_line":"            \u0027host\u0027: self.host"},{"line_number":4129,"context_line":"        }"},{"line_number":4130,"context_line":"        si \u003d db_utils.create_share_instance(**kwargs)"},{"line_number":4131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fffe442d_2d5c5c50","line":4128,"range":{"start_line":4128,"start_character":28,"end_line":4128,"end_character":29},"updated":"2024-05-06 05:05:57.000000000","message":"nit: trailing comma","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19af4a1672738540cb2014113150c5841e50c408","unresolved":false,"context_lines":[{"line_number":4125,"context_line":"            \u0027share_server_id\u0027: share_server[\u0027id\u0027],"},{"line_number":4126,"context_line":"            \u0027status\u0027: \u0027deferred_deleting\u0027,"},{"line_number":4127,"context_line":"            \u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":4128,"context_line":"            \u0027host\u0027: self.host"},{"line_number":4129,"context_line":"        }"},{"line_number":4130,"context_line":"        si \u003d db_utils.create_share_instance(**kwargs)"},{"line_number":4131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"831e3ba4_66f5f94d","line":4128,"range":{"start_line":4128,"start_character":28,"end_line":4128,"end_character":29},"in_reply_to":"fffe442d_2d5c5c50","updated":"2024-05-06 10:16:09.000000000","message":"Done","commit_id":"66669aeac32e73c2a3dc51ec3b53ce003172748a"}],"releasenotes/notes/optimize-deferred-deletion-get-share-instance-query-b6366b7c3b0a64db.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ea188b8dbc38a88b01fc9de489a882215ba681b5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Share instance get call runs in periodic task which is part of each"},{"line_number":5,"context_line":"    manila-share service instance. Optimized this share instance get call"},{"line_number":6,"context_line":"    to consider only share instances from current host."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9efc490a_9e4fca72","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":55},"updated":"2024-05-06 23:38:16.000000000","message":"suggested rewrite:\n\n```\nThe periodic database queries made by the share manager\nservice to process deferred deletion of shares has been\nfixed to consider the host in addition to the share\u0027s\nstate. This both improves performance of the periodic\ntask, as well as fixes incorrect behavior where incorrect\nshares are retrieved by the query.\n```","commit_id":"258933eca8e5c3ee1123800e44ac7951c3500849"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"853309bd964f2be40e4d90dd07a51279c76038a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Share instance get call runs in periodic task which is part of each"},{"line_number":5,"context_line":"    manila-share service instance. Optimized this share instance get call"},{"line_number":6,"context_line":"    to consider only share instances from current host."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a8067e98_e798e9ed","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":55},"in_reply_to":"9efc490a_9e4fca72","updated":"2024-05-07 08:52:19.000000000","message":"Done","commit_id":"258933eca8e5c3ee1123800e44ac7951c3500849"}]}