)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"240183ecae48d63f576aa51df1a57723ef2a99bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63cb1539_6906287e","updated":"2024-06-27 08:23:44.000000000","message":"I commented only on the vserver_name part.\nPlease wait for feedback on the allocations from my colleague Chuan.\n\nThis change should have been two separate commits imho.","commit_id":"23db9d7d3db813215ebfd9672817994c811b86af"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bfd2a11c0d062781d2d5611a6f42dc8c68b580b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ce1594d1_99df5f0a","updated":"2024-06-26 13:57:51.000000000","message":"LGTM, thanks for the fix, Sylvan! Would be nice to have some extra netappers eyes here","commit_id":"23db9d7d3db813215ebfd9672817994c811b86af"},{"author":{"_account_id":35979,"name":"Sylvan Le Deunff","email":"sylvan.le-deunff@ovhcloud.com","username":"sylvanld"},"change_message_id":"93e31f79c7583c640d712eabd13e29e7e0f5e575","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"790ec364_944de3ff","updated":"2024-05-22 09:23:05.000000000","message":"recheck SSH connection to host timed out","commit_id":"23db9d7d3db813215ebfd9672817994c811b86af"},{"author":{"_account_id":35979,"name":"Sylvan Le Deunff","email":"sylvan.le-deunff@ovhcloud.com","username":"sylvanld"},"change_message_id":"ffdd64bfb309316ef31ab50747a135e602793b66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d4bcdcee_7f952220","updated":"2024-07-31 09:47:18.000000000","message":"I applied suggested changes :)","commit_id":"bc25b4b28d027e1caa03daf4f5f6fc8c60dd3045"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"998ef09a122d55e9bb17ca27ff54179eb2d90411","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"93b47092_489fb0b5","updated":"2024-08-29 14:45:43.000000000","message":"Fine with me","commit_id":"90ac0078d0416ccec0fff77735f270db1b87b872"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cc7374a25994ee2f568b231aea681f0e4475bc7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b89ab207_93e86a28","updated":"2024-08-29 13:21:00.000000000","message":"LGTM, thanks for working on the changes. @chuan137@gmail.com @maurice.escher@sap.com - could you please take another look?","commit_id":"90ac0078d0416ccec0fff77735f270db1b87b872"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f13bdc91b732c7a9d221f29ad0bf34685fdf0a93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9435f653_7919df1f","updated":"2024-10-30 16:18:07.000000000","message":"LGTM, thanks for the rebase","commit_id":"5d574edbbe20f2102d2e7aa08580ef53aef0cd28"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08955e060ccb56d0c4964e2dff7176c47e1c588e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6d542849_122ebd3b","updated":"2024-11-01 00:02:51.000000000","message":"LGTM; thank you Sylvan!","commit_id":"5d574edbbe20f2102d2e7aa08580ef53aef0cd28"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"343e8387888d23b10a82a5f7265d98f9b25bfb3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bcb2bb20_8ab3f7e2","updated":"2024-10-10 08:40:09.000000000","message":"Looks good to me.","commit_id":"5d574edbbe20f2102d2e7aa08580ef53aef0cd28"},{"author":{"_account_id":35979,"name":"Sylvan Le Deunff","email":"sylvan.le-deunff@ovhcloud.com","username":"sylvanld"},"change_message_id":"9d4fe4115cd54044452173d4750c75606151f82f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"afc1bb06_a732b9a4","updated":"2024-11-14 09:28:43.000000000","message":"recheck InvocationError in tempest tests","commit_id":"5d574edbbe20f2102d2e7aa08580ef53aef0cd28"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"240183ecae48d63f576aa51df1a57723ef2a99bc","unresolved":true,"context_lines":[{"line_number":1284,"context_line":"        if (dest_client.is_svm_migrate_supported()"},{"line_number":1285,"context_line":"                and src_client.is_svm_migrate_supported()):"},{"line_number":1286,"context_line":"            source_share_server_name \u003d self._get_vserver_name("},{"line_number":1287,"context_line":"                source_share_server[\u0027identifier\u0027])"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"            # Check if the migration is supported."},{"line_number":1290,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec293cbd_e5be3de9","side":"PARENT","line":1287,"range":{"start_line":1287,"start_character":16,"end_line":1287,"end_character":49},"updated":"2024-06-27 08:23:44.000000000","message":"I wonder wether we should fix the identifier to hold the correct value instead of looking at another field.\n\nI think setup_server() in lib_multi_svm.py here should return the `identifier` key and then _setup_server() from share/manager.py would update that accordingly.","commit_id":"842fda18e50b9099dbba8a3624b1f940c8329578"},{"author":{"_account_id":35979,"name":"Sylvan Le Deunff","email":"sylvan.le-deunff@ovhcloud.com","username":"sylvanld"},"change_message_id":"ffdd64bfb309316ef31ab50747a135e602793b66","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"        if (dest_client.is_svm_migrate_supported()"},{"line_number":1285,"context_line":"                and src_client.is_svm_migrate_supported()):"},{"line_number":1286,"context_line":"            source_share_server_name \u003d self._get_vserver_name("},{"line_number":1287,"context_line":"                source_share_server[\u0027identifier\u0027])"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"            # Check if the migration is supported."},{"line_number":1290,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"09f305db_52dc95c1","side":"PARENT","line":1287,"range":{"start_line":1287,"start_character":16,"end_line":1287,"end_character":49},"in_reply_to":"18401a1c_ac96a7bf","updated":"2024-07-31 09:47:18.000000000","message":"Done","commit_id":"842fda18e50b9099dbba8a3624b1f940c8329578"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"3e4511aaee2d8085a11a585734857b88fc0bd8c3","unresolved":true,"context_lines":[{"line_number":1284,"context_line":"        if (dest_client.is_svm_migrate_supported()"},{"line_number":1285,"context_line":"                and src_client.is_svm_migrate_supported()):"},{"line_number":1286,"context_line":"            source_share_server_name \u003d self._get_vserver_name("},{"line_number":1287,"context_line":"                source_share_server[\u0027identifier\u0027])"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"            # Check if the migration is supported."},{"line_number":1290,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5453383e_890af8bc","side":"PARENT","line":1287,"range":{"start_line":1287,"start_character":16,"end_line":1287,"end_character":49},"in_reply_to":"ec293cbd_e5be3de9","updated":"2024-06-27 12:21:14.000000000","message":"After some internal discussion: we noticed that _setup_server() is not called in svm migrate (i.e. nondisruptive) case, but anyhow share_server_migration_complete() in share/manager.py should already take care of copying the identifier from the source to the destination share server.\n\nOr was the previous migration done with SVM DR?","commit_id":"842fda18e50b9099dbba8a3624b1f940c8329578"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"d1a532a9d0bca6a8035c614aed6e16507b177c44","unresolved":true,"context_lines":[{"line_number":1284,"context_line":"        if (dest_client.is_svm_migrate_supported()"},{"line_number":1285,"context_line":"                and src_client.is_svm_migrate_supported()):"},{"line_number":1286,"context_line":"            source_share_server_name \u003d self._get_vserver_name("},{"line_number":1287,"context_line":"                source_share_server[\u0027identifier\u0027])"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"            # Check if the migration is supported."},{"line_number":1290,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"18401a1c_ac96a7bf","side":"PARENT","line":1287,"range":{"start_line":1287,"start_character":16,"end_line":1287,"end_character":49},"in_reply_to":"ec293cbd_e5be3de9","updated":"2024-06-27 12:31:37.000000000","message":"We are doing SVM migrate, and Manila update \u0027identifier\u0027 after migration finished successfully, https://opendev.org/openstack/manila/src/commit/eca9ec1955e929e3da0c14cd0ae4da07eb1166c4/manila/share/manager.py#L6049-L6051. So we don\u0027t see issue with this","commit_id":"842fda18e50b9099dbba8a3624b1f940c8329578"}],"manila/share/manager.py":[{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"bb930f010bc8c2534ebf10084082d01e9719780d","unresolved":true,"context_lines":[{"line_number":6098,"context_line":"            snapshot_instances, new_network_allocations)"},{"line_number":6099,"context_line":""},{"line_number":6100,"context_line":"        if migration_reused_network_allocations:"},{"line_number":6101,"context_line":"            updated_allocations \u003d existing_allocations"},{"line_number":6102,"context_line":"        else:"},{"line_number":6103,"context_line":"            network_allocations \u003d []"},{"line_number":6104,"context_line":"            for net_allocation in new_network_allocations:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa01acff_73397671","line":6101,"updated":"2024-06-27 10:21:17.000000000","message":"existing_allocations is []. Perhaps you want to fetch network allocations from source share server and set to updated_allocations?","commit_id":"23db9d7d3db813215ebfd9672817994c811b86af"},{"author":{"_account_id":35979,"name":"Sylvan Le Deunff","email":"sylvan.le-deunff@ovhcloud.com","username":"sylvanld"},"change_message_id":"ffdd64bfb309316ef31ab50747a135e602793b66","unresolved":false,"context_lines":[{"line_number":6098,"context_line":"            snapshot_instances, new_network_allocations)"},{"line_number":6099,"context_line":""},{"line_number":6100,"context_line":"        if migration_reused_network_allocations:"},{"line_number":6101,"context_line":"            updated_allocations \u003d existing_allocations"},{"line_number":6102,"context_line":"        else:"},{"line_number":6103,"context_line":"            network_allocations \u003d []"},{"line_number":6104,"context_line":"            for net_allocation in new_network_allocations:"}],"source_content_type":"text/x-python","patch_set":4,"id":"d770eaa5_653c2fb8","line":6101,"in_reply_to":"fa01acff_73397671","updated":"2024-07-31 09:47:18.000000000","message":"You are right, I made a mistake copying it from our internal changes","commit_id":"23db9d7d3db813215ebfd9672817994c811b86af"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"bb930f010bc8c2534ebf10084082d01e9719780d","unresolved":true,"context_lines":[{"line_number":6111,"context_line":""},{"line_number":6112,"context_line":"        for allocation in updated_allocations:"},{"line_number":6113,"context_line":"            allocation_id \u003d allocation[\u0027id\u0027]"},{"line_number":6114,"context_line":"            values \u003d {"},{"line_number":6115,"context_line":"                \u0027share_server_id\u0027: dest_share_server[\u0027id\u0027]"},{"line_number":6116,"context_line":"            }"},{"line_number":6117,"context_line":"            self.db.network_allocation_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"11d0d607_e6e3b725","line":6114,"updated":"2024-06-27 10:21:17.000000000","message":"may I suggest to move `values \u003d ...` to the front of if-block? I am working on a scenario where I need to set the segmentation_id. I would add another branch, and it will be convenient to be able to update the `values` dict there.","commit_id":"23db9d7d3db813215ebfd9672817994c811b86af"},{"author":{"_account_id":35979,"name":"Sylvan Le Deunff","email":"sylvan.le-deunff@ovhcloud.com","username":"sylvanld"},"change_message_id":"ffdd64bfb309316ef31ab50747a135e602793b66","unresolved":false,"context_lines":[{"line_number":6111,"context_line":""},{"line_number":6112,"context_line":"        for allocation in updated_allocations:"},{"line_number":6113,"context_line":"            allocation_id \u003d allocation[\u0027id\u0027]"},{"line_number":6114,"context_line":"            values \u003d {"},{"line_number":6115,"context_line":"                \u0027share_server_id\u0027: dest_share_server[\u0027id\u0027]"},{"line_number":6116,"context_line":"            }"},{"line_number":6117,"context_line":"            self.db.network_allocation_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"62f254b1_6a84ec11","line":6114,"in_reply_to":"11d0d607_e6e3b725","updated":"2024-07-31 09:47:18.000000000","message":"Done","commit_id":"23db9d7d3db813215ebfd9672817994c811b86af"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"343e8387888d23b10a82a5f7265d98f9b25bfb3a","unresolved":false,"context_lines":[{"line_number":6248,"context_line":"        }"},{"line_number":6249,"context_line":"        subnet_update \u003d {}"},{"line_number":6250,"context_line":""},{"line_number":6251,"context_line":"        if migration_extended_network_allocations:"},{"line_number":6252,"context_line":"            # NOTE: Network allocations are extended to the destination host on"},{"line_number":6253,"context_line":"            # previous (migration_start) step, i.e. port bindings are created"},{"line_number":6254,"context_line":"            # on destination host with existing ports. The network allocations"}],"source_content_type":"text/x-python","patch_set":10,"id":"e2ccf732_86caa070","line":6251,"updated":"2024-10-10 08:40:09.000000000","message":"Nice catch. The port binding cutover can be indeed postponed after driver migration completes. I have tested and it works well.","commit_id":"5d574edbbe20f2102d2e7aa08580ef53aef0cd28"}]}