)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b81f5af36c78e1d52f64c35f0b8d72f65013f052","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db90409d_651235a8","updated":"2024-06-28 23:02:51.000000000","message":"Thanks kiran, couple of minor issues noted inline","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3f5b24818199b528adb96ecf2bfed41d5022801c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9347e6d_c430c931","updated":"2024-07-03 08:41:32.000000000","message":"Fixed suggestions.","commit_id":"8bbfd9cc9bdfc642ac82d7614ff2891d05787917"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"17acecd25fb6f387144581f981460d88e115cfa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3eba5b54_6c1d356c","updated":"2024-07-01 15:41:08.000000000","message":"Thank you; LGTM","commit_id":"8bbfd9cc9bdfc642ac82d7614ff2891d05787917"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9da80c6cfa013e5fd0fa78965f7530c7b7aaa029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6be163f_01239517","updated":"2024-07-03 19:52:40.000000000","message":"@gawasthi2010@gmail.com @manicsaran@gmail.com @jayaanand.borra@netapp.com @saikumar1016@gmail.com\n\nCan you please take a look here? The NetApp CI is still reporting issues.","commit_id":"e982eae40a21da26727a4d55a17a3b03f716d046"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5faf9c307a5be65e657d3490eb90187eaf7cd1eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d3448085_01ca4d31","updated":"2024-07-08 15:36:33.000000000","message":"Kiran: Can you please backport this change to older/stable releases?","commit_id":"e982eae40a21da26727a4d55a17a3b03f716d046"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1cd8d1d21b4bc9f4c10d6b12e9464e1aadb64ada","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61e9859c_d1196292","updated":"2024-07-18 06:15:54.000000000","message":"LGTM","commit_id":"e982eae40a21da26727a4d55a17a3b03f716d046"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8644fda154d83b6960e4ca36f7df5d3686941e25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"074623f7_5b873c37","updated":"2024-07-03 12:38:46.000000000","message":"LGTM, thank you for workin on this fix","commit_id":"e982eae40a21da26727a4d55a17a3b03f716d046"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"e3a5a6e34cad04ea9f4199b4a3f47e398004d3c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0060a73_e207642d","updated":"2024-07-08 12:34:06.000000000","message":"Looks fine","commit_id":"e982eae40a21da26727a4d55a17a3b03f716d046"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"517ef19143f81f16b67bcb35076fadbaf11ddf35","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b06f2eac_c2764b61","updated":"2024-07-08 06:42:52.000000000","message":"There are other places in ZAPI as well as in REST client we are enabling and disabling the dedupe, could you please make those changes also. Those are for flex group but it is nice to have those. Below are list of methods \n\ndef enable_dedupe_async(self, volume_name):\ndef disable_dedupe_async(self, volume_name):","commit_id":"e982eae40a21da26727a4d55a17a3b03f716d046"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"e3a5a6e34cad04ea9f4199b4a3f47e398004d3c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6d3f6b8f_950c3a6a","in_reply_to":"170012f8_6206b68c","updated":"2024-07-08 12:34:06.000000000","message":"ok","commit_id":"e982eae40a21da26727a4d55a17a3b03f716d046"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"be6c710b6ca595558232e38d07ad2e025b0854a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"170012f8_6206b68c","in_reply_to":"b06f2eac_c2764b61","updated":"2024-07-08 10:11:57.000000000","message":"No, async method does not need to retry.","commit_id":"e982eae40a21da26727a4d55a17a3b03f716d046"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b81f5af36c78e1d52f64c35f0b8d72f65013f052","unresolved":true,"context_lines":[{"line_number":2327,"context_line":"        return api_args"},{"line_number":2328,"context_line":""},{"line_number":2329,"context_line":"    @na_utils.trace"},{"line_number":2330,"context_line":"    def enable_dedup(self, volume_name):"},{"line_number":2331,"context_line":"        \"\"\"Enable deduplication on volume.\"\"\""},{"line_number":2332,"context_line":"        interval \u003d 3"},{"line_number":2333,"context_line":"        retries \u003d 5"}],"source_content_type":"text/x-python","patch_set":1,"id":"86236cee_59eb3b16","line":2330,"range":{"start_line":2330,"start_character":8,"end_line":2330,"end_character":20},"updated":"2024-06-28 23:02:51.000000000","message":"can we add a test case for these two changes here? https://opendev.org/openstack/manila/src/branch/master/manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py#L3493","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"72014422d3be669d92f96ee1a9f5b1b5e360a25b","unresolved":false,"context_lines":[{"line_number":2327,"context_line":"        return api_args"},{"line_number":2328,"context_line":""},{"line_number":2329,"context_line":"    @na_utils.trace"},{"line_number":2330,"context_line":"    def enable_dedup(self, volume_name):"},{"line_number":2331,"context_line":"        \"\"\"Enable deduplication on volume.\"\"\""},{"line_number":2332,"context_line":"        interval \u003d 3"},{"line_number":2333,"context_line":"        retries \u003d 5"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f731fc3_26c6bea2","line":2330,"range":{"start_line":2330,"start_character":8,"end_line":2330,"end_character":20},"in_reply_to":"86236cee_59eb3b16","updated":"2024-07-01 07:42:25.000000000","message":"Done","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b81f5af36c78e1d52f64c35f0b8d72f65013f052","unresolved":true,"context_lines":[{"line_number":2333,"context_line":"        retries \u003d 5"},{"line_number":2334,"context_line":"        api_args \u003d {\u0027path\u0027: \u0027/vol/%s\u0027 % volume_name}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        @manila_utils.retry(retry_param\u003dexception.ShareBackendException,"},{"line_number":2337,"context_line":"                            interval\u003dinterval,"},{"line_number":2338,"context_line":"                            retries\u003dretries,"},{"line_number":2339,"context_line":"                            backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd818e34_9e5a5f8b","line":2336,"range":{"start_line":2336,"start_character":50,"end_line":2336,"end_character":71},"updated":"2024-06-28 23:02:51.000000000","message":"this file uses NetAppException in most places; maybe stick to that.. it looks like ShareBackendException is only used one other place (and its worth fixing it in a different change).","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"72014422d3be669d92f96ee1a9f5b1b5e360a25b","unresolved":false,"context_lines":[{"line_number":2333,"context_line":"        retries \u003d 5"},{"line_number":2334,"context_line":"        api_args \u003d {\u0027path\u0027: \u0027/vol/%s\u0027 % volume_name}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        @manila_utils.retry(retry_param\u003dexception.ShareBackendException,"},{"line_number":2337,"context_line":"                            interval\u003dinterval,"},{"line_number":2338,"context_line":"                            retries\u003dretries,"},{"line_number":2339,"context_line":"                            backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"08d2f113_8669ccf3","line":2336,"range":{"start_line":2336,"start_character":50,"end_line":2336,"end_character":71},"in_reply_to":"bd818e34_9e5a5f8b","updated":"2024-07-01 07:42:25.000000000","message":"Done","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b81f5af36c78e1d52f64c35f0b8d72f65013f052","unresolved":true,"context_lines":[{"line_number":2358,"context_line":"        try_enable_dedup()"},{"line_number":2359,"context_line":""},{"line_number":2360,"context_line":"    @na_utils.trace"},{"line_number":2361,"context_line":"    def disable_dedup(self, volume_name):"},{"line_number":2362,"context_line":"        \"\"\"Disable deduplication on volume.\"\"\""},{"line_number":2363,"context_line":"        interval \u003d 3"},{"line_number":2364,"context_line":"        retries \u003d 5"}],"source_content_type":"text/x-python","patch_set":1,"id":"177e371d_7dc6b852","line":2361,"range":{"start_line":2361,"start_character":8,"end_line":2361,"end_character":21},"updated":"2024-06-28 23:02:51.000000000","message":"Same comment as above: https://opendev.org/openstack/manila/src/branch/master/manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py#L3493","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"72014422d3be669d92f96ee1a9f5b1b5e360a25b","unresolved":false,"context_lines":[{"line_number":2358,"context_line":"        try_enable_dedup()"},{"line_number":2359,"context_line":""},{"line_number":2360,"context_line":"    @na_utils.trace"},{"line_number":2361,"context_line":"    def disable_dedup(self, volume_name):"},{"line_number":2362,"context_line":"        \"\"\"Disable deduplication on volume.\"\"\""},{"line_number":2363,"context_line":"        interval \u003d 3"},{"line_number":2364,"context_line":"        retries \u003d 5"}],"source_content_type":"text/x-python","patch_set":1,"id":"261f2ec4_9d32d146","line":2361,"range":{"start_line":2361,"start_character":8,"end_line":2361,"end_character":21},"in_reply_to":"177e371d_7dc6b852","updated":"2024-07-01 07:42:25.000000000","message":"Done","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"63e2442765b2db0039702880529b6fc25e2104c5","unresolved":true,"context_lines":[{"line_number":2333,"context_line":"        retries \u003d 5"},{"line_number":2334,"context_line":"        api_args \u003d {\u0027path\u0027: \u0027/vol/%s\u0027 % volume_name}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        @manila_utils.retry(retry_param\u003dexception.NetAppException,"},{"line_number":2337,"context_line":"                            interval\u003dinterval,"},{"line_number":2338,"context_line":"                            retries\u003dretries,"},{"line_number":2339,"context_line":"                            backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6d1f1675_4793d654","line":2336,"updated":"2024-07-03 07:15:47.000000000","message":"would be better to move the retry decorator to outer method, no need to add a nested function here.","commit_id":"8bbfd9cc9bdfc642ac82d7614ff2891d05787917"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3f5b24818199b528adb96ecf2bfed41d5022801c","unresolved":false,"context_lines":[{"line_number":2333,"context_line":"        retries \u003d 5"},{"line_number":2334,"context_line":"        api_args \u003d {\u0027path\u0027: \u0027/vol/%s\u0027 % volume_name}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"        @manila_utils.retry(retry_param\u003dexception.NetAppException,"},{"line_number":2337,"context_line":"                            interval\u003dinterval,"},{"line_number":2338,"context_line":"                            retries\u003dretries,"},{"line_number":2339,"context_line":"                            backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e3f61e0f_361cc49e","line":2336,"in_reply_to":"6d1f1675_4793d654","updated":"2024-07-03 08:41:32.000000000","message":"Done","commit_id":"8bbfd9cc9bdfc642ac82d7614ff2891d05787917"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"63e2442765b2db0039702880529b6fc25e2104c5","unresolved":true,"context_lines":[{"line_number":2364,"context_line":"        retries \u003d 5"},{"line_number":2365,"context_line":"        api_args \u003d {\u0027path\u0027: \u0027/vol/%s\u0027 % volume_name}"},{"line_number":2366,"context_line":""},{"line_number":2367,"context_line":"        @manila_utils.retry(retry_param\u003dexception.NetAppException,"},{"line_number":2368,"context_line":"                            interval\u003dinterval,"},{"line_number":2369,"context_line":"                            retries\u003dretries,"},{"line_number":2370,"context_line":"                            backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b8750042_b8493fce","line":2367,"updated":"2024-07-03 07:15:47.000000000","message":"same as above","commit_id":"8bbfd9cc9bdfc642ac82d7614ff2891d05787917"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3f5b24818199b528adb96ecf2bfed41d5022801c","unresolved":false,"context_lines":[{"line_number":2364,"context_line":"        retries \u003d 5"},{"line_number":2365,"context_line":"        api_args \u003d {\u0027path\u0027: \u0027/vol/%s\u0027 % volume_name}"},{"line_number":2366,"context_line":""},{"line_number":2367,"context_line":"        @manila_utils.retry(retry_param\u003dexception.NetAppException,"},{"line_number":2368,"context_line":"                            interval\u003dinterval,"},{"line_number":2369,"context_line":"                            retries\u003dretries,"},{"line_number":2370,"context_line":"                            backoff_rate\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b4fb81f1_40a6ca33","line":2367,"in_reply_to":"b8750042_b8493fce","updated":"2024-07-03 08:41:32.000000000","message":"Done","commit_id":"8bbfd9cc9bdfc642ac82d7614ff2891d05787917"}],"releasenotes/notes/bug-2071359-netapp-retry-sis-operatin-if-already-active-4625605175f76d07.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b81f5af36c78e1d52f64c35f0b8d72f65013f052","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver will now retry the sis operation (e.g. dedupe) if sis"},{"line_number":5,"context_line":"    operation is currently active. This is needed because NetApp turn on"},{"line_number":6,"context_line":"    efficiency (by default) on latest hardware which causes conflicting sis"},{"line_number":7,"context_line":"    operation when Manila tries to turn it off. For more details, please check"},{"line_number":8,"context_line":"    Launchpad `bug #2071359 \u003chttps://bugs.launchpad.net/manila/+bug/2071359\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"01df53ff_94cef9cb","line":5,"range":{"start_line":5,"start_character":65,"end_line":5,"end_character":69},"updated":"2024-06-28 23:02:51.000000000","message":"nit: turns","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"72014422d3be669d92f96ee1a9f5b1b5e360a25b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver will now retry the sis operation (e.g. dedupe) if sis"},{"line_number":5,"context_line":"    operation is currently active. This is needed because NetApp turn on"},{"line_number":6,"context_line":"    efficiency (by default) on latest hardware which causes conflicting sis"},{"line_number":7,"context_line":"    operation when Manila tries to turn it off. For more details, please check"},{"line_number":8,"context_line":"    Launchpad `bug #2071359 \u003chttps://bugs.launchpad.net/manila/+bug/2071359\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d66994be_552e4aef","line":5,"range":{"start_line":5,"start_character":65,"end_line":5,"end_character":69},"in_reply_to":"01df53ff_94cef9cb","updated":"2024-07-01 07:42:25.000000000","message":"Done","commit_id":"0e53bc1e1d5f6cda0acc4fdd98d79ff3a54c541c"}]}