)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"c5289d98e662d275e679cafe34680daf4c0903f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"057b04b4_5cb180ef","updated":"2025-01-17 17:50:03.000000000","message":"it still failes, but I addressed your weird errors. Have a look please at fixes in the _get_request method in the test which helps avoiding need for a new method and generally forces much less changes. Please also consider that you have slightly changed formatting of files which will be probably undesired, so either you restore this manually or try to revert all you changes to the initial state and replay the relevant changes (I believe changes in the schemas module are fine, but others may cause cores to complain)","commit_id":"fa5d88dc4c0aa03447ef77fa536bcf0b5478f180"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53394658f97b7b5e27c6fd8688c192de8b7c4c3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"67a2ba11_5d30507f","updated":"2025-02-14 20:43:10.000000000","message":"Hey, Jonathan. I figured out what is happening on this change that is causing the unit tests to fail.\n\nIn the views file [1] (which is exactly where the build the dictionary to be returned), we are removing the share group quotas of the dictionary in case the request had a share type as one of the query parameters. All of the quota show/detail tests that are failing are using a share type in the request, that\u0027s why the validation is failing.\n\nIn this case, we would need to make the response body example more dynamic: share groups are required in the response only when the request doesn\u0027t have a share type in the query parameters. I was looking at examples in the documentation and apparently this can be a bit tricky, as the request and the response don\u0027t share the same context. I saw some suggestions of using anyOf and oneOf for this validation. It can work, but I see this validation not being so strict as the other ones. @artem.goncharov@gmail.com do you have any other good ideas on how to deal with this? \n\n[1] https://github.com/openstack/manila/blob/master/manila/api/views/quota_sets.py#L41-L45\n\nThank you for your patience with this change :)","commit_id":"fdb73b50580fb5dd76a119fd5e065ff76b4e2c0f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"97a666c15e29d341f6e27d3790376f3586deb395","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"29816b69_1d17828f","in_reply_to":"67a2ba11_5d30507f","updated":"2025-02-28 14:16:45.000000000","message":"This is an example of what I mean: https://paste.opendev.org/show/bwb4ioEa7ys6twsg8rXv/\nPlease note that when we don\u0027t use --share-type (send a GET with a share type as part of the query parameter), we have the share groups and share group snapshots quota, but when we don\u0027t, such quotas are there.\nAt the end, that\u0027s what we will need to work around.","commit_id":"fdb73b50580fb5dd76a119fd5e065ff76b4e2c0f"}],"manila/tests/api/v2/test_quota_sets.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53394658f97b7b5e27c6fd8688c192de8b7c4c3f","unresolved":true,"context_lines":[{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    # TODO(jonathan) - MM not obj"},{"line_number":884,"context_line":"    def test_delete_not_authorized(self):"},{"line_number":885,"context_line":"        req \u003d self._get_fake_http_request(False, False)"},{"line_number":886,"context_line":"        self.assertRaises("},{"line_number":887,"context_line":"            webob.exc.HTTPForbidden,"},{"line_number":888,"context_line":"            self.controller.delete,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9e3e5e33_404a2edd","line":885,"range":{"start_line":885,"start_character":8,"end_line":885,"end_character":55},"updated":"2025-02-14 20:43:10.000000000","message":"```suggestion\n        req \u003d _get_request(False, False)\n```","commit_id":"fdb73b50580fb5dd76a119fd5e065ff76b4e2c0f"}]}