)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"717b1018ca65102513b067a44762d6ae522426a6","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- We will attempt to resize subvolumes whose size are \"infinite\""},{"line_number":20,"context_line":"to a configuration option defined in the cephfs driver."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I5e86d09ea5ba8e61ecf04c52b25c639dfc823737"},{"line_number":23,"context_line":"Signed-off-by: Carlos Eduardo \u003cces.eduardo98@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0d793874_61521281","line":21,"updated":"2024-07-25 19:15:55.000000000","message":"add partially implements","commit_id":"db8d23a914efd81ffe4a7d46fd419c7455aed487"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ad34f42d6322d3473c4e41a87b7bd66cbb200c21","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- We will attempt to resize subvolumes whose size are \"infinite\""},{"line_number":20,"context_line":"to a configuration option defined in the cephfs driver."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I5e86d09ea5ba8e61ecf04c52b25c639dfc823737"},{"line_number":23,"context_line":"Signed-off-by: Carlos Eduardo \u003cces.eduardo98@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8439c8a7_ea9144d1","line":21,"in_reply_to":"0d793874_61521281","updated":"2024-08-28 21:40:10.000000000","message":"Done","commit_id":"db8d23a914efd81ffe4a7d46fd419c7455aed487"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"12dbc36d922b2bb369248d6799a3965cc610795a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"provide the subvolume/subvolume snapshot name in the"},{"line_number":14,"context_line":"export/provider location parameter."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- The size of the snapshots will follow the shares\u0027 size, as we"},{"line_number":17,"context_line":"can not currently be sure of the real size of the snapshot."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- We will attempt to resize subvolumes whose size are \"infinite\""},{"line_number":20,"context_line":"to a configuration option defined in the cephfs driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"37f20946_92075c1d","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":59},"updated":"2024-08-12 15:40:05.000000000","message":"add a mention here to https://tracker.ceph.com/issues/67215#change-270669","commit_id":"311885520261c1bc63f9a24bc2f8f45acb29d0aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"provide the subvolume/subvolume snapshot name in the"},{"line_number":14,"context_line":"export/provider location parameter."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- The size of the snapshots will follow the shares\u0027 size, as we"},{"line_number":17,"context_line":"can not currently be sure of the real size of the snapshot."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- We will attempt to resize subvolumes whose size are \"infinite\""},{"line_number":20,"context_line":"to a configuration option defined in the cephfs driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"373344ea_3b966af5","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":59},"in_reply_to":"37f20946_92075c1d","updated":"2024-08-27 22:56:42.000000000","message":"Done","commit_id":"311885520261c1bc63f9a24bc2f8f45acb29d0aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[1] https://tracker.ceph.com/issues/67215#change-270669"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Partially-Implements: bp/manage-unmanage-cephfs-shares-and-snapshots"},{"line_number":30,"context_line":"Change-Id: I5e86d09ea5ba8e61ecf04c52b25c639dfc823737"},{"line_number":31,"context_line":"Signed-off-by: Carlos Eduardo \u003cces.eduardo98@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"55a8a828_15dc8cc9","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":9},"updated":"2024-08-27 22:56:42.000000000","message":"Partially? because of the tempest plugin tests?","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c028c393148cbfb9fabfa32f99e2f0169cdf9f7d","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[1] https://tracker.ceph.com/issues/67215#change-270669"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Partially-Implements: bp/manage-unmanage-cephfs-shares-and-snapshots"},{"line_number":30,"context_line":"Change-Id: I5e86d09ea5ba8e61ecf04c52b25c639dfc823737"},{"line_number":31,"context_line":"Signed-off-by: Carlos Eduardo \u003cces.eduardo98@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9df8495d_9a2af7eb","line":29,"range":{"start_line":29,"start_character":24,"end_line":29,"end_character":25},"updated":"2024-08-27 22:57:25.000000000","message":"bp\u003cspace\u003emanage-unmanage-cephfs-shares-and-snapshots","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[1] https://tracker.ceph.com/issues/67215#change-270669"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Partially-Implements: bp/manage-unmanage-cephfs-shares-and-snapshots"},{"line_number":30,"context_line":"Change-Id: I5e86d09ea5ba8e61ecf04c52b25c639dfc823737"},{"line_number":31,"context_line":"Signed-off-by: Carlos Eduardo \u003cces.eduardo98@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"6eea465e_34703ad9","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":9},"in_reply_to":"55a8a828_15dc8cc9","updated":"2024-08-28 21:18:24.000000000","message":"yes :)","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[1] https://tracker.ceph.com/issues/67215#change-270669"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Partially-Implements: bp/manage-unmanage-cephfs-shares-and-snapshots"},{"line_number":30,"context_line":"Change-Id: I5e86d09ea5ba8e61ecf04c52b25c639dfc823737"},{"line_number":31,"context_line":"Signed-off-by: Carlos Eduardo \u003cces.eduardo98@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9d22ecbe_78c62782","line":29,"range":{"start_line":29,"start_character":24,"end_line":29,"end_character":25},"in_reply_to":"9df8495d_9a2af7eb","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"717b1018ca65102513b067a44762d6ae522426a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74fcaeb5_6f56b305","updated":"2024-07-25 19:15:55.000000000","message":"Still need to add a release note :)","commit_id":"db8d23a914efd81ffe4a7d46fd419c7455aed487"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8d80c361_e78c7e99","updated":"2024-08-27 22:56:42.000000000","message":"Thank you Carlos; Could you please see comments inline and add a release note?","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9f1df57d_fadb97db","updated":"2024-08-28 21:18:24.000000000","message":"Thanks for the reviews, Goutham and Haixin. Please take a look at the changes and responses inline :)","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ccafc9e7c77261aad4762241352b3f242d222e22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2ad308c8_e57ef149","updated":"2024-08-27 18:06:58.000000000","message":"recheck\nA couple of timeout failures in the grenade job. This change doesn\u0027t touch any core features that should impact the grenade job.","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7ba0281d945f68a453190f302d0c112f49df4d65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bbc1a550_90582d10","updated":"2024-08-30 01:32:10.000000000","message":"LGTM","commit_id":"30281a646c9c53a31207af499b35c61084e77e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4646df031294e9e1e5b05eaa416254607b24e97a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ab63fe26_206483a3","updated":"2024-08-30 05:35:29.000000000","message":"Thanks; LGTM.. thanks for enabling the tests; lets work on them if necessary and follow up","commit_id":"30281a646c9c53a31207af499b35c61084e77e1c"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"30a3792c988c1498fc283f2fd796795efe89f819","unresolved":true,"context_lines":[{"line_number":643,"context_line":"        )"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        sub_snapshot_list \u003d rados_command("},{"line_number":646,"context_line":"            self.rados_client, \"fs subvolume snapshot ls\","},{"line_number":647,"context_line":"            argdict, json_obj\u003dTrue"},{"line_number":648,"context_line":"        )"},{"line_number":649,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b232e99b_acc927cf","line":646,"range":{"start_line":646,"start_character":32,"end_line":646,"end_character":56},"updated":"2024-08-12 15:41:09.000000000","message":"from ashrodri/gouthamr in the collab review: run snapshot info instead","commit_id":"311885520261c1bc63f9a24bc2f8f45acb29d0aa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ccafc9e7c77261aad4762241352b3f242d222e22","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        )"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        sub_snapshot_list \u003d rados_command("},{"line_number":646,"context_line":"            self.rados_client, \"fs subvolume snapshot ls\","},{"line_number":647,"context_line":"            argdict, json_obj\u003dTrue"},{"line_number":648,"context_line":"        )"},{"line_number":649,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d0d25857_039e7429","line":646,"range":{"start_line":646,"start_character":32,"end_line":646,"end_character":56},"in_reply_to":"b232e99b_acc927cf","updated":"2024-08-27 18:06:58.000000000","message":"Done","commit_id":"311885520261c1bc63f9a24bc2f8f45acb29d0aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                    \"startup. Ensuring would re-export shares and this \""},{"line_number":146,"context_line":"                    \"action isn\u0027t always required, unless something has \""},{"line_number":147,"context_line":"                    \"been administratively modified on CephFS.\"),"},{"line_number":148,"context_line":"    cfg.IntOpt(\u0027cephfs_default_infinite_share_size\u0027,"},{"line_number":149,"context_line":"               default\u003d10,"},{"line_number":150,"context_line":"               help\u003d\"Provide a integer that indicate the amount of gigabytes \""},{"line_number":151,"context_line":"                    \"that a share should be resized during the share manage \""},{"line_number":152,"context_line":"                    \"process, in case its size is considered infinite by the \""},{"line_number":153,"context_line":"                    \"share back end.\")"},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027cephfs_nfs_cluster_id\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"a006df19_ef833e9f","line":154,"range":{"start_line":148,"start_character":0,"end_line":154,"end_character":1},"updated":"2024-08-27 22:56:42.000000000","message":"-1\n\nCan we please do a driver option instead?\nit\u0027d be a weird knob to have a global size for shares.. it\u0027s possible we\u0027d want to enforce a quota when bringing an infinite share into Manila..","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8eddc6a041352e41759b5d9875f7fc2610b5545b","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                    \"startup. Ensuring would re-export shares and this \""},{"line_number":146,"context_line":"                    \"action isn\u0027t always required, unless something has \""},{"line_number":147,"context_line":"                    \"been administratively modified on CephFS.\"),"},{"line_number":148,"context_line":"    cfg.IntOpt(\u0027cephfs_default_infinite_share_size\u0027,"},{"line_number":149,"context_line":"               default\u003d10,"},{"line_number":150,"context_line":"               help\u003d\"Provide a integer that indicate the amount of gigabytes \""},{"line_number":151,"context_line":"                    \"that a share should be resized during the share manage \""},{"line_number":152,"context_line":"                    \"process, in case its size is considered infinite by the \""},{"line_number":153,"context_line":"                    \"share back end.\")"},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027cephfs_nfs_cluster_id\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"2733af73_4a6bb603","line":154,"range":{"start_line":148,"start_character":0,"end_line":154,"end_character":1},"in_reply_to":"09d31120_ef7bb7af","updated":"2024-08-28 17:58:19.000000000","message":"That is certainly a valid question! but, we don\u0027t raise OverQuota within the manila manage workflow intentionally: https://github.com/openstack/manila/blob/52d423f6061e707d3bd969354769014ed4847e0d/manila/share/manager.py#L2959-L2970\n\nWe allow the quota to be exceeded, and inform the administrator via logging.. they\u0027ll need to adjust the quota accordingly.","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    \"startup. Ensuring would re-export shares and this \""},{"line_number":146,"context_line":"                    \"action isn\u0027t always required, unless something has \""},{"line_number":147,"context_line":"                    \"been administratively modified on CephFS.\"),"},{"line_number":148,"context_line":"    cfg.IntOpt(\u0027cephfs_default_infinite_share_size\u0027,"},{"line_number":149,"context_line":"               default\u003d10,"},{"line_number":150,"context_line":"               help\u003d\"Provide a integer that indicate the amount of gigabytes \""},{"line_number":151,"context_line":"                    \"that a share should be resized during the share manage \""},{"line_number":152,"context_line":"                    \"process, in case its size is considered infinite by the \""},{"line_number":153,"context_line":"                    \"share back end.\")"},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027cephfs_nfs_cluster_id\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"e86a5970_92ed3301","line":154,"range":{"start_line":148,"start_character":0,"end_line":154,"end_character":1},"in_reply_to":"2733af73_4a6bb603","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"66d83dbe585bea7ddd62db4c7f5fb080054c4470","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                    \"startup. Ensuring would re-export shares and this \""},{"line_number":146,"context_line":"                    \"action isn\u0027t always required, unless something has \""},{"line_number":147,"context_line":"                    \"been administratively modified on CephFS.\"),"},{"line_number":148,"context_line":"    cfg.IntOpt(\u0027cephfs_default_infinite_share_size\u0027,"},{"line_number":149,"context_line":"               default\u003d10,"},{"line_number":150,"context_line":"               help\u003d\"Provide a integer that indicate the amount of gigabytes \""},{"line_number":151,"context_line":"                    \"that a share should be resized during the share manage \""},{"line_number":152,"context_line":"                    \"process, in case its size is considered infinite by the \""},{"line_number":153,"context_line":"                    \"share back end.\")"},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027cephfs_nfs_cluster_id\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"09d31120_ef7bb7af","line":154,"range":{"start_line":148,"start_character":0,"end_line":154,"end_character":1},"in_reply_to":"a006df19_ef833e9f","updated":"2024-08-28 09:12:49.000000000","message":"In my opinion, if the size of the subvolume is infinite. manila does not support manage, just raise.\nFor example, the current project quota still has 5G left to manage a subvolume with unlimited capacity. The driver successfully changed unrestricted to 10G, but the manager reported an OverQuota error. As a result, the capacity of the subvolume was changed, and manila failed to manage it.   what do you think?","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        return gigs * units.Gi"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def _get_sub_name(self, share_id):"},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            subvolume_name \u003d self.private_storage.get(share_id, \"sub_name\")"},{"line_number":346,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"e5f2c484_d7709f2e","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":21},"updated":"2024-08-27 22:56:42.000000000","message":"```suggestion\n    def _get_subvolume_name(self, share_id):\n```","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        return gigs * units.Gi"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def _get_sub_name(self, share_id):"},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            subvolume_name \u003d self.private_storage.get(share_id, \"sub_name\")"},{"line_number":346,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"53a49dce_41301631","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":21},"in_reply_to":"e5f2c484_d7709f2e","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def _get_sub_name(self, share_id):"},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            subvolume_name \u003d self.private_storage.get(share_id, \"sub_name\")"},{"line_number":346,"context_line":"        except Exception:"},{"line_number":347,"context_line":"            return share_id"},{"line_number":348,"context_line":"        # Subvolume name could be empy, so in case it is, return share_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"033d1a16_5c7aaf6b","line":345,"range":{"start_line":345,"start_character":65,"end_line":345,"end_character":73},"updated":"2024-08-27 22:56:42.000000000","message":"```suggestion\n            subvolume_name \u003d self.private_storage.get(share_id, \"subvolume_name\")\n```","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def _get_sub_name(self, share_id):"},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            subvolume_name \u003d self.private_storage.get(share_id, \"sub_name\")"},{"line_number":346,"context_line":"        except Exception:"},{"line_number":347,"context_line":"            return share_id"},{"line_number":348,"context_line":"        # Subvolume name could be empy, so in case it is, return share_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"4664b38d_50fc8f74","line":345,"range":{"start_line":345,"start_character":65,"end_line":345,"end_character":73},"in_reply_to":"033d1a16_5c7aaf6b","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":345,"context_line":"            subvolume_name \u003d self.private_storage.get(share_id, \"sub_name\")"},{"line_number":346,"context_line":"        except Exception:"},{"line_number":347,"context_line":"            return share_id"},{"line_number":348,"context_line":"        # Subvolume name could be empy, so in case it is, return share_id"},{"line_number":349,"context_line":"        return subvolume_name or share_id"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def _get_subvolume_snapshot_name(self, snapshot_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"f4e1cd48_2948d49d","line":348,"range":{"start_line":348,"start_character":34,"end_line":348,"end_character":38},"updated":"2024-08-27 22:56:42.000000000","message":"None","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            subvolume_name \u003d self.private_storage.get(share_id, \"sub_name\")"},{"line_number":346,"context_line":"        except Exception:"},{"line_number":347,"context_line":"            return share_id"},{"line_number":348,"context_line":"        # Subvolume name could be empy, so in case it is, return share_id"},{"line_number":349,"context_line":"        return subvolume_name or share_id"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def _get_subvolume_snapshot_name(self, snapshot_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"16122481_402e57ba","line":348,"range":{"start_line":348,"start_character":34,"end_line":348,"end_character":38},"in_reply_to":"f4e1cd48_2948d49d","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":351,"context_line":"    def _get_subvolume_snapshot_name(self, snapshot_id):"},{"line_number":352,"context_line":"        try:"},{"line_number":353,"context_line":"            subvolume_snapshot_name \u003d self.private_storage.get("},{"line_number":354,"context_line":"                snapshot_id, \"snap_name\""},{"line_number":355,"context_line":"            )"},{"line_number":356,"context_line":"        except Exception:"},{"line_number":357,"context_line":"            return snapshot_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"74ed8b85_8d0313b8","line":354,"updated":"2024-08-27 22:56:42.000000000","message":"```suggestion\n                snapshot_id, \"subvolume_snapshot_name\"\n```","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    def _get_subvolume_snapshot_name(self, snapshot_id):"},{"line_number":352,"context_line":"        try:"},{"line_number":353,"context_line":"            subvolume_snapshot_name \u003d self.private_storage.get("},{"line_number":354,"context_line":"                snapshot_id, \"snap_name\""},{"line_number":355,"context_line":"            )"},{"line_number":356,"context_line":"        except Exception:"},{"line_number":357,"context_line":"            return snapshot_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"270f8767_d4cf164e","line":354,"in_reply_to":"74ed8b85_8d0313b8","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"66d83dbe585bea7ddd62db4c7f5fb080054c4470","unresolved":true,"context_lines":[{"line_number":516,"context_line":"        return self._get_export_locations(share)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def _get_subvolume_size_in_gb(self, subvolume_size):"},{"line_number":519,"context_line":"        return round(int(subvolume_size) / units.Gi, 2)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":522,"context_line":"        # bring FS subvolume/share under manila management"}],"source_content_type":"text/x-python","patch_set":7,"id":"a9a420d9_8fde6f6f","line":519,"range":{"start_line":519,"start_character":7,"end_line":519,"end_character":55},"updated":"2024-08-28 09:12:49.000000000","message":"new_gb \u003d int(math.ceil(int(subvolume_size) / units.Gi))\n    return new_gb\n    \nthen we should resize subvolume to new_gb.","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        return self._get_export_locations(share)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def _get_subvolume_size_in_gb(self, subvolume_size):"},{"line_number":519,"context_line":"        return round(int(subvolume_size) / units.Gi, 2)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":522,"context_line":"        # bring FS subvolume/share under manila management"}],"source_content_type":"text/x-python","patch_set":7,"id":"b1b41885_d57c4289","line":519,"range":{"start_line":519,"start_character":7,"end_line":519,"end_character":55},"in_reply_to":"a9a420d9_8fde6f6f","updated":"2024-08-28 21:18:24.000000000","message":"good catch, thanks :D","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":527,"context_line":"        subvolume_name \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027]"},{"line_number":528,"context_line":"        if not subvolume_name:"},{"line_number":529,"context_line":"            raise exception.ShareBackendException("},{"line_number":530,"context_line":"                \"The subvolume name must be provided as a driver option while \""},{"line_number":531,"context_line":"                \"managing shares.\")"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        argdict \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"a2179d6d_26d5805f","line":530,"range":{"start_line":530,"start_character":53,"end_line":530,"end_character":71},"updated":"2024-08-27 22:56:42.000000000","message":"as the `export_path`?","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        subvolume_name \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027]"},{"line_number":528,"context_line":"        if not subvolume_name:"},{"line_number":529,"context_line":"            raise exception.ShareBackendException("},{"line_number":530,"context_line":"                \"The subvolume name must be provided as a driver option while \""},{"line_number":531,"context_line":"                \"managing shares.\")"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        argdict \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"35be30f0_b94a19ba","line":530,"range":{"start_line":530,"start_character":53,"end_line":530,"end_character":71},"in_reply_to":"a2179d6d_26d5805f","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":548,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        # Check if share mode matches"},{"line_number":551,"context_line":"        if subvolume_info.get(\u0027mode\u0027) !\u003d self._cephfs_volume_mode:"},{"line_number":552,"context_line":"            LOG.info(\"Subvolume %(subvol)s mode is different from what is \""},{"line_number":553,"context_line":"                     \"configured in Manila.\")"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        subvolume_size \u003d subvolume_info.get(\u0027bytes_quota\u0027)"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"e220e27a_34f876e9","line":553,"range":{"start_line":551,"start_character":0,"end_line":553,"end_character":45},"updated":"2024-08-27 22:56:42.000000000","message":"Why don\u0027t we change it to match what we have in Manila?","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":true,"context_lines":[{"line_number":548,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        # Check if share mode matches"},{"line_number":551,"context_line":"        if subvolume_info.get(\u0027mode\u0027) !\u003d self._cephfs_volume_mode:"},{"line_number":552,"context_line":"            LOG.info(\"Subvolume %(subvol)s mode is different from what is \""},{"line_number":553,"context_line":"                     \"configured in Manila.\")"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        subvolume_size \u003d subvolume_info.get(\u0027bytes_quota\u0027)"},{"line_number":556,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"61ddbeed_2a7e55a2","line":553,"range":{"start_line":551,"start_character":0,"end_line":553,"end_character":45},"in_reply_to":"e220e27a_34f876e9","updated":"2024-08-28 21:18:24.000000000","message":"Unfortunately, we don\u0027t have an API to update the volume mode. We used to do it when it was idempotent, but apparently this is only happening now when the creation was idempotent","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"66d83dbe585bea7ddd62db4c7f5fb080054c4470","unresolved":true,"context_lines":[{"line_number":552,"context_line":"            LOG.info(\"Subvolume %(subvol)s mode is different from what is \""},{"line_number":553,"context_line":"                     \"configured in Manila.\")"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        subvolume_size \u003d subvolume_info.get(\u0027bytes_quota\u0027)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        # We need to resize infinite subvolumes, as Manila doesn\u0027t support it"},{"line_number":558,"context_line":"        if isinstance(subvolume_size, str) and subvolume_size \u003d\u003d \"infinite\":"}],"source_content_type":"text/x-python","patch_set":7,"id":"deaf4328_7efa49df","line":555,"range":{"start_line":555,"start_character":8,"end_line":555,"end_character":58},"updated":"2024-08-28 09:12:49.000000000","message":"What if subvolume_size converted to GB is a non-integer GB? For example, 2.5GB.\nI think we should round up. For example, expand 2.5G to 3G","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":552,"context_line":"            LOG.info(\"Subvolume %(subvol)s mode is different from what is \""},{"line_number":553,"context_line":"                     \"configured in Manila.\")"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        subvolume_size \u003d subvolume_info.get(\u0027bytes_quota\u0027)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        # We need to resize infinite subvolumes, as Manila doesn\u0027t support it"},{"line_number":558,"context_line":"        if isinstance(subvolume_size, str) and subvolume_size \u003d\u003d \"infinite\":"}],"source_content_type":"text/x-python","patch_set":7,"id":"90355d23_05aeafce","line":555,"range":{"start_line":555,"start_character":8,"end_line":555,"end_character":58},"in_reply_to":"deaf4328_7efa49df","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        if isinstance(subvolume_size, str) and subvolume_size \u003d\u003d \"infinite\":"},{"line_number":559,"context_line":"            try:"},{"line_number":560,"context_line":"                # Default resize gb must be configured"},{"line_number":561,"context_line":"                new_size \u003d self.configuration.safe_get("},{"line_number":562,"context_line":"                    \u0027cephfs_default_infinite_share_size\u0027"},{"line_number":563,"context_line":"                ) or 0"},{"line_number":564,"context_line":"                if new_size \u003d\u003d 0:"},{"line_number":565,"context_line":"                    msg \u003d (\"subvolume %s has infinite size and no default \""},{"line_number":566,"context_line":"                           \"size value is configured in Manila. Please update \""}],"source_content_type":"text/x-python","patch_set":7,"id":"5be39172_c72c68d0","line":563,"range":{"start_line":561,"start_character":15,"end_line":563,"end_character":22},"updated":"2024-08-27 22:56:42.000000000","message":"please use driver_options, for example: driver_options.get(\"size\") \nif its not provided, log an error and raise an exception","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        if isinstance(subvolume_size, str) and subvolume_size \u003d\u003d \"infinite\":"},{"line_number":559,"context_line":"            try:"},{"line_number":560,"context_line":"                # Default resize gb must be configured"},{"line_number":561,"context_line":"                new_size \u003d self.configuration.safe_get("},{"line_number":562,"context_line":"                    \u0027cephfs_default_infinite_share_size\u0027"},{"line_number":563,"context_line":"                ) or 0"},{"line_number":564,"context_line":"                if new_size \u003d\u003d 0:"},{"line_number":565,"context_line":"                    msg \u003d (\"subvolume %s has infinite size and no default \""},{"line_number":566,"context_line":"                           \"size value is configured in Manila. Please update \""}],"source_content_type":"text/x-python","patch_set":7,"id":"4a569c6d_2fdaa8de","line":563,"range":{"start_line":561,"start_character":15,"end_line":563,"end_character":22},"in_reply_to":"5be39172_c72c68d0","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":569,"context_line":"                    raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"                # Attempt resizing the subvolume"},{"line_number":572,"context_line":"                self._resize_share(share, new_size, no_shrink\u003dTrue)"},{"line_number":573,"context_line":"            except exception.ShareShrinkingPossibleDataLoss:"},{"line_number":574,"context_line":"                msg \u003d (\"Could not resize the subvolume using the default \""},{"line_number":575,"context_line":"                       \"\u0027cephfs_default_infinite_share_size\u0027 config option \""}],"source_content_type":"text/x-python","patch_set":7,"id":"0b46525d_b7f7880d","line":572,"range":{"start_line":572,"start_character":16,"end_line":572,"end_character":67},"updated":"2024-08-27 22:56:42.000000000","message":"after this, set `subvolume_size` to `new_size`","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                    raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"                # Attempt resizing the subvolume"},{"line_number":572,"context_line":"                self._resize_share(share, new_size, no_shrink\u003dTrue)"},{"line_number":573,"context_line":"            except exception.ShareShrinkingPossibleDataLoss:"},{"line_number":574,"context_line":"                msg \u003d (\"Could not resize the subvolume using the default \""},{"line_number":575,"context_line":"                       \"\u0027cephfs_default_infinite_share_size\u0027 config option \""}],"source_content_type":"text/x-python","patch_set":7,"id":"4b674abf_75475358","line":572,"range":{"start_line":572,"start_character":16,"end_line":572,"end_character":67},"in_reply_to":"0b46525d_b7f7880d","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":581,"context_line":"                raise"},{"line_number":582,"context_line":"        else:"},{"line_number":583,"context_line":"            subvolume_size \u003d self._get_subvolume_size_in_gb(subvolume_size)"},{"line_number":584,"context_line":"            if subvolume_size \u003c 1:"},{"line_number":585,"context_line":"                msg \u003d ("},{"line_number":586,"context_line":"                    \"Subvolume %(subvol)s cannot be managed. Its size must be \""},{"line_number":587,"context_line":"                    \"at least 1 gigabyte.\" % {\u0027subvol\u0027: subvolume_name}"},{"line_number":588,"context_line":"                )"},{"line_number":589,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        share_metadata \u003d {\"sub_name\": subvolume_name}"},{"line_number":592,"context_line":"        self.private_storage.update(share[\u0027id\u0027], share_metadata)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1826c14d_250fce36","line":589,"range":{"start_line":584,"start_character":11,"end_line":589,"end_character":62},"updated":"2024-08-27 22:56:42.000000000","message":"Maybe just expand it to 1 GiB","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"66d83dbe585bea7ddd62db4c7f5fb080054c4470","unresolved":true,"context_lines":[{"line_number":581,"context_line":"                raise"},{"line_number":582,"context_line":"        else:"},{"line_number":583,"context_line":"            subvolume_size \u003d self._get_subvolume_size_in_gb(subvolume_size)"},{"line_number":584,"context_line":"            if subvolume_size \u003c 1:"},{"line_number":585,"context_line":"                msg \u003d ("},{"line_number":586,"context_line":"                    \"Subvolume %(subvol)s cannot be managed. Its size must be \""},{"line_number":587,"context_line":"                    \"at least 1 gigabyte.\" % {\u0027subvol\u0027: subvolume_name}"},{"line_number":588,"context_line":"                )"},{"line_number":589,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        share_metadata \u003d {\"sub_name\": subvolume_name}"},{"line_number":592,"context_line":"        self.private_storage.update(share[\u0027id\u0027], share_metadata)"}],"source_content_type":"text/x-python","patch_set":7,"id":"80b1adf6_4041ef41","line":589,"range":{"start_line":584,"start_character":11,"end_line":589,"end_character":62},"in_reply_to":"1826c14d_250fce36","updated":"2024-08-28 09:12:49.000000000","message":"+1","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":581,"context_line":"                raise"},{"line_number":582,"context_line":"        else:"},{"line_number":583,"context_line":"            subvolume_size \u003d self._get_subvolume_size_in_gb(subvolume_size)"},{"line_number":584,"context_line":"            if subvolume_size \u003c 1:"},{"line_number":585,"context_line":"                msg \u003d ("},{"line_number":586,"context_line":"                    \"Subvolume %(subvol)s cannot be managed. Its size must be \""},{"line_number":587,"context_line":"                    \"at least 1 gigabyte.\" % {\u0027subvol\u0027: subvolume_name}"},{"line_number":588,"context_line":"                )"},{"line_number":589,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        share_metadata \u003d {\"sub_name\": subvolume_name}"},{"line_number":592,"context_line":"        self.private_storage.update(share[\u0027id\u0027], share_metadata)"}],"source_content_type":"text/x-python","patch_set":7,"id":"8faf9a59_c7bb55f9","line":589,"range":{"start_line":584,"start_character":11,"end_line":589,"end_character":62},"in_reply_to":"80b1adf6_4041ef41","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":594,"context_line":"        export_locations \u003d self._get_export_locations("},{"line_number":595,"context_line":"            share, subvolume_name\u003dsubvolume_name"},{"line_number":596,"context_line":"        )"},{"line_number":597,"context_line":"        export_locations \u003d ("},{"line_number":598,"context_line":"            export_locations"},{"line_number":599,"context_line":"            if isinstance(export_locations, list)"},{"line_number":600,"context_line":"            else [export_locations]"},{"line_number":601,"context_line":"        )"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        managed_share \u003d {"},{"line_number":604,"context_line":"            \"size\": subvolume_size,"}],"source_content_type":"text/x-python","patch_set":7,"id":"be2a4f5a_4329a16a","line":601,"range":{"start_line":597,"start_character":8,"end_line":601,"end_character":9},"updated":"2024-08-27 22:56:42.000000000","message":"We don\u0027t need this.. \n\n_get_export_locations invokes \"get_export_locations\" from the protocol helpers, each of which do return a list:\n\nNative CephFS:\nhttps://opendev.org/openstack/manila/src/commit/4bf505404ae77a230f79841797e0ee41d2ada414/manila/share/drivers/cephfs/driver.py#L861-L876\n\nNFS:\nhttps://opendev.org/openstack/manila/src/commit/4bf505404ae77a230f79841797e0ee41d2ada414/manila/share/drivers/cephfs/driver.py#L1046-L1075","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        export_locations \u003d self._get_export_locations("},{"line_number":595,"context_line":"            share, subvolume_name\u003dsubvolume_name"},{"line_number":596,"context_line":"        )"},{"line_number":597,"context_line":"        export_locations \u003d ("},{"line_number":598,"context_line":"            export_locations"},{"line_number":599,"context_line":"            if isinstance(export_locations, list)"},{"line_number":600,"context_line":"            else [export_locations]"},{"line_number":601,"context_line":"        )"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        managed_share \u003d {"},{"line_number":604,"context_line":"            \"size\": subvolume_size,"}],"source_content_type":"text/x-python","patch_set":7,"id":"2291592c_0fc57170","line":601,"range":{"start_line":597,"start_character":8,"end_line":601,"end_character":9},"in_reply_to":"be2a4f5a_4329a16a","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":606,"context_line":"        }"},{"line_number":607,"context_line":"        return managed_share"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def manage_existing_snapshot(self, snapshot_instance, driver_options):"},{"line_number":610,"context_line":"        # bring FS subvolume/share under manila management"},{"line_number":611,"context_line":"        LOG.debug(\"[%(be)s]: manage_existing_snapshot: id\u003d%(id)s.\","},{"line_number":612,"context_line":"                  {\"be\": self.backend_name, \"id\": snapshot_instance[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":7,"id":"abc3e4f9_2a2c98f0","line":609,"range":{"start_line":609,"start_character":39,"end_line":609,"end_character":56},"updated":"2024-08-27 22:56:42.000000000","message":"for all practical purposes, treat this is as the \"snapshot\".. don\u0027t need to call it an instance here.","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        }"},{"line_number":607,"context_line":"        return managed_share"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def manage_existing_snapshot(self, snapshot_instance, driver_options):"},{"line_number":610,"context_line":"        # bring FS subvolume/share under manila management"},{"line_number":611,"context_line":"        LOG.debug(\"[%(be)s]: manage_existing_snapshot: id\u003d%(id)s.\","},{"line_number":612,"context_line":"                  {\"be\": self.backend_name, \"id\": snapshot_instance[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7430eb4f_fd533824","line":609,"range":{"start_line":609,"start_character":39,"end_line":609,"end_character":56},"in_reply_to":"abc3e4f9_2a2c98f0","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":616,"context_line":"        if not sub_snapshot_name:"},{"line_number":617,"context_line":"            raise exception.ShareBackendException("},{"line_number":618,"context_line":"                \"The subvolume snapshot name must be provided as a driver \""},{"line_number":619,"context_line":"                \"option while managing shares.\")"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        sub_name \u003d self._get_sub_name(snapshot_instance[\u0027share_instance_id\u0027])"},{"line_number":622,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"de16eb8e_1cbea11d","line":619,"range":{"start_line":619,"start_character":39,"end_line":619,"end_character":45},"updated":"2024-08-27 22:56:42.000000000","message":"s/shares/snapshots","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":615,"context_line":"        sub_snapshot_name \u003d snapshot_instance.get(\u0027provider_location\u0027, None)"},{"line_number":616,"context_line":"        if not sub_snapshot_name:"},{"line_number":617,"context_line":"            raise exception.ShareBackendException("},{"line_number":618,"context_line":"                \"The subvolume snapshot name must be provided as a driver \""},{"line_number":619,"context_line":"                \"option while managing shares.\")"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        sub_name \u003d self._get_sub_name(snapshot_instance[\u0027share_instance_id\u0027])"},{"line_number":622,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"e9cf3e5c_77bf2cb7","line":619,"range":{"start_line":618,"start_character":65,"end_line":619,"end_character":23},"updated":"2024-08-27 22:56:42.000000000","message":"the \"provider_location\"","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        if not sub_snapshot_name:"},{"line_number":617,"context_line":"            raise exception.ShareBackendException("},{"line_number":618,"context_line":"                \"The subvolume snapshot name must be provided as a driver \""},{"line_number":619,"context_line":"                \"option while managing shares.\")"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        sub_name \u003d self._get_sub_name(snapshot_instance[\u0027share_instance_id\u0027])"},{"line_number":622,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"4583260a_5a75f1b3","line":619,"range":{"start_line":619,"start_character":39,"end_line":619,"end_character":45},"in_reply_to":"de16eb8e_1cbea11d","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        sub_snapshot_name \u003d snapshot_instance.get(\u0027provider_location\u0027, None)"},{"line_number":616,"context_line":"        if not sub_snapshot_name:"},{"line_number":617,"context_line":"            raise exception.ShareBackendException("},{"line_number":618,"context_line":"                \"The subvolume snapshot name must be provided as a driver \""},{"line_number":619,"context_line":"                \"option while managing shares.\")"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        sub_name \u003d self._get_sub_name(snapshot_instance[\u0027share_instance_id\u0027])"},{"line_number":622,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6f2849e5_32b4e6f8","line":619,"range":{"start_line":618,"start_character":65,"end_line":619,"end_character":23},"in_reply_to":"e9cf3e5c_77bf2cb7","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":645,"context_line":"        # Shares/subvolumes already managed by manila will never have"},{"line_number":646,"context_line":"        # infinite as their bytes_quota, so no need for extra precaution."},{"line_number":647,"context_line":"        try:"},{"line_number":648,"context_line":"            rados_command("},{"line_number":649,"context_line":"                self.rados_client, \"fs subvolume snapshot info\","},{"line_number":650,"context_line":"                sub_snap_info_argdict, json_obj\u003dTrue"},{"line_number":651,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":7,"id":"276d5541_6ef6b5aa","line":648,"range":{"start_line":648,"start_character":12,"end_line":648,"end_character":25},"updated":"2024-08-27 22:56:42.000000000","message":"managed_subvolume_snapshot \u003d \n\n(grab the return value, we need it when Ceph provides the size)","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        # Shares/subvolumes already managed by manila will never have"},{"line_number":646,"context_line":"        # infinite as their bytes_quota, so no need for extra precaution."},{"line_number":647,"context_line":"        try:"},{"line_number":648,"context_line":"            rados_command("},{"line_number":649,"context_line":"                self.rados_client, \"fs subvolume snapshot info\","},{"line_number":650,"context_line":"                sub_snap_info_argdict, json_obj\u003dTrue"},{"line_number":651,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":7,"id":"02ba0bfa_9d89f1e9","line":648,"range":{"start_line":648,"start_character":12,"end_line":648,"end_character":25},"in_reply_to":"276d5541_6ef6b5aa","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        snapshot_metadata \u003d {\"snap_name\": sub_snapshot_name}"},{"line_number":660,"context_line":"        self.private_storage.update("},{"line_number":661,"context_line":"            snapshot_instance[\u0027snapshot_id\u0027], snapshot_metadata"},{"line_number":662,"context_line":"        )"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        # NOTE(carloss): fs subvolume snapshot info command does not return"}],"source_content_type":"text/x-python","patch_set":7,"id":"b0f0dc04_afade5e0","line":661,"range":{"start_line":661,"start_character":31,"end_line":661,"end_character":42},"updated":"2024-08-27 22:56:42.000000000","message":"[\u0027id\u0027] would suffice?\nWith the CephFS driver, until we implement replication, there\u0027ll be a 1-1 relationship between a snapshot and snapshot instance; but, we could use \"id\" here for consistency","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4646df031294e9e1e5b05eaa416254607b24e97a","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        snapshot_metadata \u003d {\"snap_name\": sub_snapshot_name}"},{"line_number":660,"context_line":"        self.private_storage.update("},{"line_number":661,"context_line":"            snapshot_instance[\u0027snapshot_id\u0027], snapshot_metadata"},{"line_number":662,"context_line":"        )"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        # NOTE(carloss): fs subvolume snapshot info command does not return"}],"source_content_type":"text/x-python","patch_set":7,"id":"999137bb_173dcd18","line":661,"range":{"start_line":661,"start_character":31,"end_line":661,"end_character":42},"in_reply_to":"86cd514f_c312f399","updated":"2024-08-30 05:35:29.000000000","message":"Ah; I remember Ramana Raja\u0027s argument that we\u0027d not implement snapshot instances any time soon :/ \n\nbut good point.","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":true,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        snapshot_metadata \u003d {\"snap_name\": sub_snapshot_name}"},{"line_number":660,"context_line":"        self.private_storage.update("},{"line_number":661,"context_line":"            snapshot_instance[\u0027snapshot_id\u0027], snapshot_metadata"},{"line_number":662,"context_line":"        )"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        # NOTE(carloss): fs subvolume snapshot info command does not return"}],"source_content_type":"text/x-python","patch_set":7,"id":"86cd514f_c312f399","line":661,"range":{"start_line":661,"start_character":31,"end_line":661,"end_character":42},"in_reply_to":"b0f0dc04_afade5e0","updated":"2024-08-28 21:18:24.000000000","message":"Actually just trying to keep consistency with the current snapshot creation: https://github.com/openstack/manila/blob/master/manila/share/drivers/cephfs/driver.py#L641\n\nWhen we create snapshots, we go set its name to the snapshot_id, so just trying to keep consistency even in the private storage layer.","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6db196af21237cdac2f1163e77e6cc95d074dffc","unresolved":true,"context_lines":[{"line_number":664,"context_line":"        # NOTE(carloss): fs subvolume snapshot info command does not return"},{"line_number":665,"context_line":"        # the snapshot size, so we reuse the share size until this is not"},{"line_number":666,"context_line":"        # available for us."},{"line_number":667,"context_line":"        subvolume_size \u003d self._get_subvolume_size_in_gb("},{"line_number":668,"context_line":"            subvolume_info.get(\u0027bytes_quota\u0027)"},{"line_number":669,"context_line":"        )"},{"line_number":670,"context_line":"        managed_snapshot \u003d {"},{"line_number":671,"context_line":"            \"size\": subvolume_size,"},{"line_number":672,"context_line":"            \"provider_location\": sub_snapshot_name"}],"source_content_type":"text/x-python","patch_set":7,"id":"be9cef40_0b563d32","line":669,"range":{"start_line":667,"start_character":8,"end_line":669,"end_character":9},"updated":"2024-08-27 22:56:42.000000000","message":"no need to do this; the manager already does: https://opendev.org/openstack/manila/src/commit/4bf505404ae77a230f79841797e0ee41d2ada414/manila/share/manager.py#L3034-L3039\n\n\ndo this instead:\n\n```\nmanaged_snapshot \u003d {\u0027provider_location\u0027: sub_snapshot_name}\nif managed_subvolume_snapshot.get(\u0027bytes_quota\u0027) is not None:\n   managed_snapshot[\u0027size\u0027] \u003d self._get_subvolume_size_in_gb(managed_subvolume_snapshot[\u0027bytes_quota\u0027])\n   \n\n```","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"53fabe922e931ef2c9a2b8db732876b8b70ca531","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        # NOTE(carloss): fs subvolume snapshot info command does not return"},{"line_number":665,"context_line":"        # the snapshot size, so we reuse the share size until this is not"},{"line_number":666,"context_line":"        # available for us."},{"line_number":667,"context_line":"        subvolume_size \u003d self._get_subvolume_size_in_gb("},{"line_number":668,"context_line":"            subvolume_info.get(\u0027bytes_quota\u0027)"},{"line_number":669,"context_line":"        )"},{"line_number":670,"context_line":"        managed_snapshot \u003d {"},{"line_number":671,"context_line":"            \"size\": subvolume_size,"},{"line_number":672,"context_line":"            \"provider_location\": sub_snapshot_name"}],"source_content_type":"text/x-python","patch_set":7,"id":"2e3f781f_4ad92bac","line":669,"range":{"start_line":667,"start_character":8,"end_line":669,"end_character":9},"in_reply_to":"be9cef40_0b563d32","updated":"2024-08-28 21:18:24.000000000","message":"Done","commit_id":"4f43f7ba859633dc9250e56e1699efcd178fa763"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d6125ac33d48589b99dff4891b86c22c419d0f67","unresolved":true,"context_lines":[{"line_number":577,"context_line":"            except exception.ShareBackendException:"},{"line_number":578,"context_line":"                raise"},{"line_number":579,"context_line":"        else:"},{"line_number":580,"context_line":"            current_subvolume_size \u003d round(int(subvolume_size) / units.Gi, 2)"},{"line_number":581,"context_line":"            if current_subvolume_size \u003c 1:"},{"line_number":582,"context_line":"                new_size \u003d 1"},{"line_number":583,"context_line":"                LOG.info("},{"line_number":584,"context_line":"                    \"Subvolume %(subvol)s is being resized to %(new_size)s \""},{"line_number":585,"context_line":"                    \"GB.\", {"},{"line_number":586,"context_line":"                        \u0027subvol\u0027: subvolume_name,"},{"line_number":587,"context_line":"                        \u0027new_size\u0027: new_size"},{"line_number":588,"context_line":"                    }"},{"line_number":589,"context_line":"                )"},{"line_number":590,"context_line":"                self._resize_share(share, new_size, no_shrink\u003dTrue)"},{"line_number":591,"context_line":"                subvolume_size \u003d new_size"},{"line_number":592,"context_line":"            else:"},{"line_number":593,"context_line":"                subvolume_size \u003d self._get_subvolume_size_in_gb(subvolume_size)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        share_metadata \u003d {\"subvolume_name\": subvolume_name}"},{"line_number":596,"context_line":"        self.private_storage.update(share[\u0027id\u0027], share_metadata)"}],"source_content_type":"text/x-python","patch_set":9,"id":"296d8950_8889cb57","line":593,"range":{"start_line":580,"start_character":12,"end_line":593,"end_character":79},"updated":"2024-08-29 02:38:17.000000000","message":"The current logic resize 0.5G to 1G, but 2.5G does not resize to 3G. I think it can be written as follows:\n\n            if int(subvolume_size) % units.Gi \u003d\u003d 0:\n                # subvolume_size is an integer GB, no need to resize subvolume\n                subvolume_size \u003d self._get_subvolume_size_in_gb(subvolume_size)\n            else:\n                # subvolume size is not an integer GB. need to resize subvolume\n                new_size_gb \u003d self._get_subvolume_size_in_gb(subvolume_size)\n                LOG.info(\n                    \"Subvolume %(subvol)s is being resized to %(new_size)s \"\n                    \"GB.\", {\n                        \u0027subvol\u0027: subvolume_name,\n                        \u0027new_size\u0027: new_size_gb\n                    }\n                )\n                self._resize_share(share, new_size_gb, no_shrink\u003dTrue)\n                subvolume_size \u003d new_size_gb","commit_id":"b26092250eb8c47b262c4372b755ea2fb72330c2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e2fcbef0c63a3554f26719bbcd941bd728555066","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            except exception.ShareBackendException:"},{"line_number":578,"context_line":"                raise"},{"line_number":579,"context_line":"        else:"},{"line_number":580,"context_line":"            current_subvolume_size \u003d round(int(subvolume_size) / units.Gi, 2)"},{"line_number":581,"context_line":"            if current_subvolume_size \u003c 1:"},{"line_number":582,"context_line":"                new_size \u003d 1"},{"line_number":583,"context_line":"                LOG.info("},{"line_number":584,"context_line":"                    \"Subvolume %(subvol)s is being resized to %(new_size)s \""},{"line_number":585,"context_line":"                    \"GB.\", {"},{"line_number":586,"context_line":"                        \u0027subvol\u0027: subvolume_name,"},{"line_number":587,"context_line":"                        \u0027new_size\u0027: new_size"},{"line_number":588,"context_line":"                    }"},{"line_number":589,"context_line":"                )"},{"line_number":590,"context_line":"                self._resize_share(share, new_size, no_shrink\u003dTrue)"},{"line_number":591,"context_line":"                subvolume_size \u003d new_size"},{"line_number":592,"context_line":"            else:"},{"line_number":593,"context_line":"                subvolume_size \u003d self._get_subvolume_size_in_gb(subvolume_size)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        share_metadata \u003d {\"subvolume_name\": subvolume_name}"},{"line_number":596,"context_line":"        self.private_storage.update(share[\u0027id\u0027], share_metadata)"}],"source_content_type":"text/x-python","patch_set":9,"id":"073e74e5_8e321b73","line":593,"range":{"start_line":580,"start_character":12,"end_line":593,"end_character":79},"in_reply_to":"296d8950_8889cb57","updated":"2024-08-29 14:13:16.000000000","message":"Done. Good catch, thank you! :D","commit_id":"b26092250eb8c47b262c4372b755ea2fb72330c2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4646df031294e9e1e5b05eaa416254607b24e97a","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        # Check if share mode matches"},{"line_number":550,"context_line":"        if subvolume_info.get(\u0027mode\u0027) !\u003d self._cephfs_volume_mode:"},{"line_number":551,"context_line":"            LOG.info(\"Subvolume %(subvol)s mode is different from what is \""},{"line_number":552,"context_line":"                     \"configured in Manila.\")"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        subvolume_size \u003d subvolume_info.get(\u0027bytes_quota\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5b0d4c4f_3537774e","line":551,"range":{"start_line":551,"start_character":43,"end_line":551,"end_character":60},"updated":"2024-08-30 05:35:29.000000000","message":"maybe log the mode. \n\nI suspect this will become a bug/RFE in the future.. but we\u0027ll see if someone needs the driver to ensure the mode configured in manila","commit_id":"30281a646c9c53a31207af499b35c61084e77e1c"}]}