)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c393e178094432398e6d895c4d1ac220ce98eb0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[netapp] set last-transfer-size limit to a large value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9026bff1_aed6fa99","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":68},"updated":"2024-08-26 22:30:10.000000000","message":"Is this a bug in the driver? or ONTAP?","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"d37dd46f8f88b7d56932b39e8f7b7c16628042a3","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[netapp] set last-transfer-size limit to a large value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fd8981a3_ba45c2cb","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":68},"in_reply_to":"9026bff1_aed6fa99","updated":"2024-08-29 14:02:26.000000000","message":"The check is in the ONTAP driver, in the update_replica_state() function, https://github.com/openstack/manila/blob/52d423f6061e707d3bd969354769014ed4847e0d/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L2755-L2756","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"ee133aba63583746e65ec3ff54cdbf85ff89332a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[netapp] set last-transfer-size limit to a large value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a89a31bd_b6781fa5","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":68},"in_reply_to":"fd8981a3_ba45c2cb","updated":"2024-10-02 07:29:23.000000000","message":"Done","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"6d2f393373f85f315f1e78fa55f3757bbcd3da67","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[netapp] set last-transfer-size limit to a large value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"697a0733_b8369ea1","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"updated":"2024-08-14 08:41:31.000000000","message":"Replicas","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"ee133aba63583746e65ec3ff54cdbf85ff89332a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[netapp] set last-transfer-size limit to a large value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d95b90d9_e0ba1b8b","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"in_reply_to":"697a0733_b8369ea1","updated":"2024-10-02 07:29:23.000000000","message":"Done","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c393e178094432398e6d895c4d1ac220ce98eb0","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2066031"},{"line_number":15,"context_line":"Change-Id: I05d2e7c72c04f941182accf8e68102ccea1d6b99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5764632c_c6460a95","line":12,"range":{"start_line":11,"start_character":17,"end_line":12,"end_character":52},"updated":"2024-08-26 22:30:10.000000000","message":"So why have this check remain in the driver at all?\n\nI prefer that we drop this check if it is erraneous.. Were you looking for feedback from NetApp maintainers?","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"d37dd46f8f88b7d56932b39e8f7b7c16628042a3","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2066031"},{"line_number":15,"context_line":"Change-Id: I05d2e7c72c04f941182accf8e68102ccea1d6b99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8031bebf_c3f72363","line":12,"range":{"start_line":11,"start_character":17,"end_line":12,"end_character":52},"in_reply_to":"5764632c_c6460a95","updated":"2024-08-29 14:02:26.000000000","message":"Only had a short discussion in manila meeting, https://meetings.opendev.org/meetings/manila/2024/manila.2024-05-23-15.00.log.txt\nI could update this PR to drop the check if you prefer","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"343984c65ba7ddd54c69ba664ff9a83ed1c1da12","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2066031"},{"line_number":15,"context_line":"Change-Id: I05d2e7c72c04f941182accf8e68102ccea1d6b99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ee395abc_564a7fbd","line":12,"range":{"start_line":11,"start_character":17,"end_line":12,"end_character":52},"in_reply_to":"8031bebf_c3f72363","updated":"2024-08-29 23:08:43.000000000","message":"Yes, I think dropping it is better than keeping effectively dead code; but am certainly not a NetApp expert.. lets have some NetApp maintainers chime in.","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"ee133aba63583746e65ec3ff54cdbf85ff89332a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2066031"},{"line_number":15,"context_line":"Change-Id: I05d2e7c72c04f941182accf8e68102ccea1d6b99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"05790b50_0eab8931","line":12,"range":{"start_line":11,"start_character":17,"end_line":12,"end_character":52},"in_reply_to":"e2bfdb73_a47a4240","updated":"2024-10-02 07:29:23.000000000","message":"Done","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"84ac0a322f30616f7181452976c6c68294d4c2c0","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last-transfer-size check has not worked very well in production."},{"line_number":10,"context_line":"Relicas with frequent data changes always stay in \u0027out-of-sync\u0027 for its"},{"line_number":11,"context_line":"\u0027replica_state\u0027. We set the default value of the driver option"},{"line_number":12,"context_line":"\u0027netapp_snapmirror_last_transfer_size_limit\u0027 to 1PB."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2066031"},{"line_number":15,"context_line":"Change-Id: I05d2e7c72c04f941182accf8e68102ccea1d6b99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e2bfdb73_a47a4240","line":12,"range":{"start_line":11,"start_character":17,"end_line":12,"end_character":52},"in_reply_to":"ee395abc_564a7fbd","updated":"2024-09-11 15:46:41.000000000","message":"I\u0027ll discuss with team and will update on this by tomorrow. This is old code, even I need to understand why this condition is require.","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"6064989f14378d7785d7396fffaf4e4b3a963db3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93f118f9_b55e6912","updated":"2024-09-30 09:33:12.000000000","message":"Change to removing the check","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9ebfdf6962d33532fc2ad9ad01ee2a615566fb68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7fc9e93b_a306ba7f","updated":"2024-08-20 19:32:03.000000000","message":"LGTM, thank you for the fix!","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"6d2f393373f85f315f1e78fa55f3757bbcd3da67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"822e0f1e_aa0921d4","updated":"2024-08-14 08:41:31.000000000","message":"LGTM, we did this in our environment","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c393e178094432398e6d895c4d1ac220ce98eb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d88dae7e_4a03b84e","updated":"2024-08-26 22:30:10.000000000","message":"Thank you for the bug report and the fix, Chuan.. I don\u0027t agree with the change, please see comments inline..","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d08b6066c00613b8259924d69cb6a2d3b5a2ad1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"500bc55a_dc247bf6","updated":"2024-09-30 15:35:06.000000000","message":"Hi @chuan137@gmail.com; thanks for updating this; a comment inline regarding the release note","commit_id":"c93cc42d800ebe7cf3522c101fbaa97f20ba5882"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"89041870e949c3acbf88c6c511623f6f7d5d9f57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d10bc65_7b2f13c2","updated":"2024-10-01 10:42:49.000000000","message":"LGTM ..!","commit_id":"c93cc42d800ebe7cf3522c101fbaa97f20ba5882"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"ee133aba63583746e65ec3ff54cdbf85ff89332a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d53a15bf_1122bfe4","updated":"2024-10-02 07:29:23.000000000","message":"update commit message","commit_id":"21a49881bd1235f1386e267abd9d42a1dcda27cd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4114f6dfa45614ae2565b18376d1541cb927074","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"594f1177_de04f85a","updated":"2024-10-07 18:57:55.000000000","message":"Thanks Chuan! LGTM. \n\nNetApp CI is still broken.. but, Gireesh +1\u0027ed PS#3; and we\u0027ve only had release note changes since..","commit_id":"f46ec7b82e0eddcd3952fc6ec93af6cffe19c412"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"25779cd4c0d0a4039c721668845a21b24658e9b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"784ba203_039b75f0","updated":"2024-10-07 20:58:27.000000000","message":"recheck\n\nduplicate access rule issue with test_create_replica_add_access_rule_delete_replica","commit_id":"f46ec7b82e0eddcd3952fc6ec93af6cffe19c412"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c393e178094432398e6d895c4d1ac220ce98eb0","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b2054e6_8b4c7d49","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"updated":"2024-08-26 22:30:10.000000000","message":"Updating the default value may cause silent issues when someone upgrades.. If you\u0027ve been able to do this in your environment to achieve the desired result, I\u0027d just leave the default alone..","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"324a028a97713d68c3971ad4658aa8259b867757","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ed432339_37123065","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"in_reply_to":"04feac19_d4a96a3a","updated":"2024-09-10 09:06:39.000000000","message":"You are talking about below code ..?\n\nconfig_size \u003d (int(config.safe_get(\n            \u0027netapp_snapmirror_last_transfer_size_limit\u0027)) * units.Ki)\n        last_transfer_size \u003d int(snapmirror.get(\u0027last-transfer-size\u0027, 0))\n        if last_transfer_size \u003e config_size:\n            return constants.REPLICA_STATE_OUT_OF_SYNC\n            \nYou don\u0027t wanted to execute above if condition in your environment, if yes, you can achieve this by setting \"netapp_snapmirror_last_transfer_size_limit\" value in manila.conf file.\n\nJust wanted to understand what is use-case of setting default value to \"1099511627776\"","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"574ec102f8349be7c315d1608e0b16b44d283628","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fbbb45e_ee0de025","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"in_reply_to":"1b2054e6_8b4c7d49","updated":"2024-09-03 16:06:26.000000000","message":"Agree with Goutham, user set this value in manila.conf file as per his environment and requirement.","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"6a77b8269e97453dda3e59051029a17371f9fefd","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"04feac19_d4a96a3a","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"in_reply_to":"5fbbb45e_ee0de025","updated":"2024-09-04 08:20:39.000000000","message":"we could also drop the check and setting, what do you think?","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"97ce7924ebee54832355e888d74c914ff009d368","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dad72a13_9943f976","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"in_reply_to":"64535b72_14f90852","updated":"2024-09-11 08:46:48.000000000","message":"A replication being \u0027in-sync\u0027 means: snapmirror is healthy and working (and implicitly also: data has been transferred to target within rpo (!)).\n\nWe mistakenly thought that a small last transfer means that the target is pretty much up to date, because not much data had to be carried over. We want to correct that mistake.\n\nHaving a big last transfer just means: there have been a lot of changes. Okay, fine - having a lot of changes above a limit does not mean that the replication is unhealthy. Seeing a big number at the target is not a bad sign, it means the big chunk of changes made it over to the target, hooray.\n\nA better indicator is the last transfer end time: i.e. is the transfer still running or was the data successfully transferred? We have that already. Also we are checking for last transfer error.\n\nNote: even replica resync for NetApp just means to re-establish a broken snapmirror. It does not mean: snapmirror update and force a transfer. So you would not be able to get out of the \u0027out-of-sync because of big last transfer\u0027 condition on your own, you would have to wait for the next regular transfer and hope that it is small enough :)","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"6064989f14378d7785d7396fffaf4e4b3a963db3","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5e47f054_ece0a94b","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"in_reply_to":"d021e076_085ce750","updated":"2024-09-30 09:33:12.000000000","message":"Done","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"117f247c394bb44d3c562e94e35673cd1c10da1e","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"e0a9ce50_acebcb6a","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"in_reply_to":"dad72a13_9943f976","updated":"2024-09-11 16:03:45.000000000","message":"\u003e A better indicator is the last transfer end time: i.e. is the transfer still running or was the data successfully transferred? We have that already. Also we are checking for last transfer error.\n\n\nI agree!\nIs this check sufficient, and working well in your environment? \n\nhttps://opendev.org/openstack/manila/src/commit/84ab5df84a9de4ad6df1fa31b95b0b9503ec1572/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L2874-L2883","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a8626d8775a13b97ba1135a43377a13323d46019","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"d021e076_085ce750","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"in_reply_to":"e0a9ce50_acebcb6a","updated":"2024-09-11 17:26:31.000000000","message":"I looked into the replica code and for me below 2 condition is sufficient to make sure replica is out of sync \n1. mirror.get(\u0027relationship-status\u0027) !\u003d idea, we are checking this initially but different way\n2. mirror.get(\u0027is-healthy\u0027): False or checking the last_transfer_error.\n\nIn my opinion, setting the replica out of sync based on the condition below doesn\u0027t make sense for me also.\nif last_transfer_size \u003e config_size:\nreturn constants.REPLICA_STATE_OUT_OF_SYNC\n\nI agree with Maurice and Goutham, that the last transfer end time.. and last transfer error are enough to check whether the replica is out of sync or not.\nI am fine with removing the above condition.","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46bc965a5f6a266d68f98a4cd3a721e4ee6f2810","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                    \u0027a replica\u0027),"},{"line_number":253,"context_line":"    cfg.IntOpt(\u0027netapp_snapmirror_last_transfer_size_limit\u0027,"},{"line_number":254,"context_line":"               min\u003d512,"},{"line_number":255,"context_line":"               default\u003d1099511627776,  # One PB"},{"line_number":256,"context_line":"               help\u003d\u0027This option set the last transfer size limit (in KB) \u0027"},{"line_number":257,"context_line":"                    \u0027of snapmirror to decide whether replica is in sync or \u0027"},{"line_number":258,"context_line":"                    \u0027out of sync.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"64535b72_14f90852","line":255,"range":{"start_line":255,"start_character":23,"end_line":255,"end_character":36},"in_reply_to":"ed432339_37123065","updated":"2024-09-10 22:00:47.000000000","message":"Gireesh:\n\nthis size check is one of many checks that the driver does to determine if a replica is \"in-sync\"\n https://opendev.org/openstack/manila/src/commit/84ab5df84a9de4ad6df1fa31b95b0b9503ec1572/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L2885-L2892 \n\nChuan notes that this isn\u0027t working well in production on shares with frequent data changes. Do you know why that might be? I do think checking \"size\" is a crude measure.. I mean that files can be added/modified/deleted creating substantial changes to the size.. \n\nmaaaybe this is an ONTAP issue? And the driver is expecting something that ONTAP doesn\u0027t promise?","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"}],"releasenotes/notes/netapp-remove-last-transfer-size-limit-check-ec66035ff30ad70b.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d08b6066c00613b8259924d69cb6a2d3b5a2ad1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the check for the last transfer size during updating replica state in"},{"line_number":5,"context_line":"    the ONTAP driver. Also remove the corresponding option"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"20f57d50_f5621b93","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2024-09-30 15:35:06.000000000","message":"upgrade\n\n\nOption deprecations and removals affect upgrades","commit_id":"c93cc42d800ebe7cf3522c101fbaa97f20ba5882"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"23add2c0c629292f1111f070563cce320b70e17d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the check for the last transfer size during updating replica state in"},{"line_number":5,"context_line":"    the ONTAP driver. Also remove the corresponding option"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ca4619b7_2970ba53","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"20f57d50_f5621b93","updated":"2024-10-02 07:23:55.000000000","message":"Done","commit_id":"c93cc42d800ebe7cf3522c101fbaa97f20ba5882"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d08b6066c00613b8259924d69cb6a2d3b5a2ad1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the check for the last transfer size during updating replica state in"},{"line_number":5,"context_line":"    the ONTAP driver. Also remove the corresponding option"},{"line_number":6,"context_line":"    `netapp_snapmirror_last_transfer_size_limit`."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"480330a8_203aa593","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"updated":"2024-09-30 15:35:06.000000000","message":"Removed","commit_id":"c93cc42d800ebe7cf3522c101fbaa97f20ba5882"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"23add2c0c629292f1111f070563cce320b70e17d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the check for the last transfer size during updating replica state in"},{"line_number":5,"context_line":"    the ONTAP driver. Also remove the corresponding option"},{"line_number":6,"context_line":"    `netapp_snapmirror_last_transfer_size_limit`."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dc81f531_2d86bdce","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"in_reply_to":"480330a8_203aa593","updated":"2024-10-02 07:23:55.000000000","message":"Done","commit_id":"c93cc42d800ebe7cf3522c101fbaa97f20ba5882"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d08b6066c00613b8259924d69cb6a2d3b5a2ad1d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the check for the last transfer size during updating replica state in"},{"line_number":5,"context_line":"    the ONTAP driver. Also remove the corresponding option"},{"line_number":6,"context_line":"    `netapp_snapmirror_last_transfer_size_limit`."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"85c884f0_21776772","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":33},"updated":"2024-09-30 15:35:06.000000000","message":"removed","commit_id":"c93cc42d800ebe7cf3522c101fbaa97f20ba5882"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"23add2c0c629292f1111f070563cce320b70e17d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the check for the last transfer size during updating replica state in"},{"line_number":5,"context_line":"    the ONTAP driver. Also remove the corresponding option"},{"line_number":6,"context_line":"    `netapp_snapmirror_last_transfer_size_limit`."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ee21f31e_990220fc","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":33},"in_reply_to":"85c884f0_21776772","updated":"2024-10-02 07:23:55.000000000","message":"Done","commit_id":"c93cc42d800ebe7cf3522c101fbaa97f20ba5882"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"405238ecbe8d8d1243c79906370bfaa97ce433ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Option deprecations and removals affect upgrades. Removed the check for the"},{"line_number":5,"context_line":"    last transfer size during updating replica state in the ONTAP driver. Also"},{"line_number":6,"context_line":"    removed the corresponding option"},{"line_number":7,"context_line":"    `netapp_snapmirror_last_transfer_size_limit`."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9be36992_efa9c0fc","line":4,"updated":"2024-10-02 08:09:30.000000000","message":"Remove --\u003e Option deprecations and removals affect upgrades. \nAlso add bug reference in releasenotes.","commit_id":"21a49881bd1235f1386e267abd9d42a1dcda27cd"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"a671520c361316bb0fd21d311f32c87e1e9eaa89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Option deprecations and removals affect upgrades. Removed the check for the"},{"line_number":5,"context_line":"    last transfer size during updating replica state in the ONTAP driver. Also"},{"line_number":6,"context_line":"    removed the corresponding option"},{"line_number":7,"context_line":"    `netapp_snapmirror_last_transfer_size_limit`."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"21b2d3e9_c82efb6b","line":4,"in_reply_to":"9be36992_efa9c0fc","updated":"2024-10-05 11:30:25.000000000","message":"Done","commit_id":"21a49881bd1235f1386e267abd9d42a1dcda27cd"}],"releasenotes/notes/netapp-set-default-last-transfer-size-limit-ec66035ff30ad70b.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c393e178094432398e6d895c4d1ac220ce98eb0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set the default value of the `netapp_snapmirror_last_transfer_size_limit`"},{"line_number":5,"context_line":"    option to 1PB. The previous default value was 1MB. Using a large value"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1858a399_92d74041","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2024-08-26 22:30:10.000000000","message":"upgrade","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"ee133aba63583746e65ec3ff54cdbf85ff89332a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set the default value of the `netapp_snapmirror_last_transfer_size_limit`"},{"line_number":5,"context_line":"    option to 1PB. The previous default value was 1MB. Using a large value"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5c9e330c_30256601","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"1858a399_92d74041","updated":"2024-10-02 07:29:23.000000000","message":"Done","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c393e178094432398e6d895c4d1ac220ce98eb0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set the default value of the `netapp_snapmirror_last_transfer_size_limit`"},{"line_number":5,"context_line":"    option to 1PB. The previous default value was 1MB. Using a large value"},{"line_number":6,"context_line":"    effectively disables the check for the last transfer size limit during"},{"line_number":7,"context_line":"    updating replica state."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f6e88380_4e19cb06","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":18},"updated":"2024-08-26 22:30:10.000000000","message":"```suggestion\n    The default value of the `netapp_snapmirror_last_transfer_size_limit`\n    option is now 1PB. The previous default value was 1MB. Using a large value\n```","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"},{"author":{"_account_id":33038,"name":"Chuan Miao","email":"chuan137@gmail.com","username":"chuan137"},"change_message_id":"ee133aba63583746e65ec3ff54cdbf85ff89332a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set the default value of the `netapp_snapmirror_last_transfer_size_limit`"},{"line_number":5,"context_line":"    option to 1PB. The previous default value was 1MB. Using a large value"},{"line_number":6,"context_line":"    effectively disables the check for the last transfer size limit during"},{"line_number":7,"context_line":"    updating replica state."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4de45dac_f7d3d0f8","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":18},"in_reply_to":"f6e88380_4e19cb06","updated":"2024-10-02 07:29:23.000000000","message":"Done","commit_id":"b771bdfefa2e2e025ed3076594e124a6ca2f6164"}]}