)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dddb1bdaabf2703e741547390976a4130deac09","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     jayaanand borra \u003cjayaanand.borra@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-29 02:50:36 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":8,"context_line":"where the user can specify a pre-created NetApp efficiency policy"},{"line_number":9,"context_line":"from share located share-server. During share creation, User specified"},{"line_number":10,"context_line":"efficiency policy can be applied to the FlexVol/FlexGroup volume that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"827f2790_bd43d2f3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2024-07-29 16:57:27.000000000","message":"Please consider adding a title (summary), followed by a blank line and details.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure would explain the best practice.","commit_id":"3c50474004daa114d3c8667ff5836b4096c48b9c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"dfd20dd1d12709b5fefd108bbacc52a4db09c681","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jayaanand borra \u003cjayaanand.borra@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-29 02:50:36 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":8,"context_line":"where the user can specify a pre-created NetApp efficiency policy"},{"line_number":9,"context_line":"from share located share-server. During share creation, User specified"},{"line_number":10,"context_line":"efficiency policy can be applied to the FlexVol/FlexGroup volume that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2e05f879_5cc4e9d0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"in_reply_to":"6fb5ddec_a7f7c253","updated":"2024-07-30 17:30:08.000000000","message":"Thank you! Takashi/Carlos. Update title 😊. Missed during initial commit.","commit_id":"3c50474004daa114d3c8667ff5836b4096c48b9c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3f6f35fbd2b2919e00033c531cff4f322c4acca4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     jayaanand borra \u003cjayaanand.borra@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-29 02:50:36 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":8,"context_line":"where the user can specify a pre-created NetApp efficiency policy"},{"line_number":9,"context_line":"from share located share-server. During share creation, User specified"},{"line_number":10,"context_line":"efficiency policy can be applied to the FlexVol/FlexGroup volume that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6fb5ddec_a7f7c253","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"in_reply_to":"827f2790_bd43d2f3","updated":"2024-07-30 13:11:10.000000000","message":"++ :)","commit_id":"3c50474004daa114d3c8667ff5836b4096c48b9c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6654c2d06873164dae3a55375d9c4fd8d1245d1","unresolved":true,"context_lines":[{"line_number":11,"context_line":"from share located share-server. During share creation, User specified"},{"line_number":12,"context_line":"efficiency policy can be applied to the FlexVol/FlexGroup volume that"},{"line_number":13,"context_line":"corresponds to the Manila Share."},{"line_number":14,"context_line":"Blueprint: manila-netapp-efficiency-policy"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1ebc1b8ac6d70c4f525593d0fc75aa0cae2b22bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e75ed9e5_f3c1e167","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":42},"updated":"2024-09-04 06:20:06.000000000","message":"Implements: bp manila-netapp-efficiency-policy\n\nPlease keep this syntax; the bot needs it to update the blueprints on Launchpad","commit_id":"43538613ee615c31b2ec577505597a601048cdec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4fca2bcc21d66a6bc3d6987af61662481548adde","unresolved":false,"context_lines":[{"line_number":11,"context_line":"from share located share-server. During share creation, User specified"},{"line_number":12,"context_line":"efficiency policy can be applied to the FlexVol/FlexGroup volume that"},{"line_number":13,"context_line":"corresponds to the Manila Share."},{"line_number":14,"context_line":"Blueprint: manila-netapp-efficiency-policy"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1ebc1b8ac6d70c4f525593d0fc75aa0cae2b22bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"870dfd34_e705d5c2","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":42},"in_reply_to":"e75ed9e5_f3c1e167","updated":"2024-09-04 18:36:28.000000000","message":"Please update the launchpad blueprint manually for now..","commit_id":"43538613ee615c31b2ec577505597a601048cdec"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c8d695be_502e429d","updated":"2024-08-20 19:15:37.000000000","message":"Thank you for working on this feature. Could you please take a look at the comments inline?","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e52907c_5b9dd80c","updated":"2024-08-01 17:35:54.000000000","message":"Thanks jayaanand for working on this feature. I have few comments on this patch.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"67f5ddc855fb77f798bc34c0a7b62a4391081709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"187fb8d2_32c85617","updated":"2024-09-03 15:55:41.000000000","message":"LGTM","commit_id":"43538613ee615c31b2ec577505597a601048cdec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"083f12c74c9cd8d91636c54ef34147b14a3f4a61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4789defa_411c50a5","updated":"2024-09-02 16:18:23.000000000","message":"LGTM, thank you Gireesh! Do you have any CI tests to share with us?\nIf not, would be nice to get some feedback from other people that managed to test this change","commit_id":"43538613ee615c31b2ec577505597a601048cdec"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a5dedb50b352835536cc07877bf1f192cfedb07a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9421a6f4_6dd57510","updated":"2024-09-03 16:07:08.000000000","message":"Please add some CI tests covering this feature as a follow-up.","commit_id":"43538613ee615c31b2ec577505597a601048cdec"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"995d71c0_d60d1d3f","updated":"2024-09-02 15:53:16.000000000","message":"Thank you! Gireesh and Carlose for detailed review. Addressed review comments please review again.","commit_id":"43538613ee615c31b2ec577505597a601048cdec"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"580c34a7de66009714e4f44103301b3ab6aac2d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a0698742_82606421","updated":"2024-09-04 16:19:32.000000000","message":"Yes Goutham. All workflows are tested locally. I didn\u0027t find any errors in any DevStack logs. Don\u0027t expect any regression from this changes.","commit_id":"43538613ee615c31b2ec577505597a601048cdec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4fca2bcc21d66a6bc3d6987af61662481548adde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca344358_a38c3c30","in_reply_to":"04f4f5cd_a4337a70","updated":"2024-09-04 18:36:28.000000000","message":"\u003e Yes Goutham. All workflows are tested locally. I didn\u0027t find any errors in any DevStack logs. Don\u0027t expect any regression from this changes.\n\n\nThank you for confirming this","commit_id":"43538613ee615c31b2ec577505597a601048cdec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6654c2d06873164dae3a55375d9c4fd8d1245d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"04f4f5cd_a4337a70","in_reply_to":"4789defa_411c50a5","updated":"2024-09-04 06:20:06.000000000","message":"@jayaanand.borra@netapp.com\n\nWas this patch tested locally and verified to not introduce any regressions?","commit_id":"43538613ee615c31b2ec577505597a601048cdec"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":2239,"context_line":"        self.send_request(\u0027volume-create\u0027, api_args)"},{"line_number":2240,"context_line":""},{"line_number":2241,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":2242,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":2243,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":2244,"context_line":"            efficiency_policy\u003defficiency_policy"},{"line_number":2245,"context_line":"        )"},{"line_number":2246,"context_line":"        if max_files is not None:"},{"line_number":2247,"context_line":"            self.set_volume_max_files(volume_name, max_files)"},{"line_number":2248,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dec38ca3_576a5885","line":2245,"range":{"start_line":2242,"start_character":8,"end_line":2245,"end_character":9},"updated":"2024-08-01 17:35:54.000000000","message":"Add this code under if condition \nif efficiency_policy is not None:\n        self.update_volume_efficiency_attributes(..","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2239,"context_line":"        self.send_request(\u0027volume-create\u0027, api_args)"},{"line_number":2240,"context_line":""},{"line_number":2241,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":2242,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":2243,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":2244,"context_line":"            efficiency_policy\u003defficiency_policy"},{"line_number":2245,"context_line":"        )"},{"line_number":2246,"context_line":"        if max_files is not None:"},{"line_number":2247,"context_line":"            self.set_volume_max_files(volume_name, max_files)"},{"line_number":2248,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"96b1fa7b_2a067210","line":2245,"range":{"start_line":2242,"start_character":8,"end_line":2245,"end_character":9},"in_reply_to":"3db01d63_435b084a","updated":"2024-09-02 15:53:16.000000000","message":"all \"apply_volume_efficiency_policy\" functions in ZAPI and REST are verifying for not None. All provisioning options are populated to None by default. There are multiple paths to apply volume_efficiency policy changes. We are versifying None values at args assignment and skipping ZAPI and REST call.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":2239,"context_line":"        self.send_request(\u0027volume-create\u0027, api_args)"},{"line_number":2240,"context_line":""},{"line_number":2241,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":2242,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":2243,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":2244,"context_line":"            efficiency_policy\u003defficiency_policy"},{"line_number":2245,"context_line":"        )"},{"line_number":2246,"context_line":"        if max_files is not None:"},{"line_number":2247,"context_line":"            self.set_volume_max_files(volume_name, max_files)"},{"line_number":2248,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3db01d63_435b084a","line":2245,"range":{"start_line":2242,"start_character":8,"end_line":2245,"end_character":9},"in_reply_to":"dec38ca3_576a5885","updated":"2024-08-20 19:15:37.000000000","message":"++","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":2384,"context_line":"                                       efficiency_policy\u003dNone):"},{"line_number":2385,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2386,"context_line":"        api_args \u003d {"},{"line_number":2387,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2388,"context_line":"            \u0027policy-name\u0027: efficiency_policy"},{"line_number":2389,"context_line":"        }"},{"line_number":2390,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c3a841a3_a516b518","line":2387,"range":{"start_line":2387,"start_character":20,"end_line":2387,"end_character":43},"updated":"2024-08-20 19:15:37.000000000","message":"maybe use an f string here? I think it\u0027d make the code a bit more readable","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2384,"context_line":"                                       efficiency_policy\u003dNone):"},{"line_number":2385,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2386,"context_line":"        api_args \u003d {"},{"line_number":2387,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2388,"context_line":"            \u0027policy-name\u0027: efficiency_policy"},{"line_number":2389,"context_line":"        }"},{"line_number":2390,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1b87b50b_ca94eabe","line":2387,"range":{"start_line":2387,"start_character":20,"end_line":2387,"end_character":43},"in_reply_to":"c3a841a3_a516b518","updated":"2024-09-02 15:53:16.000000000","message":"updated to us f string now.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":2383,"context_line":"    def apply_volume_efficiency_policy(self, volume_name,"},{"line_number":2384,"context_line":"                                       efficiency_policy\u003dNone):"},{"line_number":2385,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2386,"context_line":"        api_args \u003d {"},{"line_number":2387,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2388,"context_line":"            \u0027policy-name\u0027: efficiency_policy"},{"line_number":2389,"context_line":"        }"},{"line_number":2390,"context_line":""},{"line_number":2391,"context_line":"        # update volume efficiency policy only if policy_name is provided"},{"line_number":2392,"context_line":"        if efficiency_policy:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9edb67a7_4fee5d40","line":2389,"range":{"start_line":2386,"start_character":8,"end_line":2389,"end_character":9},"updated":"2024-08-20 19:15:37.000000000","message":"maybe API args shouldn\u0027t exist unless efficiency policy is being set, so I believe we should flip the comparison and change the method a bit:\n```\nif not efficiency_policy:\n    return\n\napi_args \u003d {\n    \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,\n    \u0027policy-name\u0027: efficiency_policy\n}\n\nself.send_request(\u0027sis-set-config\u0027, api_args)\n```","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2383,"context_line":"    def apply_volume_efficiency_policy(self, volume_name,"},{"line_number":2384,"context_line":"                                       efficiency_policy\u003dNone):"},{"line_number":2385,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2386,"context_line":"        api_args \u003d {"},{"line_number":2387,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2388,"context_line":"            \u0027policy-name\u0027: efficiency_policy"},{"line_number":2389,"context_line":"        }"},{"line_number":2390,"context_line":""},{"line_number":2391,"context_line":"        # update volume efficiency policy only if policy_name is provided"},{"line_number":2392,"context_line":"        if efficiency_policy:"}],"source_content_type":"text/x-python","patch_set":2,"id":"60c55123_93ee8736","line":2389,"range":{"start_line":2386,"start_character":8,"end_line":2389,"end_character":9},"in_reply_to":"9edb67a7_4fee5d40","updated":"2024-09-02 15:53:16.000000000","message":"updated to populate when efficiency_policy is not none.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":2395,"context_line":"    @na_utils.trace"},{"line_number":2396,"context_line":"    def apply_volume_efficiency_policy_async(self, volume_name,"},{"line_number":2397,"context_line":"                                             efficiency_policy\u003dNone):"},{"line_number":2398,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2399,"context_line":"        api_args \u003d {"},{"line_number":2400,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2401,"context_line":"            \u0027policy-name\u0027: efficiency_policy"}],"source_content_type":"text/x-python","patch_set":2,"id":"6cd508cf_0841543d","line":2398,"range":{"start_line":2398,"start_character":62,"end_line":2398,"end_character":66},"updated":"2024-08-20 19:15:37.000000000","message":"asynchronously.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2395,"context_line":"    @na_utils.trace"},{"line_number":2396,"context_line":"    def apply_volume_efficiency_policy_async(self, volume_name,"},{"line_number":2397,"context_line":"                                             efficiency_policy\u003dNone):"},{"line_number":2398,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2399,"context_line":"        api_args \u003d {"},{"line_number":2400,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2401,"context_line":"            \u0027policy-name\u0027: efficiency_policy"}],"source_content_type":"text/x-python","patch_set":2,"id":"2dec36e3_908f9fe5","line":2398,"range":{"start_line":2398,"start_character":62,"end_line":2398,"end_character":66},"in_reply_to":"6cd508cf_0841543d","updated":"2024-09-02 15:53:16.000000000","message":"updated comments to use \"asynchronously\"","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":2396,"context_line":"    def apply_volume_efficiency_policy_async(self, volume_name,"},{"line_number":2397,"context_line":"                                             efficiency_policy\u003dNone):"},{"line_number":2398,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2399,"context_line":"        api_args \u003d {"},{"line_number":2400,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2401,"context_line":"            \u0027policy-name\u0027: efficiency_policy"},{"line_number":2402,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ad3d43c_095ea844","line":2399,"range":{"start_line":2399,"start_character":8,"end_line":2399,"end_character":16},"updated":"2024-08-20 19:15:37.000000000","message":"same about api args","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2396,"context_line":"    def apply_volume_efficiency_policy_async(self, volume_name,"},{"line_number":2397,"context_line":"                                             efficiency_policy\u003dNone):"},{"line_number":2398,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2399,"context_line":"        api_args \u003d {"},{"line_number":2400,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2401,"context_line":"            \u0027policy-name\u0027: efficiency_policy"},{"line_number":2402,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"537bb3a8_22fe2677","line":2399,"range":{"start_line":2399,"start_character":8,"end_line":2399,"end_character":16},"in_reply_to":"3ad3d43c_095ea844","updated":"2024-09-02 15:53:16.000000000","message":"updated api args to use f string","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":2397,"context_line":"                                             efficiency_policy\u003dNone):"},{"line_number":2398,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2399,"context_line":"        api_args \u003d {"},{"line_number":2400,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2401,"context_line":"            \u0027policy-name\u0027: efficiency_policy"},{"line_number":2402,"context_line":"        }"},{"line_number":2403,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"38ab954b_5290aefc","line":2400,"range":{"start_line":2400,"start_character":12,"end_line":2400,"end_character":44},"updated":"2024-08-20 19:15:37.000000000","message":"same thing about the f string","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2397,"context_line":"                                             efficiency_policy\u003dNone):"},{"line_number":2398,"context_line":"        \"\"\"Apply efficiency policy to FlexVol/FlexGroup volume.\"\"\""},{"line_number":2399,"context_line":"        api_args \u003d {"},{"line_number":2400,"context_line":"            \u0027path\u0027: \u0027/vol/%s\u0027 % volume_name,"},{"line_number":2401,"context_line":"            \u0027policy-name\u0027: efficiency_policy"},{"line_number":2402,"context_line":"        }"},{"line_number":2403,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ec9723b9_f1e19fbf","line":2400,"range":{"start_line":2400,"start_character":12,"end_line":2400,"end_character":44},"in_reply_to":"38ab954b_5290aefc","updated":"2024-09-02 15:53:16.000000000","message":"updated to use f sting now.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":2694,"context_line":"        self.send_request(\u0027volume-modify-iter\u0027, api_args)"},{"line_number":2695,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":2696,"context_line":"        # Efficiency options must be handled separately"},{"line_number":2697,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":2698,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":2699,"context_line":"            is_flexgroup\u003dis_flexgroup, efficiency_policy\u003defficiency_policy"},{"line_number":2700,"context_line":"        )"},{"line_number":2701,"context_line":""},{"line_number":2702,"context_line":"    @na_utils.trace"},{"line_number":2703,"context_line":"    def update_volume_efficiency_attributes(self, volume_name, dedup_enabled,"}],"source_content_type":"text/x-python","patch_set":2,"id":"16ccd03f_67c1cf9a","line":2700,"range":{"start_line":2697,"start_character":8,"end_line":2700,"end_character":9},"updated":"2024-08-01 17:35:54.000000000","message":"Add this code under below condition \nif efficiency_policy  is not None:","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2694,"context_line":"        self.send_request(\u0027volume-modify-iter\u0027, api_args)"},{"line_number":2695,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":2696,"context_line":"        # Efficiency options must be handled separately"},{"line_number":2697,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":2698,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":2699,"context_line":"            is_flexgroup\u003dis_flexgroup, efficiency_policy\u003defficiency_policy"},{"line_number":2700,"context_line":"        )"},{"line_number":2701,"context_line":""},{"line_number":2702,"context_line":"    @na_utils.trace"},{"line_number":2703,"context_line":"    def update_volume_efficiency_attributes(self, volume_name, dedup_enabled,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1709139e_2a5bc8e2","line":2700,"range":{"start_line":2697,"start_character":8,"end_line":2700,"end_character":9},"in_reply_to":"16ccd03f_67c1cf9a","updated":"2024-09-02 15:53:16.000000000","message":"all \"apply_volume_efficiency_policy\" functions in ZAPI and REST are verifying for not None. All provisioning options are populated to None by default. There are multiple paths to apply volume_efficiency policy changes. We are versifying None values at args assignment and skipping ZAPI and REST call.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":2734,"context_line":"            else:"},{"line_number":2735,"context_line":"                self.disable_compression(volume_name)"},{"line_number":2736,"context_line":""},{"line_number":2737,"context_line":"        if is_flexgroup:"},{"line_number":2738,"context_line":"            self.apply_volume_efficiency_policy_async("},{"line_number":2739,"context_line":"                volume_name, efficiency_policy\u003defficiency_policy)"},{"line_number":2740,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7101f634_b6caf9cb","line":2737,"range":{"start_line":2737,"start_character":6,"end_line":2737,"end_character":24},"updated":"2024-08-01 17:35:54.000000000","message":"change this condition to \nif is_flexgroup and efficiency_policy is not None:","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2734,"context_line":"            else:"},{"line_number":2735,"context_line":"                self.disable_compression(volume_name)"},{"line_number":2736,"context_line":""},{"line_number":2737,"context_line":"        if is_flexgroup:"},{"line_number":2738,"context_line":"            self.apply_volume_efficiency_policy_async("},{"line_number":2739,"context_line":"                volume_name, efficiency_policy\u003defficiency_policy)"},{"line_number":2740,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc37facb_2ed1acbc","line":2737,"range":{"start_line":2737,"start_character":6,"end_line":2737,"end_character":24},"in_reply_to":"3876d23f_64c701e2","updated":"2024-09-02 15:53:16.000000000","message":"all \"apply_volume_efficiency_policy\" functions in ZAPI and REST are verifying for not None. All provisioning options are populated to None by default. There are multiple paths to apply volume_efficiency policy changes. We are versifying None values at args assignment and skipping ZAPI and REST call.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":2734,"context_line":"            else:"},{"line_number":2735,"context_line":"                self.disable_compression(volume_name)"},{"line_number":2736,"context_line":""},{"line_number":2737,"context_line":"        if is_flexgroup:"},{"line_number":2738,"context_line":"            self.apply_volume_efficiency_policy_async("},{"line_number":2739,"context_line":"                volume_name, efficiency_policy\u003defficiency_policy)"},{"line_number":2740,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3876d23f_64c701e2","line":2737,"range":{"start_line":2737,"start_character":6,"end_line":2737,"end_character":24},"in_reply_to":"7101f634_b6caf9cb","updated":"2024-08-20 19:15:37.000000000","message":"++, then we won\u0027t need to check in the method","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":947,"context_line":"    # TODO(caique): when ZAPI is dropped, this method should be removed and"},{"line_number":948,"context_line":"    # the callers should start calling directly the \"create_volume_async\""},{"line_number":949,"context_line":"    @na_utils.trace"},{"line_number":950,"context_line":"    def create_volume(self, aggregate_name, volume_name, size_gb,"},{"line_number":951,"context_line":"                      thin_provisioned\u003dFalse, snapshot_policy\u003dNone,"},{"line_number":952,"context_line":"                      language\u003dNone, dedup_enabled\u003dFalse,"},{"line_number":953,"context_line":"                      compression_enabled\u003dFalse, max_files\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c6f68789_83a4c101","line":950,"range":{"start_line":950,"start_character":3,"end_line":950,"end_character":32},"updated":"2024-08-01 17:35:54.000000000","message":"You made the change for create_volume but in case of modify volume I am not seeing any changes in rest lib. Could you please add those also.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":947,"context_line":"    # TODO(caique): when ZAPI is dropped, this method should be removed and"},{"line_number":948,"context_line":"    # the callers should start calling directly the \"create_volume_async\""},{"line_number":949,"context_line":"    @na_utils.trace"},{"line_number":950,"context_line":"    def create_volume(self, aggregate_name, volume_name, size_gb,"},{"line_number":951,"context_line":"                      thin_provisioned\u003dFalse, snapshot_policy\u003dNone,"},{"line_number":952,"context_line":"                      language\u003dNone, dedup_enabled\u003dFalse,"},{"line_number":953,"context_line":"                      compression_enabled\u003dFalse, max_files\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"57ffcc7a_d4ccab61","line":950,"range":{"start_line":950,"start_character":3,"end_line":950,"end_character":32},"in_reply_to":"c6f68789_83a4c101","updated":"2024-09-02 15:53:16.000000000","message":"starting from Line#2535 is for modify volume lib changes.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":968,"context_line":"            qos_policy_group\u003dqos_policy_group, encrypt\u003dencrypt,"},{"line_number":969,"context_line":"            adaptive_qos_policy_group\u003dadaptive_qos_policy_group,"},{"line_number":970,"context_line":"            mount_point_name\u003dmount_point_name, **options)"},{"line_number":971,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":972,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":973,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":974,"context_line":"            efficiency_policy\u003defficiency_policy"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b17e810_286c40a8","line":971,"range":{"start_line":971,"start_character":8,"end_line":971,"end_character":66},"updated":"2024-08-01 17:35:54.000000000","message":"For readability point of view add efficiency_policy parameter in method instead of getting it from option. Same is applicable for ZAPI also","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":968,"context_line":"            qos_policy_group\u003dqos_policy_group, encrypt\u003dencrypt,"},{"line_number":969,"context_line":"            adaptive_qos_policy_group\u003dadaptive_qos_policy_group,"},{"line_number":970,"context_line":"            mount_point_name\u003dmount_point_name, **options)"},{"line_number":971,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":972,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":973,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":974,"context_line":"            efficiency_policy\u003defficiency_policy"}],"source_content_type":"text/x-python","patch_set":2,"id":"1bdc0fcd_28720cb7","line":971,"range":{"start_line":971,"start_character":8,"end_line":971,"end_character":66},"in_reply_to":"6b17e810_286c40a8","updated":"2024-09-02 15:53:16.000000000","message":"All provisioning values are available in **options. Also changing signature which is core provisioning workflow need extensive change to all calling functions.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":969,"context_line":"            adaptive_qos_policy_group\u003dadaptive_qos_policy_group,"},{"line_number":970,"context_line":"            mount_point_name\u003dmount_point_name, **options)"},{"line_number":971,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":972,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":973,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":974,"context_line":"            efficiency_policy\u003defficiency_policy"},{"line_number":975,"context_line":"        )"},{"line_number":976,"context_line":"        if max_files is not None:"},{"line_number":977,"context_line":"            self.set_volume_max_files(volume_name, max_files)"},{"line_number":978,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3bac1654_c79b0466","line":975,"range":{"start_line":972,"start_character":8,"end_line":975,"end_character":9},"updated":"2024-08-01 17:35:54.000000000","message":"Add this code under below condition\nif efficiency_policy is not None:","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":969,"context_line":"            adaptive_qos_policy_group\u003dadaptive_qos_policy_group,"},{"line_number":970,"context_line":"            mount_point_name\u003dmount_point_name, **options)"},{"line_number":971,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":972,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":973,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":974,"context_line":"            efficiency_policy\u003defficiency_policy"},{"line_number":975,"context_line":"        )"},{"line_number":976,"context_line":"        if max_files is not None:"},{"line_number":977,"context_line":"            self.set_volume_max_files(volume_name, max_files)"},{"line_number":978,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d643e98d_cfbc2830","line":975,"range":{"start_line":972,"start_character":8,"end_line":975,"end_character":9},"in_reply_to":"3bac1654_c79b0466","updated":"2024-09-02 15:53:16.000000000","message":"all \"apply_volume_efficiency_policy\" functions in ZAPI and REST are verifying for not None. All provisioning options are populated to None by default. There are multiple paths to apply volume_efficiency policy changes. We are versifying None values at args assignment and skipping ZAPI and REST call.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":1132,"context_line":"        elif not compression_enabled and efficiency_status[\u0027compression\u0027]:"},{"line_number":1133,"context_line":"            self.disable_compression_async(volume_name)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        self.apply_volume_efficiency_policy("},{"line_number":1136,"context_line":"            volume_name, efficiency_policy\u003defficiency_policy)"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    @na_utils.trace"},{"line_number":1139,"context_line":"    def enable_dedupe_async(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2c17afc5_601e5a73","line":1136,"range":{"start_line":1135,"start_character":8,"end_line":1136,"end_character":61},"updated":"2024-08-01 17:35:54.000000000","message":"Add the condition to apply only when efficiency_policy is not None.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"        elif not compression_enabled and efficiency_status[\u0027compression\u0027]:"},{"line_number":1133,"context_line":"            self.disable_compression_async(volume_name)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        self.apply_volume_efficiency_policy("},{"line_number":1136,"context_line":"            volume_name, efficiency_policy\u003defficiency_policy)"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    @na_utils.trace"},{"line_number":1139,"context_line":"    def enable_dedupe_async(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7562fd9f_390e3627","line":1136,"range":{"start_line":1135,"start_character":8,"end_line":1136,"end_character":61},"in_reply_to":"2c17afc5_601e5a73","updated":"2024-09-02 15:53:16.000000000","message":"all \"apply_volume_efficiency_policy\" functions in ZAPI and REST are verifying for not None. All provisioning options are populated to None by default. There are multiple paths to apply volume_efficiency policy changes. We are versifying None values at args assignment and skipping ZAPI and REST call.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":2536,"context_line":"        # Extract efficiency_policy from provisioning_options"},{"line_number":2537,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":2538,"context_line":"        # Efficiency options must be handled separately"},{"line_number":2539,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":2540,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":2541,"context_line":"            is_flexgroup\u003dis_flexgroup, efficiency_policy\u003defficiency_policy"},{"line_number":2542,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"0a06bb06_191854bc","line":2539,"range":{"start_line":2539,"start_character":7,"end_line":2539,"end_character":49},"updated":"2024-08-01 17:35:54.000000000","message":"Add the code under efficiency_policy is not None.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2536,"context_line":"        # Extract efficiency_policy from provisioning_options"},{"line_number":2537,"context_line":"        efficiency_policy \u003d options.get(\u0027efficiency_policy\u0027, None)"},{"line_number":2538,"context_line":"        # Efficiency options must be handled separately"},{"line_number":2539,"context_line":"        self.update_volume_efficiency_attributes("},{"line_number":2540,"context_line":"            volume_name, dedup_enabled, compression_enabled,"},{"line_number":2541,"context_line":"            is_flexgroup\u003dis_flexgroup, efficiency_policy\u003defficiency_policy"},{"line_number":2542,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b2202f3_7585a0d7","line":2539,"range":{"start_line":2539,"start_character":7,"end_line":2539,"end_character":49},"in_reply_to":"0a06bb06_191854bc","updated":"2024-09-02 15:53:16.000000000","message":"all \"apply_volume_efficiency_policy\" functions in ZAPI and REST are verifying for not None. All provisioning options are populated to None by default. There are multiple paths to apply volume_efficiency policy changes. We are versifying None values at args assignment and skipping ZAPI and REST call.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":1138,"context_line":"                  \u0027provisioning options %(options)s\u0027,"},{"line_number":1139,"context_line":"                  {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1140,"context_line":"                   \u0027options\u0027: provisioning_options,"},{"line_number":1141,"context_line":"                   \u0027mount_point_name\u0027: mount_point_name})"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        if self._is_flexgroup_pool(pool_name):"},{"line_number":1144,"context_line":"            aggr_list \u003d self._get_flexgroup_aggregate_list(pool_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c27d6bb6_c3c41933","line":1141,"range":{"start_line":1141,"start_character":18,"end_line":1141,"end_character":57},"updated":"2024-08-01 17:35:54.000000000","message":"why this extra parameter is added here even this is not used in message. plz remove this.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                  \u0027provisioning options %(options)s\u0027,"},{"line_number":1139,"context_line":"                  {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1140,"context_line":"                   \u0027options\u0027: provisioning_options,"},{"line_number":1141,"context_line":"                   \u0027mount_point_name\u0027: mount_point_name})"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        if self._is_flexgroup_pool(pool_name):"},{"line_number":1144,"context_line":"            aggr_list \u003d self._get_flexgroup_aggregate_list(pool_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"839673d6_a613fcc3","line":1141,"range":{"start_line":1141,"start_character":18,"end_line":1141,"end_character":57},"in_reply_to":"21ee625d_60d8afb2","updated":"2024-09-02 15:53:16.000000000","message":"😊 i am using old setup from manila. this line creeper in... not sure how.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":1138,"context_line":"                  \u0027provisioning options %(options)s\u0027,"},{"line_number":1139,"context_line":"                  {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1140,"context_line":"                   \u0027options\u0027: provisioning_options,"},{"line_number":1141,"context_line":"                   \u0027mount_point_name\u0027: mount_point_name})"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        if self._is_flexgroup_pool(pool_name):"},{"line_number":1144,"context_line":"            aggr_list \u003d self._get_flexgroup_aggregate_list(pool_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"21ee625d_60d8afb2","line":1141,"range":{"start_line":1141,"start_character":18,"end_line":1141,"end_character":57},"in_reply_to":"c27d6bb6_c3c41933","updated":"2024-08-20 19:15:37.000000000","message":"yep, feels like something with rebasing likely","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"}],"releasenotes/notes/manila-netapp-storage-efficiency-policy-5fa0b2b15901bf93.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":4,"context_line":"    where the user can specify a pre-created NetApp efficiency policy"},{"line_number":5,"context_line":"    from share located share-server. During share creation, User specified"},{"line_number":6,"context_line":"    efficiency policy can be applied to the FlexVol/FlexGroup volume that"},{"line_number":7,"context_line":"    corresponds to the Manila Share."},{"line_number":8,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e95ff9e1_c0c91256","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":36},"updated":"2024-08-20 19:15:37.000000000","message":"```suggestion\n    It is now possible to specify pre-created NetApp efficiency\n    policies through the use of the `netapp:efficiency_policy` share type\n    extra spec.\n```","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":4,"context_line":"    where the user can specify a pre-created NetApp efficiency policy"},{"line_number":5,"context_line":"    from share located share-server. During share creation, User specified"},{"line_number":6,"context_line":"    efficiency policy can be applied to the FlexVol/FlexGroup volume that"},{"line_number":7,"context_line":"    corresponds to the Manila Share."},{"line_number":8,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"889b660c_d2b8f80d","line":5,"range":{"start_line":5,"start_character":60,"end_line":5,"end_character":64},"updated":"2024-08-01 17:35:54.000000000","message":"change User -\u003e user","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cb532252cb168218fef3083a0688f9ddc5f773d9","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":4,"context_line":"    where the user can specify a pre-created NetApp efficiency policy"},{"line_number":5,"context_line":"    from share located share-server. During share creation, User specified"},{"line_number":6,"context_line":"    efficiency policy can be applied to the FlexVol/FlexGroup volume that"},{"line_number":7,"context_line":"    corresponds to the Manila Share."},{"line_number":8,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b13f3862_6fbd8b75","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":35},"updated":"2024-08-01 17:35:54.000000000","message":"this should be \"on ONTAP SVM\". share server is with respect to DHSS\u003dtrue","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":4,"context_line":"    where the user can specify a pre-created NetApp efficiency policy"},{"line_number":5,"context_line":"    from share located share-server. During share creation, User specified"},{"line_number":6,"context_line":"    efficiency policy can be applied to the FlexVol/FlexGroup volume that"},{"line_number":7,"context_line":"    corresponds to the Manila Share."},{"line_number":8,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fb7b1242_50ee4294","line":5,"range":{"start_line":5,"start_character":60,"end_line":5,"end_character":64},"in_reply_to":"889b660c_d2b8f80d","updated":"2024-09-02 15:53:16.000000000","message":"Text changed to Carlose suggestion.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":4,"context_line":"    where the user can specify a pre-created NetApp efficiency policy"},{"line_number":5,"context_line":"    from share located share-server. During share creation, User specified"},{"line_number":6,"context_line":"    efficiency policy can be applied to the FlexVol/FlexGroup volume that"},{"line_number":7,"context_line":"    corresponds to the Manila Share."},{"line_number":8,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"52612137_d5672205","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":35},"in_reply_to":"b13f3862_6fbd8b75","updated":"2024-09-02 15:53:16.000000000","message":"Text changed to Carlose suggestion.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    This change introduce a new extra spec netapp:efficiency_policy"},{"line_number":4,"context_line":"    where the user can specify a pre-created NetApp efficiency policy"},{"line_number":5,"context_line":"    from share located share-server. During share creation, User specified"},{"line_number":6,"context_line":"    efficiency policy can be applied to the FlexVol/FlexGroup volume that"},{"line_number":7,"context_line":"    corresponds to the Manila Share."},{"line_number":8,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"84711973_35a02dea","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":36},"in_reply_to":"e95ff9e1_c0c91256","updated":"2024-09-02 15:53:16.000000000","message":"Text is updated to suggested text.","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"652bebea5d0f5503b3b771af2993d2226d3aa508","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    corresponds to the Manila Share."},{"line_number":8,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"},{"line_number":9,"context_line":"    efficiency policy creation. Users can retype to apply the policy, or if the"},{"line_number":10,"context_line":"    share-network is constant (i.e., one share service is created for one share network),"},{"line_number":11,"context_line":"    they can create an efficiency policy for the share server and apply it to"},{"line_number":12,"context_line":"    DHSS\u003dTrue shares."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"99810330_34d87286","line":10,"range":{"start_line":10,"start_character":79,"end_line":10,"end_character":89},"updated":"2024-08-20 19:15:37.000000000","message":"nit: please wrap this at 79 characters","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"43c20e0d9a19fa10aeaa46ddfdfb8b33144dfef4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    corresponds to the Manila Share."},{"line_number":8,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"},{"line_number":9,"context_line":"    efficiency policy creation. Users can retype to apply the policy, or if the"},{"line_number":10,"context_line":"    share-network is constant (i.e., one share service is created for one share network),"},{"line_number":11,"context_line":"    they can create an efficiency policy for the share server and apply it to"},{"line_number":12,"context_line":"    DHSS\u003dTrue shares."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b86cca5d_a7baec5d","line":10,"range":{"start_line":10,"start_character":79,"end_line":10,"end_character":89},"in_reply_to":"99810330_34d87286","updated":"2024-09-02 15:53:16.000000000","message":"yes, truncated to 79 chars","commit_id":"c5fc7196a809d4539d9475852b3a88455b1da1bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6654c2d06873164dae3a55375d9c4fd8d1245d1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    policies through the use of the `netapp:efficiency_policy` share type"},{"line_number":5,"context_line":"    extra spec."},{"line_number":6,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"},{"line_number":7,"context_line":"    efficiency policy creation. Users can retype to apply the policy, or if the"},{"line_number":8,"context_line":"    share-network is constant (i.e., one share service is created for one share"},{"line_number":9,"context_line":"    network), they can create an efficiency policy for the share server and"},{"line_number":10,"context_line":"    apply it to DHSS\u003dTrue shares."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"32edf7ce_e9f90c98","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":68},"updated":"2024-09-04 06:20:06.000000000","message":"retype isn\u0027t a feature in manila","commit_id":"43538613ee615c31b2ec577505597a601048cdec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4fca2bcc21d66a6bc3d6987af61662481548adde","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    policies through the use of the `netapp:efficiency_policy` share type"},{"line_number":5,"context_line":"    extra spec."},{"line_number":6,"context_line":"    In the case of DHSS\u003dTrue, the share server is not available upfront for"},{"line_number":7,"context_line":"    efficiency policy creation. Users can retype to apply the policy, or if the"},{"line_number":8,"context_line":"    share-network is constant (i.e., one share service is created for one share"},{"line_number":9,"context_line":"    network), they can create an efficiency policy for the share server and"},{"line_number":10,"context_line":"    apply it to DHSS\u003dTrue shares."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6444be18_f73e6b39","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":68},"in_reply_to":"32edf7ce_e9f90c98","updated":"2024-09-04 18:36:28.000000000","message":"I think you meant storage administrators can apply an efficiency policy out of band of manila.. if yes, please fix this release note in a separate change","commit_id":"43538613ee615c31b2ec577505597a601048cdec"}]}