)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"898346148d8d4f415f977f3396ea8e005e797bea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc33d35a_a1c86591","updated":"2024-07-31 13:00:01.000000000","message":"Change looks good. Thank you for working on it.\nOn CI:\n- Pep8 failure seems related to some issues in the release note. Could you please check that?\n- Generic driver is failing to create share networks, but mostly, the tests have worked\n- Generic scenario test worked, which is a good sign for us that the functionality didn\u0027t have regressions.\n\nIt would be nice to have NetApp engineers and other vendors testing this change if possible. I am adding a couple of maintainers as reviewers","commit_id":"95438c236ee2e15cf93f02a6ad8fc0884d3cb752"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba6bc47e004f6da11b52a199c91ac1b03c58bb86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a6715ea_d8d1037e","in_reply_to":"bc33d35a_a1c86591","updated":"2024-07-31 22:53:15.000000000","message":"Thanks; will address the pep8 error. \n\nThe Generic driver must be \"unaffected\" by this change - we don\u0027t test external provider networks with tempest jobs unless they\u0027re configured within tempest.conf  (config opt: \"share_network_id\")\n\nThe failures in the generic driver and container driver seem to occur without this change. These test jobs use pre-provisioned test credentials. I wonder if something broke there:\n\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dmanila-tempest-plugin-generic\u0026project\u003dopenstack/manila\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dmanila-tempest-plugin-container\u0026project\u003dopenstack/manila\n\n\nJob Configuration:\nhttps://github.com/openstack/manila-tempest-plugin/blob/a0420244e3d14f4441adab462fe9d2a0f1316b58/zuul.d/manila-tempest-jobs.yaml#L320\nhttps://github.com/openstack/manila-tempest-plugin/blob/a0420244e3d14f4441adab462fe9d2a0f1316b58/zuul.d/manila-tempest-jobs.yaml#L273","commit_id":"95438c236ee2e15cf93f02a6ad8fc0884d3cb752"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c1fa59a607539ba3d3a4199acaab6ab7e9ffbad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c709c4b_d1a0d936","updated":"2024-08-02 00:13:05.000000000","message":"@ihrachys@redhat.com @nusiddiq@redhat.com\nCould you please help verify if this patch is doing the right thing wrt using the Neutron API to:\n\n1) Verify that an network is \"external\"\n2) Set the port\u0027s admin status up to False\n\nThank you!","commit_id":"4a2ed4e61d60b90faac7b11f1b81dceee16b94cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f8b15aacf865846e2c24f3b99bb8b962ee0f681b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a4cd474_962b9b96","updated":"2024-08-02 19:39:12.000000000","message":"@manicsaran@gmail.com was able to test this with NetApp DHSS\u003dTrue on his devstack environment; and he is currently testing this with an RHOSP 17.1 environment that\u0027s based on stable/wallaby. \n\n@manicsaran@gmail.com - could you share your results/and review this change?","commit_id":"4a2ed4e61d60b90faac7b11f1b81dceee16b94cc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49ef848f5ef0c72eaab49b13893acb31120b4fd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0a502a99_82aaa89c","updated":"2024-08-02 20:24:05.000000000","message":"LGTM, thanks for the fix","commit_id":"4a2ed4e61d60b90faac7b11f1b81dceee16b94cc"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"2dfb2946940504fab67fc3dfdb665479fc5d193c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84240b1e_d9bff779","updated":"2024-08-07 17:21:49.000000000","message":"Thank you Goutham for the fix and a very quick turnaround. \n\nApart from the NIT comment on method name, other looks good. \n\nAlso, another NIT on logging: Can we print logs mentioning we are creating a port with Admin Down state for  manila:share external network based ports. As we are changing the default behavior of creating a port with \"DOWN\" admin state, it would help the users to know why the manila:share ports are in down state. \n\nAll other changes look good to me.","commit_id":"4a2ed4e61d60b90faac7b11f1b81dceee16b94cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d4108c9a2d470a94a01326d634b8bb3a4b47219a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2edd70de_2acea7f1","in_reply_to":"84240b1e_d9bff779","updated":"2024-08-12 14:14:53.000000000","message":"Thanks Saravanan; I\u0027ve added an info level log.","commit_id":"4a2ed4e61d60b90faac7b11f1b81dceee16b94cc"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"400bfe13b3fd3404393065ec7d5dbbe71d3d6b7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9d37400d_42f11665","updated":"2024-08-13 09:09:05.000000000","message":"It is not breaking existing productive scenarios for us. There is a release note and logging of the down state, that means surprises should be minimal.","commit_id":"53c8b69c016010e2bbbf3220bcf771a2e9dd8b91"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1e947859b6f3ed1af3208f5294dab2b87561dad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"239f3e8a_83a0cae3","updated":"2024-08-12 19:12:23.000000000","message":"LGTM, thank you!","commit_id":"53c8b69c016010e2bbbf3220bcf771a2e9dd8b91"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d4108c9a2d470a94a01326d634b8bb3a4b47219a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3ebdc0a2_d4b5ccee","updated":"2024-08-12 14:14:53.000000000","message":"Thank you @manicsaran@gmail.com.. please take a look at the latest patch","commit_id":"53c8b69c016010e2bbbf3220bcf771a2e9dd8b91"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"286da4540403cbc230954eb3261ae1eb70588db8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"330333dc_6eba1904","updated":"2024-08-12 15:50:48.000000000","message":"recheck\n\nlvm driver encountered a few issues after upgrade in the grenade job; seems unrelated","commit_id":"53c8b69c016010e2bbbf3220bcf771a2e9dd8b91"}],"manila/network/neutron/neutron_network_plugin.py":[{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"2dfb2946940504fab67fc3dfdb665479fc5d193c","unresolved":true,"context_lines":[{"line_number":410,"context_line":"                share_network_subnet[\u0027neutron_net_id\u0027])"},{"line_number":411,"context_line":"        return \u0027segments\u0027 in net_info"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def _save_neutron_network_data(self, context, share_network_subnet,"},{"line_number":414,"context_line":"                                   save_db\u003dTrue):"},{"line_number":415,"context_line":"        net_info \u003d self.neutron_api.get_network("},{"line_number":416,"context_line":"            share_network_subnet[\u0027neutron_net_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"19453f6b_5291c38f","line":413,"updated":"2024-08-07 17:21:49.000000000","message":"NIT: As the method returns a boolean value of \"is_external_network\", should the method name be changed to a getter \u0026 save ? or we\u0027ll have another method to just return external state ?","commit_id":"4a2ed4e61d60b90faac7b11f1b81dceee16b94cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d4108c9a2d470a94a01326d634b8bb3a4b47219a","unresolved":true,"context_lines":[{"line_number":410,"context_line":"                share_network_subnet[\u0027neutron_net_id\u0027])"},{"line_number":411,"context_line":"        return \u0027segments\u0027 in net_info"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def _save_neutron_network_data(self, context, share_network_subnet,"},{"line_number":414,"context_line":"                                   save_db\u003dTrue):"},{"line_number":415,"context_line":"        net_info \u003d self.neutron_api.get_network("},{"line_number":416,"context_line":"            share_network_subnet[\u0027neutron_net_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"8d3fa376_ceff3ad6","line":413,"in_reply_to":"19453f6b_5291c38f","updated":"2024-08-12 14:14:53.000000000","message":"I agree; but I was planning to improve this method to store this data in the manila database instead of passing it around like this. I changed the name of the method for now.. \n\nMaking db changes would disallow this bug fix to be backported; so its worth leaving this like this.","commit_id":"4a2ed4e61d60b90faac7b11f1b81dceee16b94cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a18d7eded338046cfa59cb6cab8402d3b7daa0a","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                share_network_subnet[\u0027neutron_net_id\u0027])"},{"line_number":411,"context_line":"        return \u0027segments\u0027 in net_info"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def _save_neutron_network_data(self, context, share_network_subnet,"},{"line_number":414,"context_line":"                                   save_db\u003dTrue):"},{"line_number":415,"context_line":"        net_info \u003d self.neutron_api.get_network("},{"line_number":416,"context_line":"            share_network_subnet[\u0027neutron_net_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0558c0d_b470e11d","line":413,"in_reply_to":"8d3fa376_ceff3ad6","updated":"2024-08-12 14:17:07.000000000","message":"Done","commit_id":"4a2ed4e61d60b90faac7b11f1b81dceee16b94cc"}],"releasenotes/notes/bug-2074504-disable-ports-on-neutron-ext-nets-af3ff56da9a928df.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"898346148d8d4f415f977f3396ea8e005e797bea","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When using Neutron networks tagged as \"external\" (unmanaged provider networks) as "},{"line_number":5,"context_line":"    share networks, Manila now creates ports with `admin_state_up\u003dFalse` (disabled)."},{"line_number":6,"context_line":"    This change addresses ARP failures that can occur when using OVN as the Neutron"},{"line_number":7,"context_line":"    ML2 plugin. For more information, refer to `bug 2074504"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff39f338_ba5e6460","line":4,"range":{"start_line":4,"start_character":85,"end_line":4,"end_character":86},"updated":"2024-07-31 13:00:01.000000000","message":"nit: blank space here at the end","commit_id":"95438c236ee2e15cf93f02a6ad8fc0884d3cb752"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba6bc47e004f6da11b52a199c91ac1b03c58bb86","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When using Neutron networks tagged as \"external\" (unmanaged provider networks) as "},{"line_number":5,"context_line":"    share networks, Manila now creates ports with `admin_state_up\u003dFalse` (disabled)."},{"line_number":6,"context_line":"    This change addresses ARP failures that can occur when using OVN as the Neutron"},{"line_number":7,"context_line":"    ML2 plugin. For more information, refer to `bug 2074504"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"658b8a5f_c4ec67c1","line":4,"range":{"start_line":4,"start_character":85,"end_line":4,"end_character":86},"in_reply_to":"ff39f338_ba5e6460","updated":"2024-07-31 22:53:15.000000000","message":"Done","commit_id":"95438c236ee2e15cf93f02a6ad8fc0884d3cb752"}]}