)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a6a3faaef8782f7d35a8d0a7465f3ee0edc1fb8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9c0a03b_0c10c7ee","updated":"2024-08-17 16:49:15.000000000","message":"Added few more comments","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"b9b4e7bc565221286bd1fecddb02e6b5e1666eab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c33e9a9_aabce8a4","updated":"2024-08-14 15:16:10.000000000","message":"LGTM\n\nI\u0027m only wondering now why we are scheduling at all instead of sending the create request directly to the host we want. I can\u0027t remember if we had a reason for implementing it that way other than that the scheduler hints were a good vehicle for putting the only_host information.","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"eb1b82d32baa46997149a67af85591da95a19870","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"223c6df4_9fa5f649","updated":"2024-08-15 03:12:16.000000000","message":"LGTM, only one comment\nalso need add release not.","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3f321035b1a52cbb4bd7550303a9bd500a6f905c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6c83156_a1b6282c","updated":"2024-08-11 18:05:56.000000000","message":"Please add the release note for this patch","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"eb1b82d32baa46997149a67af85591da95a19870","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35884b01_34a008e8","in_reply_to":"0c33e9a9_aabce8a4","updated":"2024-08-15 03:12:16.000000000","message":"Scheduling helps users balance capacity among multiple storage backends and automatically schedule back-end storage with features specified in the share type extra spec. The scheduling layer can also be useful for pre-filtering back-end storage that has gone down. scheduler hints are used only in special scenarios to specify a backend。\n\nUnder normal circumstances, share_backend_name can be scheduled to the specified back-end storage after we configure it in the extra spec of share type","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"2f343de7ed26adc6c10c8e5ef122b23b3fa3a1cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"002f83bb_73e9131c","updated":"2024-08-23 11:13:53.000000000","message":"I don\u0027t have much idea about functionality but code looks good for me.","commit_id":"71ef38c7b12556020dfc83f113339907cba640e2"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2d994f1e18a4b71364c2e20afb18b6d3bfc0f71f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab7e510b_23ec0e75","updated":"2024-08-26 01:46:54.000000000","message":"code LGTM. better add this change to doc.\nhttps://opendev.org/openstack/manila/src/branch/master/api-ref/source/parameters.yaml#2880 \n\n- ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67, will consider disabled host even host has been disabled.","commit_id":"71ef38c7b12556020dfc83f113339907cba640e2"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"9bc51d4230a701c3d1177d4fb7771828dca1bf82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7854384_a5d06eed","in_reply_to":"ab7e510b_23ec0e75","updated":"2024-08-26 01:47:58.000000000","message":"https://opendev.org/openstack/manila/src/commit/4bf505404ae77a230f79841797e0ee41d2ada414/api-ref/source/parameters.yaml#L2880","commit_id":"71ef38c7b12556020dfc83f113339907cba640e2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9f1726208f346dc89a13aeeea2fe078708f33e27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53e22f76_acd2238a","in_reply_to":"f7854384_a5d06eed","updated":"2024-08-26 10:42:35.000000000","message":"added.","commit_id":"71ef38c7b12556020dfc83f113339907cba640e2"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"16085948393a618caf383fb909176668931a487c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd64508f_39052691","updated":"2024-08-27 00:56:09.000000000","message":"LGTM","commit_id":"667b77c2c41b1b225dec6c12d1aeee6e2ac8ff37"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d1d3b2e05b9f9bae42c2e684b25d5f3a94e8193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3e4c573_e80675f0","updated":"2024-08-27 15:48:15.000000000","message":"Thanks for working on this change. Approach looks good, only a few suggestions shared in the comments. Please take a look at them :)","commit_id":"667b77c2c41b1b225dec6c12d1aeee6e2ac8ff37"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"57205a03c1ce631784d787c6fb565528b81be05a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9eb844b9_7c9b9f71","updated":"2024-08-30 04:00:07.000000000","message":"@haixin, can you please recheck ?\n@goutham/@carloss, please check again as all comments addressed.","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"29b4e22c985259f63629681bf31b78303b3abba6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"795e4f09_7f6cd29c","updated":"2024-08-28 01:24:14.000000000","message":"LGTM, thanks.","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ee668fdffb12fd34f1249e92b77213d19b6e56a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29092afc_948ab5c3","updated":"2024-08-29 23:26:29.000000000","message":"Thanks; I think this works; i\u0027ve a couple of suggestions inline","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e6e4b7102bbd3ce30cba61c16f09a84a6662d41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c1f1507b_ded2c26d","updated":"2024-08-30 06:37:05.000000000","message":"Thanks for the changes; please see comment inline","commit_id":"abfecdb99dd0026b7b7ee955e1940d5f7e018356"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c3fd72eedf16acaf23fd946db86390c50f2ec8f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f4df0d2e_611d16a6","updated":"2024-08-30 07:00:30.000000000","message":"LGTM，thanks","commit_id":"203a5e325f12d92bbf1edc21f606d4c391ef4268"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b0aaf12dc2148aa87be5c11197d07208d9835ffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"425a1901_1962905c","updated":"2024-08-30 06:51:54.000000000","message":"Thanks!","commit_id":"203a5e325f12d92bbf1edc21f606d4c391ef4268"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d1d3b2e05b9f9bae42c2e684b25d5f3a94e8193","unresolved":true,"context_lines":[{"line_number":2877,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2878,"context_line":"    strings. Accepted hints are:"},{"line_number":2879,"context_line":"    - ``same_host`` or ``different_host``: values must be a comma separated list of Share IDs"},{"line_number":2880,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67, will consider host even if its disabled."},{"line_number":2881,"context_line":"  in: body"},{"line_number":2882,"context_line":"  required: false"},{"line_number":2883,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f077ff73_41d2ecd1","line":2880,"range":{"start_line":2880,"start_character":150,"end_line":2880,"end_character":196},"updated":"2024-08-27 15:48:15.000000000","message":"This gives the impression that this will happen even with the 2.67 API version, when it won\u0027t. I think it would be better if we moved this detail to the admin documentation.","commit_id":"667b77c2c41b1b225dec6c12d1aeee6e2ac8ff37"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7a92974e00c19dbc5ad74dfdaa5a337932e0be48","unresolved":false,"context_lines":[{"line_number":2877,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2878,"context_line":"    strings. Accepted hints are:"},{"line_number":2879,"context_line":"    - ``same_host`` or ``different_host``: values must be a comma separated list of Share IDs"},{"line_number":2880,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67, will consider host even if its disabled."},{"line_number":2881,"context_line":"  in: body"},{"line_number":2882,"context_line":"  required: false"},{"line_number":2883,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"89c389ff_77bc754a","line":2880,"range":{"start_line":2880,"start_character":150,"end_line":2880,"end_character":196},"in_reply_to":"f077ff73_41d2ecd1","updated":"2024-08-27 18:42:10.000000000","message":"Done","commit_id":"667b77c2c41b1b225dec6c12d1aeee6e2ac8ff37"}],"manila/db/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ee668fdffb12fd34f1249e92b77213d19b6e56a","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def service_get_all_by_topic(context, topic, disabled\u003dFalse):"},{"line_number":107,"context_line":"    \"\"\"Get all services for a given topic.\"\"\""},{"line_number":108,"context_line":"    return IMPL.service_get_all_by_topic(context, topic, disabled)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def service_get_all_share_sorted(context):"}],"source_content_type":"text/x-python","patch_set":5,"id":"85c42f0b_13de01d8","line":108,"range":{"start_line":108,"start_character":57,"end_line":108,"end_character":65},"updated":"2024-08-29 23:26:29.000000000","message":"always pass kwargs as kwargs\n```suggestion\n    return IMPL.service_get_all_by_topic(context, topic, disabled\u003ddisabled)\n```","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"57205a03c1ce631784d787c6fb565528b81be05a","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def service_get_all_by_topic(context, topic, disabled\u003dFalse):"},{"line_number":107,"context_line":"    \"\"\"Get all services for a given topic.\"\"\""},{"line_number":108,"context_line":"    return IMPL.service_get_all_by_topic(context, topic, disabled)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def service_get_all_share_sorted(context):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f3eef869_b6b8b010","line":108,"range":{"start_line":108,"start_character":57,"end_line":108,"end_character":65},"in_reply_to":"85c42f0b_13de01d8","updated":"2024-08-30 04:00:07.000000000","message":"Done","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"eb1b82d32baa46997149a67af85591da95a19870","unresolved":true,"context_lines":[{"line_number":586,"context_line":"    query \u003d model_query("},{"line_number":587,"context_line":"        context, models.Service, read_deleted\u003d\"no\")"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if disabled is False:"},{"line_number":590,"context_line":"        query \u003d query.filter_by(disabled\u003ddisabled)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    return query.filter_by(topic\u003dtopic).all()"}],"source_content_type":"text/x-python","patch_set":1,"id":"f44f96ff_ccc8a71a","line":589,"range":{"start_line":589,"start_character":4,"end_line":589,"end_character":25},"updated":"2024-08-15 03:12:16.000000000","message":"if not disabled:","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d4d0a2df5b159fec42bf52813f80affdc00bbf05","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    query \u003d model_query("},{"line_number":587,"context_line":"        context, models.Service, read_deleted\u003d\"no\")"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if disabled is False:"},{"line_number":590,"context_line":"        query \u003d query.filter_by(disabled\u003ddisabled)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    return query.filter_by(topic\u003dtopic).all()"}],"source_content_type":"text/x-python","patch_set":1,"id":"f54dc8fd_102199f9","line":589,"range":{"start_line":589,"start_character":4,"end_line":589,"end_character":25},"in_reply_to":"57a4f971_0e76d140","updated":"2024-08-20 10:43:34.000000000","message":"Done","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a6a3faaef8782f7d35a8d0a7465f3ee0edc1fb8d","unresolved":true,"context_lines":[{"line_number":586,"context_line":"    query \u003d model_query("},{"line_number":587,"context_line":"        context, models.Service, read_deleted\u003d\"no\")"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if disabled is False:"},{"line_number":590,"context_line":"        query \u003d query.filter_by(disabled\u003ddisabled)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    return query.filter_by(topic\u003dtopic).all()"}],"source_content_type":"text/x-python","patch_set":1,"id":"57a4f971_0e76d140","line":589,"range":{"start_line":589,"start_character":4,"end_line":589,"end_character":25},"in_reply_to":"f44f96ff_ccc8a71a","updated":"2024-08-17 16:49:15.000000000","message":"+1","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ee668fdffb12fd34f1249e92b77213d19b6e56a","unresolved":true,"context_lines":[{"line_number":587,"context_line":"        context, models.Service, read_deleted\u003d\"no\")"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if not disabled:"},{"line_number":590,"context_line":"        query \u003d query.filter_by(disabled\u003ddisabled)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    return query.filter_by(topic\u003dtopic).all()"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"80c39a3b_2fbcf0ad","line":590,"range":{"start_line":590,"start_character":16,"end_line":590,"end_character":50},"updated":"2024-08-29 23:26:29.000000000","message":"Quite confusing.. \n\nplease change the name of the parameter \"disabled\" to \"consider_disabled\" like you\u0027re doing in the scheduler.. \n\nso it conveys what you\u0027re really doing. \n\nFrom first glance it looks like you either want disabled hosts or enabled hosts based on the value of \"disabled\", but what you\u0027re really implementing is a way to get all hosts regardless of their status. \n\n\n```\ndef service_get_all_by_topic(context, topic, consider_disabled\u003dFalse):\n    query \u003d model_query(\n        context, models.Service, read_deleted\u003d\"no\")\n\n    if not consider_disabled:\n        query \u003d query.filter_by(disabled\u003dFalse)\n    \n    return query.filter_by(topic\u003dtopic).all()\n\n```","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"57205a03c1ce631784d787c6fb565528b81be05a","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        context, models.Service, read_deleted\u003d\"no\")"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if not disabled:"},{"line_number":590,"context_line":"        query \u003d query.filter_by(disabled\u003ddisabled)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    return query.filter_by(topic\u003dtopic).all()"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5caf63b3_1c5a35ce","line":590,"range":{"start_line":590,"start_character":16,"end_line":590,"end_character":50},"in_reply_to":"80c39a3b_2fbcf0ad","updated":"2024-08-30 04:00:07.000000000","message":"consider the diff, with consider_disabled True, I am considering all hosts and consider_disabled False(which is also default behaviour of earlier code) I am considering only enabled hosts. So from all hosts returned by db, `only_host` hint will pick disabled host if asked by admin.\n\nchanged to consider_disabled.","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e6e4b7102bbd3ce30cba61c16f09a84a6662d41","unresolved":true,"context_lines":[{"line_number":587,"context_line":"        context, models.Service, read_deleted\u003d\"no\")"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if not consider_disabled:"},{"line_number":590,"context_line":"        query \u003d query.filter_by(disabled\u003dconsider_disabled)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    return query.filter_by(topic\u003dtopic).all()"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c9bcf394_7f71f385","line":590,"range":{"start_line":590,"start_character":41,"end_line":590,"end_character":58},"updated":"2024-08-30 06:37:05.000000000","message":"this is still confusing.. please use \n\n```\n   if not consider_disabled:\n       query \u003d query.filter_by(disabled\u003dFalse)\n```   \n\nSee the difference?\nIt simply means:\n\n\"If you\u0027re asking me not to consider disabled hosts, i\u0027ll explicitly look for \u0027disabled\u003dFalse\u0027.. \" \n\nThere\u0027s no need for maintainers to work out variable substitution in their brain if you do that.","commit_id":"abfecdb99dd0026b7b7ee955e1940d5f7e018356"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0eb5f515a7232a5457b8a43452dae8344ec2a4af","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        context, models.Service, read_deleted\u003d\"no\")"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if not consider_disabled:"},{"line_number":590,"context_line":"        query \u003d query.filter_by(disabled\u003dconsider_disabled)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    return query.filter_by(topic\u003dtopic).all()"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"081e1994_9445f9e4","line":590,"range":{"start_line":590,"start_character":41,"end_line":590,"end_character":58},"in_reply_to":"c9bcf394_7f71f385","updated":"2024-08-30 06:41:56.000000000","message":"Done","commit_id":"abfecdb99dd0026b7b7ee955e1940d5f7e018356"}],"manila/scheduler/drivers/filter.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d1d3b2e05b9f9bae42c2e684b25d5f3a94e8193","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        # Note: remember, we are using an iterator here. So only"},{"line_number":243,"context_line":"        # traverse this list once."},{"line_number":244,"context_line":"        consider_disabled_host \u003d False"},{"line_number":245,"context_line":"        if policy.check_is_host_admin(context) and filter_properties.get("},{"line_number":246,"context_line":"                \u0027scheduler_hints\u0027, {}).get(\u0027only_host\u0027):"},{"line_number":247,"context_line":"            consider_disabled_host \u003d True"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        hosts \u003d self.host_manager.get_all_host_states_share("},{"line_number":250,"context_line":"            elevated,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9396bb_f6d0c899","line":247,"range":{"start_line":245,"start_character":1,"end_line":247,"end_character":41},"updated":"2024-08-27 15:48:15.000000000","message":"missing unit tests: \nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_085/925902/4/check/openstack-tox-cover/085dd8a/cover/z_aa24a81b34d289b0_filter_py.html#t247","commit_id":"667b77c2c41b1b225dec6c12d1aeee6e2ac8ff37"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7a92974e00c19dbc5ad74dfdaa5a337932e0be48","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # Note: remember, we are using an iterator here. So only"},{"line_number":243,"context_line":"        # traverse this list once."},{"line_number":244,"context_line":"        consider_disabled_host \u003d False"},{"line_number":245,"context_line":"        if policy.check_is_host_admin(context) and filter_properties.get("},{"line_number":246,"context_line":"                \u0027scheduler_hints\u0027, {}).get(\u0027only_host\u0027):"},{"line_number":247,"context_line":"            consider_disabled_host \u003d True"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        hosts \u003d self.host_manager.get_all_host_states_share("},{"line_number":250,"context_line":"            elevated,"}],"source_content_type":"text/x-python","patch_set":4,"id":"225ed9fd_0909b1f5","line":247,"range":{"start_line":245,"start_character":1,"end_line":247,"end_character":41},"in_reply_to":"da9396bb_f6d0c899","updated":"2024-08-27 18:42:10.000000000","message":"Done","commit_id":"667b77c2c41b1b225dec6c12d1aeee6e2ac8ff37"}],"manila/scheduler/host_manager.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a6a3faaef8782f7d35a8d0a7465f3ee0edc1fb8d","unresolved":true,"context_lines":[{"line_number":637,"context_line":"        share_services \u003d db.service_get_all_by_topic("},{"line_number":638,"context_line":"            context,"},{"line_number":639,"context_line":"            topic,"},{"line_number":640,"context_line":"            disabled\u003dconsider_disabled_host"},{"line_number":641,"context_line":"        )"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        active_hosts \u003d set()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b4f525a_787a995b","line":640,"updated":"2024-08-17 16:49:15.000000000","message":"nit: add trailing comma","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d4d0a2df5b159fec42bf52813f80affdc00bbf05","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        share_services \u003d db.service_get_all_by_topic("},{"line_number":638,"context_line":"            context,"},{"line_number":639,"context_line":"            topic,"},{"line_number":640,"context_line":"            disabled\u003dconsider_disabled_host"},{"line_number":641,"context_line":"        )"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        active_hosts \u003d set()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d43a374e_8704a14c","line":640,"in_reply_to":"7b4f525a_787a995b","updated":"2024-08-20 10:43:34.000000000","message":"Done","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a6a3faaef8782f7d35a8d0a7465f3ee0edc1fb8d","unresolved":true,"context_lines":[{"line_number":645,"context_line":"            host \u003d service[\u0027host\u0027]"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"            # Warn about down services and remove them from host_state_map"},{"line_number":648,"context_line":"            if not utils.service_is_up(service) or ("},{"line_number":649,"context_line":"                    not consider_disabled_host and service[\u0027disabled\u0027]):"},{"line_number":650,"context_line":"                LOG.warning(\"Share service is down. (host: %s).\", host)"},{"line_number":651,"context_line":"                continue"},{"line_number":652,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f141fafe_4e5f215a","line":649,"range":{"start_line":648,"start_character":12,"end_line":649,"end_character":72},"updated":"2024-08-17 16:49:15.000000000","message":"Can you make it more readable as below\nservice_down \u003d not utils.service_is_up(service)\nnot_consider_disabled_host  \u003d not consider_disabled_host\nif service_down or (not_consider_disabled_host and service[\u0027disabled\u0027]):","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d4d0a2df5b159fec42bf52813f80affdc00bbf05","unresolved":false,"context_lines":[{"line_number":645,"context_line":"            host \u003d service[\u0027host\u0027]"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"            # Warn about down services and remove them from host_state_map"},{"line_number":648,"context_line":"            if not utils.service_is_up(service) or ("},{"line_number":649,"context_line":"                    not consider_disabled_host and service[\u0027disabled\u0027]):"},{"line_number":650,"context_line":"                LOG.warning(\"Share service is down. (host: %s).\", host)"},{"line_number":651,"context_line":"                continue"},{"line_number":652,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f1c3681_dcab4147","line":649,"range":{"start_line":648,"start_character":12,"end_line":649,"end_character":72},"in_reply_to":"f141fafe_4e5f215a","updated":"2024-08-20 10:43:34.000000000","message":"Done","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a6a3faaef8782f7d35a8d0a7465f3ee0edc1fb8d","unresolved":true,"context_lines":[{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        self._update_host_state_map("},{"line_number":686,"context_line":"            context,"},{"line_number":687,"context_line":"            consider_disabled_host\u003dconsider_disabled_host"},{"line_number":688,"context_line":"        )"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        # Build a pool_state map and return that map instead of host_state_map"}],"source_content_type":"text/x-python","patch_set":1,"id":"e2602d57_07e73aa7","line":687,"updated":"2024-08-17 16:49:15.000000000","message":"nit: trailing comma","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d4d0a2df5b159fec42bf52813f80affdc00bbf05","unresolved":false,"context_lines":[{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        self._update_host_state_map("},{"line_number":686,"context_line":"            context,"},{"line_number":687,"context_line":"            consider_disabled_host\u003dconsider_disabled_host"},{"line_number":688,"context_line":"        )"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        # Build a pool_state map and return that map instead of host_state_map"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7768616_30b15429","line":687,"in_reply_to":"e2602d57_07e73aa7","updated":"2024-08-20 10:43:34.000000000","message":"Done","commit_id":"7bb7c9ef939e1b8bc70b5dc90d93f8ff7bb6e48b"}],"releasenotes/notes/bug-2072552-allow-scheduling-to-disabled-host-82c93468ec322256.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d1d3b2e05b9f9bae42c2e684b25d5f3a94e8193","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manila will allow admin users to schedule share on \u0027disabled\u0027 host using"},{"line_number":5,"context_line":"    \u0027only_host\u0027 scheduler hint. Please note, \u0027disabled\u0027 host is up/running"},{"line_number":6,"context_line":"    (i.e. listening on RPC calls), but disabled using share service set API."},{"line_number":7,"context_line":"    For more details, please refer to"},{"line_number":8,"context_line":"    `launchpad bug 2072552 \u003chttps://bugs.launchpad.net/manila/+bug/2072552\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0c7f2c43_ac6392a2","line":6,"range":{"start_line":4,"start_character":3,"end_line":6,"end_character":75},"updated":"2024-08-27 15:48:15.000000000","message":"Maybe:\n```suggestion\n    Manila now allows OpenStack administrators to schedule shares creation\n    on hosts that are currently running and marked as under maintenance\n    (`disabled`) through the `only_host` scheduler hint.\n```","commit_id":"667b77c2c41b1b225dec6c12d1aeee6e2ac8ff37"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7a92974e00c19dbc5ad74dfdaa5a337932e0be48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manila will allow admin users to schedule share on \u0027disabled\u0027 host using"},{"line_number":5,"context_line":"    \u0027only_host\u0027 scheduler hint. Please note, \u0027disabled\u0027 host is up/running"},{"line_number":6,"context_line":"    (i.e. listening on RPC calls), but disabled using share service set API."},{"line_number":7,"context_line":"    For more details, please refer to"},{"line_number":8,"context_line":"    `launchpad bug 2072552 \u003chttps://bugs.launchpad.net/manila/+bug/2072552\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fb97bab3_06111541","line":6,"range":{"start_line":4,"start_character":3,"end_line":6,"end_character":75},"in_reply_to":"0c7f2c43_ac6392a2","updated":"2024-08-27 18:42:10.000000000","message":"Done","commit_id":"667b77c2c41b1b225dec6c12d1aeee6e2ac8ff37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ee668fdffb12fd34f1249e92b77213d19b6e56a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manila now allows OpenStack administrators to schedule shares creation"},{"line_number":5,"context_line":"    on hosts that are currently running and marked as under maintenance"},{"line_number":6,"context_line":"    (`disabled`) through the `only_host` scheduler hint."},{"line_number":7,"context_line":"    For more details, please refer to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7431ce94_1cad30bf","line":4,"range":{"start_line":4,"start_character":67,"end_line":4,"end_character":68},"updated":"2024-08-29 23:26:29.000000000","message":"drop \"creation\"; still conveys the same meaning","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"57205a03c1ce631784d787c6fb565528b81be05a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Manila now allows OpenStack administrators to schedule shares creation"},{"line_number":5,"context_line":"    on hosts that are currently running and marked as under maintenance"},{"line_number":6,"context_line":"    (`disabled`) through the `only_host` scheduler hint."},{"line_number":7,"context_line":"    For more details, please refer to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1817263d_1461a63f","line":4,"range":{"start_line":4,"start_character":67,"end_line":4,"end_character":68},"in_reply_to":"7431ce94_1cad30bf","updated":"2024-08-30 04:00:07.000000000","message":"Done","commit_id":"6f56fcbb25d2181acea22748612e7c097cd5ef39"}]}