)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79e6fb41b24e456c12037b2c725a4890b5109d3d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[NetApp] SnapLock support for NetApp driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The NetApp ONTAP driver now supports the SnapLock feature. A new"},{"line_number":10,"context_line":"extra spec, \u0027netapp:snaplock_type\u0027, has been added to create SnapLock"},{"line_number":11,"context_line":"volumes. Additionally, extra specs related to the SnapLock retention"},{"line_number":12,"context_line":"period have been introduced to set the retention period on SnapLock"},{"line_number":13,"context_line":"volumes. Along with this, the \u0027netapp_snaplock_type\u0027 capability has been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"707af045_bcf5c6c0","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":34},"updated":"2024-09-04 06:10:34.000000000","message":"this is redundant when you have `netapp_snaplock_type` added as you describe below","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a2bb2b968c494ff7c3c35088713b9072b9296453","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[NetApp] SnapLock support for NetApp driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The NetApp ONTAP driver now supports the SnapLock feature. A new"},{"line_number":10,"context_line":"extra spec, \u0027netapp:snaplock_type\u0027, has been added to create SnapLock"},{"line_number":11,"context_line":"volumes. Additionally, extra specs related to the SnapLock retention"},{"line_number":12,"context_line":"period have been introduced to set the retention period on SnapLock"},{"line_number":13,"context_line":"volumes. Along with this, the \u0027netapp_snaplock_type\u0027 capability has been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"0679a0c4_0ec8b774","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":34},"in_reply_to":"707af045_bcf5c6c0","updated":"2024-09-05 14:59:54.000000000","message":"Modify the code and changing the description.","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"9ff52548d241d622c6799a8e47c92648a518f91e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ec681a95_e81aa7c7","updated":"2024-08-21 05:38:06.000000000","message":"recheck","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"847df19c0577c7e5bce89504ed3978e02aba4b51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f74ff62_4fb57d9a","updated":"2024-08-21 08:21:36.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"3daa607820e5891a6cddc1255c84f1067b912824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"622bee20_ccc95276","updated":"2024-08-22 04:50:06.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"4897fd97f029578883753dd017a345a74d0ee6f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6f1242ea_c3a0d5b1","updated":"2024-08-21 09:18:18.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"b489badf08186ef974644d7acffbd37bfd42a91f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"955c64c1_23cc63e2","updated":"2024-08-22 02:55:51.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"87cdd53ef41a3874379c99432ddd9ee50a14a102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"96674aa3_47fd9536","updated":"2024-08-21 08:24:00.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"01b7f0383fc983a8ba603502489f22fa6189e0c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9abd0963_d0bce966","updated":"2024-08-22 05:24:53.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8852ef8d22ae46aa37bee9eb7955ef3d34eac6c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ab31750e_8a0515bd","updated":"2024-08-21 08:45:02.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"d74d510b13a3d1f7ec01a6abe03e48069f8bdf36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e7341e92_a07a3cb5","updated":"2024-08-22 04:37:40.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"f147e4469b8d074466f1379f416b0c7475e3ac97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f068ce3b_09ce422e","updated":"2024-08-22 03:11:53.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"5f79a3e53a4a0a9aaacb63991cf888e7389d8613"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8e8388e8_d0206310","updated":"2024-08-29 21:53:36.000000000","message":"Thank you for working on this change. Please take a look at the comments inline :)","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9fe94573_a3c5c9eb","updated":"2024-09-03 09:35:24.000000000","message":"Thanks Carlos and Goutham for your valuable comments. I have incorporated most of the comments. Please let me know if anything is missing.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"25442e85c45a47ab92dda0c404653b2835527532","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5e1e544c_bf1dfc53","updated":"2024-08-30 07:19:33.000000000","message":"run-NetApp CI","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79e6fb41b24e456c12037b2c725a4890b5109d3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b23d8ca1_b4530686","updated":"2024-09-04 06:10:34.000000000","message":"Hi Gireesh, since your CI isn\u0027t working.. was this tested somehow for regresions?\nPlease see some comments inline","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"56ab1016f9c32f2c608e5566244afd2de11616e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"57941bc3_5be56b9e","updated":"2024-09-03 16:16:44.000000000","message":"LGTM","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"462fec950fa107077b021b5614f3feaf625ce114","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1f1e6888_61eca6ac","updated":"2024-09-03 13:17:31.000000000","message":"Thank you for working on this change, Gireesh. IMHO we can leave the documentation concern for a follow-up PS.","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"86f54975887df874176884e42db92e0293f82c8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1195e396_e9c49fe5","updated":"2024-09-05 14:55:18.000000000","message":"Looks good to me. Thank you.","commit_id":"c7b9c6b5a48a9de1d62c3f4f1e4bf814ea9ebf3f"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"660b0b6b314da16f8766fa7e18532cfaeec2591b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d9c6706d_43800fe0","in_reply_to":"1195e396_e9c49fe5","updated":"2024-09-05 14:56:21.000000000","message":"Please fix the comments shared by Goutham.","commit_id":"c7b9c6b5a48a9de1d62c3f4f1e4bf814ea9ebf3f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36485ae53dbdc0bd471edf1133528a5b6cd86bc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d0d7e7c7_a777f03e","updated":"2024-09-05 18:59:35.000000000","message":"LGTM thanks Gireesh; minor comments inline if you make another patch, or a follow up change","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ea6526b4e6b66549df97932985ec0c8426db0b93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"31c0a0d3_5519da75","updated":"2024-09-05 19:02:04.000000000","message":"LGTM, thank you Gireesh, and everyone for sharing some feedback.\nPlease address Goutham\u0027s comments in a follow-up change :)","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a2bb2b968c494ff7c3c35088713b9072b9296453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b064ea8c_bcf80f3d","updated":"2024-09-05 14:59:54.000000000","message":"Thanks Goutham for your valuable comments, I have incorporated all of them, please have a look again.","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1e8c8a40b9f8e4f30fd117ae383b947082c0f286","unresolved":true,"context_lines":[{"line_number":6450,"context_line":"            self.send_request(\u0027volume-set-snaplock-attrs\u0027, api_args)"},{"line_number":6451,"context_line":""},{"line_number":6452,"context_line":"    @na_utils.trace"},{"line_number":6453,"context_line":"    def is_snaplock_enabled_volume(self, volume_name):"},{"line_number":6454,"context_line":"        \"\"\"Get whether volume is SnapLock enabled or disabled\"\"\""},{"line_number":6455,"context_line":"        vol_attr \u003d self.get_volume(volume_name)"},{"line_number":6456,"context_line":"        if vol_attr.get(\u0027snaplock-type\u0027) in (\"compliance\", \"enterprise\"):"}],"source_content_type":"text/x-python","patch_set":2,"id":"459b49ff_0560eaad","line":6453,"updated":"2024-08-13 13:32:03.000000000","message":"this function can be moved to common file as same used in rest API file.","commit_id":"a934318aee3060983cf398ef38bc5adcb30d30cd"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1f621fa7df50b1bf2df7c386d3e0b6ff294e7b13","unresolved":false,"context_lines":[{"line_number":6450,"context_line":"            self.send_request(\u0027volume-set-snaplock-attrs\u0027, api_args)"},{"line_number":6451,"context_line":""},{"line_number":6452,"context_line":"    @na_utils.trace"},{"line_number":6453,"context_line":"    def is_snaplock_enabled_volume(self, volume_name):"},{"line_number":6454,"context_line":"        \"\"\"Get whether volume is SnapLock enabled or disabled\"\"\""},{"line_number":6455,"context_line":"        vol_attr \u003d self.get_volume(volume_name)"},{"line_number":6456,"context_line":"        if vol_attr.get(\u0027snaplock-type\u0027) in (\"compliance\", \"enterprise\"):"}],"source_content_type":"text/x-python","patch_set":2,"id":"d0cd80b6_b61b7da3","line":6453,"in_reply_to":"459b49ff_0560eaad","updated":"2024-08-29 11:37:02.000000000","message":"only common place to move this file is in lib base but I am calling this method within the file. If I move this method to lib base I can\u0027t call this from client_cmode.. files. I make it private, hope that will be fine.","commit_id":"a934318aee3060983cf398ef38bc5adcb30d30cd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1e8c8a40b9f8e4f30fd117ae383b947082c0f286","unresolved":true,"context_lines":[{"line_number":6479,"context_line":"                                            api_args)"},{"line_number":6480,"context_line":"        else:"},{"line_number":6481,"context_line":"            return None"},{"line_number":6482,"context_line":"        if result is not None and self._has_records(result):"},{"line_number":6483,"context_line":"            attributes_list \u003d result.get_child_by_name("},{"line_number":6484,"context_line":"                \u0027attributes-list\u0027) or netapp_api.NaElement(\u0027none\u0027)"},{"line_number":6485,"context_line":"            vs_aggr_attributes \u003d attributes_list.get_child_by_name("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8dcbce_ad6faa16","line":6482,"updated":"2024-08-13 13:32:03.000000000","message":"this if block can be moved under above if check","commit_id":"a934318aee3060983cf398ef38bc5adcb30d30cd"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1f621fa7df50b1bf2df7c386d3e0b6ff294e7b13","unresolved":false,"context_lines":[{"line_number":6479,"context_line":"                                            api_args)"},{"line_number":6480,"context_line":"        else:"},{"line_number":6481,"context_line":"            return None"},{"line_number":6482,"context_line":"        if result is not None and self._has_records(result):"},{"line_number":6483,"context_line":"            attributes_list \u003d result.get_child_by_name("},{"line_number":6484,"context_line":"                \u0027attributes-list\u0027) or netapp_api.NaElement(\u0027none\u0027)"},{"line_number":6485,"context_line":"            vs_aggr_attributes \u003d attributes_list.get_child_by_name("}],"source_content_type":"text/x-python","patch_set":2,"id":"cca2dcf4_56122cf3","line":6482,"in_reply_to":"bf8dcbce_ad6faa16","updated":"2024-08-29 11:37:02.000000000","message":"This method might be classed multiple time so instead of adding this condition to calling function it is better to add this to method definition.","commit_id":"a934318aee3060983cf398ef38bc5adcb30d30cd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":2269,"context_line":"        if snaplock_type is not None:"},{"line_number":2270,"context_line":"            self.set_snaplock_attributes("},{"line_number":2271,"context_line":"                volume_name,"},{"line_number":2272,"context_line":"                options.get(\u0027snaplock_autocommit_period\u0027),"},{"line_number":2273,"context_line":"                options.get(\u0027snaplock_min_retention_period\u0027),"},{"line_number":2274,"context_line":"                options.get(\u0027snaplock_max_retention_period\u0027),"},{"line_number":2275,"context_line":"                options.get(\u0027snaplock_default_retention_period\u0027),"},{"line_number":2276,"context_line":"            )"},{"line_number":2277,"context_line":""},{"line_number":2278,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":6,"id":"16555dad_2017d255","line":2275,"range":{"start_line":2272,"start_character":0,"end_line":2275,"end_character":65},"updated":"2024-08-29 21:53:36.000000000","message":"maybe we can just send options to the method and get the values inside the method? that would avoid this same piece of code being repeated on line 2764","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":2269,"context_line":"        if snaplock_type is not None:"},{"line_number":2270,"context_line":"            self.set_snaplock_attributes("},{"line_number":2271,"context_line":"                volume_name,"},{"line_number":2272,"context_line":"                options.get(\u0027snaplock_autocommit_period\u0027),"},{"line_number":2273,"context_line":"                options.get(\u0027snaplock_min_retention_period\u0027),"},{"line_number":2274,"context_line":"                options.get(\u0027snaplock_max_retention_period\u0027),"},{"line_number":2275,"context_line":"                options.get(\u0027snaplock_default_retention_period\u0027),"},{"line_number":2276,"context_line":"            )"},{"line_number":2277,"context_line":""},{"line_number":2278,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":6,"id":"39e58ec8_783b9922","line":2275,"range":{"start_line":2272,"start_character":0,"end_line":2275,"end_character":65},"in_reply_to":"16555dad_2017d255","updated":"2024-09-03 09:35:24.000000000","message":"nice..! thanks for this suggestion. Made the changes.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":4154,"context_line":"        }"},{"line_number":4155,"context_line":""},{"line_number":4156,"context_line":"        if self.features.SNAPLOCK:"},{"line_number":4157,"context_line":"            desired_attributes[\u0027aggr-attributes\u0027][\u0027aggr-snaplock-attributes\u0027]\\"},{"line_number":4158,"context_line":"                \u003d {\u0027is-snaplock\u0027: None, \u0027snaplock-type\u0027: None}"},{"line_number":4159,"context_line":"        try:"},{"line_number":4160,"context_line":"            aggrs \u003d self._get_aggregates("},{"line_number":4161,"context_line":"                aggregate_names\u003d[aggregate_name],"}],"source_content_type":"text/x-python","patch_set":6,"id":"2ddfc41a_61ce9a3c","line":4158,"range":{"start_line":4157,"start_character":12,"end_line":4158,"end_character":62},"updated":"2024-08-29 21:53:36.000000000","message":"nit: please wrap this in parenthesis, i.e.:\n\n```suggestion\n            snaplock_attributes \u003d {\u0027is-snaplock\u0027: None, \u0027snaplock-type\u0027: None}\n            (desired_attributes[\u0027aggr-attributes\u0027][\n                \u0027aggr-snaplock-attributes\u0027] \u003d snaplock_attributes)\n```","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":4154,"context_line":"        }"},{"line_number":4155,"context_line":""},{"line_number":4156,"context_line":"        if self.features.SNAPLOCK:"},{"line_number":4157,"context_line":"            desired_attributes[\u0027aggr-attributes\u0027][\u0027aggr-snaplock-attributes\u0027]\\"},{"line_number":4158,"context_line":"                \u003d {\u0027is-snaplock\u0027: None, \u0027snaplock-type\u0027: None}"},{"line_number":4159,"context_line":"        try:"},{"line_number":4160,"context_line":"            aggrs \u003d self._get_aggregates("},{"line_number":4161,"context_line":"                aggregate_names\u003d[aggregate_name],"}],"source_content_type":"text/x-python","patch_set":6,"id":"11a941dd_abb96c12","line":4158,"range":{"start_line":4157,"start_character":12,"end_line":4158,"end_character":62},"in_reply_to":"2ddfc41a_61ce9a3c","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":6430,"context_line":"            \"snaplock-node-compliance-clock\""},{"line_number":6431,"context_line":"        )"},{"line_number":6432,"context_line":"        if not node_compliance_clock:"},{"line_number":6433,"context_line":"            raise exception.NetAppException(\"Compliance clock is not \""},{"line_number":6434,"context_line":"                                            \"configured for node %s\","},{"line_number":6435,"context_line":"                                            node_name)"},{"line_number":6436,"context_line":"        clock_info \u003d node_compliance_clock.get_child_by_name("}],"source_content_type":"text/x-python","patch_set":6,"id":"49cbe300_db7d7215","line":6433,"range":{"start_line":6433,"start_character":44,"end_line":6433,"end_character":45},"updated":"2024-08-29 21:53:36.000000000","message":"nit: please break this to the next line for a better readability","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":6430,"context_line":"            \"snaplock-node-compliance-clock\""},{"line_number":6431,"context_line":"        )"},{"line_number":6432,"context_line":"        if not node_compliance_clock:"},{"line_number":6433,"context_line":"            raise exception.NetAppException(\"Compliance clock is not \""},{"line_number":6434,"context_line":"                                            \"configured for node %s\","},{"line_number":6435,"context_line":"                                            node_name)"},{"line_number":6436,"context_line":"        clock_info \u003d node_compliance_clock.get_child_by_name("}],"source_content_type":"text/x-python","patch_set":6,"id":"436d6648_fd713824","line":6433,"range":{"start_line":6433,"start_character":44,"end_line":6433,"end_character":45},"in_reply_to":"49cbe300_db7d7215","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":6437,"context_line":"            \"compliance-clock-info\")"},{"line_number":6438,"context_line":"        clock_fmt_value \u003d clock_info.get_child_content("},{"line_number":6439,"context_line":"            \"formatted-snaplock-compliance-clock\")"},{"line_number":6440,"context_line":"        if clock_fmt_value \u003d\u003d \"ComplianceClock is not configured\":"},{"line_number":6441,"context_line":"            return False"},{"line_number":6442,"context_line":"        else:"},{"line_number":6443,"context_line":"            return True"},{"line_number":6444,"context_line":""},{"line_number":6445,"context_line":"    @na_utils.trace"},{"line_number":6446,"context_line":"    def set_snaplock_attributes(self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4fac54e1_ac3c6a53","line":6443,"range":{"start_line":6440,"start_character":8,"end_line":6443,"end_character":23},"updated":"2024-08-29 21:53:36.000000000","message":"I was thinking: is this the only message that the storage will return? Because if there is a period at the end or something, we\u0027d break. If fit is the case, I\u0027d suggest:\n```suggestion\n        return clock_fmt_value !\u003d \"ComplianceClock is not configured\"\n```\nOtherwise, we can use `return \"ComplianceClock is not configured\" not in clock_fmt_value`","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":6437,"context_line":"            \"compliance-clock-info\")"},{"line_number":6438,"context_line":"        clock_fmt_value \u003d clock_info.get_child_content("},{"line_number":6439,"context_line":"            \"formatted-snaplock-compliance-clock\")"},{"line_number":6440,"context_line":"        if clock_fmt_value \u003d\u003d \"ComplianceClock is not configured\":"},{"line_number":6441,"context_line":"            return False"},{"line_number":6442,"context_line":"        else:"},{"line_number":6443,"context_line":"            return True"},{"line_number":6444,"context_line":""},{"line_number":6445,"context_line":"    @na_utils.trace"},{"line_number":6446,"context_line":"    def set_snaplock_attributes(self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4c629242_89716bc7","line":6443,"range":{"start_line":6440,"start_character":8,"end_line":6443,"end_character":23},"in_reply_to":"4fac54e1_ac3c6a53","updated":"2024-09-03 09:35:24.000000000","message":"yes, this is better way, thanks and changed","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":6454,"context_line":"                                         snaplock_min_retention_period,"},{"line_number":6455,"context_line":"                                         snaplock_max_retention_period,"},{"line_number":6456,"context_line":"                                         snaplock_default_retention_period)):"},{"line_number":6457,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6458,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6459,"context_line":"            return"},{"line_number":6460,"context_line":"        else:"},{"line_number":6461,"context_line":"            api_args \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf064c6a_b58bd4e5","line":6458,"range":{"start_line":6457,"start_character":57,"end_line":6458,"end_character":51},"updated":"2024-08-29 21:53:36.000000000","message":"won\u0027t update SnapLock attributes.\n\nBut just out of curiosity: none of these keys are mandatory? I am asking that because with the current way, the if we only have autocommit_period, it would be accepted, if we only set min_retention_period, it would too... If only one of them are set, would the NetApp Storage have a default for the rest?","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"462fec950fa107077b021b5614f3feaf625ce114","unresolved":false,"context_lines":[{"line_number":6454,"context_line":"                                         snaplock_min_retention_period,"},{"line_number":6455,"context_line":"                                         snaplock_max_retention_period,"},{"line_number":6456,"context_line":"                                         snaplock_default_retention_period)):"},{"line_number":6457,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6458,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6459,"context_line":"            return"},{"line_number":6460,"context_line":"        else:"},{"line_number":6461,"context_line":"            api_args \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"3614154c_90defdc3","line":6458,"range":{"start_line":6457,"start_character":57,"end_line":6458,"end_character":51},"in_reply_to":"600ae8f5_81447525","updated":"2024-09-03 13:17:31.000000000","message":"Ack, thank you!","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":6454,"context_line":"                                         snaplock_min_retention_period,"},{"line_number":6455,"context_line":"                                         snaplock_max_retention_period,"},{"line_number":6456,"context_line":"                                         snaplock_default_retention_period)):"},{"line_number":6457,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6458,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6459,"context_line":"            return"},{"line_number":6460,"context_line":"        else:"},{"line_number":6461,"context_line":"            api_args \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"600ae8f5_81447525","line":6458,"range":{"start_line":6457,"start_character":57,"end_line":6458,"end_character":51},"in_reply_to":"bf064c6a_b58bd4e5","updated":"2024-09-03 09:35:24.000000000","message":"done the message changes.\nyes, NetApp Storage have a default for the rest.\nif we are not passing any of these values, default value will be set for all these key fields. If we are passing only one value then that value will be override the default value for that field, and for rest of the field it would be the default value.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":6450,"context_line":"                                snaplock_max_retention_period\u003dNone,"},{"line_number":6451,"context_line":"                                snaplock_default_retention_period\u003dNone):"},{"line_number":6452,"context_line":"        \"\"\"Set the retention period for SnapLock enabled volume\"\"\""},{"line_number":6453,"context_line":"        if all(attr is None for attr in (snaplock_autocommit_period,"},{"line_number":6454,"context_line":"                                         snaplock_min_retention_period,"},{"line_number":6455,"context_line":"                                         snaplock_max_retention_period,"},{"line_number":6456,"context_line":"                                         snaplock_default_retention_period)):"},{"line_number":6457,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6458,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6459,"context_line":"            return"},{"line_number":6460,"context_line":"        else:"},{"line_number":6461,"context_line":"            api_args \u003d {"},{"line_number":6462,"context_line":"                \u0027volume\u0027: volume_name,"},{"line_number":6463,"context_line":"            }"},{"line_number":6464,"context_line":"            if snaplock_autocommit_period is not None:"},{"line_number":6465,"context_line":"                api_args[\u0027autocommit-period\u0027] \u003d snaplock_autocommit_period"},{"line_number":6466,"context_line":"            if snaplock_default_retention_period is not None:"},{"line_number":6467,"context_line":"                if snaplock_default_retention_period \u003d\u003d \"min\":"},{"line_number":6468,"context_line":"                    snaplock_default_retention_period \u003d\\"},{"line_number":6469,"context_line":"                        snaplock_min_retention_period"},{"line_number":6470,"context_line":"                elif snaplock_default_retention_period \u003d\u003d \u0027max\u0027:"},{"line_number":6471,"context_line":"                    snaplock_default_retention_period \u003d\\"},{"line_number":6472,"context_line":"                        snaplock_max_retention_period"},{"line_number":6473,"context_line":"                api_args[\u0027default-retention-period\u0027] \u003d ("},{"line_number":6474,"context_line":"                    snaplock_default_retention_period)"},{"line_number":6475,"context_line":"            if snaplock_min_retention_period is not None:"},{"line_number":6476,"context_line":"                api_args[\u0027minimum-retention-period\u0027] \u003d\\"},{"line_number":6477,"context_line":"                    snaplock_min_retention_period"},{"line_number":6478,"context_line":"            if snaplock_max_retention_period is not None:"},{"line_number":6479,"context_line":"                api_args[\u0027maximum-retention-period\u0027] \u003d\\"},{"line_number":6480,"context_line":"                    snaplock_max_retention_period"},{"line_number":6481,"context_line":"            self.send_request(\u0027volume-set-snaplock-attrs\u0027, api_args)"},{"line_number":6482,"context_line":""},{"line_number":6483,"context_line":"    @na_utils.trace"},{"line_number":6484,"context_line":"    def _is_snaplock_enabled_volume(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bb036dbc_8b3e8d1f","line":6481,"range":{"start_line":6453,"start_character":8,"end_line":6481,"end_character":68},"updated":"2024-08-29 21:53:36.000000000","message":"A suggestion to add a bit more of readability to this method, as multiple if/else statements can be a bit confusing. I couldn\u0027t test it myself, so would be nice if you have the chance to.\n```suggestion\n        api_args \u003d {}\n\n        snaplock_attribute_mapping \u003d {\n            \u0027snaplock_autocommit_period\u0027: \u0027autocommit-period\u0027,\n            \u0027snaplock_min_retention_period\u0027: \u0027minimum-retention-period\u0027,\n            \u0027snaplock_max_retention_period\u0027: \u0027maximum-retention-period\u0027,\n            \u0027snaplock_default_retention_period\u0027: \u0027default-retention-period\u0027\n        }\n\n        for share_type_attr, na_api_attr in snaplock_attribute_mapping.items():\n            if options.get(share_type_attr):\n                api_args[na_api_attr] \u003d options.get(share_type_attr)\n\n        if all(value is None for value in api_args.values()):\n            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\"\n                      \" updated SnapLock attributes\")\n            return\n\n        api_args[\u0027volume\u0027] \u003d volume_name\n        default_retention_period \u003d options.get(\n            \u0027snaplock_default_retention_period\u0027\n        )\n        if default_retention_period and default_retention_period \u003d\u003d \"max\":\n            api_args[\u0027default-retention-period\u0027] \u003d (\n                api_args[\u0027maximum-retention-period\u0027]\n            )\n        elif default_retention_period and default_retention_period \u003d\u003d \"min\":\n            api_args[\u0027default-retention-period\u0027] \u003d (\n                api_args[\u0027minimum-retention-period\u0027]\n            )\n\n        self.send_request(\u0027volume-set-snaplock-attrs\u0027, api_args)\n```","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":6450,"context_line":"                                snaplock_max_retention_period\u003dNone,"},{"line_number":6451,"context_line":"                                snaplock_default_retention_period\u003dNone):"},{"line_number":6452,"context_line":"        \"\"\"Set the retention period for SnapLock enabled volume\"\"\""},{"line_number":6453,"context_line":"        if all(attr is None for attr in (snaplock_autocommit_period,"},{"line_number":6454,"context_line":"                                         snaplock_min_retention_period,"},{"line_number":6455,"context_line":"                                         snaplock_max_retention_period,"},{"line_number":6456,"context_line":"                                         snaplock_default_retention_period)):"},{"line_number":6457,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6458,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6459,"context_line":"            return"},{"line_number":6460,"context_line":"        else:"},{"line_number":6461,"context_line":"            api_args \u003d {"},{"line_number":6462,"context_line":"                \u0027volume\u0027: volume_name,"},{"line_number":6463,"context_line":"            }"},{"line_number":6464,"context_line":"            if snaplock_autocommit_period is not None:"},{"line_number":6465,"context_line":"                api_args[\u0027autocommit-period\u0027] \u003d snaplock_autocommit_period"},{"line_number":6466,"context_line":"            if snaplock_default_retention_period is not None:"},{"line_number":6467,"context_line":"                if snaplock_default_retention_period \u003d\u003d \"min\":"},{"line_number":6468,"context_line":"                    snaplock_default_retention_period \u003d\\"},{"line_number":6469,"context_line":"                        snaplock_min_retention_period"},{"line_number":6470,"context_line":"                elif snaplock_default_retention_period \u003d\u003d \u0027max\u0027:"},{"line_number":6471,"context_line":"                    snaplock_default_retention_period \u003d\\"},{"line_number":6472,"context_line":"                        snaplock_max_retention_period"},{"line_number":6473,"context_line":"                api_args[\u0027default-retention-period\u0027] \u003d ("},{"line_number":6474,"context_line":"                    snaplock_default_retention_period)"},{"line_number":6475,"context_line":"            if snaplock_min_retention_period is not None:"},{"line_number":6476,"context_line":"                api_args[\u0027minimum-retention-period\u0027] \u003d\\"},{"line_number":6477,"context_line":"                    snaplock_min_retention_period"},{"line_number":6478,"context_line":"            if snaplock_max_retention_period is not None:"},{"line_number":6479,"context_line":"                api_args[\u0027maximum-retention-period\u0027] \u003d\\"},{"line_number":6480,"context_line":"                    snaplock_max_retention_period"},{"line_number":6481,"context_line":"            self.send_request(\u0027volume-set-snaplock-attrs\u0027, api_args)"},{"line_number":6482,"context_line":""},{"line_number":6483,"context_line":"    @na_utils.trace"},{"line_number":6484,"context_line":"    def _is_snaplock_enabled_volume(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e66845dc_e050a06f","line":6481,"range":{"start_line":6453,"start_character":8,"end_line":6481,"end_character":68},"in_reply_to":"bb036dbc_8b3e8d1f","updated":"2024-09-03 09:35:24.000000000","message":"This is nice and optimize one, thanks for suggesting this. I made the changes.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":6484,"context_line":"    def _is_snaplock_enabled_volume(self, volume_name):"},{"line_number":6485,"context_line":"        \"\"\"Get whether volume is SnapLock enabled or disabled\"\"\""},{"line_number":6486,"context_line":"        vol_attr \u003d self.get_volume(volume_name)"},{"line_number":6487,"context_line":"        if vol_attr.get(\u0027snaplock-type\u0027) in (\"compliance\", \"enterprise\"):"},{"line_number":6488,"context_line":"            return True"},{"line_number":6489,"context_line":"        else:"},{"line_number":6490,"context_line":"            return False"},{"line_number":6491,"context_line":""},{"line_number":6492,"context_line":"    @na_utils.trace"},{"line_number":6493,"context_line":"    def get_vserver_aggr_snaplock_type(self, aggr_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9397f62a_fdef4f20","line":6490,"range":{"start_line":6487,"start_character":8,"end_line":6490,"end_character":24},"updated":"2024-08-29 21:53:36.000000000","message":"```suggestion\n        return vol_attr.get(\u0027snaplock-type\u0027) in (\"compliance\", \"enterprise\")\n```","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":6484,"context_line":"    def _is_snaplock_enabled_volume(self, volume_name):"},{"line_number":6485,"context_line":"        \"\"\"Get whether volume is SnapLock enabled or disabled\"\"\""},{"line_number":6486,"context_line":"        vol_attr \u003d self.get_volume(volume_name)"},{"line_number":6487,"context_line":"        if vol_attr.get(\u0027snaplock-type\u0027) in (\"compliance\", \"enterprise\"):"},{"line_number":6488,"context_line":"            return True"},{"line_number":6489,"context_line":"        else:"},{"line_number":6490,"context_line":"            return False"},{"line_number":6491,"context_line":""},{"line_number":6492,"context_line":"    @na_utils.trace"},{"line_number":6493,"context_line":"    def get_vserver_aggr_snaplock_type(self, aggr_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fb2f83e_27e08252","line":6490,"range":{"start_line":6487,"start_character":8,"end_line":6490,"end_character":24},"in_reply_to":"9397f62a_fdef4f20","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79e6fb41b24e456c12037b2c725a4890b5109d3d","unresolved":true,"context_lines":[{"line_number":6427,"context_line":"            \"compliance-clock-info\")"},{"line_number":6428,"context_line":"        clock_fmt_value \u003d clock_info.get_child_content("},{"line_number":6429,"context_line":"            \"formatted-snaplock-compliance-clock\")"},{"line_number":6430,"context_line":"        return clock_fmt_value !\u003d \"ComplianceClock is not configured\""},{"line_number":6431,"context_line":""},{"line_number":6432,"context_line":"    @na_utils.trace"},{"line_number":6433,"context_line":"    def set_snaplock_attributes(self, volume_name, **options):"}],"source_content_type":"text/x-python","patch_set":9,"id":"20958d47_18d06541","line":6430,"range":{"start_line":6430,"start_character":15,"end_line":6430,"end_character":69},"updated":"2024-09-04 06:10:34.000000000","message":"imo, \n\n1) please compare substrings: \"not configured\" is probably sufficient\n2) make sure to lowercase server value prior to comparison","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a2bb2b968c494ff7c3c35088713b9072b9296453","unresolved":false,"context_lines":[{"line_number":6427,"context_line":"            \"compliance-clock-info\")"},{"line_number":6428,"context_line":"        clock_fmt_value \u003d clock_info.get_child_content("},{"line_number":6429,"context_line":"            \"formatted-snaplock-compliance-clock\")"},{"line_number":6430,"context_line":"        return clock_fmt_value !\u003d \"ComplianceClock is not configured\""},{"line_number":6431,"context_line":""},{"line_number":6432,"context_line":"    @na_utils.trace"},{"line_number":6433,"context_line":"    def set_snaplock_attributes(self, volume_name, **options):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dcf5db62_d8696b83","line":6430,"range":{"start_line":6430,"start_character":15,"end_line":6430,"end_character":69},"in_reply_to":"20958d47_18d06541","updated":"2024-09-05 14:59:54.000000000","message":"done","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79e6fb41b24e456c12037b2c725a4890b5109d3d","unresolved":true,"context_lines":[{"line_number":6444,"context_line":"                api_args[na_api_attr] \u003d options.get(share_type_attr)"},{"line_number":6445,"context_line":""},{"line_number":6446,"context_line":"        if all(value is None for value in api_args.values()):"},{"line_number":6447,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6448,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6449,"context_line":"            return"},{"line_number":6450,"context_line":""},{"line_number":6451,"context_line":"        api_args[\u0027volume\u0027] \u003d volume_name"}],"source_content_type":"text/x-python","patch_set":9,"id":"269aa41a_df4c7bbf","line":6448,"range":{"start_line":6447,"start_character":57,"end_line":6448,"end_character":31},"updated":"2024-09-04 06:10:34.000000000","message":"not updating","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a2bb2b968c494ff7c3c35088713b9072b9296453","unresolved":false,"context_lines":[{"line_number":6444,"context_line":"                api_args[na_api_attr] \u003d options.get(share_type_attr)"},{"line_number":6445,"context_line":""},{"line_number":6446,"context_line":"        if all(value is None for value in api_args.values()):"},{"line_number":6447,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6448,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6449,"context_line":"            return"},{"line_number":6450,"context_line":""},{"line_number":6451,"context_line":"        api_args[\u0027volume\u0027] \u003d volume_name"}],"source_content_type":"text/x-python","patch_set":9,"id":"424910d5_067f96a0","line":6448,"range":{"start_line":6447,"start_character":57,"end_line":6448,"end_character":31},"in_reply_to":"269aa41a_df4c7bbf","updated":"2024-09-05 14:59:54.000000000","message":"Done","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36485ae53dbdc0bd471edf1133528a5b6cd86bc7","unresolved":true,"context_lines":[{"line_number":6476,"context_line":"                api_args[na_api_attr] \u003d options.get(share_type_attr)"},{"line_number":6477,"context_line":""},{"line_number":6478,"context_line":"        if all(value is None for value in api_args.values()):"},{"line_number":6479,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6480,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6481,"context_line":"            return"},{"line_number":6482,"context_line":""},{"line_number":6483,"context_line":"        api_args[\u0027volume\u0027] \u003d volume_name"}],"source_content_type":"text/x-python","patch_set":11,"id":"6ca12166_4d5a953e","line":6480,"range":{"start_line":6479,"start_character":57,"end_line":6480,"end_character":31},"updated":"2024-09-05 18:59:35.000000000","message":"\"not updating\"","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ab44a37d099995eb0caaeabc8d5333054b83f80f","unresolved":false,"context_lines":[{"line_number":6476,"context_line":"                api_args[na_api_attr] \u003d options.get(share_type_attr)"},{"line_number":6477,"context_line":""},{"line_number":6478,"context_line":"        if all(value is None for value in api_args.values()):"},{"line_number":6479,"context_line":"            LOG.debug(\"All SnapLock attributes are None, doesn\u0027t\""},{"line_number":6480,"context_line":"                      \" updated SnapLock attributes\")"},{"line_number":6481,"context_line":"            return"},{"line_number":6482,"context_line":""},{"line_number":6483,"context_line":"        api_args[\u0027volume\u0027] \u003d volume_name"}],"source_content_type":"text/x-python","patch_set":11,"id":"d27a28dc_5a801386","line":6480,"range":{"start_line":6479,"start_character":57,"end_line":6480,"end_character":31},"in_reply_to":"6ca12166_4d5a953e","updated":"2024-09-09 13:23:39.000000000","message":"Fixed as part of patch https://review.opendev.org/c/openstack/manila/+/928608","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":5541,"context_line":"            \u0027get\u0027"},{"line_number":5542,"context_line":"        )"},{"line_number":5543,"context_line":"        clock_fmt_value \u003d response.get(\u0027time\u0027)"},{"line_number":5544,"context_line":"        if clock_fmt_value \u003d\u003d \"ComplianceClock is not configured\":"},{"line_number":5545,"context_line":"            return False"},{"line_number":5546,"context_line":"        else:"},{"line_number":5547,"context_line":"            return True"},{"line_number":5548,"context_line":""},{"line_number":5549,"context_line":"    @na_utils.trace"},{"line_number":5550,"context_line":"    def set_snaplock_attributes(self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0a046756_c062e6be","line":5547,"range":{"start_line":5544,"start_character":8,"end_line":5547,"end_character":23},"updated":"2024-08-29 21:53:36.000000000","message":"same as in the other file","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":5541,"context_line":"            \u0027get\u0027"},{"line_number":5542,"context_line":"        )"},{"line_number":5543,"context_line":"        clock_fmt_value \u003d response.get(\u0027time\u0027)"},{"line_number":5544,"context_line":"        if clock_fmt_value \u003d\u003d \"ComplianceClock is not configured\":"},{"line_number":5545,"context_line":"            return False"},{"line_number":5546,"context_line":"        else:"},{"line_number":5547,"context_line":"            return True"},{"line_number":5548,"context_line":""},{"line_number":5549,"context_line":"    @na_utils.trace"},{"line_number":5550,"context_line":"    def set_snaplock_attributes(self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d92b630f_d2d7b11c","line":5547,"range":{"start_line":5544,"start_character":8,"end_line":5547,"end_character":23},"in_reply_to":"0a046756_c062e6be","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":5547,"context_line":"            return True"},{"line_number":5548,"context_line":""},{"line_number":5549,"context_line":"    @na_utils.trace"},{"line_number":5550,"context_line":"    def set_snaplock_attributes(self,"},{"line_number":5551,"context_line":"                                volume_name,"},{"line_number":5552,"context_line":"                                snaplock_autocommit_period\u003dNone,"},{"line_number":5553,"context_line":"                                snaplock_min_retention_period\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a653a1cc_f26d5df3","line":5550,"updated":"2024-08-29 21:53:36.000000000","message":"same as the method in the client_cmode","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":5547,"context_line":"            return True"},{"line_number":5548,"context_line":""},{"line_number":5549,"context_line":"    @na_utils.trace"},{"line_number":5550,"context_line":"    def set_snaplock_attributes(self,"},{"line_number":5551,"context_line":"                                volume_name,"},{"line_number":5552,"context_line":"                                snaplock_autocommit_period\u003dNone,"},{"line_number":5553,"context_line":"                                snaplock_min_retention_period\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"74ab9b75_df9ccfb0","line":5550,"in_reply_to":"a653a1cc_f26d5df3","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":5601,"context_line":"    def _is_snaplock_enabled_volume(self, volume_name):"},{"line_number":5602,"context_line":"        \"\"\"Get whether volume is SnapLock enabled or disabled\"\"\""},{"line_number":5603,"context_line":"        vol_attr \u003d self.get_volume(volume_name)"},{"line_number":5604,"context_line":"        if vol_attr.get(\u0027snaplock-type\u0027) in (\"compliance\", \"enterprise\"):"},{"line_number":5605,"context_line":"            return True"},{"line_number":5606,"context_line":"        else:"},{"line_number":5607,"context_line":"            return False"},{"line_number":5608,"context_line":""},{"line_number":5609,"context_line":"    @na_utils.trace"},{"line_number":5610,"context_line":"    def _get_cluster_node_uuid(self, node_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e2a72186_ca0c653d","line":5607,"range":{"start_line":5604,"start_character":8,"end_line":5607,"end_character":24},"updated":"2024-08-29 21:53:36.000000000","message":"same about the one line return","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":5601,"context_line":"    def _is_snaplock_enabled_volume(self, volume_name):"},{"line_number":5602,"context_line":"        \"\"\"Get whether volume is SnapLock enabled or disabled\"\"\""},{"line_number":5603,"context_line":"        vol_attr \u003d self.get_volume(volume_name)"},{"line_number":5604,"context_line":"        if vol_attr.get(\u0027snaplock-type\u0027) in (\"compliance\", \"enterprise\"):"},{"line_number":5605,"context_line":"            return True"},{"line_number":5606,"context_line":"        else:"},{"line_number":5607,"context_line":"            return False"},{"line_number":5608,"context_line":""},{"line_number":5609,"context_line":"    @na_utils.trace"},{"line_number":5610,"context_line":"    def _get_cluster_node_uuid(self, node_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"aa23a1b9_33ea703f","line":5607,"range":{"start_line":5604,"start_character":8,"end_line":5607,"end_character":24},"in_reply_to":"e2a72186_ca0c653d","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"caf5b085b9116c450ffb828fd08d6af38e1baefe","unresolved":true,"context_lines":[{"line_number":1039,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":1040,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":1041,"context_line":"                                adaptive_qos_policy_group,"},{"line_number":1042,"context_line":"                                mount_point_name, snaplock_type):"},{"line_number":1043,"context_line":"        \"\"\"Builds the body to volume creation request.\"\"\""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"dfc0017e_b782382e","line":1042,"updated":"2024-09-05 15:35:08.000000000","message":"Can you restore mount_point_name\u003dNone","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3cb3edde512519afc5b0e887dda4342f569a4f7a","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":1040,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":1041,"context_line":"                                adaptive_qos_policy_group,"},{"line_number":1042,"context_line":"                                mount_point_name, snaplock_type):"},{"line_number":1043,"context_line":"        \"\"\"Builds the body to volume creation request.\"\"\""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"f91b1931_1592d639","line":1042,"in_reply_to":"0ea6a1f3_f0f3f561","updated":"2024-09-05 17:16:45.000000000","message":"That is wrong which I have fix, why it was set to none, could you please explain ..?","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"2a8833b9d463df60fc5c37587a42b4106dff82df","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":1040,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":1041,"context_line":"                                adaptive_qos_policy_group,"},{"line_number":1042,"context_line":"                                mount_point_name, snaplock_type):"},{"line_number":1043,"context_line":"        \"\"\"Builds the body to volume creation request.\"\"\""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"b03a7a6b_7106b5eb","line":1042,"in_reply_to":"59d543f2_7e1da4ea","updated":"2024-09-05 17:32:53.000000000","message":"Can you tell me where else it will be called, this is local method with in that function. In future if this need to do, let make the changes at that time.","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"30490b87ca8873e27475084675f2105fc006e4d3","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":1040,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":1041,"context_line":"                                adaptive_qos_policy_group,"},{"line_number":1042,"context_line":"                                mount_point_name, snaplock_type):"},{"line_number":1043,"context_line":"        \"\"\"Builds the body to volume creation request.\"\"\""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"ccabf7db_df8dc528","line":1042,"in_reply_to":"b03a7a6b_7106b5eb","updated":"2024-09-05 17:39:14.000000000","message":"by removing none you will force caller of this function to pass mount_point_name always. which is optional\n \nif optional mount_point_name is not present then volume_name is used for mount_point_name by this code mount_point_name \u003d mount_point_name or volume_name","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"7232256718c7345150f33d9c61c3bf11ff816bb6","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":1040,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":1041,"context_line":"                                adaptive_qos_policy_group,"},{"line_number":1042,"context_line":"                                mount_point_name, snaplock_type):"},{"line_number":1043,"context_line":"        \"\"\"Builds the body to volume creation request.\"\"\""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"2616f8b6_f161335d","line":1042,"in_reply_to":"ccabf7db_df8dc528","updated":"2024-09-05 18:32:00.000000000","message":"Thank you for the comment.\n \nThe method _get_create_volume_body is called only once in the entire code, and it is invoked from the parent function create_volume_async. The parent function create_volume_async is already setting mount_point_name\u003dNone, and so the same would be passed to _get_create_volume_body.\n \nI agree that, if someone else is invoking _get_create_volume_body directly, they may ignore to pass mount_point_name\u003dNone.\n \nAs we are invoking only one time here, and in case if someone is invoking _get_create_volume_body in the future, we need to make sure \"mount_point_name\u003dNone\" to be passed similar to how it is done in create_volume_async. This is noted, and we\u0027ll follow the practice. In the future, if it is getting invoked, we can refactor the method.","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3172f5346234feeef8db875095a988a6389cef1f","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":1040,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":1041,"context_line":"                                adaptive_qos_policy_group,"},{"line_number":1042,"context_line":"                                mount_point_name, snaplock_type):"},{"line_number":1043,"context_line":"        \"\"\"Builds the body to volume creation request.\"\"\""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"e88a654b_db34cdc5","line":1042,"in_reply_to":"dfc0017e_b782382e","updated":"2024-09-05 15:48:10.000000000","message":"_get_create_volume_body, method is getting called from create_volume_async and in this we have already set it to none, again setting it to none is not right approach. Previous it was none and I fix this as part of this patch.","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"65270082827a5bf8fec19ad9cced4655f250c779","unresolved":true,"context_lines":[{"line_number":1039,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":1040,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":1041,"context_line":"                                adaptive_qos_policy_group,"},{"line_number":1042,"context_line":"                                mount_point_name, snaplock_type):"},{"line_number":1043,"context_line":"        \"\"\"Builds the body to volume creation request.\"\"\""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"0ea6a1f3_f0f3f561","line":1042,"in_reply_to":"e88a654b_db34cdc5","updated":"2024-09-05 17:04:24.000000000","message":"None one is setting to None. Defaulting to None. there is a difference.","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e8310413428d5b865a0930945137cae364ea86dc","unresolved":true,"context_lines":[{"line_number":1039,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":1040,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":1041,"context_line":"                                adaptive_qos_policy_group,"},{"line_number":1042,"context_line":"                                mount_point_name, snaplock_type):"},{"line_number":1043,"context_line":"        \"\"\"Builds the body to volume creation request.\"\"\""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"59d543f2_7e1da4ea","line":1042,"in_reply_to":"f91b1931_1592d639","updated":"2024-09-05 17:21:05.000000000","message":"what is the grantee that create_volume_async is only used by create_volume_async function?","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4869252e11a209480d65aefe05e166445086f92","unresolved":true,"context_lines":[{"line_number":118,"context_line":"        \u0027netapp:fpolicy_extensions_to_exclude\u0027:"},{"line_number":119,"context_line":"            \u0027fpolicy_extensions_to_exclude\u0027,"},{"line_number":120,"context_line":"        \u0027netapp:fpolicy_file_operations\u0027: \u0027fpolicy_file_operations\u0027,"},{"line_number":121,"context_line":"        \u0027netapp:snaplock_type\u0027: \u0027snaplock_type\u0027,"},{"line_number":122,"context_line":"        \u0027netapp:snaplock_autocommit_period\u0027:"},{"line_number":123,"context_line":"            \u0027snaplock_autocommit_period\u0027,"},{"line_number":124,"context_line":"        \u0027netapp:snaplock_min_retention_period\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"40f0643c_b69a8cb5","line":121,"range":{"start_line":121,"start_character":9,"end_line":121,"end_character":30},"updated":"2024-08-30 00:50:17.000000000","message":"This is being declared as a scoped extra-spec, but, on line 2576, you\u0027re also reading/setting a pool capability: netapp_snaplock_type","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \u0027netapp:fpolicy_extensions_to_exclude\u0027:"},{"line_number":119,"context_line":"            \u0027fpolicy_extensions_to_exclude\u0027,"},{"line_number":120,"context_line":"        \u0027netapp:fpolicy_file_operations\u0027: \u0027fpolicy_file_operations\u0027,"},{"line_number":121,"context_line":"        \u0027netapp:snaplock_type\u0027: \u0027snaplock_type\u0027,"},{"line_number":122,"context_line":"        \u0027netapp:snaplock_autocommit_period\u0027:"},{"line_number":123,"context_line":"            \u0027snaplock_autocommit_period\u0027,"},{"line_number":124,"context_line":"        \u0027netapp:snaplock_min_retention_period\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"615ec54a_2f9c5bf7","line":121,"range":{"start_line":121,"start_character":9,"end_line":121,"end_character":30},"in_reply_to":"40f0643c_b69a8cb5","updated":"2024-09-03 09:35:24.000000000","message":"\"netapp:snaplock_type\" this is volume type extra specs which is require to create SnapLock share with either \"Enterprise\" or \"Compliance\". While netapp_snaplock_type capability is added to filter the specific pool. We have below user cases for this \n1. Before 9.10.1 (before unified aggregate support) SnapLock type is supported at aggregate level so we can create \"Enterprise\" volume only under \"Enterprise\" aggregate, same for compliance.So, in this case if user wanted to create \"Enterprise\" volume (share) then he has to also add \"netapp_snaplock_type\" to in volume type extra specs to filter the right aggregate for volume creation.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4869252e11a209480d65aefe05e166445086f92","unresolved":true,"context_lines":[{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    @na_utils.trace"},{"line_number":1402,"context_line":"    def _check_snaplock_type(self, share, value):"},{"line_number":1403,"context_line":"        \"\"\"Chcek SnapLock type\"\"\""},{"line_number":1404,"context_line":"        if value not in self.SNAPLOCK_TYPE:"},{"line_number":1405,"context_line":"            args \u003d {\u0027snaplock_type\u0027: value,"},{"line_number":1406,"context_line":"                    \u0027extra_spec\u0027: \u0027netapp:snaplock_type\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b3202f2a_c9b2f501","line":1403,"range":{"start_line":1403,"start_character":11,"end_line":1403,"end_character":16},"updated":"2024-08-30 00:50:17.000000000","message":"typo","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    @na_utils.trace"},{"line_number":1402,"context_line":"    def _check_snaplock_type(self, share, value):"},{"line_number":1403,"context_line":"        \"\"\"Chcek SnapLock type\"\"\""},{"line_number":1404,"context_line":"        if value not in self.SNAPLOCK_TYPE:"},{"line_number":1405,"context_line":"            args \u003d {\u0027snaplock_type\u0027: value,"},{"line_number":1406,"context_line":"                    \u0027extra_spec\u0027: \u0027netapp:snaplock_type\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"eba43b32_2ca2ef2a","line":1403,"range":{"start_line":1403,"start_character":11,"end_line":1403,"end_character":16},"in_reply_to":"b3202f2a_c9b2f501","updated":"2024-09-03 09:35:24.000000000","message":"Corrected","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":1413,"context_line":"            raise exception.NetAppException(msg % args)"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    @na_utils.trace"},{"line_number":1416,"context_line":"    def _check_snaplock_attributes(self, share, key, value):"},{"line_number":1417,"context_line":"        \"\"\"Validate the SnapLock retention periods\"\"\""},{"line_number":1418,"context_line":"        valid_units_for_period \u003d [\"minutes\", \"hours\", \"days\","},{"line_number":1419,"context_line":"                                  \"months\", \"years\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"a197bf38_b108c225","line":1416,"updated":"2024-08-29 21:53:36.000000000","message":"some parts of this method aren\u0027t being unit tested: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_48b/926049/6/check/openstack-tox-cover/48bf615/cover/z_a8cfac5052a75b06_lib_base_py.html#t1416 - could you please take a look?","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"462fec950fa107077b021b5614f3feaf625ce114","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"            raise exception.NetAppException(msg % args)"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    @na_utils.trace"},{"line_number":1416,"context_line":"    def _check_snaplock_attributes(self, share, key, value):"},{"line_number":1417,"context_line":"        \"\"\"Validate the SnapLock retention periods\"\"\""},{"line_number":1418,"context_line":"        valid_units_for_period \u003d [\"minutes\", \"hours\", \"days\","},{"line_number":1419,"context_line":"                                  \"months\", \"years\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"dec72eac_3aa308a7","line":1416,"in_reply_to":"422d769b_4ad0040d","updated":"2024-09-03 13:17:31.000000000","message":"ack, ty :)","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"            raise exception.NetAppException(msg % args)"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    @na_utils.trace"},{"line_number":1416,"context_line":"    def _check_snaplock_attributes(self, share, key, value):"},{"line_number":1417,"context_line":"        \"\"\"Validate the SnapLock retention periods\"\"\""},{"line_number":1418,"context_line":"        valid_units_for_period \u003d [\"minutes\", \"hours\", \"days\","},{"line_number":1419,"context_line":"                                  \"months\", \"years\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"422d769b_4ad0040d","line":1416,"in_reply_to":"a197bf38_b108c225","updated":"2024-09-03 09:35:24.000000000","message":"I have unit test for that but, there is some copy paste issue, forgot to change the key for other test. I fix the unit test for this, now line will be cover.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4869252e11a209480d65aefe05e166445086f92","unresolved":true,"context_lines":[{"line_number":1445,"context_line":"            if not is_matched:"},{"line_number":1446,"context_line":"                self._throw_snaplock_exception(share, key, value, extra_msg)"},{"line_number":1447,"context_line":""},{"line_number":1448,"context_line":"    def _throw_snaplock_exception(self, share, key, value, extra_msg):"},{"line_number":1449,"context_line":"        args \u003d {\u0027value\u0027: value,"},{"line_number":1450,"context_line":"                \u0027extra_spec\u0027: key,"},{"line_number":1451,"context_line":"                \u0027type_id\u0027: share[\u0027share_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"d332279d_06915f77","line":1448,"range":{"start_line":1448,"start_character":9,"end_line":1448,"end_character":14},"updated":"2024-08-30 00:50:17.000000000","message":"s/throw/raise\n\npython !\u003d java :)","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"            if not is_matched:"},{"line_number":1446,"context_line":"                self._throw_snaplock_exception(share, key, value, extra_msg)"},{"line_number":1447,"context_line":""},{"line_number":1448,"context_line":"    def _throw_snaplock_exception(self, share, key, value, extra_msg):"},{"line_number":1449,"context_line":"        args \u003d {\u0027value\u0027: value,"},{"line_number":1450,"context_line":"                \u0027extra_spec\u0027: key,"},{"line_number":1451,"context_line":"                \u0027type_id\u0027: share[\u0027share_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"b3ac035d_14e17355","line":1448,"range":{"start_line":1448,"start_character":9,"end_line":1448,"end_character":14},"in_reply_to":"d332279d_06915f77","updated":"2024-09-03 09:35:24.000000000","message":"thanks, done.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4869252e11a209480d65aefe05e166445086f92","unresolved":true,"context_lines":[{"line_number":1460,"context_line":"    def _check_snaplock_compatibility(self):"},{"line_number":1461,"context_line":"        \"\"\"Check SnapLock license and compliance clock sync with the nodes\"\"\""},{"line_number":1462,"context_line":"        # Check SnapLock license is enabled on cluster"},{"line_number":1463,"context_line":"        if self._have_cluster_creds:"},{"line_number":1464,"context_line":"            if \u0027snaplock\u0027 not in self._licenses:"},{"line_number":1465,"context_line":"                exception.NetAppException(\"SnapLock License is not\""},{"line_number":1466,"context_line":"                                          \" available on ONTAP\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"020bcbf3_7194bf99","line":1463,"range":{"start_line":1463,"start_character":0,"end_line":1463,"end_character":36},"updated":"2024-08-30 00:50:17.000000000","message":"if not, would snaplock still be available?\n\nIf it is,maybe you need an else here, to log a warning that the driver is unable to verify if snaplock can be used","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":1460,"context_line":"    def _check_snaplock_compatibility(self):"},{"line_number":1461,"context_line":"        \"\"\"Check SnapLock license and compliance clock sync with the nodes\"\"\""},{"line_number":1462,"context_line":"        # Check SnapLock license is enabled on cluster"},{"line_number":1463,"context_line":"        if self._have_cluster_creds:"},{"line_number":1464,"context_line":"            if \u0027snaplock\u0027 not in self._licenses:"},{"line_number":1465,"context_line":"                exception.NetAppException(\"SnapLock License is not\""},{"line_number":1466,"context_line":"                                          \" available on ONTAP\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"8f77b469_60833173","line":1463,"range":{"start_line":1463,"start_character":0,"end_line":1463,"end_character":36},"in_reply_to":"020bcbf3_7194bf99","updated":"2024-09-03 09:35:24.000000000","message":"Done.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4869252e11a209480d65aefe05e166445086f92","unresolved":true,"context_lines":[{"line_number":1466,"context_line":"                                          \" available on ONTAP\")"},{"line_number":1467,"context_line":"            if not self._is_snaplock_compliance_configured:"},{"line_number":1468,"context_line":"                msg \u003d _(\u0027Compliance clock is not configured for one\u0027"},{"line_number":1469,"context_line":"                        \u0027 of the node.\u0027)"},{"line_number":1470,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1471,"context_line":""},{"line_number":1472,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":6,"id":"9d67dc98_a863dc39","line":1469,"range":{"start_line":1469,"start_character":33,"end_line":1469,"end_character":37},"updated":"2024-08-30 00:50:17.000000000","message":"nit: nodes","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"                                          \" available on ONTAP\")"},{"line_number":1467,"context_line":"            if not self._is_snaplock_compliance_configured:"},{"line_number":1468,"context_line":"                msg \u003d _(\u0027Compliance clock is not configured for one\u0027"},{"line_number":1469,"context_line":"                        \u0027 of the node.\u0027)"},{"line_number":1470,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":1471,"context_line":""},{"line_number":1472,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":6,"id":"f8e1e423_58fefc07","line":1469,"range":{"start_line":1469,"start_character":33,"end_line":1469,"end_character":37},"in_reply_to":"9d67dc98_a863dc39","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":5199,"context_line":"        return snaplock_type"},{"line_number":5200,"context_line":""},{"line_number":5201,"context_line":"    @na_utils.trace"},{"line_number":5202,"context_line":"    def _is_snaplock_compatible_for_migration(self, source_pool, des_pool):"},{"line_number":5203,"context_line":"        if self._client.features.UNIFIED_AGGR:"},{"line_number":5204,"context_line":"            return True"},{"line_number":5205,"context_line":"        if (self.configuration.netapp_use_legacy_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"c3555402_25d69b10","line":5202,"updated":"2024-08-29 21:53:36.000000000","message":"https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_48b/926049/6/check/openstack-tox-cover/48bf615/cover/z_a8cfac5052a75b06_lib_base_py.html#t5202 - not covered by unit tests. Could you please take a look?","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":5199,"context_line":"        return snaplock_type"},{"line_number":5200,"context_line":""},{"line_number":5201,"context_line":"    @na_utils.trace"},{"line_number":5202,"context_line":"    def _is_snaplock_compatible_for_migration(self, source_pool, des_pool):"},{"line_number":5203,"context_line":"        if self._client.features.UNIFIED_AGGR:"},{"line_number":5204,"context_line":"            return True"},{"line_number":5205,"context_line":"        if (self.configuration.netapp_use_legacy_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"88d329f1_9e428160","line":5202,"in_reply_to":"c3555402_25d69b10","updated":"2024-09-03 09:35:24.000000000","message":"Will add more unit test.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"462fec950fa107077b021b5614f3feaf625ce114","unresolved":false,"context_lines":[{"line_number":5203,"context_line":"        if self._client.features.UNIFIED_AGGR:"},{"line_number":5204,"context_line":"            return True"},{"line_number":5205,"context_line":"        if (self.configuration.netapp_use_legacy_client"},{"line_number":5206,"context_line":"                and self._client.features.SNAPLCOK):"},{"line_number":5207,"context_line":"            source_snaplock_type \u003d self._ssc_stats.get(source_pool, {}).get("},{"line_number":5208,"context_line":"                \u0027netapp_snaplock_type\u0027)"},{"line_number":5209,"context_line":"            des_snaplock_type \u003d self._ssc_stats.get(des_pool, {}).get("}],"source_content_type":"text/x-python","patch_set":6,"id":"8a68f14f_f4c78609","line":5206,"range":{"start_line":5206,"start_character":42,"end_line":5206,"end_character":50},"updated":"2024-09-03 13:17:31.000000000","message":"good catch :)","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"79e6fb41b24e456c12037b2c725a4890b5109d3d","unresolved":true,"context_lines":[{"line_number":1396,"context_line":"    @na_utils.trace"},{"line_number":1397,"context_line":"    def _check_snaplock_type(self, share, value):"},{"line_number":1398,"context_line":"        \"\"\"Check SnapLock type\"\"\""},{"line_number":1399,"context_line":"        if value not in self.SNAPLOCK_TYPE:"},{"line_number":1400,"context_line":"            args \u003d {\u0027snaplock_type\u0027: value,"},{"line_number":1401,"context_line":"                    \u0027extra_spec\u0027: \u0027netapp:snaplock_type\u0027,"},{"line_number":1402,"context_line":"                    \u0027type_id\u0027: share[\u0027share_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"e2621238_30b14282","line":1399,"range":{"start_line":1399,"start_character":24,"end_line":1399,"end_character":42},"updated":"2024-09-04 06:10:34.000000000","message":"You\u0027re introducing a capability called \"netapp_snaplock_type\".. \nyou don\u0027t need a scoped extra-spec called \"netapp:snaplock_type\".. \n\nthe share type extra specs will have: netapp_snaplock_type alongside \u0027netapp:snaplock_autocommit_period\u0027, \u0027netapp:snaplock_min_retention_period\u0027, \u0027netapp:snaplock_max_retention_period\u0027, \u0027netapp:snaplock_default_retention_period\u0027. \n\n\nThe benefit of using the capability is that you have a way to present this information through the scheduler, and administrators can \"discover\" the possible values. \n\nhttps://docs.openstack.org/manila/latest/admin/capabilities_and_extra_specs.html","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a2bb2b968c494ff7c3c35088713b9072b9296453","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"    @na_utils.trace"},{"line_number":1397,"context_line":"    def _check_snaplock_type(self, share, value):"},{"line_number":1398,"context_line":"        \"\"\"Check SnapLock type\"\"\""},{"line_number":1399,"context_line":"        if value not in self.SNAPLOCK_TYPE:"},{"line_number":1400,"context_line":"            args \u003d {\u0027snaplock_type\u0027: value,"},{"line_number":1401,"context_line":"                    \u0027extra_spec\u0027: \u0027netapp:snaplock_type\u0027,"},{"line_number":1402,"context_line":"                    \u0027type_id\u0027: share[\u0027share_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"55fefc48_1152427d","line":1399,"range":{"start_line":1399,"start_character":24,"end_line":1399,"end_character":42},"in_reply_to":"e2621238_30b14282","updated":"2024-09-05 14:59:54.000000000","message":"As discussed, removed the \"netapp:snaplock_type\" and \nif ONTAP support unified aggregate (ONTAP version \u003e\u003d9.10.1)\n   - add \"netapp_snaplock_type\": [\u0027compliance\u0027, \u0027enterprise\u0027] in capability in pool\nelse:\n- get the snaplock type from aggregate and update that in pool.","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"}],"manila/tests/share/drivers/netapp/dataontap/client/fakes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36485ae53dbdc0bd471edf1133528a5b6cd86bc7","unresolved":true,"context_lines":[{"line_number":3114,"context_line":"        \u003c/compliance-clock-info\u003e"},{"line_number":3115,"context_line":"    \u003c/snaplock-node-compliance-clock\u003e"},{"line_number":3116,"context_line":"  \u003c/results\u003e\"\"\" % {"},{"line_number":3117,"context_line":"    \u0027clock_info\u0027: \u0027not configured\u0027"},{"line_number":3118,"context_line":"})"},{"line_number":3119,"context_line":""},{"line_number":3120,"context_line":"FAKE_XML1 \u003d \"\"\"\u003coptions\u003e\\"}],"source_content_type":"text/x-python","patch_set":11,"id":"52ba6b56_a5d2ad47","line":3117,"range":{"start_line":3117,"start_character":18,"end_line":3117,"end_character":34},"updated":"2024-09-05 18:59:35.000000000","message":"i\u0027d retain this as \u0027ComplianceClock is not configured\u0027\n\nyour code is interested only in the \"not configured\" part.. The response from the server can be anything as long as it also contains \"not configured\" for this specific test case","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ab44a37d099995eb0caaeabc8d5333054b83f80f","unresolved":false,"context_lines":[{"line_number":3114,"context_line":"        \u003c/compliance-clock-info\u003e"},{"line_number":3115,"context_line":"    \u003c/snaplock-node-compliance-clock\u003e"},{"line_number":3116,"context_line":"  \u003c/results\u003e\"\"\" % {"},{"line_number":3117,"context_line":"    \u0027clock_info\u0027: \u0027not configured\u0027"},{"line_number":3118,"context_line":"})"},{"line_number":3119,"context_line":""},{"line_number":3120,"context_line":"FAKE_XML1 \u003d \"\"\"\u003coptions\u003e\\"}],"source_content_type":"text/x-python","patch_set":11,"id":"c7c71411_76d11a99","line":3117,"range":{"start_line":3117,"start_character":18,"end_line":3117,"end_character":34},"in_reply_to":"52ba6b56_a5d2ad47","updated":"2024-09-09 13:23:39.000000000","message":"Fixed as part of patch https://review.opendev.org/c/openstack/manila/+/928608","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":2100,"context_line":"                             netapp_api.EAPINOTFOUND)))"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        result \u003d self.client.get_node_for_aggregate(fake.SHARE_AGGREGATE_NAME)"},{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":"        self.assertIsNone(result)"},{"line_number":2105,"context_line":""},{"line_number":2106,"context_line":"    def test_get_node_for_aggregate_api_error(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"2986b27a_51b3388e","side":"PARENT","line":2103,"updated":"2024-08-29 21:53:36.000000000","message":"nit: could you please revert this? This can trick us if we need to look at the commit history in the future","commit_id":"2d987cf5859d9db72827b810c2fc3006743d9c1c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":2100,"context_line":"                             netapp_api.EAPINOTFOUND)))"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        result \u003d self.client.get_node_for_aggregate(fake.SHARE_AGGREGATE_NAME)"},{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":"        self.assertIsNone(result)"},{"line_number":2105,"context_line":""},{"line_number":2106,"context_line":"    def test_get_node_for_aggregate_api_error(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b3d945c7_7f197516","side":"PARENT","line":2103,"in_reply_to":"2986b27a_51b3388e","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"2d987cf5859d9db72827b810c2fc3006743d9c1c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":2121,"context_line":"                         mock.Mock(return_value\u003dapi_response))"},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"        result \u003d self.client.get_node_for_aggregate(fake.SHARE_AGGREGATE_NAME)"},{"line_number":2124,"context_line":""},{"line_number":2125,"context_line":"        self.assertIsNone(result)"},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"    def test_get_cluster_aggregate_capacities(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"97ef476b_dc68b7ae","side":"PARENT","line":2124,"updated":"2024-08-29 21:53:36.000000000","message":"same as above","commit_id":"2d987cf5859d9db72827b810c2fc3006743d9c1c"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"                         mock.Mock(return_value\u003dapi_response))"},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"        result \u003d self.client.get_node_for_aggregate(fake.SHARE_AGGREGATE_NAME)"},{"line_number":2124,"context_line":""},{"line_number":2125,"context_line":"        self.assertIsNone(result)"},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"    def test_get_cluster_aggregate_capacities(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e00e5c59_46d85ef5","side":"PARENT","line":2124,"in_reply_to":"97ef476b_dc68b7ae","updated":"2024-09-03 09:35:24.000000000","message":"Done","commit_id":"2d987cf5859d9db72827b810c2fc3006743d9c1c"}],"releasenotes/notes/snaplock-support-for-netapp-driver-9b639386c07c4990.yaml":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1e8c8a40b9f8e4f30fd117ae383b947082c0f286","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027worm_support_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required WORM-supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba9ef42e_e14bd257","line":12,"updated":"2024-08-13 13:32:03.000000000","message":"Do we need to mention worm_support type in this releasenotes ?","commit_id":"a934318aee3060983cf398ef38bc5adcb30d30cd"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027worm_support_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required WORM-supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"daa2e958_8c9c6243","line":12,"in_reply_to":"abc8f2c1_2e657a65","updated":"2024-09-03 09:35:24.000000000","message":"Carlos also suggested to remove this, removed this from release note.","commit_id":"a934318aee3060983cf398ef38bc5adcb30d30cd"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1f621fa7df50b1bf2df7c386d3e0b6ff294e7b13","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027worm_support_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required WORM-supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"abc8f2c1_2e657a65","line":12,"in_reply_to":"ba9ef42e_e14bd257","updated":"2024-08-29 11:37:02.000000000","message":"I change it to \"netapp_snaplock_type\". I hope this is fine to add this, let other comment on this.","commit_id":"a934318aee3060983cf398ef38bc5adcb30d30cd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver: This feature is already being used by customers, but it is"},{"line_number":5,"context_line":"    configured manually on the NetApp backends without Manila. Customers want"},{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"363e9dd3_a2bd6cc9","line":6,"range":{"start_line":4,"start_character":19,"end_line":6,"end_character":50},"updated":"2024-08-29 21:53:36.000000000","message":"I think we can remove this... yes, it is important to understand that it is already being used, but it feels more like a detail for the cycle highlights. In the release notes, we can be a bit brief and mention what does this change translate to the end user/admin, and we can have a couple of links if we would like to mention the reasons behind.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver: This feature is already being used by customers, but it is"},{"line_number":5,"context_line":"    configured manually on the NetApp backends without Manila. Customers want"},{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"30f5306b_61aaf40f","line":6,"range":{"start_line":4,"start_character":19,"end_line":6,"end_character":50},"in_reply_to":"363e9dd3_a2bd6cc9","updated":"2024-09-03 09:35:24.000000000","message":"I don\u0027t have any links, but as you suggested I removed this.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0759b7b7_999870bc","line":11,"range":{"start_line":9,"start_character":22,"end_line":11,"end_character":21},"updated":"2024-08-29 21:53:36.000000000","message":"reading this, would be nice to have some doc links to back us up and show how this should be done...","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"580d4691_0fe15d9b","line":11,"range":{"start_line":9,"start_character":22,"end_line":11,"end_character":21},"in_reply_to":"0759b7b7_999870bc","updated":"2024-09-03 09:35:24.000000000","message":"While creating the documentation for this feature will add the all the details.\nDo you want me to add the document here ..? if yes then it will take some time.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"462fec950fa107077b021b5614f3feaf625ce114","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fc497bc_f241ac42","line":11,"range":{"start_line":9,"start_character":22,"end_line":11,"end_character":21},"in_reply_to":"580d4691_0fe15d9b","updated":"2024-09-03 13:17:31.000000000","message":"No, I\u0027m good, I don\u0027t think we should hold this patch because of it. Maybe we can link the NetApp driver docs and then we try to make the docs land asap?","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"cfc8454c1f16dd28ddc8d81cd97c74ddb3947c39","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"13490eb5_251bcfcb","line":11,"range":{"start_line":9,"start_character":22,"end_line":11,"end_character":21},"in_reply_to":"9fc497bc_f241ac42","updated":"2024-09-03 15:31:16.000000000","message":"thanks","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver: This feature is already being used by customers, but it is"},{"line_number":5,"context_line":"    configured manually on the NetApp backends without Manila. Customers want"},{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e9479049_23cbbe9e","line":14,"range":{"start_line":4,"start_character":4,"end_line":14,"end_character":1},"updated":"2024-08-29 21:53:36.000000000","message":"Here is a brief suggestion for the release notes:\n\n```suggestion\n    NetApp Driver: It is now possible to create WORM shares using the\n    SnapLock feature. In order to create such shares, please set\n    \u0027netapp:snaplock_type\u0027 to the share type extra specs, alongside the\n    related retention period extra specs.\n\n```","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"318e08de3dada2c13ebd252cfca4ad819a8832de","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cfdff5d6_9bffa6de","line":14,"range":{"start_line":12,"start_character":3,"end_line":14,"end_character":1},"updated":"2024-08-29 21:53:36.000000000","message":"feels a bit more like an implementation detail, so I think we can drop it","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"462fec950fa107077b021b5614f3feaf625ce114","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver: This feature is already being used by customers, but it is"},{"line_number":5,"context_line":"    configured manually on the NetApp backends without Manila. Customers want"},{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cd111a43_9b2ff9bc","line":14,"range":{"start_line":4,"start_character":4,"end_line":14,"end_character":1},"in_reply_to":"62dd6a22_b030caa9","updated":"2024-09-03 13:17:31.000000000","message":"looks great Gireesh, thank you!","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"63c7517a_1c46828c","line":14,"range":{"start_line":12,"start_character":3,"end_line":14,"end_character":1},"in_reply_to":"cfdff5d6_9bffa6de","updated":"2024-09-03 09:35:24.000000000","message":"done.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"fac47addcdfee9df287778379cf230011aa8443f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver: This feature is already being used by customers, but it is"},{"line_number":5,"context_line":"    configured manually on the NetApp backends without Manila. Customers want"},{"line_number":6,"context_line":"    to achieve the same functionality using Manila."},{"line_number":7,"context_line":"    With this change NetApp ONTAP driver now supports the SnapLock feature."},{"line_number":8,"context_line":"    A new extra spec, \u0027netapp:snaplock_type\u0027, has been added to create"},{"line_number":9,"context_line":"    SnapLock volumes. Additionally, extra specs related to the SnapLock"},{"line_number":10,"context_line":"    retention period have been introduced to set the retention period on"},{"line_number":11,"context_line":"    SnapLock volumes."},{"line_number":12,"context_line":"    Along with this, the \u0027netapp_snaplock_type\u0027 capability has been added to the"},{"line_number":13,"context_line":"    backend pool to schedule the shares on the required supported pool."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"62dd6a22_b030caa9","line":14,"range":{"start_line":4,"start_character":4,"end_line":14,"end_character":1},"in_reply_to":"e9479049_23cbbe9e","updated":"2024-09-03 09:35:24.000000000","message":"Thanks for suggestion. I have changes it as below, let me me know if it fine.\n\nNetApp Driver: The NetApp Driver now supports the creation of WORM \nshares using the SnapLock feature. To create these shares, set the \n\u0027netapp:snaplock_type\u0027 in the share type extra specs, along with the\nSnapLock related retention period extra specs.","commit_id":"fa86d2267ec5d8603c43eacfdc96b01fe392ed6b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"99e7b32d9659c7a429d0899901cfa39543195136","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NetApp Driver: The NetApp Driver now supports the creation of WORM"},{"line_number":5,"context_line":"    shares using the SnapLock feature. To create these shares, set the"},{"line_number":6,"context_line":"    \u0027netapp:snaplock_type\u0027 in the share type extra specs, along with the"},{"line_number":7,"context_line":"    SnapLock related retention period extra specs."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"10d46cd9_20f84fc6","line":7,"updated":"2024-09-03 13:46:33.000000000","message":"change looks good. but we need to point either to bug or blueprint (which indirectly hold links to doc you are going to update in future)","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"e2ceb62bf7254150671e59f522dbab1b10a69667","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    NetApp Driver: The NetApp Driver now supports the creation of WORM"},{"line_number":5,"context_line":"    shares using the SnapLock feature. To create these shares, set the"},{"line_number":6,"context_line":"    \u0027netapp:snaplock_type\u0027 in the share type extra specs, along with the"},{"line_number":7,"context_line":"    SnapLock related retention period extra specs."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6fc069be_9d0ff87e","line":7,"in_reply_to":"10d46cd9_20f84fc6","updated":"2024-09-05 15:17:58.000000000","message":"Discuss with Kiran, will write the separate doc for this feature where I\u0027ll mention the list of extra specs.","commit_id":"2db360d39a14b6f56a3fcda824d0c0d6d4eb1b1a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36485ae53dbdc0bd471edf1133528a5b6cd86bc7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver: The NetApp Driver now supports the creation of WORM"},{"line_number":5,"context_line":"    shares using the SnapLock feature. To create these shares, set the"},{"line_number":6,"context_line":"    \u0027netapp:snaplock_type\u0027 in the share type extra specs, along with the"},{"line_number":7,"context_line":"    SnapLock related retention period extra specs."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"66f6938a_e3100e64","line":6,"range":{"start_line":6,"start_character":5,"end_line":6,"end_character":25},"updated":"2024-09-05 18:59:35.000000000","message":"netapp_snaplock_type","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ab44a37d099995eb0caaeabc8d5333054b83f80f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver: The NetApp Driver now supports the creation of WORM"},{"line_number":5,"context_line":"    shares using the SnapLock feature. To create these shares, set the"},{"line_number":6,"context_line":"    \u0027netapp:snaplock_type\u0027 in the share type extra specs, along with the"},{"line_number":7,"context_line":"    SnapLock related retention period extra specs."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"875c178e_126842f4","line":6,"range":{"start_line":6,"start_character":5,"end_line":6,"end_character":25},"in_reply_to":"66f6938a_e3100e64","updated":"2024-09-09 13:23:39.000000000","message":"Fixed as part of patch https://review.opendev.org/c/openstack/manila/+/928608","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36485ae53dbdc0bd471edf1133528a5b6cd86bc7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NetApp Driver: The NetApp Driver now supports the creation of WORM"},{"line_number":5,"context_line":"    shares using the SnapLock feature. To create these shares, set the"},{"line_number":6,"context_line":"    \u0027netapp:snaplock_type\u0027 in the share type extra specs, along with the"},{"line_number":7,"context_line":"    SnapLock related retention period extra specs."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fd961781_37c67074","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":50},"updated":"2024-09-05 18:59:35.000000000","message":"these ought to be documented somewhere..","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"ab44a37d099995eb0caaeabc8d5333054b83f80f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NetApp Driver: The NetApp Driver now supports the creation of WORM"},{"line_number":5,"context_line":"    shares using the SnapLock feature. To create these shares, set the"},{"line_number":6,"context_line":"    \u0027netapp:snaplock_type\u0027 in the share type extra specs, along with the"},{"line_number":7,"context_line":"    SnapLock related retention period extra specs."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"784a5ca5_78054d00","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":50},"in_reply_to":"fd961781_37c67074","updated":"2024-09-09 13:23:39.000000000","message":"Will create the doc for this","commit_id":"0892de04f67cc34bb205151238fedb0e3908b99a"}]}