)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"efd68a38a731537c8ef149ae9c9c5ce42e648688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61754782_974b5dce","updated":"2024-09-18 15:05:17.000000000","message":"@haix09@chinatelecom.cn: can you please see responses and help merge this :)","commit_id":"17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"030d53a8d39460503373b8253bc95e63c05312ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84574a7a_70178d6b","updated":"2024-09-23 00:59:04.000000000","message":"LGTM, sorry for late response.","commit_id":"17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4f81cedade0160cc75f18336a76699caad7eba7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74309b35_e1c36d20","updated":"2024-09-13 20:25:18.000000000","message":"Thank you for working on this fix, Goutham. LGTM","commit_id":"17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a3cd9e828b434f333714a2c0a3c65484084e8744","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b40e854b_09c39ac8","updated":"2024-09-13 02:16:56.000000000","message":"thanks for this change. i have a question in line.","commit_id":"17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a3cd9e828b434f333714a2c0a3c65484084e8744","unresolved":true,"context_lines":[{"line_number":1256,"context_line":"            export_location \u003d {"},{"line_number":1257,"context_line":"                \u0027path\u0027: export_path,"},{"line_number":1258,"context_line":"                \u0027is_admin_only\u0027: False,"},{"line_number":1259,"context_line":"                \u0027metadata\u0027: {"},{"line_number":1260,"context_line":"                    \u0027preferred\u0027: export_ip[\u0027preferred\u0027],"},{"line_number":1261,"context_line":"                },"},{"line_number":1262,"context_line":"            }"},{"line_number":1263,"context_line":"            export_locations.append(export_location)"},{"line_number":1264,"context_line":"        return export_locations"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf004715_c97e5175","line":1261,"range":{"start_line":1259,"start_character":17,"end_line":1261,"end_character":18},"updated":"2024-09-13 02:16:56.000000000","message":"+1. good catch.","commit_id":"17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a3cd9e828b434f333714a2c0a3c65484084e8744","unresolved":true,"context_lines":[{"line_number":1509,"context_line":"        # NFS interfaces directly via manila.conf. If they do,"},{"line_number":1510,"context_line":"        # these are represented as non-preferred export paths."},{"line_number":1511,"context_line":"        # This is mostly to allow NFS-Ganesha server migrations."},{"line_number":1512,"context_line":"        ganesha_export_ips \u003d (eip for eip in ganesha_export_ips"},{"line_number":1513,"context_line":"                              if eip not in ceph_nfs_export_ips)"},{"line_number":1514,"context_line":"        for ip in ganesha_export_ips:"},{"line_number":1515,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: False})"},{"line_number":1516,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6b749fc9_df690ef4","line":1513,"range":{"start_line":1512,"start_character":8,"end_line":1513,"end_character":64},"updated":"2024-09-13 02:16:56.000000000","message":"why need not in ceph_nfs_export_ips?\n\nif config cephfs_ganesha_server_ip ip_address_A.\nand we got ceph_nfs_export_ips also is ip_address_A(vip).\nthen ganesha_export_ips will be empty.","commit_id":"17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8dd7d430a3290f73b9fee839745b9cfe1927d6f6","unresolved":true,"context_lines":[{"line_number":1509,"context_line":"        # NFS interfaces directly via manila.conf. If they do,"},{"line_number":1510,"context_line":"        # these are represented as non-preferred export paths."},{"line_number":1511,"context_line":"        # This is mostly to allow NFS-Ganesha server migrations."},{"line_number":1512,"context_line":"        ganesha_export_ips \u003d (eip for eip in ganesha_export_ips"},{"line_number":1513,"context_line":"                              if eip not in ceph_nfs_export_ips)"},{"line_number":1514,"context_line":"        for ip in ganesha_export_ips:"},{"line_number":1515,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: False})"},{"line_number":1516,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f3640e1b_d191c6cc","line":1513,"range":{"start_line":1512,"start_character":8,"end_line":1513,"end_character":64},"in_reply_to":"6b749fc9_df690ef4","updated":"2024-09-13 20:14:23.000000000","message":"Yes; and that\u0027s the desired effect.. \n\nThis is the logic:\n\nThe list of export IPs needs to be a de-duplicated list of:\n1) Configured ones (`cephfs_ganesha_export_ips` or `cephfs_ganesha_server_ip`) \n2) NFS IPs we learn from the server (lines 1487-1495)\n\nThe code highlighted here is just making sure that even if the administrator unintentionally configures the same IPs in manila.conf, the list of IPs will be de-duplicated properly. \n\n\nFor example:\n\n ```\n # manila.conf\n cephfs_ganesha_export_ips \u003d 1.2.3.4,mynfsserver.com\n \n # nfs cluster info:\n ceph_nfs_export_ips \u003d 1.2.3.4\n \n # list of de-duplicated export_ips:\n export_ips \u003d [\u00271.2.3.4\u0027, \u0027mynfsserver.com\u0027]\n ```","commit_id":"17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"030d53a8d39460503373b8253bc95e63c05312ed","unresolved":false,"context_lines":[{"line_number":1509,"context_line":"        # NFS interfaces directly via manila.conf. If they do,"},{"line_number":1510,"context_line":"        # these are represented as non-preferred export paths."},{"line_number":1511,"context_line":"        # This is mostly to allow NFS-Ganesha server migrations."},{"line_number":1512,"context_line":"        ganesha_export_ips \u003d (eip for eip in ganesha_export_ips"},{"line_number":1513,"context_line":"                              if eip not in ceph_nfs_export_ips)"},{"line_number":1514,"context_line":"        for ip in ganesha_export_ips:"},{"line_number":1515,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: False})"},{"line_number":1516,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"48e3d8d4_30509969","line":1513,"range":{"start_line":1512,"start_character":8,"end_line":1513,"end_character":64},"in_reply_to":"f3640e1b_d191c6cc","updated":"2024-09-23 00:59:04.000000000","message":"thanks for your explanation.","commit_id":"17088aa57af3ae2dd5a16e2e8558ec471d2c1cc5"}]}