)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"01fa5dc1040e6f463f368129bb04d0241d77c1ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b9957e7a_bbe31134","updated":"2026-03-11 22:45:32.000000000","message":"Thank you for working on the this. good OOP design approach.\n\nFew inline comments please look into it. \n\nThe ``PowerFlex`` driver has missing instance level attributes to be remove.\n\nAlso we needs to run the CI for supported drivers.","commit_id":"923faed5f637a6a41d0f768c9e24cee89067d096"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a3a59669bf6f47d2b302beba5ac11ddf375b0cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"78e59211_efeed48f","updated":"2026-03-12 11:54:46.000000000","message":"Thanks for spotting these. I\u0027ve fixed the pointed problems.","commit_id":"923faed5f637a6a41d0f768c9e24cee89067d096"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8b8e2dc56a823a6b2e60dba54b9641386ea51906","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b556526f_bf3a3daf","updated":"2026-03-12 16:12:21.000000000","message":"@kajinamit@oss.nttdata.com, ``PowerFlex`` (https://opendev.org/openstack/manila/src/commit/2112b49f853f1b8414324632c6cf63053789c6f2/manila/share/drivers/dell_emc/plugins/powerflex/connection.py#L89) still have instance level attributes, please fix that as well.","commit_id":"5e2eee6089de61d28484cd087077bcb574d33ac8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"690aa970a1276e87767651c0c550c3bb624ecfec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"eef0d876_91c03b5a","in_reply_to":"b556526f_bf3a3daf","updated":"2026-03-12 16:14:09.000000000","message":"My bad. Fixed it.","commit_id":"5e2eee6089de61d28484cd087077bcb574d33ac8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"830284f510b2eac71d43b681d8ca8c05bb477bc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"43bc892f_dc9401b4","updated":"2026-03-12 16:16:14.000000000","message":"LGTM, but needs to test this with supported CI.","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"90ea2679c43023209f743508ae94c45edbb8aaa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1a2564a0_4c5f315d","updated":"2026-03-13 12:49:21.000000000","message":"LGTM. The CI jobs are passing.\n\nOne thing to address is the code coverage: the test coverage for driver.py has decreased from 92% to 64%, and for base.py from 86% to 74%.","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2650a4ebed906c18684a7e06ed9c257dc6fcb0a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"19adf2c4_b47474f7","updated":"2026-03-12 22:02:46.000000000","message":"run-DellEMC PowerScale CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"dd70db21c6a759704dad147ead404bed1f768d0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"548bd05c_5b462fd7","updated":"2026-03-12 16:16:27.000000000","message":"run-DellEMC PowerScale CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e916a7fbc279cffc068dfed8f2cca5a189131c8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7e7d19b4_f6500975","updated":"2026-03-12 17:12:18.000000000","message":"run-DellEMC PowerScale CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"36b1bd8719b57901cb370c61cc7cc096e3d3c33d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bcdea947_7ba9dc51","updated":"2026-03-12 18:58:51.000000000","message":"run-DellEMC PowerScale CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3bd96c9acbed9c739e21e9183b86f25d05dfa58e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2443abf5_af075d2f","updated":"2026-03-12 17:12:38.000000000","message":"run-DellEMC PowerStore CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5ac5a26b353db81e0bbca3e34eed0b79cfc8ef37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3ecae750_eaabc809","updated":"2026-03-12 16:18:02.000000000","message":"run-DellEMC PowerStore CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"bcd1b6e09157922044b9222256c55093c382935a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cbdd09dd_6308a172","updated":"2026-03-12 22:03:00.000000000","message":"run-DellEMC PowerStore CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"816849fd3b56eff90801659744376f27b993bfa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2907bcf6_010bbd28","updated":"2026-03-12 17:42:28.000000000","message":"run-DellEMC Unity CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8acc9ad402d4e7d39fd3e1a16b46417e68190783","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"46c597a1_4d44d6c0","updated":"2026-03-12 22:04:52.000000000","message":"run-DellEMC Unity CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"441497d7d660bd11a7a8b9169c6afe6250dc69cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4756d982_05fd8888","updated":"2026-03-13 11:21:51.000000000","message":"run-DellEMC Unity CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5a3ae647029b9a885a5e08224004e4569b896d64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4eed69b6_55175b7c","updated":"2026-03-13 05:47:20.000000000","message":"run-DellEMC Unity CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0e75847a41bc0d70cd24948872b3395c3d133c35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"89cb5c68_d913fb9b","updated":"2026-03-13 06:20:03.000000000","message":"run-DellEMC Unity CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4ef746072914236ca6ce6233561336645b93653f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"acd16e15_e33af6a8","updated":"2026-03-12 22:03:12.000000000","message":"run-DellEMC Unity CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a5b32139cdeccd1b7747566b90113bd88a93c3d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c03ea427_e152ebe4","updated":"2026-03-13 10:24:59.000000000","message":"run-DellEMC Unity CI","commit_id":"c04656dbd5385df6342d605be84a78339f9ce9c2"}],"manila/share/drivers/dell_emc/driver.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"01fa5dc1040e6f463f368129bb04d0241d77c1ab","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                                             share_server\u003dNone):"},{"line_number":120,"context_line":"        \"\"\"manage an existing share snapshot\"\"\""},{"line_number":121,"context_line":"        return self.plugin.manage_existing_snapshot_with_server("},{"line_number":122,"context_line":"            snapshot, driver_options, share_server\u003dNone)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def manage_server(self, context, share_server, identifier,"},{"line_number":125,"context_line":"                      driver_options):"}],"source_content_type":"text/x-python","patch_set":9,"id":"c0a8c758_3b96d92e","line":122,"updated":"2026-03-11 22:45:32.000000000","message":"passing share_server\u003dNone as a literal instead of forwarding the actual share_server parameter. This means the share server context is always lost, regardless of what the caller passes. In DHSS\u003dTrue mode, manage-snapshot-with-server will silently behave as if no share server was provided.\n\nFix: Change share_server\u003dNone → share_server\u003dshare_server.","commit_id":"923faed5f637a6a41d0f768c9e24cee89067d096"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a3a59669bf6f47d2b302beba5ac11ddf375b0cf","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                                             share_server\u003dNone):"},{"line_number":120,"context_line":"        \"\"\"manage an existing share snapshot\"\"\""},{"line_number":121,"context_line":"        return self.plugin.manage_existing_snapshot_with_server("},{"line_number":122,"context_line":"            snapshot, driver_options, share_server\u003dNone)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def manage_server(self, context, share_server, identifier,"},{"line_number":125,"context_line":"                      driver_options):"}],"source_content_type":"text/x-python","patch_set":9,"id":"67f30a88_81eca880","line":122,"in_reply_to":"c0a8c758_3b96d92e","updated":"2026-03-12 11:54:46.000000000","message":"Oh, yes. That\u0027s unintentional override. Fixed it.","commit_id":"923faed5f637a6a41d0f768c9e24cee89067d096"}],"manila/share/drivers/dell_emc/plugins/base.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"01fa5dc1040e6f463f368129bb04d0241d77c1ab","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def revert_to_snapshot(self, context, snapshot, share_access_rules,"},{"line_number":48,"context_line":"                           snapshot_access_rules, share_server):"},{"line_number":49,"context_line":"        \"\"\"Revert share to a napshot\"\"\""},{"line_number":50,"context_line":"        raise NotImplementedError()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"0981009c_cb3cde19","line":49,"updated":"2026-03-11 22:45:32.000000000","message":"typo it should be ``snapshot``","commit_id":"923faed5f637a6a41d0f768c9e24cee89067d096"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a3a59669bf6f47d2b302beba5ac11ddf375b0cf","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def revert_to_snapshot(self, context, snapshot, share_access_rules,"},{"line_number":48,"context_line":"                           snapshot_access_rules, share_server):"},{"line_number":49,"context_line":"        \"\"\"Revert share to a napshot\"\"\""},{"line_number":50,"context_line":"        raise NotImplementedError()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"8d14b1e4_296d4518","line":49,"in_reply_to":"0981009c_cb3cde19","updated":"2026-03-12 11:54:46.000000000","message":"Done","commit_id":"923faed5f637a6a41d0f768c9e24cee89067d096"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale.py":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"01fa5dc1040e6f463f368129bb04d0241d77c1ab","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self._powerscale_api \u003d None"},{"line_number":90,"context_line":"        self.driver_handles_share_servers \u003d False"},{"line_number":91,"context_line":"        self.ipv6_implemented \u003d True"},{"line_number":92,"context_line":"        self.manage_existing_snapshot_support \u003d True"},{"line_number":93,"context_line":"        # props for share status update"},{"line_number":94,"context_line":"        self.reserved_percentage \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"d7851b6f_7179ef50","side":"PARENT","line":91,"updated":"2026-03-11 22:45:32.000000000","message":"driver_handles_share_servers and ipv6_implemented, this should be remove and ipv6_implemented moved to class level.","commit_id":"773dc6c428854dc4d3ae27b986f9f404cef01eb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a3a59669bf6f47d2b302beba5ac11ddf375b0cf","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self._powerscale_api \u003d None"},{"line_number":90,"context_line":"        self.driver_handles_share_servers \u003d False"},{"line_number":91,"context_line":"        self.ipv6_implemented \u003d True"},{"line_number":92,"context_line":"        self.manage_existing_snapshot_support \u003d True"},{"line_number":93,"context_line":"        # props for share status update"},{"line_number":94,"context_line":"        self.reserved_percentage \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"65bed67f_d9d08889","side":"PARENT","line":91,"in_reply_to":"d7851b6f_7179ef50","updated":"2026-03-12 11:54:46.000000000","message":"Done","commit_id":"773dc6c428854dc4d3ae27b986f9f404cef01eb1"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"01fa5dc1040e6f463f368129bb04d0241d77c1ab","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        self._powerscale_api \u003d None"},{"line_number":90,"context_line":"        self.driver_handles_share_servers \u003d False"},{"line_number":91,"context_line":"        self.ipv6_implemented \u003d True"},{"line_number":92,"context_line":"        self.manage_existing_snapshot_support \u003d True"},{"line_number":93,"context_line":"        # props for share status update"},{"line_number":94,"context_line":"        self.reserved_percentage \u003d None"},{"line_number":95,"context_line":"        self.reserved_snapshot_percentage \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"e959c5d6_245456de","side":"PARENT","line":92,"updated":"2026-03-11 22:45:32.000000000","message":"This is no longer required.","commit_id":"773dc6c428854dc4d3ae27b986f9f404cef01eb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a3a59669bf6f47d2b302beba5ac11ddf375b0cf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self._powerscale_api \u003d None"},{"line_number":90,"context_line":"        self.driver_handles_share_servers \u003d False"},{"line_number":91,"context_line":"        self.ipv6_implemented \u003d True"},{"line_number":92,"context_line":"        self.manage_existing_snapshot_support \u003d True"},{"line_number":93,"context_line":"        # props for share status update"},{"line_number":94,"context_line":"        self.reserved_percentage \u003d None"},{"line_number":95,"context_line":"        self.reserved_snapshot_percentage \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"214c693e_5ec25b55","side":"PARENT","line":92,"in_reply_to":"e959c5d6_245456de","updated":"2026-03-12 11:54:46.000000000","message":"Done","commit_id":"773dc6c428854dc4d3ae27b986f9f404cef01eb1"}]}