)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f96bdb133a4115fba05563b0fafb891ad8d4a423","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"118c368b_b7686e1b","updated":"2024-10-02 08:22:14.000000000","message":"recheck","commit_id":"360ea9ac37bd42594cf035dc0fb45e957f2920e2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f4bea230124321f91e9285fda4b84787a6fd8ec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"96a46c69_447e9d5c","updated":"2024-10-10 07:50:26.000000000","message":"thanks for review, fixed the suggestions. \n\nFYI, In future, one can extend to allow update of access_key if supported. But currently we have requirement of only access_level.","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b1ab3e14f2a64549f9f6a7e828ef83983ab11e14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53ab230d_8d92af73","updated":"2024-10-10 02:30:48.000000000","message":"thanks for your change, Kiran Pawar.\ncode looks good. some comments inlines.\n\nand we need add api doc for this feature.\nadd doc in manila/api-ref/soruce/share-access-rules.inc\n\nPUT /v2/share-access-rules/{access_id}  (since API v2.88)\nrequest body:\n{\n    \"update_access\": {\n        \"access_level\": \"rw\"\n     }\n}","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0b25a8f67cffeda3a01fbe700bf5a833c6a3cd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ddd40140_477c0d11","updated":"2024-10-11 03:36:40.000000000","message":"some comments inline 😊","commit_id":"9cad83e46ebaab3f6fc20dece3ca676b01e69468"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"87c2c9a9e69aae9fdf733cb14151bd941eabd4f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"21b6f846_5aeed8b5","updated":"2024-10-11 09:51:37.000000000","message":"LGTM now. thanks.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1aa0e3f7_696e7daf","updated":"2024-10-15 15:49:14.000000000","message":"LGTM, I provided few minor comments, please fix those also.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f19d12e3c4782d160f4a68a41073fd52206e0a98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e411f504_b2d63e46","updated":"2024-12-06 13:56:52.000000000","message":"Added tempest tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/937243 as asked in manila weekly meeting.","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"980657ebdd710cd1500273def5da65f3b9353338","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"12aafb2f_0cde55a2","updated":"2024-10-18 03:52:07.000000000","message":"LGTM, thanks.","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"35ecae95aa64888b87f42457bd68c3bb8cc63e6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2da38109_54f576c7","updated":"2024-11-14 04:20:50.000000000","message":"LGTM..!","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"768e03a37bc864b0bfcadf0a7bd4837d7be3c614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"87ee760d_a2058c6e","updated":"2024-12-18 10:40:51.000000000","message":"Thanks for working on this change! Please take a look at the comments inline","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"025472ea55415b8719ea4175644fa125163e9990","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2f02c22e_0a4ee951","updated":"2024-12-19 00:48:45.000000000","message":"LGTM,thanks","commit_id":"d891d116d67ddf8012975fb19a16222752d9e7e8"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"70ab505b0627fc1f3a55b1e6bc42b3be8eb22dd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"27048a72_331e3e05","updated":"2024-12-18 20:50:30.000000000","message":"Looks goood","commit_id":"d891d116d67ddf8012975fb19a16222752d9e7e8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8baea2d39ced7f92fe0ce4970384c227fba2aa9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"37a8e0fa_0863bf0f","updated":"2025-01-02 14:35:31.000000000","message":"The change/PR is updated to add policy for update API.","commit_id":"d891d116d67ddf8012975fb19a16222752d9e7e8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0674c7a2278eed331f37a3acd4e0a45a3992284b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"eefdad7f_fed8e466","updated":"2025-01-16 13:48:42.000000000","message":"LGTM,Thank you! Tests were proposed. Please keep an eye out on CI. If there is need for a follow-up change, let\u0027s address possible comments there.","commit_id":"65d48c0589379642c9219eac7709199420fb7aac"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"efc2558c7e12219ed7958c7310fd890c1dae3f04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0cf46806_0eab13b3","updated":"2025-01-03 02:45:54.000000000","message":"add new policy for update. good catch. LGTM.","commit_id":"65d48c0589379642c9219eac7709199420fb7aac"}],"api-ref/source/samples/share-access-rules-update-response.json":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0b25a8f67cffeda3a01fbe700bf5a833c6a3cd7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"        \"state\": \"error\","},{"line_number":5,"context_line":"        \"id\": \"507bf114-36f2-4f56-8cf4-857985ca87c1\","},{"line_number":6,"context_line":"        \"share_id\": \"fb213952-2352-41b4-ad7b-2c4c69d13eef\","},{"line_number":7,"context_line":"        \"access_type\": \"cert\","},{"line_number":8,"context_line":"        \"access_to\": \"example.com\","},{"line_number":9,"context_line":"        \"access_key\": null,"},{"line_number":10,"context_line":"        \"created_at\": \"2018-07-17T02:01:04.000000\","}],"source_content_type":"application/json","patch_set":6,"id":"ff02e45d_dfdc8747","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":28},"updated":"2024-10-11 03:36:40.000000000","message":"now we only support ip.","commit_id":"9cad83e46ebaab3f6fc20dece3ca676b01e69468"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"272b9b5612bb0d79ca930933c95b0b7ff7604b73","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"state\": \"error\","},{"line_number":5,"context_line":"        \"id\": \"507bf114-36f2-4f56-8cf4-857985ca87c1\","},{"line_number":6,"context_line":"        \"share_id\": \"fb213952-2352-41b4-ad7b-2c4c69d13eef\","},{"line_number":7,"context_line":"        \"access_type\": \"cert\","},{"line_number":8,"context_line":"        \"access_to\": \"example.com\","},{"line_number":9,"context_line":"        \"access_key\": null,"},{"line_number":10,"context_line":"        \"created_at\": \"2018-07-17T02:01:04.000000\","}],"source_content_type":"application/json","patch_set":6,"id":"eb9001bb_ce740577","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":28},"in_reply_to":"ff02e45d_dfdc8747","updated":"2024-10-11 07:58:40.000000000","message":"Done","commit_id":"9cad83e46ebaab3f6fc20dece3ca676b01e69468"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0b25a8f67cffeda3a01fbe700bf5a833c6a3cd7","unresolved":true,"context_lines":[{"line_number":5,"context_line":"        \"id\": \"507bf114-36f2-4f56-8cf4-857985ca87c1\","},{"line_number":6,"context_line":"        \"share_id\": \"fb213952-2352-41b4-ad7b-2c4c69d13eef\","},{"line_number":7,"context_line":"        \"access_type\": \"cert\","},{"line_number":8,"context_line":"        \"access_to\": \"example.com\","},{"line_number":9,"context_line":"        \"access_key\": null,"},{"line_number":10,"context_line":"        \"created_at\": \"2018-07-17T02:01:04.000000\","},{"line_number":11,"context_line":"        \"updated_at\": \"2018-07-17T02:01:04.000000\","}],"source_content_type":"application/json","patch_set":6,"id":"8f5cdcf9_59db8d51","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":33},"updated":"2024-10-11 03:36:40.000000000","message":"a ip","commit_id":"9cad83e46ebaab3f6fc20dece3ca676b01e69468"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"272b9b5612bb0d79ca930933c95b0b7ff7604b73","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        \"id\": \"507bf114-36f2-4f56-8cf4-857985ca87c1\","},{"line_number":6,"context_line":"        \"share_id\": \"fb213952-2352-41b4-ad7b-2c4c69d13eef\","},{"line_number":7,"context_line":"        \"access_type\": \"cert\","},{"line_number":8,"context_line":"        \"access_to\": \"example.com\","},{"line_number":9,"context_line":"        \"access_key\": null,"},{"line_number":10,"context_line":"        \"created_at\": \"2018-07-17T02:01:04.000000\","},{"line_number":11,"context_line":"        \"updated_at\": \"2018-07-17T02:01:04.000000\","}],"source_content_type":"application/json","patch_set":6,"id":"5631e0e6_16d3b8bc","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":33},"in_reply_to":"8f5cdcf9_59db8d51","updated":"2024-10-11 07:58:40.000000000","message":"Done","commit_id":"9cad83e46ebaab3f6fc20dece3ca676b01e69468"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"768e03a37bc864b0bfcadf0a7bd4837d7be3c614","unresolved":true,"context_lines":[{"line_number":7,"context_line":"        \"access_type\": \"ip\","},{"line_number":8,"context_line":"        \"access_to\": \"0.0.0.0/0\","},{"line_number":9,"context_line":"        \"access_key\": null,"},{"line_number":10,"context_line":"        \"created_at\": \"2018-07-17T02:01:04.000000\","},{"line_number":11,"context_line":"        \"updated_at\": \"2018-07-17T02:01:04.000000\","},{"line_number":12,"context_line":"        \"metadata\": {"},{"line_number":13,"context_line":"            \"key1\": \"value1\","},{"line_number":14,"context_line":"            \"key2\": \"value2\""}],"source_content_type":"application/json","patch_set":8,"id":"86daecee_b66515a2","line":11,"range":{"start_line":10,"start_character":6,"end_line":11,"end_character":51},"updated":"2024-12-18 10:40:51.000000000","message":"nit: we could use more recent dates to be more realistic","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4015311dfa0a2ca4747002ee1b8abc868edb91a7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        \"access_type\": \"ip\","},{"line_number":8,"context_line":"        \"access_to\": \"0.0.0.0/0\","},{"line_number":9,"context_line":"        \"access_key\": null,"},{"line_number":10,"context_line":"        \"created_at\": \"2018-07-17T02:01:04.000000\","},{"line_number":11,"context_line":"        \"updated_at\": \"2018-07-17T02:01:04.000000\","},{"line_number":12,"context_line":"        \"metadata\": {"},{"line_number":13,"context_line":"            \"key1\": \"value1\","},{"line_number":14,"context_line":"            \"key2\": \"value2\""}],"source_content_type":"application/json","patch_set":8,"id":"fca4439c_e7fc769e","line":11,"range":{"start_line":10,"start_character":6,"end_line":11,"end_character":51},"in_reply_to":"86daecee_b66515a2","updated":"2024-12-18 13:42:15.000000000","message":"Done","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"}],"api-ref/source/share-access-rules.inc":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a0b25a8f67cffeda3a01fbe700bf5a833c6a3cd7","unresolved":true,"context_lines":[{"line_number":165,"context_line":"   - access_id: access_id_path"},{"line_number":166,"context_line":"   - access_level: access_level"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Response parameters"},{"line_number":169,"context_line":"-------------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"35148341_3bf96440","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":19},"updated":"2024-10-11 03:36:40.000000000","message":"we also need Request example","commit_id":"9cad83e46ebaab3f6fc20dece3ca676b01e69468"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"272b9b5612bb0d79ca930933c95b0b7ff7604b73","unresolved":false,"context_lines":[{"line_number":165,"context_line":"   - access_id: access_id_path"},{"line_number":166,"context_line":"   - access_level: access_level"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Response parameters"},{"line_number":169,"context_line":"-------------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"efe7e120_dec208a4","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":19},"in_reply_to":"35148341_3bf96440","updated":"2024-10-11 07:58:40.000000000","message":"Done","commit_id":"9cad83e46ebaab3f6fc20dece3ca676b01e69468"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"768e03a37bc864b0bfcadf0a7bd4837d7be3c614","unresolved":true,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. versionadded:: 2.88"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update access_level of a specified access rule."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Response codes"},{"line_number":146,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"e88f6c4d_173dda32","line":143,"range":{"start_line":143,"start_character":7,"end_line":143,"end_character":19},"updated":"2024-12-18 10:40:51.000000000","message":"``access_level``","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4015311dfa0a2ca4747002ee1b8abc868edb91a7","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. versionadded:: 2.88"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Update access_level of a specified access rule."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Response codes"},{"line_number":146,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"82a71048_a656dfe8","line":143,"range":{"start_line":143,"start_character":7,"end_line":143,"end_character":19},"in_reply_to":"e88f6c4d_173dda32","updated":"2024-12-18 13:42:15.000000000","message":"Done","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":205,"context_line":"    * 2.85 - Added backup_type field to share backups."},{"line_number":206,"context_line":"    * 2.86 - Add ensure share API."},{"line_number":207,"context_line":"    * 2.87 - Added Share export location metadata API"},{"line_number":208,"context_line":"    * 2.88 - Added update Share access rule."},{"line_number":209,"context_line":"\"\"\""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":7,"id":"e14c16c9_c100ca9f","line":208,"range":{"start_line":208,"start_character":13,"end_line":208,"end_character":43},"updated":"2024-10-15 15:49:14.000000000","message":"This need to change with new meaningful sentence, few suggestions from my side, other can also suggest \n- Update Share access rule.\n- Added functionality to update the share access rule.\n- Implemented the PUT method to modify the share access rule.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    * 2.85 - Added backup_type field to share backups."},{"line_number":206,"context_line":"    * 2.86 - Add ensure share API."},{"line_number":207,"context_line":"    * 2.87 - Added Share export location metadata API"},{"line_number":208,"context_line":"    * 2.88 - Added update Share access rule."},{"line_number":209,"context_line":"\"\"\""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":7,"id":"dc3a390d_b59cd9fb","line":208,"range":{"start_line":208,"start_character":13,"end_line":208,"end_character":43},"in_reply_to":"e14c16c9_c100ca9f","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/api/v2/share_accesses.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b1ab3e14f2a64549f9f6a7e828ef83983ab11e14","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        return self._index(req, support_for_access_filters\u003dTrue)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @wsgi.Controller.api_version(\u00272.88\u0027)"},{"line_number":147,"context_line":"    def update(self, req, id, body\u003dNone):"},{"line_number":148,"context_line":"        \"\"\"Update data about the given share access rule.\"\"\""},{"line_number":149,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":150,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"45eb7022_928c1961","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":41},"updated":"2024-10-10 02:30:48.000000000","message":"def update(self, req, id, body):\n\nwe always need body","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f4bea230124321f91e9285fda4b84787a6fd8ec7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return self._index(req, support_for_access_filters\u003dTrue)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @wsgi.Controller.api_version(\u00272.88\u0027)"},{"line_number":147,"context_line":"    def update(self, req, id, body\u003dNone):"},{"line_number":148,"context_line":"        \"\"\"Update data about the given share access rule.\"\"\""},{"line_number":149,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":150,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"541671d8_5082c55b","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":41},"in_reply_to":"45eb7022_928c1961","updated":"2024-10-10 07:50:26.000000000","message":"Done","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b1ab3e14f2a64549f9f6a7e828ef83983ab11e14","unresolved":true,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @wsgi.Controller.api_version(\u00272.88\u0027)"},{"line_number":147,"context_line":"    def update(self, req, id, body\u003dNone):"},{"line_number":148,"context_line":"        \"\"\"Update data about the given share access rule.\"\"\""},{"line_number":149,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":150,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"},{"line_number":151,"context_line":"            raise webob.exc.HTTPBadRequest()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1bfd6bc3_1b94f94d","line":148,"range":{"start_line":148,"start_character":18,"end_line":148,"end_character":22},"updated":"2024-10-10 02:30:48.000000000","message":"access level","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f4bea230124321f91e9285fda4b84787a6fd8ec7","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @wsgi.Controller.api_version(\u00272.88\u0027)"},{"line_number":147,"context_line":"    def update(self, req, id, body\u003dNone):"},{"line_number":148,"context_line":"        \"\"\"Update data about the given share access rule.\"\"\""},{"line_number":149,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":150,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"},{"line_number":151,"context_line":"            raise webob.exc.HTTPBadRequest()"}],"source_content_type":"text/x-python","patch_set":3,"id":"d6fba307_7f62e0dd","line":148,"range":{"start_line":148,"start_character":18,"end_line":148,"end_character":22},"in_reply_to":"1bfd6bc3_1b94f94d","updated":"2024-10-10 07:50:26.000000000","message":"Done","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b1ab3e14f2a64549f9f6a7e828ef83983ab11e14","unresolved":true,"context_lines":[{"line_number":147,"context_line":"    def update(self, req, id, body\u003dNone):"},{"line_number":148,"context_line":"        \"\"\"Update data about the given share access rule.\"\"\""},{"line_number":149,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":150,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"},{"line_number":151,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        access_data \u003d body[\u0027access\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"b4eca76b_135999d7","line":150,"range":{"start_line":150,"start_character":41,"end_line":150,"end_character":47},"updated":"2024-10-10 02:30:48.000000000","message":"grant access need \"allow_access\" in request body.\nrevoke access need \"deny_access\" in request body.\nso here would be better \"update_access\".","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f4bea230124321f91e9285fda4b84787a6fd8ec7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def update(self, req, id, body\u003dNone):"},{"line_number":148,"context_line":"        \"\"\"Update data about the given share access rule.\"\"\""},{"line_number":149,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":150,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"},{"line_number":151,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        access_data \u003d body[\u0027access\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"f6ebc4b3_bb48ccff","line":150,"range":{"start_line":150,"start_character":41,"end_line":150,"end_character":47},"in_reply_to":"b4eca76b_135999d7","updated":"2024-10-10 07:50:26.000000000","message":"Done","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b1ab3e14f2a64549f9f6a7e828ef83983ab11e14","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"},{"line_number":151,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":154,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":155,"context_line":"        if share_access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":156,"context_line":"            msg \u003d _(\"Invalid access_type. Only allowed to \""}],"source_content_type":"text/x-python","patch_set":3,"id":"654c0072_f6f1e00e","line":153,"range":{"start_line":153,"start_character":28,"end_line":153,"end_character":34},"updated":"2024-10-10 02:30:48.000000000","message":"update_access","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f4bea230124321f91e9285fda4b84787a6fd8ec7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"},{"line_number":151,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":154,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":155,"context_line":"        if share_access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":156,"context_line":"            msg \u003d _(\"Invalid access_type. Only allowed to \""}],"source_content_type":"text/x-python","patch_set":3,"id":"6ec91ae7_b7194a8d","line":153,"range":{"start_line":153,"start_character":28,"end_line":153,"end_character":34},"in_reply_to":"654c0072_f6f1e00e","updated":"2024-10-10 07:50:26.000000000","message":"Done","commit_id":"4d95d16bc9934f9458d38f903f0ee309461209c5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"56229d45ecaeb81e97245e9f822249b8c2849573","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        access_data \u003d body[\u0027update_access\u0027]"},{"line_number":154,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":155,"context_line":"        if share_access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":156,"context_line":"            msg \u003d _(\"Invalid access_type. Only allowed to \""},{"line_number":157,"context_line":"                    \"update \u0027ip\u0027 access_type.\")"},{"line_number":158,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        access_level \u003d access_data.get(\u0027access_level\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"38c11fba_a2478586","line":157,"range":{"start_line":156,"start_character":20,"end_line":157,"end_character":46},"updated":"2024-12-17 15:19:32.000000000","message":"This is not something constrained to IP access rules. Other access rules can also have their access level updated.","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"768e03a37bc864b0bfcadf0a7bd4837d7be3c614","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        access_data \u003d body[\u0027update_access\u0027]"},{"line_number":154,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":155,"context_line":"        if share_access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":156,"context_line":"            msg \u003d _(\"Invalid access_type. Only allowed to \""},{"line_number":157,"context_line":"                    \"update \u0027ip\u0027 access_type.\")"},{"line_number":158,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        access_level \u003d access_data.get(\u0027access_level\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dcd8f2ac_36228f91","line":157,"range":{"start_line":156,"start_character":20,"end_line":157,"end_character":46},"in_reply_to":"38c11fba_a2478586","updated":"2024-12-18 10:40:51.000000000","message":"I believe we should look into enabling that and let drivers decide","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4015311dfa0a2ca4747002ee1b8abc868edb91a7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        access_data \u003d body[\u0027update_access\u0027]"},{"line_number":154,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":155,"context_line":"        if share_access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":156,"context_line":"            msg \u003d _(\"Invalid access_type. Only allowed to \""},{"line_number":157,"context_line":"                    \"update \u0027ip\u0027 access_type.\")"},{"line_number":158,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        access_level \u003d access_data.get(\u0027access_level\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7117a113_c322d04f","line":157,"range":{"start_line":156,"start_character":20,"end_line":157,"end_character":46},"in_reply_to":"dcd8f2ac_36228f91","updated":"2024-12-18 13:42:15.000000000","message":"Done","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"56229d45ecaeb81e97245e9f822249b8c2849573","unresolved":true,"context_lines":[{"line_number":168,"context_line":"                    \"level: %s.\") % access_level"},{"line_number":169,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if access_level \u003d\u003d share_access.access_level:"},{"line_number":172,"context_line":"            return self._view_builder.view(req, share_access)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        share \u003d self.share_api.get(context, share_access.share_id)"},{"line_number":175,"context_line":"        values \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3136a569_ca0f1fc1","line":172,"range":{"start_line":171,"start_character":8,"end_line":172,"end_character":61},"updated":"2024-12-17 15:19:32.000000000","message":"the view would likely give a false idea that this was updated, when it wasn\u0027t. Maybe we don\u0027t return anything and log it?","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4015311dfa0a2ca4747002ee1b8abc868edb91a7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    \"level: %s.\") % access_level"},{"line_number":169,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if access_level \u003d\u003d share_access.access_level:"},{"line_number":172,"context_line":"            return self._view_builder.view(req, share_access)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        share \u003d self.share_api.get(context, share_access.share_id)"},{"line_number":175,"context_line":"        values \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"fcf75aa0_d7eea9b9","line":172,"range":{"start_line":171,"start_character":8,"end_line":172,"end_character":61},"in_reply_to":"3136a569_ca0f1fc1","updated":"2024-12-18 13:42:15.000000000","message":"Considering implementation of update API for other resources e.g. access metadata, even if you input existing metadata, manila will update in db and process the view. So we should simply return view such that user get to know access_level is updated (though its already exist in db).","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"56229d45ecaeb81e97245e9f822249b8c2849573","unresolved":true,"context_lines":[{"line_number":2962,"context_line":""},{"line_number":2963,"context_line":"@require_context"},{"line_number":2964,"context_line":"@context_manager.writer"},{"line_number":2965,"context_line":"def share_access_update(context, access_id, values):"},{"line_number":2966,"context_line":"    access_ref \u003d _share_access_get(context, access_id)"},{"line_number":2967,"context_line":"    access_ref.update(values)"},{"line_number":2968,"context_line":"    access_ref.save(session\u003dcontext.session)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5e219d86_e9e34934","line":2965,"range":{"start_line":2965,"start_character":4,"end_line":2965,"end_character":23},"updated":"2024-12-17 15:19:32.000000000","message":"is there a chance that share_instance_access_update can be at least partly reused?","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4015311dfa0a2ca4747002ee1b8abc868edb91a7","unresolved":false,"context_lines":[{"line_number":2962,"context_line":""},{"line_number":2963,"context_line":"@require_context"},{"line_number":2964,"context_line":"@context_manager.writer"},{"line_number":2965,"context_line":"def share_access_update(context, access_id, values):"},{"line_number":2966,"context_line":"    access_ref \u003d _share_access_get(context, access_id)"},{"line_number":2967,"context_line":"    access_ref.update(values)"},{"line_number":2968,"context_line":"    access_ref.save(session\u003dcontext.session)"}],"source_content_type":"text/x-python","patch_set":8,"id":"c6e7381d_c90f9b11","line":2965,"range":{"start_line":2965,"start_character":4,"end_line":2965,"end_character":23},"in_reply_to":"5e219d86_e9e34934","updated":"2024-12-18 13:42:15.000000000","message":"I am not in favour to update access rule with Null/None instance_id and modify existing function.","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"}],"manila/share/access.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"768e03a37bc864b0bfcadf0a7bd4837d7be3c614","unresolved":true,"context_lines":[{"line_number":417,"context_line":"        except NotImplementedError:"},{"line_number":418,"context_line":"            # NOTE(u_glide): Fallback to legacy allow_access/deny_access"},{"line_number":419,"context_line":"            # for drivers without update_access() method support"},{"line_number":420,"context_line":"            # Does not support update access"},{"line_number":421,"context_line":"            self._update_access_fallback(context, add_rules, delete_rules,"},{"line_number":422,"context_line":"                                         rules_to_be_removed_from_db,"},{"line_number":423,"context_line":"                                         share_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"52123030_569edb51","line":420,"range":{"start_line":420,"start_character":14,"end_line":420,"end_character":44},"updated":"2024-12-18 10:40:51.000000000","message":"```suggestion\n            # It is also possible that updating the access_level is not permitted.\n```","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4015311dfa0a2ca4747002ee1b8abc868edb91a7","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        except NotImplementedError:"},{"line_number":418,"context_line":"            # NOTE(u_glide): Fallback to legacy allow_access/deny_access"},{"line_number":419,"context_line":"            # for drivers without update_access() method support"},{"line_number":420,"context_line":"            # Does not support update access"},{"line_number":421,"context_line":"            self._update_access_fallback(context, add_rules, delete_rules,"},{"line_number":422,"context_line":"                                         rules_to_be_removed_from_db,"},{"line_number":423,"context_line":"                                         share_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"efac693d_a360aaf8","line":420,"range":{"start_line":420,"start_character":14,"end_line":420,"end_character":44},"in_reply_to":"52123030_569edb51","updated":"2024-12-18 13:42:15.000000000","message":"Done","commit_id":"5d9d7e3371e27bf4eba1c6331afef9747572fb20"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    @ensure_server"},{"line_number":854,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":855,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":856,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        This driver has two different behaviors according to parameters:"}],"source_content_type":"text/x-python","patch_set":7,"id":"2604a122_01987971","line":855,"range":{"start_line":855,"start_character":36,"end_line":855,"end_character":48},"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add the doc string for this parameter, all other parameters has so please add for this also.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    @ensure_server"},{"line_number":854,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":855,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":856,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        This driver has two different behaviors according to parameters:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ee75159_dacf600d","line":855,"range":{"start_line":855,"start_character":36,"end_line":855,"end_character":48},"in_reply_to":"2604a122_01987971","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/drivers/glusterfs/layout.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        existent access rules and apply all access rules for given share."},{"line_number":125,"context_line":"        This recovery is made at driver start up."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        2. Adding/Deleting of several access rules - \u0027access_rules\u0027 contains"},{"line_number":128,"context_line":"        all access_rules, \u0027add_rules\u0027 and \u0027delete_rules\u0027 contain rules which"},{"line_number":129,"context_line":"        should be added/deleted. Driver can ignore rules in \u0027access_rules\u0027 and"},{"line_number":130,"context_line":"        apply only rules from \u0027add_rules\u0027 and \u0027delete_rules\u0027."},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":"        gluster_mgr \u003d self.layout._share_manager(share)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2348f300_c982b5c9","line":130,"range":{"start_line":127,"start_character":12,"end_line":130,"end_character":61},"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add the update detail in this.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        existent access rules and apply all access rules for given share."},{"line_number":125,"context_line":"        This recovery is made at driver start up."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        2. Adding/Deleting of several access rules - \u0027access_rules\u0027 contains"},{"line_number":128,"context_line":"        all access_rules, \u0027add_rules\u0027 and \u0027delete_rules\u0027 contain rules which"},{"line_number":129,"context_line":"        should be added/deleted. Driver can ignore rules in \u0027access_rules\u0027 and"},{"line_number":130,"context_line":"        apply only rules from \u0027add_rules\u0027 and \u0027delete_rules\u0027."},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":"        gluster_mgr \u003d self.layout._share_manager(share)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"326067d6_259bc673","line":130,"range":{"start_line":127,"start_character":12,"end_line":130,"end_character":61},"in_reply_to":"2348f300_c982b5c9","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/drivers/hitachi/hnas/driver.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":157,"context_line":"                           job_timeout)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":160,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":161,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param context: The `context.RequestContext` object for the request"}],"source_content_type":"text/x-python","patch_set":7,"id":"829105bb_c9731570","line":160,"range":{"start_line":160,"start_character":36,"end_line":160,"end_character":48},"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add the doc string for this.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                           job_timeout)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":160,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":161,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param context: The `context.RequestContext` object for the request"}],"source_content_type":"text/x-python","patch_set":7,"id":"3293503b_6fd9246a","line":160,"range":{"start_line":160,"start_character":36,"end_line":160,"end_character":48},"in_reply_to":"829105bb_c9731570","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/drivers/infortrend/driver.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        super(InfortrendNASDriver, self)._update_share_stats(data)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":133,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":134,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param context: Current context"}],"source_content_type":"text/x-python","patch_set":7,"id":"8258b728_c944e26c","line":133,"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add the doc string for this parameter.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        super(InfortrendNASDriver, self)._update_share_stats(data)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":133,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":134,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param context: Current context"}],"source_content_type":"text/x-python","patch_set":7,"id":"d27500b4_6de4c20b","line":133,"in_reply_to":"8258b728_c944e26c","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":367,"context_line":"            LOG.warning(exc)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":370,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":371,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        This driver has two different behaviors according to parameters:"}],"source_content_type":"text/x-python","patch_set":7,"id":"593eaeb5_f9ebd8d2","line":370,"range":{"start_line":370,"start_character":36,"end_line":370,"end_character":48},"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add doc string for this.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            LOG.warning(exc)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":370,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":371,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        This driver has two different behaviors according to parameters:"}],"source_content_type":"text/x-python","patch_set":7,"id":"8565d4b1_cb4034e5","line":370,"range":{"start_line":370,"start_character":36,"end_line":370,"end_character":48},"in_reply_to":"593eaeb5_f9ebd8d2","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/drivers/macrosan/macrosan_nas.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @debug_trace"},{"line_number":147,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":148,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":149,"context_line":"        \"\"\"Update access rules list."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        :param context: Current context"}],"source_content_type":"text/x-python","patch_set":7,"id":"7d4acf5e_ca4257cc","line":148,"range":{"start_line":148,"start_character":36,"end_line":148,"end_character":48},"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add doc string for this.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @debug_trace"},{"line_number":147,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":148,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":149,"context_line":"        \"\"\"Update access rules list."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        :param context: Current context"}],"source_content_type":"text/x-python","patch_set":7,"id":"588ad680_d6d66f73","line":148,"range":{"start_line":148,"start_character":36,"end_line":148,"end_character":48},"in_reply_to":"7d4acf5e_ca4257cc","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/drivers/nexenta/ns4/nexenta_nas.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        self.helper.delete_snapshot(snapshot[\u0027share_name\u0027], snapshot[\u0027name\u0027])"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":111,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":112,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param context: The `context.RequestContext` object for the request"}],"source_content_type":"text/x-python","patch_set":7,"id":"c769ce0b_8245b859","line":111,"range":{"start_line":111,"start_character":36,"end_line":111,"end_character":48},"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add the doc string for this parameter.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.helper.delete_snapshot(snapshot[\u0027share_name\u0027], snapshot[\u0027name\u0027])"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":111,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":112,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param context: The `context.RequestContext` object for the request"}],"source_content_type":"text/x-python","patch_set":7,"id":"5de6905a_169dc069","line":111,"range":{"start_line":111,"start_character":36,"end_line":111,"end_character":48},"in_reply_to":"c769ce0b_8245b859","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/drivers/nexenta/ns5/nexenta_nas.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        }]}"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":395,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":396,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        Using access_rules list for both adding and deleting rules."}],"source_content_type":"text/x-python","patch_set":7,"id":"0e0df8dd_470962f7","line":395,"range":{"start_line":395,"start_character":36,"end_line":395,"end_character":48},"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add doc string for this.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        }]}"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":395,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":396,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        Using access_rules list for both adding and deleting rules."}],"source_content_type":"text/x-python","patch_set":7,"id":"d6ac3bf4_032afd18","line":395,"range":{"start_line":395,"start_character":36,"end_line":395,"end_character":48},"in_reply_to":"0e0df8dd_470962f7","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/drivers/quobyte/quobyte.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3d47d6e701a6aa27418d6cec9831dc1acd517f36","unresolved":true,"context_lines":[{"line_number":365,"context_line":"        self._resize_share(share\u003dshrink_share, new_size\u003dshrink_size)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":368,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":369,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        Two different cases are supported in here:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1cb884ea_caa6e445","line":368,"range":{"start_line":368,"start_character":36,"end_line":368,"end_character":48},"updated":"2024-10-15 15:49:14.000000000","message":"nit: Add doc string for this.","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5a207e61753cfc98c3cc830dfc90705189252aae","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        self._resize_share(share\u003dshrink_share, new_size\u003dshrink_size)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":368,"context_line":"                      delete_rules, update_rules, share_server\u003dNone):"},{"line_number":369,"context_line":"        \"\"\"Update access rules for given share."},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        Two different cases are supported in here:"}],"source_content_type":"text/x-python","patch_set":7,"id":"c3f02ea9_f13b33e8","line":368,"range":{"start_line":368,"start_character":36,"end_line":368,"end_character":48},"in_reply_to":"1cb884ea_caa6e445","updated":"2024-10-16 08:21:52.000000000","message":"Done","commit_id":"f62ccd6a0da4df9a47365567d7d0a6e17f6e8ecf"}],"manila/share/manager.py":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"70ab505b0627fc1f3a55b1e6bc42b3be8eb22dd6","unresolved":true,"context_lines":[{"line_number":4446,"context_line":""},{"line_number":4447,"context_line":"    def update_access_for_instances(self, context, share_instance_ids,"},{"line_number":4448,"context_line":"                                    share_server_id\u003dNone):"},{"line_number":4449,"context_line":"        \"\"\"Allow/Deny access to shares that belong to the same share server.\"\"\""},{"line_number":4450,"context_line":"        share_server \u003d None"},{"line_number":4451,"context_line":"        if share_server_id:"},{"line_number":4452,"context_line":"            share_server \u003d self.db.share_server_get(context, share_server_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"d1de7806_d35893ac","line":4449,"range":{"start_line":4449,"start_character":11,"end_line":4449,"end_character":21},"updated":"2024-12-18 20:50:30.000000000","message":"nit: Should this be Access/Deny/Update?","commit_id":"d891d116d67ddf8012975fb19a16222752d9e7e8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9f1862e031d16d933d590232ba4022782600987a","unresolved":false,"context_lines":[{"line_number":4446,"context_line":""},{"line_number":4447,"context_line":"    def update_access_for_instances(self, context, share_instance_ids,"},{"line_number":4448,"context_line":"                                    share_server_id\u003dNone):"},{"line_number":4449,"context_line":"        \"\"\"Allow/Deny access to shares that belong to the same share server.\"\"\""},{"line_number":4450,"context_line":"        share_server \u003d None"},{"line_number":4451,"context_line":"        if share_server_id:"},{"line_number":4452,"context_line":"            share_server \u003d self.db.share_server_get(context, share_server_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"d873577d_e5a8e658","line":4449,"range":{"start_line":4449,"start_character":11,"end_line":4449,"end_character":21},"in_reply_to":"d1de7806_d35893ac","updated":"2025-01-02 14:55:28.000000000","message":"Done","commit_id":"d891d116d67ddf8012975fb19a16222752d9e7e8"}]}