)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Youssef \u003cbaataouiyoussef@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-06 21:43:57 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added a new shares.py file in the schema folder to handle"},{"line_number":8,"context_line":"schema-related logic for share objects. Modified shares.py"},{"line_number":9,"context_line":"in the api\\v2 folder to include new decorators methods that interact with"},{"line_number":10,"context_line":"the schema layer."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The changes ensure that shares follow the updated validation"},{"line_number":13,"context_line":"rules and improve the handling of share objects across the"},{"line_number":14,"context_line":"application."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4521bb653ee5694be58e71cc5373c1ec7d9418b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0968be49_9c5025b8","line":14,"range":{"start_line":7,"start_character":0,"end_line":14,"end_character":12},"updated":"2024-10-07 16:17:03.000000000","message":"As Takashi mentioned on IRC; we recommend good commit message hygiene to keep things sane in community driven software development: \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\n\nThere\u0027s no need to tell us _what_ you did; just _why_ would suffice.. For example:\n\n\"\"\"\nAdd JSON schema validation to share-extend API\n\nSchemas are added to validate all v2 versions of the API.\n\n\"\"\"","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62e8f997_28f2de49","updated":"2024-10-07 16:17:03.000000000","message":"Great start here, Youssef! \n\nAs you can see; \"Zuul\" - the community\u0027s Continuous Integration System has tested your change and shared test failures; we can dive through them - however, some of these can be identified through code review. Please take a look at my comments inline. \n\nA test failure from one of the several jobs that failed is here:\n\nhttps://e9bcfc635397bc0a3785-9ea232b51691ad27ed2d3f8993736155.ssl.cf2.rackcdn.com/931596/1/check/manila-tempest-plugin-dummy-no-dhss/b16f249/testr_results.html","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"}],"manila/api/schemas/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from oslo_config import cfg\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"from manila.api.validation import parameter_types\r"},{"line_number":18,"context_line":"\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"CONF \u003d cfg.CONF\r"},{"line_number":21,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfd86b6b_5d230a4e","line":18,"updated":"2024-10-07 16:17:03.000000000","message":"Looks like you have Windows Style Line Endings enabled in your local environment; please fix that: \n\n```\ngit config --global core.autocrlf true\n```","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    }\r"},{"line_number":34,"context_line":"}\r"},{"line_number":35,"context_line":"\r"},{"line_number":36,"context_line":"#This is for version(\u00272.7\u0027, \u00272.63\u0027)\r"},{"line_number":37,"context_line":"extend_request_body_v27_to_v263 \u003d copy.deepcopy(extend_request_body)\r"},{"line_number":38,"context_line":"\r"},{"line_number":39,"context_line":"#This is for version(\u00272.64\u0027)\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"c01969e8_d57e8a91","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":36},"updated":"2024-10-07 16:17:03.000000000","message":"no need for these comments; you\u0027ve named the schemas well enough to understand","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\r"},{"line_number":39,"context_line":"#This is for version(\u00272.64\u0027)\r"},{"line_number":40,"context_line":"extend_request_body_v264 \u003d copy.deepcopy(extend_request_body)\r"},{"line_number":41,"context_line":"extend_request_body_v264[\u0027properties\u0027].update({\r"},{"line_number":42,"context_line":"    \u0027force\u0027: parameter_types.boolean\r"},{"line_number":43,"context_line":"})\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3a10adf_150d9327","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":38},"updated":"2024-10-07 16:17:03.000000000","message":"```suggestion\nextend_request_body_v264[\u0027properties\u0027][\u0027extend\u0027][\u0027properties\u0027].update({\n```","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"}],"manila/api/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":true,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":528,"context_line":"    @wsgi.action(\u0027os-extend\u0027)"},{"line_number":529,"context_line":"    # new validation add"},{"line_number":530,"context_line":"    @validation.request_body_schema(share_schema.extend_request_body)"},{"line_number":531,"context_line":"    def extend_legacy(self, req, id, body):"},{"line_number":532,"context_line":"        \"\"\"Extend size of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"29877bf9_55f49e68","line":529,"range":{"start_line":529,"start_character":0,"end_line":529,"end_character":24},"updated":"2024-10-07 16:17:03.000000000","message":"please remove","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":true,"context_lines":[{"line_number":530,"context_line":"    @validation.request_body_schema(share_schema.extend_request_body)"},{"line_number":531,"context_line":"    def extend_legacy(self, req, id, body):"},{"line_number":532,"context_line":"        \"\"\"Extend size of a share.\"\"\""},{"line_number":533,"context_line":"        body.get(\u0027os-extend\u0027, {}).pop(\u0027force\u0027, None)"},{"line_number":534,"context_line":"        return self._extend(req, id, body)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    @wsgi.Controller.api_version(\u00272.7\u0027, \u00272.63\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b297e91d_d154f1c8","line":533,"range":{"start_line":533,"start_character":18,"end_line":533,"end_character":27},"updated":"2024-10-07 16:17:03.000000000","message":"this needs a third schema because the API prior to version 2.7 accepts \"os-extend\" instead of \"extend\" as the top level key","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":true,"context_lines":[{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    @wsgi.Controller.api_version(\u00272.7\u0027, \u00272.63\u0027)"},{"line_number":537,"context_line":"    @wsgi.action(\u0027extend\u0027)"},{"line_number":538,"context_line":"    # # new validation add"},{"line_number":539,"context_line":"    @validation.request_body_schema(share_schema.extend_request_body_v27_to_v263)"},{"line_number":540,"context_line":"    def extend(self, req, id, body):"},{"line_number":541,"context_line":"        \"\"\"Extend size of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"c1fbbe36_c1980b6b","line":538,"range":{"start_line":538,"start_character":0,"end_line":538,"end_character":26},"updated":"2024-10-07 16:17:03.000000000","message":"please remove","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4d15d2a430bb5c01143e638fc14b39529551611","unresolved":true,"context_lines":[{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    @wsgi.Controller.api_version(\u00272.64\u0027)  # noqa"},{"line_number":546,"context_line":"    @wsgi.action(\u0027extend\u0027)"},{"line_number":547,"context_line":"    # new validation add"},{"line_number":548,"context_line":"    @validation.request_body_schema(share_schema.extend_request_body_v264)"},{"line_number":549,"context_line":"    def extend(self, req, id, body):  # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":550,"context_line":"        \"\"\"Extend size of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9de0429e_199e922d","line":547,"range":{"start_line":547,"start_character":0,"end_line":547,"end_character":24},"updated":"2024-10-07 16:17:03.000000000","message":"please remove","commit_id":"96e2751a1d16b81383cbe4ff612426d28338dc86"}]}